Publish DEPS for 106.0.5249.9
Incrementing VERSION to 106.0.5249.9
Change-Id: I10736661b7008dfce0cc83851c8b6cd6ea1fc723
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3853223
Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/5249@{#73}
Cr-Branched-From: 4f7bea5de862aaa52e6bde5920755a9ef9db120b-refs/heads/main@{#1036826}
[Journeys] Focus and show keyboard when starting search with empty text
(cherry picked from commit 74983e5a06e076f0f3cc05b266cd3102c1c2fc4b)
Bug: 1354041
Change-Id: I9999bb1b05c43a8e20336af9f77d684cedcb71e6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3840626
Reviewed-by: Gang Wu <[email protected]>
Commit-Queue: Patrick Noland <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1037828}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3852981
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/5249@{#72}
Cr-Branched-From: 4f7bea5de862aaa52e6bde5920755a9ef9db120b-refs/heads/main@{#1036826}
WebView: Don't call shouldOverrideUrlLoading for uuid-in-package iframes
Before this, subframe navigations to uuid-in-package: URLs in WebView
were aborted unless a WebViewClient was provided and its
shouldOverrideUrlLoading() returned false for uuid-in-package: URLs.
Since uuid-in-package: iframe navigation with WebBundles is part of web
platform feature, we should skip calling shouldOverrideUrlLoading() for
uuid-in-package: subframe navigations, as with http and https URLs.
(cherry picked from commit 61cfd8874fa55ec823247ec7aa4b5afa3452d7a5)
Bug: 1354434
Change-Id: Ie8eea33f2e7e5efa72d85e8017a7a39ecdf749a1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3840385
Reviewed-by: Richard Coles <[email protected]>
Commit-Queue: Kunihiko Sakamoto <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1038045}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3853921
Reviewed-by: Krishna Govind <[email protected]>
Commit-Queue: Krishna Govind <[email protected]>
Owners-Override: Krishna Govind <[email protected]>
Cr-Commit-Position: refs/branch-heads/5249@{#71}
Cr-Branched-From: 4f7bea5de862aaa52e6bde5920755a9ef9db120b-refs/heads/main@{#1036826}
[iOS][Omnibox] Limit URL matches
We are conducting a experiment to increase the number of ZPS matches in
NTP. It also increased the number of suggestions in SPR/Web states which
was not intended.
The extra suggestions shown in SRP/Web states are URL suggestions,
this CL limit the number of URL matches to limit the number of suggestions shown in those states.
Update with correct MaxURLMatches value.
(cherry picked from commit 9f18bf00b471e530eba43ca08eb4cd6f5a58791e)
Bug: 1353742
Change-Id: I4d500885b5f1827efe8e6436b71eb33c1d4fccd4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3849928
Commit-Queue: Tomasz Wiszkowski <[email protected]>
Reviewed-by: Tomasz Wiszkowski <[email protected]>
Auto-Submit: Christian Xu <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1038370}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3853881
Cr-Commit-Position: refs/branch-heads/5249@{#70}
Cr-Branched-From: 4f7bea5de862aaa52e6bde5920755a9ef9db120b-refs/heads/main@{#1036826}
[Password Manager] Record metrics for failed imports.
Recording metrics for individual credentials and the entire import flow.
(cherry picked from commit f40a35ef848de2f3b473af90946fa5ccfdb6b3d7)
Bug: 1325290
Change-Id: I3ccd4037a7566e5169d4a5cd492240ee161e37de
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3845187
Reviewed-by: Vasilii Sukhanov <[email protected]>
Commit-Queue: Elias Khsheibun <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1037850}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3854183
Auto-Submit: Elias Khsheibun <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/5249@{#69}
Cr-Branched-From: 4f7bea5de862aaa52e6bde5920755a9ef9db120b-refs/heads/main@{#1036826}
[Passwords Import] Handle MAX_FILE_SIZE gracefully
This CL adds graceful handling of the status, that have been already
implemented on the backend, but was not included in mocks yet.
(cherry picked from commit 0a18357027f2f7b1348ce20fb9eab5411a289e18)
Bug: 1355796
Change-Id: Icdcb727193bb4f3a904cc0e1a7ed12133aa686d0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3849607
Commit-Queue: Viktor Semeniuk <[email protected]>
Auto-Submit: Andrii Natiahlyi <[email protected]>
Reviewed-by: Viktor Semeniuk <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1038679}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3852962
Auto-Submit: Elias Khsheibun <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/5249@{#68}
Cr-Branched-From: 4f7bea5de862aaa52e6bde5920755a9ef9db120b-refs/heads/main@{#1036826}
Revert "Use D3DImageBacking for more GMB formats"
This reverts commit 4bb44428c79c67f7aa299a4e341a4e6a7f010d72.
Reason for revert: Memory regressions https://crbug.com/1354060
Original change's description:
> Use D3DImageBacking for more GMB formats
>
> Some shared memory GMBs, eg. software video decode, are currently using
> GLImageBacking rather than D3DImageBacking on Windows. If
> D3DImageBacking supports the GMB format then use that instead.
>
> Bug: 1293509
> Change-Id: I139e90269951519fa76aa5119da121969e9912a3
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832932
> Commit-Queue: Kyle Charbonneau <[email protected]>
> Reviewed-by: Sunny Sachanandani <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1036253}
(cherry picked from commit 9a5f5cfa6f333400448d02030353ab62cf4e227c)
Bug: 1293509, 1354060
Change-Id: I13f24b41d32433af4dfd2864dc5f9827f2a61056
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3846023
Commit-Queue: Kyle Charbonneau <[email protected]>
Reviewed-by: Sunny Sachanandani <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1037898}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3852025
Cr-Commit-Position: refs/branch-heads/5249@{#67}
Cr-Branched-From: 4f7bea5de862aaa52e6bde5920755a9ef9db120b-refs/heads/main@{#1036826}
More lacros investigative logging
The intent is to have more details about when the command to
show some UI might be stuck or successfully sent.
(cherry picked from commit 7c2c808c6ab1950a848acd106bc35b4b3530f87b)
Bug: 1340791
Change-Id: I3acfa7b8d1758c62dafe13981d3dc567a8cfa9e8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3841933
Reviewed-by: Erik Chen <[email protected]>
Commit-Queue: Alex Ilin <[email protected]>
Reviewed-by: Alex Ilin <[email protected]>
Auto-Submit: Nicolas Dossou-Gbété <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1037149}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3854141
Commit-Queue: Nicolas Dossou-Gbété <[email protected]>
Reviewed-by: David Roger <[email protected]>
Cr-Commit-Position: refs/branch-heads/5249@{#66}
Cr-Branched-From: 4f7bea5de862aaa52e6bde5920755a9ef9db120b-refs/heads/main@{#1036826}
[Private Network Access] Doom cache and send request to network if cache fails PNA check
Context: By default, the private network policy blocks http requests made from public IP address space to private/local IP address space.
The bug we're trying to fix is: Initially, a site and its resource have private or local IP. We load it and cached the resource (private to private or local to local is allowed). Then, because of VPN, the site and its resource now have public IPs. We expect to still be able to access the resource because public to public is also allowed. However, because of the cache, the browser mistakenly thinks that a public site is trying to access a private resource, and the fetch fails.
Our solution is, if the cached response is blocked by the private network policy, we doom the cache and attempt to load it from the network. If the browser finds that the resource is now also in the public space, the request will succeed. If the resource is still in the private or local space, the request will still fail. (This is tested by this test case https://source.chromium.org/chromium/chromium/src/+/main:content/browser/renderer_host/private_network_access_browsertest.cc;l=3410-3433;drc=36c59c53be1d8852f5087008c45a95797bac9730;bpv=1;bpt=1?q=private_network_access_browser&ss=chromium%2Fchromium%2Fsrc)
(cherry picked from commit 2ea57440c86937b27cc972452500b1ace6f46466)
Bug: 1350026, 1352591
Change-Id: I51226d3b379fa946aed0fb96feedfb5d775af789
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834586
Commit-Queue: Jonathan Hao <[email protected]>
Reviewed-by: Maks Orlovich <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1037754}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3851521
Commit-Queue: Maks Orlovich <[email protected]>
Auto-Submit: Jonathan Hao <[email protected]>
Cr-Commit-Position: refs/branch-heads/5249@{#65}
Cr-Branched-From: 4f7bea5de862aaa52e6bde5920755a9ef9db120b-refs/heads/main@{#1036826}
[M106]Create histogram to track add account process in Android Chrome
This cl adds a histogram to record states in add account process
launched from Android Chrome.
This cl only records the histogram from SyncConsentFragment add
account entry point. Other entry points will be added in subsequent
cls.
(cherry picked from commit 4d70768fcdfd9ee80f4fc304cb079a57fc30748f)
Bug: 1351315
Change-Id: I7f0c72ff9825c900d448ffd505cb019fbbef0a1a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834460
Reviewed-by: Alex Ilin <[email protected]>
Commit-Queue: Tanmoy Mollik <[email protected]>
Reviewed-by: Boris Sazonov <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1037804}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3850842
Commit-Queue: Boris Sazonov <[email protected]>
Reviewed-by: Tanmoy Mollik <[email protected]>
Cr-Commit-Position: refs/branch-heads/5249@{#64}
Cr-Branched-From: 4f7bea5de862aaa52e6bde5920755a9ef9db120b-refs/heads/main@{#1036826}
[iOS] Fix horizontal margins in Incognito interstitial
A new `titleHorizontalMargin` property is added to Promo style view
controller to enable customisation of margins around the title label.
If not set before view loads, it defaults to `kTitleHorizontalMargin`.
A new `stackViewHorizontalMargin` argument is added to the designated
initialisers of revamped and non-revamped Incognito views to customise
margins of the Incognito views as well.
Incognito view bouncing is disabled in Incognito interstitial as well
since this scroll view is not even supposed to be scrollable (it is
constrained to have the same height as its content).
(cherry picked from commit 18cd43b3534f8d8a82c8a8d044ae91bf3a353452)
Bug: 1355292
Change-Id: I3656cdacca4be8cc43a9f0a12d998d4f9c06874c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3845534
Reviewed-by: Gauthier Ambard <[email protected]>
Reviewed-by: Sylvain Defresne <[email protected]>
Commit-Queue: Quentin Pubert <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1038158}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3854437
Bot-Commit: Rubber Stamper <[email protected]>
Auto-Submit: Quentin Pubert <[email protected]>
Commit-Queue: Sylvain Defresne <[email protected]>
Cr-Commit-Position: refs/branch-heads/5249@{#63}
Cr-Branched-From: 4f7bea5de862aaa52e6bde5920755a9ef9db120b-refs/heads/main@{#1036826}
[Passwords Import] Handle all results & entry statuses
This CL adds graceful handling of statuses, that have been already
implemented on the backend, but were not included in mocks yet.
(cherry picked from commit f3e94a589e355f08de42ce14978a319e29555e05)
Bug: 1325290
Change-Id: If155d9122a1652ebb02227632d2336b229dfd39a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3841305
Commit-Queue: Andrii Natiahlyi <[email protected]>
Reviewed-by: Mohamed Amir Yosef <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1037261}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3854142
Commit-Queue: Mohamed Amir Yosef <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Auto-Submit: Elias Khsheibun <[email protected]>
Cr-Commit-Position: refs/branch-heads/5249@{#62}
Cr-Branched-From: 4f7bea5de862aaa52e6bde5920755a9ef9db120b-refs/heads/main@{#1036826}
[Password Manager] Check and report errors & conflicts during import.
This change populates the response callback (ImportResults) when the import operation is done.
Also, for the url field, the mojo interface of the csv_password_parser is extended to provide an invalid_url in case the parsed GURL is invalid. The reasoning is that the actual input data is needed when an input URL is invalid and in GURL the original input is lost in case the of an invalid input.
(cherry picked from commit 8dcaef0b408d372b0b0932652e7f46b83bcabf1c)
Bug: 1325290
Change-Id: I7e1f9aa4c346e0bbd392826f3551620816e0febf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3827417
Reviewed-by: Mohamed Amir Yosef <[email protected]>
Commit-Queue: Elias Khsheibun <[email protected]>
Reviewed-by: Alex Gough <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1037412}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3854221
Auto-Submit: Elias Khsheibun <[email protected]>
Reviewed-by: Mike West <[email protected]>
Commit-Queue: Mike West <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/5249@{#61}
Cr-Branched-From: 4f7bea5de862aaa52e6bde5920755a9ef9db120b-refs/heads/main@{#1036826}
[iOS] CBD updates footer on sign-in/sign-out
Tested:
* Enable/Disable Enable-cbd-sign-out
* restart
* open an ipad with two window
* in one window, open CBD
* in the other sign-in/out.
* Check that the footer updates (in enabled case) or don’t change (in disabled case) as expected
(cherry picked from commit 42320dee69518cd21bea9c9338f2ad999fa3575e)
Fixed: 1343749
Change-Id: Id9b1bcdc8d129740d6e463b081496ad0b1e3e5fd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3836814
Commit-Queue: Jérôme Lebel <[email protected]>
Reviewed-by: Jérôme Lebel <[email protected]>
Auto-Submit: Arthur Milchior <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1037621}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3848170
Commit-Queue: Arthur Milchior <[email protected]>
Cr-Commit-Position: refs/branch-heads/5249@{#60}
Cr-Branched-From: 4f7bea5de862aaa52e6bde5920755a9ef9db120b-refs/heads/main@{#1036826}
Integrate Private Aggregation API with privacy sandbox settings
Ensures that the Private Aggregation API is only allowed in the
appropriate contexts.
(cherry picked from commit 7d5c8e1df5392d3e8b45797c8a5031ac24b63ccd)
Bug: 1353526
Change-Id: I13fb901635ca1e31dbbb5807ea94a17c7777e7ff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834196
Reviewed-by: Yao Xiao <[email protected]>
Auto-Submit: Alex Turner <[email protected]>
Commit-Queue: Avi Drissman <[email protected]>
Reviewed-by: Avi Drissman <[email protected]>
Reviewed-by: John Delaney <[email protected]>
Reviewed-by: Theodore Olsauskas-Warren <[email protected]>
Reviewed-by: Russ Hamilton <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1037207}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3851421
Commit-Queue: Theodore Olsauskas-Warren <[email protected]>
Reviewed-by: Qingxin Wu <[email protected]>
Cr-Commit-Position: refs/branch-heads/5249@{#59}
Cr-Branched-From: 4f7bea5de862aaa52e6bde5920755a9ef9db120b-refs/heads/main@{#1036826}
[Merge to 106][RDSD] Add feature engagement for the RDS app menu setting
(cherry picked from commit 176d55963e8543ac8cac12ebb12709856e923488)
Bug: 1353597
Change-Id: I43b96d830ff4e31144e0cc5f94c7395d1e2c4ccd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3840402
Reviewed-by: Shu Yang <[email protected]>
Commit-Queue: Aishwarya Rajesh <[email protected]>
Reviewed-by: Theresa Sullivan <[email protected]>
Reviewed-by: Alexei Svitkine <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1037825}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3852961
Reviewed-by: Weilun Shi <[email protected]>
Cr-Commit-Position: refs/branch-heads/5249@{#58}
Cr-Branched-From: 4f7bea5de862aaa52e6bde5920755a9ef9db120b-refs/heads/main@{#1036826}
Incrementing VERSION to 106.0.5249.8
Change-Id: I780cd24731b1445b8d0da839102f304a7a9d3f34
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3853201
Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/5249@{#57}
Cr-Branched-From: 4f7bea5de862aaa52e6bde5920755a9ef9db120b-refs/heads/main@{#1036826}
[TabSwitcher] Use total tab count for tab stack button instead of tab group count
Based on discussions with product and UX, we want to change the tab stack button count from "tab group count + non-tab group count" to "total tab count irrespective of groups"
(cherry picked from commit efc42e99ce3bb7e12b66ed0428614dd943c0a1ad)
Bug: 1353171
Change-Id: I7ca05c7f99cbecf0358fac38f3235afbd9a5330f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3827359
Reviewed-by: Theresa Sullivan <[email protected]>
Commit-Queue: Sirisha Kavuluru <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1037984}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3852941
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/5249@{#56}
Cr-Branched-From: 4f7bea5de862aaa52e6bde5920755a9ef9db120b-refs/heads/main@{#1036826}
Merge 106: Avoid possible out-of-bounds array access
Speculative fix for rare crash. It's probable that firing the event
on the parent somehow caused its children to be invalidated.
(cherry picked from commit 2cfa10325f997e7cbdbd3dce34d0171bd0dea07e)
Bug: 1352653
Change-Id: Ib69d2bd5491099e4795d4b098662d0278b48f2a4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3846096
Reviewed-by: Daniel Libby <[email protected]>
Auto-Submit: Aaron Leventhal <[email protected]>
Commit-Queue: Daniel Libby <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1037960}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3852861
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/5249@{#55}
Cr-Branched-From: 4f7bea5de862aaa52e6bde5920755a9ef9db120b-refs/heads/main@{#1036826}
Revert "Cache whether scroll animating element was removed by commit."
This reverts commit f5512dfefbdbe7ad218be8ccf57569da64a309e9.
Reason for revert: performance regression scrolling on gmail.
Original change's description:
> Cache whether scroll animating element was removed by commit.
>
> This change:
>
> * notifies the AnimationHost whether or not the scroll animating element
> is currently animating, and
>
> * caches that the scroll animation element has been removed by commit,
> in case the animation restarts.
>
> Fixed: 1341219
> Bug: 900241, 1347679
> Change-Id: Ie8d154bdd430031480e32a943bcd71dd2ab21313
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3813083
> Reviewed-by: Robert Flack <[email protected]>
> Commit-Queue: Robert Flack <[email protected]>
> Auto-Submit: David Baron <[email protected]>
> Commit-Queue: David Baron <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1033685}
(cherry picked from commit 1e67c3669d2cdde7a70b517ba9631e6e3eacacf9)
Bug: 900241, 1347679
Change-Id: I9f95b9a8b254beee1ffe763524606e4497d4ce05
Fixed: 1354807
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3846211
Auto-Submit: David Baron <[email protected]>
Commit-Queue: David Baron <[email protected]>
Reviewed-by: Xianzhu Wang <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1038020}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3846194
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/5249@{#54}
Cr-Branched-From: 4f7bea5de862aaa52e6bde5920755a9ef9db120b-refs/heads/main@{#1036826}
Refresh Public Suffix List to the latest version.
(cherry picked from commit 53112b99cc992796e63f912536c63dffc6e2b3ab)
Change-Id: I4ade6932969233cd03a79757445b3ae89bc80d73
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3845178
Reviewed-by: Peter Kasting <[email protected]>
Commit-Queue: Peter Kasting <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1037724}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3851063
Auto-Submit: Peter Kasting <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/5249@{#53}
Cr-Branched-From: 4f7bea5de862aaa52e6bde5920755a9ef9db120b-refs/heads/main@{#1036826}
[M106]Reland "Reland "Add Tangible sync flow for signin row in main settings""
This reverts commit ff9407ba3cae86cfc2e59388a9e2d6c4282a7182.
Reason for revert: The sign-in row is hidden when promos are shown if
none of SYNC_ANDROID_PROMOS_WITH_ILLUSTRATION, SYNC_ANDROID_PROMOS_WITH_SINGLE_BUTTON or SYNC_ANDROID_PROMOS_WITH_TITLE is enabled.
This cl uses one of these flags - SYNC_ANDROID_PROMOS_WITH_SINGLE_BUTTON - to fix the tests.
Original change's description:
> Revert "Reland "Add Tangible sync flow for signin row in main settings""
>
> This reverts commit df177914f44a95fafbd73b7ec8d5bca732160aa1.
>
> Reason for revert: Failing bots for another reason
> https://bugs.chromium.org/p/chromium/issues/detail?id=1353505
>
> Original change's description:
> > Reland "Add Tangible sync flow for signin row in main settings"
> >
> > This reverts commit 7935edc2e4d5a7d963df448334f565695f39a2c1.
> >
> > Reason for revert:
> > Fixes the tests. Sync promo uses the same string as the signin
> > preference when there are no accounts.
> > In order to fix the tests an account is added to the device so that
> > the promo has a different text.
> >
> > Original change's description:
> > > Revert "Add Tangible sync flow for signin row in main settings"
> > >
> > > This reverts commit 4cee9379113bfc4c729d491143793be5192b49df.
> > >
> > > Reason for revert: newly added tests fail on bots (see
> > > https://crbug.com/1353505).
> > >
> > > Original change's description:
> > > > Add Tangible sync flow for signin row in main settings
> > > >
> > > > This cl adds the tangible sync flow launch capability to the signin
> > > > preference in main settings page. This flow is guarded by a flag.
> > > >
> > > > Bug: 1332527
> > > > Change-Id: I9222fa0512e1fcd55a012a9fa37853a9b66b0226
> > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3819763
> > > > Reviewed-by: Boris Sazonov <[email protected]>
> > > > Commit-Queue: Tanmoy Mollik <[email protected]>
> > > > Cr-Commit-Position: refs/heads/main@{#1035435}
> > >
> > > Bug: 1332527, 1353505
> > > Change-Id: I6e82abcd635da0999b0c7752c77d0ef08986f193
> > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834451
> > > Commit-Queue: Rubber Stamper <[email protected]>
> > > Auto-Submit: Boris Sazonov <[email protected]>
> > > Bot-Commit: Rubber Stamper <[email protected]>
> > > Cr-Commit-Position: refs/heads/main@{#1035761}
> >
> > Bug: 1332527, 1353505
> > Change-Id: I387ba7a5c31e28a8f82726af53ac68c76ced6487
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834251
> > Reviewed-by: Boris Sazonov <[email protected]>
> > Commit-Queue: Tanmoy Mollik <[email protected]>
> > Cr-Commit-Position: refs/heads/main@{#1036573}
>
> Bug: 1332527, 1353505
> Change-Id: Icd2b88b2d67bf945edc006e09629633a75680541
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3838475
> Commit-Queue: Lijin Shen <[email protected]>
> Bot-Commit: Rubber Stamper <[email protected]>
> Owners-Override: Lijin Shen <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1036813}
(cherry picked from commit 0955f0f218fbd7a02043afe4a2151a831835cc3a)
Bug: 1332527, 1353505
Change-Id: I0ba69c3047a91f01ac508d277a1c30797cd9a97e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3845610
Reviewed-by: Boris Sazonov <[email protected]>
Commit-Queue: Tanmoy Mollik <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1037803}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3851522
Auto-Submit: Boris Sazonov <[email protected]>
Commit-Queue: Boris Sazonov <[email protected]>
Reviewed-by: Tanmoy Mollik <[email protected]>
Cr-Commit-Position: refs/branch-heads/5249@{#52}
Cr-Branched-From: 4f7bea5de862aaa52e6bde5920755a9ef9db120b-refs/heads/main@{#1036826}
[iOS] Only add profile image to standard signin promo view
(cherry picked from commit c15c1acb312e5605f93987cfc547b1f6e748e10f)
Bug: 1331010
Change-Id: I04e1a1ca9e1a43d5c9756c1a0a481ec62f572d33
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3841663
Commit-Queue: Jérôme Lebel <[email protected]>
Auto-Submit: Adam Arcaro <[email protected]>
Reviewed-by: Jérôme Lebel <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1038142}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3851701
Commit-Queue: Sergio Collazos <[email protected]>
Reviewed-by: Sergio Collazos <[email protected]>
Commit-Queue: Adam Arcaro <[email protected]>
Cr-Commit-Position: refs/branch-heads/5249@{#51}
Cr-Branched-From: 4f7bea5de862aaa52e6bde5920755a9ef9db120b-refs/heads/main@{#1036826}
[M106]Add a method to tweak add account flow result in FakeAccountManagerFacade for tests
This cl adds a new method in FakeAccountManagerFacade that will let
testing add account flow in chrome more easier. This method allows
tests to tweak the results of the add account flow.
This cl also migrates some test suites to use this method.
(cherry picked from commit 9ec29e290b27e1ba247fdae7bd8a33e6fd7aa9d6)
Bug: 1351315
Change-Id: Ib90f8d9117c71b8e9bc1907d2ebefc686e274177
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3842170
Commit-Queue: Tanmoy Mollik <[email protected]>
Reviewed-by: Boris Sazonov <[email protected]>
Auto-Submit: Tanmoy Mollik <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1037714}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3850922
Commit-Queue: Boris Sazonov <[email protected]>
Auto-Submit: Boris Sazonov <[email protected]>
Reviewed-by: Tanmoy Mollik <[email protected]>
Cr-Commit-Position: refs/branch-heads/5249@{#50}
Cr-Branched-From: 4f7bea5de862aaa52e6bde5920755a9ef9db120b-refs/heads/main@{#1036826}
[M106 Merge][side search] Add feature engagement for autotriggering
This CL integrates the autotriggering side search side panel feature
with the feature egagement backend. This is only done for the unified
side panel as experimentation will happen after this feature has
fully rolled out.
ShouldAutomaticallyTriggerAfterNavigation() has been added to the
unified side panel controller to determine whether or not we should
attempt to automatically trigger the side panel based on the
following conditions:
1. The associated tab is the currently active browser tab
2. The side panel is not currently open to side search
3. The navigation is renderer initiated (i.e. not an omnibox
or bookmark navigation)
4. We have navigated back to the same SRP within the tab 2
number of times (default, configurable by finch param)
5. The currently committed navigation is the first navigation
away from the SRP
The automatic triggering behavior is also configurable via the
feature engagement backend. This can be used to control the
window in which auto-triggering is reattempted and how frequently
this occurs.
int returned_to_previous_srp_count() has also replaced
bool returned_to_previous_srp() in the tab helper to allow for
count based (rather than boolean based) tracking for the number
of times users return to the same SRP.
To test enable IPH_SideSearchAutoTriggering as the
in-product-help-demo-mode-choice in chrome://flags and use the
following on the command line (ignore the newlines):
--enable-features=
SideSearch,
SideSearchDSESupport,
UnifiedSidePanel,
SideSearchAutoTriggering:SideSearchAutoTriggeringReturnCount/1
Follow up will add additional metrics and tests.
(cherry picked from commit 35268cac07a9bad2747f2ff6a4ccc222e1800672)
Bug: 1354016
Change-Id: Id6890e0dbe045a55137d07f311d498da62839454
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3835658
Commit-Queue: Thomas Lukaszewicz <[email protected]>
Reviewed-by: Yuheng Huang <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1037325}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3850822
Cr-Commit-Position: refs/branch-heads/5249@{#49}
Cr-Branched-From: 4f7bea5de862aaa52e6bde5920755a9ef9db120b-refs/heads/main@{#1036826}
[M106] rgbkbd: show nudge only if device is supported
Fix a bug where the nudge was shown incorrectly for the devices that do
not have rgb capability.
BUG=b/243435252
TEST=Manually
(cherry picked from commit 747e99b047b87f9afb1efe7cc602880cd0e327cd)
Change-Id: I9af89f66a00a0933bb66240e579076f9cfa181da
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3848706
Reviewed-by: James Cook <[email protected]>
Commit-Queue: Jason Thai <[email protected]>
Auto-Submit: Jason Thai <[email protected]>
Commit-Queue: James Cook <[email protected]>
Quick-Run: Jason Thai <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1038027}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3851661
Cr-Commit-Position: refs/branch-heads/5249@{#48}
Cr-Branched-From: 4f7bea5de862aaa52e6bde5920755a9ef9db120b-refs/heads/main@{#1036826}
[M106][Android] Don't use landscape layout on large screens
On large and extra-large displays, FirstRunActivity is displayed
within a dialog (due to using DialogWhenLarge theme).
This CL suppresses landscape layouts for FRE views if the dialog is
used (as the dialog always has portrait proportions).
(cherry picked from commit 045a42eacafccdf65f2294503e78ecd9bcfef94e)
Bug: 1350917
Change-Id: Ib9534ff4bb7cd001b0e885477726cede8c38d009
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3845163
Commit-Queue: Tanmoy Mollik <[email protected]>
Auto-Submit: Boris Sazonov <[email protected]>
Reviewed-by: Tanmoy Mollik <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1037699}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3850119
Owners-Override: Krishna Govind <[email protected]>
Commit-Queue: Boris Sazonov <[email protected]>
Reviewed-by: Krishna Govind <[email protected]>
Commit-Queue: Krishna Govind <[email protected]>
Cr-Commit-Position: refs/branch-heads/5249@{#47}
Cr-Branched-From: 4f7bea5de862aaa52e6bde5920755a9ef9db120b-refs/heads/main@{#1036826}
[PhotoPicker]: Extend video support flag.
(Cherry pick to M106 branch.)
The feature has been launched, so the flag is now
enabled by default, but we'd like to keep the flag
as a kill-switch in case something comes up with
the launch.
(cherry picked from commit 9440c1d8a8069cae20b599ba9ce9b0a98e688c93)
Bug: None
Change-Id: Ie5645aade1f5452beae1866d1553e763cec26f4b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3846032
Commit-Queue: Finnur Thorarinsson <[email protected]>
Reviewed-by: Rayan Kanso <[email protected]>
Commit-Queue: Rayan Kanso <[email protected]>
Auto-Submit: Finnur Thorarinsson <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1037820}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3850022
Cr-Commit-Position: refs/branch-heads/5249@{#46}
Cr-Branched-From: 4f7bea5de862aaa52e6bde5920755a9ef9db120b-refs/heads/main@{#1036826}
[Merge to M106] ios: Fix crash when adding bookmark from incognito.
The on-the-record BookmarkIneractionController is always used when
adding or editing bookmarks. A refactor in crrev.com/c/3755541 changed
the logic to use the on-the-record WebState (which can be null) when
determining the title and URL for a bookmark.
Instead, pass a BookmarkAddCommand with the correct WebState.
(cherry picked from commit f69798c6b4b87084eb9a894b7a8f7be7e237ae5b)
Fixed: 1353114
Change-Id: Iadf8de4445ad24e059d1889f5ac503d2887f81ae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3846908
Auto-Submit: Justin Cohen <[email protected]>
Commit-Queue: Rohit Rao <[email protected]>
Commit-Queue: Justin Cohen <[email protected]>
Reviewed-by: Rohit Rao <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1038084}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3846564
Owners-Override: Krishna Govind <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Reviewed-by: Krishna Govind <[email protected]>
Auto-Submit: Krishna Govind <[email protected]>
Commit-Queue: Krishna Govind <[email protected]>
Cr-Commit-Position: refs/branch-heads/5249@{#45}
Cr-Branched-From: 4f7bea5de862aaa52e6bde5920755a9ef9db120b-refs/heads/main@{#1036826}
[M106][Android] Use CrashKeyString to tag FRE crashes
If Chrome is started and the FRE is not completed yet - tag crashes
happening in this session with "first_run": "yes". This is consistent
with iOS, where crashes from the first run are tagged with
"first-run": "yes". This information is helpful to analyze stability
of FRE-related launches and should give us more info about the flow
that led to a crash.
(cherry picked from commit da740b40c0ffbaa768ea970fb6c78ec7593e54f1)
Bug: 1354558
Change-Id: Ia37f322f4b01d9b4e4bef34765c221bba96cf5bc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3841762
Commit-Queue: Boris Sazonov <[email protected]>
Reviewed-by: Sam Maier <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1037752}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3851321
Auto-Submit: Boris Sazonov <[email protected]>
Commit-Queue: Sam Maier <[email protected]>
Cr-Commit-Position: refs/branch-heads/5249@{#44}
Cr-Branched-From: 4f7bea5de862aaa52e6bde5920755a9ef9db120b-refs/heads/main@{#1036826}
[Start] Fix new tab button shown delay.
(cherry picked from commit 5e0d01d43f52adc05e56894aadc58a09bee8ade7)
Bug: 1354865
Change-Id: I98bdbff40722a9ddbeac92f23f55007f53545a2f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3843348
Reviewed-by: Xi Han <[email protected]>
Commit-Queue: Hao Dong <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1037763}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3851021
Cr-Commit-Position: refs/branch-heads/5249@{#43}
Cr-Branched-From: 4f7bea5de862aaa52e6bde5920755a9ef9db120b-refs/heads/main@{#1036826}
[SearchResumption] Fix header isn't reading properly in talkback.
The bug was caused by connecting two strings together without a space
between them. It leads to two words read as one in talkback.
(cherry picked from commit 236bc37c0dcc49ac0da1de74a4481473ae537771)
Bug: 1355218
Change-Id: Idb6eb19b2b2277bcdefd10cfc90f3ead6dc2f16e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3845186
Reviewed-by: Hao Dong <[email protected]>
Commit-Queue: Xi Han <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1037732}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3850605
Cr-Commit-Position: refs/branch-heads/5249@{#42}
Cr-Branched-From: 4f7bea5de862aaa52e6bde5920755a9ef9db120b-refs/heads/main@{#1036826}
Switch V8 reference to git hash
Bug: 1341211
Change-Id: Ia6e8f25e90270f5e4ff86123e224af1c40aded44
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3849976
Reviewed-by: Lutz Vahl <[email protected]>
Commit-Queue: Liviu Rau <[email protected]>
Reviewed-by: Michael Achenbach <[email protected]>
Auto-Submit: Liviu Rau <[email protected]>
Cr-Commit-Position: refs/branch-heads/5249@{#41}
Cr-Branched-From: 4f7bea5de862aaa52e6bde5920755a9ef9db120b-refs/heads/main@{#1036826}
Updating XTBs based on .GRDs from branch 5249
Change-Id: Ie8fe6b06b31b93fd0d762b683e0be2346d981c6e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3850601
Bot-Commit: Rubber Stamper <[email protected]>
Auto-Submit: Ben Mason <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/5249@{#40}
Cr-Branched-From: 4f7bea5de862aaa52e6bde5920755a9ef9db120b-refs/heads/main@{#1036826}
Revert "[signin] Temporary disable IsAllowedForMachineLearningCapability"
This reverts commit 6d9bf4b85993f56aca3c78de8a624252d7634261.
Reason for revert: the capability has been enabled on the server
Original change's description:
> [signin] Temporary disable IsAllowedForMachineLearningCapability
>
> IsAllowedForMachineLearningCapability isn't enabled on server yet and
> this causes test failures.
>
> This CL excludes IsAllowedForMachineLearningCapability from
> GetSupportedAccountCapabilityNames() so that it won't be fetched from
> the server at all.
>
> This is a temporary change until IsAllowedForMachineLearningCapability
> is rolled out.
>
> Bug: 1352081
> Change-Id: I8337544d715d738f6f1f7d3ca297d2837c1997f7
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834483
> Auto-Submit: Alex Ilin <[email protected]>
> Commit-Queue: Alex Ilin <[email protected]>
> Reviewed-by: Nicolas Dossou-Gbété <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1036092}
(cherry picked from commit 19a2b3ace511deaa956fde8ed33a8be3ea51bb94)
Change-Id: I4eab1b19ec4b109c1be061bbfc263b6d5652a15e
Fixed: 1352081
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3838152
Reviewed-by: Nicolas Dossou-Gbété <[email protected]>
Commit-Queue: Alex Ilin <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1037656}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3848172
Bot-Commit: Rubber Stamper <[email protected]>
Auto-Submit: Matteo Ruello <[email protected]>
Reviewed-by: Alex Ilin <[email protected]>
Cr-Commit-Position: refs/branch-heads/5249@{#39}
Cr-Branched-From: 4f7bea5de862aaa52e6bde5920755a9ef9db120b-refs/heads/main@{#1036826}
[M106][OOBE]: Enable network portal detector after accepting EULA
(cherry picked from commit d7a3d088c6747679c19f29b41765eb6beef6cfa1)
Bug: b:239935283
Change-Id: I83798e4cc35fd072f907af3864c5afa3e382fd95
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3838817
Reviewed-by: Roman Sorokin <[email protected]>
Commit-Queue: Danila Kuzmin <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1037159}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3845390
Reviewed-by: Renato Silva <[email protected]>
Cr-Commit-Position: refs/branch-heads/5249@{#38}
Cr-Branched-From: 4f7bea5de862aaa52e6bde5920755a9ef9db120b-refs/heads/main@{#1036826}
[M106] Re-enable EnableSyncImmediatelyInFRE
This feature was rolled back due to a bug where child accounts
got stuck in the FRE after opening Chrome's Terms & Conditions.
This CL fixes the bug and re-enables the feature. Details are
in http://b/237715067#comment7.
Manually tested scenarios (assumes AllowSyncOffForChildAccounts
disabled, but tested with both --force-enable-signin-fre and
force-disable-signin-fre):
- "Yes, I'm in" -> Sync enabled
- Terms & Conditions then "Yes, I'm in" -> Sync enabled
- "settings" -> This was broken before and is now fixed, as long as
the user doesn't click Terms & Conditions.
(cherry picked from commit 20df8450d4c8801a164f37a291b9d61fe1d99438)
Bug: 795292, 1354619
Change-Id: Ie6f57b46bbd7fd197751c98747c919a6f1c5112d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3838630
Reviewed-by: Boris Sazonov <[email protected]>
Auto-Submit: Victor Vianna <[email protected]>
Quick-Run: Victor Vianna <[email protected]>
Commit-Queue: Victor Vianna <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1037245}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3844330
Commit-Queue: Boris Sazonov <[email protected]>
Cr-Commit-Position: refs/branch-heads/5249@{#37}
Cr-Branched-From: 4f7bea5de862aaa52e6bde5920755a9ef9db120b-refs/heads/main@{#1036826}
Passwords LoginDatabase: Fix primary key returned from AddLogin
AddLogin calls `db_.GetLastInsertRowId()` to determine the primary key
of the newly-added credential. However, in the "replace" code path, it
called GetLastInsertRowId() twice, and the second time, it might
return an incorrect result, since other DB insertions (insecure
credentials and/or password notes) might have happened in the
meantime.
This CL fixes the issue by not calling GetLastInsertRowId() a second
time, and instead reusing the value from the first call.
(cherry picked from commit 1d969eb5d3e5c75750fb58c9873d23a434eddb96)
Bug: 1352460
Change-Id: I50319678fa160959c9f766e71f3b53b0398c284a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3841758
Reviewed-by: Mohamed Amir Yosef <[email protected]>
Commit-Queue: Marc Treib <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1037059}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3838572
Reviewed-by: Vasilii Sukhanov <[email protected]>
Auto-Submit: Marc Treib <[email protected]>
Cr-Commit-Position: refs/branch-heads/5249@{#36}
Cr-Branched-From: 4f7bea5de862aaa52e6bde5920755a9ef9db120b-refs/heads/main@{#1036826}
ProfileDestroyer: allow custom force-destruction timeout
This is useful for automation scenarios where slow computers
may not be able to close all processes in two seconds, but
will eventually succeed.
Currently, we hit CHECK in ~ProfileDestroyer, most likely because
we force-destroy upon timeout of ~2 seconds. This change allows
automation profiles to provide a custom timeout that would be
enough to destroy all render process hosts.
(cherry picked from commit bcc5a287a2b0e971b3d6bee67aaf832a6f9af123)
Bug: 1349150
Change-Id: Iadbd45a6e23c90b1dae43c23b3c4de7930727c8d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3821446
Commit-Queue: Dmitry Gozman <[email protected]>
Reviewed-by: Andrey Kosyakov <[email protected]>
Reviewed-by: Arthur Sonzogni <[email protected]>
Reviewed-by: Nicolas Ouellet-Payeur <[email protected]>
Reviewed-by: Ramin Halavati <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1037431}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3846107
Commit-Queue: Ramin Halavati <[email protected]>
Auto-Submit: Dmitry Gozman <[email protected]>
Cr-Commit-Position: refs/branch-heads/5249@{#35}
Cr-Branched-From: 4f7bea5de862aaa52e6bde5920755a9ef9db120b-refs/heads/main@{#1036826}
Revert "[Dr-Dc] Add more devices to be blocklisted."
This reverts commit aaaa0e3a28bf9523f4379195d754fdf9200838ec.
Reason for revert: crbug.com/1354945
Original change's description:
> [Dr-Dc] Add more devices to be blocklisted.
>
> Add more devices to be blocklisted here in chrome code since adding it
> via finch is very slow.
>
> (cherry picked from commit 50a85fa470de5de5d9fca09cba6f1bedf84cf52c)
>
> Bug: 1340054
> Change-Id: I3343d67ede012765fbfe36d6feb34a505d1a389e
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3842363
> Auto-Submit: vikas soni <[email protected]>
> Commit-Queue: vikas soni <[email protected]>
> Reviewed-by: Sunny Sachanandani <[email protected]>
> Cr-Original-Commit-Position: refs/heads/main@{#1037178}
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3840823
> Reviewed-by: vikas soni <[email protected]>
> Cr-Commit-Position: refs/branch-heads/5249@{#4}
> Cr-Branched-From: 4f7bea5de862aaa52e6bde5920755a9ef9db120b-refs/heads/main@{#1036826}
Bug: 1340054
Change-Id: I20133a4a07dd9d389172a53585e39765cfbf8e4b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3848921
Owners-Override: Krishna Govind <[email protected]>
Commit-Queue: vikas soni <[email protected]>
Reviewed-by: Krishna Govind <[email protected]>
Cr-Commit-Position: refs/branch-heads/5249@{#34}
Cr-Branched-From: 4f7bea5de862aaa52e6bde5920755a9ef9db120b-refs/heads/main@{#1036826}
Revert "[Dr-Dc] Disable DrDc on some gpus ."
This reverts commit c4a306d0a88dc12f4a5e15e66004ac2c3a4cab79.
Reason for revert: crbug.com/1354945
Original change's description:
> [Dr-Dc] Disable DrDc on some gpus .
>
> Disable DrDc on some gpus via gpudriverbugworkaround.
>
> (cherry picked from commit 1e7201436c8cd050c51d5a5fdf4c8e74e793a27f)
>
> Bug: 1354201
> Change-Id: Ia54ea2ae67bdd93d5085e81eca32b33433073eec
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3840470
> Commit-Queue: vikas soni <[email protected]>
> Reviewed-by: Vasiliy Telezhnikov <[email protected]>
> Cr-Original-Commit-Position: refs/heads/main@{#1036894}
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3842868
> Reviewed-by: Krishna Govind <[email protected]>
> Owners-Override: Krishna Govind <[email protected]>
> Reviewed-by: vikas soni <[email protected]>
> Cr-Commit-Position: refs/branch-heads/5249@{#5}
> Cr-Branched-From: 4f7bea5de862aaa52e6bde5920755a9ef9db120b-refs/heads/main@{#1036826}
Bug: 1354201
Change-Id: I849932e2bf1766f849d52c25c426c923dedf296e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3845891
Reviewed-by: Krishna Govind <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Owners-Override: Krishna Govind <[email protected]>
Commit-Queue: vikas soni <[email protected]>
Cr-Commit-Position: refs/branch-heads/5249@{#33}
Cr-Branched-From: 4f7bea5de862aaa52e6bde5920755a9ef9db120b-refs/heads/main@{#1036826}
[ios] Enable TrendingQueriesModule to 5% Stable
Launch Bug: crbug.com/1328303
(cherry picked from commit da12b9a1c733a9419a8bfea96971cc493ddb835c)
Bug: 1340123
Change-Id: Ie2ca2eee20f86a5870b5219a834694bfb1a67626
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3842570
Commit-Queue: Chris Lu <[email protected]>
Reviewed-by: Rohit Rao <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1037303}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3849261
Commit-Queue: Rohit Rao <[email protected]>
Auto-Submit: Chris Lu <[email protected]>
Cr-Commit-Position: refs/branch-heads/5249@{#32}
Cr-Branched-From: 4f7bea5de862aaa52e6bde5920755a9ef9db120b-refs/heads/main@{#1036826}
[iOS] on iPad, CBD’s sign-out is over the link
Result can be seen on
https://drive.google.com/file/d/1yoMS9bAyUMPHcLxQB2G7qAfZoNo8INzV/view?usp=sharing
Also document a function missing documentation.
(cherry picked from commit 4abbea2af6a6f8c4ad931876f2e6dd7d2b65fcff)
Fixed: 1354161
Change-Id: I3e8daaa9507c041b7bc7465ba6ec9b2838a8cdd1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3839076
Reviewed-by: Jérôme Lebel <[email protected]>
Commit-Queue: Arthur Milchior <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1037130}
No-Try: Just a cherry pick
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3845810
Auto-Submit: Arthur Milchior <[email protected]>
Cr-Commit-Position: refs/branch-heads/5249@{#31}
Cr-Branched-From: 4f7bea5de862aaa52e6bde5920755a9ef9db120b-refs/heads/main@{#1036826}
[skylab_tests] Update skylab tests cros img version
This CL will update cros image version for skylab tests. CROS_BOARD_LKGM
is updated according to chromeos/CHROMEOS_LKGM; CROS_BOARD_DEV,
CROS_BOARD_BETA and CROS_BOARD_STABLE are updated according to Omaha.
If this CL caused regressions, please revert and pause the autoroller at
https://luci-scheduler.appspot.com/jobs/chrome/lacros-skylab-tests-cros-img-roller
Also please file a bug to OS>LaCrOS>Partner, and CC [email protected],
[email protected].
[email protected]
Requires-Testing: True
Change-Id: If0f37032bc1d8096d8a83043716a6702ec4dba89
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3849045
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Auto-Submit: skylab-test-cros-roller@chops-service-accounts.iam.gserviceaccount.com <skylab-test-cros-roller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/5249@{#30}
Cr-Branched-From: 4f7bea5de862aaa52e6bde5920755a9ef9db120b-refs/heads/main@{#1036826}
Keep the de facto CLS behavior for fixed-position before crrev.com/1036822
crrev.com/1036822 added kFixedPosition compositing reason for
fixed-position objects that are composited for other fixed-position
compositing reasons in a non-scrollable view. This caused change of
CLS for some web sites because the compositing reason is also used in
IsLayoutShiftRoot(). Now adjust condition in IsLayoutShiftRoot() to
keep the de facto CLS behavior before crrev.com/1036822.
(cherry picked from commit 7307661a70eae3079b13d9996a7c9d101ca53116)
Bug: 1354452
Change-Id: If1bf5ca40a2bf52a57fbcd9f4bea33fdef7f07af
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3842267
Commit-Queue: Xianzhu Wang <[email protected]>
Reviewed-by: Philip Rogers <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1037256}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3842710
Auto-Submit: Xianzhu Wang <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/5249@{#29}
Cr-Branched-From: 4f7bea5de862aaa52e6bde5920755a9ef9db120b-refs/heads/main@{#1036826}
[M106] Files app: Fix new breadcrumbs with Shared with me
"Shared with me" uses the drive search code. The new breadcrumbs +
change directory using the Store was in a infinite loop when trying to
clear the search during the "change directory".
This CL fixes by only try to clear the search if the store has a search.
Also tested the fix manually in the DUT.
(cherry picked from commit f40efc23a189a1d1ed7f668d84c02d7b5b9423c4)
Test: browser_tests --gtest_filter="*breadcrumbNavigateBackToSharedWithMe*"
Bug: 1354004
Change-Id: I1f517e01587b31cd2f0f73ee3e009a2d5d559b95
Cq-Do-Not-Cancel-Tryjobs: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3841134
Commit-Queue: Ben Reich <[email protected]>
Reviewed-by: Ben Reich <[email protected]>
Auto-Submit: Luciano Pacheco <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1036945}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3848901
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/5249@{#28}
Cr-Branched-From: 4f7bea5de862aaa52e6bde5920755a9ef9db120b-refs/heads/main@{#1036826}
Incrementing VERSION to 106.0.5249.7
Change-Id: Idb47588e54ac22189cf00e8851d18e06e93e608d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3849101
Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/5249@{#27}
Cr-Branched-From: 4f7bea5de862aaa52e6bde5920755a9ef9db120b-refs/heads/main@{#1036826}
[M106 Merge][side search] Make required code and UMA changes for auto triggering
This CL adds the initial feature engagement code and UMA
action / histogram changes for the side panel autotriggering
engagement experiment per components/feature_engagement/README.md.
(cherry picked from commit 7ffc1a23041542fa5e4f7149e54ae32986df010c)
Bug: 1354016
Change-Id: I515d434c87e149d5ad0e9e5ba50936ca49d59c38
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834421
Commit-Queue: Thomas Lukaszewicz <[email protected]>
Reviewed-by: Tommy Nyquist <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1036858}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3842712
Cr-Commit-Position: refs/branch-heads/5249@{#26}
Cr-Branched-From: 4f7bea5de862aaa52e6bde5920755a9ef9db120b-refs/heads/main@{#1036826}
[SearchResumption] Change search resumption module header text.
Change the header text to "Based on your last tab". Also, update the
content description for a11y.
Before:
https://drive.google.com/file/d/1RMVSbYkXqHMPqEi4WBYaG_nD9aLRPuix/view?usp=sharing
After:
https://drive.google.com/file/d/1iuBD--CkZMjUkBlXHqngIXTkn8-UfuU4/view?usp=sharing
(cherry picked from commit d7612a82dc439809f5a9bd457c2199369b9b4187)
Bug: 1354191
Change-Id: I731fc7c119b9e907760febfae545fb21d218f56b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3838635
Auto-Submit: Xi Han <[email protected]>
Commit-Queue: Hao Dong <[email protected]>
Reviewed-by: Hao Dong <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1036883}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3846394
Cr-Commit-Position: refs/branch-heads/5249@{#25}
Cr-Branched-From: 4f7bea5de862aaa52e6bde5920755a9ef9db120b-refs/heads/main@{#1036826}
[m106][omnibox][rich-autocompletion] Support RTL when using dash UI.
CL crrev.com/c/3793563 added dash UI for LTR languages.
This CL adds support for RTL.
For LTR
The paren UI: input[autocompletion] (url)
The dash UI: input[autocompletion] - url
For RTL (:
The paren UI: tupni[noitelpmocotua] (lru)
The dash UI (before this CL): tupni[noitelpmocotua] lru -
The dash UI (with this CL): tupni[noitelpmocotua] - lru
Screenshots: https://screenshot.googleplex.com/3gYG7zZrv4TAXBD
(cherry picked from commit d5fda64507c20dc60dcc2a1dd77fca1f62d335d4)
Bug: 1348352, 1062446
Change-Id: I77d503f960c9e9bf4446a93e554f7b3d91834665
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3828001
Reviewed-by: Peter Kasting <[email protected]>
Auto-Submit: manuk hovanesian <[email protected]>
Commit-Queue: manuk hovanesian <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1037120}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3841224
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/5249@{#24}
Cr-Branched-From: 4f7bea5de862aaa52e6bde5920755a9ef9db120b-refs/heads/main@{#1036826}
[m106][rollicu] Update TZ to 2022b
This CL is the M106 branch equivalent of
https://chromium-review.googlesource.com/c/chromium/src/+/3841326
IANA announcement:
https://mm.icann.org/pipermail/tz-announce/2022-August/000071.html
Upstream ICU PR:
https://github.com/unicode-org/icu/pull/2157
How to verify - In JavaScript
(new Date("2022-09-05T12:34:56Z")).toLocaleTimeString("en", {timeZone: "America/Santiago", timeZoneName:"long"})
(new Intl.DateTimeFormat("en", {timeZone: "Europe/Kiev"})).resolvedOptions().timeZone
(new Intl.DateTimeFormat("en", {timeZone: "Europe/Kyiv"})).resolvedOptions().timeZone
Before the change:
> '9:34:56 AM Chile Summer Time'
> 'Europe/Kiev'
> RangeError: Invalid time zone specified: Europe/Kyiv
After the change:
> '8:34:56 AM Chile Standard Time'
> 'Europe/Kiev'
> 'Europe/Kiev'
Changes
"
Briefly:
Chile's DST is delayed by a week in September 2022.
Iran no longer observes DST after 2022.
Rename Europe/Kiev to Europe/Kyiv.
New zic -R option
Vanguard form now uses %z.
Finish moving duplicate-since-1970 zones to 'backzone'.
New build option PACKRATLIST
New tailored_tarballs target, replacing rearguard_tarballs
Changes to future timestamps
Chile's 2022 DST start is delayed from September 4 to September 11.
(Thanks to Juan Correa.)
Iran plans to stop observing DST permanently, after it falls back
on 2022-09-21. (Thanks to Ali Mirjamali.)
Changes to past timestamps
Finish moving to 'backzone' the location-based zones whose
timestamps since 1970 are duplicates; adjust links accordingly.
This change ordinarily affects only pre-1970 timestamps, and with
the new PACKRATLIST option it does not affect any timestamps.
In this round the affected zones are Antarctica/Vostok,
Asia/Brunei, Asia/Kuala_Lumpur, Atlantic/Reykjavik,
Europe/Amsterdam, Europe/Copenhagen, Europe/Luxembourg,
Europe/Monaco, Europe/Oslo, Europe/Stockholm, Indian/Christmas,
Indian/Cocos, Indian/Kerguelen, Indian/Mahe, Indian/Reunion,
Pacific/Chuuk, Pacific/Funafuti, Pacific/Majuro, Pacific/Pohnpei,
Pacific/Wake and Pacific/Wallis, and the affected links are
Arctic/Longyearbyen, Atlantic/Jan_Mayen, Iceland, Pacific/Ponape,
Pacific/Truk, and Pacific/Yap.
From fall 1994 through fall 1995, Shanks wrote that Crimea's
DST transitions were at 02:00 standard time, not at 00:00.
(Thanks to Michael Deckers.)
Iran adopted standard time in 1935, not 1946. In 1977 it observed
DST from 03-21 23:00 to 10-20 24:00; its 1978 transitions were on
03-24 and 08-05, not 03-20 and 10-20; and its spring 1979
transition was on 05-27, not 03-21.
(Thanks to Roozbeh Pournader and Francis Santoni.)
Chile's observance of -04 from 1946-08-29 through 1947-03-31 was
considered DST, not standard time. Santiago and environs had moved
their clocks back to rejoin the rest of mainland Chile; put this
change at the end of 1946-08-28. (Thanks to Michael Deckers.)
Some old, small clock transitions have been removed, as people at
the time did not change their clocks. This affects Asia/Hong_Kong
in 1904, Asia/Ho_Chi_Minh in 1906, and Europe/Dublin in 1880.
Changes to zone name
Rename Europe/Kiev to Europe/Kyiv, as "Kyiv" is more common in
English now. Spelling of other names in Ukraine has not yet
demonstrably changed in common English practice so for now these
names retain old spellings, as in other countries (e.g.,
Europe/Prague not "Praha", and Europe/Sofia not "Sofiya").
"
Bug: 1354379
Change-Id: I3b891b55995c2a146fac96dd30d6eebee985f238
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3846026
Commit-Queue: Frank Tang <[email protected]>
Reviewed-by: Jungshik Shin <[email protected]>
Cr-Commit-Position: refs/branch-heads/5249@{#23}
Cr-Branched-From: 4f7bea5de862aaa52e6bde5920755a9ef9db120b-refs/heads/main@{#1036826}
Revert r1014944: "Change border element role per the color lightness"
This patch reverts https://crrev.com/1014944 ("Change border element
role per the color lightness") due to a regression where borders are
too bright on common pages.
Original Change-Id: I4125626fa2e3295bc977d45f4979d193c9971c9a
(cherry picked from commit bd880e5ed36dc6363a87c3bf1971681376d258c5)
Bug: 1352156
Change-Id: I2898f0c1aed3d8266ffc5f2e5b23a621095512c4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3838669
Reviewed-by: Xianzhu Wang <[email protected]>
Auto-Submit: Philip Rogers <[email protected]>
Commit-Queue: Xianzhu Wang <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1037327}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3845168
Commit-Queue: Philip Rogers <[email protected]>
Cr-Commit-Position: refs/branch-heads/5249@{#22}
Cr-Branched-From: 4f7bea5de862aaa52e6bde5920755a9ef9db120b-refs/heads/main@{#1036826}
M106: Fix find-in-page for the PDF Viewer.
Send the correct "final update" value, with a test case to trigger the
failing scenario.
While trying to reduce the number of messages sent while performing
find-in-page in crrev.com/1021347, the "final update" bit got set
incorrectly and got sent twice in some cases. This causes the browser to
"hang up" after receiving the first "final update" message and ignore
the second one. Developer builds also trigger a DCHECK() failure when
this happens.
Fix this by giving the plugin more control over the "final update" bit
in the blink::WebPluginContainer::ReportFindInPageSelection() interface,
and make the simple change in WebPluginContainerImpl() to pass the value
along. Then add all the plumbing necessary to the PDF plugin code to
communicate with WebPluginContainer, and let
PDFiumEngine::SelectFindResult() send the appropriate values.
(cherry picked from commit 733e70c3286eec35f2f14cedcb26f4508a1fe63c)
Bug: 1352097
Change-Id: I91c1433792f0f931258fb893954180f8af1c5f5b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3828901
Reviewed-by: K. Moon <[email protected]>
Commit-Queue: Lei Zhang <[email protected]>
Reviewed-by: Jeremy Roman <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1037259}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3846450
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/5249@{#21}
Cr-Branched-From: 4f7bea5de862aaa52e6bde5920755a9ef9db120b-refs/heads/main@{#1036826}
[Start] Fix Start surface doesn't response when changing homepage
settings.
When homepage setting is changed, we only need to check if Start surface
is enabled has changed, and recreate the Chrome if true. Update the
check in ToolbarManager fixes the issue.
Demo:
https://drive.google.com/file/d/1-XDYJ1vScOuUqyLJxLst3mga83n5_FZb/view?usp=sharing
(cherry picked from commit eac11bc12b4e501e3adabe783bdce31e2aff771a)
Bug: 1354139
Change-Id: I49c339bf2f580728cc565f0534d1f00fc7c1e68e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3838792
Reviewed-by: Hao Dong <[email protected]>
Commit-Queue: Xi Han <[email protected]>
Reviewed-by: Yaron Friedman <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1037171}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3846393
Cr-Commit-Position: refs/branch-heads/5249@{#20}
Cr-Branched-From: 4f7bea5de862aaa52e6bde5920755a9ef9db120b-refs/heads/main@{#1036826}
[Merge M106][BG CSSTokenizer] Part 4: Bg tokenization for external stylesheets
The approach used here is very similar to what is done for the V8
script streamer. The resource body is intercepted and read on a
background thread. The background thread will decode and tokenize the
data, and send the result to the CSSStyleSheetResource on the main thread when body loading is complete.
Part 1 and general overview: http://crrev.com/c/3808071
Part 2: http://crrev.com/c/3812099
Part 3: http://crrev.com/c/3810818
(cherry picked from commit 20b67579f0ae29b35ac167a804c07b77a6837d5f)
Bug: 1289471
Change-Id: I32ece03daeebd5bdf85ab237eabdae593bc4e09d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3808611
Reviewed-by: Mason Freed <[email protected]>
Reviewed-by: Nico Weber <[email protected]>
Commit-Queue: Clark DuVall <[email protected]>
Reviewed-by: Hiroshige Hayashizaki <[email protected]>
Reviewed-by: Rune Lillesveen <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1037323}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3845188
Bot-Commit: Rubber Stamper <[email protected]>
Owners-Override: Nico Weber <[email protected]>
Cr-Commit-Position: refs/branch-heads/5249@{#19}
Cr-Branched-From: 4f7bea5de862aaa52e6bde5920755a9ef9db120b-refs/heads/main@{#1036826}
[M106][DownloadBubble] Adjust toolbar active color based on theme.
before: http://screen/QrAPdAVytvJu6Ec
after: http://screen/B3ffSyAh7JMgkHW
(cherry picked from commit 37b4e28818c4415ddfd3d7ca82a9efdbf7e6f874)
Bug: 1354650
Change-Id: I04ba7edfdfdd2f470cd241183dbcd35e42165adb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3842692
Reviewed-by: Rohit Bhatia <[email protected]>
Commit-Queue: Xinghui Lu <[email protected]>
Reviewed-by: Peter Kasting <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1037212}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3846330
Commit-Queue: Peter Kasting <[email protected]>
Cr-Commit-Position: refs/branch-heads/5249@{#18}
Cr-Branched-From: 4f7bea5de862aaa52e6bde5920755a9ef9db120b-refs/heads/main@{#1036826}
[M106 Merge] Enable CALayerTreeOptimization by default on Mac
(cherry picked from commit fcdc38dda3f06d4d008a9dae43a67b83b57b5456)
Bug: 1294936
Change-Id: Ib48b5320cf3e6348c7ec93540710db2fca7c92b2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3840403
Auto-Submit: Maggie Chen <[email protected]>
Reviewed-by: ccameron chromium <[email protected]>
Commit-Queue: ccameron chromium <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1036968}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3845952
Commit-Queue: Maggie Chen <[email protected]>
Cr-Commit-Position: refs/branch-heads/5249@{#17}
Cr-Branched-From: 4f7bea5de862aaa52e6bde5920755a9ef9db120b-refs/heads/main@{#1036826}
[iOS] Make Incognito interstitial banner smaller
(cherry picked from commit 0ba0cae956bb1f9c00f5fb101b027313aa5837ae)
Bug: 1318750
Change-Id: Ib09c32ef87b247fa1988ee1b98af72e3e45dd6d8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3838793
Commit-Queue: Quentin Pubert <[email protected]>
Reviewed-by: Mark Cogan <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1037072}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3841769
Bot-Commit: Rubber Stamper <[email protected]>
Reviewed-by: Gauthier Ambard <[email protected]>
Auto-Submit: Quentin Pubert <[email protected]>
Cr-Commit-Position: refs/branch-heads/5249@{#16}
Cr-Branched-From: 4f7bea5de862aaa52e6bde5920755a9ef9db120b-refs/heads/main@{#1036826}
[iOS] Have VoiceOver focus the Incognito interstitial title when it appears
- `viewDidAppear` is overridden in view controller to manually bring
focus onto title label when Incognito interstitial appears.
- `title` property is set to improve accessibility of navigation.
(cherry picked from commit b77dbcb78891ad66b1bb71801803d73c4b132e4c)
Bug: 1354523
Change-Id: I36f273365d11d005780466c1186ce476779e04b4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3841485
Commit-Queue: Quentin Pubert <[email protected]>
Reviewed-by: David Jean <[email protected]>
Reviewed-by: Mark Cogan <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1037048}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3839150
Auto-Submit: Quentin Pubert <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Reviewed-by: Gauthier Ambard <[email protected]>
Cr-Commit-Position: refs/branch-heads/5249@{#15}
Cr-Branched-From: 4f7bea5de862aaa52e6bde5920755a9ef9db120b-refs/heads/main@{#1036826}
[M106][infra] Use 8-core machines for branched try/fuchsia-binary-size.
branched fuchsia-binary-size is builderless, but we don't have 16-core
builderless try machines. This changes it so that the branched versions
will use 8 cores.
Bug: 1355319
Change-Id: Ia46843d2d9c65bb3f746bd89931e87f37ea2ad70
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3846410
Auto-Submit: Garrett Beaty <[email protected]>
Commit-Queue: Ben Pastene <[email protected]>
Reviewed-by: Ben Pastene <[email protected]>
Cr-Commit-Position: refs/branch-heads/5249@{#14}
Cr-Branched-From: 4f7bea5de862aaa52e6bde5920755a9ef9db120b-refs/heads/main@{#1036826}
Incrementing VERSION to 106.0.5249.6
Change-Id: I279d007b51ce0049544321bc5321b66f031fb091
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3842489
Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/5249@{#13}
Cr-Branched-From: 4f7bea5de862aaa52e6bde5920755a9ef9db120b-refs/heads/main@{#1036826}
Incrementing VERSION to 106.0.5249.5
Change-Id: Ib76a7fd5378168db8c8bb11e0ccc2dd670f89ee1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3840697
Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/5249@{#12}
Cr-Branched-From: 4f7bea5de862aaa52e6bde5920755a9ef9db120b-refs/heads/main@{#1036826}
Incrementing VERSION to 106.0.5249.4
Change-Id: I8136624bda31001ddc1c32064d706921f270c7de
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3838331
Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/5249@{#11}
Cr-Branched-From: 4f7bea5de862aaa52e6bde5920755a9ef9db120b-refs/heads/main@{#1036826}
Incrementing VERSION to 106.0.5249.3
Change-Id: I36989a661d1dc35a441a87fc1fc33c0d894a3ea4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3843128
Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/5249@{#10}
Cr-Branched-From: 4f7bea5de862aaa52e6bde5920755a9ef9db120b-refs/heads/main@{#1036826}
Update LUCI config for M106
[email protected]
Change-Id: If488857dfa05947bc8b585a6b0e1eb6541f221b1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3843069
Auto-Submit: Srinivas Sista <[email protected]>
Owners-Override: Srinivas Sista <[email protected]>
Commit-Queue: Wanda Mora <[email protected]>
Reviewed-by: Wanda Mora <[email protected]>
Commit-Queue: Srinivas Sista <[email protected]>
Cr-Commit-Position: refs/branch-heads/5249@{#9}
Cr-Branched-From: 4f7bea5de862aaa52e6bde5920755a9ef9db120b-refs/heads/main@{#1036826}
Incrementing VERSION to 106.0.5249.2
Change-Id: I8b937572f39f415c798080614644a8ee4028347f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3842637
Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/5249@{#8}
Cr-Branched-From: 4f7bea5de862aaa52e6bde5920755a9ef9db120b-refs/heads/main@{#1036826}
Update 5249 DEPS for M106 branching
[email protected]
Change-Id: I1cfc4eb003d8712a3bd153b8e8c564fbf3f11ebc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3842293
Reviewed-by: Krishna Govind <[email protected]>
Commit-Queue: Srinivas Sista <[email protected]>
Cr-Commit-Position: refs/branch-heads/5249@{#7}
Cr-Branched-From: 4f7bea5de862aaa52e6bde5920755a9ef9db120b-refs/heads/main@{#1036826}
[Android] Don't use landscape layout in FRE on tablets
Adds FirstRunPageDelegate.canUseLandscapeLayout method that returns
false if FRE is shown within TabbedModeFirstRunActivity (which is
shown in a dialog that always has the portrait orientation) or
true if FRE is shown within FirstRunActivity (which is shown in
fullscreen mode and thus can have landscape orientation).
This method is then used to suppress the usage of
signin_first_run_landscape_view when FRE is shown in a dialog.
(cherry picked from commit 0f60b0e8fd8358932c8eef8385ec0afcb012fa58)
Bug: 1350917
Change-Id: I55a67d32eb12bd726f31bb4320e71a36dc313048
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3840395
Reviewed-by: Tanmoy Mollik <[email protected]>
Commit-Queue: Boris Sazonov <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1037066}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3840432
Owners-Override: Krishna Govind <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/5249@{#6}
Cr-Branched-From: 4f7bea5de862aaa52e6bde5920755a9ef9db120b-refs/heads/main@{#1036826}
[Dr-Dc] Disable DrDc on some gpus .
Disable DrDc on some gpus via gpudriverbugworkaround.
(cherry picked from commit 1e7201436c8cd050c51d5a5fdf4c8e74e793a27f)
Bug: 1354201
Change-Id: Ia54ea2ae67bdd93d5085e81eca32b33433073eec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3840470
Commit-Queue: vikas soni <[email protected]>
Reviewed-by: Vasiliy Telezhnikov <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1036894}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3842868
Reviewed-by: Krishna Govind <[email protected]>
Owners-Override: Krishna Govind <[email protected]>
Reviewed-by: vikas soni <[email protected]>
Cr-Commit-Position: refs/branch-heads/5249@{#5}
Cr-Branched-From: 4f7bea5de862aaa52e6bde5920755a9ef9db120b-refs/heads/main@{#1036826}
[Dr-Dc] Add more devices to be blocklisted.
Add more devices to be blocklisted here in chrome code since adding it
via finch is very slow.
(cherry picked from commit 50a85fa470de5de5d9fca09cba6f1bedf84cf52c)
Bug: 1340054
Change-Id: I3343d67ede012765fbfe36d6feb34a505d1a389e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3842363
Auto-Submit: vikas soni <[email protected]>
Commit-Queue: vikas soni <[email protected]>
Reviewed-by: Sunny Sachanandani <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1037178}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3840823
Reviewed-by: vikas soni <[email protected]>
Cr-Commit-Position: refs/branch-heads/5249@{#4}
Cr-Branched-From: 4f7bea5de862aaa52e6bde5920755a9ef9db120b-refs/heads/main@{#1036826}
[lacros] Update lacros QA qualified version
This CL will update lacros version in //chrome/LACROS_QA_QUALIFIED_VERSION. This
file will be used in Upreving the RootFS-Lacros in the CROS image.
If this CL caused regressions, please revert and pause the autoroller at
https://luci-scheduler.appspot.com/jobs/chrome/lacros-qa-qualified-tracking-roller
Also please file a bug to OS>LaCrOS>Partner, and CC [email protected],
[email protected].
[email protected]
Change-Id: I548ee5d3f8c4d7875c03bb2a5f2e187c10e72910
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3841172
Auto-Submit: lacros-tracking-roller@chops-service-accounts.iam.gserviceaccount.com <lacros-tracking-roller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Rubber Stamper <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/5249@{#3}
Cr-Branched-From: 4f7bea5de862aaa52e6bde5920755a9ef9db120b-refs/heads/main@{#1036826}
Incrementing VERSION to 106.0.5249.1
Change-Id: I2c10036d44f7ab91bd2565d6040c50910066c166
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3838752
Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/5249@{#2}
Cr-Branched-From: 4f7bea5de862aaa52e6bde5920755a9ef9db120b-refs/heads/main@{#1036826}
Update DEPS for 5249 branching
Change-Id: I0cfa757c52d10fe6b5913ae4be8a8ef3359ea0ba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3838213
Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/5249@{#1}
Cr-Branched-From: 4f7bea5de862aaa52e6bde5920755a9ef9db120b-refs/heads/main@{#1036826}
[remoting] Simplify DesktopResizerX11::CreateMode().
The new mode ID is returned by the RANDR CreateMode() request, so
there is no need to refresh the resources and search for it.
Bug: 1326339
Change-Id: Ibb0bf991ccfa431c1ead900205d66529a7d08f61
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3839075
Auto-Submit: Lambros Lambrou <[email protected]>
Commit-Queue: Jamie Walch <[email protected]>
Reviewed-by: Jamie Walch <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036826}
Update process_perf_results.pydeps
no-try: true
Change-Id: Id1e9852b7724293846a23e290522d865410f9c27
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3840675
Owners-Override: Ben Pastene <[email protected]>
Reviewed-by: Ben Pastene <[email protected]>
Commit-Queue: Ben Pastene <[email protected]>
Commit-Queue: Sven Zheng <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036825}
Update Crashpad to 3e80b95054c868241ee3ec291603f5babda685e1
0c369760bd47 Mac: update MachOImageAnnotationsReader tests for dyld4
05e3bd85ebd6 Mac: Expect timestamp for main executable in macOS 12+ in
process reader
af96fcd576d0 Mac: use pthread_get_stack{addr,size}_np in process reader
tests
1d4447645d30 Mac: Fix shadow warning
3e80b95054c8 Run clang-format on process_reader_mac_test
Bug: 844396, 1334418, 1319307, 1268776
Change-Id: I819c665c8b660a8f33a991d2090f7e17083a6861
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3840747
Commit-Queue: Leonard Grey <[email protected]>
Reviewed-by: Mark Mentovai <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036824}
Remove de-jelly flag
Already expired in m104.
Bug: 995965
Change-Id: I11af4c910eb8f3434658aa20b6e35f63b1dfff27
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3838945
Reviewed-by: Vasiliy Telezhnikov <[email protected]>
Commit-Queue: Vasiliy Telezhnikov <[email protected]>
Auto-Submit: Bo Liu <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036823}
[ScrollUpdateOptimizations] Fix fixed-position overlap testing
1. Fall back to the generic cross-scroll overlap testing if there
is any additional clip between the fixed-position state and the
scroller overflow clip because the expanded fixed-position
rect would be incorrectly clipped.
2. Also use CompositingReason::kFixedPosition for special fixed-
position compositing reasons in a non-scrollable viewport, to
use the fixed-position code path in overlap testing if possible
to avoid extra overlaps.
Found the issues because the following tests failed with
ScrollUpdateOptimizations enabled by default:
external/wpt/css/css-multicol/fixedpos-static-pos-with-viewport-cb-001.html
external/wpt/css/css-multicol/fixedpos-static-pos-with-viewport-cb-002.html
external/wpt/css/css-multicol/fixedpos-static-pos-with-viewport-cb-003.html
external/wpt/css/css-position/position-fixed-scroll-overlap.html
I probably only checked blink_web_tests for failures when I tried the
original ScrollUpdateOptimizations CL with the feature enabled.
Bug: 1346789
Change-Id: Ia6fbcd72aebb355b1ba42f5c332a8e61a679ee66
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3838628
Reviewed-by: Philip Rogers <[email protected]>
Commit-Queue: Xianzhu Wang <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036822}
Reland "[Extensions] Use scoped IDs for extension webRequest sub-event names."
This relands commit a72f6da93453d91d3c9d5a5ef2947f73e3625fe7.
Reland notes:
The original CL used scoped sub-event names in webRequest events for
any extension context (and not for webview, which caused a crash).
Unfortunately, this *also* caused crashes: We require that each
listener have a unique ID, where the ID is the set of the subevent
name, extension ID, process ID, and other bits. With context-scoped
subevent names, each ID was unique within the context, but if an
extension added multiple listeners from different contexts that ran
in the same process, the events could collide.
For example, if an extension adds a listener for the onBeforeRequest
event in two different frames, each of those listeners would have the
subevent name of "webRequest.onBeforeRequest/1". Since they also run
in the same process, these listeners would collide, leading to the
crash.
Fix this by only using context-scoped subevent names for service
worker contexts. This is the only scenario we need them (where we need
consistent IDs across worker starts) and also ensures there will be no
collisions as an extension can only have a single service worker with
access to extension APIs per BrowserContext.
Add a regression test to exercise the explicit behavior that caused the
crash (extensions with listeners in multiple contexts) and an additional
test for an MV3 extension with multiple listeners and different types of
contexts.
Original change's description:
> [Extensions] Use scoped IDs for extension webRequest sub-event names.
>
> This CL relands a change to sub-event name generation for webRequest
> events that broke webview. It preserves existing behavior for webview
> and only uses scoped IDs for extensions.
>
> Bug: 1024211
> Change-Id: I168669aeca855f0a5ba25b2817b25724e6307de0
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3628162
> Reviewed-by: Devlin Cronin <[email protected]>
> Commit-Queue: David Bertoni <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1003765}
Bug: 1024211
Change-Id: I7fa64b052b8cc487d91754434e04c52f88febb33
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3828490
Reviewed-by: David Bertoni <[email protected]>
Commit-Queue: Devlin Cronin <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036821}
Fix Offer Notification Bubble Crash When Offer Data Is Cleared
This CL fixes a crash where if the offer is deleted from the local
autofill offer data (for example, if autofill wallet import is turned
off, clearing the offer data), and we try to re-show the offer, the
controller keeps a pointer to the offer that is deleted which results in
a crash.
This CL instead copies the original offer shown, so that on re-show we
will show a copy which will always be present for the entire lifecycle
of the controller.
Bug: 1334806
Change-Id: Ia4cc81b6944a9fe8d6ca4f6c8e881a49482bb5bb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3827484
Reviewed-by: Siyu An <[email protected]>
Reviewed-by: Mohamed Amir Yosef <[email protected]>
Commit-Queue: Vinny Persky <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036820}
[Lacros] Introduce a new device reporting settings component
This change introduces a new DeviceReportingSettings component that can
be used by the metric reporting pipeline in Lacros to fetch device
settings via crosapi.
Bug: b:241486730
Change-Id: I6669faa920003a31bcf6f2469b6399a4d748904e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3831139
Reviewed-by: Ahmed Nasr <[email protected]>
Reviewed-by: Leonid Baraz <[email protected]>
Commit-Queue: Vignesh Shenvi <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036819}
[A11y Settings Revamp] Redirect Manage page to top-level section
Redirect Manage Accessibility page to Accessibility top-level section of
Chrome OS Settings. go/a11y-settings-revamp
Before: https://screenshot.googleplex.com/5H5WfEPwv5VBDyq
After: https://screenshot.googleplex.com/BoCVsadJdbcbnhC
Bug: 1292142
Change-Id: Ic9b094272d84c57298115eb21017bda32bb7a026
AX-Relnotes: Updates to Chrome OS Accessibility Settings to make accessibility options simpler / easier to use.
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3836262
Commit-Queue: Josiah Krutz <[email protected]>
Reviewed-by: Katie Dektar <[email protected]>
Reviewed-by: Xiyuan Xia <[email protected]>
Reviewed-by: Jimmy Gong <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036818}
Move UMA names for segment to config file
The clients should not change the internal files for string mapping,
move the UMA name strings to public file where the keys are defined.
Also clean up the macros introduced in previous cls to workaround.
BUG=1346389
Change-Id: I7b294236335a8a2e20278ced47584ad8adf01593
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3798860
Reviewed-by: Shakti Sahu <[email protected]>
Commit-Queue: Siddhartha S <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036817}
shortcuts: Add ts_library
- Preparatory step for converting shortcut_customization to typescript
- Import Polymer templates at runtime
- Disable closure compiler
- html_to_js -> html_to_wrapper/css_to_wrapper
Bug: b/242549183
Change-Id: Ifedae3a9e47700d497e1995f2ee3b216198e4979
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834682
Reviewed-by: Rebekah Potter <[email protected]>
Commit-Queue: Michael Checo <[email protected]>
Reviewed-by: Jimmy Gong <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036816}
[dPWA Testing] Refactor & simplification pass on tests
This change:
* Changes the site names to be more specific. For example,
SiteA -> Standalone.
* Updates some test actions to take advantage of the new wildcard
feature.
* Updates other tests to use new actions, deleting unnecessary ones.
* Other misc cleanup.
* Shortening names now that the test names are too long.
Bug: b/242063423
Change-Id: Iaf80d30ca6ea0653cca382d9d4f91ed58f9cd07c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3828313
Reviewed-by: Phillis Tang <[email protected]>
Reviewed-by: Dana Fried <[email protected]>
Reviewed-by: Dibyajyoti Pal <[email protected]>
Commit-Queue: Daniel Murphy <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036815}
Add tests for service worker storage key calculation.
https://crrev.com/c/3829514 landed without tests, this CL adds a test to
verify correct storage key calculation in the presence of host
permissions, heavily inspired by the similar tests in
RenderFrameHostImpl.
Bug: 1346450
Change-Id: Id1f6eef1e452b609e1fe4293bebde1287a915c78
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3838684
Reviewed-by: Ben Kelly <[email protected]>
Reviewed-by: Andrey Zaytsev <[email protected]>
Commit-Queue: Marijn Kruisselbrink <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036814}
Revert "Reland "Add Tangible sync flow for signin row in main settings""
This reverts commit df177914f44a95fafbd73b7ec8d5bca732160aa1.
Reason for revert: Failing bots for another reason
https://bugs.chromium.org/p/chromium/issues/detail?id=1353505
Original change's description:
> Reland "Add Tangible sync flow for signin row in main settings"
>
> This reverts commit 7935edc2e4d5a7d963df448334f565695f39a2c1.
>
> Reason for revert:
> Fixes the tests. Sync promo uses the same string as the signin
> preference when there are no accounts.
> In order to fix the tests an account is added to the device so that
> the promo has a different text.
>
> Original change's description:
> > Revert "Add Tangible sync flow for signin row in main settings"
> >
> > This reverts commit 4cee9379113bfc4c729d491143793be5192b49df.
> >
> > Reason for revert: newly added tests fail on bots (see
> > https://crbug.com/1353505).
> >
> > Original change's description:
> > > Add Tangible sync flow for signin row in main settings
> > >
> > > This cl adds the tangible sync flow launch capability to the signin
> > > preference in main settings page. This flow is guarded by a flag.
> > >
> > > Bug: 1332527
> > > Change-Id: I9222fa0512e1fcd55a012a9fa37853a9b66b0226
> > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3819763
> > > Reviewed-by: Boris Sazonov <[email protected]>
> > > Commit-Queue: Tanmoy Mollik <[email protected]>
> > > Cr-Commit-Position: refs/heads/main@{#1035435}
> >
> > Bug: 1332527, 1353505
> > Change-Id: I6e82abcd635da0999b0c7752c77d0ef08986f193
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834451
> > Commit-Queue: Rubber Stamper <[email protected]>
> > Auto-Submit: Boris Sazonov <[email protected]>
> > Bot-Commit: Rubber Stamper <[email protected]>
> > Cr-Commit-Position: refs/heads/main@{#1035761}
>
> Bug: 1332527, 1353505
> Change-Id: I387ba7a5c31e28a8f82726af53ac68c76ced6487
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834251
> Reviewed-by: Boris Sazonov <[email protected]>
> Commit-Queue: Tanmoy Mollik <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1036573}
Bug: 1332527, 1353505
Change-Id: Icd2b88b2d67bf945edc006e09629633a75680541
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3838475
Commit-Queue: Lijin Shen <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Owners-Override: Lijin Shen <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036813}
[webengine] Fix comment reference to enable_basic_printing
Bug: 1272828
Change-Id: Ib2453e4760d43aa37db054278c1e5bc7d4aaf0ea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3840366
Reviewed-by: Sergey Ulanov <[email protected]>
Commit-Queue: Sergey Ulanov <[email protected]>
Auto-Submit: David Dorwin <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036812}
[NTP] Rename task_module files to be recipe_module
The shopping module is no longer supported. Therefore, the task module
is now only for recipes. I left the task verbiage in some places to act as a way to say "a group of recipes", but was more specific about recipe on the file names and for an individual recipe.
Past CL for removing shopping module support:
https://chromium-review.googlesource.com/c/chromium/src/+/3551583
Bug: 1304803
Change-Id: Iff0150dfe054a9168b3cd9497cc4637662f5d9a7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3718433
Reviewed-by: Tibor Goldschwendt <[email protected]>
Commit-Queue: Riley Tatum <[email protected]>
Reviewed-by: Theodore Olsauskas-Warren <[email protected]>
Reviewed-by: Emily Stark <[email protected]>
Reviewed-by: David Trainor <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036811}
Remove CSSModules RuntimeEnabledFeatures entry
This feature shipped in M93 - this CL removes the feature flag
and merges the tests into the import-assertions virtual test suite to
continue the same validation.
[email protected]
Bug: 992499
Change-Id: I9e2ca299333263d341b0bc6ac031dda3895cfe4d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834775
Reviewed-by: Dan Clark <[email protected]>
Reviewed-by: Kouhei Ueno <[email protected]>
Commit-Queue: Daniel Libby <[email protected]>
Reviewed-by: Mason Freed <[email protected]>
Reviewed-by: Hiroshige Hayashizaki <[email protected]>
Auto-Submit: Daniel Libby <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036810}
Roll Perfetto Trace Processor Mac from 8404c1cc9828 to c16f31c6da75
https://android.googlesource.com/platform/external/perfetto.git/+log/8404c1cc9828..c16f31c6da75
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: [email protected]
Change-Id: I61c491831fff4b23ef7eff63d630bb50dbbe8ab7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3838841
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036809}
[Journeys] Add divider view between clusters in queryfull state
Also, modulate the height of the divider: thick in queryfull, thin in
queryless.
Bug: 1352958
Change-Id: I87ff076bbd7e5f2316c38cdd033c37a721bbf241
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3829499
Commit-Queue: Patrick Noland <[email protected]>
Reviewed-by: Brandon Wylie <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036808}
Roll Chrome Win32 PGO Profile
Roll Chrome Win32 PGO profile from chrome-win32-main-1660823934-70140be7d2ce58f76795e07e5d74c4d4024afcfc.profdata to chrome-win32-main-1660845461-8a929a60e3c06ed3ad0ff274f1378b08fca86633.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win-chrome
Tbr: [email protected]
Change-Id: I6c5cd22a0f8d8351bb7ccd82e08452b1d5a1283b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3840509
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036807}
rtc::Event: Accept webrtc::TimeDelta for timed wait.
This CL implements step 2 of the plan in bugs.webrtc.org/14366 to
migrate rtc::Event to use webrtc::TimeDelta.
The CL
* Switches kForever to TimeDelta::PlusInfinity().
* Adds Wait(TimeDelta) and changes Wait(int) to use TimeDelta
instead.
* Adds a method accepting any type of 2 timeout arguments, and
internally converts to TimeDelta arguments.
* Switches the int-based methods to call into the TimeDelta method.
Bug: webrtc:14366
Change-Id: I838c55aad6b0cc6f76acee1b3fa81d940bfc8782
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3833538
Reviewed-by: Mirko Bonadei <[email protected]>
Commit-Queue: Markus Handell <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036806}
[Sheriff] Disable failing crostini tests.
- crostini.NoAccessToDrive.bullseye_stable_gaia
- crostini.ShareDrive.bullseye_stable_gaia
Bug: 1354229
Change-Id: I583df01e038f2af0ef1c948fe630f0261d33710e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3838966
Reviewed-by: Nicolas Ouellet-Payeur <[email protected]>
Commit-Queue: Sophey Dong <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036805}
Structs with user-declared constructors are not aggregates in C++20.
Remove the explicit declarations so this will still compile. No
behavior change.
Bug: 1284275
Change-Id: I7a3ce56be3c909e39ac784f1b23b8c3e5ae39566
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3836677
Auto-Submit: Peter Kasting <[email protected]>
Commit-Queue: Mark Schillaci <[email protected]>
Reviewed-by: Mark Schillaci <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036804}
Only include battery_level_provider on platforms with an impl.
Before this change, battery_level_provider.h was available on all
platforms but would be empty on platforms with no implementations.
Now that the check is implemented using a buildflag in a separate
header (since
https://chromium-review.googlesource.com/c/chromium/src/+/3791716),
we can completely avoid this header on unwanted platforms.
Bug: 1248057
Change-Id: I17508e73f1dc35498f8bb153bc6f0a188d6115fe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3826013
Reviewed-by: Mark Mentovai <[email protected]>
Commit-Queue: Patrick Monette <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036803}
float: Unset background color in MultitaskMenuView.
Avoid hiding corners of the dialog view in dark mode.
Change-Id: I5dae2c36d2daa7a4d39381bfa03357badf120fc7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3835747
Commit-Queue: Sophie Wen <[email protected]>
Reviewed-by: Sammie Quon <[email protected]>
Reviewed-by: Ahmed Fakhry <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036802}
Limit dialog-width increase from main-image use
This makes sure that the main image doesn't increase dialog width by
more than a snapping point.
Bug: None
Change-Id: Ia57d0cb9f8ef86b5286e13a1a4c33a2708ed99cb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3836261
Reviewed-by: Robert Liao <[email protected]>
Auto-Submit: Peter Boström <[email protected]>
Commit-Queue: Robert Liao <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036801}
Update the streams used by the decode_test binary when logging errors.
Update VAAPI decode_test binary to use LOG(ERROR) instead of cout. Additionally,
the usage message will not be printed out through cerr if it being printed due
to an error.
BUG=b:239719493
Change-Id: I8911b1955d7960bdea685d8dd3690018bdac00de
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834489
Reviewed-by: Andres Calderon Jaramillo <[email protected]>
Reviewed-by: Jao-ke Chin-Lee <[email protected]>
Commit-Queue: Joey Allen <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036800}
lacros: Move some ui files to c/b/ui/lacros.
Test: compiles
Bug: none
Change-Id: I1249243db7d43ad6fd967d0d28819f62d43b2d56
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3827994
Commit-Queue: Sammie Quon <[email protected]>
Reviewed-by: Peter Kasting <[email protected]>
Reviewed-by: Mitsuru Oshima <[email protected]>
Reviewed-by: Erik Chen <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036799}
migration: Let GetShieldLayerColor get colors from ui::ColorProvider
Let AshColorProvider::GetShieldLayerColor get colors
from ui::ColorProvider by using the color id corresponding to the
ShieldLayerType.
Fixed: 1350502
Change-Id: Ifdbc4a16d0a5bfa73fa8e0bb2344e91c276e0247
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834811
Reviewed-by: Sean Kau <[email protected]>
Commit-Queue: Connie Xu <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036798}
[tracing] Add trace events for SimpleURLLoader
Add toplevel events for SimpleURLLoader "read from pipe" events and add
base::Location pointing to where the loader has been created.
[email protected]
BUG=b/241911427
Change-Id: I112ffa327b2817f3ab0a3c0dd45c49d774074aa7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3829275
Commit-Queue: Alexander Timin <[email protected]>
Reviewed-by: Takashi Toyoshima <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036797}
migration: Remove GetBackgroundDefaultColor from AshColorProvider
AshColorProvider::GetBackgroundDefaultColor is hardcoded and called by
GetBackgroundColor only. This CL removed this function and let
GetBackgroundColor get the color from ui::ColorProvider by using the
color id kColorAshShieldAndBaseOpaque directly.
Fixed: 1350498
Change-Id: I3e4bbe460a26317cf1156843a9186219f56e3939
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3826196
Commit-Queue: Connie Xu <[email protected]>
Reviewed-by: Sean Kau <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036796}
Reland "Introduce global impression limits."
This is a reland of commit 5223fc6f53872666c269d414f20457a171788527
Change: Make BUILD dependency acyclic.
Original change's description:
> Introduce global impression limits.
>
> The promos manager internally checks the following global impression
> limits:
>
> - No more than 3 promos can be shown per week.
> - No more than 1 promo can be shown every 2 days.
> - A given promo cannot be displayed more than once per month.
>
> Change-Id: I26f821750b27b92b1719533baa8fb8332f216acc
> Bug: 1354115
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834516
> Reviewed-by: Ali Juma <[email protected]>
> Commit-Queue: Benjamin Williams <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1036591}
Bug: 1354115
Change-Id: I038efb2d7de7ccf3987e868132bdc1a133377f32
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3838392
Reviewed-by: Mike Dougherty <[email protected]>
Commit-Queue: Benjamin Williams <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036795}
wallpaper: fix crash in extension api
chrome.wallpaper.setWallpaper extension api can cause a crash when
called repeatedly in a tight loop when prior requests to decode
wallpaper are canceled.
Order of events:
request A to decode wallpaper begins
request B to decode wallpaper begins
request A is notified of cancellation
request A finishes decoding and runs cancel_cb, which clears
wallpaper_settings_
request B finishes decoding and attempts to access wallpaper_settings_
Instead use data_decoder::DecodeImage directly and pass necessary
data through callbacks. This prevents multiple requests from fighting
over setting and clearing wallpaper_settings_.
BUG=1352659
TEST=browser_tests --gtest_filter="*WallPaperApi*"
TEST=open a wallpaper extension, click the button to change wallpaper
very quickly dozens of times, no crash
TEST=use wallpaper extension from lacros browser
Change-Id: I21e29c0dd0061a0c9e97e1c30c92644c8ff566a7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3830316
Reviewed-by: Erik Chen <[email protected]>
Commit-Queue: Jeffrey Young <[email protected]>
Reviewed-by: Xiaohui Chen <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036794}
[Autofill] Remove expired metric Autofill.IcuCollatorCreationSuccess.
The metric expired in M77 but was not removed from the code.
Bug: 975625
Change-Id: I0c5530470bb49896c37676e6515309ddc01aad16
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3838715
Reviewed-by: Vidhan Jain <[email protected]>
Commit-Queue: Vidhan Jain <[email protected]>
Auto-Submit: Christoph Schwering <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036793}
Feedback: Metrics to record user's exit path
*User exit path includes:
kQuitSearchPageHelpContentClicked,
kQuitSearchPageNoHelpContentClicked,
kQuitNoResultFound,
kQuitShareDataPageHelpContentClicked,
kQuitShareDataPageNoHelpContentClicked,
kSuccessHelpContentClicked,
kSuccessNoHelpContentClicked
*Uses postMessage to communicate between chrome-untrusted:// page
and chrome:// page
Bug: b:185624798
Test: browser_tests --gtest_filter=OSFeedbackBrowserTest.*
Change-Id: Ic75c34a0d9dc420e71ec12e33bf83c91d3bc53c4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3811341
Commit-Queue: Longbo Wei <[email protected]>
Reviewed-by: Jimmy Gong <[email protected]>
Reviewed-by: Xiangdong Kong <[email protected]>
Reviewed-by: Mustafa Emre Acer <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036792}
[PriceTracking] Handle clicks within price tracking side panel UI
Bug: 1346624
Change-Id: I6bc29c78a678708b95c46728ba83093b55aac674
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832658
Reviewed-by: Alex Gough <[email protected]>
Commit-Queue: Yue Zhang <[email protected]>
Reviewed-by: John Lee <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036791}
PrivacyIndicators: Refactor AppAccessNotifier unit tests
Use 2 different test suites: one is for general app access tests
(parameterized for both cases when feature is on and off), one is
specifically for privacy indicators feature. This refactor will remove
unnecessary set up and tear down in the test suite.
Change-Id: Ie56c60d1e50fdee9a8a916e0f2c0854c893d7248
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3840397
Commit-Queue: Andre Le <[email protected]>
Reviewed-by: James Cook <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036790}
Update the shelf app menu when the browser window name is set
Originally, the shelf app menu always shows the active tab name of the
browser window. However, we want to have the window name of the
browser gets shown on the shelf app menu. This cl add logic to take
that issue into consideration.
Bug: 1351882
Change-Id: Ia7ae08e9bea6063226f4aa8e502dcc141ef467db
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3840302
Commit-Queue: Wen-Chien Wang <[email protected]>
Reviewed-by: James Cook <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036789}
Add PasswordManager.ImportFileSize metric
The metric tracks the size of the file selected by the user during import flow.
Bug: 1325290
Change-Id: I5788ad6cd9341c2e05ad3ba53a5e08ff3973f9df
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3838594
Reviewed-by: Mohamed Amir Yosef <[email protected]>
Commit-Queue: Andrii Natiahlyi <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036788}
wm: Remove redundant code
In HidingWindowAnimationObserverBase, OnAnimationCompleted has the
code "delete this;" invoking the destructor which contains the code
"window_->RemoveObserver(this);" and therefore there is no need for
OnAnimationCompleted to also have "window_->RemoveObserver(this);"
Bug: None
Change-Id: I43a251e20506d5f01a40c5b58107b702c0b30e9f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3838963
Reviewed-by: Scott Violet <[email protected]>
Commit-Queue: Avery Musbach <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036787}
Adjust layout to fix alignment
The ChannelIndicatorQuickSettingsView was added, but the layout
was not correct. This resulted in the UnifiedSystemInfoView being
too big, and center aligned.
- Remove insets on the child views, which were doubling desired insets.
- Let child views stretch along the cross-axis (horizontally)
- Give child views center or start alignments so they are properly
start or center aligned.
(with channel indicator)
https://screenshot.googleplex.com/3PmWgy6fGBhJvRe.png
(no channel indicator)
https://screenshot.googleplex.com/A5xuAAz6CrjjbKN.png
(incorrect UI)
https://screenshot.googleplex.com/6Axwsb4vEH6fpio
bug: 1349933
Change-Id: I30683c211fafa4e5bb09867c79d8882b19b38d49
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832517
Quick-Run: Alex Newcomer <[email protected]>
Commit-Queue: Alex Newcomer <[email protected]>
Reviewed-by: Roger Tinkoff <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036786}
Reland "Add first Promo class unit test."
This is a reland of commit e5e95ff0b49ef0ba973e0ddaf9afcab217847db1
Change: Update Promo* initializers to the latest version.
Original change's description:
> Add first Promo class unit test.
>
> Change-Id: Iaead9b53af28bec227cb04dcae86524df4587092
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832702
> Reviewed-by: Joemer Ramos <[email protected]>
> Commit-Queue: Benjamin Williams <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1036635}
Change-Id: I7d27eaa91579137fe9200ddbd2d45003f201f2f6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3838393
Reviewed-by: Joemer Ramos <[email protected]>
Commit-Queue: Benjamin Williams <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036785}
[PriceTracking] Add initial list UI in side panel
This CL adds the list UI of price tracking and adds it to the existing
side panel bookmark list UI. This CL also adds tests for the
rendering of the list UI.
Bug: 1346624
Change-Id: I83d31a04f6dda91d77c8cc0d7e91b1c049a51084
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3829154
Reviewed-by: John Lee <[email protected]>
Commit-Queue: Yue Zhang <[email protected]>
Reviewed-by: Matthew Jones <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036784}
PrivacyIndicators: Change view and icons visibility when appropriate
Change PrivacyIndicatorsTrayItemView and its icons according to
camera/mic access. Added unit tests in both //ash and //chrome/browser.
Fixed: 1352595
Change-Id: I1679f83f91852ccedf1808620d18a26ef6f67697
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832791
Reviewed-by: James Cook <[email protected]>
Reviewed-by: Alex Newcomer <[email protected]>
Commit-Queue: Andre Le <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036783}
[DevTools] Eliminate usage of deprecated send command wrapper in tests.
This CL removes last occurrences of the deprecated SendCommand() wrapper
that uses obsolete base::DictionaryValue type and the wrapper itself,
Change-Id: I0924116ede2d9fad156122a1ddaed88488d78c64
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3840468
Commit-Queue: Peter Kvitek <[email protected]>
Reviewed-by: Andrey Kosyakov <[email protected]>
Reviewed-by: Alexander Timin <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036782}
clone and use upstream wpt
Currently we are using a local copy of wpt and wpt tests. What we want is to use the upstream tests from github in order to have more consistent test results.
In this CL we are doing the following:
- add a tag that allows usage of upstream path
- if upstream is active then clone repo
- if upstream is active then use the upstream wpt + tests
- update builder to include --use-upstream-wpt
Change-Id: Ida3ea7a02d6eb4dd1f575ef7f9580f935dd83c3e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3829678
Reviewed-by: Jonathan Lee <[email protected]>
Reviewed-by: Weizhong Xia <[email protected]>
Commit-Queue: Nihar Damarasingu <[email protected]>
Reviewed-by: Brian Sheedy <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036781}
Remove base="true" from USB.ExternalDeviceAttached histogram
USB.ExternalDeviceAttached does not use suffix, so base="true" is not
needed. With base="true", USB.ExternalDeviceAttached is not selectable
in UMA.
USB.ExternalDeviceAttached histogram added in crrev.com/c/3756855
Bug: b/236890076
Change-Id: Ib3668f12427e4ab32038a7f4e355aa3e72274ea6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3836855
Reviewed-by: Chad Duffin <[email protected]>
Commit-Queue: Won Chung <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036780}
[RDSD] Desktop site app menu setting updates
- Remove the RDS setting entry from the app menu on native pages including History/Downloads/Bookmarks/Recent tabs/NTP
- Add a feature engagement event to track usage of the RDS setting on the app menu for the current tab-level setting implementation
Bug: 1353598, 1353597
Change-Id: Iaef673bf61abfd5efe74c75ebe051100c248289e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834420
Reviewed-by: Shu Yang <[email protected]>
Commit-Queue: Aishwarya Rajesh <[email protected]>
Reviewed-by: Theresa Sullivan <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036779}
Roll Chrome Win64 PGO Profile
Roll Chrome Win64 PGO profile from chrome-win64-main-1660834523-5357c1014f567bf4898228b2c78273127462122f.profdata to chrome-win64-main-1660845461-5fa07676dae6b878d4fbaa3c8a21edc10dfbdd34.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win64-chrome
Tbr: [email protected]
Change-Id: If75576d678c85ff4d2274d1af77416711dd6ed67
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3839233
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036778}
Roll Chrome Mac Arm PGO Profile
Roll Chrome Mac Arm PGO profile from chrome-mac-arm-main-1660823934-1c59750fb448eb4a5cb00d927bf2af94d44355d4.profdata to chrome-mac-arm-main-1660845461-6d2b87a64ef678c60f5022188c9f845300d5c23d.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-arm-chromium
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:mac-chrome
Tbr: [email protected]
Change-Id: I5deb0e2a6ed3a92c1978742cd322dc69814702a3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3839255
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036777}
Roll Chrome Linux PGO Profile
Roll Chrome Linux PGO profile from chrome-linux-main-1660823934-e6502543dd9b12af2179cf56baa23b61d083b0a8.profdata to chrome-linux-main-1660845461-6907d5caac9a3a7552d52bf333c970cd7960238a.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-linux-chromium
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:linux-chrome
Tbr: [email protected]
Change-Id: I2934191fd6708c36da793d6347f0d2d165499e1f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3840409
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036776}
Disable component update for chrome for testing.
Chrome for Testing binaries should have a fixed version and never
update.
For context, see https://goo.gle/chrome-for-testing
Bug: 1336611
Change-Id: I1591f22171b765589a38e9ad4f7b24884c726c5b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3824980
Reviewed-by: Joshua Pawlicki <[email protected]>
Auto-Submit: Thiago Perrotta <[email protected]>
Reviewed-by: Nico Weber <[email protected]>
Commit-Queue: Thiago Perrotta <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036775}
Shows the app icon in scrollable shelf when activating the app.
This cl adds a functionality that, when an app is opened or activated,
the scrollable shelf view will automatically update its offset to show
the activated icon.
Bug: 1068956
Change-Id: Idad938112682e6f1645c04dd42cd58b4883f875f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3817242
Reviewed-by: James Cook <[email protected]>
Reviewed-by: Andrew Xu <[email protected]>
Commit-Queue: Wen-Chien Wang <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036774}
Roll Chrome Mac PGO Profile
Roll Chrome Mac PGO profile from chrome-mac-main-1660823934-91cc3328a61ccf2ecfe29ed7ad1071291ae93af7.profdata to chrome-mac-main-1660845461-3452705c6146cc61ae9f7b278a773834dc6bec58.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:mac-chrome
Tbr: [email protected]
Change-Id: Ib2ab27d34dbf314fcf80e713009a2575418d8a03
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3840508
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036773}
glanceables: Rename welcome_label related files
Bug: 1353488
Test: no changes in logic
Change-Id: Ic0bfdab303afae65b64fc952fd506040db2c1bd7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3840388
Commit-Queue: James Cook <[email protected]>
Auto-Submit: Artsiom Mitrokhin <[email protected]>
Reviewed-by: James Cook <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036772}
usb: Move WebUsbServiceImpl to //content
This CL moves the implementation of the blink::mojom::WebUsbService
mojo interface from the embedder layer to the content layer.
Ownership of the UsbDelegate is moved from WebUsbServiceImpl to
the ContentBrowserClient which now has a GetUsbDelegate method.
Previously, the lifetime of WebUsbServiceImpl was managed by
FrameUsbServices. Now it is a self-owned DocumentUserData with
the same lifetime.
Previously, UsbTabHelper managed the connected USB device state.
Now WebContentsImpl manages this state and clients observe
WebContents directly.
Browser tests (//chrome/browser/usb/usb_browsertest.cc) and unit
tests (//chrome/browser/usb/web_usb_service_impl_unittest.cc) are
moved to //content but the embedder-specific versions of the tests
are retained as chrome_usb_browsertest.cc and
chrome_usb_delegate_unittest.cc.
Bug: 991759, 1220314
Change-Id: I2ed528acc6dbc5667ae22b9219a1320226792a40
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3671829
Commit-Queue: Matt Reynolds <[email protected]>
Reviewed-by: Kinuko Yasuda <[email protected]>
Reviewed-by: Reilly Grant <[email protected]>
Reviewed-by: Dana Fried <[email protected]>
Reviewed-by: Francois Pierre Doray <[email protected]>
Reviewed-by: Brandon Jones <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036771}
[Sheriff] Disable flaky Dictation/SmartCapitalization test.
Bug: 1354284
Change-Id: Ie07dc669ac9e22495ba086de258a230cdcd11445
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3838828
Commit-Queue: Sophey Dong <[email protected]>
Owners-Override: Sophey Dong <[email protected]>
Reviewed-by: Nicolas Ouellet-Payeur <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036770}
EV checking: Stop checking revocation for EV in builtin proc
Bug: 1268848
Change-Id: I5b4a3abbd51a2ee0fbdc199eb98425425e331ab6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3782902
Reviewed-by: Matt Mueller <[email protected]>
Reviewed-by: Carlos IL <[email protected]>
Commit-Queue: Hubert Chao <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036769}
Android OSK resizes visual viewport behind flag
With this flag, the Android On-Screen Keyboard no longer resizes the
page (and so doesn't cause the page to relayout), instead resizing only
the visual viewport.
This updates the ApplicationViewportInsetSupplier class to allow two
kinds of insets, "stacking" and "overlapping". Stacking insets are meant
for UI components that are displayed together; in this case, the
on-screen keyboard along with the autofill accessory that appears on top
of it. Overlapping insets are for unrelated UI that would overlay each
other.
The approach in this CL reuses the approach taken by the
Virtual-Keyboard API's overlaysContent attribute which similarly avoids
resizing the page.
Doc: https://docs.google.com/document/d/1RwvFxq-DM8LlKTeh-r_oL8-7EpM_UvC81BAO5lWWk48/edit?hl=en&forcehl=1#
Bug: 1353728
Change-Id: Ia1c3772aac1e5c71a1e5efacbc4cc0d413de0c5a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3749398
Reviewed-by: Matthew Jones <[email protected]>
Reviewed-by: Ted Choc <[email protected]>
Reviewed-by: Xi Han <[email protected]>
Commit-Queue: David Bokan <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036768}
Record Translate.CompactInfobar.Event metrics for Translate Message UI.
In order to make the Translate Message UI more easily comparable to the
infobar UI, the Translate Message UI should record
Translate.CompactInfobar.Event metrics whenever the comparable events
occur.
Bug: 1354247
Change-Id: I15f7d6c7e67fbb0c64519cfa2ed26723d898828e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3840334
Commit-Queue: Scott Little <[email protected]>
Reviewed-by: Trevor Perrier <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036767}
Make notifyEvent params argument optional
Bug: b/242549183
Change-Id: I882aa27fe4401b03492d45835761b417c7877b6a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3838718
Auto-Submit: Michael Checo <[email protected]>
Reviewed-by: Ashley Prasad <[email protected]>
Commit-Queue: Ashley Prasad <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036766}
[remoting host][linux] Allow WebAuthn NMH to run after Chrome update
remote_webauthn refuses to run after Chrome has been updated but hasn't
been relaunched. It turns out the problem is that Chrome has updated its
binary in its path, but the Chrome process is still the old one until it
gets relaunched. In this case the Chrome process' exe symlink will point
to "/opt/google/chrome/chrome (deleted)", which is not in
kAllowedCallerPrograms.
Given Chrome doesn't immediately push users to relaunch Chrome after the
update, we should still keep the NMH working in this state.
This CL fixes this problem by stripping " (deleted)" from the image path
if the image path doesn't exist. This is safe since the path is still
unspoofable. Creating a binary with a path ending with " (deleted)"
won't work since the path exists.
Bug: 1353928,b/240178477
Change-Id: I2fcd89f33c65b7d2f0235f6b08d0d7746a5442e8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834434
Reviewed-by: Joe Downing <[email protected]>
Commit-Queue: Yuwei Huang <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036765}
Speculatively re-enable AppViewTest.TestAppViewRefusedDataShouldFail
When tested locally with --gtest_repeat=50, this exhibited no flakes.
Bug: 875908
Change-Id: I6fbea5397f769d882005701c24d11f193a897450
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3838806
Reviewed-by: James Maclean <[email protected]>
Auto-Submit: Kevin McNee <[email protected]>
Commit-Queue: James Maclean <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036764}
breadcrumbs: remove temporary CHECKs
crrev.com/c/3437935 added temporary CHECKs to try and understand a
crash. The crash is now understood, so this change removes the CHECKs
and associated comment.
Bug: 1287441
Change-Id: Ib2efb4985331862bbe76848968ed58bf2ba4a64c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3835034
Reviewed-by: David Bienvenu <[email protected]>
Commit-Queue: Jesse McKenna <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036763}
[Web Locks] Update RequestImpl resolver checks
Updates the resovler checks in the `RequestImpl` method to help resolve a Clusterfuzz error that was partially fixed in cl/3832518.
Bug: 1347389
Change-Id: I4eaf8f1d700287262a74368893f5404cffa622c9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3840427
Reviewed-by: Ayu Ishii <[email protected]>
Commit-Queue: Christine Smith <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036762}
check_annotations: Fix --limit option
Setting the --limit option crashes this script because it's treated as
an int, but the default type for parsed arguments is string. Fix this
by setting type=int in the argument parser.
Bug: none
Change-Id: Iedbfc6b5af10a731212eecbc60fe7efcabdde15c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3831147
Auto-Submit: Fergus Dall <[email protected]>
Commit-Queue: Fergus Dall <[email protected]>
Reviewed-by: Nico Weber <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036761}
Add field trial config for kIOSNewOmniboxImplementation.
The feature name (starting with lowercase k) predates the current
naming convention, or at least the presubmit check to prevent it.
Fix prerenderer test which can't find autocompleted text in the
old way with flag on.
Bug: none
Change-Id: I5189cb1093f9a600af8f718221761e006e4d8a68
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3831541
Auto-Submit: Stepan Khapugin <[email protected]>
Commit-Queue: Rohit Rao <[email protected]>
Reviewed-by: Rohit Rao <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036760}
[Toolbar] Remove the toolbar enter/exit animation code
This code is now effectively dead; the toolbar is not drawn during tab
switcher enter/exit because it's invisible until the transition
finishes. Even createPostExitTabSwitcherAnimation, which nominally
occurs after setting the toolbar to visible, is dead because we don't
even enable animations at the same time as we use the accessibility tab
switcher, which is a pre-condition for this delayed animation.
Note that there is still an apparent cross-fade when showing/hiding
the tab switcher toolbar but this is the result of blending the tab
switcher toolbar with the toolbar bitmap.
This change also removes some other now-defunct animation code related
to the OptionalButton that was made obsolete by a recent refactoring.
Bug: none
Change-Id: Ia0391d435ee50ff31feec3ba08e352b4bf820888
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3817873
Commit-Queue: Patrick Noland <[email protected]>
Reviewed-by: Theresa Sullivan <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036759}
Refactor CartService to use PrefService::GetValueList
This is part of a larger migration effort based on
go/trust-your-prefs.
Bug: 1341998
Change-Id: Id5ce2a8cc82200b76723aa5c76824016656c40a2
Tests: Existing unit tests
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3831542
Reviewed-by: Paul Adedeji <[email protected]>
Commit-Queue: Roland Bock <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036758}
Update WebUI HelpBubble basic layout
Update HelpBubble style and basic functionality to match all IPH variants, i.e.:
- Title and/or body text only
- Title and/or body text with buttons
- Title and/or body text with info icon (placeholder)
- Progress bar with body text
Also:
* Add force_close_button to mojo params to cover variants that show a close button.
* Update tests to match new markup
* Add messages to all tests for debugging
Bug: 1350589
Change-Id: Id6f6bd854583ae2330ee4ab3b1e13958aa0d0361
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3827503
Commit-Queue: Mickey Burks <[email protected]>
Reviewed-by: Dana Fried <[email protected]>
Reviewed-by: Joe Mason <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036757}
[reclient] Turn off racing on Comparison Builders
Turn off racing for RBE exec strategy on Comparison Mac (reclient), Comparison Mac arm64 (reclient), and Comparison ios (reclient).
Bug: b/242206117
Change-Id: Ib370da914dec1ab4ef6dadda8435eb8ef19d74d7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3840627
Commit-Queue: Andus Yu <[email protected]>
Reviewed-by: Garrett Beaty <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036756}
webauthn: fix autofill on Android 13.
Listing credentials is the one case that we care about where the objects
passed to and from Play Services aren't just SafeParcelables: the
returned value is an array of SafeParcelable objects instead.
The SafeParcelable format is difficult to change, and thus fairly
stable, but the high-level Parcel format can change.
In order to support skipping values, Android 13 now includes an extra
length prefix in this higher-level format and this needs to be
accommodated. That change isn't difficult but, in order to better catch
these things in the future, I've added a unittest to check the
serialisation is as expected.
Change-Id: I72e189b901a151cbf36ebbcc095d7041907d0442
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3838720
Reviewed-by: Ken Buchanan <[email protected]>
Commit-Queue: Adam Langley <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036755}
Avoid unnecessary breaks before a repeated table footer.
We got confused by a repeat break token, and refused to place a zero
pixels "tall" repeated table footer even if there was just enough space
for it (exactly zero pixels).
Bug: 1354141
Change-Id: I5285156e7224d26f77e54ed1ea6eae10877eaaff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3838771
Reviewed-by: Alison Maher <[email protected]>
Reviewed-by: Ian Kilpatrick <[email protected]>
Commit-Queue: Morten Stenshorne <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036754}
Postpone the expire date of Net.SpdySession.AlpsDecoderStatus
Change-Id: I3ad8559b6894c480470723e9a7fc35685bf21aef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834200
Reviewed-by: David Schinazi <[email protected]>
Commit-Queue: Fan Yang <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036753}
Extend expiry of speed metrics histograms by 1y.
This extends the expiry of the following histograms:
PageLoad.Clients.FromGoogleSearch.FromSidePanel.PaintTiming.NavigationToFirstImagePaint
PageLoad.Clients.LayoutInstability.MaxCumulativeShiftScore.Subframe.*
PageLoad.Clients.AMP.LayoutInstability.MaxCumulativeShiftScore.Subframe.*
(33 in all after expansion)
Bug: 1343447, 1352991, 1352992, 1352993, 1352994, 1352995, 1352996, 1352997, 1352998, 1352999, 1353000, 1353001, 1353002, 1353003, 1353004, 1353005, 1353006
Change-Id: I1ba27d47a7958f385ed290ea0235bdfe3a797a2a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3838622
Reviewed-by: Annie Sullivan <[email protected]>
Auto-Submit: Ian Clelland <[email protected]>
Commit-Queue: Annie Sullivan <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036752}
Refactors DecoderClient to pass along cache type for storing entries.
- Updates the gpu->browser storing calls so that they require a cache
type since there can be more than 1 gpu side cache now.
- Updates all testing references accordingly.
- Renames the function so that it is clear that we can store arbitrary
blobs, not just shaders anymore.
Bug: dawn:549
Change-Id: I015bb051d1fbd1ce7addf70b65aa6babaaaef72e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3787288
Commit-Queue: Loko Kung <[email protected]>
Reviewed-by: Austin Eng <[email protected]>
Reviewed-by: Sunny Sachanandani <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036751}
Fix progress-based-animation-test
The test was not waiting for the loading to complete. It was possible
to run the test before the animation started. This patch waits for the
animation to start before updating the scroll position and testing the
computed style.
Bug: 1350542
Change-Id: I0dea471ebd6d2f3c3c40d1044ff191eef69a11f9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3840387
Reviewed-by: Mustaq Ahmed <[email protected]>
Commit-Queue: Kevin Ellis <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036750}
Add CustomizationFacet with CLOUD_GAMING_DEVICE entry in DemoModeDimensions in UMA.
Doc: go/demo-mode-uma-dimension-feature-list
privacy: b/242072563
Bug: 242072563
Change-Id: I9d9fa29af8c705337e22eb8291cd22cd8b31b812
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3837172
Reviewed-by: Steven Holte <[email protected]>
Commit-Queue: Bowen Li <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036749}
kerberos: Validate krb5 config on "Advanced" click
Previously the syntax of the config was checked only when the user
tried to change it. Since the invalid config can be inserted via
policy, the config should be validated the moment the user sees it to
avoid cryptic behaviour.
BUG=chromium:1349058
Change-Id: I76906aefae4f7236d5ed40d1eae4e0cfff4fb0bb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3823075
Auto-Submit: Michael Slutskii <[email protected]>
Reviewed-by: Jimmy Gong <[email protected]>
Commit-Queue: Jimmy Gong <[email protected]>
Commit-Queue: Felipe Andrade <[email protected]>
Reviewed-by: Felipe Andrade <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036748}
Refactor Value usage in chrome\browser\media\router\providers\cast, CL3
Remove CastSession::From() overload that takes a Value instead of a
Value::Dict.
Bug: 1187001,1338341
Change-Id: Id0a1706dde4c659240933df6ed81bf9024ef1957
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3810664
Reviewed-by: Mark Foltz <[email protected]>
Commit-Queue: Matt Menke <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036747}
Revert "Add first Promo class unit test."
This reverts commit e5e95ff0b49ef0ba973e0ddaf9afcab217847db1.
Reason for revert: Need to use proper inits for Promo*
Original change's description:
> Add first Promo class unit test.
>
> Change-Id: Iaead9b53af28bec227cb04dcae86524df4587092
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832702
> Reviewed-by: Joemer Ramos <[email protected]>
> Commit-Queue: Benjamin Williams <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1036635}
Change-Id: I76ef845263d248a3e982573639cc385560c4ac02
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3838371
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Auto-Submit: Benjamin Williams <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036746}
Disable send-tab-to-self sign-in promos on Lacros
We can't handle those yet, so disable in the meantime.
Bug: 1219433
Change-Id: I04790a14a9ffcea3efb159e4e947e7d0f5b4e4f8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3838816
Commit-Queue: Elly Fong-Jones <[email protected]>
Auto-Submit: Victor Vianna <[email protected]>
Commit-Queue: Victor Vianna <[email protected]>
Quick-Run: Victor Vianna <[email protected]>
Reviewed-by: Elly Fong-Jones <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036745}
Fix -Wshadow instances in net/.
Bug: 1344231
Change-Id: I594a260d034d67bc1d462d339ce2ae776b5cf8c7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3835061
Commit-Queue: Matt Mueller <[email protected]>
Auto-Submit: Peter Kasting <[email protected]>
Reviewed-by: Matt Mueller <[email protected]>
Commit-Queue: Peter Kasting <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036744}
Revert "Introduce global impression limits."
This reverts commit 5223fc6f53872666c269d414f20457a171788527.
Reason for revert: Breaks build due to bad BUILD rule.
Original change's description:
> Introduce global impression limits.
>
> The promos manager internally checks the following global impression
> limits:
>
> - No more than 3 promos can be shown per week.
> - No more than 1 promo can be shown every 2 days.
> - A given promo cannot be displayed more than once per month.
>
> Change-Id: I26f821750b27b92b1719533baa8fb8332f216acc
> Bug: 1354115
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834516
> Reviewed-by: Ali Juma <[email protected]>
> Commit-Queue: Benjamin Williams <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1036591}
Bug: 1354115
Change-Id: I5c3f6916fe9dc815f3838f19cb6445d628913ba0
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3838296
Commit-Queue: Rubber Stamper <[email protected]>
Auto-Submit: Benjamin Williams <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036743}
Add strings for the Translate Message UI dismissal tooltip.
These strings are for the eventual Translate Message UI dismissal
tooltip, see
https://chromium-review.googlesource.com/c/chromium/src/+/3645546 for
the separate CL with functionality. These strings are being landed
before the rest of the functionality in order to make sure they land
before branch.
Bug: 1324357
Change-Id: I1cc093d23aa8bdc0b2024db25f3eb31e29770e1c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3835275
Reviewed-by: Trevor Perrier <[email protected]>
Auto-Submit: Scott Little <[email protected]>
Commit-Queue: Scott Little <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036742}
Launch VisualFeaturesInCsppPings
Stable 1% metrics are positive, and we have privacy approval for the
full launch.
Bug: 1316024
Change-Id: I97fd07ea3c36673b4903ead1bd413f0b1cb1b8c5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3840266
Reviewed-by: Rohit Bhatia <[email protected]>
Commit-Queue: Daniel Rubery <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036741}
[ZPS] Fix bug due to unconstrained ZPS cache size
The recent updates made to the zero-prefix suggest cache to accommodate
ZPS prefetching on SRP and Web did not introduce an upper limit on the
size of the ZPS cache. In the absence of any eviction policy, this would
result in the cache growing to an unbounded size and bloating the
Preferences JSON file's size (at least until the user cleared their
browsing history).
This CL fixes the issue by enforcing a limit of a single entry in the
ZPS cache for URL-based ZPS requests.
Bug: 1344004
Change-Id: Idabdb3a5a5cfbde60aa3b08b9d40f556fc41976e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3835654
Reviewed-by: Moe Ahmadi <[email protected]>
Commit-Queue: Khalid Peer <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036740}
Extract RoundByteSize method from StorageHandler.
Extract and expose RoundBytesSize so it can be used by
DeviceStatusCollector to upload device storage and display
it in the admin console.
Bug: b:235136592, b:238441744
Change-Id: I887538da29feae2625061e583e289fa69318ca59
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834589
Commit-Queue: Ahmed Nasr <[email protected]>
Reviewed-by: Kyle Horimoto <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036739}
ash: No channel indicator QS buttons in login/lock screen
Only construct the channel indicator quick settings UI if the session
state is ACTIVE.
Bug: 1353847
Change-Id: I106c9e2fe60ec77ffd4ff08a8afc3f615837b00b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3838937
Reviewed-by: Alex Newcomer <[email protected]>
Commit-Queue: Alex Newcomer <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036738}
[Sheriff] Disable lacros.Basic
Bug: 1354215
Change-Id: I58fd5adeffce8c7f13dfac113da3d9d668f9626d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3838786
Reviewed-by: Nicolas Ouellet-Payeur <[email protected]>
Commit-Queue: Sophey Dong <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036737}
[AppLanguagePrompt] Add shouldshow tests
This CL adds tests for AppLanguagePromoDialog#shouldShowPrompt()
Bug: 1351483
Change-Id: I02056b4710eded85b748609cb3f0406349f11389
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832319
Commit-Queue: Trevor Perrier <[email protected]>
Reviewed-by: Josh Simmons <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036736}
Regroup base/power_monitor source files in base/BUILD.gn
Currently, some files are only included when is_nacl is false, and some
are unconditionally included. Group them up together in the
unconditional list.
Bug: 1248057
Change-Id: I43bc4677432564db04a39dae1cfbb628e9c52f09
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3825907
Reviewed-by: Daniel Cheng <[email protected]>
Auto-Submit: Patrick Monette <[email protected]>
Commit-Queue: Patrick Monette <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036735}
blink::Color: Store 4 floating-point values instead of an RGBA32
Prior to this change, a blink::Color was internally just an RGBA32, or
uint32_t. Now, blink::Color stores 4 floats.
Internally, change Color::Rgb() to call Color::toSkColor4f(), rather
than vice-versa.
This increases the size of a blink::Color from 4 bytes to 16 bytes. It
also removes the ability to treat a blink::Color interchangeably with
a uint32_t.
Binary-Size: Size increase is unavoidable (see above).
Bug: 1351544
Change-Id: I34f09a7e2dfd149cde1760d50bd00afc0615b293
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834252
Reviewed-by: Juanmi Huertas <[email protected]>
Commit-Queue: ccameron chromium <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036734}
[fuchsia] workstation_eng uses '.' rather than '-' to split the parts
Bug: fuchsia:99495
Change-Id: I8e27e4606d2da471ca42e2c155d5e79e0bb6ed37
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3835781
Reviewed-by: Chong Gu <[email protected]>
Reviewed-by: Fabrice de Gans <[email protected]>
Commit-Queue: Kevin Marshall <[email protected]>
Reviewed-by: Kevin Marshall <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036733}
Roll Catapult from e12cc61cfa3d to 72946313ec4f (1 revision)
https://chromium.googlesource.com/catapult.git/+log/e12cc61cfa3d..72946313ec4f
2022-08-18 [email protected] Disable coverage when test filter passed to typ test runner
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/catapult-autoroll
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: chromium:1347302
Tbr: [email protected]
Change-Id: I9d42d6e222f500b67b0be33bb6b2db37f75c707f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3839270
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036732}
Roll Skia from be6380e00df1 to 439c4708a042 (10 revisions)
https://skia.googlesource.com/skia.git/+log/be6380e00df1..439c4708a042
2022-08-18 [email protected] [Graphite] Move create/deleteBackendTexture off Context/SharedContext.
2022-08-18 [email protected] [Graphite] Add general support for render steps to emit a primitive color
2022-08-18 [email protected] Remove StrikeRef
2022-08-18 [email protected] [Graphite] Set local coordinates varying within VerticesRenderStep
2022-08-18 [email protected] Remove Context reference from inside each SymbolTable.
2022-08-18 [email protected] Guard use of execinfo.h with glib in VkTestUtils
2022-08-18 [email protected] Roll ANGLE from 2965f81b83e5 to c6c7ff3c45bb (3 revisions)
2022-08-18 [email protected] Add SkSL test for exact integer division in ES3.
2022-08-18 [email protected] Roll SwiftShader from ab4bf6ad00d4 to 1c3dfde53353 (1 revision)
2022-08-18 [email protected] [Graphite] Add ability to define stepLocalCoords from RenderSteps (set to varying in SkSL)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Cq-Do-Not-Cancel-Tryjobs: true
Bug: None
Tbr: [email protected]
Change-Id: I13e81c6ccb10aec7d797f9c3f50c1847e452e27a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3839272
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036731}
[lacros skew tests] Refresh skew tests for M106
This CL updates the ash version ['106.0.5248.0'] for Lacros version skew testing.
If this CL caused regressions, please revert and stop the autoroller
at https://luci-scheduler.appspot.com/jobs/chrome/lacros-version-skew-roller
Also please file a bug to OS>LaCrOS>Partner, and CC [email protected],
[email protected].
[email protected]
Bug: None
Change-Id: Icc233995fcce63f77cefb5d93cb54846b7d122b4
Requires-Testing: True
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3840426
Auto-Submit: chrome-weblayer-builder <chrome-weblayer-builder@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Rubber Stamper <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036730}
[Read Anything] Save user choice for colors to prefs
This CL continues the work on the toolbar for the Read Anything
feature.
With this CL we add a new enum to the read_anything.mojom to define
the valid theme choices. We use this enum (as an int) to save
and read a user's color choice to prefs.
AX-Relnotes: N/A
Bug: 1266555
Change-Id: Ib9ff886cefda291ded66a1bc74d48bebdd2a505d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3831845
Reviewed-by: Alex Gough <[email protected]>
Commit-Queue: Mark Schillaci <[email protected]>
Reviewed-by: Abigail Klein <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036729}
arc: Cleanup DPC compliance metrics reporting code
Compliance metrics are expired and we don't need to revive them so we're
cleaning the code and histogram.xml file.
BUG=b:227195677
TEST=tast run DUT enterprise.ARCProvisioning
TEST=./out_Default/Release/unit_tests --gtest_filter='ArcPolicyBridge*'
Change-Id: I356213e4714a1dc684822979548cf383d22ebd51
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3837017
Auto-Submit: Muhammad Hasan Khan <[email protected]>
Commit-Queue: Yao Li <[email protected]>
Reviewed-by: Yao Li <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036728}
[signin] Do not silently grant ConsentLevel::kSync if sync is disabled
Some implementations of TurnSyncOnHelper::Delegate want to silently
abort the sync flow if the sync is disabled. The current way of doing
that (returning LoginUIService::SYNC_WITH_DEFAULT_SETTINGS) is bad
because it grants ConsentLevel::kSync without showing any consent UI.
This CL introduces a new TurnSyncOnHelper::Delegate method that allows
to abort the sync flow when sync is disabled without removing the
account.
Fixed: 1354130
Change-Id: Idc027432c605b3fd48b63a69746e03a709abf530
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3838610
Reviewed-by: Nicolas Dossou-Gbété <[email protected]>
Commit-Queue: Alex Ilin <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036727}
Roll DevTools Frontend from aea435301416 to c005e44cd0f3 (1 revision)
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/aea435301416..c005e44cd0f3
2022-08-18 [email protected] Ignore frame when deduplicating authored folders
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: [email protected]
Change-Id: Ie4f390ba1f9f5dcb12e2873aeefd24706940f1de
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3840246
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036726}
Remove ScopedAssistantLightModeAsDefault in Assistant Controller
It's just being used to determine dark mode so compute the value
directly. Locations that resolve colors have their own calls
to ScopedAssisstantLightModeAsDefault.
Bug: 1351837
Change-Id: I389a51ebea355d65c5f70fbd4d17a9964e0a17b9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3828053
Commit-Queue: Sean Kau <[email protected]>
Reviewed-by: Xiaoqian Dai <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036725}
[Fallbacks] Add form renderer id to params when the context menu is
triggered in a form
Add a new context menu param 'form_renderer_id', this param will
store the form's renderer id if the context menu is opened via
right-clicking on an input field or a textarea field in a form.
Similar to `field_renderer_id` param.
Bug: 1325811
Change-Id: I2f0e256abbd1ba0508d80bd8a581871193e73bf3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3820109
Reviewed-by: Kinuko Yasuda <[email protected]>
Reviewed-by: Christoph Schwering <[email protected]>
Commit-Queue: Vidhan Jain <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036724}
webrtc: disallow encodedInsertableStreams in pc.setConfiguration()
and return the actual value in getConfiguration()
See https://github.com/w3c/webrtc-encoded-transform/pull/111
for the spec of this API version
BUG=chromium:1347309
Change-Id: Iaab0c347d182e2943b0cda9630fe4cefeb7042ff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3785012
Reviewed-by: Harald Alvestrand <[email protected]>
Commit-Queue: Philipp Hancke <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036723}
Roll Dawn from e0bf254f720e to 1ac1514ad2c9 (2 revisions)
https://dawn.googlesource.com/dawn.git/+log/e0bf254f720e..1ac1514ad2c9
2022-08-18 [email protected] Roll SwiftShader from ab4bf6ad00d4 to 1c3dfde53353 (1 revision)
2022-08-18 [email protected] Add bitwise_expression to the WGSL parser.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dawn-chromium-autoroll
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel
Bug: None
Tbr: [email protected]
Change-Id: Iad4461f4569fda3a9abe0a04189e993c814b751d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3839252
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036722}
Fix tests in web_tests/transitions
These tests fail if style changes are introduced before the first
style update. Fixed by ensuring that we render the page before the
first style change.
Bug: 1255285
Change-Id: I53c70c33262bb7921baf455c4998c412efdc397e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3840206
Commit-Queue: Kevin Ellis <[email protected]>
Reviewed-by: Mustaq Ahmed <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036721}
Update OWNER for wpt test scripts
Change-Id: I0054efb8b249351e01f5c4e8f04ed573777f92d9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3838799
Commit-Queue: Weizhong Xia <[email protected]>
Reviewed-by: Brian Sheedy <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036720}
Shimless: Update exit dialog text
screenshot: http://screen/AVchkiN6xpbNRRG
Bug: 1198187
Change-Id: Iacc868d0f4abfd1a7c4577d42fd9f3484e8d46e4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3838618
Reviewed-by: Michael Checo <[email protected]>
Reviewed-by: Gavin Williams <[email protected]>
Commit-Queue: Gavin Williams <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036719}
WebUI: Migrate cr_radio_button/* to class-based syntax
Bug: 1206112
Change-Id: I60c886e2006c1bd80b04d027a5011f08cc957267
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3826435
Commit-Queue: Rebekah Potter <[email protected]>
Reviewed-by: John Lee <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036718}
WebUI: Check in Polymer 3 cr-button
AX-Relnotes: n/a
Bug: 1184053
Change-Id: I1a3dc5476e9c5772fff8627f117023fe34506e89
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832606
Reviewed-by: Luciano Pacheco <[email protected]>
Reviewed-by: John Lee <[email protected]>
Commit-Queue: Rebekah Potter <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036717}
[A11y Settings Revamp] Rearrange Keyboard and Text Input Page
Rearrange Keyboard and Text Input Page so that the features with icons
are at the top. go/a11y-settings-revamp
Before: https://screenshot.googleplex.com/4FLgdp2oPFCrBo6
After: https://screenshot.googleplex.com/C3Xk9pU6uDxVufB
Bug: 1292142
Change-Id: Ie1e64f5807f9cca639d42e59421b125718bf7080
AX-Relnotes: Updates to Chrome OS Accessibility Settings to make accessibility options simpler / easier to use.
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3836260
Reviewed-by: Katie Dektar <[email protected]>
Commit-Queue: Josiah Krutz <[email protected]>
Reviewed-by: Jimmy Gong <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036716}
[iOS][test runner] Ensure that xctestrun_data.{OnlyTestIdentifiers,SkipTestIdentifiers} does not contain more than one slash.
For some reason, if the slash is included more than once, the retry will
always fail. The call stack on the retry is as follows:
** INTERNAL ERROR: Uncaught exception **
Uncaught Exception: *** -[__NSSetM addObject:]: object cannot be nil
Stack:
0 __exceptionPreprocess (in CoreFoundation)
1 objc_exception_throw (in libobjc.A.dylib)
2 _CFThrowFormattedException (in CoreFoundation)
3 -[__NSSetM addObject:].cold.2 (in CoreFoundation)
4 -[__NSSetM addObject:] (in CoreFoundation)
5 -[XCTTestIdentifierSetBuilder addTestIdentifier:] (in XCTestCore)
6 -[XCTHTestRunSpecification initWithDictionaryRepresentation:error:] (in XCTHarness)
7 -[XCTHTestRunCoder_V1 testRunSpecificationsInDictionaryRepresentation:removingPathPlaceholders:error:] (in XCTHarness)
8 -[XCTHTestRunCoder_V1 testRunFileWithDictionaryRepresentation:removingPathPlaceholders:error:] (in XCTHarness)
9 +[XCTHTestRunFileSerialization testRunFileWithDictionaryRepresentation:removingPathPlaceholders:error:] (in XCTHarness)
10 +[XCTHTestRunFileSerialization testRunFileWithContentsOfURL:pathPlaceholders:error:] (in XCTHarness)
11 specialized static XCTHTestRunFileSerialization.testRunFile(withContentsOf:derivedDataPath:) (in IDEFoundation)
12 @objc static XCTHTestRunFileSerialization.testRunFile(withContentsOf:derivedDataPath:) (in IDEFoundation)
13 -[Xcode3CommandLineBuildTool _resolveInputOptionsWithTimingSection:] (in Xcode3Core)
14 -[Xcode3CommandLineBuildTool run] (in Xcode3Core)
15 XcodeBuildMain (in libxcodebuildLoader.dylib)
16 start (in libdyld.dylib)
Bug: webrtc:14382
Change-Id: I4c95ef78f86a1124366bc02c2a2ca12580861ec0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3838593
Reviewed-by: Zhaoyang Li <[email protected]>
Commit-Queue: Zhaoyang Li <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036715}
Add unique identifier to Promo initializer.
Change-Id: I4857da6f9b9507001a2582a18950e5eea1b15398
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3836259
Commit-Queue: Benjamin Williams <[email protected]>
Reviewed-by: Sebastien Seguin-Gagnon <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036714}
Roll src-internal from ba34d7bac20d to 773787650d3b (6 revisions)
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ba34d7bac20d..773787650d3b
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: [email protected],[email protected]
Change-Id: I62b144cc867780b7f97a433c761252f52801ca37
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3839230
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1036713}
Roll Chrome Win64 PGO Profile
Roll Chrome Win64 PGO profile from chrome-win64-main-1660823934-acebcb6c95b714dbd9cf1e3ba86b0a6496fe1b8c.profdata to chrome-win64-main-1660834523-5357c1014f567bf4898228b2c78273127462122f.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win64-chrome
Tbr: [email protected]
Change-Id: I17876fc396eaa3f726464799ce99537bfa193a28
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3839271
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036712}
Export android-code-coverage-native data to zoss
Bug: 1305015
Change-Id: I08958b60d3f6f727975ad2d82e71417db767c060
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3838821
Auto-Submit: Prakhar Asthana <[email protected]>
Reviewed-by: Zhaoyang Li <[email protected]>
Commit-Queue: Zhaoyang Li <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036711}
Export win10-code-coverage data to zoss
Bug: 1305015
Change-Id: I26d3182a9a24c589626c27678cacd60ca947b5ce
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3840291
Auto-Submit: Prakhar Asthana <[email protected]>
Reviewed-by: Zhaoyang Li <[email protected]>
Commit-Queue: Zhaoyang Li <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036710}
[DesktopScreenshots] Register component earlier, on share hub open.
This allows users who use any sharing feature to check for a
component update or first-install the editor. Previously installs or update checks required loading the capture bubble.
The feature does not load at startup to save bandwidth for the majority
of users who do not use the feature.
Change-Id: I4e3644ad3a9fa877b56079b68bb3073c351d008f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3833389
Reviewed-by: Kristi Park <[email protected]>
Commit-Queue: Travis Skare <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036709}
Export ios-simulator-code-coverage data to zoss
Bug: 1305015
Change-Id: I9fbdcf379b46d9a2df54def412c4f25887af9405
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3838823
Reviewed-by: Zhaoyang Li <[email protected]>
Auto-Submit: Prakhar Asthana <[email protected]>
Commit-Queue: Zhaoyang Li <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036708}
Roll Help App from FiCVNk17K_YUEWVml... to _JqbtCltJUQrGFSIw...
Release_Notes: http://go/help_app-x20/relnotes/Main/help_app_nightly_202208180800_RC00.html
https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/help_app/app/+/_JqbtCltJUQrGFSIw_3hlkjdvrFVrqIKXh9aSzVJ0e8C
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/help-app-chromium-autoroll
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: [email protected]
Change-Id: Id7c3065964381d862ac04fb638b83063c47b9e76
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3839269
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1036707}
Fix failing wpt test external/wpt/paint-timing/fcp-only/fcp-gradient.html
Check if background images are contentful before marking frame as
containing a first-contentful-paint.
Bug: 1193506
Change-Id: I553aabd2639614a47d47c5acb564b3bde8d93e29
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3714574
Reviewed-by: Philip Rogers <[email protected]>
Commit-Queue: Sohom Datta <[email protected]>
Commit-Queue: Fredrik Söderquist <[email protected]>
Reviewed-by: Fredrik Söderquist <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036706}
Unoptimize CHECKs in DCHECK builds
CHECKs are about an order of magnitude fewer than DCHECKs, so this
optimization doesn't serve us in DCHECK builds where DCHECKs are not
similarly optimized.
This lets us capture the LOG_FATAL crash key for CHECKs on
DCHECK-enabled builds, which may add useful additional information for
debugging (which DCHECKs currently do).
This is also useful because when a CHECK failure occurs in a stable
build it's possible that the same CHECK condition has been hit in a
DCHECK build which you'd be able to query for in crash reporting.
Bug: 1340649
Change-Id: Ic605b990af169c7c38f44f323aa7462c1ff3c0c1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3835045
Reviewed-by: Daniel Cheng <[email protected]>
Commit-Queue: Peter Boström <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036705}
Log Camera Roll download results
TESTED=verified via chrome://histogram
Bug: b/239201889
Change-Id: I00054af0c27a41aacf6cc97c9990dfb16f723d46
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3826026
Reviewed-by: Juliet Lévesque <[email protected]>
Reviewed-by: Jon Mann <[email protected]>
Commit-Queue: Jason Sun <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036704}
Speculative fix to a notification inline reply clusterfuzz crash
We cannot reproduce this clusterfuzz case, but looking at the crash
trace it looks like a null pointer dereference in a corner case. This is
a speculative fix to the problem.
Bug: 1343219
Change-Id: I6f0a7d40c403d09531c79afed2057d7d1bae20c1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834514
Reviewed-by: Ahmed Mehfooz <[email protected]>
Reviewed-by: Alex Newcomer <[email protected]>
Commit-Queue: Andre Le <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036703}
Refactor TaskManagerView to use PrefService::GetValueDict
This is part of a larger migration effort based on
go/trust-your-prefs.
Bug: 1341996
Test: Existing unit tests
Change-Id: I5211495ac2a0f6abb533e6f5263492b8be9affcf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3830021
Reviewed-by: Dana Fried <[email protected]>
Commit-Queue: Dana Fried <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036702}
CanvasFormattedText: Fix fuzzer-identified issue
The fuzzer found another issue with the current experimental CFT
implementation. While we were already checking that the run belonged to
a frame that hadn't been destroyed, it was possible to add a run to a
CanvasFormattedText object that belonged to a destroyed frame.
I've added two checks for this:
1. We now check that the CFT's View() is valid (we were previously only
checking the run.
2. For the various append/insert/setRun APIs, we now check that the CFT
and the run belong to the same frame/document.
Bug: 1289807
Change-Id: I4d3f4a940e59d1fc7ec5273c9c3a729aca8c6b06
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3837077
Reviewed-by: Fernando Serboncini <[email protected]>
Reviewed-by: Ian Kilpatrick <[email protected]>
Commit-Queue: Ian Prest <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036701}
Handle corner cases when opening URLs from incognito mode.
Some special URLs (e.g. chrome://settings) can't be opened in incognito
mode. The existing code sets the navigator to the first one returned by
OpenURL. This is incorrect in the case where we batch open URLs from
incognito mode because the navigator gets set to the window which is non
incognito which makes the rest of the URLs open in non-incognito mode.
[email protected]
Bug: 1349283
Change-Id: I18228eb6b2ec4fbec76e76b4f12b516f1de2c485
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3819848
Commit-Queue: Scott Violet <[email protected]>
Reviewed-by: Scott Violet <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036700}
Ensure PABudgetStorage's KeyValueTable is destroyed on DB sequence
The KeyValueTable is currently destroyed on the UI sequence, which may
cause thread safety issues. For example, any weak pointers it vends
would be invalidated on the wrong sequence. So, we extend the lifetime
of the table slightly, destroying it similarly to the sql::Database.
Bug: 1354212
Change-Id: I9bdf14eef90e35151b63c81f697767c7be82cde1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3837233
Reviewed-by: John Delaney <[email protected]>
Commit-Queue: Alex Turner <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036699}
Export mac-code-coverage data to zoss
Bug: 1305015
Change-Id: Ib0b44c0cb6ee9c4bc9126bba9408d7e223d868b9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3838837
Reviewed-by: Zhaoyang Li <[email protected]>
Commit-Queue: Zhaoyang Li <[email protected]>
Auto-Submit: Prakhar Asthana <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036698}
Make ColdModeSpellCheckRequester recheck element when spellcheck is re-enabled
When spellcheck is disabled on an element, all existing markers are
removed.
crrev.com/c/3822635 makes cold mode checker memorize all fully-checked
elements, so that they are not repeatedly checked.
Then it created a regression that if a fully checked element is
spellcheck disabled then re-enabled, it's not checked again.
This patch fixes it by removing an element from the fully checked
element set when spellchecking is disabled for this element.
Fixed: 1353929
Change-Id: I8483d5eccfe28cc3e39c4780c7b8fa509bd56430
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3835558
Reviewed-by: Yoshifumi Inoue <[email protected]>
Commit-Queue: Xiaocheng Hu <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036697}
[iOS] Only show the promo when the feed is visible
The FeedTopSectionCoordinator should always exist, since the promo can
be shown and hidden when the feed visibility changes. Therefore we
always create the coordinator, and conditionally add its VC to the
NewTabPageViewController when it is updated.
Bug: 1331010
Change-Id: Ia11654afeb41edb913dd40d4f45a5d4882349db9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3838796
Reviewed-by: Sergio Collazos <[email protected]>
Auto-Submit: Adam Arcaro <[email protected]>
Commit-Queue: Adam Arcaro <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036696}
Revert "[mojo] Disable flaking SharedBufferTest"
This reverts commit b92a1d6a6af973c2cb271995cc7d80a3f19b3aa8.
Reason for revert: AFAICT this has not actually been flaking recently, prior to being disabled.
Original change's description:
> [mojo] Disable flaking SharedBufferTest
>
> Bug: 1287637, 1342222
> Bug: fuchsia:96241
> Change-Id: I659fded6ee7aaffddfcd94958adc0d894923343e
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3747786
> Reviewed-by: Adithya Srinivasan <[email protected]>
> Owners-Override: Adithya Srinivasan <[email protected]>
> Commit-Queue: Wez <[email protected]>
> Auto-Submit: Wez <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1021648}
Bug: 1287637, 1342222
Bug: fuchsia:96241
Change-Id: I395d20485bf815c6ea2616b79386e24b199886a7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3829561
Auto-Submit: Wez <[email protected]>
Reviewed-by: Ken Rockot <[email protected]>
Commit-Queue: Ken Rockot <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036695}
Reland "Integrating Private Aggregation with Shared Storage"
This is a reland of commit cce318217b2b40a4b8be183e4adb6a5aa9bdc3d5
The memory leaks seen in fuchsia-fyi-x64-asan are a known limitation of
the garbage-collected gin library. Fuchsia does not support the leak
suppression config so we need to manually disable the tests instead.
Original change's description:
> Integrating Private Aggregation with Shared Storage
>
> Exposes a new privateAggregation.sendHistogramReport() call to Shared
> Storage worklets and adds the mojo plumbing to forward these requests to
> the private_aggregation/ component (if it's enabled) in the browser.
>
> Bug: 1346108
> Change-Id: Iea4db1c14fc1c0dda805a639bee917f4f9dfb2ae
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3814272
> Reviewed-by: Dominic Farolino <[email protected]>
> Commit-Queue: Alex Turner <[email protected]>
> Reviewed-by: Yao Xiao <[email protected]>
> Reviewed-by: Nan Lin <[email protected]>
> Reviewed-by: Alex Gough <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1035668}
Bug: 1346108
Change-Id: I3a852186dbf9a9079d4c18555a5d789b008479ea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3838137
Reviewed-by: Alex Gough <[email protected]>
Reviewed-by: John Delaney <[email protected]>
Reviewed-by: Rohan Pavone <[email protected]>
Auto-Submit: Alex Turner <[email protected]>
Commit-Queue: Yao Xiao <[email protected]>
Reviewed-by: Dominic Farolino <[email protected]>
Reviewed-by: Yao Xiao <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036694}
[Chromecast] Remove RequestMoveOut.
This method is no longer used.
Bug: b/242898471
Test: build for android, linux, fuchsia
Change-Id: I8c1b1141648c148223da0c38671f2c0252cd2b2d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3835060
Reviewed-by: Sean Topping <[email protected]>
Commit-Queue: Sean Topping <[email protected]>
Auto-Submit: Simeon Anfinrud <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036693}
Clear pending repeated footer when breaking before it.
A repeatable table footer may be a suitable early-break in some cases,
and when that happens, we need to clear the pending table footer, so
that we won't start looking for it after the table child loop.
Bug: 1353998
Change-Id: I6f0792069d46b75eaefe65d73349ee49c5ecc61e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3838790
Commit-Queue: Morten Stenshorne <[email protected]>
Reviewed-by: Ian Kilpatrick <[email protected]>
Reviewed-by: Alison Maher <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036692}
Fix copying of PolicyGlobal to diagnostics in chrome://sandbox
In a previous change[0] uses of the policy_rules_ member were
renamed to policy_rules when coying the low level policy from
the config to the diagnostic. This lead to the copy being
unpacked to Json later in the chrome://sandbox flow sometimes
having invalid pointers (probably where a process had exited
and its low level policy had been freed, making pointers to
its policy invalid). This resulted in a flaky test which was
disabled[1].
This change fixes this and renames another variable to
make it more obvious what is going on.
[0] https://chromium-review.googlesource.com/c/chromium/src/+/3558444
[1] https://chromium-review.googlesource.com/c/chromium/src/+/3836276
Tests: ChromeURLDataManagerWebUITrustedTypesTest.NoTrustedTypesViolation/chrome___sandbox
Bug: 1353819
Change-Id: I3e722a5ba28b6a92f56f537d824f677e184e90b0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3836343
Commit-Queue: Alex Gough <[email protected]>
Reviewed-by: James Forshaw <[email protected]>
Reviewed-by: Peter Boström <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036691}
Reland "Add basic benchmark to collect stack samples"
This reverts commit 4190818890d957e3540225b5a33bb0de119f8550.
Removed non-ASCII character
Change-Id: I430f1eba928f53a86e72030050372edce30357ac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3838812
Reviewed-by: Mikhail Khokhlov <[email protected]>
Commit-Queue: Carlos Caballero Grolimund <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036690}
Roll WebRTC from 723f19d230e7 to 7aaeb5a270ba (19 revisions)
https://webrtc.googlesource.com/src.git/+log/723f19d230e7..7aaeb5a270ba
2022-08-18 [email protected] Create pre-allocated decoders on the decoder thread.
2022-08-18 [email protected] Remove usage of rtc::MessageHandler in OpenSSLAdapter
2022-08-18 [email protected] Clean VideoReceiveStream2::HandleEncodedFrameOnDecodeQueue
2022-08-18 [email protected] Revert "dtls: allow dtls role to change during DTLS restart"
2022-08-18 [email protected] dtls: allow dtls role to change during DTLS restart
2022-08-18 [email protected] Roll chromium_revision 73d2f8e653..80727c54da (1035926:1036533)
2022-08-18 [email protected] In FakeNetworkInterface drop dependency on rtc::MessageHandler
2022-08-18 [email protected] Remove usage of rtc::MessageHandler in net/dcsctp
2022-08-18 [email protected] Adopt absl::string_view in modules/desktop_capture/
2022-08-18 [email protected] Remove statistics tracking from FrameBuffer2
2022-08-18 [email protected] Add an explicit conversion from absl::string_view to std::string
2022-08-18 [email protected] Prevent UB on BufferT::AppendData and ctor.
2022-08-18 [email protected] Remove usage of rtc::MessageHandler in peer_connection example
2022-08-18 [email protected] Don't specify the Mac version for iOS bots
2022-08-17 [email protected] Remove unused headers ScreenCaptureFrameQueue
2022-08-17 [email protected] TaskQueueStdlib: remove dependency on Event::kForever being int.
2022-08-17 [email protected] Migrate mb script to python3.
2022-08-17 [email protected] Cleanup TurnServer
2022-08-17 [email protected] Adopt absl::string_view in modules/congestion_controller/
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in WebRTC: https://bugs.chromium.org/p/webrtc/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: [email protected]
Change-Id: I8abaf3553a82b33c8e48570a13791ab1aa5cd4ae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3839290
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036689}
Fix tests in fast/animations/scroll-animations
These tests likely broke due to shuffling of support code in WPT.
In this patch, we break the dependency on WPT, which prevents WPT
changes from inadvertently breaking non-WPT tests.
It appears that 2 of the tests could be migrated to WPT. The remaining
one depends on internals and cannot be ported. Will leave the decision
of whether to move some of the tests to a followup CL.
Bug: 1343365
Change-Id: I71e37456c951103d4653fe267fe58422d452ca0e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3838774
Commit-Queue: Kevin Ellis <[email protected]>
Reviewed-by: Mustaq Ahmed <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036688}
Extend expiration date for metrics
OOBE.GaiaScreen.*
Login.ReauthToken.FetchDuration.*
Bug: 1306135, 1317205
Change-Id: Id5df20c19d515965f9209fb04b38521d28e25341
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3837692
Auto-Submit: Yunke Zhou <[email protected]>
Commit-Queue: Roman Sorokin <[email protected]>
Reviewed-by: Roman Sorokin <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036687}
[Journeys] Hide start icon drawable in queryfull state
Bug: 1353070
Change-Id: Ia5900f99d8008962af017d9fc9f91faf76841cb3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832700
Commit-Queue: Patrick Noland <[email protected]>
Reviewed-by: Brandon Wylie <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036686}
Introduce a GOOGLE_CHROME_FOR_TESTING_BRANDING build flag for C++ files.
https://chromium-review.googlesource.com/c/chromium/src/+/3781529
introduced a GN boolean flag for chrome for testing, which is consumed
herein.
For context, see https://goo.gle/chrome-for-testing
Bug: 1336611
Change-Id: I4d82bf279c8477b655ee943b2f0ca70ed0ed6f03
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3824042
Auto-Submit: Thiago Perrotta <[email protected]>
Commit-Queue: Nico Weber <[email protected]>
Reviewed-by: Nico Weber <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036685}
[SmartLock]: Delete ScanningBackoff experiment impl
Based on the data collected so far on the MultiDevice.SecureChannel.
BLE.ReceiveAdvertisementToAuthentication.EffectiveSuccessRateWithRetries
metric, the Smart Lock team has decided to scrap this study.
TEST=built and ran existing tests
Change-Id: Iea0e5e7645e79aa6211b417079a4106413ae87ee
Bug: b/234065703, b/208932863
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3823374
Reviewed-by: Ryan Hansberry <[email protected]>
Commit-Queue: Brittany Hartmire <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036684}
[DevTools] Replaced deprecated base::Value DICTIONARY and LIST types.
These types are deprecated for a long time. This CL replaces their
usage in tests that use DevTools commands with base::Value::Dict
and ::List respectively.
Change-Id: I8bf57bce476980049b3b99ce486ab70da3f58980
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3812264
Reviewed-by: Camille Lamy <[email protected]>
Reviewed-by: Ari Chivukula <[email protected]>
Reviewed-by: Andrey Kosyakov <[email protected]>
Commit-Queue: Peter Kvitek <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036683}
Update GPU expectations for software-renderer
Some tests do disable GPU compositing so add renderer-software tag to
capture this. Change existing tags from skia-renderer-gl to
renderer-skia-gl so they all share common prefix Also update
gpu_integration_unittests to produce tag renderer-skia-gl instead of
renderer-software since it's more typical.
Bug: 1343379
Change-Id: If48e895e333a2abdd953720ca74a542a70164b4c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3827506
Reviewed-by: Yuly Novikov <[email protected]>
Commit-Queue: Kyle Charbonneau <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036682}
Fix unsafe narrowing instances in ui/base.
This requires touching base/ and net/ also.
Bug: 1292951
Change-Id: Ibbee02d7e76b3a723cb68d668a07509353c571d9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3827415
Auto-Submit: Peter Kasting <[email protected]>
Reviewed-by: Peter Boström <[email protected]>
Reviewed-by: Ryan Hamilton <[email protected]>
Commit-Queue: Ryan Hamilton <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036681}
float: Hide multitask menu when entering tablet mode.
It still shows up if we click/hover the size button in tablet mode, but
I think instead of preventing it, we should hide the entire button. Will
do that in a follow up.
Also prevents the hover event from firing if the widget is not active.
Bug: 1347978
Test: ash_unittests MultitaskMenuTest.MultitaskMenuClosesOnTabletMode
Change-Id: Ie2ef62cb0578386b459b0eab34256d26e38935a7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3805943
Reviewed-by: Mitsuru Oshima <[email protected]>
Commit-Queue: Sammie Quon <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036680}
Add new field for root device total storage size to device status.
This new field will be populated using Spaced to match the displayed
storage in the device UI.
Bug: b:235136592, b:238441744
Change-Id: I2bd0b180a5e6cadbf887c3813bf0252ad0553672
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834244
Reviewed-by: Julian Pastarmov <[email protected]>
Commit-Queue: Ahmed Nasr <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036679}
[Signin][Android] Use kCurrentLog for FREMobileIdentityConsistencySynthetic
Make sure that FREMobileIdentityConsistencySynthetic is applied to UMA
data collected in the First Run Experience.
Fixed: 1347055
Change-Id: I900591acc2f01412706338a1bc827f3059ef594e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3836340
Auto-Submit: Boris Sazonov <[email protected]>
Reviewed-by: Mark Pearson <[email protected]>
Commit-Queue: Mark Pearson <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036678}
Reland "Add a method to convert integer socket family to net::AddressFamily"
This is a reland of commit dcb32506b023ffa2231e2f319ddcdf397891048d
Original change's description:
> Add a method to convert integer socket family to net::AddressFamily
>
> This will be used to support DNS resolution for a specific address
> family.
>
> Bug: webrtc:14319, webrtc:14131
> Change-Id: Ie5704638e9e6d32fd217e0f931ebaf68b0eb1b8e
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832378
> Auto-Submit: Sameer Vijaykar <[email protected]>
> Reviewed-by: David Schinazi <[email protected]>
> Commit-Queue: Sameer Vijaykar <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1036347}
Bug: webrtc:14319, webrtc:14131
Change-Id: Idf440f556b5f55f9a2ca97c1d4905e7ef674be73
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3837114
Reviewed-by: David Schinazi <[email protected]>
Auto-Submit: Sameer Vijaykar <[email protected]>
Commit-Queue: Sameer Vijaykar <[email protected]>
Commit-Queue: David Schinazi <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036677}
Roll SwiftShader from ab4bf6ad00d4d1edcc6bb3487139e91f0d379fbb to 1c3dfde53353 (1 revision)
Cannot build log URL because revision "ab4bf6ad00d4d1edcc6bb3487139e91f0d379fbb" is invalid: Failed to retrieve revision.
2022-08-18 [email protected] Added missing null pointer check on pDepthStencilResolveAttachment
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-chromium-autoroll
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86
Bug: None
Tbr: [email protected]
Change-Id: I14205d9649964ad540963841203df853576446fc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3835356
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036676}
Refactor invalidations to use PrefService::GetValueDict
This is part of a larger migration effort based on
go/trust-your-prefs.
Bug: 1341996
Test: Existing unit tests
Change-Id: Iccb1934b9df773c8e278d33c7731e487360abada
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3838611
Reviewed-by: Marc Treib <[email protected]>
Commit-Queue: Roland Bock <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036675}
android/webview: Log distinct site visits per week
Used the same expiry Android.WebView.OriginsVisited.
Explicitly named the histogram "weekly" in case another time range
could be added in the future.
The logic was put into AwSiteVisitLogger instead of
extending AwOriginVisitLogger because while they are similar,
we wouldn't actually share a lot of code between the two loggers
as they need to store different data in the shared preferences
and need to make different comparisons in the time ranges.
We would also need to awkwardly rename AwOriginVisitLogger
and still use the old shared preference file name or migrate it.
Added to this, we might later get rid of AwOriginVisitLogger.
Defined a site visit as visiting an eTLD+1.
Trusting the unit tests to test this because testing this manually
would need to be done over a week.
Bug: 1353775
Change-Id: I77e9f08ee8dad7ba4db507c561878f30ba2b9692
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3838212
Reviewed-by: Peter Beverloo <[email protected]>
Reviewed-by: Peter Conn <[email protected]>
Reviewed-by: Calder Kitagawa <[email protected]>
Commit-Queue: Rupert Wiser <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036674}
Remove usage of base::TimeTicks::Now() from browser_autofill_manager_unittest
Bug: 1352652
Change-Id: I6081cff7b026783be4486a047eeb6121900b5b99
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3838634
Commit-Queue: Vidhan Jain <[email protected]>
Commit-Queue: Christoph Schwering <[email protected]>
Auto-Submit: Vidhan Jain <[email protected]>
Reviewed-by: Christoph Schwering <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036673}
Roll RTS model from RbH8e_77lW7LpT7Nh... to GUeUYkTnmtlRNdQBo...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/rts-windows-amd64-chromium-autoroll
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: [email protected]
Change-Id: I7c26bdefa84b8f48222b1a2f0e086fcf93a675b2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3839229
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036672}
Roll DevTools Frontend from 15d7d6882e74 to aea435301416 (1 revision)
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/15d7d6882e74..aea435301416
2022-08-18 [email protected] Fix top layer not loading issue
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: [email protected]
Change-Id: Icd88e47ff04338954064e9fc25b650588a33f572
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3835512
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036671}
Saved Desks: Prevent focus on overview widgets when exiting overview
When exiting overview, we fade out the overview grid and have a
CleanupAnimationObserver delete the grid widget after shutdown has
completed for the overview session. This led to cases where the grid
view will still get focused even though it should be deleted, resulting
in a crash.
This CL ensures that when we call the fade out animation that the widget
is set to be no longer activatable, so there is no attempt by the
FocusController to activate it.
Bug: 1351467
Test: manual, added DeskSaveAndRecallTest.ExitOverviewDeskItemFocusCrash
Change-Id: I67cb36224007acb8f3d56e3cfdfcf8351ef3ad81
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3837012
Commit-Queue: Richard Chui <[email protected]>
Reviewed-by: Ahmed Fakhry <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036670}
[Passwords Import] Update strings for start & success states
Mocks: https://screenshot.googleplex.com/9rpNCTS3LDnEjNT.png
Impl: https://screenshot.googleplex.com/4pLXh6WhZTtaDEb.png
Bug: 1325290
Change-Id: I4ecbe572ee816afea55b5d92c259c038739fb2db
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3838250
Reviewed-by: Vasilii Sukhanov <[email protected]>
Commit-Queue: Andrii Natiahlyi <[email protected]>
Auto-Submit: Andrii Natiahlyi <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036669}
[Passwords import] Add per import limit
This CL adds a limit for the maximum number of passwords allowed
during import from single CSV file.
Mocks:
- https://screenshot.googleplex.com/5EuRZRK627BtXyG.png
Impl:
- https://screenshot.googleplex.com/FBPM7CQVVVpC2VY.png
Full mocks: https://www.figma.com/file/EyHs7Dl8W4cDSg2zAHYDB2/Import-passwords?node-id=2%3A369
DD: http://docs/document/d/1dcd9UiBxVt9Dc1O-5P_X1ktcVRtT5-qcE3iLQlemWME
Bug: 1325290
Change-Id: If97974f5b0f272705804e989e0179d1e66d0d61d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834245
Auto-Submit: Andrii Natiahlyi <[email protected]>
Reviewed-by: Vasilii Sukhanov <[email protected]>
Commit-Queue: Vasilii Sukhanov <[email protected]>
Reviewed-by: Mohamed Amir Yosef <[email protected]>
Commit-Queue: Andrii Natiahlyi <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036668}
Remove [email protected] from third_party/content_analysis_sdk/OWNERS.
This suggested change is automatically generated based on group memberships and affiliations.
If this change is unnecessary or in error, vote CR -1 and the bot will abandon it. Vote CR +1/2 to approve this change.
See the owner's recent activity for context: https://chromium-review.googlesource.com/q/[email protected]
To report an issue, file a bug in the Infra>Security component.
Change-Id: Ief2d36d9065f755ec20d5835190b4b6ea2645cd6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3773282
Auto-Submit: Owners Cleanup <swarming-tasks@owners-cleanup-prod.google.com.iam.gserviceaccount.com>
Reviewed-by: Roger Tawa <[email protected]>
Commit-Queue: Roger Tawa <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036667}
Remove extension and mime type check for content analysis
This is no longer required so as to enable more DLP rule possibilities.
Bug: b/241254708
Change-Id: Ieef5ec8cf8623b839946a7ad19037d02647fdfe0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3831930
Auto-Submit: Dominique Fauteux-Chapleau <[email protected]>
Commit-Queue: Daniel Rubery <[email protected]>
Reviewed-by: Daniel Rubery <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036666}
Shimless: update the reboot delay
Display the updated reboot delay of 3 seconds:
https://chromium-review.googlesource.com/c/chromiumos/platform2/+/3832066
https://screenshot.googleplex.com/3L7C6HtG2qVqrps
Bug: 1198187
Test: local
Change-Id: Id88ae58e692582ab52ca078e1d14c675a2a7d65c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3837015
Commit-Queue: Gavin Williams <[email protected]>
Auto-Submit: Anton Swifton <[email protected]>
Reviewed-by: Gavin Williams <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036665}
Generate globalAlpha effect via filters
Currently, there are two ways to produce an opacity effect in Canvas2D: set the globalAlpha property or use the opacity canvas filter. By unifying the paths for the two APIs, the resulting effects are guaranteed to be identical and are easier to maintain and debug. After reference and performance testing, it was decided to do the unification by producing the effect defined with globalAlpha via filters.
The new GetGlobalAlphaAsFilter method, added to CanvasRenderingContext2DState, creates an opacity PaintFilter the with the value specified by globalAlpha. The StateGetFilter method now can receive an additional argument to indicate whether to include this filter, in order to allow the use of this method to get the canvas filters defined by the user. When the argument is set to include the globalAlpha filter, the PaintFilter returned is the result of composing the regular user set filters with the one obtained with GetGlobalAlphaAsFilter. The inclusion of the globalAlpha value in the image_flags, which was the way in which the globalAlpha effect was applied previously, was removed.
Bug: 1344922
Change-Id: Id96acd1f9ae07d2cb3076d27503273ea7408b7a0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3763215
Reviewed-by: Juanmi Huertas <[email protected]>
Commit-Queue: Andres Perez <[email protected]>
Reviewed-by: Robert Flack <[email protected]>
Reviewed-by: Justin Novosad <[email protected]>
Reviewed-by: Aaron Krajeski <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036664}
[memories][persist-clusters] Don't expire visits with visit_id = 0.
Syncing propoates visit deletes. Sometimes, on iOS devices, we get sync
data indicating a visit with id 0 was deleted. This is causing a DCHECK
crash. This CL adds a guard when deleting visits from the sync flow. It
leaves the DCHECK for deleting visits locally so we will know if
something is wrong.
Bug: 1353807, 1184879, 1184875, 1171352
Change-Id: I25fa06254cef3b1a430a75fa47bbfd8dd2e1a9e2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3835059
Commit-Queue: manuk hovanesian <[email protected]>
Auto-Submit: manuk hovanesian <[email protected]>
Reviewed-by: Marc Treib <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036663}
[MediaCapture Extensions] Background blur constraints and settings
This CL implements Media Capture and Streams Extensions background blur
constraints and settings on the renderer side. On the media capture
video backend side, this CL sets the default background blur support to
to be not supported and implements background blur support for the
Windows MediaFoundation backend based on hardware and platform support.
Spec: https://w3c.github.io/mediacapture-extensions/#exposing-mediastreamtrack-source-background-blur-support
Background blur feature is behind a flag:
chrome --enable-blink-features=MediaCaptureBackgroundBlur
Intent-to-prototype:
https://groups.google.com/a/chromium.org/g/blink-dev/c/3ke9hgaREwM
Bug: 1338665
Change-Id: I70267979eb99960b06f8acfa354dbc8b00915a2f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3714592
Reviewed-by: Vladimir Levin <[email protected]>
Reviewed-by: Guido Urdaneta <[email protected]>
Reviewed-by: Harald Alvestrand <[email protected]>
Commit-Queue: Eero Hakkinen <[email protected]>
Reviewed-by: Markus Handell <[email protected]>
Reviewed-by: Rijubrata Bhaumik <[email protected]>
Reviewed-by: Tomas Gunnarsson <[email protected]>
Reviewed-by: Robert Sesek <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036662}
[iOS] Avoid crashing when reloading items in GoogleServices
`self.passwordLeakCheckItem` is only added in the table view when
`kEnhancedProtection` feature is disabled.
This patch makes sure `kEnhancedProtection` is disabled before to
update `passwordLeakCheckItem`, and to ask its consumer to reload it.
Fixed: 1353810
Change-Id: I705635d2e7778b1099624a2131e915cd53668ce7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3838778
Commit-Queue: Jérôme Lebel <[email protected]>
Auto-Submit: Jérôme Lebel <[email protected]>
Reviewed-by: Joemer Ramos <[email protected]>
Commit-Queue: Joemer Ramos <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036661}
Roll RTS model from KV4QPYI4VnwiZw1JN... to sGVhzaqwgT697qIGK...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/rts-mac-amd64-chromium-autoroll
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: [email protected]
Change-Id: I97d9bb8a4b3a29ba07f3e3cf2c6ba29c8c5e42ef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3839289
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036660}
Lacros: Implement `AccountManagerMojoService::ReportAuthError`
Base CL - https://crrev.com/c/3825905
Design Doc - http://shortn/_hKoc0VqbIt
Bug: 1226055, 1312897
Test: components_unittests
Change-Id: I990a5e24f6dfb6415ba8ae8d5e9a24068419fb5e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832225
Reviewed-by: Anastasiia N <[email protected]>
Commit-Queue: Kush Sinha <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036659}
[Web Payment] Use promises in CanMakePaymentQueryTest
Bug: 1288946
Change-Id: I6e03775c698e7271dfb32d673d652e93a34a7fda
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832499
Commit-Queue: Rouslan Solomakhin <[email protected]>
Reviewed-by: Stephen McGruer <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036658}
Disable client_side_phishing_fuzzer for Linux ASAN Debug builds.
The bot mentioned in the bug is having trouble linking
client_side_phishing_fuzzer. This is a temporary fix to get the failing
bot working again sooner.
Bug: 1353965
Change-Id: I1d257e2d3a83c2089876dcc08970dd9b48993052
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3836633
Reviewed-by: Daniel Rubery <[email protected]>
Commit-Queue: Lei Zhang <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036657}
Update rendering metrics in system_health benchmark
We've been working on replacing older Event.Latency with EventLatency,
and PercentDroppedFrames with PercentDroppedFrames3. They have been
stable on rendering_desktop and rendering_mobile for a while.
This change adds them to system_health and system_health_scroll_jank so
that we can get a couple weeks of data in parallel to the old metrics.
At which point we will remove the old ones.
Bug: 1080679
Change-Id: Ia9ddd4466274c2ed84adf42f82c7b88b03007072
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3836778
Reviewed-by: Annie Sullivan <[email protected]>
Commit-Queue: Jonathan Ross <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036656}
More thoroughly document how mojom.NavigationClient gets reused
RenderFrameImpl maintains a mojom.NavigationClient implementation that
acts as a:
1.) "Request" navigation client:
For navigations on a target frame where the initiator is local.
This is used to cancel navigations that have been sent to the
browser, and to listen for when the browser "drops" navigations
2.) "Commit" navigation client:
Which the browser uses to commit navigations to.
Sometimes the same navigation client implementation is used as both, and this CL more thoroughly documents when and how this happens.
Change-Id: Ib3192d1b0f911839cd8a9d9119670cebbc4e1281
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3835467
Reviewed-by: Rakina Zata Amni <[email protected]>
Commit-Queue: Dominic Farolino <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036655}
sheriff: mark iframe-navigation-stealing-focus.html as flaky
It has a very high flake score across all platforms.
Bug: 1340167
Change-Id: Ia2fed3b270476d7b2c5f1a2232c64796c2a2b197
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3835448
Reviewed-by: Peter Boström <[email protected]>
Auto-Submit: Elly Fong-Jones <[email protected]>
Commit-Queue: Elly Fong-Jones <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036654}
Change 3P intents in Incognito feature name
Also entry is added for a study in `fieldtrial_testing_config.json`.
Bug: 1318750
Change-Id: Ie7707ba0e95e35f98ae585eb65325b62f23b8094
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3838929
Commit-Queue: Quentin Pubert <[email protected]>
Reviewed-by: David Jean <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036653}
Roll Perfetto Trace Processor Win from 8404c1cc9828 to c16f31c6da75
https://android.googlesource.com/platform/external/perfetto.git/+log/8404c1cc9828..c16f31c6da75
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: [email protected]
Change-Id: Ibe3425904a621e89b6f95771ba6c9dcfba053d79
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3838672
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036652}
Roll src-internal from 01fafe4e372c to ba34d7bac20d (2 revisions)
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/01fafe4e372c..ba34d7bac20d
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: [email protected]
Change-Id: I29ad433ea6e2ccf6b1deafcb5e2abfafd5a932f8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834875
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1036651}
Roll RTS model from dem8jpLGDhB7uQjgE... to MHZoKHSLMgxFLr6l4...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/rts-linux-amd64-chromium-autoroll
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: [email protected]
Change-Id: Ia196084ad9f9baefd18acead457fa5c96b5eb6b8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3839190
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036650}
Roll Website from b49932fe8cc1 to 1b05569731b9 (1 revision)
https://chromium.googlesource.com/website.git/+log/b49932fe8cc1..1b05569731b9
2022-08-18 [email protected] [website] Update design-documents/profile-architecture
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/website-chromium
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Website: https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: chromium:1053445,chromium:1341215
Tbr: [email protected]
Change-Id: Ia27247350d6bc76f6892c1d7fb477b1a0278c0ac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3839050
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036649}
[ios] Adds foreground tint color to the lockscreen widgets.
This is necessary for the widgets to render properly, but was
incorrectly removed when rebasing.
Bug: 1347565
Change-Id: Ia7c42c6b3bc5a276917c1c2b4cc49e84ceddda73
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3838632
Reviewed-by: Chris Lu <[email protected]>
Commit-Queue: Rohit Rao <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036648}
cros_healthd: Update mojom interface to remove deprecated SystemInfo
|SystemInfo| is deprecated in chromium 15047.0.0. (CL:3811063).
BUG=b:190459636
TEST=CQ
TEST=deploy chrome on DUT and then open Diagnostics App to check the
system information (board name, version info...)
Change-Id: I2730eb7bdfa163c3367230f4b076edae7fdc546d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3829657
Auto-Submit: Byron Lee <[email protected]>
Commit-Queue: Alex Gough <[email protected]>
Reviewed-by: Alex Gough <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036647}
Roll Skia from 246d7e915ff6 to be6380e00df1 (4 revisions)
https://skia.googlesource.com/skia.git/+log/246d7e915ff6..be6380e00df1
2022-08-18 [email protected] Roll vulkan-deps from c24b395f1402 to a1ba8ef3ad46 (3 revisions)
2022-08-18 [email protected] Roll Dawn from 30fa0d8d2ced to e0bf254f720e (2 revisions)
2022-08-18 [email protected] update Skia's Android.bp script to include the Skottie module
2022-08-18 [email protected] Avoid SkQP errors when attempting to initialize a Vk test.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Cq-Do-Not-Cancel-Tryjobs: true
Bug: None
Tbr: [email protected]
Change-Id: If94c79dbc9e2f6abf8a9707b0480255740d2ccf0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3839009
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036646}
Move {ash => chromeos/ash}/components/cryptohome/
ChromeOS components and services are meant to live in chromeos/,
separate from Ash shell code. Fix a previous migration that used the
wrong directory.
This CL is part of the ChromeOS source code directory migration:
https://docs.google.com/document/d/1g-98HpzA8XcoGBWUv1gQNr4rbnD5yfvbtYZyPDDbkaE.
Bug: 1164001
Change-Id: I85291e8b35328648f35df445d13bc71d0ed3e9f8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3780906
Commit-Queue: Henrique Ferreiro <[email protected]>
Reviewed-by: Hidehiko Abe <[email protected]>
Owners-Override: Hidehiko Abe <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036645}
Add a WebView flag for AlwaysAbandonScheduledTasks
Bug: 1262205
Change-Id: I6a00c4cbe45b72759e42c3f9e1a7aec541f240f6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832780
Commit-Queue: Patrick Monette <[email protected]>
Reviewed-by: Bo Liu <[email protected]>
Reviewed-by: Lei Zhang <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036644}
Refactor accessibility to use PrefService::GetValueList
This is part of a larger migration effort based on
go/trust-your-prefs.
Bug: 1341998
Change-Id: Idca1e577009c3f9bc838e78ba449aad9de9585ea
Tests: Existing unit tests
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3836271
Reviewed-by: Katie Dektar <[email protected]>
Commit-Queue: Roland Bock <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036643}
[Settings] Add translate target metric and metrics test
Adding a metric to track when the user changes the translate target.
A matching metrics test is added.
Additionally, adding definitions for the following actions to match the
metrics currently recorded on android:
- remove from never translate
- add to never translate
- remove from always translate
- add to always translate
- remove from never translate sites
- restart chrome for split install
Bug: 1351816
Change-Id: I0dc881dce667917aeb1e743205a64aae971ee86c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3823604
Commit-Queue: Andrea Gomez <[email protected]>
Reviewed-by: Trevor Perrier <[email protected]>
Reviewed-by: John Lee <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036642}
[DownloadBubble] Update full screen notification text
Update the full screen notification for downloads if the notification is
overriding another notification.
Screencast: http://go/scrcast/NjIyNTkwOTYzNjkyMzM5MnxhNDU4YTFlNy1kYw
POC screencast: http://go/scrcast/NDg2ODIzMjIyMjYwNTMxMnw0MGJkNzAwMi0wMg
Bug: 1352388
Change-Id: Ibfaeff033258247c8354740090d8d84d80655009
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3837016
Commit-Queue: Rohit Bhatia <[email protected]>
Reviewed-by: Peter Boström <[email protected]>
Reviewed-by: Xinghui Lu <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036641}
[DownloadBubble] Show the download button again after undo the remove action.
Call ShowToolbarButton() explicitly in UpdateToolbarButtonState() when
the the button should be shown. It will also fix the wrong icon issue
when a new window is created during in progress downloads
(http://screen/A7pxuRzsHNFjSrJ).
Bug: 1348541
Change-Id: Iec2dde891ff1c64f768b21cddb943979fde670fe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834767
Reviewed-by: Rohit Bhatia <[email protected]>
Commit-Queue: Xinghui Lu <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036640}
Revert "Add alternate accelerator for IDC_BASIC_PRINT and deprecate the old one"
This reverts commit 8d2d2b8acd3ed07102b9822e154dcb07c84471b8.
Reason for revert: Ctrl-Alt hotkeys aren't allowed on Windows (https://devblogs.microsoft.com/oldnewthing/20040329-00/?p=40003)
Original change's description:
> Add alternate accelerator for IDC_BASIC_PRINT and deprecate the old one
>
> This changes the accelerator for printing via system dialog on non-Mac
> desktop platforms to Ctrl-Alt-P. The current accelerator is still
> enabled, but if it's used we display an infobar informing the user
> about the new hotkey.
>
> Change-Id: Ied633ca3e609cf951447f0adeca39bdda81d24b3
> Bug: 1331331
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3684430
> Reviewed-by: Peter Kasting <[email protected]>
> Commit-Queue: Peter Kasting <[email protected]>
> Reviewed-by: Lei Zhang <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1012180}
Bug: 1331331
Change-Id: I611b2aff72718c07f75ae5aa00557c6d225484e1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834518
Commit-Queue: Leonard Grey <[email protected]>
Reviewed-by: Lei Zhang <[email protected]>
Commit-Queue: Lei Zhang <[email protected]>
Reviewed-by: Peter Kasting <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036639}
Remove WaylandDisplayObserver properly
Bug: 1351403
Test: covered by unittests. Also tested manually using arc/lacros window + external dissplays.
Change-Id: Id1cf0f425c2776538f08e654cda7f5228c3d5422
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3490037
Reviewed-by: Kazuki Takise <[email protected]>
Commit-Queue: Mitsuru Oshima <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036638}
Roll Chrome Win32 PGO Profile
Roll Chrome Win32 PGO profile from chrome-win32-main-1660802055-4580a4c3503de99bad7a4bdd2106a70e8083184c.profdata to chrome-win32-main-1660823934-70140be7d2ce58f76795e07e5d74c4d4024afcfc.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win-chrome
Tbr: [email protected]
Change-Id: I6e0e1267926f126df35153663583df6cb4893337
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3835357
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036637}
[iOS][Omnibox] Fix cell background color in actions v2.
Use the proper color from mocks.
Bug: none
Change-Id: I72e0c2ec2d6c39fe5d2a6867f65acbade59b987e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3838809
Reviewed-by: Robbie Gibson <[email protected]>
Commit-Queue: Robbie Gibson <[email protected]>
Auto-Submit: Stepan Khapugin <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036636}
Add first Promo class unit test.
Change-Id: Iaead9b53af28bec227cb04dcae86524df4587092
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832702
Reviewed-by: Joemer Ramos <[email protected]>
Commit-Queue: Benjamin Williams <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036635}
[Cast Streaming] Rename cast_streaming::CastStreamingDemuxer
This CL renames the cast_streaming::CastStreamingDemuxer to the less
redundantly named cast_streaming::FrameInjectingDemuxer.
Change-Id: If119cbfca81b10b30ddc6496e371861b1dd88fb0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3645910
Reviewed-by: Fabrice de Gans <[email protected]>
Commit-Queue: Ryan Keane <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036634}
Move SamplingEventSource to base/power_monitor/
This move is done in preparation for adding BatteryStateSampler in
the same directory, which will depend on SamplingEventSource.
Bug: 1248057
Change-Id: I91022e465614d1fbcbccfaa4fd782349a83e3534
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3819886
Reviewed-by: Etienne Pierre-Doray <[email protected]>
Commit-Queue: Patrick Monette <[email protected]>
Reviewed-by: Daniel Cheng <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036633}
[canvas] Make 2D canvas hibernation feature-controlled on all platforms
This is currently an experiment on macOS, where numbers are unstable,
and hard to interpret. Though this feature has been launched a while
ago, this CL makes it runtime-controlled on other platforms as well, to
start a holdback trial, and assess its impact.
Bug: 1329375
Change-Id: I990af5d23eb4712226f6e48ce9b11d5750eb6127
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3810223
Reviewed-by: Khushal Sagar <[email protected]>
Commit-Queue: Benoit Lize <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036632}
Notifier Framework: System Nudge Catalog
Add `NudgeCatalogName` enum to identify system nudges to keep better
track of notifiers used in CrOS and implement general usage metrics.
(go/notifier-framework-sketch)
Bug: 1286399
Change-Id: Ic60a7e99ee98a87af028f9464b4c94dcd34bc8cf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3829785
Reviewed-by: James Cook <[email protected]>
Commit-Queue: Kevin Radtke <[email protected]>
Reviewed-by: Alex Newcomer <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036631}
Update comments for some ash and lacros builders
Bug: 1345687
Change-Id: Ie088b1c8771bdcd074db1f4d426d0d28ab7f329d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3835655
Reviewed-by: Garrett Beaty <[email protected]>
Auto-Submit: Sven Zheng <[email protected]>
Commit-Queue: Garrett Beaty <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036630}
Automatic update from google3
Automatic update for 2022-08-18 UTC
Change-Id: I6cdea682c874a061269ab88b4db197c393baa518
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3838110
Commit-Queue: PKI Metadata Updates Bot <[email protected]>
Bot-Commit: PKI Metadata Updates Bot <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036629}
Unified side panel update combobox after Show call.
Updating the index also updates the width so
we want to update after the entry has been chosen.
Bug: 1353375
Change-Id: Ic1baf70d82ff1b265c99e47993246c91ed6dc58b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3836952
Reviewed-by: Emily Shack <[email protected]>
Commit-Queue: Caroline Rising <[email protected]>
Auto-Submit: Caroline Rising <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036628}
Add origin info to OptimizationGuide client requests
See also cl/463248625.
Bug: 1346370
Change-Id: I50e4a5b0218066628c077bd84f611aad27384c09
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3787617
Commit-Queue: Zhixiang Teoh <[email protected]>
Reviewed-by: Raj T <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036627}
FLEDGE: Fix update to handle groupByOrigin mode
Bug: 1330341
Change-Id: I82c5050513c00e93ad12afbe13e4c9b3ae35e224
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3830753
Reviewed-by: Russ Hamilton <[email protected]>
Commit-Queue: Maks Orlovich <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036626}
Correctly sort the newly created crostini folder in app list.
If a user downloads a linux app, it will automatically be added into
the crostini folder, which is named as "Linux apps". However, the
position of the crostini folder isn't sorted at the time it is created.
The reason leading to this bug is that we always use the first
available position as a folder item's initial position instead of
calculating one with the sort order in consideration. Given that the
branch date is impeding, this CL serves as a fix quick by only
calculating the crostini folder's initial position. We are concerned of
the possible regression in OEM folders if we calculate the item
position for every folder or every system folder.
Note that the normal folder (i.e. the folder generated by merging two
app items) is already handled well in Ash. Therefore, using the first
available position on other folders is less damaging than it appears to
be.
Bug: 1260875, 1353237
Change-Id: I454f0f3cea0e5be71b24a4e3eef58a3c6bcf599c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834739
Reviewed-by: Xiyuan Xia <[email protected]>
Commit-Queue: Wen-Chien Wang <[email protected]>
Reviewed-by: Andrew Xu <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036625}
Remove content analysis scanning from system print PrintNow code path
This fixes crbug/1352193, which was caused by having the system print
code path call the script print path after scanning, which triggered a
second scan as scripted prints are also covered by the
OnPrintEnterpriseConnectorPolicy. The fix is simply to remove the
system print specific code, this way scanning happens on the scripted
print code path.
This also adds back some flaky print browser tests on Mac and Linux,
as their flakyness was due to that issue and doesn't repro anymore
with the fix.
(Sheriffs, please revert this CL if these tests become flaky again)
Bug: 1322645, 1321689, 1352193
Change-Id: I8232fc1cbcd3af1ef1aebc9de0ee68f7065c5e12
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3826306
Reviewed-by: Lei Zhang <[email protected]>
Commit-Queue: Dominique Fauteux-Chapleau <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036624}
IOSurfaceCaptureDeviceBase: remove min frame rate logic.
IOSurfaceCaptureDeviceBase has a feature for upholding a
minimum frame rate in the absence of incoming frames. This
turns out not to be needed when the RequestRefreshFrame
method in media::VideoCaptureDevice is overridden. This is
invoked from MediaStreamVideoTrack and modified as needed
by getUserMedia and applyConstraints.
The change simply implements RequestRefreshFrame and
just serves the latest received frame (if any) in
response.
Bug: chromium:1309653
Change-Id: I0073d8a52c06ff811eb248fec91b2aad5d67bc6a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3826128
Reviewed-by: Mark Foltz <[email protected]>
Reviewed-by: ccameron chromium <[email protected]>
Commit-Queue: Markus Handell <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036623}
Roll Perfetto Trace Processor Linux from 8404c1cc9828 to c16f31c6da75
https://android.googlesource.com/platform/external/perfetto.git/+log/8404c1cc9828..c16f31c6da75
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: [email protected]
Change-Id: I332843e104d39af675f9639213116e072e1607c4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3838609
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036622}
Volatile compound ops are deprecated in C++20.
Bug: 1284275
Change-Id: I76ba0cc257e22ebce96e8e1a5c537d5c10a292d8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3835454
Reviewed-by: Yuwei Huang <[email protected]>
Commit-Queue: Peter Kasting <[email protected]>
Auto-Submit: Peter Kasting <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036621}
Report token type must be bytes
Bug: b/209384145
Change-Id: Ifa8ef9a7232b88398acb1e59b9189cfab947de20
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3838631
Commit-Queue: Julie Hockett <[email protected]>
Reviewed-by: Florian Gauger <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036620}
Add page title to scanning request and report for Print scans
Bug: b/242210797
Change-Id: Ib9471098f2802cef8046d6eb801d37fef6620445
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832152
Commit-Queue: Dominique Fauteux-Chapleau <[email protected]>
Auto-Submit: Dominique Fauteux-Chapleau <[email protected]>
Reviewed-by: Roger Tawa <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036619}
Prepare for a signal to be processed by multiple processors.
In ExtensionTelemetryService::AddSignal, pass the signal as reference instead of relinquishing ownership to the signal processor. This change will allow the signal information to be passed to multiple signal processors in a future CL.
Dependent CLs:
http://crrev/c/3788301
http://crrev/c/3788302
Bug: 1351484
Change-Id: Ia3447567c69ddf3f8d6212c2cfde17822b1bcf08
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3828045
Auto-Submit: Zack Han <[email protected]>
Commit-Queue: Zack Han <[email protected]>
Reviewed-by: Xinghui Lu <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036618}
Use frame bound task runners in wasm CodeCache.
Rename main_thread_task_runner_ because it really isn't the main thread,
it is the thread that the ExecutionContext lives on. Do not use
GetDeprecatedTaskRunner but the associated frame task runner.
BUG=624696
Change-Id: I9e874d4f9ee8785b96fc0a0d3dc4abb336221cc1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834781
Reviewed-by: Michael Lippautz <[email protected]>
Commit-Queue: Dave Tapuska <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036617}
Roll Chrome Mac Arm PGO Profile
Roll Chrome Mac Arm PGO profile from chrome-mac-arm-main-1660802055-ac45d6ec643d14be8715fc9b37eac5b4dc7224d0.profdata to chrome-mac-arm-main-1660823934-1c59750fb448eb4a5cb00d927bf2af94d44355d4.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-arm-chromium
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:mac-chrome
Tbr: [email protected]
Change-Id: I5642439c95b53af6c5199b2d6647d99f09296a7c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3838493
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036616}
Refactor chrome_content_browser_client to use PrefService::GetValueList
This is part of a larger migration effort based on
go/trust-your-prefs.
Bug: 1341998
Change-Id: If5a0ef40e96a239b9576af2e39b5f83da5620512
Tests: Existing unit tests
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3835600
Reviewed-by: Sergiy Belozorov <[email protected]>
Commit-Queue: Roland Bock <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036615}
[iOS][Omnibox] Enable paste button by default
Enable omnibox paste button by default as the rollout plan is on
waterfall.
Bug: 1354093
Change-Id: I9be0d94e7225ccd343c74599a0fee78edd812084
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3837178
Commit-Queue: Christian Xu <[email protected]>
Reviewed-by: Stepan Khapugin <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036614}
[ios][feed] Guard stable from debug notifications and override settings
Change-Id: I74598f1b7cd63efc3d91d7e88f88dc461c01e11a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3836267
Commit-Queue: Sergio Collazos <[email protected]>
Auto-Submit: edchin <[email protected]>
Reviewed-by: Sergio Collazos <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036613}
Roll Chrome Mac PGO Profile
Roll Chrome Mac PGO profile from chrome-mac-main-1660802055-5bf492462dadc6642d8aac4e4cc964e2ed94733c.profdata to chrome-mac-main-1660823934-91cc3328a61ccf2ecfe29ed7ad1071291ae93af7.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:mac-chrome
Tbr: [email protected]
Change-Id: I20ef30b4e62db4ae3c4d8b32754ea1357339e678
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3838074
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036612}
Use aliases when resolving FPS queries.
Bug: 1349781
Change-Id: I341d33918b311a9d871cc066fb0b66e5c63cb74e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834315
Reviewed-by: Shuran Huang <[email protected]>
Reviewed-by: Matt Reichhoff <[email protected]>
Commit-Queue: Chris Fredrickson <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036611}
Don't rely on iframe load event firing after subsequent script executes.
It appears that it was possible for PostMessageTest to not yet be
defined when the iframe load events are dispatched. Move them after
the definition of that function so that's impossible, and rewrite the
PostMessageTest function inline in those handlers, since it's quite
short anyhow.
Fixed: 1342518,1343698
Change-Id: Iafe632570b10991c1345fdc26063ebc1a85ed1a7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3827819
Commit-Queue: Jeremy Roman <[email protected]>
Reviewed-by: Adithya Srinivasan <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036610}
Refactor AppSessionMetrics to use PrefService::GetValueDict
This is part of a larger migration effort based on
go/trust-your-prefs.
Bug: 1341996
Test: Existing unit tests
Change-Id: Ic63c65f70a58ca9b7bffa76ddc6f3dd96f7634c6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3829233
Commit-Queue: Roland Bock <[email protected]>
Reviewed-by: Edman Anjos <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036609}
Roll Chrome Win64 PGO Profile
Roll Chrome Win64 PGO profile from chrome-win64-main-1660813005-2530e9a234c2fc92e27eae5fef03f59bd7a0acf9.profdata to chrome-win64-main-1660823934-acebcb6c95b714dbd9cf1e3ba86b0a6496fe1b8c.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win64-chrome
Tbr: [email protected]
Change-Id: I21d87ca00802dfceba6861a652f88328bc9d5acd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3838072
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036608}
Updating trunk VERSION from 5248.0 to 5249.0
* This is an automated release commit.
* Do not revert without consulting [email protected].
NOAUTOREVERT=true
Change-Id: Id2c78e0a308f7f1ac552267f7cc62b7d3f0eb5be
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3839089
Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1036607}
Roll R8 from JRl-hD82_6i56BBTt... to qvL35O3yU1ZbOWHVZ...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/r8-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:android-internal-binary-size;luci.chrome.try:android-internal-rel;luci.chrome.try:test-o-emulator
Tbr: [email protected],[email protected]
Change-Id: I32b71d24ce9d3f51292c199a2422fde03510450f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3837621
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1036606}
Add first Impression Limit class unit test.
Change-Id: Ie277d5773acd1b3b325c6b6896949d9c87be6f0f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832639
Commit-Queue: Benjamin Williams <[email protected]>
Reviewed-by: Ginny Huang <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036605}
[Reporting Connector] Add Browser Crash Event Reporting Impl
-- Design Doc: go/dpr-crash-reporting
Change-Id: Id48b9e58ccb0a4b9b95cda2afa097a21f2e80c5c
Bug: 1349157
Change-Id: I17484e62687964e7fd8f392c601609f6263ef3b1
Previous abandoned CL: http://crrev/c/3796713
Change-Id: I17484e62687964e7fd8f392c601609f6263ef3b1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3814112
Commit-Queue: Haifan Wang <[email protected]>
Reviewed-by: Dominique Fauteux-Chapleau <[email protected]>
Auto-Submit: Haifan Wang <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036604}
Simplify some BindOnce code.
Change-Id: I3a8faf0fbc6f4f67906c634793703257cc0503b4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3836779
Auto-Submit: Chris Fredrickson <[email protected]>
Reviewed-by: Dylan Cutler <[email protected]>
Commit-Queue: Dylan Cutler <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036603}
[site data] Display the favicon in the row view
Using FaviconCache, fetch the favicon for each row in the site data dialog. If there are no favicon available, a fallback icon is used.
Bug: 1344787
Change-Id: Ibac77476a360d0ce6d0719a7faa1b0f8c99187c5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834595
Reviewed-by: Theodore Olsauskas-Warren <[email protected]>
Commit-Queue: Olesia Marukhno <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036602}
Make WrappedSkImageBacking renderable
When being created from pixels ensure the WrappedSkImageBacking is
renderable for non-compressed formats. This matches the behaviour when
created without pixels.
SkiaReadbackPixelTestNV12WithBlit was failing with Vulkan due to
BlitRequest destination textures being non-renderable.
Bug: 1261646
Change-Id: I21b8f096073b880f396d7bc8782ff59a94402be4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3836414
Reviewed-by: Vasiliy Telezhnikov <[email protected]>
Commit-Queue: Kyle Charbonneau <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036601}
Refactor capture_policy_utils to use PrefService::GetValueList
This is part of a larger migration effort based on
go/trust-your-prefs.
Bug: 1341998
Change-Id: I639b35869bc0b3960ee18dbf9cab7d9c67b09e39
Tests: Existing unit tests
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3837815
Reviewed-by: Guido Urdaneta <[email protected]>
Commit-Queue: Roland Bock <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036600}
Roll Fuchsia SDK from 9.20220817.1.1 to 9.20220817.2.1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast
Tbr: [email protected]
Disable-Retries: true
Change-Id: Ie3131f461e9f7ed82bdd022ca989d50079ec16d2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3833648
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036599}
[MSC] Added screen capture usage indicator view.
This CL adds a new view to indicate the usage of the new
getDisplayMediaSet API (indicating that several screens are captured).
Bug: 1300883
Change-Id: Ice0fe91db9a1bdb41a8f3744db667ebc7a73bbf2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3668545
Reviewed-by: Markus Handell <[email protected]>
Reviewed-by: Avi Drissman <[email protected]>
Reviewed-by: Tom Sepez <[email protected]>
Commit-Queue: Simon Hangl <[email protected]>
Reviewed-by: Ahmed Fakhry <[email protected]>
Reviewed-by: Elad Alon <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036598}
Refactor locale_util to use PrefService::GetValueList
This is part of a larger migration effort based on
go/trust-your-prefs.
Bug: 1341998
Change-Id: Iebe746f4612752790a567bb63e3ddf49bd33bace
Tests: Existing unit tests
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3831072
Reviewed-by: Hidehiko Abe <[email protected]>
Commit-Queue: Roland Bock <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036597}
Roll ANGLE from 6ee6fac97f2a to 428b6788d711 (1 revision)
https://chromium.googlesource.com/angle/angle.git/+log/6ee6fac97f2a..428b6788d711
2022-08-16 [email protected] Update CHROMIUM_copy_texture.txt to match the code
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86
Bug: None
Tbr: [email protected]
Change-Id: I0f7f788e92ae12c691571ee08fd904bbe85e30a0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3836922
Bot-Commit: chromium-autoroll <[email protected]>
Reviewed-by: Geoff Lang <[email protected]>
Commit-Queue: Geoff Lang <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036596}
Remove requirement that Partitioned cookies cannot be set with SameParty
Now that we are deprecating the SameParty attribute, this requirement is no longer necessary.
Bug: 1225444
Change-Id: Id44a4c3b813cb464f2859581269236cd694a2564
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3836774
Reviewed-by: Chris Fredrickson <[email protected]>
Commit-Queue: Dylan Cutler <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036595}
Refactor PrivacySandboxService to use PrefService::GetValueList
This is part of a larger migration effort based on
go/trust-your-prefs.
Bug: 1341998
Change-Id: I7f5544b36fda23440bb0b3997198096efa7d9ad0
Tests: Existing unit tests
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3837179
Reviewed-by: Martin Šrámek <[email protected]>
Commit-Queue: Roland Bock <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036594}
Refactor chrome_browser_main to use PrefService::GetValueList
This is part of a larger migration effort based on
go/trust-your-prefs.
Bug: 1341998
Change-Id: Ief32ab9103ed1fc9581ee0fd5d638c5d8f35a3e7
Tests: Existing unit tests
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834818
Reviewed-by: Vasilii Sukhanov <[email protected]>
Commit-Queue: Roland Bock <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036593}
Display Google icon in approve/deny screen.
Replaced the existing Family Link icon.
The new googleg icon used is a copy of the existing icon chrome/browser/ui/android/omnibox/java/res/drawable/
ic_logo_googleg_20dp.xml,
which allows us to re-size the image to higher dimensions.
The result is shown the comment of the linked issue: https://bugs.chromium.org/p/chromium/issues/detail?id=1347805#c7 .
Bug: 1347805
Change-Id: I31f916300cda879e9e9e6ab2ea24b80c8bf4000f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3826239
Reviewed-by: Aga Wronska <[email protected]>
Commit-Queue: Anthi Orfanou <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036592}
Introduce global impression limits.
The promos manager internally checks the following global impression
limits:
- No more than 3 promos can be shown per week.
- No more than 1 promo can be shown every 2 days.
- A given promo cannot be displayed more than once per month.
Change-Id: I26f821750b27b92b1719533baa8fb8332f216acc
Bug: 1354115
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834516
Reviewed-by: Ali Juma <[email protected]>
Commit-Queue: Benjamin Williams <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036591}
Refactor BrowsingData to use PrefService::GetValueList
This is part of a larger migration effort based on
go/trust-your-prefs.
Bug: 1341998
Change-Id: Iab4929aebcf2fd5fe081df6fe3bc8695a49858e6
Tests: Existing unit tests
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3837952
Reviewed-by: Christian Dullweber <[email protected]>
Commit-Queue: Roland Bock <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036590}
Refactor ConnectorsManager to use PrefService::GetValueList
This is part of a larger migration effort based on
go/trust-your-prefs.
Bug: 1341998
Change-Id: I1e090862e3f9dea5140132cab41666a749b43d41
Tests: Existing unit tests
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834819
Reviewed-by: Dominique Fauteux-Chapleau <[email protected]>
Commit-Queue: Roland Bock <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036589}
[iOS] Conditions to show top of feed sign-in promo
Adds conditions to show the signin promo on top of the feed:
- Max 10 impressions
- An impression is only logged once within a 30 minute session
- The promo will only appear if the user has engaged with a feed
- The promo will not appear on the start surface
Bug: 1331010
Change-Id: Ie98df349ebfe9c954ccbdaafe03bf0db935b5787
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3833498
Reviewed-by: Sergio Collazos <[email protected]>
Reviewed-by: Jérôme Lebel <[email protected]>
Commit-Queue: Adam Arcaro <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036588}
Roll Chrome Linux PGO Profile
Roll Chrome Linux PGO profile from chrome-linux-main-1660802055-fd573ddf1ad9a2999a1104730245430a95ca2ef9.profdata to chrome-linux-main-1660823934-e6502543dd9b12af2179cf56baa23b61d083b0a8.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-linux-chromium
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:linux-chrome
Tbr: [email protected]
Change-Id: I560a6215850db050eb5333b133b9c315c683d846
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3837625
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036587}
[ui] Cache the janky duration histogram
This is the most popular histogram in UMA (by total count, which is not
accurate here since it's updated by more than 1 every time, but it's
still reported *very* often), and looking up a histogram by name each
time is somewhat expensive.
Cache it in a static local.
Change-Id: Ie6dcb1560a200007d003a3982167afce7a9c281d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3836754
Reviewed-by: Robert Flack <[email protected]>
Commit-Queue: Benoit Lize <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036586}
Revert "Integrating Private Aggregation with Shared Storage"
This reverts commit cce318217b2b40a4b8be183e4adb6a5aa9bdc3d5.
Reason for revert: Causing memory leaks in fuchsia-fyi-x64-asan
Original change's description:
> Integrating Private Aggregation with Shared Storage
>
> Exposes a new privateAggregation.sendHistogramReport() call to Shared
> Storage worklets and adds the mojo plumbing to forward these requests to
> the private_aggregation/ component (if it's enabled) in the browser.
>
> Bug: 1346108
> Change-Id: Iea4db1c14fc1c0dda805a639bee917f4f9dfb2ae
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3814272
> Reviewed-by: Dominic Farolino <[email protected]>
> Commit-Queue: Alex Turner <[email protected]>
> Reviewed-by: Yao Xiao <[email protected]>
> Reviewed-by: Nan Lin <[email protected]>
> Reviewed-by: Alex Gough <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1035668}
Bug: 1346108,1353756
Change-Id: I7285bfe5a33998e616f6d58ba115f052b77c26b5
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3836412
Reviewed-by: Alex Turner <[email protected]>
Commit-Queue: Rohan Pavone <[email protected]>
Reviewed-by: Yao Xiao <[email protected]>
Reviewed-by: Alex Gough <[email protected]>
Reviewed-by: Dominic Farolino <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036585}
[skylab_tests] Update skylab tests cros img version
This CL will update cros image version for skylab tests. CROS_BOARD_LKGM
is updated according to chromeos/CHROMEOS_LKGM; CROS_BOARD_DEV,
CROS_BOARD_BETA and CROS_BOARD_STABLE are updated according to Omaha.
If this CL caused regressions, please revert and pause the autoroller at
https://luci-scheduler.appspot.com/jobs/chrome/lacros-skylab-tests-cros-img-roller
Also please file a bug to OS>LaCrOS>Partner, and CC [email protected],
[email protected].
[email protected]
Cq-Include-Trybots: luci.chrome.try:lacros-amd64-generic-chrome-skylab
Requires-Testing: True
Change-Id: I664adb1f132453aad9423ef1e9c2b3f1427aad56
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3838349
Auto-Submit: skylab-test-cros-roller@chops-service-accounts.iam.gserviceaccount.com <skylab-test-cros-roller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Rubber Stamper <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036584}
nit: Remove duplicated includes from BrowserTestBase
Change-Id: I1a8f0223dab418366a4cc6473d113f2e55cc51ab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3837732
Auto-Submit: Eriko Kurimoto <[email protected]>
Reviewed-by: Avi Drissman <[email protected]>
Commit-Queue: Avi Drissman <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036583}
Avoid unnecessary copy out of pair.
Change-Id: I0621afdf029f035e08d36f4dcbea3fe3e8ab980f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834419
Reviewed-by: Shuran Huang <[email protected]>
Commit-Queue: Shuran Huang <[email protected]>
Auto-Submit: Chris Fredrickson <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036582}
Revert "Roll vulkan-deps from 31a5e38f3e48 to 33d0b2c3122a (12 revisions)"
This reverts commit c895cbaf8d07887103383f74a428bbe85d837904.
Reason for revert:
GpuProcess_disable_gpu and GpuProcess_swiftshader_for_webgl fail on every platform in Debug
See:
https://bugs.chromium.org/p/chromium/issues/detail?id=1354146
Original change's description:
> Roll vulkan-deps from 31a5e38f3e48 to 33d0b2c3122a (12 revisions)
>
> https://chromium.googlesource.com/vulkan-deps.git/+log/31a5e38f3e48..33d0b2c3122a
>
> Changed dependencies:
> * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/1728c1d40a..0073a1fa36
> * vulkan-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/497f232680..d55c7aaf04
> * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/e51d0d1c18..caaa7f2d66
>
> If this roll has caused a breakage, revert this CL and stop the roller
> using the controls here:
> https://autoroll.skia.org/r/vulkan-deps-chromium-autoroll
> Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
> is aware of the problem.
>
> To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
>
> To report a problem with the AutoRoller itself, please file a bug:
> https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
>
> Documentation for the AutoRoller is here:
> https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
>
> Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86;luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:win-asan;luci.chromium.try:linux_chromium_cfi_rel_ng
> Bug: None
> Tbr: [email protected],[email protected],[email protected]
> Change-Id: Ic834dfb64aecdea874a030df3f768c4eb4d1ae56
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3836346
> Commit-Queue: chromium-autoroll <[email protected]>
> Bot-Commit: chromium-autoroll <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1036504}
Bug: None
Change-Id: Icc9d8bf0a2f2d02d8de34f846a1afd4e9d7c35c7
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86;luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:win-asan;luci.chromium.try:linux_chromium_cfi_rel_ng
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3838192
Auto-Submit: Alexis Hétu <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036581}
Add permission revocation flag.
This CL adds a missing flag in chrome://flags for site-level notification permission revocation on Android.
Bug: 1353897
Change-Id: I91cea1195d04bd4bcf7088f1a26706b01659f9a0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3826170
Reviewed-by: Ravjit Uppal <[email protected]>
Commit-Queue: Illia Klimov <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036580}
Remove some GetDeprecatedTaskRunner calls.
Rewrite tests to use appropriate task runner or testing hook to
grab the current task runner.
BUG=624696
Change-Id: Ia0ac131f87d6a9ecfc2f40d2456b73d2046aa3f7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3835272
Reviewed-by: Kent Tamura <[email protected]>
Reviewed-by: Kouhei Ueno <[email protected]>
Commit-Queue: Dave Tapuska <[email protected]>
Reviewed-by: Jeremy Roman <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036579}
Remove temporary using declaration in //chromeos/dbus/common [1/N]
This CL removes unnecessary temporary using declaration of
'chromeos::DBusMethodCallback', since //chromeos/dbus/common is
visible to both Lacros and Ash.
This CL is part of the Chrome OS source code directory migration:
https://docs.google.com/document/d/1g-98HpzA8XcoGBWUv1gQNr4rbnD5yfvbtYZyPDDbkaE.
Change-Id: Idb93e733cc5920da15e6e1ef7b53ae2bbb112b87
Bug: 1164001
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834692
Commit-Queue: Yeunjoo Choi <[email protected]>
Reviewed-by: Hidehiko Abe <[email protected]>
Owners-Override: Hidehiko Abe <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036578}
[FastCheckout] Add form cache state UMA in CapabilitiesFetcher.
This CL adds support for recording the cache state at the point
where availability for a given form signature on a given origin
is looked up.
Bug: 1350456, 1334642
Change-Id: Ib7318aee1eac2b4161fed7205609d1bb1de7249f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3829265
Commit-Queue: Jan Keitel <[email protected]>
Reviewed-by: Norge Vizcay <[email protected]>
Reviewed-by: Vidhan Jain <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036577}
Refactor browser/profiles to use PrefService::GetValue*
This is part of a larger migration effort based on
go/trust-your-prefs.
Bug: 1341996, 1341998
Test: Existing unit tests
Change-Id: I8e43f2714e446b603826d86d432b49679ab43690
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3829149
Reviewed-by: Monica Basta <[email protected]>
Commit-Queue: Roland Bock <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036576}
[@container] Invalidate past size containers in shadow DOM
Since the nearest container is found in shadow-including ancestors and
not in flat tree ancestors, and style recalc traversal happens in flat
tree order, we need to invalidate inside flat tree descendant
containers if such containers are inside shadow trees.
Bug: 1353912
Change-Id: Iead6acf239ef461cdff81fbd517787ce98e366b6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3838209
Commit-Queue: Rune Lillesveen <[email protected]>
Reviewed-by: Anders Hartvoll Ruud <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036575}
Enable kFullscreenPromosManager in unit tests.
Change-Id: I2688d8d66ccc0123d73421289e6a78b84a599907
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3813832
Reviewed-by: Sebastien Seguin-Gagnon <[email protected]>
Commit-Queue: Benjamin Williams <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036574}
Reland "Add Tangible sync flow for signin row in main settings"
This reverts commit 7935edc2e4d5a7d963df448334f565695f39a2c1.
Reason for revert:
Fixes the tests. Sync promo uses the same string as the signin
preference when there are no accounts.
In order to fix the tests an account is added to the device so that
the promo has a different text.
Original change's description:
> Revert "Add Tangible sync flow for signin row in main settings"
>
> This reverts commit 4cee9379113bfc4c729d491143793be5192b49df.
>
> Reason for revert: newly added tests fail on bots (see
> https://crbug.com/1353505).
>
> Original change's description:
> > Add Tangible sync flow for signin row in main settings
> >
> > This cl adds the tangible sync flow launch capability to the signin
> > preference in main settings page. This flow is guarded by a flag.
> >
> > Bug: 1332527
> > Change-Id: I9222fa0512e1fcd55a012a9fa37853a9b66b0226
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3819763
> > Reviewed-by: Boris Sazonov <[email protected]>
> > Commit-Queue: Tanmoy Mollik <[email protected]>
> > Cr-Commit-Position: refs/heads/main@{#1035435}
>
> Bug: 1332527, 1353505
> Change-Id: I6e82abcd635da0999b0c7752c77d0ef08986f193
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834451
> Commit-Queue: Rubber Stamper <[email protected]>
> Auto-Submit: Boris Sazonov <[email protected]>
> Bot-Commit: Rubber Stamper <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1035761}
Bug: 1332527, 1353505
Change-Id: I387ba7a5c31e28a8f82726af53ac68c76ced6487
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834251
Reviewed-by: Boris Sazonov <[email protected]>
Commit-Queue: Tanmoy Mollik <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036573}
[editing] Avoid selection.IsRange() failure in insert_list_command.cc
InsertListCommand::DoApply() behaves different depending on whether the
current selection is collapsed or is a range. In the latter case, it
adjusts the selection in case it starts just before a table or ends just
after a table, to avoid crossing the table boundary. It also asserted
that the adjusted selection would still be a range, but this isn't
always the case.
So this patch checks if the adjusted selection is still a range, and if
not, it uses the same logic as if the original selection hadn't been a
range.
Bug: 1350571
TEST=InsertListCommandTest.SelectionFromEndOfTableToAfterTable
Change-Id: Ib2921a287ad3ff7acdd9e85bf76d0431b94cb373
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3816643
Reviewed-by: Yoshifumi Inoue <[email protected]>
Commit-Queue: Oriol Brufau <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036572}
Added a buildflag for freeslot bitmap
Added a buildflag named `USE_FREESLOT_BITMAP` to partition alloc, which
is set to false by default and going to hide the new freeslot bitmap feature behind.
Bug: 1354062
Change-Id: Ifbc52aaee2c377d35401205d7abde21ccbf7126f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3837912
Reviewed-by: Takashi Sakamoto <[email protected]>
Commit-Queue: Honoka Anada <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036571}
[BrowserFragment] Add adapter to access weblayer PostMessage-interface in BrowserFragment
Change-Id: I93dbde1461566c0495c2012b3f979d890873592f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832218
Reviewed-by: Clark DuVall <[email protected]>
Commit-Queue: Susanne Westphal <[email protected]>
Reviewed-by: Rayan Kanso <[email protected]>
Reviewed-by: Ken Buchanan <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036570}
Roll DevTools Frontend from 1a9c7dc0b2e1 to 15d7d6882e74 (1 revision)
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/1a9c7dc0b2e1..15d7d6882e74
2022-08-18 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update Chromium PINS
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: [email protected]
Change-Id: I3f1872f0853b3dee6696a091b497c3f175766bb3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3835298
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036569}
Roll src-internal from 3d298fbbd22d to 01fafe4e372c (5 revisions)
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/3d298fbbd22d..01fafe4e372c
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: [email protected]
Change-Id: I2f71dfd363e0a1f8286af4f40bde2be44f39906b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3837758
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1036568}
[APC Desktop] Stop icon animation during prompt.
The current behavior of the pulsing icons in the APC progress bar
is such that icons will only stop pulsing at the end of a run.
However, according the UI guidance, the pulsing should stop while a
user is faced with a prompt, since the pulsing icon indicates an
ongoing action.
This CL stops icon pulsing upon displaying (non-empty) prompts. It
also adds several unit tests to check that icon pulsing works as
expected.
Bug: 1329179
Change-Id: Iec76db4c4f444e7d5703756cbf3f13a8eef0b01a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3831073
Reviewed-by: Norge Vizcay <[email protected]>
Commit-Queue: Jan Keitel <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036567}
[Passwords] Fix accessibility text for password generation popup for UPM
This was overlooked during the feature development of UPM on Desktop MVP
Since this feature is already launched, no need to put this behind a
feature flag.
Bug: 1309480
Change-Id: I8501f1c87062fdf9f61b57f8bec534868181b4ba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3838210
Reviewed-by: Vasilii Sukhanov <[email protected]>
Commit-Queue: Mohamed Amir Yosef <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036566}
Roll Dawn from 30fa0d8d2ced to e0bf254f720e (2 revisions)
https://dawn.googlesource.com/dawn.git/+log/30fa0d8d2ced..e0bf254f720e
2022-08-18 [email protected] Roll ANGLE from 92e4cd75785d to 955adb775768 (10 revisions)
2022-08-18 [email protected] Roll vulkan-deps from 863822794aa7 to 33d0b2c3122a (13 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dawn-chromium-autoroll
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel
Bug: None
Tbr: [email protected]
Change-Id: I56e1fde918b59ab558b78bf5e60c29685755ffa9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3837797
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036565}
[Telemetry] Fix missing image in documentation
Currently the image included in the Telemetry Extension's documentation
page is not properly displayed. This CL fixes that by adding the image
as proper markdown.
Bug: None
Change-Id: Ia0543da5f1825600b59505024273bbd3f11e722e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3838311
Reviewed-by: Oleh Lamzin <[email protected]>
Commit-Queue: Bastian Kersting <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036564}
Add java unit tests for Direct writing classes
Add unit tests to increase test coverage for classes under
components/stylus_handwriting package for:
class DirectWritingServiceCallback
Class DirectWritingTrigger
Bug: 1300551
Change-Id: I0c52778882f3881b58922b03aa8f387e32952c8f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3833620
Reviewed-by: Peter Conn <[email protected]>
Commit-Queue: Peter Conn <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036563}
Roll libc++ from 9de2fe040375 to db722166934e (7 revisions)
https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/9de2fe040375..db722166934e
2022-08-17 [email protected] [libcxx] Fix using the vcruntime ABI with _HAS_EXCEPTIONS=0 defined
2022-08-17 [email protected] [libcxx][spaceship][doc] Repair links and clean up spaceship progress doc
2022-08-17 [email protected] [libc++] Diagnose when header search paths are set up incorrectly
2022-08-17 [email protected] Revert "[libcxx] Resolve warnings for Wshift-sign-overflow"
2022-08-17 [email protected] [libcxx] Resolve warnings for Wshift-sign-overflow
2022-08-17 [email protected] [libc++][format] Uglyfies format buffer.
2022-08-17 [email protected] [libc++][CI] Updates and improves the Docker image.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/libcxx-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: [email protected],[email protected]
Change-Id: I2aaaa6550729f19950ed6b57c4eb8298098fb39a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3837757
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036562}
[MPArch] Use GuestMainFrame->GetSI instead of WC->GetSI for GuestView's
GetStoragePartition access.
The GetStoragePartition task is described in
https://docs.google.com/document/d/1kgDz0NhbNeO8qT-gFR_hJJjO1Z-isSnXNtCPrInT2M0 - Design - Pre-work - Necessary pre-work - Investigate
and fix StoragePartition access.
There are two major callsites of guest's WC->GetSI:
1. WebViewGuest's ClearCodeCache, ClearDataInternal and ClearData. These
are addressed by installing a GetGuestMainFrame on GuestViewBase.
2. StatefulSSLHostStateDelegate's AllowCert, QueryPolicy,
AllowHttpForHost, IsHttpAllowedForHost and HasCertAllowException. These
functions only access the storage partition so we can just pass that
instead. This mechanical change introduces the majority of the delta in
this CL.
Bug: 1261928
Change-Id: I0557cb38664fa4493f3bd38bc762865d61cc9607
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3791688
Reviewed-by: Emily Stark <[email protected]>
Reviewed-by: Bo Liu <[email protected]>
Commit-Queue: William Liu <[email protected]>
Reviewed-by: Avi Drissman <[email protected]>
Reviewed-by: Kevin McNee <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036561}
[site data] Update the row based on the content setting
Display the current content setting state as the subtitle. Hide the menu
item that matches the current setting. Add updating the UI as a result
of an user action (hiding the row, updating the subtitle). Actually
handling the actions will be implemented separately.
Bug: 1344787
Change-Id: I1492882c90f6c594ad03eba3372bf5ce1115dea9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834177
Reviewed-by: Theodore Olsauskas-Warren <[email protected]>
Commit-Queue: Olesia Marukhno <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036560}
Roll Perfetto from 8404c1cc9828 to c16f31c6da75 (1 revision)
https://android.googlesource.com/platform/external/perfetto.git/+log/8404c1cc9828..c16f31c6da75
2022-08-17 [email protected] Migrate SizeProfileComputer to trace processor DescriptorPool
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel
Bug: None
Tbr: [email protected]
Change-Id: I9d317b6db7897cf00ca9dcef00e3f4b762705a31
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3837620
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036559}
Reland "Move //chromeos/{=>ash/components}/dbus/dbus_thread_manager.{cc|h}"
This is a reland of commit 4923462ac8f410160841521a70b70dd6e16ff5f1
Original change's description:
> Move //chromeos/{=>ash/components}/dbus/dbus_thread_manager.{cc|h}
>
> Also, this CL moves "dbus" component target to
> chromeos/ash/components/dbus/BUILD.gn from chromeos/dbus/BUILD.gn
>
> This CL is part of the Chrome OS source code directory migration:
> https://docs.google.com/document/d/1g-98HpzA8XcoGBWUv1gQNr4rbnD5yfvbtYZyPDDbkaE.
>
> Bug: 1164001
> Change-Id: I16767b0f79aa209f8e58e65f41c6f65d296fd596
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3833683
> Reviewed-by: Hidehiko Abe <[email protected]>
> Owners-Override: Hidehiko Abe <[email protected]>
> Commit-Queue: Yeunjoo Choi <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1036425}
Bug: 1164001, 1354022
Change-Id: Ia2aba2ca9898b3591a6ef135bd1704c94c37b061
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3833321
Owners-Override: Hidehiko Abe <[email protected]>
Reviewed-by: Hidehiko Abe <[email protected]>
Commit-Queue: Yeunjoo Choi <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036558}
[iOS] Speculative fix for TabGrid indicator
It seems that the ActivityIndicator of the tab grid is shown and started
but is only hidden.
Try to also stop it to see if it reduces the flakes linked to the
indicator still executed.
Bug: 1352970
Change-Id: I62d36e527135397fcc186eb310ed446da62d7408
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3831543
Reviewed-by: Jérôme Lebel <[email protected]>
Auto-Submit: Gauthier Ambard <[email protected]>
Commit-Queue: Jérôme Lebel <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036557}
Create Promo enum.
Change-Id: I08f08640157fcd1539cd882b3de2d77eb162a818
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3817001
Commit-Queue: Benjamin Williams <[email protected]>
Reviewed-by: Rohit Rao <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036556}
[Signin][Android] Enable new initialization flow for FRE sign-in
Enables client-side experiment for groups added in
https://crrev.com/c/3827827.
Since this changes sizes of existing groups, counters in these groups
are bumped up.
Bug: 1343837
Change-Id: I943b8a34b6153120243f598b56fec4c460d552e8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3830312
Reviewed-by: Tanmoy Mollik <[email protected]>
Commit-Queue: Boris Sazonov <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036555}
Roll Chrome Win64 PGO Profile
Roll Chrome Win64 PGO profile from chrome-win64-main-1660802055-d24b5a7cff1e39e8fd0c20cb9a99bbaeca1edc33.profdata to chrome-win64-main-1660813005-2530e9a234c2fc92e27eae5fef03f59bd7a0acf9.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win64-chrome
Tbr: [email protected]
Change-Id: I3f4e3cc75f66b3cae3704990fb25810b9f40dc9b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3837876
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036554}
Mark dangling pointers occurring in SnapshotBrowserTest.*
These dangling pointers occur when running the tests alone, they occur
in a few tests:
- SnapshotBrowserTest.*
- BackForwardCacheBrowserTestWithBlockedWebsites.*
Bug: 1291138
Change-Id: Ifb3233b4bf69305843fa4bbdda88e243db99cb67
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3826002
Reviewed-by: Maggie Chen <[email protected]>
Reviewed-by: Adam Rice <[email protected]>
Commit-Queue: Pâris Meuleman <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036553}
Match all UA rulesets in the same MatchRequest.
When we have functionality to match against multiple RuleSets for the
same element at the same time, it's a bit meaningless to call separate
CollectMatchingRules() and sort for each of them (there can be multiple
if e.g. the element is a media element, or if we have quirks mode).
This is just a cleanup; performance is neutral.
Change-Id: Ifd64da55b865c5c8fd87739e4986d3db957b3496
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3829518
Commit-Queue: Steinar H Gunderson <[email protected]>
Reviewed-by: Anders Hartvoll Ruud <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036552}
Refactor Signin to use PrefService::GetValueDict
This is part of a larger migration effort based on
go/trust-your-prefs.
Bug: 1341996
Test: Existing unit tests
Change-Id: I2812755d1c1962efe2cc834482eac510b83ac8b8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3829098
Reviewed-by: Monica Basta <[email protected]>
Commit-Queue: Roland Bock <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036551}
[ozone/wayland] Workaround missing wl_touch.frame after wl_touch.up
... on Gnome/Wayland, KDE, Weston.
BUG=1352927
[email protected]
Change-Id: Ia9276257bf654be6c42dac44ed66837a2395c4f9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832706
Reviewed-by: Nick Yamane <[email protected]>
Commit-Queue: Antonio Gomes <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036550}
[dPWA] Enforce client view's height to be at least WCO's height
There was a bug that when the window was minimized fully, the window
reduced to just a single line. This fix ensures that the minimum size of
the window is at least the height of the caption button container which
contains the window-controls-overlay (WCO) toggle and other window
controls.
Bug: 1353133
Change-Id: I8a0285418b19bb9c3ac8d4f43f0990126c354511
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832388
Reviewed-by: Peter Kasting <[email protected]>
Commit-Queue: Sonja Laurila <[email protected]>
Auto-Submit: Sonja Laurila <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036549}
Roll src/third_party/cros_system_api/ aa799daeb..354de5ff0 (3 commits)
https://chromium.googlesource.com/chromiumos/platform2/system_api.git/+log/aa799daeb5b4..354de5ff0d73
$ git log aa799daeb..354de5ff0 --date=short --no-merges --format='%ad %ae %s'
2022-08-15 chungsheng mojo_service_manager: Move constants to system_api
2022-08-11 ayaelattar dlp: Update protos to have paths & more info
2022-08-11 chenghaoyang system_api: Add IioSensor service name
Created with:
roll-dep src/third_party/cros_system_api
BUG=chromium:1352132, chromium:1338454
Change-Id: I92acf25789441b9443e7b8cc467d2b513f079505
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3837673
Reviewed-by: Alvin Lee <[email protected]>
Commit-Queue: Aya Elsayed <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036548}
Roll R8 from lAcTGSK3VDSH4DI3H... to JRl-hD82_6i56BBTt...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/r8-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:android-internal-binary-size;luci.chrome.try:android-internal-rel;luci.chrome.try:test-o-emulator
Tbr: [email protected],[email protected]
Change-Id: Ifaf538166f95f6d8ec889333c6c26a9bb5a904ae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3836490
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1036547}
mojo-ipcz: Implement WrappedPlatformHandle
To support the general PlatformHandle wrapping APIs Mojo exposes, we
need a way to reference PlatformHandles as IpczHandles.
This CL introduces the WrappedPlatformHandle driver object for that
purpose. WrappedPlatformHandle supports serialization, and the
MojoWrapPlatformHandle API returns an instance of that object already
boxed and suitable for portal transmission.
Bug: 1299283
Change-Id: Icfd79ffdbbea611e53e800838e1875e31128dfee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3817006
Commit-Queue: Ken Rockot <[email protected]>
Reviewed-by: Alex Gough <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036546}
[APC Desktop] Refactor helper classes for progress bar.
This CL is a simple refactoring of the two helper classes used in
PasswordChangeRunProgress. The reason for the refactoring is to allow
for dedicated unit tests of the two helper classes.
A follow-up CL will add functionality and unit tests.
Bug: 1329179
Change-Id: I1b1e7dd9a9ff01a999508524b9797eb889fbf0ec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3835693
Commit-Queue: Jan Keitel <[email protected]>
Reviewed-by: Norge Vizcay <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036545}
[CEX] Pass in Chrome version number to JS flow
Bug: b/238983486
Change-Id: Iea08770eb153636ac3e8b7fa8ee2c9a528b9f88d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3837115
Auto-Submit: Florian Gauger <[email protected]>
Reviewed-by: Luca Hunkeler <[email protected]>
Commit-Queue: Florian Gauger <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036544}
RTCVideoEncoder: Add GUARD_BY_CONTEXT qualifier to |status_|
This is a follow up of crrev.com/c/3811075. The sequence checker
GUARD_BY ensures |status| is accessed by the same sequence.
Bug: b:241349739
Test: Build
Change-Id: I9c09879faffd8a9f4e4d768bd5d0d7bcbe94b86e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3836374
Auto-Submit: Hirokazu Honda <[email protected]>
Commit-Queue: Hirokazu Honda <[email protected]>
Reviewed-by: Markus Handell <[email protected]>
Commit-Queue: Markus Handell <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036543}
Roll DevTools Frontend from 3fcfa37a5526 to 1a9c7dc0b2e1 (2 revisions)
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/3fcfa37a5526..1a9c7dc0b2e1
2022-08-18 [email protected] Add info about non-overridden response headers to `NetworkRequest`
2022-08-18 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS (trusted)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: chromium:1297533
Tbr: [email protected]
Change-Id: I19134f8ef3e2bbdcc90822bdc4c94766852f4c19
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3837875
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036542}
arc: update arc_policy_bridge OWNERS file
Replacing pbond@ with yaohuali@
TEST=none
BUG=none
Change-Id: Iabf9155c81012b611f7c532ee435c32a1328022b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3836909
Commit-Queue: Polina Bondarenko <[email protected]>
Reviewed-by: Polina Bondarenko <[email protected]>
Auto-Submit: Muhammad Hasan Khan <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036541}
[iOS] Adds Context Menu Symbols
This CL adds 2 custom symbols to the Context Menu.
Bug: 131554
Change-Id: Ice0957abadc9d91c9d4da17622810367b45cc477
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834258
Reviewed-by: Gauthier Ambard <[email protected]>
Commit-Queue: Ewann Pellé <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036540}
PageLoadMetrics: Prerender2 support for LocalNetworkRequestsPageLoadMetricsObserver
No behavioural change.
LocalNetworkRequestsPageLoadMetricsObserver will be deprecated the near
future. This CL makes it clear that this class doesn't support
prerendering and using STOP_OBSERVING.
Bug: 1317494
Change-Id: I2fd61c29a186a0e021df68a44c27c85086323c72
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3833677
Reviewed-by: Takashi Toyoshima <[email protected]>
Reviewed-by: Kouhei Ueno <[email protected]>
Commit-Queue: Ken Okada <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036539}
policy: add deprecated field back to proto
Add url_parameter_to_autofill_saml_username optional field back to
SAMLSettingsProto as it may be causing incompatibility issues.
This field was removed in https://crrev.com/c/3825930
BUG=b:242960381
TEST=unit_tests --gtest_filter="DevicePolicyDecoderTest.*" --single-process-tests
Change-Id: I8f1b20012c159166707deca3e73b582d67cfffca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3837177
Commit-Queue: Cristina Guerrero <[email protected]>
Reviewed-by: Felipe Andrade <[email protected]>
Reviewed-by: Alexander Hendrich <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036538}
[BrowserFragment] allow initializing the fragment with creation params
This allows users of the API to customize the behaviour by providing a
profileId, persistenceId (for state resumption), and setting the
incognito mode.
Change-Id: I10c9702e6461ae8efdc6e65c2532df592c71375f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3823165
Reviewed-by: Clark DuVall <[email protected]>
Reviewed-by: Susanne Westphal <[email protected]>
Reviewed-by: Ken Buchanan <[email protected]>
Commit-Queue: Rayan Kanso <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036537}
dpwa: Fix tests for CreateShortcutIgnoresManifest
When CreateShortcutIgnoresManifest is enabled, some existing tests
break because they use CreateShortcut when they shouldn't.
WebAppIntegrationBrowserTest.WindowModeSettingsIsNotAvailableForIsolatedAppsOnAppSettingsPage
failed because the install URL was different from the start URL, which
was pointed at the root. Instead, we should use InstallMenuOption.
WebAppIntegrationBrowserTestMacWinLinux.CheckSiteHandlesFile needs
file handlers, which are not part of shortcuts anymore, so they
also need to use InstallMenuOption. Same for a few other tests,
where the behavior was identical in both cases, but installation
makes more sense semantically.
BUG=cr:1216457
TEST=browser_tests --gtest_filter=*WebAppIntegrationBrowserTest.*
Change-Id: I3f8de870129f19e17b04ed7a275dead05e23036e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3829562
Reviewed-by: Daniel Murphy <[email protected]>
Commit-Queue: Philipp Weiß <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036536}
AnonymousIframe: Improve tests around DOM storage.
This checks two anonymous iframe in the same page share the same access
to LocalStorage/SessionStorage.
Bug: 1285233,1286743
Change-Id: Ib279b243a92296e1ebbab5bd21a44ca56455f9d7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3835599
Reviewed-by: Yifan Luo <[email protected]>
Commit-Queue: Arthur Sonzogni <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036535}
Passwords: Notify Settings after user authentication expires
This CL replaces the |last_authentication_time_| with a
RetainingOneShotTimer. The timer gets a TimeoutCallback from
PasswordsPrivateDelegateImpl, so that the event router can be called.
This CL is a foundational CL for putting password viewing page behind
authentication (go/password-notes-auth-dd). Future CLs will use the
event in the view page.
Bug: 1345899
Change-Id: I2fcd69ea562d654ec1caa72857a9f30cf7deeda7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3779668
Reviewed-by: Mohamed Amir Yosef <[email protected]>
Commit-Queue: Adem Derinel <[email protected]>
Reviewed-by: Devlin Cronin <[email protected]>
Reviewed-by: Rebekah Potter <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036534}
Roll Chrome Win32 PGO Profile
Roll Chrome Win32 PGO profile from chrome-win32-main-1660791474-54751a986e854dfcb1fc1e95474ec3ee15fc0ce0.profdata to chrome-win32-main-1660802055-4580a4c3503de99bad7a4bdd2106a70e8083184c.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win-chrome
Tbr: [email protected]
Change-Id: I2c4ff70633228f02b5ab8c1054358723d0b1e1e6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3837795
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036533}
[Autofill Assistant] Disable landscape mode for QR code dialog fragment
- We do not have UX mocks for landscape mode and we are disabling it for now.
- We are forcing orientation to PORTRAIT in onResume method and then listening to orientation after onDestroy method. (We checked that onResume, onCreate methods behave similarly)
Bug: b/241884205
Change-Id: Ic52e3716d1c15634b14bd09dad1adfd1027118a6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3836274
Reviewed-by: Florian Gauger <[email protected]>
Commit-Queue: Vinit Solanki <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036532}
[IndexedDB] Add clean-up after a test
Bug: 1296584
Change-Id: I5c1c071f2edd4bab20ec5e7accceb60d5f2ec2ba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832663
Commit-Queue: Kateryna Prokopenko <[email protected]>
Reviewed-by: Simon Zünd <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036531}
[linux/wayland] Fixed popup anchors and translation of located events.
This CL fixes two issues related to how popup windows were handled.
The first issue is explained in details in the linked crbug. In short,
the XDG positioner used the surface coordinates, although the XDG shell
specification tells that it should originate from the window geometry.
The second issue is a bug in handling the located events: they did not
take the geometry into account as well, which resulted in that menus
received events located outside the popup.
This CL fixes both issues by introducing the convenience method for
getting the window geometry offset, and then applying that offset where
necessary.
Bug: 1292486
Change-Id: I715b84659f98881742ac1f07dad5ccb961531628
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3835664
Reviewed-by: Maksim Sisov <[email protected]>
Commit-Queue: Alexander Dunaev <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036530}
Fix UserMediaClientTest failures on win-backuprefptr-x86-fyi-rel.
blink::InitializeAudioSourceObject() compares
platform_source->device().id with audio_source->device().id to know
whether the source is an audio source or not. However
MockMojoMediaStreamDispatcherHost::GenerateStreams() creates a video
source whose device id is the same as an audio source if both
controls.audio.device_id and controls.video.device_id are the same
(e.g. empty strings).
So a MediaStreamVideoSource instance will be treat as
MediaStreamAudioSource, and ProcessedLocalAudioSource::From() may
cause crash.
The sample build failures:
https://ci.chromium.org/ui/p/chromium/builders/ci/win-backuprefptr-x86-fyi-rel/6720/overview
Change-Id: Ic13874f8fc061349eeb7dd0988726d45d4a8dcb6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834548
Commit-Queue: Takashi Sakamoto <[email protected]>
Reviewed-by: Tony Herre <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036529}
Roll Chrome Mac PGO Profile
Roll Chrome Mac PGO profile from chrome-mac-main-1660780262-f4fa315aae4417a804bcd059d89281b143896c7b.profdata to chrome-mac-main-1660802055-5bf492462dadc6642d8aac4e4cc964e2ed94733c.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:mac-chrome
Tbr: [email protected]
Change-Id: Ib4dfbfd6aab1a5406b5987904bfff41f0011d806
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3837345
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036528}
DanglingPtr: fix dangling ptrs in gles2_cmd_decoder_passthrough
Bug: 1291138
Change-Id: Ie264dfa9d3b859e4266e474ec36670edf2808dcf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3829690
Commit-Queue: Ali Hijazi <[email protected]>
Reviewed-by: Brandon Jones <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036527}
Adds gpu cache destroyed callback for each cache.
- By setting the destroyed callback, the browser can notify the GPU
process that the cache is no longer being used on the browser side
and hence safe to stage it for removal on the GPU side. Without this
the GPU process doesn't know when it can cull stale or unused
in-memory caches. Note that we cannot just cull them when they are no
longer used on the GPU side because it is possible for the browser to
create new GPU channels referencing the culled cache since the browser
does not know that they have been destroyed on the GPU side. This
results in the GPU using an empty in-memory cache that will never be
populated.
Bug: dawn:549
Change-Id: Ie4578a44518c4bdafff9466efe0c05b42c89f08d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3827706
Commit-Queue: Loko Kung <[email protected]>
Reviewed-by: Alex Moshchuk <[email protected]>
Reviewed-by: Daniel Cheng <[email protected]>
Reviewed-by: Sunny Sachanandani <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036526}
Reland "[CodeHealth] Settings WebUI base::Value refactoring - Part 1"
In this CL OnStartupHandler::GetNtpExtension now returns a base::Value,
as `null` is a valid response to be sent by the handler.
This is a partial reland to a partial revert of the original commit. For
reference: https://crrev.com/c/3833396
This is a reland of commit f0e6d42f5906d8cac94c74f0c03070f984d8bfe0
Original change's description:
> [CodeHealth] Settings WebUI base::Value refactoring - Part 1
>
> This CL corrects the use of base value for the webui handlers of a
> couple of files under webui/settings.
>
> Bug: 1187001
> Change-Id: I4dc51df9ae48773d6e1fee292f7e7ba1dd9e83ba
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3810934
> Reviewed-by: Aga Wronska <[email protected]>
> Commit-Queue: Claudio DeSouza <[email protected]>
> Reviewed-by: Giovanni Ortuno Urquidi <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1033140}
Bug: 1187001
Change-Id: I52d8f77159474fa39e8a5e663e46fdc709104f74
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3828620
Commit-Queue: Claudio DeSouza <[email protected]>
Reviewed-by: Giovanni Ortuno Urquidi <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036525}
Lacros: Implement `AccountManagerFacadeImpl::ReportAuthError`
Design Doc: http://shortn/_hKoc0VqbIt
Bug: 1226055, 1312897
Change-Id: I52e64ffaae33b49127772c17fbe14120724d14c4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3829099
Commit-Queue: Kush Sinha <[email protected]>
Reviewed-by: Anastasiia N <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036524}
Set headers received time for H3/QUIC, for responseStart
Aligned with HTTP2, setting the time when response headers are
received. Separately, we should ensure early-hints time is
measured by responseStart.
Note that currently this cannot be tested in WPT, see:
https://github.com/web-platform-tests/rfcs/blob/106a43732c1a5ddf8cd24fa5436a7c43c14f5450/rfcs/quic.md
and https://github.com/web-platform-tests/wpt/issues/20159
Change-Id: If9a005fc
Fixed: 1044264
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3815441
Reviewed-by: Ryan Hamilton <[email protected]>
Commit-Queue: Noam Rosenthal <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036523}
Revise "Symbolizing a crash dump" commands in debugging tips
Seems like these got outdated
Bug: none
Change-Id: Iea2af064a12b75a136b48d5d1ede2b160f8a15bc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834455
Reviewed-by: Fabian Sommer <[email protected]>
Commit-Queue: Fabian Sommer <[email protected]>
Auto-Submit: Roman Sorokin <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036522}
[ios] Fixes NTP ViewController scrolledIntoFeed value
Fixed Transparency Issue on the NTP header when coming back from a tab to the first two cards. Removed a negative sign from offsetWhenScrolledIntoFeed as it was not needed and already calculated properly.
Bug: https://b.corp.google.com/issues/231322340
Change-Id: Icaf27e7c524896fac1b486d630c02e80a0866681
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834792
Reviewed-by: Sergio Collazos <[email protected]>
Reviewed-by: Adam Arcaro <[email protected]>
Commit-Queue: Guillem Perez <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036521}
[CodeHealth] Platform apps base::Value refactoring
This CL adjust several sites where deprecated base::Value methods are
removed.
Bug: 1187001, 1352780
Change-Id: I705d520085198f3f7f67aa60ffe6c8093cf3a74c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3828688
Commit-Queue: Claudio DeSouza <[email protected]>
Reviewed-by: Trent Apted <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036520}
[CodeHealth] Enrollment screen base::Value refactoring
This CL removes the use of any deprecated interfaces for the enrollment
screen handler.
Bug: 1187001
Change-Id: Ib670cc4ab096749aaba84baade4844ee57576fcb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3829696
Reviewed-by: Jeffrey Young <[email protected]>
Commit-Queue: Claudio DeSouza <[email protected]>
Reviewed-by: Xiyuan Xia <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036519}
Browsertests for ntp customize chrome button
Browser tests for accessing customize chrome side panel through ntp.
Change-Id: I9b9e0d0d1b12d94ace2fc54d812c786cf7dd07d1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3823498
Commit-Queue: Nihar Majmudar <[email protected]>
Reviewed-by: Thomas Lukaszewicz <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036518}
[Identifiability Study] Refactor and add a Multi-block Reid Estimator Unit Test
The current Reid Estimator unit tests cover reporting the Reid hash from single blocks. In this cl, we add a unit test to cover defining and reporting multiple blocks in 1 iteration.
We also refactored the Reid Estimator class to move the ComputeHashForReidScore into the private class ReidBlockStorage.
Bug: 1330244
Change-Id: Id15d66cab76e5424542ded167099d15ccd5993e9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3829236
Reviewed-by: Mike West <[email protected]>
Commit-Queue: Saeid Eid <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036517}
Emit mojo_interface_tag only in extended tracing mode
- This saves trace buffer space for field traces. Trace Processor then
generates the corresponding arg based on symbolization, see aosp/2162962
- For local traces, we still emit a raw string so that the trace makes
sense without symbolization.
Bug: b/240248381
Change-Id: Iccbe54d7cfe64f8581904a8cc0359b9548378ace
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3789361
Reviewed-by: Alexander Timin <[email protected]>
Commit-Queue: Igor Kraskevich <[email protected]>
Reviewed-by: Oksana Zhuravlova <[email protected]>
Reviewed-by: Eric Seckler <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036516}
Roll Chrome Win64 PGO Profile
Roll Chrome Win64 PGO profile from chrome-win64-main-1660791474-6895efe42be013a81bb9dfaa270caf6c25688cd2.profdata to chrome-win64-main-1660802055-d24b5a7cff1e39e8fd0c20cb9a99bbaeca1edc33.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win64-chrome
Tbr: [email protected]
Change-Id: I30127cbe49c6b517ecdcc112cef07fbbc7339079
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3833646
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036515}
Add tests for anonymous iframe origin trial about cookies.
This was requested here:
https://chromium-review.googlesource.com/c/chromium/src/+/3829096/comments/057b8588_5087ea1e
This patch copy the WPT test:
external/wpt/html/anonymous-iframe/cookie-store.tentative.https.window.js
and make sure it continues to work using the origin trial instead of the
blink feature.
Bug: 1318041
Change-Id: Ib909ed04158319ed13ce12efa8122a38e7428e5f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834543
Commit-Queue: Arthur Sonzogni <[email protected]>
Reviewed-by: Maks Orlovich <[email protected]>
Reviewed-by: Dominic Farolino <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036514}
[canvas] Account for SharedImage-backed canvases in memory-infra
Current canvas memory metrics are misleading, because they show 0
bytes in many cases even though the actual footprint is higher.
Besides this being misleading in memory-infra dumps, it also shows as
a large amount of "GPU" footprint which is "unclaimed" by other
processes.
This CL aims at correcting that, by attributing the GPU-side memory
memory footprint of canvases to the actual renderers. It relies on the
existing mechanism through which allocations in different processes
can be matched using a unique ID.
Bug: 1329375
Change-Id: I099ee3932d157a02734d546a79ad109d4ed2e70b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3747768
Commit-Queue: Benoit Lize <[email protected]>
Reviewed-by: Juanmi Huertas <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036513}
[base/allocator] Shim malloc_usable_size() on Android
On Android, all malloc()-related calls need to be wrapped by the linker,
otherwise they would go to the system allocator, namely either scudo or
jemalloc. These allocators are not very pleased to be asked about a
pointer they didn't allocate.
To fix that, wrap malloc_usable_size() on Android.
Reported by mlippautz@.
Change-Id: Ib6cf8d6aa003d25666b4ff4dfa6cebabe35d6c83
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834601
Reviewed-by: Michael Lippautz <[email protected]>
Commit-Queue: Benoit Lize <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036512}
metrics: add usage metrics for WebRTC.PeerConnection.validicechars
which will allow determining whether enforcing the specification
is safe to do.
Related WebRTC CL:
https://webrtc-review.googlesource.com/c/src/+/268380
BUG=chromium:1053756
Change-Id: If9834a241d7626a9794722a679b7da2b411f3ece
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3809752
Commit-Queue: Philipp Hancke <[email protected]>
Reviewed-by: Johannes Kron <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036511}
[PA] MTECheckedPtr: Support direct maps
The present incarnation of MTECheckedPtr has hitherto only supported
normal buckets. This CL adds support for direct maps.
Fixed: 1307514
Change-Id: If9aaea647cbfec9dc07c527eb53c1daaad8389e9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3815338
Commit-Queue: Kalvin Lee <[email protected]>
Reviewed-by: Bartek Nowierski <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036510}
FrameSet NG: Port the first part of LayoutFrameSet::LayOutAxis()
This CL ports the first loop of LayoutFrameSet::LayOutAxis() to
NGFrameSetLayoutAlgorithm.
This CL has no behavior changes due to a disabled runtime flag.
Bug: 1346221
Change-Id: I9c14863619fb7aeb49547b2b99f8ae6d20c72365
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3837081
Reviewed-by: Koji Ishii <[email protected]>
Auto-Submit: Kent Tamura <[email protected]>
Commit-Queue: Kent Tamura <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036509}
Roll Chrome Mac Arm PGO Profile
Roll Chrome Mac Arm PGO profile from chrome-mac-arm-main-1660780262-60c71a0b98589364c70ec4d0645375d6dab8e723.profdata to chrome-mac-arm-main-1660802055-ac45d6ec643d14be8715fc9b37eac5b4dc7224d0.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-arm-chromium
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:mac-chrome
Tbr: [email protected]
Change-Id: I37e2d636d5f0a6ab221ce1f411aa36a2017a9cfc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3837344
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036508}
[BrowserFragment] Save the instance state
The instance state is passed from weblayer to the host process when
ready, so that the Fragment's onSaveInstanceState method can run
synchronously
Change-Id: Ie4eab56d9a73f4ccc86abc1b523658888ed83181
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3819769
Reviewed-by: Clark DuVall <[email protected]>
Reviewed-by: Ken Buchanan <[email protected]>
Reviewed-by: Susanne Westphal <[email protected]>
Commit-Queue: Rayan Kanso <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036507}
arc: Perform Android Management check in ArcRequirementChecker
- ArcRequirementChecker owns ArcAndroidManagementChecker.
- NEGOTIATING_TERMS_OF_SERVICE and CHECKING_ANDROID_MANAGEMENT are
merged into State::CHECKING_REQUIREMENTS.
- ArcRequirementChecker reports the result using the Delegate interface
instead of callbacks.
- Replace OnTermsOfServiceNegotiatedForTesting(true) +
StartArcForTesting() in tests with
EmulateRequirementCheckCompletionForTesting().
BUG=b:236927651
TEST=tast run arc.Optin.vm arc.OptinManaged.vm
TEST=unit_tests --gtest_filter="*Arc*"
Change-Id: If7038c730afc4ff85ff42bc1372331d7b21f6b97
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3823637
Reviewed-by: Hidehiko Abe <[email protected]>
Reviewed-by: Dominick Ng <[email protected]>
Commit-Queue: Ryo Hashimoto <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036506}
[BrowserFragment] Add ability to inject JS in a tab
Change-Id: I21d7c3941c0b9b8a304ba367cfef737d8d498f05
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3836436
Reviewed-by: Ken Buchanan <[email protected]>
Reviewed-by: Susanne Westphal <[email protected]>
Reviewed-by: Clark DuVall <[email protected]>
Commit-Queue: Rayan Kanso <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036505}
Roll vulkan-deps from 31a5e38f3e48 to 33d0b2c3122a (12 revisions)
https://chromium.googlesource.com/vulkan-deps.git/+log/31a5e38f3e48..33d0b2c3122a
Changed dependencies:
* spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/1728c1d40a..0073a1fa36
* vulkan-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/497f232680..d55c7aaf04
* vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/e51d0d1c18..caaa7f2d66
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-chromium-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86;luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:win-asan;luci.chromium.try:linux_chromium_cfi_rel_ng
Bug: None
Tbr: [email protected],[email protected],[email protected]
Change-Id: Ic834dfb64aecdea874a030df3f768c4eb4d1ae56
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3836346
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036504}
[VCN Card on File] Add feature flag for syncing usage data
go/card-on-file-chrome-sync
Bug: 1341387
Change-Id: I82756c650c5773a9d9fd2e3240385475be143045
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3836420
Reviewed-by: Marc Treib <[email protected]>
Commit-Queue: Alexander Tekle <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036503}
Quota: Update persistent quota deprecation flag
This change updates blink code that used the
quota deprecation flag to use the method that
checks both feature list flag and chrome switches
following change for enterprise policy.
Bug: 1233525
Change-Id: Ic595aa931efac96ca1ac2fb4adf5aedcce962ee6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3833319
Commit-Queue: Marijn Kruisselbrink <[email protected]>
Reviewed-by: Marijn Kruisselbrink <[email protected]>
Auto-Submit: Ayu Ishii <[email protected]>
Commit-Queue: Ayu Ishii <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036502}
Roll DevTools Frontend from 75531fdd1fd3 to 3fcfa37a5526 (1 revision)
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/75531fdd1fd3..3fcfa37a5526
2022-08-18 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: [email protected]
Change-Id: Iec6e8c6c76881a00d8adb18382030ef215897660
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3837618
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036501}
webrtc: add WPT for outbound-rtp.active statistics
added in https://github.com/w3c/webrtc-stats/pull/649
Also add myself as stat owner and replace my personal email with the work one in wpt/webrtc/OWNERS
BUG=webrtc:14291
Change-Id: I2cf0cad859bb1fbea0692e0f0c009d2cc67ec813
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3803166
Reviewed-by: Harald Alvestrand <[email protected]>
Commit-Queue: Philipp Hancke <[email protected]>
Reviewed-by: Henrik Boström <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036500}
Roll Chrome Linux PGO Profile
Roll Chrome Linux PGO profile from chrome-linux-main-1660780262-7ef36d13ad35359a3b3c32a0a6645dd0355a4adf.profdata to chrome-linux-main-1660802055-fd573ddf1ad9a2999a1104730245430a95ca2ef9.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-linux-chromium
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:linux-chrome
Tbr: [email protected]
Change-Id: Ie6a05cb33fea1a85312614ff240cbe602769a308
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834064
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036499}
FrameSet: Fix an integer overflow
crrev.com/1035755 introduced an integer overflow:
(int * int) / int64_t
The type of the multiplication result is |int|, and can overflow.
This CL changes it like:
ClampTo<int>((int * int64_t) / int64_t)
Bug: 1353277
Change-Id: Ib59d1a16762e139bf882a8619e344914339d535d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3836624
Auto-Submit: Kent Tamura <[email protected]>
Reviewed-by: Morten Stenshorne <[email protected]>
Commit-Queue: Morten Stenshorne <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036498}
[Floss] Improve error message in ExportedCallbackManager
Reland of CL:3834584.
This adds more precise error message when failed to parse D-Bus
parameters.
Bug: b:233124021
Change-Id: I4ed3ace61def53ef4f6773484bdf35928010ed64
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832930
Commit-Queue: Sonny Sasaka <[email protected]>
Reviewed-by: Abhishek Pandit-Subedi <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036497}
[Frameworks roll] Roll to 468383811 piper revision
Change-Id: I9fb2f18a091321c53682b84f691b8b7faa7fe25e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3827996
Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1036496}
Enable virtual keyboard multitouch flag by default.
Bug: 1320473
Change-Id: I8d54a82ea79739e877e8b49d296d6619ee320f3f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3812330
Reviewed-by: Darren Shen <[email protected]>
Commit-Queue: Darren Shen <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036495}
MojoSharedBufferVideoFrame: Use base::ReadOnlySharedMemoryRegion
MojoSharedBufferVideoFrame manages the buffer with
base::UnsafeSharedMemoryRegion. But it is used to pass a video frame
for a hardware accelerated video encoder and encrypted video
decoded in the utility process for a renderer. Either encoder or renderer must not to the buffer. This CL changes
MojoSharedBufferVideoFrame uses base::ReadOnlySharedMemoryRegion.
Bug: b:241362231
Bug: b:242527747
Test: webrtc call
Change-Id: I64a46b19ca4f4e82b6f1e5887dbef7de1ccd109b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3833795
Commit-Queue: Hirokazu Honda <[email protected]>
Reviewed-by: John Rummell <[email protected]>
Reviewed-by: Dominick Ng <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036494}
[anchor-position] Fix |ObjectIsRelayoutBoundary|
This patch changes |ObjectIsRelayoutBoundary| to return `false`
when it has any descendants that have `anchor-name`, because
changes to anchors need to be propagated.
Bug: 1309178
Change-Id: I81435305895bd197a08aecf2dab0aaf183183415
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3826592
Commit-Queue: Koji Ishii <[email protected]>
Reviewed-by: Ian Kilpatrick <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036493}
Move GetPredictedCountryCode test.
Moves the test from FormDataImporterTest to the newly created
FormDataImporterUtilsTest.
Bug: 1007974
Change-Id: Ifd13406a5d64ee8109393557affdaac3e402eaf3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3829184
Reviewed-by: Christoph Schwering <[email protected]>
Commit-Queue: Florian Leimgruber <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036492}
[PageInfo] Add link to "All Sites"
Add a link to "All Sites" settings subpage to FPS
button in the Cookies subpage.
Bug: 1346305
Change-Id: If70bf4eb7dc1a293d56940b406e95b1fdde81b07
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834166
Reviewed-by: Rebekah Potter <[email protected]>
Reviewed-by: Christian Dullweber <[email protected]>
Reviewed-by: Olesia Marukhno <[email protected]>
Commit-Queue: Zofia Salata <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036491}
Remove TestExpectations entries for fast/js/instanceof-test.html
The test is no longer flaky.
Bug: 1249176, 1344983
Change-Id: Ibb7ecee24d719e3de28ceb4f277810dfec948cf6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3835456
Auto-Submit: Yutaka Hirano <[email protected]>
Reviewed-by: Nidhi Jaju <[email protected]>
Commit-Queue: Nidhi Jaju <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036490}
Roll Skia from 751cad567169 to 246d7e915ff6 (1 revision)
https://skia.googlesource.com/skia.git/+log/751cad567169..246d7e915ff6
2022-08-18 [email protected] Roll ANGLE from 7a87e90d03be to 2965f81b83e5 (3 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Cq-Do-Not-Cancel-Tryjobs: true
Bug: None
Tbr: [email protected]
Change-Id: Idb26c9da375a1274e39594214445f204cbd57ec1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3837101
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036489}
[Test Reviver] Replicate swarming settings in test suite exception for android-pie-x86-fyi-rel-reviver.
We do not replicate test filter from android-pie-x86-rel
because we suppose to run disabled tests on
android-pie-x86-fyi-rel-reviver.
Bug: 1348392
Change-Id: I7be365ca9e7ee0f6812d3633b3e6a68905525d5b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834779
Commit-Queue: James Shen <[email protected]>
Reviewed-by: Haiyang Pan <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036488}
Roll Dawn from a48f233ca58b to 30fa0d8d2ced (3 revisions)
https://dawn.googlesource.com/dawn.git/+log/a48f233ca58b..30fa0d8d2ced
2022-08-18 [email protected] Makes sure to zero-init D3D12 descriptors for cache keys.
2022-08-17 [email protected] reader/wgsl: Error if 'struct' has attributes
2022-08-17 [email protected] Roll SwiftShader from 3fb7084b02d7 to ab4bf6ad00d4 (2 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dawn-chromium-autoroll
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel
Bug: chromium:1352803
Tbr: [email protected]
Change-Id: I8e03f02ad424530c9c0206686670793f913be31a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834061
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036487}
Expose a single private method for tests instead of all private members.
This approach scales better with new tests that get written, and it
limits the ways that the tests can reach into the private details of
the SUT.
Change-Id: I4fcc6a8ade03c121d78eb283630376e95a6f0b6c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3830317
Auto-Submit: Chris Fredrickson <[email protected]>
Commit-Queue: Mike West <[email protected]>
Reviewed-by: Mike West <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036486}
Remove chromeos_remote_device_isolated_tests from chromeos-kevin-rel
The pool's finally starting to slowly die off. Eventually we'll want
to replace these with the jacuzzis, but they're still having issues
(b/239867489). So just remove tests from this bot to at least let
builds go through.
Bug: None
Change-Id: I041ccbc30646894a05d0297f4485606ff523c7fe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3835657
Auto-Submit: Ben Pastene <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Commit-Queue: Ben Pastene <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036485}
[lacros skew tests] Refresh skew tests for M106
This CL updates the ash version ['106.0.5247.0'] for Lacros version skew testing.
If this CL caused regressions, please revert and stop the autoroller
at https://luci-scheduler.appspot.com/jobs/chrome/lacros-version-skew-roller
Also please file a bug to OS>LaCrOS>Partner, and CC [email protected],
[email protected].
[email protected]
Bug: None
Change-Id: Ibeeea4821683ffe25829e10baf34506322bc7f99
Requires-Testing: True
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3835155
Bot-Commit: Rubber Stamper <[email protected]>
Auto-Submit: chrome-weblayer-builder <chrome-weblayer-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036484}
[Files app] Add VolumeType output operator
BUG=chromium:1313346
TEST=autoninja -C out/Default unit_tests && out/Default/unit_tests --gtest_filter=VolumeManagerTest.*
Change-Id: Ic9f4e34cf7f1a1357544984e456f461867755f1e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3833320
Reviewed-by: Marcello Salomao <[email protected]>
Commit-Queue: François Degros <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036483}
FrameSet NG: Implement NGFrameSetPainter::PaintChildren()
This CL has no behavior changes due to a disabled runtime flag.
Bug: 1346221
Change-Id: I6901aa5d38ce3c064de3962cd8343ede1f35db96
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3837539
Auto-Submit: Kent Tamura <[email protected]>
Reviewed-by: Koji Ishii <[email protected]>
Commit-Queue: Koji Ishii <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036482}
Import wpt@4530a81a3700212455c412d6f82b7da4c57a8b1c
Using wpt-import in Chromium bc05f3445f1f837b910be901372586208e20de63.
Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md
Directory owners for changes in this CL:
[email protected]:
external/wpt/css/css-break
NOAUTOREVERT=true
[email protected]
No-Export: true
Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-input-fyi-rel,linux-blink-rel
Change-Id: Id950e456cb8f82375ed630574c3ac88ce6e6aca6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3831539
Auto-Submit: WPT Autoroller <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036481}
History Sync: Populate new context_annotations columns in the DB
The previous CL (crrev.com/c/3825961) added a bunch of new columns to
the history DB. This CL adds code to populate the first batch of them,
those in the context_annotations table, for non-iOS platforms.
The new columns in the content_annotations table, as well as the
iOS-specific plumbing, are left for another followup.
Bug: 1347012
Change-Id: I003d2537ff0abed3fe47d571dc361ab539bef783
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3828371
Commit-Queue: Marc Treib <[email protected]>
Reviewed-by: Sophie Chang <[email protected]>
Reviewed-by: Tommy Li <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036480}
[String matching] Use a small num_matching_blocks_penalty by default.
This parameter penalizes match results according to how many distinct
matching sequences were detected i.e. contiguous matching is favored
over fragmented matching.
Currently there are three users of
FuzzyTokenizedStringMatch::Relevance(), using the following values of
num_matching_blocks_penalty:
1) App search provider: 0.0
2) Game search provider: 0.0
3) Local search provider 0.1.
This CL does the following:
A) Update (1) and (2) to use a penalty of 0.1, in line with (3).
This is a good penalty to add to (1) and (2), as it dampens some
over-triggering we have been seeing.
B) Remove this parameter from the FuzzyTokenizedStringMatch interface.
Leave it in the SequenceMatcher interface for now, for testing
purposes. This is part of an effort to simplify the FTSM interface.
C) Update tests as needed, introducing slightly more flexibility to
absolute error values.
readme
Test: existing, and inspection of fuzzy benchmarking output as per
Bug: 1336160
Change-Id: I015d5fdc151bb96cc4d0a2e4db8c171d3b5f32fe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3835532
Reviewed-by: Rachel Wong <[email protected]>
Commit-Queue: Amanda Deacon <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036479}
Roll Chrome Win32 PGO Profile
Roll Chrome Win32 PGO profile from chrome-win32-main-1660780262-b3bae951c038a2b091e4926a65d5356ab293dd11.profdata to chrome-win32-main-1660791474-54751a986e854dfcb1fc1e95474ec3ee15fc0ce0.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win-chrome
Tbr: [email protected]
Change-Id: I326bd4c66b8c37eee4522597dd42298a6a01af72
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834869
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036478}
Avatars: Add string constants for avatar file paths
The added file paths will be used to generate gstatic URLs and to cache
the user profile avatars locally.
DD: go/avatars-from-cloud
Bug: b/241977201
Test: None
Change-Id: I062d6e43dd52146db81a7712b459d350e68ed940
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3831248
Reviewed-by: Jeffrey Young <[email protected]>
Reviewed-by: Xiyuan Xia <[email protected]>
Commit-Queue: Yue Li <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036477}
system-extensions: Add SystemExtensionsServiceWorkerManager for service worker operations
Abstraction on top of ServiceWorkerContext that allows
us to register and unregister Service Workers for a given System
Extensions. In the future it will allow other parts of the system
to also start service workers for System Extensions and
garbage collect any service worker registrations that might
have failed before.
Also changes the RegisterServiceWorker call to no longer post a task
since the call to register itself is asynchronous.
Bug: b:242265231
Change-Id: I941a322638b5f3d2f5a4927fd9db745bb5ff98a1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3831801
Reviewed-by: Jiewei Qian <[email protected]>
Commit-Queue: Giovanni Ortuno Urquidi <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036476}
webrtc: merge encoded transform audio/video flags
which are no longer separate in the current JS-exposed implementation
BUG=None
Change-Id: I5d0dbc793a0c5ab8aa49112aee99b299247d484a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834592
Reviewed-by: Harald Alvestrand <[email protected]>
Commit-Queue: Philipp Hancke <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036475}
Refactor DefaultSearchManager to use PrefService::GetValueDict
This is part of a larger migration effort based on
go/trust-your-prefs.
Bug: 1341996
Test: Existing unit tests
Change-Id: Ided7f487006994975b80c16be3e5d44265bbd2ff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3829276
Reviewed-by: Angela Yoeurng <[email protected]>
Commit-Queue: Roland Bock <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036474}
Fix DCHECK failure at ChunkedDataPipeUploadDataStream::OnSizeReceived
We call OnSizeReceived in OnDataPipeGetterClosed when the status and
size haven't been received yet. As we don't update `size_` if the
received status is not OK, Checking `size_` is not enough. Let's
check `status_` too.
Change-Id: Ib34b6430c4bf29d790fe64cbb695a678a5b32532
Bug: 1353519
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3836233
Auto-Submit: Yutaka Hirano <[email protected]>
Reviewed-by: Matt Menke <[email protected]>
Commit-Queue: Matt Menke <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036473}
Adds browsertest for saved devices.
This change refactors the original AccessCodeCastIntegrationBrowsertest to accommodate saved devices flow. It then build two new test cases for instant expiration and saved devices.
Bug: b/241939554
Change-Id: I8dfe06417843493aeda527ab4dffe8f48168eae9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3831066
Reviewed-by: Brian Malcolm <[email protected]>
Commit-Queue: George Benz <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036472}
Roll PDFium from ee44620f2b58 to 213704d5b741 (10 revisions)
https://pdfium.googlesource.com/pdfium.git/+log/ee44620f2b58..213704d5b741
2022-08-18 [email protected] Remove stray fx_memory_wrapper.h includes.
2022-08-18 [email protected] Encapsulate FXJS_PerIsolateData members.
2022-08-18 [email protected] Use DataVector<T> in remaining files.
2022-08-18 [email protected] Encapsulate CXFA_FMLexer::Token and make read-only
2022-08-17 [email protected] Encapsulate CFXJS_ObjDefinition members
2022-08-17 [email protected] Make CFWL_ThemePart::m_iPart const and private
2022-08-17 [email protected] Remove redundant public: from struct ExecEventParaInfo.
2022-08-17 [email protected] Mark ProgressiveDecoder::HorzTable instance variables as private
2022-08-17 [email protected] Use DataVector<T> in core/fxcodec/.
2022-08-17 [email protected] Remove V8::InitializeSandbox calls
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pdfium-autoroll
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in PDFium: https://bugs.chromium.org/p/pdfium/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: [email protected]
Change-Id: Ic65469dabd66df6ebe2f57aad9442af47d5476b6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3837361
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036471}
ash: autozoom_controller: Fix state uninitialized
The state_ was uninitialized and cause issue with MSan:
https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests/29843/overview
Fix it by initializing it to default OFF.
Bug: b:221980963
Test: manually test on DUT
Change-Id: I3c50529d3fb1f2fe3021ec0b474676619cf00abc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3833768
Commit-Queue: Pi-Hsun Shih <[email protected]>
Auto-Submit: Pi-Hsun Shih <[email protected]>
Reviewed-by: Andre Le <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036470}
Added UMAs to detect when a user copies out a MS Office file from Drive.
Bug: 1351947
Change-Id: If0b15e25f5e3e54b22ced6a34adcd3aa941032bc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3829502
Commit-Queue: Cassy Chun-Crogan <[email protected]>
Reviewed-by: Peter Marshall <[email protected]>
Reviewed-by: Austin Tankiang <[email protected]>
Reviewed-by: Nigel Tao <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036469}
Roll DevTools Frontend from 7b67f32b65dc to 75531fdd1fd3 (1 revision)
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/7b67f32b65dc..75531fdd1fd3
2022-08-18 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS (trusted-origins)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: [email protected]
Change-Id: I19061053e56eb4053b4927c24ba69bf49e2da712
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3837474
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036468}
Roll Chrome Win64 PGO Profile
Roll Chrome Win64 PGO profile from chrome-win64-main-1660780262-fe2e456587600df4c05f8fe8d55836a99b887d3c.profdata to chrome-win64-main-1660791474-6895efe42be013a81bb9dfaa270caf6c25688cd2.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win64-chrome
Tbr: [email protected]
Change-Id: I1c96cae39f63c7bf96bed199dadbf059e85a3ed1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3836951
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036467}
Roll Skia from 4d50c634c2bf to 751cad567169 (1 revision)
https://skia.googlesource.com/skia.git/+log/4d50c634c2bf..751cad567169
2022-08-18 [email protected] Roll Dawn from e86758cb26ed to 30fa0d8d2ced (1 revision)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Cq-Do-Not-Cancel-Tryjobs: true
Bug: None
Tbr: [email protected]
Change-Id: I8b7ed01f443dbbbd124206b60277881f92a4d42f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3837613
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036466}
Refactor components/network to use PrefService::GetValueDict
This is part of a larger migration effort based on
go/trust-your-prefs.
Bug: 1341996
Test: Existing unit tests
Change-Id: I202c8b84102782ef538c5b661c4579777a089bde
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832668
Commit-Queue: Roland Bock <[email protected]>
Reviewed-by: Steven Bennetts <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036465}
prerender: refactor disabling Prerender2 in extension
This CL simplifies the logic of disabling Prerender2 in extension, and
removes the check in the browser code.
Bug: 1344511
Change-Id: I5007c7dc6cd9e819be814587913448d946c906fb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3816161
Reviewed-by: Devlin Cronin <[email protected]>
Commit-Queue: Huanpo Lin <[email protected]>
Reviewed-by: Takashi Toyoshima <[email protected]>
Reviewed-by: Alex Moshchuk <[email protected]>
Reviewed-by: Scott Violet <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036464}
mojo-ipcz: Implement driver object serialization
Implements the Serialize() and Deserialize() APIs.
The generic object serialize and deserialize implementation lives
in Transport, since a Transport may be needed for context (e.g. on
Windows). Individual driver objects must implement a basic
interface to be supported there, and this CL implements it trivially
for TransmissibleHandle.
On most platforms, the PlatformHandles emitted by each object's
Serialize() method are transmissible directly out-of-band by the
Transport's underlying Channel. On Windows, Transport serializes
them into inline message data instead.
A test is added to cover usage across all platforms, essentially
transmitting one Transport over another, to another process, and
then verifying end-to-end operation of the transmitted Transport.
Bug: 1299283
Change-Id: I8068df58b0e1ecb0c232d039c9f5a36aef2519f9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3811994
Reviewed-by: Daniel Cheng <[email protected]>
Commit-Queue: Ken Rockot <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036463}
Revert "Move //chromeos/{=>ash/components}/dbus/dbus_thread_manager.{cc|h}"
This reverts commit 4923462ac8f410160841521a70b70dd6e16ff5f1.
Reason for revert: breaks chromeos builders
Original change's description:
> Move //chromeos/{=>ash/components}/dbus/dbus_thread_manager.{cc|h}
>
> Also, this CL moves "dbus" component target to
> chromeos/ash/components/dbus/BUILD.gn from chromeos/dbus/BUILD.gn
>
> This CL is part of the Chrome OS source code directory migration:
> https://docs.google.com/document/d/1g-98HpzA8XcoGBWUv1gQNr4rbnD5yfvbtYZyPDDbkaE.
>
> Bug: 1164001
> Change-Id: I16767b0f79aa209f8e58e65f41c6f65d296fd596
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3833683
> Reviewed-by: Hidehiko Abe <[email protected]>
> Owners-Override: Hidehiko Abe <[email protected]>
> Commit-Queue: Yeunjoo Choi <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1036425}
Bug: 1164001, 1354022
Change-Id: I762b616c3d9f3d12793013e06245186ce9c86185
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3837540
Bot-Commit: Rubber Stamper <[email protected]>
Commit-Queue: Huanpo Lin <[email protected]>
Owners-Override: Robert Lin <[email protected]>
Reviewed-by: Yeunjoo Choi <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036462}
[Files app] Make MountCondition a class enum
With proper output operator for debugging and logging.
BUG=chromium:1313346
TEST=autoninja -C out/Default unit_tests browser_tests components_unittests ash_components_unittests chrome
Change-Id: I562bdfc3a27e430f3cf2113daa2f30022f465e3d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3835224
Reviewed-by: Tommy Li <[email protected]>
Reviewed-by: Marcello Salomao <[email protected]>
Commit-Queue: François Degros <[email protected]>
Reviewed-by: Timothy Loh <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036461}
Do not trigger duplicated blink-rel bots
Some blink-rel bots have cq counter parts. When rebaselining, running
such bots will waste resources, and cause non-deterministic results
when rebaselining. The reason is that we will randomly pick one bot
when there are duplicate bots.
Removed linux-blink-optional-highdpi-rel from builders.json and
'--flag-specific' from rebaseline-cl. Highdpi flag-specific tests
are running inside linux-rel. And rebaseline-cl will automatically
fetch flag specific results as long as the builders are triggered.
Also fixed the port mismatch for mac-rel.
Bug: 1353054
Change-Id: I31925521166bc169d416c3b536124bf994c60f83
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3828509
Reviewed-by: Jonathan Lee <[email protected]>
Commit-Queue: Weizhong Xia <[email protected]>
Reviewed-by: Preethi Mohan <[email protected]>
Reviewed-by: Xianzhu Wang <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036460}
Pass old Frame's had_sticky_activation_before_navigation using OldDocumentInfoForCommit
Currently had_sticky_activation_before_navigation passing assumes that
the old document uses the same Frame object as the new committing
document. This might not be the case if the commit uses LocalFrame
swap (RenderDocument).
This CL makes it so that we correctly get that state from the old
Frame by saving the old Frame's had_sticky_activation_before_navigation
in OldDocumentInfoForCommit. Also moves OldDocumentInfoForCommit into
its own file.
Bug: 936696
Change-Id: Ib43efb28f9cd4e7a7d8cebe374f82df8d63eaeb6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3545496
Reviewed-by: Daniel Cheng <[email protected]>
Commit-Queue: Rakina Zata Amni <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036459}
Roll androidx from 07PiAW_hVf8sSGw-h... to nJRbqGtdXzotJnB8k...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/androidx-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:android-internal-binary-size;luci.chrome.try:android-internal-rel
Tbr: [email protected],[email protected]
Change-Id: Ic5d3fd141bfa9cc1ac791a1ed6fb205c5ef7bdcd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3837472
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036458}
blink::Color: Remove helper functions
Remove the functions MakeRGB, MakeRGBA, MakeRGBA32FromFloats,
MakeRGBAFromHSLA, MakeRGBAFromHWBA, and several of their helper
functions. Change all callers to use methods on the Color class.
Un-inline several functions in blink::Color, and minimize the number
of places where the blink::Color::color_ member is used.
The next patch in this sequence will change the internals of the
Color class to no longer be an RGBA32.
Bug: 1351544
Change-Id: I8270d462443e75d9a3bb64d92ee959a39119e15c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834250
Commit-Queue: ccameron chromium <[email protected]>
Reviewed-by: Kentaro Hara <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036457}
Reland "[IBAN Filling] Introduce IBAN Manager class which handles IBAN related functionality including retrieving IBAN data, managing IBAN suggestions, filling IBAN field."
This is a reland of commit bb575920eca2cfeb09026b415aabaa5538b0f648
Original change's description:
> [IBAN Filling] Introduce IBAN Manager class which handles IBAN related functionality
> including retrieving IBAN data, managing IBAN suggestions, filling IBAN field.
>
> Implementation: https://docs.google.com/document/d/1JlAfURVa3ALm-U5HC4p41fx8PFF-mtRSgN2czfVcb-w/edit?resourcekey=0-t-Xsicco20apeY2EFZGGMw#heading=h.e5uc3qpefa5q
>
> Next step:
> Create IBANManagerFactory which creates IBANManager instance, get IBANMnager instance in the client (chrome/browser/ui/autofill/chrome_autofill_client.cc), and creates SingleFieldFillerRounter(https://source.chromium.org/chromium/chromium/src/+/main:components/autofill/core/browser/autofill_client.cc;drc=36c59c53be1d8852f5087008c45a95797bac9730;l=49) with the IBANManager.
>
> Bug: 1344590
> Change-Id: I36bed55de6d518db5d92f412b7a16e54c76f52a6
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3794042
> Reviewed-by: Jared Saul <[email protected]>
> Commit-Queue: Qihui Zhao <[email protected]>
> Reviewed-by: Christoph Schwering <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1036327}
Bug: 1344590
Change-Id: I6c3c7518dcd954e3b75e9828140bab62c4a8f5bf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3835154
Commit-Queue: Qihui Zhao <[email protected]>
Reviewed-by: Christoph Schwering <[email protected]>
Reviewed-by: Jared Saul <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036456}
PageLoadMetrics: Prerender2 support for SecurityStatePLMO
SecurityStatePLMO records active page's security level at OnCommit time,
and OnComplete time, and these metrics are not affected by
navigation_start or activation_start time.
This patch makes the class to continue observing, and record the initial
security level at DidActivatePrerenderedPage time instead of OnComplete
time for prerendering pages as their state doesn't affect the active
page state until the page is activated.
Bug: 1317494
Change-Id: I15ec73ac54898a531d10af1cd4015b3fc3cb9301
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3836273
Reviewed-by: Chris Thompson <[email protected]>
Reviewed-by: Ken Okada <[email protected]>
Commit-Queue: Takashi Toyoshima <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036455}
Roll src/net/third_party/quiche/src/ 866ce9fef..9b5aac917 (11 commits)
https://quiche.googlesource.com/quiche.git/+log/866ce9fefe2a..9b5aac9172d4
$ git log 866ce9fef..9b5aac917 --date=short --no-merges --format='%ad %ae %s'
2022-08-17 vasilvv Partial rollback of cl/467313603 to unblock Chromium merge
2022-08-17 ramosalex Fix unused parameter on non-Linux builds.
2022-08-17 ramosalex Add bind to interface socket option support to QuicUdpSocketApi and QuicClientEpollNetworkHelper.
2022-08-17 quiche-dev `balsa_headers`: fix a C++ compatibility issue.
2022-08-16 quiche-dev Allow setting a delay for a response.
2022-08-16 dschinazi Move RFC 9000 variable length integer encoding from QUIC to QUICHE
2022-08-15 danzh In QuicConnection::OnCanWrite(), early return after writing buffered crypto frames if the connection gets closed.
2022-08-15 vasilvv Fix race condition in EndToEndTest.AckNotifierWithPacketLossAndBlockedSocket
2022-08-12 ericorth Roll forward cl/466743774
2022-08-12 ericorth Fix a memory destruction ordering issue in Quic test code
2022-08-12 ericorth Internal change
Created with:
roll-dep src/net/third_party/quiche/src
Change-Id: I656e7d516bde33c9a25215d5b2b5a78f6c71de10
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3837176
Commit-Queue: Yoichi Osato <[email protected]>
Reviewed-by: Yoichi Osato <[email protected]>
Auto-Submit: Victor Vasiliev <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036454}
sheriff: Disable threaded-no-composited-antialiasing/animations/
sample-on-last-keyframe.html
Bug: 1354013
Change-Id: Iaf6bec2f5c00465d7bf0d9f5adb66ecdec09c8b9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3837536
Commit-Queue: Hiroki Nakagawa <[email protected]>
Auto-Submit: Huanpo Lin <[email protected]>
Reviewed-by: Hiroki Nakagawa <[email protected]>
Owners-Override: Robert Lin <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036453}
[games] add UMA metrics for result errors
Bug: 1305880
Change-Id: Ifb0b0426b3a2d18e8ab42b4778f65cdc1beced17
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3836216
Commit-Queue: CJ Huang <[email protected]>
Reviewed-by: Tony Yeoman <[email protected]>
Reviewed-by: Rachel Wong <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036452}
sheriff: Disable WebUIInteractionTestUtilInteractiveUiTest.
CompareScreenshot_SecondaryWebUI
Bug: 1354017
Change-Id: Ifcbc35b133640c0c6036e83987a50675ead81141
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3836620
Commit-Queue: Yoichi Osato <[email protected]>
Auto-Submit: Huanpo Lin <[email protected]>
Reviewed-by: Yoichi Osato <[email protected]>
Owners-Override: Robert Lin <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036451}
Roll WebGPU CTS from 168bc9b7f359 to 4e8df07a22ca (1 revision)
https://chromium.googlesource.com/external/github.com/gpuweb/cts.git/+log/168bc9b7f359..4e8df07a22ca
2022-08-18 [email protected] Add timestamp_query_set,device_mismatch test to beginComputePass tests (#1760)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webgpu-cts-chromium-autoroll
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel
Bug: None
Tbr: [email protected]
Change-Id: I4ef7c0e24862f1483badf30e1f28423029e7b476
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3828520
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036450}
longpress diacritics: a11y announcments for show, insert, dismiss
Screen shot for all messages:
go/tscreen/056aa0d54bc898ac0ee58baff5ab50290c79b237
Decided to go with a picture of diacritics window for show/insert/dismiss to give the translaters context. If I took a screen shot after insert and dismiss, it'll be very confusing since there is no diacritic window in the screenshot.
Bug: b/242254214
Change-Id: I445e80668b940f2b208e81214bb33dc4c7305373
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3836680
Reviewed-by: Mehrab N <[email protected]>
Reviewed-by: Keith Lee <[email protected]>
Commit-Queue: jhtin <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036449}
e14s flags audit: Remove some jiwan flags, bump remaining to 111.
Bug: b/242234620
Change-Id: I76a7267bff21908772cfa8106acd0eb9d2e5281e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3829505
Commit-Queue: Jing Wang <[email protected]>
Reviewed-by: Jing Wang <[email protected]>
Auto-Submit: jhtin <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036448}
FrameSet NG: Set up and transfer FrameSetLayoutData
This CL has no behavior changes due to a disabled runtime flag.
Bug: 1346221
Change-Id: I903ecf3239108dae0e062dda6493f4a23e613243
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3833527
Reviewed-by: Koji Ishii <[email protected]>
Commit-Queue: Kent Tamura <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036447}
Refactor Value usage in chrome\browser\media\router\providers\cast, CL2
Make cast_channel::InternalMessage use Value::Dict.
Bug: 1187001,1338341
Change-Id: If56047f668563779054b616c3fd26d1475e560aa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3811467
Reviewed-by: Mark Foltz <[email protected]>
Commit-Queue: Matt Menke <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036446}
Revert "Roll src/third_party/flatbuffers/src/ 0fe13cb28..a3508f36d (70 commits)"
This reverts commit cbdcba2835f14cca305dfdc999b7165c08fd20d0.
Reason for revert: causing build failures on Chrome uprev: b/242884846
Original change's description:
> Roll src/third_party/flatbuffers/src/ 0fe13cb28..a3508f36d (70 commits)
>
> https://chromium.googlesource.com/external/github.com/google/flatbuffers.git/+log/0fe13cb28ce5..a3508f36d5ef
>
> $ git log 0fe13cb28..a3508f36d --date=short --no-merges --format='%ad %ae %s'
> 2022-08-15 paulovictor.pinheiro [Kotlin] Make sure namespace path exist for code generation (#7357)
> 2022-08-15 mirko.bonadei Stop using __has_trivial_copy on recent clang versions. (#7443)
> 2022-08-15 derekbailey [C#] Rework how sorted vectors are looked up (#7441)
> 2022-08-14 derekbailey Define minimum buffer size (#7440)
> 2022-08-14 32997632+stefan301 make_span overloads for pointer to vector (#7374) (#7435)
> 2022-08-14 derekbailey [TypeScript] Fix namespaceless schema generation (#7432)
> 2022-08-13 derekbailey Add checks to verifier (#7438)
> 2022-08-14 maxim.zaks Fix FlexBuffers JS/TS bug https://github.com/google/flatbuffers/issues/6934 (#7434)
> 2022-08-13 derekbailey Add flatc python tests to CI (#7437)
> 2022-08-13 derekbailey Update TypeScriptTest.py to work better cross platform (#7436)
> 2022-08-12 derekbailey Update gitingore to reflect name change (#7431)
> 2022-08-12 derekbailey Remove auto including locale functions (#7430)
> 2022-08-13 kevinsong [C++] Set StructDef::has_key property when deserializing from binary schema (#7386) (#7428)
> 2022-08-10 krueger [C++] Make template parameter in stl_emulation.h more explicit to avoid conflicts with cpprestsdk U macro (#7424)
> 2022-08-10 46622381+YashasviChaurasia Issue#6959 :Updated Automatically generated rust files. (#7425)
> 2022-08-09 sssooonnnggg111 avoid zero-as-null-pointer warning (#7423)
> 2022-08-08 derekbailey [C++] Vector of Tables equality (#7415)
> 2022-08-09 andrei.burdulescu [golang] Perform keyword escaping after case conversion (#7421)
> 2022-08-08 derekbailey Turn of fail fast for C++ CI
> 2022-08-08 derekbailey Remove stringop-overflow from error (#7422)
> 2022-08-08 andrei.burdulescu [golang] Add support for text parsing with json struct tags (#7353)
> 2022-08-07 derekbailey Moved TypeScriptTests to python script (#7411)
> 2022-08-07 aman.eureka Rebased: grpc/compiler: Respect filename suffix and extension during code generation (#7414)
> 2022-08-06 derekbailey Add tests for flatc (#7405)
> 2022-08-06 derekbailey Add FLATBUFFERS_STRICT_MODE (#7408)
> 2022-08-07 bjornharrtell [TS] Use TextEncoder and TextDecoder (#7400)
> 2022-08-06 chronoxor Compilation issue msys2 #7399 (#7409)
> 2022-08-06 derekbailey Delete .travis directory
> 2022-08-06 derekbailey Revert "Compilation issue msys2 (#7403)" (#7407)
> 2022-08-05 derekbailey Update readme.md
> 2022-08-05 derekbailey Revert "grpc/compiler: Respect filename suffix and extension during code generation (#7343)" (#7406)
> 2022-08-05 derekbailey Delete cpp-linter.yml
> 2022-08-06 chris (#7323) Rename CMake files according to project name (#7378)
> 2022-08-06 sfzhou.scut Fix error msg format when generate GRPC failed (#7350)
> 2022-08-06 aman.eureka grpc/compiler: Respect filename suffix and extension during code generation (#7343)
> 2022-08-05 33996375+06393993 Fix Clang-Cl compile on Windows (#7308)
> 2022-08-05 jkuszmaul [TS/Bazel] Minor improvements to typescript.bzl (#7300)
> 2022-08-06 sssooonnnggg111 [TS] fix incorrect reverse when writting array of structs (#7271)
> 2022-08-05 aardappel Fix FlexBuffers Verifier tracking vectors reuse at wrong offset
> 2022-08-05 atilkurtulmus Add missing const (#7401)
> 2022-08-05 chronoxor Compilation issue msys2 (#7403)
> 2022-07-26 derekbailey keep-prefix keeps relative pathing (#7394)
> 2022-07-27 jumbycc fix(#7360): grpc used deprecated functions (#7361)
> 2022-07-27 yassershalabi cpp_generator: comment out unused parameter to avoid warnings (#7381)
> 2022-07-26 derekbailey Updated Newtonsoft.Json to 13.0.1 (#7393)
> 2022-07-07 ian Fix references to LICENSE file (#7377)
> 2022-06-29 insertjokehere [Dart] Implement putBool to fix errors when serializing structs with bools (#7359)
> 2022-06-23 49699333+dependabot[bot] Bump Newtonsoft.Json from 12.0.3 to 13.0.1 in /tests/FlatBuffers.Test (#7363)
> 2022-06-16 caleb.zulawski Reenable optional json (#7352)
> 2022-06-15 derekbailey Only include direct included filed (#7348)
> 2022-06-15 derekbailey Revert "Implement optional scalars for JSON (#7322)" (#7351)
> 2022-06-14 derekbailey Revert "Move reflection_ts_fbs into a separate directory (#7342)" (#7349)
> 2022-06-14 derekbailey Remove asserting in verifier for flattests
> 2022-06-14 dbaileychess move -Wextra-semi to GCC 8.0+
> 2022-06-14 jkuszmaul [TS] Don't generate self-imports with --ts-flat-file (#7340)
> 2022-06-15 sturm.timo [golang] Create missing namespace directory structure (#7324) (#7325)
> 2022-06-15 paulovictor.pinheiro [Kotlin] Remove download benchmark files dependency (#7314)
> 2022-06-14 derekbailey Disable Android on Linux CI build
> 2022-06-15 sssooonnnggg111 [TS] fix ts import path issue (#7298)
> 2022-06-15 kiwamura0314 replace io/ioutil to os (#7281)
> 2022-06-14 caleb.zulawski Implement optional scalars for JSON (#7322)
> 2022-06-13 i Move reflection_ts_fbs into a separate directory (#7342)
> 2022-06-13 caleb.zulawski Implement optional scalars for Python (#7318)
> 2022-06-05 26250654+mustiikhalil Started implementation for private flags in rust (#7269)
> 2022-05-29 26250654+mustiikhalil Adds full supposed for Wasm in the swift lib (#7328)
> 2022-05-23 casperneo Use keep case for Rust union discriminant type. (#7321)
> 2022-05-23 bluelive Add explicit return types to lobster generated code (#7312)
> 2022-05-14 bjornharrtell Add size check to fix out of bounds read risk (#7304)
> 2022-05-12 bsilver8192 Update Rust docs page (#7296)
> 2022-05-11 103502437+mr-swifter [swift] add had<ArrayName> property for arrays to check presence in a message (#7280)
>
> Created with:
> roll-dep src/third_party/flatbuffers/src
>
> Bug: 1343975
> Change-Id: I233dd4183622128639f5893b396972ea9d8b5898
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3830012
> Commit-Queue: Mirko Bonadei <[email protected]>
> Auto-Submit: Mirko Bonadei <[email protected]>
> Reviewed-by: Nico Weber <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1035211}
Bug: 1343975
Change-Id: Ib59cd0c53c5a75ca06544dba4fb90c08dd7a652f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3836876
Auto-Submit: Yoshiki Iguchi <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036445}
RTCVideoEncoder: Remove |status_| lock protection
This CL lets only RTCVideoEncoder::Impl access |status_| so that the
variable is not needed to be protected by lock.
Bug: b:241349739
Test: Meet call
Change-Id: Ic00dff94d882a3498fe5c10db13fa87597f61528
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3811075
Reviewed-by: Markus Handell <[email protected]>
Commit-Queue: Hirokazu Honda <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036444}
Update settings > Security and Privacy > Lock screen
This control now applies to lid close as well as suspend.
http://go/chrome-ss/38408cb2415733b666ba3afcf07ced6172ca6f75
Bug: 902589
Change-Id: I94afde42cf15e186cd2f6c778647d2cc0fa11793
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3826498
Reviewed-by: Xiaohui Chen <[email protected]>
Commit-Queue: Joel Hockey <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036443}
Reland "Add TRACE_EVENT Encode() function of MojoVEA and its clients"
This is a reland of commit 4609f724a3677c3ead89de51a5c50501fdc1053e
Original change's description:
> Add TRACE_EVENT Encode() function of MojoVEA and its clients
>
> This CL adds TRACE_EVENT to MojoVEA::Encode() and its caller functions
> so as to measure the pre-processing time like scaling and buffer
> allocation for Encode().
>
> Bug: b:241362231
> Test: chrome://tracing in Google Meet call
> Change-Id: Ic3cfa624230b20466bd7b96f96907283ee1959e7
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3812821
> Reviewed-by: Joe Downing <[email protected]>
> Reviewed-by: Ryan Keane <[email protected]>
> Commit-Queue: Hirokazu Honda <[email protected]>
> Reviewed-by: Eugene Zemtsov <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1035034}
Bug: b:241362231
Change-Id: I8d760990eb2ae4026408a088436a001bd7bc0a81
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3833316
Reviewed-by: Eugene Zemtsov <[email protected]>
Reviewed-by: Joe Downing <[email protected]>
Commit-Queue: Hirokazu Honda <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036442}
[Frameworks roll] Roll to 468358183 piper revision
Change-Id: I398c583db76d28e02aa21cb80ae532c8f89fa025
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834296
Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1036441}
PageLoadMetrics: Prerender2 support for ServiceWorkerPLMO
ServiceWorkerPLMO records service worker specific variant of
page load metrics to evaluate the performance gain obtained
through the service worker existence. From the viewpoint of
this purpose, merging prerendering page data originated from
activation_time can be noise.
So this patch just stops observing on prerendering pages.
Bug: 1317494
Change-Id: I7b6906c42c443d58c9b6072fb01a9dcee2b2544a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834226
Reviewed-by: Hiroki Nakagawa <[email protected]>
Reviewed-by: Yoshisato Yanagisawa <[email protected]>
Commit-Queue: Takashi Toyoshima <[email protected]>
Reviewed-by: Ken Okada <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036440}
Roll Chrome Win32 PGO Profile
Roll Chrome Win32 PGO profile from chrome-win32-main-1660759200-913e2c13072ec66036ccda24b56d1cf694a84a8f.profdata to chrome-win32-main-1660780262-b3bae951c038a2b091e4926a65d5356ab293dd11.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win-chrome
Tbr: [email protected]
Change-Id: I09e97b992f0c27cfcd0f9695c07b44a7afa76852
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3837358
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036439}
Add metrics for video chroma subsampling formats.
This adds UMA metrics for decoding requests to platform decoders with
different chroma subsampling formats, even some of the formats may be
rejected by the platform decoder.
Bug: 1348712
Change-Id: I4aac5b6f2af638c9930804f864540878e8276174
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3817231
Reviewed-by: Evan Liu <[email protected]>
Reviewed-by: Dan Sanders <[email protected]>
Commit-Queue: Jianlin Qiu <[email protected]>
Reviewed-by: Hirokazu Honda <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036438}
Roll Skia from 4b720a135d0d to 4d50c634c2bf (20 revisions)
https://skia.googlesource.com/skia.git/+log/4b720a135d0d..4d50c634c2bf
2022-08-17 [email protected] Roll skcms from 9c30a95f0f16 to c2639b59758f (1 revision)
2022-08-17 [email protected] Roll ANGLE from 24012abcb9ed to 7a87e90d03be (3 revisions)
2022-08-17 [email protected] Reland "Use the remote canvas to convert Slugs"
2022-08-17 [email protected] Revise SmallPathRenderer to pre-transform paths to improve batching.
2022-08-17 [email protected] [Metal] Check for SDK version when setting up CommandBuffer creation
2022-08-17 [email protected] Roll Dawn from a48f233ca58b to e86758cb26ed (2 revisions)
2022-08-17 [email protected] Roll ANGLE from 213a1ee6e6db to 24012abcb9ed (4 revisions)
2022-08-17 [email protected] Manual Dawn roll
2022-08-17 [email protected] [metal] Enable enhanced encoder status.
2022-08-17 [email protected] Roll vulkan-deps from 476247c15324 to c24b395f1402 (2 revisions)
2022-08-17 [email protected] Better encapsulate SkColorFilter_Matrix
2022-08-17 [email protected] Revert "Use the remote canvas to convert Slugs"
2022-08-17 [email protected] Roll vulkan-deps from 16356830603c to 476247c15324 (2 revisions)
2022-08-17 [email protected] Roll Dawn from 6e716c77accd to 0f0ba20208be (5 revisions)
2022-08-17 [email protected] Reland "Raster Pipeline: Use clang::musttail when possible"
2022-08-17 [email protected] Add bazel rules for avif decode
2022-08-17 [email protected] Roll SwiftShader from 3fb7084b02d7 to ab4bf6ad00d4 (2 revisions)
2022-08-17 [email protected] Use the remote canvas to convert Slugs
2022-08-17 [email protected] Disable VectorScalarMath test on ANGLE + Intel GPU.
2022-08-17 [email protected] Roll Dawn from 1130a602efc9 to 6e716c77accd (3 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Cq-Do-Not-Cancel-Tryjobs: true
Bug: chromium:1320153,chromium:1320305,chromium:1320930
Tbr: [email protected]
Test: Test: Test: EGLContextSharingTestNoFixture.InactiveThreadDoesntPreventCleanup*
Change-Id: I86c3b8d12686cc311f317a743660858a4f7352ad
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3836926
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036437}
Roll Chrome Mac Arm PGO Profile
Roll Chrome Mac Arm PGO profile from chrome-mac-arm-main-1660759200-46b5fdcae896d77ccc4504d58ac8a64bac713603.profdata to chrome-mac-arm-main-1660780262-60c71a0b98589364c70ec4d0645375d6dab8e723.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-arm-chromium
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:mac-chrome
Tbr: [email protected]
Change-Id: Ib6171bd47336813a46d111e53edde72f5e821db3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3836947
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036436}
Fix ChildProcessFieldTrialSyncerTest.FieldTrialState failure on backuprefptr fyi bots
ChildProcessFieldTrialSyncerTest.FieldTrialState doesn't consider the
case: --enable-features=TestFeature:TestParam/TestValue. If the
parameter is given, StudyTestFeature.GroupTestFeature will be created
and the test will always fail. So we need to use
ScopedFeatureList::InitWithEmptyFeatureAndFieldTrialLists() to prepare
empty feature and field trial lists.
Change-Id: I9574e3076358462a342637ec4a60497b20daca5b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3830742
Commit-Queue: Takashi Sakamoto <[email protected]>
Reviewed-by: Alexei Svitkine <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036435}
Roll Chrome Mac PGO Profile
Roll Chrome Mac PGO profile from chrome-mac-main-1660759200-53c3b4e47331d0bee6d3137f2c7622e479d87e66.profdata to chrome-mac-main-1660780262-f4fa315aae4417a804bcd059d89281b143896c7b.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:mac-chrome
Tbr: [email protected]
Change-Id: I4dece20b8927a0c897d1b1854236d73c8a466cd3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834219
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036434}
Roll Depot Tools from 940cd8e20f54 to d14f65eba90c (1 revision)
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/940cd8e20f54..d14f65eba90c
2022-08-18 [email protected] add reclient for ChromeOS
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/depot-tools-chromium-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: [email protected],[email protected],[email protected],[email protected]
Change-Id: I178ebb1960d8f1c72ba36295be4922ac7085512c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3837374
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036433}
system-extensions: Add more unit tests for PersistenceManager
Adds tests for corrupted System Extension ids and for missing
manifests.
Bug: b/221120509
Change-Id: Idacc59554b857437e8487d0fd8c52f3c8a86ddb9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3823155
Reviewed-by: Dominic Schulz <[email protected]>
Commit-Queue: Giovanni Ortuno Urquidi <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036432}
Roll Catapult from b3421074fa70 to e12cc61cfa3d (1 revision)
https://chromium.googlesource.com/catapult.git/+log/b3421074fa70..e12cc61cfa3d
2022-08-17 [email protected] [chromeperf] migrate main handler from webapp2 to flask
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/catapult-autoroll
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: [email protected]
Change-Id: I03186e60c940c7698d6330230a9244e77c147238
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3837334
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036431}
Roll src-internal from 266a1641a0fa to 3d298fbbd22d (4 revisions)
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/266a1641a0fa..3d298fbbd22d
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: chromium:1349706,chromium:1351353,chromium:1353757
Tbr: [email protected]
Change-Id: Ic8f93e3362bfbad856f61072b65f88ebf669b803
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834220
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1036430}
Use "", not u8"", for Unicode strings.
In C++20, the latter produces char8_t*, which can't be compared with
char*.
Bug: 1284275
Change-Id: Ib663df98bd23f2547ec75d032bbecde41c4005ee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3837252
Auto-Submit: Peter Kasting <[email protected]>
Reviewed-by: Yoshifumi Inoue <[email protected]>
Commit-Queue: Yoshifumi Inoue <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036429}
Update base::Value usage in stateful_ssl_host_state_delegate.cc.
In particular, use Value::List and Value::Dict to manipulate and access
lists and dictionaries. All other APIs to do so are deprecated.
Bug: 1337341
Change-Id: Ia4a2c9bfc76d6a63abe9c5ef96180025237a98a2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3836692
Reviewed-by: Emily Stark <[email protected]>
Commit-Queue: Matt Menke <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036428}
Show a different 'Translating page' title in the Translate Message UI.
Before this CL, when a user loads a page in a language that they have
"Always translate pages in <language>" set for, then the translate
message UI will pop up with the title "Translate page?" and a spinning
progress indicator until the translation finishes.
This CL changes this such that if the translate message UI was not
showing and then is directly opened in a translation-in-progress state,
then show a separate "Translating page" title indicating that
translation is in progress, instead of the default "Translate page?"
title. The title string will still be "Translate page?" when translation
is in progress if the translate message UI was already visible in the
before-translation state, e.g. if the user clicks the "Translate" button
on the translate message UI.
Bug: 1353868
Change-Id: If940d68388e02e914ec982700576a8430d279455
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834740
Reviewed-by: Trevor Perrier <[email protected]>
Commit-Queue: Scott Little <[email protected]>
Commit-Queue: Trevor Perrier <[email protected]>
Auto-Submit: Scott Little <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036427}
Updating trunk VERSION from 5247.0 to 5248.0
* This is an automated release commit.
* Do not revert without consulting [email protected].
NOAUTOREVERT=true
Change-Id: I3035a711a19ae2f995e09abac1ea50a9c41a5bcd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3835080
Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1036426}
Move //chromeos/{=>ash/components}/dbus/dbus_thread_manager.{cc|h}
Also, this CL moves "dbus" component target to
chromeos/ash/components/dbus/BUILD.gn from chromeos/dbus/BUILD.gn
This CL is part of the Chrome OS source code directory migration:
https://docs.google.com/document/d/1g-98HpzA8XcoGBWUv1gQNr4rbnD5yfvbtYZyPDDbkaE.
Bug: 1164001
Change-Id: I16767b0f79aa209f8e58e65f41c6f65d296fd596
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3833683
Reviewed-by: Hidehiko Abe <[email protected]>
Owners-Override: Hidehiko Abe <[email protected]>
Commit-Queue: Yeunjoo Choi <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036425}
WebUI: Add a dark mode color for cr-tooltip-icon
This makes cr-tooltip-icon more likely to pass contrast ratio on dark
mode as it aligns with cr-icon-button's colors.
The fix doesn't work for the Incognito NTP since that page isn't a
true dark mode page and has a lighter card background color, so force
its cr-tooltip-icon to be the same color as the card's text.
Fixed: 1311727
Change-Id: I3b9916aab2b4d54283477094e6736ad7861ea992
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3836695
Reviewed-by: Rebekah Potter <[email protected]>
Commit-Queue: John Lee <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036424}
Deprecate SoftwareReporter.CreateJobResult
This histogram has never logged anything but SUCCESS. We don't actively
monitor it, so it can be removed.
Fixed: 1343458
Change-Id: I8172b17f22f053c821a366272da6e6459f8188d1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834622
Auto-Submit: Daniel Rubery <[email protected]>
Reviewed-by: Rohit Bhatia <[email protected]>
Commit-Queue: Rohit Bhatia <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036423}
Roll Chrome Win64 PGO Profile
Roll Chrome Win64 PGO profile from chrome-win64-main-1660769982-10f954c13e36edc95e4577507982ecddf2ec4388.profdata to chrome-win64-main-1660780262-fe2e456587600df4c05f8fe8d55836a99b887d3c.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win64-chrome
Tbr: [email protected]
Change-Id: I0270781530a97d9006472ebb108ce29d0b4865ba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3836929
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036422}
Update V8 to version 10.6.194.
Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/0601466c..41bc7435
Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues
Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_chromeos_msan_rel_ng
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel
[email protected],[email protected],[email protected]
Change-Id: I4372eac6c2cb9f1de505914e9c989b17738619cc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3835656
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1036421}
Roll src/third_party/libavif/src/ d22d4de94..e0954237c (13 commits)
https://chromium.googlesource.com/external/github.com/AOMediaCodec/libavif.git/+log/d22d4de94120..e0954237c40f
$ git log d22d4de94..e0954237c --date=short --no-merges --format='%ad %ae %s'
2022-08-08 wtc Use the latest versions of GitHub Actions
2022-08-05 wtc Add .github/workflows/ci-windows.yml
2022-08-17 vigneshv avifenc: Set YUV format to 400 for grayscale PNGs
2022-08-17 wtc Fix Clang and GCC -Wswitch-enum warnings
2022-08-17 wtc Delete a stale (and malformed) comment
2022-08-16 wtc Add the avifDecoder option 'imageDimensionLimit'
2022-08-17 vigneshv Update comment in avif.h about libyuv usage
2022-08-16 wtc Remove AVIF_API from include/avif/internal.h
2022-08-16 wtc Ext: Update to SVT-AV1 v1.2.1
2022-08-16 wtc Compile with Clang -Wshorten-64-to-32 warning flag
2022-08-16 vigneshv Fix rgbPixelBytes computation in avifPrepareReformatState
2022-08-16 yguyon Fix MSVC cast warning in avifABGRToJ420()
2022-08-16 yguyon Use libyuv for default PNG RGB-to-YUV in avifenc
Created with:
roll-dep src/third_party/libavif/src
[email protected],[email protected]
Change-Id: I155778bcdda1e9cb3e36b3e54a09e5c04e57b55b
Bug: b/242362974
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3837256
Auto-Submit: Wan-Teh Chang <[email protected]>
Reviewed-by: James Zern <[email protected]>
Commit-Queue: James Zern <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036420}
[iOS] Re-enable PermissionsTestCase.testPermissionsAfterTabSwitch
Root cause is fixed in iOS 16 beta 5. Verified locally on latest
Xcode beta.
Fixed: 1343380
Change-Id: I65a4f59519b2d89f9d2219097d10b6a7450f1211
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3822911
Commit-Queue: Rohit Rao <[email protected]>
Reviewed-by: Rohit Rao <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036419}
Fix shadow variables in //media.
- Rename one variable to resolve the shadowing.
- Remove 2 stray variables that are useless.
Bug: 1344231
Change-Id: I6294ff8f046988b069da2342f6da80b4f93abd88
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3835650
Commit-Queue: Lei Zhang <[email protected]>
Reviewed-by: Eugene Zemtsov <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036418}
Add WebApp::IsolationData to store IWA-specific information
This is an optional field that will be present for IWAs and will
contain all IWA-specific information, which is just bundle/proxy
location for now.
Bug: 1333966
Change-Id: Ic9f7da2cc9f1cc4349c7b8010f2fc9828b8b45e8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3828576
Reviewed-by: Phillis Tang <[email protected]>
Commit-Queue: Robbie McElrath <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036417}
Roll Website from 00a10042ab33 to b49932fe8cc1 (1 revision)
https://chromium.googlesource.com/website.git/+log/00a10042ab33..b49932fe8cc1
2022-08-18 [email protected] 2022Q2 Chrome Security update
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/website-chromium
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Website: https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: [email protected]
Change-Id: Ifa22a0e4c489a8963ca098389479073d3a46a98c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3837353
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036416}
ambient: rm setting page components pt2
Remove handlers, search tags, localized messages.
BUG=b/242568053
TEST=Manually
Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Change-Id: I479a3fc4ff46474549ebb37345eb2a3afb5e4ac3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3828319
Reviewed-by: Sam McNally <[email protected]>
Commit-Queue: Jason Thai <[email protected]>
Reviewed-by: Xiaohui Chen <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036415}
emoji-picker: reenabling tabs category scrolling in v1
fix prevented scrolling in both v1 and v2.
b: 220202868 was only meant to modify v2, but the
Bug: b:220202868
Change-Id: I2e706ccdf744e15aa1525eb686780cc9dcc07bc5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3829249
Commit-Queue: Zac Partridge <[email protected]>
Reviewed-by: Mehrab N <[email protected]>
Reviewed-by: Keith Lee <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036414}
Roll Projector App from OEv_F3H4roKFxcVxV... to xbs9VsAB3uK9gNyQt...
Release_Notes: http://go/projector_app-x20/relnotes/Main/projector_app_20220817_RC00.html
https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/projector_app/app/+/xbs9VsAB3uK9gNyQtNWmfxYtOUrdR28ynajJYzrV6tAC
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/projector-app-chromium-autoroll
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chrome.try:linux-chromeos-chrome
Bug: b/242874099,b/242880838
Tbr: [email protected]
Change-Id: Ie0b2d47c91339f85e8c98dfd955cb0afc58cdbc9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3836925
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1036413}
saved_desks: Update focus ring after save for later
This CL fixed the issue that when press enter to click the
save_as_template_button or the save_for_later_button, the yellow focus
ring didn't update to the edited desk name view; instead, it stayed as
the button used to be.
After the fix, the yellow focus ring can update to the correct position.
Test: Manual
Change-Id: I2afc59c342b236b83ec503684d1694cc7099b2ad
Fixed: 1349843
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3835745
Reviewed-by: Sammie Quon <[email protected]>
Reviewed-by: Daniel Andersson <[email protected]>
Commit-Queue: Hongyu Long <[email protected]>
Reviewed-by: Yongshun Liu <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036412}
Add a Finch parameter for the InputStream available() call.
That way we can see how much that helps compared to using a larger mojo data pipe.
Bug: 1318925
Change-Id: Iac79bfb3d6a8731ac40851c76efde1167688f2b7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3831251
Reviewed-by: Yutaka Hirano <[email protected]>
Reviewed-by: Clark DuVall <[email protected]>
Commit-Queue: Yutaka Hirano <[email protected]>
Auto-Submit: John Abd-El-Malek <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036411}
Remove Mic and Lens buttons in clobber mode.
The change ensures the Lens and Voice icons are removed from toolbar
when Omnibox contains user input to release some space for the input
content.
This seems to have recently regressed as a result of multiple new
features launching.
Before: http://screen/aKXnqSgE4GDm7CF.png
After: http://screen/3g8NHGTkiiwW2ir.png
ZPS: http://screen/7H2vhbqXXpzqz7j.png
Change-Id: I8db60813fd46ccd7bc523e34627e5012954158a5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832324
Reviewed-by: Gang Wu <[email protected]>
Commit-Queue: Gang Wu <[email protected]>
Auto-Submit: Tomasz Wiszkowski <[email protected]>
Reviewed-by: Brandon Wylie <[email protected]>
Commit-Queue: Brandon Wylie <[email protected]>
Commit-Queue: Tomasz Wiszkowski <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036410}
Discard pages at the end of slot span for smaller slot size
Current code truncates the unused system pages at the end of a slot span
only if slot_size >= SystemPageSize(). However, we can do this when
slot_size < SystemPageSize() as well, so this CL added that case.
Bug: 1345599
Change-Id: I17f63addc861658095de7618ca97a4435ec869f8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3828206
Reviewed-by: Takashi Sakamoto <[email protected]>
Reviewed-by: Kalvin Lee <[email protected]>
Commit-Queue: Honoka Anada <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036409}
Support "enabled when on battery" in Battery Saver Mode
Bug: 1308741
Change-Id: I68095cb8b076849c331f084f95ca7deeff9292fc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3827735
Commit-Queue: Anthony Vallée-Dubois <[email protected]>
Reviewed-by: Chris Hamilton <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036408}
Roll Chrome Linux PGO Profile
Roll Chrome Linux PGO profile from chrome-linux-main-1660759200-a83b9b53dac865d5c3359250f156cb8570d3c467.profdata to chrome-linux-main-1660780262-7ef36d13ad35359a3b3c32a0a6645dd0355a4adf.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-linux-chromium
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:linux-chrome
Tbr: [email protected]
Change-Id: I965e689ce98a541c7cffaef826e26724efd64065
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3837336
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036407}
[Files app] Remove MountPoint's constructor
MountPoint is now a plain struct.
Also removed the MountPointInfo type alias. It is not used anymore.
BUG=chromium:1313346
TEST=autoninja -C out/Default unit_tests browser_tests components_unittests ash_components_unittests
Change-Id: Ibf1491653d89d8a026991c9b84ca9c6c8c5db74a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3822426
Commit-Queue: François Degros <[email protected]>
Reviewed-by: Marcello Salomao <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036406}
Clean up unused kDesktopPWAsTabStripLinkCapturing feature flag
Change-Id: I6036c6b85b17923773eed9acf09c3ba43b508c17
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3836874
Reviewed-by: Louise Brett <[email protected]>
Commit-Queue: Louise Brett <[email protected]>
Auto-Submit: Alan Cutter <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036405}
[Lacros] Remove l10n dependency out of //chromeos
crrev.com/c/3725767 uncovered an issue introduced in crrev.com/c/3686576
, that l10n dependency was required in `version_loader.cc` under
//chromeos/version. //chromeos is used to host chromeos related low
level code and should never depend on anything on the frontend side.
This CL removes l10n operations from //chromeos and re-distribute them
into //chrome/browser/ui/webui where l10n operations can happen. Because
of this change, chrome://version frontend code is also updated to
reflect corresponding callback API changes.
This CL only impact Ash-chrome. However, in a future CL where the
chrome://version logic of both Lacros and Ash will be unified, this CL
will also be beneficial to Lacros.
Bug: 1347780
Change-Id: I514384bf1743ad8284b38560d9f7f8855dc4c1f7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3800840
Reviewed-by: Mitsuru Oshima <[email protected]>
Reviewed-by: Hidehiko Abe <[email protected]>
Commit-Queue: Di Wu <[email protected]>
Reviewed-by: Kyle Horimoto <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036404}
[A11y Settings Revamp] Apply visual updates and improve layout
Apply visual updates and tweak padding to improve layout as part of
go/a11y-settings-revamp
Bug: 1292142
Change-Id: Ie9b284d39d1bb108d8474e5f7257368e4565dda5
AX-Relnotes: Updates to Chrome OS Accessibility Settings to make accessibility options simpler / easier to use.
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3836396
Reviewed-by: Katie Dektar <[email protected]>
Reviewed-by: Jimmy Gong <[email protected]>
Commit-Queue: Josiah Krutz <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036403}
Obliterate use_fake_binary_experiment
No longer used...
Change-Id: Id9c959248d6ff21876a5b1f98957925df233bbb3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832191
Auto-Submit: Bartek Nowierski <[email protected]>
Commit-Queue: Takashi Sakamoto <[email protected]>
Reviewed-by: Takashi Sakamoto <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036402}
[blinkpy] 5/N: `update-metadata` reads and parses wptreports
This change adds functionality to `update-metadata` to read and parse
wptreports (either from disk or from a build). Reports from builds are
downloaded in parallel.
Mentions of 'run logs' have been replaced with 'reports'. Supporting
the raw log format will add more complexity than is worthwhile.
Bug: 1299650
Change-Id: Ic879a17770bd841fb54bdb32a623b3d6bcf3d063
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3836957
Reviewed-by: Weizhong Xia <[email protected]>
Commit-Queue: Jonathan Lee <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036401}
Enable dcheck_always_on on chromeos-betty-pi-arc-chrome
After this, we can remove chromeos-betty-pi-arc-chrome-dchecks.
Bug: 1314494
Change-Id: I6bb3d890d4a78623d5d3279abe67056f77316a3b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3835651
Commit-Queue: Sven Zheng <[email protected]>
Reviewed-by: Ben Pastene <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036400}
Dictation icon remains visible during speech file download.
Previously the dictation icon was hidden during speech file
download and a download icon was shown instead within the
progress indicator. This replaces the download icon with
the dictation icon per UX request.
When a user turns on Dictation they don't expect a "download"
icon to appear in the tray. The Dictation icon in the tray
provides information about the background speech file download
without being unexpected.
Screenshot with this change applied:
https://screenshot.googleplex.com/5M9RooLiw4zSv5v.png
Also adds an extra, unrelated test for the dictation icon
changing when toggled.
AX-Relnotes: Dictation shows dictation icon, not download icon, when downloading speech files.
Bug: 1346720
Test: New ash_unittest and manual test
Change-Id: I381baf85da94b25b9957c946441ab483a46f0ba6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832604
Reviewed-by: David Black <[email protected]>
Commit-Queue: Katie Dektar <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036399}
Add experimental improvements to Lens instruction chip.
These improvements are guarded behind a new feature flag.
Screenshots:
https://screenshot.googleplex.com/4dgGYdUPNjArrxw
https://screenshot.googleplex.com/72xfN6VTzAecBCq
https://screenshot.googleplex.com/VocVdebeMbuaRPP
Bug: b:238943340, 1353901
Change-Id: I0e39f731642a9e63d9aa74373bf512c96bba50d3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3829812
Reviewed-by: Thomas Lukaszewicz <[email protected]>
Reviewed-by: Ali Stanfield <[email protected]>
Commit-Queue: Juan Mojica <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036398}
[lacros skew tests] Refresh skew tests for M106
This CL updates the ash version ['106.0.5239.0'] for Lacros version skew testing.
If this CL caused regressions, please revert and stop the autoroller
at https://luci-scheduler.appspot.com/jobs/chrome/lacros-version-skew-roller
Also please file a bug to OS>LaCrOS>Partner, and CC [email protected],
[email protected].
[email protected]
Bug: None
Change-Id: Ia406dc6395d5c16e2ff1b68c1dd2a62ac757c23f
Requires-Testing: True
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834741
Auto-Submit: chrome-weblayer-builder <chrome-weblayer-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036397}
Modify PauseApps & UnpauseApps to support the non mojom interface.
BUG=1253250
Change-Id: I6de9d1d8f290737b801b69482c1ece07bab46dbb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834944
Reviewed-by: Dominick Ng <[email protected]>
Commit-Queue: Nancy Wang <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036396}
Fix the website metrics issue for restored inactivated tab.
When the inactivated tab is restored, ActiveTabWebContentsObserver is
not created, but the tab/webcontent has been loaded. So when switching
from the inactivated tab to activated the tab, after creating
ActiveTabWebContentsObserver, PrimaryPageChanged is not called, and
the activated tab is not recorded in the website metrics.
Modify the code to create ActiveTabWebContentsObserver when the tab is
created, to save the webcontent, so that the activated tab can be
recorded in the website metrics.
BUG=1353732
Change-Id: Id5b1dbdacadcd8d85ca4f6dff5fc63428f737b55
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3836214
Reviewed-by: Dominick Ng <[email protected]>
Commit-Queue: Nancy Wang <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036395}
Switch //content to use ENABLE_PPAPI
Switches //content to use the ENABLE_PPAPI buildflag for PPAPI-specific
code, rather than the more general ENABLE_PLUGINS buildflag.
Also removes RenderFrame's PluginDidStartLoading() and
PluginDidStopLoading() methods, which are dead code.
Bug: 1306610
Change-Id: Iff4508e2673a92e77dae8a3badea885e31cde7e6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832643
Reviewed-by: Nasko Oskov <[email protected]>
Commit-Queue: K. Moon <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036394}
Roll Perfetto Trace Processor Mac from 3960394cdf24 to 8404c1cc9828
https://android.googlesource.com/platform/external/perfetto.git/+log/3960394cdf24..8404c1cc9828
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: [email protected]
Change-Id: I894977153f6fee2a6c6e03fd7e6a36a9aff40e10
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3829248
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036393}
[Fast Pair] Update "No devices" string for Saved Devices subpage
Following UX review, update the string that appears on the Saved Devices subpage when there are no devices saved to the user account. (https://storage.cloud.google.com/chromium-translation-screenshots/d2e98242c4258bac7a1d4d92e80e4c8173b1b160)
TEST: Tested on DUT
FIX: b/241584445
Change-Id: Ie22fdb900cca89c4f8e6fa896d0e3bcae050689a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3831247
Reviewed-by: Daniel Classon <[email protected]>
Reviewed-by: Jon Mann <[email protected]>
Commit-Queue: Brando Socarras <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036392}
glanceables: Add basic layout to main view
* Add container for two-column layout
* Add labels for "Up next" and "Restore last session"
The spacing and font size values are arbitrary, since we don't have a
formal spec yet.
Bug: 1353885
Test: manual
Change-Id: I88bbf68aa71e6dc0964aad6c961d4b2c1370b8a0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3835530
Commit-Queue: James Cook <[email protected]>
Reviewed-by: Matthew Mourgos <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036391}
Revert "Add a method to convert integer socket family to net::AddressFamily"
This reverts commit dcb32506b023ffa2231e2f319ddcdf397891048d.
Reason for revert:
It seems that this CL is causing failure.
https://ci.chromium.org/p/chromium/builders/ci/Cast%20Audio%20Linux/143804
Original change's description:
> Add a method to convert integer socket family to net::AddressFamily
>
> This will be used to support DNS resolution for a specific address
> family.
>
> Bug: webrtc:14319, webrtc:14131
> Change-Id: Ie5704638e9e6d32fd217e0f931ebaf68b0eb1b8e
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832378
> Auto-Submit: Sameer Vijaykar <[email protected]>
> Reviewed-by: David Schinazi <[email protected]>
> Commit-Queue: Sameer Vijaykar <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1036347}
Bug: webrtc:14319, webrtc:14131
Change-Id: Ia17fab58f1c3c84435b5f4dde7134a3e6c24fa6e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3837076
Reviewed-by: Minoru Chikamune <[email protected]>
Auto-Submit: Huanpo Lin <[email protected]>
Commit-Queue: Minoru Chikamune <[email protected]>
Owners-Override: Robert Lin <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036390}
Files app: Move style from main.html to the file_manager.css
This is the only style inlined in the HTML, this is from the time that
Polymer didn't recognize CSS style, so it required the <custom-style>
tag.
as dialog.
Test: Manually changed the background color to red and opened the save
Change-Id: Iff71ad3ee4895fe95196b6af21aa559c76a50404
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3836873
Commit-Queue: Luciano Pacheco <[email protected]>
Reviewed-by: Wenbo Jie <[email protected]>
Auto-Submit: Luciano Pacheco <[email protected]>
Commit-Queue: Wenbo Jie <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036389}
Add the contentful paint metrics for skippable fetch handler.
To measure the improvement by skipping the fetch handler, this CL adds
the metrics to measure the first contentful paint and longest
contentful paint for the skippable fetch handler.
Bug: 1347319
Change-Id: I7865adb42879f3b1b5184dc15cb32efaae33e7b3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3833618
Reviewed-by: Hiroki Nakagawa <[email protected]>
Commit-Queue: Yoshisato Yanagisawa <[email protected]>
Reviewed-by: Takashi Toyoshima <[email protected]>
Reviewed-by: Kouhei Ueno <[email protected]>
Reviewed-by: Sam McNally <[email protected]>
Reviewed-by: Kentaro Hara <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036388}
Fix -Wshadow in services/.
Bug: 1344231
Change-Id: I428f6263dec496763ff53175baede85f3e55c85a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3835058
Reviewed-by: Takashi Toyoshima <[email protected]>
Commit-Queue: Takashi Toyoshima <[email protected]>
Auto-Submit: Peter Kasting <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036387}
Stop using AddressList in MockHostResolverBase::RuleResult
Currently MockHostResolverBase::RuleResult is using both AddressList
and std::vector<HostResolverEndpointResult> for non error result.
We don't need to keep both logic. So this CL stops using AddressList.
Bug: 1344273
Change-Id: I37a56be598dbefe6919c55934af65d7c2382b4db
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3802388
Commit-Queue: Tsuyoshi Horo <[email protected]>
Reviewed-by: Eric Orth <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036386}
[Floss] Refactor WriteDBusParamIntoVariant
Reland of CL:3833334.
This refactors WriteDBusParamIntoVariant to minimize the multiple
similar definitions by creating a general definition that will call the
specific WriteDBusParam inside a variant, so that implementations need
to focus only on WriteDBusParam for each new type.
This adds DBusTypeInfo which will be useful for ExportedCallbackManager
to provide a more meaningful error message when automatically parsing
D-Bus parameters.
Bug: b:233124021
Change-Id: I3e68ee29373f96a34b68e9b846d6323e9c33fa0c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832929
Commit-Queue: Sonny Sasaka <[email protected]>
Reviewed-by: Abhishek Pandit-Subedi <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036385}
Fix nullptr display info provider in Lacros.
This CL fixes DisplayInfoProvider usage in Lacros.
When crosapi is not available and we cannot provide a full API impl,
we return a nullptr.
This fix is done because client code assumed that there is always a
provider instance and does not check for empty ptr.
R=erikchen, jennyz
Bug: 1352277
Change-Id: I1bbc717b2b69ceaa87e3d147ffbfaa5c4a6cedd1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832383
Reviewed-by: Devlin Cronin <[email protected]>
Commit-Queue: Sergii Bykov <[email protected]>
Reviewed-by: Alexander Hendrich <[email protected]>
Reviewed-by: Jenny Zhang <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036384}
float: Stack TabletMultitaskMenu above the window to show it every time.
Test: manual
Bug: 1349918
Change-Id: I1bf3a38e909b1a831963da9e075705b25d23e405
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3835029
Commit-Queue: Sophie Wen <[email protected]>
Reviewed-by: Sammie Quon <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036383}
rgbkbd: add search terms
Add "keyboard backlight" as the main term with other alternatives:
- "keyboard light color"
- "keyboard color"
- "key color"
- "backlight color"
- "backlit color"
BUG=b/240980782
TEST=Manually
Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Change-Id: I3c9bc5e6b42b2ae0c47e5719d46574e7fc941536
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834764
Commit-Queue: Jason Thai <[email protected]>
Reviewed-by: Jeffrey Young <[email protected]>
Reviewed-by: Sam McNally <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036382}
Change MFChecker triggering point from DidFinishLifecycleUpdate
to RunPostLifecycleSteps
Removed unnecessary dependency to LifecycleNotificationObserver from MobileFriendlinessChecker for simplicity.
Change-Id: Icf345206c529a1ca006800d277e1f43cf92ebbe9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3821847
Reviewed-by: Stefan Zager <[email protected]>
Reviewed-by: Xianzhu Wang <[email protected]>
Commit-Queue: Hiroki Kumazaki <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036381}
Roll nearby-connections from 4d2ff863f98d to d92f1d475734 (1 revision)
https://chromium.googlesource.com/external/github.com/google/nearby-connections.git/+log/4d2ff863f98d..d92f1d475734
2022-08-17 [email protected] Internal change.
> PiperOrigin-RevId: 468293287
>
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/nearby-connections-chromium
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:linux-nearby-chrome-fyi
Bug: None
Tbr: [email protected],[email protected],[email protected]
Change-Id: I6946235ac7f130ffd9d0c6c3dbfcad2d4fc961a7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3836263
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1036380}
Automated Commit: LKGM 15050.0.0 for chromeos.
Uploaded by https://ci.chromium.org/b/8805701533619970209
This CL will remain in WIP until both master-full and master-release
builds for this version are finished. This CL should not be submitted
to the CQ until that happens.
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-chrome
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-chrome
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-octopus-chrome
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-reven-chrome
CQ_INCLUDE_TRYBOTS=luci.chrome.try:lacros-amd64-generic-chrome
Change-Id: Ie62492cb75a2197b324e58afccf6af90fea03185
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3833010
Owners-Override: Toby Huang <[email protected]>
Reviewed-by: Yoshiki Iguchi <[email protected]>
Reviewed-by: Toby Huang <[email protected]>
Commit-Queue: Yoshiki Iguchi <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036379}
[Journeys] Announce deletions for a11y
Bug: 1346689
Change-Id: Ie08262275fa6f69d28137344b6be3884782eb501
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3835645
Reviewed-by: Gang Wu <[email protected]>
Commit-Queue: Patrick Noland <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036378}
e14s flags audit: myy->dvallet + flags to M111
Bug: b/242234620
Change-Id: I00fce78a865eaa2209a785608788ee17c9665fea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834684
Auto-Submit: jhtin <[email protected]>
Reviewed-by: David Vallet <[email protected]>
Quick-Run: David Vallet <[email protected]>
Commit-Queue: David Vallet <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036377}
Update V8 to version 10.6.191.
Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/43711c5b..0601466c
Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues
Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_chromeos_msan_rel_ng
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel
[email protected],[email protected],[email protected]
Change-Id: I8c30138a1319e8ea87dee55987319f847fa2d931
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3826195
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1036376}
[Files app] Use MountPoint instead of MountPointInfo
Use the shorter name of this struct.
Use brace initialization when constructing MountPoint values.
Less code for the same thing.
BUG=chromium:1313346
TEST=autoninja -C out/Default unit_tests browser_tests components_unittests ash_components_unittests
Change-Id: I5f80580394666623c9e28a91de25ace264edaa44
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3829002
Commit-Queue: François Degros <[email protected]>
Reviewed-by: Anqing Zhao <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036375}
Don't notify unchanged scrollbar visibility
Bug: 1268142
Change-Id: I72ffbc0248e52dbf6e4dbdad4063de65ae993fe9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832220
Commit-Queue: Xianzhu Wang <[email protected]>
Reviewed-by: Philip Rogers <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036374}
Rename fusebox_util to fusebox_errno
As a file name, "util" generally doesn't give much information.
Bug: 1249370
Change-Id: I60aaf4768ee3fb9e32d8a882ad5b13dd12b43382
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832608
Reviewed-by: Ben Reich <[email protected]>
Auto-Submit: Nigel Tao <[email protected]>
Commit-Queue: Nigel Tao <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036373}
PageLoadMetrics: Prerender2 support for SessionRestorePLMO
SessionRestorePLMO is interested only in performance on session restore,
and prerender doesn't occur in such a case. So this patch just makes it
stop observing on prerendering pages.
Bug: 1317494
Change-Id: Iaddb541cc2938c791ed705b05cc64f22f55bfd00
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832992
Reviewed-by: Ken Okada <[email protected]>
Commit-Queue: Takashi Toyoshima <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036372}
PageLoadMetrics: Prerender2 support for PrefetchProxyPLMO
Prerender doesn't use PrefetchProxy, and the class is interested
only in the primary page metrics. So, this patch just stops
observing explicitly on prerendering page.
Bug: 1317494
Change-Id: I01f7a69241351a166fe8d0b36e740257d5c61c6d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3833769
Reviewed-by: Ken Okada <[email protected]>
Reviewed-by: Kouhei Ueno <[email protected]>
Commit-Queue: Takashi Toyoshima <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036371}
PageLoadMetrics: Prerender2 support for TabRestorePLMO
TabRestorePLMO is interested in performance on tab restoration.
Prerender doesn't occur in such a case. This patch makes the class stop
observing on pre-rendered pages.
Bug: 1317494
Change-Id: I342cc63e80d24faaea6a1fd4ebac07adbc953c3a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3835230
Reviewed-by: Ken Okada <[email protected]>
Reviewed-by: Kouhei Ueno <[email protected]>
Commit-Queue: Takashi Toyoshima <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036370}
Roll Chrome Win64 PGO Profile
Roll Chrome Win64 PGO profile from chrome-win64-main-1660759200-ddd1a6530b4f069323096167b4d20e936340c471.profdata to chrome-win64-main-1660769982-10f954c13e36edc95e4577507982ecddf2ec4388.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win64-chrome
Tbr: [email protected]
Change-Id: I5ea90b07599bfd04a98e891a5967eeb43e59f5ec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3836843
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036369}
WebUI: Migrate cr-checkbox to TypeScript
Bug: 1316438
Change-Id: Iaf5e2ab6be4a93edb1a1801971a9b5419eedcc05
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834772
Reviewed-by: John Lee <[email protected]>
Commit-Queue: Rebekah Potter <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036368}
[AF] Extend flag-metadata.json entry for Better Auth project
Will follow up with a tech debt bug on moving this from a flag to
a helper method so we can avoid the expiry emails in the future.
Change-Id: Ic78ea105e7bb2ae955e07f68bfaa490044b3217f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834610
Commit-Queue: Jared Saul <[email protected]>
Auto-Submit: Jared Saul <[email protected]>
Reviewed-by: Vinny Persky <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036367}
GameModeController: test fullscreen losing focus
Add a unit test which verifies that a fullscreen Borealis window losing
focus results in game mode being turned off.
This tests against a bug I almost introduced in
https://crrev.com/c/3823021, which broke some properties of the state
hierarchy. That CL will likely be abandoned, but this test is still
meaningful.
Bug: b:228405479
Test: GameModeControllerTest
Change-Id: Id5b101d34a7f4717d226ddab9354fbe305f96f61
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3833617
Reviewed-by: Nic Hollingum <[email protected]>
Auto-Submit: Matthew DeVore <[email protected]>
Commit-Queue: Nic Hollingum <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036366}
PageLoadMetrics: ForegroundDurationUKMObserver for Prerender2
Ensure the timer starts after the prerendered page is displayed.
Bug: 1317494
Change-Id: I1c147b921704d6559d8b230798abbe957d9fd1b6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3766998
Auto-Submit: Johann Koenig <[email protected]>
Commit-Queue: Takashi Toyoshima <[email protected]>
Reviewed-by: Takashi Toyoshima <[email protected]>
Reviewed-by: Kouhei Ueno <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036365}
Add a MultipleFetchHandlersInServiceWorker event use counter.
To count the number of sites that use multiple fetch handlers,
let me also use the use counter.
Bug: 1347319
Change-Id: I9fbb161d39a3406236bddafe3f058e20a5d58a3b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3835425
Reviewed-by: Kouhei Ueno <[email protected]>
Commit-Queue: Yoshisato Yanagisawa <[email protected]>
Reviewed-by: Hiroki Nakagawa <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036364}
CustomizeChrome: Customize Chrome Triggering on NTP Page
This CL registers the Customize Chrome entry when on the NTP so it appears as an option in the combobox. It also allows you to open the side panel from the customize chrome button on the NTP page. When the customize chrome entry on the side panel is open the customize chrome button will not be shown and vice versa.
OWNERS file also added, owners are the same as the rest of the customize chrome directories (the NTP owners).
Bug: 1350241
Change-Id: I599893ec3c49b33cf71419f6ccb52f876043350f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3812725
Reviewed-by: Thomas Lukaszewicz <[email protected]>
Commit-Queue: Nihar Majmudar <[email protected]>
Reviewed-by: Avi Drissman <[email protected]>
Reviewed-by: Joe Mason <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036363}
Support auto-never-translate-language in the Translate Message UI.
This CL adds support for auto-never-translate-language to the Clank
Messages implementation of the Translate UI, modelled after the infobar
UI's support of auto-never-translate-language.
Bug: 1311774
Change-Id: Iaee980a00f87531421d702b6f7558e54ae9ba7d5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3836954
Reviewed-by: Trevor Perrier <[email protected]>
Auto-Submit: Scott Little <[email protected]>
Commit-Queue: Scott Little <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036362}
Suppress Pixel_WebGLContextRestored on ChromeOS Kevin.
Timing out on this ARM-based Chromebook as well. Point ChromeOS
expectations to this newly filed bug.
Bug: 1353952
Change-Id: I158d614420fbc43e1a092c79bdd419302f4c92ac
No-Try: True
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3836679
Bot-Commit: Rubber Stamper <[email protected]>
Commit-Queue: Kenneth Russell <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036361}
Reland "[CCTBrand] Add fieldtrial testing config"
This reverts commit 3b724a19db0f667705b97af7ffec7d73b1bd8f4f.
Reason for revert: Fix included in crrev.com/c/3828894
Original change's description:
> Revert "[CCTBrand] Add fieldtrial testing config"
>
> This reverts commit 18cfca4c9236cfa25fc363378ff703c1d52aeae1.
>
> Reason for revert: Potential culprit of crbug.com/1350199.
>
> Original change's description:
> > [CCTBrand] Add fieldtrial testing config
> >
> > Bug: 1341138
> > Change-Id: I751b367e5c0949aa1fcc69ed808436345e8acedb
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3795799
> > Reviewed-by: Jinsuk Kim <[email protected]>
> > Commit-Queue: Wenyu Fu <[email protected]>
> > Cr-Commit-Position: refs/heads/main@{#1031187}
>
> Bug: 1341138
> Change-Id: I2fb239a75954ed5a6e11989b004ceb09eb57b3d1
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3810680
> Owners-Override: Yue Zhang <[email protected]>
> Commit-Queue: Yue Zhang <[email protected]>
> Reviewed-by: Yue Zhang <[email protected]>
> Bot-Commit: Rubber Stamper <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1031552}
Bug: 1341138
Change-Id: I5652be2f657ac1cb8d1a99cfd7554bdafeee8f08
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3813573
Bot-Commit: Rubber Stamper <[email protected]>
Commit-Queue: Wenyu Fu <[email protected]>
Reviewed-by: Jinsuk Kim <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036360}
[CrOS Cellular] Adding label to the SIM lock dialog title
SIM lock dialog title was being skipped by the screen reader. Added
a label to prevent that.
Test: Manual testing using chrome vox
Recording: https://drive.google.com/file/d/1R3PreyoEzsyOu9MyP70tfd-jdDii0z7j/view?usp=sharing
Fixed: b/241551127
Change-Id: I30df17e17c137e503389dd36304fba8053c21184
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3826423
Reviewed-by: Regan Hsu <[email protected]>
Commit-Queue: Nikhil Nayunigari <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036359}
[Extensions] Don't try to close the extension popup before it opens
The process of opening an extension popup can be asynchronous if the
extension is overflowed in the menu. It's possible for the extension to
be unloading during this time, in which case we'll attempt to close the
popup if one exists. However, closing a popup that hasn't been shown is
unsupported.
Fix this by checking whether the popup has been opened before trying to
close it, and add a regression test for the same.
Bug: 1345477
Change-Id: Iccbc54cb2560b3c089ab41ece6c95f3ae8fe9f54
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832965
Reviewed-by: Emilia Paz <[email protected]>
Commit-Queue: Devlin Cronin <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036358}
Change some VideoStreamFromWebGLCanvas' expectations to Failure.
Bug: 1353189
Bug: 1353813
Change-Id: I1c464c5eb226056ac5f2acc63bbab03cc5cbb994
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834504
Commit-Queue: Quyen Le <[email protected]>
Reviewed-by: Brian Sheedy <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036357}
Roll earl_grey2 from f96a5e77ca13 to d8ddfdbb1e4d (1 revision)
https://chromium.googlesource.com/external/github.com/google/EarlGrey.git/+log/f96a5e77ca13..d8ddfdbb1e4d
2022-08-17 [email protected] Remove GREYConstants from interposer lib.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/earlgrey2-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs
Bug: None
Tbr: [email protected],[email protected]
Change-Id: I98ded67a77b0a88c635c73dc869997eb7bb095ec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3836368
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036356}
Lock screen when lid closes
Lock screen when lid closes if user/policy settings are configured to.
Uses the same IsProjecting() logic as powerd to ignore lid close if
device is projecting (docked). In such a case, the device will be
locked immediately if the external device is removed, and the lid is
still closed.
Bug: 902589
Change-Id: I45d08f538b4f580c9120ed7262b673c6a6b84b0d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3826842
Commit-Queue: Joel Hockey <[email protected]>
Reviewed-by: Xiyuan Xia <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036355}
[Eche] Recent apps should show below Recent photos.
This is a UX requirement: shows Recent Apps below Recent photos. Create
PhoneHubRecentAppsView after CameraRollView.
Bug: b/242600152
Test: Manual test and pass the UI as:
https: //screenshot.googleplex.com/7LCvgo7kbsVWn56.png
Change-Id: I1773ae8561e91dc536fa0e5cd2b498c0848d2ff8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3833627
Commit-Queue: Paulz Chen <[email protected]>
Reviewed-by: Jon Mann <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036354}
[Dictation] Fix infinite toggle dictation bug.
When Dictation and another Chrome OS feature backed by
Accessibility Common were both active, and Dictation was turned
on and off again in settings, Dictation would begin to toggle
infinitely when the user tried to use it. This fixes the
bug by properly destroying Dictation and removing listeners
before it is turned off.
Bug: 1353129
AX-Relnotes: Fixes bug with some other a11y features and Dictation together.
Test: Manual
Change-Id: I5869f515f7049761391c161e513e8431f5b85115
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3836856
Commit-Queue: Katie Dektar <[email protected]>
Reviewed-by: Akihiro Ota <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036353}
Change API used to show the Tailored Security Desktop Dialog
This change switches from using `ShowWebModal` to `ShowBrowserModal`
when displaying the Tailored Security notice dialog. This ensures that
more users will see the notice when the enhanced protection state is
changed.
Bug: 1353828
Change-Id: I8c1e3d5ffe23c6b2d33cfb129242e3b8558c900c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3835030
Reviewed-by: Daniel Rubery <[email protected]>
Commit-Queue: Javier Castro <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036352}
Remove launcher lacros feature flag
This feature flag should be cleaned, since the development is completed.
Bug: 1352862
Change-Id: I3f78ea28814b8dbc507026dbb026e9f3f5527a9a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834946
Commit-Queue: CJ Huang <[email protected]>
Reviewed-by: James Cook <[email protected]>
Reviewed-by: Rachel Wong <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036351}
Refactor sync_wifi to use PrefService::GetValueDict
This is part of a larger migration effort based on
go/trust-your-prefs.
Bug: 1341996
Test: Existing unit tests
Change-Id: Icc8cbdb0ee12a0830f60136694c7a801791dde7e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3829525
Commit-Queue: Roland Bock <[email protected]>
Reviewed-by: Jon Mann <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036350}
Add a couple feed experiments
Bug: none
Change-Id: I0203a67ceeda5626517d2e56176e3abdc7003b23
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3836619
Reviewed-by: Ian Wells <[email protected]>
Commit-Queue: Jian Li <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036349}
[Settings] Alphabetize language lists in the Translate Card
This CL will display the two language lists, Always translate and Never
translate, in alphabetical order.
Bug: 1352680
Change-Id: I2e232448dec7010bcd042b362607864536838e77
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3826134
Reviewed-by: Rebekah Potter <[email protected]>
Reviewed-by: Trevor Perrier <[email protected]>
Commit-Queue: Andrea Gomez <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036348}
Add a method to convert integer socket family to net::AddressFamily
This will be used to support DNS resolution for a specific address
family.
Bug: webrtc:14319, webrtc:14131
Change-Id: Ie5704638e9e6d32fd217e0f931ebaf68b0eb1b8e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832378
Auto-Submit: Sameer Vijaykar <[email protected]>
Reviewed-by: David Schinazi <[email protected]>
Commit-Queue: Sameer Vijaykar <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036347}
[WebContentsImpl] Don't call documentLoadedInFrame in child frames
Part of reducing navigation cost to reduce scroll jank. Java observers
don't do anything when documentLoadedInFrame is called in child frames,
so we don't have to notify java in this case. Though this is more of an
API cleanup rather than focusing on reducing jank.
Bug: 1353846
Change-Id: Ia5270c754648576d91f5236239414ea80cc3bb72
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3835270
Commit-Queue: Peilin Wang <[email protected]>
Reviewed-by: Yaron Friedman <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036346}
Revert "Aw: Demo the simplified dark mode"
This reverts commit 7ca2da167eb6f75f0331e8f41da316d49bd2e19d.
Reason for revert: crashes on old WebView versions (crbug.com/1353923)
Original change's description:
> Aw: Demo the simplified dark mode
>
> This patch also disables the force dark mode menu items, if
> the targetSdk<T.
>
> Bug: 1345249
> Change-Id: Id775e2578dd41bc09f248397123264edd9a991ee
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3782006
> Reviewed-by: Richard Coles <[email protected]>
> Commit-Queue: Michael Bai <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1029949}
Bug: 1345249
Bug: 1353923
Change-Id: I11cf526b904d3bccced4479382aa5bf141109ff8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3835452
Reviewed-by: Michael Bai <[email protected]>
Auto-Submit: Nate Fischer <[email protected]>
Commit-Queue: Michael Bai <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036345}
[fuchsia] A typo in the exception handling in update_images.py
images_targball_url -> images_tarball_url
Change-Id: Ieb0c6240dc7d3a50a50fc0fd402ce09cf1121b31
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3836800
Reviewed-by: Fabrice de Gans <[email protected]>
Commit-Queue: Zijie He <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036344}
Allow emphasized text in contexts on Ash
Temporary fix until we figure out more fine-grained Ash style
restrictions.
Bug: 1353654, 1352340, 1352342
Change-Id: Ibad60a886b3559b21bec19b4a40078e57c3b4bc8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834737
Auto-Submit: Austin Sullivan <[email protected]>
Commit-Queue: Austin Sullivan <[email protected]>
Reviewed-by: Peter Boström <[email protected]>
Commit-Queue: Peter Boström <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036343}
[HSTS] Update bulk entries
See https://github.com/chromium/hstspreload.org/wiki/Preload-List-Processes#updating-bulk-hsts-entries
Change-Id: Ida36fde8d82b8cd6a59a08bef4cad132bf47b824
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3836698
Commit-Queue: Joe DeBlasio <[email protected]>
Commit-Queue: Carlos IL <[email protected]>
Reviewed-by: Carlos IL <[email protected]>
Auto-Submit: Joe DeBlasio <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036342}
[UrlParamFilter] Refactor CrossOTR* Observers to share code.
This CL splits out the shared logic under components/url_param_filter in ios/cross_otr_tab_helper and content/cross_otr_observer into a shared
base class at core/cross_otr_observer.
This also requires renaming content/cross_otr_observer to content/cross_otr_web_contents_observer and all references to it.
Bug: 1342757
Change-Id: I0e379ee4af74c250903eb476fc4f57a613070fb6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3810590
Reviewed-by: Peter Kasting <[email protected]>
Reviewed-by: Matt Reichhoff <[email protected]>
Reviewed-by: Ben Kelly <[email protected]>
Commit-Queue: Kirubel Aklilu <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036341}
Enable module lookup on Android ARM64 without checking for XOM
According to Egor Pasko in http://shortn/_hI8ARRGcEp, the ELF headers
read by ReadElfBuildId and friends should never have been marked
execute-only. Only the .text segments containing code would be. His
hypothesis is that the ARM64 crashes in https://crbug.com/957801 were
actually due to an error in calculating the module offsets that was
fixed in https://crrev.com/719803. This bug would cause
ReadElfBuildId to read outside the header and occasionally land in
XOM.
This means all the functions that read ELF headers in ModuleCache
should be safe even on the few Android versions with XOM enabled.
R=wittman
Bug: 3759153
Change-Id: I922c626bb1ee9e885bf9130e87609b756711a836
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3763052
Commit-Queue: Joe Mason <[email protected]>
Reviewed-by: Mike Wittman <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036340}
libassistant-dlc: Extract libassistant loader
There are a few changes in this cl:
1. A feature flag is added to load from DLC.
2. A class is extracted to load libassistant for different situations.
3. We decided not to retry when loading libassistant DLC failed because
most of the cases are not recoverable. We will evaluate this again
after have more metrics.
Bug: b/239492993
Test: Add new tests
Change-Id: Icf3e976fd997d2b9a06753ac11a124dd9621b1f1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3820030
Reviewed-by: Xiaohui Chen <[email protected]>
Commit-Queue: Tao Wu <[email protected]>
Reviewed-by: Sam McNally <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036339}
Saved Desks: Fix crash when exiting overview before replace
Temporarily fixes a crash wherein the user is able to exit
the overview before addressing the replace dialogue.
TESTED: Manually tested and added unit test coverage.
Bug: 1351521
Change-Id: I6152cad491f20302e74ec61a031c35fd7148fa6f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3823417
Commit-Queue: Avynn Donaghe <[email protected]>
Reviewed-by: Richard Chui <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036338}
Implement empty CSSToggleMap and CSSToggle interfaces on existing objects.
This corrects a mistake where I was expecting to implement the spec's
interfaces using objects that were distinct from the implementation.
However, the spec's interfaces are close enough to the implementation
objects that they should be on the same objects.
Thus this CL creates the spec's interfaces as *empty* interfaces and
renames the existing objects (Toggle to CSSToggle, ToggleData to
CSSToggleMap) to implement them.
Later CLs will put the contents of the interfaces in and implement them
on these objects.
(Support for toggles is behind the CSSToggles flag, which is currently
off.)
Bug: 1250716
Change-Id: I36ce7a0687585c5b47ce8e03afdae8da1e7a754e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3828194
Reviewed-by: Joey Arhar <[email protected]>
Commit-Queue: David Baron <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036337}
WebUI: Check in Polymer 3 cr_radio_button/*
- Check in Polymer 3 JS files for cr_radio_button, cr_card_radio_button,
and cr_radio_button_behavior
- Update cr_radio_button_style to be a CSS file, and add to css_files
so that a (Polymer 3) .ts file will be autogenerated at build time.
Bug: 1184053
Change-Id: I322ae61757297a3b7bb46469ff071a215c668fed
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3829773
Commit-Queue: Rebekah Potter <[email protected]>
Reviewed-by: John Lee <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036336}
[ios] Disable NTPHomeTestCase.testMinimumHeight
Test is flaking on official and waterfall builds.
Bug: 1353899
Change-Id: Ie5d02f46555ea9b18856cac1403a0a1f8ae8b228
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3827820
Reviewed-by: Sebastien Seguin-Gagnon <[email protected]>
Commit-Queue: Sebastien Seguin-Gagnon <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036335}
[FilesTrash] Disallow traversing folders in Trash
Files are already not allowed to be opened from Trash, however, for the
MVP this extends to folders as well. Any request at navigating a folder
should not delegate to the Entry but should block prior to that and show
the alert dialog.
Bug: b:233561563
Test: browser_tests --gtest_filter=*trash*
Change-Id: Iae7ce807932d595ae8ca6bffb3add399f4bb1ca7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834687
Reviewed-by: Luciano Pacheco <[email protected]>
Commit-Queue: Ben Reich <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036334}
Revert "Refactor Suggestion::Payload to use StrongAlias for BackendId instead of a std::string"
This reverts commit a47fddbf85515335662a28b9a4268ffd181aeefd.
Reason for revert: breaks debug Mac build: https://ci.chromium.org/ui/p/chromium/builders/ci/GPU%20FYI%20Mac%20Builder%20(dbg)/171791/blamelist
Original change's description:
> Refactor Suggestion::Payload to use StrongAlias for BackendId instead of a std::string
>
> This CL refactors the payload of a suggestion to use a StrongAlias for BackendId instead of an std::string, so that it is more descriptive.
>
> This change should be a no-op.
>
> Fixed: 1349133
> Change-Id: I8bbc84fa2f2a82d705088f0ffc0077782e83c026
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3715236
> Reviewed-by: Christoph Schwering <[email protected]>
> Commit-Queue: Vinny Persky <[email protected]>
> Reviewed-by: Siyu An <[email protected]>
> Reviewed-by: Mohamed Amir Yosef <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1036318}
Change-Id: I4183ad4d4d1162ffbc67ad35cd9335f5a65993fa
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834386
Bot-Commit: Rubber Stamper <[email protected]>
Auto-Submit: Kenneth Russell <[email protected]>
Commit-Queue: Elly Fong-Jones <[email protected]>
Owners-Override: Elly Fong-Jones <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036333}
Revert "[IBAN Filling] Introduce IBAN Manager class which handles IBAN related functionality"
This reverts commit bb575920eca2cfeb09026b415aabaa5538b0f648.
Reason for revert: broke iOS compile: https://ci.chromium.org/ui/p/chromium/builders/ci/ios-device/255614
Original change's description:
> [IBAN Filling] Introduce IBAN Manager class which handles IBAN related functionality
> including retrieving IBAN data, managing IBAN suggestions, filling IBAN field.
>
> Implementation: https://docs.google.com/document/d/1JlAfURVa3ALm-U5HC4p41fx8PFF-mtRSgN2czfVcb-w/edit?resourcekey=0-t-Xsicco20apeY2EFZGGMw#heading=h.e5uc3qpefa5q
>
> Next step:
> Create IBANManagerFactory which creates IBANManager instance, get IBANMnager instance in the client (chrome/browser/ui/autofill/chrome_autofill_client.cc), and creates SingleFieldFillerRounter(https://source.chromium.org/chromium/chromium/src/+/main:components/autofill/core/browser/autofill_client.cc;drc=36c59c53be1d8852f5087008c45a95797bac9730;l=49) with the IBANManager.
>
> Bug: 1344590
> Change-Id: I36bed55de6d518db5d92f412b7a16e54c76f52a6
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3794042
> Reviewed-by: Jared Saul <[email protected]>
> Commit-Queue: Qihui Zhao <[email protected]>
> Reviewed-by: Christoph Schwering <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1036327}
Bug: 1344590
Change-Id: I60d0bb01cd99061778f1db892ae61b9d0a5f9bd4
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3835152
Bot-Commit: Rubber Stamper <[email protected]>
Commit-Queue: Elly Fong-Jones <[email protected]>
Auto-Submit: Elly Fong-Jones <[email protected]>
Owners-Override: Elly Fong-Jones <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036332}
[omnibox] Add Omnibox.KeywordModeUsageByEngineType UMA histogram.
This CL adds a new histogram that records whenever a user enters
keyword mode and/or completes a keyword search, enumerated by what
type of search engine they used (i.e.whether the search engine was
a prepopulated engine, starter pack engine, or not built-in).
Bug: 1287313
Change-Id: I9b1ebab0c9e8bafb19d6b8503ca48279f3bb8b02
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832963
Commit-Queue: Angela Yoeurng <[email protected]>
Reviewed-by: Tomasz Wiszkowski <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036331}
Quota: Enterprise policy for window.webkitStorageInfo
This change adds an enterprise policy to re-enable
deprecated quota API window.webkitStorageInfo for M106-107.
I2R: https://groups.google.com/u/1/a/chromium.org/g/blink-dev/c/HPuDXPKwW_s
Launch: https://crbug.com/1350316
Bug: 695586
Change-Id: I5a1132518a8cedabe9c579670468d021ba381d53
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3821482
Commit-Queue: Ayu Ishii <[email protected]>
Reviewed-by: Owen Min <[email protected]>
Reviewed-by: Kent Tamura <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036330}
sheriff: disable slow iframe unload test under asan/tsan
It's regularly timing out.
Bug: 1096612
Change-Id: I931e6b4d25a602603f001931360ed56ca7a85d7e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832533
Commit-Queue: Elly Fong-Jones <[email protected]>
Owners-Override: Elly Fong-Jones <[email protected]>
Commit-Queue: Peter Boström <[email protected]>
Reviewed-by: Peter Boström <[email protected]>
Auto-Submit: Elly Fong-Jones <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036329}
Support early-breaks inside table captions.
We already had support for passing early-breaks into table sections, but
were omitting them for table captions. This caused an infinite
recursion, because we'd re-layout the table with an early-break set, but
ended up ignoring it, and we'd get to the same point in the code where
we decided to relayout with an early-break in the first place.
Bug: 1353558
Change-Id: Ica8d97d65872a2002ad56c3774fae293a2b1df28
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834454
Reviewed-by: Ian Kilpatrick <[email protected]>
Reviewed-by: Alison Maher <[email protected]>
Commit-Queue: Morten Stenshorne <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036328}
[IBAN Filling] Introduce IBAN Manager class which handles IBAN related functionality
including retrieving IBAN data, managing IBAN suggestions, filling IBAN field.
Implementation: https://docs.google.com/document/d/1JlAfURVa3ALm-U5HC4p41fx8PFF-mtRSgN2czfVcb-w/edit?resourcekey=0-t-Xsicco20apeY2EFZGGMw#heading=h.e5uc3qpefa5q
Next step:
Create IBANManagerFactory which creates IBANManager instance, get IBANMnager instance in the client (chrome/browser/ui/autofill/chrome_autofill_client.cc), and creates SingleFieldFillerRounter(https://source.chromium.org/chromium/chromium/src/+/main:components/autofill/core/browser/autofill_client.cc;drc=36c59c53be1d8852f5087008c45a95797bac9730;l=49) with the IBANManager.
Bug: 1344590
Change-Id: I36bed55de6d518db5d92f412b7a16e54c76f52a6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3794042
Reviewed-by: Jared Saul <[email protected]>
Commit-Queue: Qihui Zhao <[email protected]>
Reviewed-by: Christoph Schwering <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036327}
[omnibox] Add unit test case showing .html is not a URL signal
This CL adds an explicit test case including host/page.html so that
it's more clear that such inputs are still considered UNKNOWN even
though some other inputs with URL characters signal URL input type.
Bug: 1353474
Change-Id: I47d928975cdbe3e6e171845744182c4cdc95d2e0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834785
Reviewed-by: Angela Yoeurng <[email protected]>
Commit-Queue: Orin Jaworski <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036326}
Set use_combined_annotations to false if use_crash_key_stubs is false
This is to avoid depending on crash handling code if the client
explicitly requests to stub crash handling code.
Change-Id: I2c219aa37006c87b7ff511499cdc78312149b327
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3836615
Reviewed-by: Lei Zhang <[email protected]>
Commit-Queue: John Wu <[email protected]>
Reviewed-by: Joshua Peraza <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036325}
Lacros: Allow for zaura shell to set initial z order
This CL adds a way for the wayland zaura shell to set the z order of a
window. We do this by adding a set_z_order function to aura-shell.xml.
This allows for the shell to generate PiP windows with the
ui::ZOrderLevel::kFloatingWindow property just as it does in ash-chrome.
We also add a z_order_level enum to aura-shell.xml that parallels the
ui::ZOrderLevel enum in ui_base_types.h.
Bug: 1346751
Change-Id: I8c0cfcd0ae1f468cfd5fe829b69ffde6ac2dc608
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3788907
Reviewed-by: Avi Drissman <[email protected]>
Reviewed-by: Thomas Anderson <[email protected]>
Reviewed-by: Ahmed Fakhry <[email protected]>
Reviewed-by: Maksim Sisov <[email protected]>
Commit-Queue: Ben Becker <[email protected]>
Reviewed-by: Mitsuru Oshima <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036324}
[omnibox][memories] Fieldtrial testing config for cluster suggestions.
Bug: 1327076
Change-Id: I82696c3726e7d0a47f9afba53bb658168af7b453
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3833533
Reviewed-by: Tommy Li <[email protected]>
Commit-Queue: manuk hovanesian <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036323}
sheriff: disable SelfUninstallNoPermissions extension test
It's flaky on Mac.
Bug: 1132581
Change-Id: I1a2e9524faf6d5f8af3817fe7a74acb657a043ef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3836955
Owners-Override: Elly Fong-Jones <[email protected]>
Reviewed-by: Peter Boström <[email protected]>
Commit-Queue: Elly Fong-Jones <[email protected]>
Commit-Queue: Peter Boström <[email protected]>
Auto-Submit: Elly Fong-Jones <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036322}
Incorporate ccTLD aliases into enterprise sets.
Bug: 1349781
Change-Id: I3815e92f95ed8e343514a89fa237e2e6dc6b8934
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834193
Reviewed-by: Kirubel Aklilu <[email protected]>
Commit-Queue: Chris Fredrickson <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036321}
[Extensions] Require a dedicated process for the new Webstore domain
This CL adds the new Webstore URL to the list of origins which require
dedicated process isolation, even across subdomains. Also adds to tests
to ensure this is the case.
Bug: 1338235
Change-Id: I373a065c92a6b73df50fe19ed6e3faa4a4971d0e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3818304
Reviewed-by: Devlin Cronin <[email protected]>
Reviewed-by: Alex Moshchuk <[email protected]>
Commit-Queue: Tim <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036320}
Roll Chrome Mac PGO Profile
Roll Chrome Mac PGO profile from chrome-mac-main-1660737332-4cb1bea6efe2496fe83bb003b1253f145bacc0f3.profdata to chrome-mac-main-1660759200-53c3b4e47331d0bee6d3137f2c7622e479d87e66.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:mac-chrome
Tbr: [email protected]
Change-Id: Ida28082cd32141ddb0ba24837031033b51703534
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3836897
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036319}
Refactor Suggestion::Payload to use StrongAlias for BackendId instead of a std::string
This CL refactors the payload of a suggestion to use a StrongAlias for BackendId instead of an std::string, so that it is more descriptive.
This change should be a no-op.
Fixed: 1349133
Change-Id: I8bbc84fa2f2a82d705088f0ffc0077782e83c026
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3715236
Reviewed-by: Christoph Schwering <[email protected]>
Commit-Queue: Vinny Persky <[email protected]>
Reviewed-by: Siyu An <[email protected]>
Reviewed-by: Mohamed Amir Yosef <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036318}
Roll nearby-connections from b57d03425f3f to 4d2ff863f98d (1 revision)
https://chromium.googlesource.com/external/github.com/google/nearby-connections.git/+log/b57d03425f3f..4d2ff863f98d
2022-08-17 [email protected] Add platform agnostic implementation of Credential_Storage class.
> PiperOrigin-RevId: 468251604
>
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/nearby-connections-chromium
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:linux-nearby-chrome-fyi
Bug: None
Tbr: [email protected],[email protected],[email protected]
Change-Id: If4a94979bf482f508bac1f84440029d1ac161f18
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3836342
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1036317}
ash: Fix channel indicator for side-shelf
ChannelIndicatorView's border is now set according to shelf alignment.
Enable sections of ChannelIndicatorView unit test that verify the
correct image_view() size in both bottom-shelf and side-shelf.
Bug: 1351496
Change-Id: I02b41f2bf44498e6f4e54250566ffa6dbeead6f0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3826800
Commit-Queue: Roger Tinkoff <[email protected]>
Reviewed-by: Alex Newcomer <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036316}
[Frameworks roll] Roll to 468258023 piper revision
Change-Id: I343aac83973e2e3179f28e1b7f7b4a81ef0cef16
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3836857
Bot-Commit: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1036315}
Roll Chrome Win64 PGO Profile
Roll Chrome Win64 PGO profile from chrome-win64-main-1660737332-c1b32cf9ce20774d9bc94b435a8489360520618f.profdata to chrome-win64-main-1660759200-ddd1a6530b4f069323096167b4d20e936340c471.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win64-chrome
Tbr: [email protected]
Change-Id: I1decbccb33cd1511fc9a28f6f7c206b5f8f83002
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3836840
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036314}
Clean up unused AuthenticatorNavigationInterceptor code
The downstream code has already been deleted, all
AuthenticatorNavigationInterceptor calls are noops.
Change-Id: Idf89138e95ba246a1bac7c8bed2e9c41faa92d41
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3830084
Reviewed-by: Bo Liu <[email protected]>
Commit-Queue: Michael Thiessen <[email protected]>
Reviewed-by: Ted Choc <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036313}
Aggregate tasks to be performed after the user updates the desktop site content setting
Previously, the only entry points for the user to update the desktop site global setting was through the Chrome settings page or the overflow menu. With the introduction of the opt-in message on 10"+ tablets, the content setting could also be updated if the user accepted the message. Going forward, there may be other means for the user to take a decision on updating the desktop site content setting.
This CL aggregates the tasks to be performed when the user explicitly requests for an update to the content setting, currently including:
1. Recording the histogram Android.RequestDesktopSite.Changed
2. Updating the SharedPreference USER_ENABLED_DESKTOP_SITE_GLOBAL_SETTING_PREFERENCE_KEY
Bug: 1351819
Change-Id: I2a0afdc151df767ab47273c5058b47fda180ce6a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3833507
Reviewed-by: Shu Yang <[email protected]>
Commit-Queue: Aishwarya Rajesh <[email protected]>
Reviewed-by: Theresa Sullivan <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036312}
[Cast Streaming][Web Codecs] Add DelegatingDecoderBufferProvider
This CL adds a new implementation of DecoderBufferProvider intended
to provide thread-safe access around a DecoderBufferProviderImpl which
is tied to a specific thread and task runner.
Change-Id: I3f656a22bf5ee6d279800c9c00111ddf95cfcf78
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3835529
Commit-Queue: Ryan Keane <[email protected]>
Reviewed-by: Jordan Bayles <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036311}
Create a tool to auto-update IDL files.
1. Update IDL files for all 6 flavors (CPU_ARCH x IS_CHROME_BRANDED).
2. Build a smaller GN target
(`chrome/updater/app/server/win:updater_idl_idl_idl_action` vs
`chrome/updater:all`)
Bug: 1353883
Change-Id: I7cc55655edfb74f644d32b44d25c6bbf7217fdc6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3835274
Commit-Queue: Xiaoling Bao <[email protected]>
Reviewed-by: S Ganesh <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036310}
Remove webstorePrivate.requestExtension API
Extension request has been launched for a year but this API is never
used by Chrome web store and there is no plan to use it in the future.
Hence remove the API as unused code.
Bug: NONE
Change-Id: Iabcc722d1a6c63c8159afaafb0404da49ab2c252
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3828608
Commit-Queue: Owen Min <[email protected]>
Reviewed-by: Devlin Cronin <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036309}
Disable launcher continue section by default
To be merged to M-105 to reduce potential backend load (QPS) while
discussions with the Drive intelligence team are ongoing.
Bug: 1353784
Test: manual on eve, Continue Section no longer appears
Change-Id: Icdc1da58a9ebef8936ffa319c79e3b66ceefa139
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834776
Auto-Submit: James Cook <[email protected]>
Commit-Queue: Rachel Wong <[email protected]>
Reviewed-by: Rachel Wong <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036308}
[chrome.mdns] Update OWNERS.
Add two current OWNERS for chrome.mdns to help with code reviews for
upcoming feature work. Eventually ownership will transition to
ChromeOS as they have partners who use this API.
vitalybuka@ has left Chromium.
Change-Id: I143e99c19984ea7c698ea99fffc7f59427f4e2bb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3836277
Commit-Queue: Mark Foltz <[email protected]>
Reviewed-by: Takumi Fujimoto <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036307}
Roll Dawn from 5ef011f2c3fc to a48f233ca58b (12 revisions)
https://dawn.googlesource.com/dawn.git/+log/5ef011f2c3fc..a48f233ca58b
2022-08-17 [email protected] Roll ANGLE from 213a1ee6e6db to 92e4cd75785d (1 revision)
2022-08-17 [email protected] tint/transform: Fix index 0 accessing in DecomposeMemoryAccess
2022-08-17 [email protected] tint/utils/UniqueVector: Use utils::Vector and utils::Hashset
2022-08-17 [email protected] tint: Implement const eval of binary minus
2022-08-17 [email protected] Add optionally_typed_ident to WGSL parser.
2022-08-17 [email protected] tint/transform: Fix PromoteInitializersToLetTest for materialized constants
2022-08-17 [email protected] Convert assignment_statement to new WGSL grammar.
2022-08-17 [email protected] Add core_lhs_expression and lhs_expression to parser.
2022-08-17 [email protected] tint/utils: Add Hashmap and Hashset
2022-08-17 [email protected] tint/utils/vector: Allow use of incomplete types
2022-08-17 [email protected] Sync some WGSL grammar names to spec
2022-08-17 [email protected] tint: Add CheckedSub functions
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dawn-chromium-autoroll
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel
Bug: None
Tbr: [email protected]
Change-Id: Ic5c78f5c8d029ee23e2bbfe9591f45e997e1ee6a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3836913
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036306}
arc/gio: Rename to improve semantics
- Rename locations_ to original_positions_ to prepare for action
reposition.
- Rename window_bounds to content_bounds.
- Make |Position| and |DependentPosition| copyable. This is useful
when an action needs to restore positions to defaults after position
mutations have been made.
Bug: b:241841669
Test: build & unit_tests PositionTest, DependentPositionTest
Change-Id: I44291eba283df14f51b0b12e8d40fb3d98556fd7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834486
Reviewed-by: David Jacobo <[email protected]>
Auto-Submit: Cici Ruan <[email protected]>
Commit-Queue: Cici Ruan <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036305}
[Policy templates] Add 'items' to various bool policies.
Add 'items' fields to the following policies:
- ReportArcStatusEnabled
- ReportCrostiniUsageEnabled
- HeartbeatEnabled
- LogUploadEnabled
- DeviceAllowNewUsers
- DeviceGuestModeEnabled
- DeviceShowUserNamesOnSignin
- DeviceDataRoamingEnabled
Bug: 1139306
Change-Id: I880c9ab6951b62b22494395f2f7e52e44355bee3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3835056
Reviewed-by: Owen Min <[email protected]>
Commit-Queue: Igor Ruvinov <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036304}
Import wpt@484061d5e2004bd554a8e3a92a34509706088101
Using wpt-import in Chromium 4cb2a80dc6a25893e763faf21bae61ad60e1beff.
With Chromium commits locally applied on WPT:
3738f7ce6d "Deflake pointerevent_boundary_events_in_capturing.html"
Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md
Directory owners for changes in this CL:
[email protected]:
external/wpt/css/css-sizing
NOAUTOREVERT=true
[email protected]
No-Export: true
Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-input-fyi-rel,linux-blink-rel
Change-Id: I3a033bd377d6b5114f3e4dd957af612e171acfd5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3835646
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Auto-Submit: WPT Autoroller <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036303}
Revert "Temporarily enable External Navigation debug logs"
This reverts commit ebf5f9fc23697febcb322380b9b44209f61738f1.
Reason for revert: Reverting before branch cut.
Original change's description:
> Temporarily enable External Navigation debug logs
>
> These logs are needed to debug issue 1323163 which can't be reproduced
> without a swedish banking app verifying a transaction.
>
> Bug: 1323163
> Change-Id: Ib02820727b205cb4fdcf8fec57935d7b1a34a123
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3827317
> Reviewed-by: Yaron Friedman <[email protected]>
> Commit-Queue: Michael Thiessen <[email protected]>
> Commit-Queue: Yaron Friedman <[email protected]>
> Auto-Submit: Michael Thiessen <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1034524}
Bug: 1323163
Change-Id: If0ebfcad431f394c3a68455a88baacea2fc2519c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3836953
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Auto-Submit: Michael Thiessen <[email protected]>
Commit-Queue: Michael Thiessen <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036302}
Android: Ensure secondary link pool is usable
Only android uses the secondary link pool and this is for tasks that are
memory intensive but generally use no more than 2GB and on average 1GB
of RAM. This means that most of the time the build is not running as
fast as it should if these tasks are sharing the memory-intensive
primary link pool. This CL ensures that the secondary pool is at least
as large as the primary pool, oftentimes larger, which should result in
much faster builds and better parallelization on bots.
This CL also removes some rare GN args in the if condition for android,
since is_java_debug is typically equal to is_debug and lint uses the
secondary pool so the value of disable_android_lint no longer matters
for the primary pool.
Added code to make future tweaks easily testable. Example and current
output:
$ for i in {09..64..2}; do echo -n "${i}GB: " && \
./build/toolchain/get_concurrent_links.py --mem_per_link_gb 6 \
--secondary_mem_per_link 2 --override-ram-in-gb-for-testing $i; done
09GB: primary=1 secondary=1
11GB: primary=1 secondary=2
13GB: primary=1 secondary=3
15GB: primary=1 secondary=4
17GB: primary=2 secondary=2
19GB: primary=2 secondary=3
21GB: primary=2 secondary=4
23GB: primary=2 secondary=5
25GB: primary=3 secondary=3
27GB: primary=3 secondary=4
29GB: primary=3 secondary=5
31GB: primary=3 secondary=6
33GB: primary=4 secondary=4
35GB: primary=4 secondary=5
37GB: primary=4 secondary=6
39GB: primary=4 secondary=7
41GB: primary=5 secondary=5
43GB: primary=5 secondary=6
45GB: primary=5 secondary=7
47GB: primary=5 secondary=8
49GB: primary=6 secondary=6
51GB: primary=6 secondary=7
53GB: primary=6 secondary=8
55GB: primary=6 secondary=9
57GB: primary=7 secondary=7
59GB: primary=7 secondary=8
61GB: primary=7 secondary=9
63GB: primary=7 secondary=10
In this output the key values are 15GB, 31GB, and 63GB as these are the
typical memory limits on bots. In this case trading one or more primary
pool sizes results in a much bigger secondary pool than before and will
result in builds completing faster.
Bug: 1351263
Change-Id: I85f937fa543eb8e1945610aef12949afd85209ee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3836694
Reviewed-by: Andrew Grieve <[email protected]>
Commit-Queue: Peter Wen <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036301}
Move FirstPartySetsContextConfig class under //net
This CL does not change the existing behavior of the code.
Change-Id: I114d158d4200857a8f6b9350248232d0db607c6c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3814845
Reviewed-by: Maks Orlovich <[email protected]>
Commit-Queue: Shuran Huang <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036300}
[ios] Updates assets for the lockscreen launcher widget.
Bug: 1347565
Change-Id: I36e590e9d2df5dc02ec9c47a7637ede624eb7e5a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3835649
Reviewed-by: Chris Lu <[email protected]>
Commit-Queue: Rohit Rao <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036299}
Initial support for a "main image" in bubbles
Bug: None
Change-Id: If14ac94c24fd39958d60d8210fc4c873020e05bd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3831798
Reviewed-by: Robert Liao <[email protected]>
Commit-Queue: Peter Boström <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036298}
Add ref-counting for cache handles so that maps don't grow unbounded.
- The maps grow based on the number of concurrently active profiles on
the same browser session. On average this is a small number (< 100)
which was why the ref-counting here is introduced separately.
Furthermore, the maps are just strings<->ints so the sizes were also
small. Adding this now as a separate feature for clarity.
Bug: dawn:549
Change-Id: Idbf02c407b883a6b2bfe71072973760ff4c2c826
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3827705
Reviewed-by: Sunny Sachanandani <[email protected]>
Commit-Queue: Loko Kung <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036297}
glanceables: Add weather icon and temperature
* Add a new GlanceablesWeatherView to the main GlanceablesView
* Observe the ambient mode weather model for weather updates
* Trigger an ambient weather fetch on login to get the initial data
The weather does not update if the user stays on the glanceables
screen. This will be addressed in a future CL.
Bug: 1353491
Test: added to ash_unittests
Change-Id: Ic77fafce6f924efe18ee46c9c9d2bab22e65f332
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3835049
Reviewed-by: Matthew Mourgos <[email protected]>
Commit-Queue: James Cook <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036296}
[realbox] Avoid overtriggering zps on mouse click and tabbing into input
Bug: 1345099
Change-Id: I6828b0b8a471be077adad28a33a97af7c8f7abf5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3828391
Commit-Queue: Moe Ahmadi <[email protected]>
Reviewed-by: John Lee <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036295}
Mark //build:version_metadata as a runtime dep of chrome_initial on CrOS
And not a build-time dep.
A 'dep' in GN is a target that needs to be compiled before our
current target gets compiled, usually for linking.
A 'data_dep' in GN, on the other hand, is a target that needs to be
compiled at _some_ point during the ninja invocation. This can be
done before or after our current target. However, anything declared
as a 'data_dep' of our current target is tracked internally by GN as
a "runtime_dep". Meaning: if the target is an executable (or a test)
these runtime_deps need to be present on the filesystem when the
executable is invoked. For more info, see:
https://gn.googlesource.com/gn/+/refs/heads/main/docs/reference.md#runtime_deps
The //build:version_metadata target produces a json file. Since this
target is a 'dep' of 'chrome_initial' (and subsequently of 'chrome'),
it's not tracked as a runtime_dep. However, this json file is read by
CrOS Tast tests at browser run-time. So it should be a runtime_dep.
Changing it to a data_dep should accomplish that, and should allow
the CrashEarly tast test to be re-enabled since the absence of
metadata.json in the test inputs was the reason behind it failing.
Bug: 1350205
Change-Id: I24e9f5831377247f427679b37af2cf6e9f6ea160
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3827817
Reviewed-by: Sven Zheng <[email protected]>
Reviewed-by: Ian Barkley-Yeung <[email protected]>
Commit-Queue: Ben Pastene <[email protected]>
Reviewed-by: Lei Zhang <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036294}
Reland "[TangibleSync] Add variation strings for tangible sync view"
This reverts commit 3c5f8f489a232eac71d58a08f4cbe93f72796496.
Reason for revert: This crash is caused due to another cl: https://crrev.com/c/3822704 affecting the screenshot. CQ landed the cl without updating the golden screenshot.
Original change's description:
> Revert "[TangibleSync] Add variation strings for tangible sync view"
>
> This reverts commit d1c4933fffc62ef2412c9b3f8e6e753235a2549b.
>
> Reason for revert: Breaking builder.
> https://ci.chromium.org/p/chromium/builders/ci/android-marshmallow-x86-rel
>
> Original change's description:
> > [TangibleSync] Add variation strings for tangible sync view
> >
> > This cl adds a title and a subtitle variation for tangible sync consent
> > view. These different views are configured by finch field trial param.
> > This cl thus modifies the existing flag setup to field trial with
> > params.
> > This cl also adds tests for these two different views. The
> > @DisableFeature annotation has also been moved from the class level to
> > the test level. Otherwise the test configuration for field trial tests
> > were getting overridden by the class level annotation.
> >
> > Bug: 1332527
> > Change-Id: I4efb511c159aec14320944f3497667cc5e8dfa25
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3825875
> > Reviewed-by: Boris Sazonov <[email protected]>
> > Commit-Queue: Tanmoy Mollik <[email protected]>
> > Cr-Commit-Position: refs/heads/main@{#1035466}
>
> Bug: 1332527
> Change-Id: I42c7d7b5890f18d67f03445e3430b8dc73151406
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3835022
> Owners-Override: Aishwarya Rajesh <[email protected]>
> Commit-Queue: Aishwarya Rajesh <[email protected]>
> Auto-Submit: Aishwarya Rajesh <[email protected]>
> Bot-Commit: Rubber Stamper <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1035705}
Bug: 1332527
Change-Id: I512aaff48a4d7704f839609bc90749218ebc02cd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3833552
Bot-Commit: Rubber Stamper <[email protected]>
Commit-Queue: Tanmoy Mollik <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036293}
Reland "Fix flaky test issue for consolidated consent screen in demo mode."
This is a reland of commit d33a2990c5fad468c048868e9e29b817b4f2c1cb
The last landing was reverted for the failure. That was becuase the last commit was based on the change crrev.com/c/3782972 (rebased mid of the day Aug 11th, when 3782972 was merged the same day morning) before landing. Dryrun result was reused based on the success of previous base (Aug 10th). Logs: https://chromium-review.googlesource.com/c/chromium/src/+/3782972/comments/6ebfbf8c_3dbcf074
Original change's description:
> Fix flaky test issue for consolidated consent screen in demo mode.
>
> Add a wait for the visibility of the acceptButton before calling test::TapConsolidatedConsentAccept(). Test result: paste.googleplex.com/5825292466651136
>
> Bug: 1341234
> Change-Id: Ib982155d945a048930198ba1a8084dce2716c33d
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3823543
> Reviewed-by: Toni Barzic <[email protected]>
> Commit-Queue: Bowen Li <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1034146}
Bug: 1341234
Change-Id: I7c6d1a9059e02bab10c3e138bab43586c70cf8d8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3830081
Reviewed-by: Toni Barzic <[email protected]>
Commit-Queue: Bowen Li <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036292}
Parse ccTLDs in First-Party Set declarations.
These values are not read/used by the backend yet; that will be done
in a followup CL.
Bug: 1349781
Change-Id: I19fd5b8b8678411b681bd6727c734b262f5dd41f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3830749
Reviewed-by: Alex Gough <[email protected]>
Reviewed-by: Matt Reichhoff <[email protected]>
Auto-Submit: Chris Fredrickson <[email protected]>
Commit-Queue: Chris Fredrickson <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036291}
Switch to gnrt from crates.py
Runs gnrt and checks in the new BUILD.gn files.
Updates the third-party crate README and adds a deprecation notice to
crates.py
Bug: 1291994
Change-Id: Ib72834a43ff852316285ede20c85fc856dc24eb3
Cq-Include-Trybots: luci.chromium.try:android-rust-arm-dbg,android-rust-arm-rel,linux-rust-x64-dbg,linux-rust-x64-rel
Change-Id: Ib72834a43ff852316285ede20c85fc856dc24eb3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3827733
Reviewed-by: Alex Gough <[email protected]>
Reviewed-by: Nasko Oskov <[email protected]>
Auto-Submit: Collin Baker <[email protected]>
Commit-Queue: Collin Baker <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036290}
Remove unused description element from bookmark_section_header.xml
No behavior is changed. Was added in 2020 but never actually displayed.
Bug: None
Change-Id: Ib38012962002f61baa01179d9d5f3f2dffcb3506
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3793233
Reviewed-by: Brandon Wylie <[email protected]>
Auto-Submit: Victor Vianna <[email protected]>
Reviewed-by: Theresa Sullivan <[email protected]>
Commit-Queue: Victor Vianna <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036289}
[stts/android] Hide "Your devices" link if there's no target device
Screenshot: crbug.com/1219434#c33
This is the equivalent of crrev.com/c/3826260 for Android.
Aaaand adjust the padding in
send_tab_to_self_feature_unavailable_prompt.xml once again.
Bug: 1219434
Change-Id: Idd7f88577f614997939313763851fb6ef3abb72a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3827219
Quick-Run: Victor Vianna <[email protected]>
Reviewed-by: Sophey Dong <[email protected]>
Reviewed-by: Boris Sazonov <[email protected]>
Commit-Queue: Victor Vianna <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036288}
FloatWindow: Add FloatedWindowInfo and enable multi floated window.
Enable multi floated window for both clamshell mode and tablet mode.
Add FloatedWindowInfo to host floated window info for both clamshell and
tablet mode.
Fixed: 1349564
Test: Manual
Change-Id: I6f1deb7328602e03f7a4cfb03840980cd83adb58
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3826367
Reviewed-by: Ahmed Fakhry <[email protected]>
Commit-Queue: Judy Wang <[email protected]>
Reviewed-by: Sammie Quon <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036287}
Update OWNERS file to allow automatic push of root_store.md via Component Udpate (currently failing)
Change-Id: If3f58dd880ea71046afb328088fc31eeb413a587
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834071
Reviewed-by: Matt Mueller <[email protected]>
Commit-Queue: Ryan Dickson <[email protected]>
Reviewed-by: Hubert Chao <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036286}
WebUI: Migrate cr-toggle to class-based syntax
Bug: 1206112
Change-Id: I4e899bc8b2ca29e09f2df8483a710a9ccfc043c0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834289
Commit-Queue: Rebekah Potter <[email protected]>
Reviewed-by: John Lee <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036285}
Remove ShelfFocusSearch.
This code goes back to before the ScrollableShelf. Now, ScrollableShelf has its own ScrollableShelfFocusSearch [1] which uses the same logic as the original one but with an extra condition to auto scroll the shelf for the focused view to be visible/tappable.
To remove code duplication, redirect GetFocusSearch in ShelfView to return the one from ScrollableShelfView.
[1]: https://source.chromium.org/chromium/chromium/src/+/main:ash/shelf/scrollable_shelf_view.cc;l=247
Bug: None
Change-Id: Idf74ecd04ed9f718996e2521d3a0efe3b311251e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3819657
Reviewed-by: Toni Barzic <[email protected]>
Commit-Queue: Ana Salazar <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036284}
Roll Chrome Win32 PGO Profile
Roll Chrome Win32 PGO profile from chrome-win32-main-1660748343-6d911f54f87af4f82c894289657e08214d69979c.profdata to chrome-win32-main-1660759200-913e2c13072ec66036ccda24b56d1cf694a84a8f.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win-chrome
Tbr: [email protected]
Change-Id: I048e9a5a66e22a3d881e9163aa7880f504103eaf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3836896
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036283}
[anchor-position] Add tests for conditions to determine the target
This patch adds web tests for r1035645 crrev.com/c/3832986.
The original patch contains C++ unit tests. Tests in this
patch tests end-to-end, and can test on other browsers.
Bug: 1309178
Change-Id: Ie9c6265846902479fd334403631b87a71c80fd47
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3835445
Commit-Queue: Xiaocheng Hu <[email protected]>
Auto-Submit: Koji Ishii <[email protected]>
Reviewed-by: Xiaocheng Hu <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036282}
[Omnibox] Adjust the width of location bar for revamp
before:
https://screenshot.googleplex.com/B8LwxZ7HBUyzJQn
after:
https://screenshot.googleplex.com/BndVmKXEQzYeZ3e
This CL adjusts the width of the location bar for phone and search
activity only.
We still need to adjust the shape for the location bar, but will be in
the follow CLs.
Bug:1348445
Change-Id: I9436cdf57ceaae9a415055e9d96b8e416d4c040e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3825977
Reviewed-by: Tomasz Wiszkowski <[email protected]>
Commit-Queue: Gang Wu <[email protected]>
Reviewed-by: Ted Choc <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036281}
Roll Perfetto Trace Processor Linux from 3960394cdf24 to 8404c1cc9828
https://android.googlesource.com/platform/external/perfetto.git/+log/3960394cdf24..8404c1cc9828
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: [email protected]
Change-Id: I4b1eb53670e3ef74174939b49f6b71bce81d12d5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3826189
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036280}
Roll src-internal from f0e9eeb81399 to 266a1641a0fa (8 revisions)
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f0e9eeb81399..266a1641a0fa
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: chromium:1105553,chromium:1346304
Tbr: [email protected],[email protected]
Change-Id: I2d5de4a869bff777a4af4ce1bbf39ee03eaf0773
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3836937
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1036279}
[ntp][hpp] Make CSS tweaks to HPP dismiss button
Changes size and colors for HPP dismiss button. These changes were confirmed with UX.
Light Mode: screenshot/6FDf4QwegoLnnLX.png
Dark Mode: screenshot/7Jm3LSYokPFkJ4f.png
Change-Id: I11465cd96e30c759f2666175afc6bb46e07cb69c
Bug: 1350587
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832959
Reviewed-by: Tibor Goldschwendt <[email protected]>
Commit-Queue: Paul Adedeji <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036278}
[iOS] Add header visibility to sticky header condition
Bug: 1353724
Change-Id: Idc2877072617f08d644c426a72dc4a393a020f2f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3836435
Reviewed-by: Sergio Collazos <[email protected]>
Commit-Queue: Sergio Collazos <[email protected]>
Auto-Submit: Adam Arcaro <[email protected]>
Commit-Queue: Adam Arcaro <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036277}
Introduce header for promos_manager_unittest.
This change introduces a header file for promos_manager_unittest.mm.
This enables mock data to be exposed to promos_manager.(h/mm) during
development.
Change-Id: Ieed8a4eea120804649289a9e95f56270dac5ce9c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3806555
Commit-Queue: Benjamin Williams <[email protected]>
Reviewed-by: Ali Juma <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036276}
[SearchResumption] Disable the module on tablets.
Bug: 1353866
Change-Id: If20bc117423871217c4a1bde30cefab98d273846
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3836854
Reviewed-by: Sky Malice <[email protected]>
Reviewed-by: Hao Dong <[email protected]>
Commit-Queue: Xi Han <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036275}
[CodeHealth] MediaInternals base::Value improvements
This CL simplifies the use of the modern base::Value methods/classes, by
making use of base::ValueView, rather than using a template.
Bug: 1351111, 1187001
Change-Id: Iee8b7a2d01966194cc2dcca3aa995f43f11bdec2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3826133
Reviewed-by: Thomas Guilbert <[email protected]>
Commit-Queue: Claudio DeSouza <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036274}
cros: disable shadows of system tray bubbles
There are several issues of the shadows on system tray bubbles. To
avoid impacting users experience, this cl creates a feature flag
`SystemTrayShadow` and disables it by default. The shadow should be
enabled after the issues are fixed.
Bug: 1353850
Change-Id: Ic56ae296f0d3574d3cff4d131f942b6409d8b6b0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832529
Commit-Queue: Alex Newcomer <[email protected]>
Reviewed-by: Alex Newcomer <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036273}
[WebLocks] Fix Null-dereference READ Clusterfuzz error in blink::mojom::blink::FeatureObserverProxy::Register
Failure was determined to be due to the unbound observer_ remote in
RequestImpl. This change adds another check to see if the observer_ is
bound, and if it's not, the promise is rejected, mirroring how the
service_ checks are handed.
Bug: 1347389
Change-Id: I392c3e0b4676cd6f4bf80238a0522e4ad6ba8a48
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832518
Reviewed-by: Ayu Ishii <[email protected]>
Commit-Queue: Christine Smith <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036272}
Move common DMClient calling code into a template
Bug: 1345407
Change-Id: Icf65a4594062776c5052d87924639643fc7cc613
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3835057
Auto-Submit: S Ganesh <[email protected]>
Reviewed-by: Xiaoling Bao <[email protected]>
Commit-Queue: S Ganesh <[email protected]>
Commit-Queue: Xiaoling Bao <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036271}
Ensure terminal can use runtime.sendMessage
Follow up to crrev.com/c/3774199.
Feature matching is done at origin level, so we must allow
runtime.sendMessage for all of Terminal app for it to work at all.
Bug: 1330425
Change-Id: I50c00bdd0d97a9f2ee7742f7fb430f13fba3b336
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3831746
Reviewed-by: Devlin Cronin <[email protected]>
Commit-Queue: Devlin Cronin <[email protected]>
Auto-Submit: Joel Hockey <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036270}
Get StorageKey using RenderFrameHostImpl in ServiceWorkerMainResourceLoaderInterceptor
An attempt to fix crbug.com/1346450.
Bug: 1346450, 1345527
Change-Id: I852783b828d24207b01b06791f3537b8932756c3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3829514
Reviewed-by: Alex Moshchuk <[email protected]>
Reviewed-by: Ayu Ishii <[email protected]>
Commit-Queue: Andrey Zaytsev <[email protected]>
Reviewed-by: Marijn Kruisselbrink <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036269}
ash: Test channel indicator in two shelf alignments
Include tests to verify the correct size of the channel indicator
image view in both bottom-shelf and side-shelf.
These tests are disabled at present, because they fail. They'll be
enabled in a separate CL that includes the fix that allows them to
pass.
Bug: 1351496
Change-Id: I263711c8ba6ce7b32a06f41a6272f603a103cadd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3826392
Reviewed-by: Alex Newcomer <[email protected]>
Commit-Queue: Roger Tinkoff <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036268}
[ios] Only Enable kTrendingQueriesModule if preceding flag is enabled
kTrendingQueriesModule cannot be enabled without
kContentSuggestionsUIModuleRefresh also enabled. Thus,
kTrendingQueriesModule feature code should be executed only when
kContentSuggestionsUIModuleRefresh is enabled.
Bug: 1348495
Change-Id: I842cded80283be3a515c119cad1ef393d553eb59
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3826827
Commit-Queue: Chris Lu <[email protected]>
Reviewed-by: Rohit Rao <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036267}
Clean up WebGPUExpectations file
Only the reftests still use this expectation file. Clean up all of the
other expectations.
Bug: 1333971
Change-Id: I45ff6cb5d03ff4c1f648e32d8986a28baea31655
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834793
Auto-Submit: Kai Ninomiya <[email protected]>
Commit-Queue: Austin Eng <[email protected]>
Reviewed-by: Austin Eng <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036266}
[iOS] Experience Kit Maps integration metrics
Add Experience Kit Maps integration metrics.
Bug: 1351353
Change-Id: I9db0ac86b950c9411391f786dd3e9c4db06ad37f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834554
Reviewed-by: Robert Kaplow <[email protected]>
Reviewed-by: David Jean <[email protected]>
Commit-Queue: Elmehdi Rahmaoui <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036265}
Roll Chrome Linux PGO Profile
Roll Chrome Linux PGO profile from chrome-linux-main-1660737332-29095bd3d22be72b162a802963b21a87dc061e6a.profdata to chrome-linux-main-1660759200-a83b9b53dac865d5c3359250f156cb8570d3c467.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-linux-chromium
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:linux-chrome
Tbr: [email protected]
Change-Id: Ifd776959c20b6fc28feaab837b3cdc17c32c8398
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3836362
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036264}
Fix Recursive PostTask Call In OnVideoFrameClosed
Adds a return so that we don't infinitely call PostTask when closing a
VideoFrame used as an ExternalTexture.
Bug: chromium:1353403
Change-Id: I2fdd4a91cd579001d07aaebb8c0a96b60ccdfeb8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832404
Reviewed-by: Austin Eng <[email protected]>
Commit-Queue: Brandon1 Jones <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036263}
Check in .d.ts files for shared navigation polymer elements
- This is in preparation for migrating shortcut customization to
TypeScript
- Add copy() target to ash/webui/common/resources/BUILD.gn so that
other projects can depend on the newly added definitions
Bug: b/242549183
Change-Id: I5120069b376ac512c75154fdf11b0640ba2db7c6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3833543
Commit-Queue: Michael Checo <[email protected]>
Reviewed-by: Rebekah Potter <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036262}
Reland "Reland "Add prediction and attribution finding logic for viz and blink""
This is a reland of commit 65599fba81f6b6579728303526b65baac4e28d4e
Original change's description:
> Reland "Add prediction and attribution finding logic for viz and blink"
>
> This is a reland of commit 31a41e223684804ecf5435f315d08959176d4646
>
> Original change's description:
> > Add prediction and attribution finding logic for viz and blink
> >
> > Implement logics to calculate the prediction and find the high latency
> > attribution for breakdown stages of kSendBeginMainFrameToCommit and
> > kSubmitCompositorFrameToPresentationCompositorFrame, which are the
> > viz and blink breakdown stages.
> >
> > Bug: 1334823
> > Change-Id: Iba4a399c030c81dba618dd956dbb171d46f3a7be
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3788225
> > Reviewed-by: Mingjing Zhang <[email protected]>
> > Commit-Queue: April Li <[email protected]>
> > Reviewed-by: Jonathan Ross <[email protected]>
> > Cr-Commit-Position: refs/heads/main@{#1032778}
>
> Bug: 1334823
> Change-Id: If38526ae284262301c50a9aa518649fb22d99598
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3824477
> Reviewed-by: Jonathan Ross <[email protected]>
> Reviewed-by: Mingjing Zhang <[email protected]>
> Commit-Queue: April Li <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1033694}
Bug: 1334823, 1351361
Change-Id: I70fd823688e6b67771a40acec17f105efbd97e47
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3833479
Reviewed-by: Jonathan Ross <[email protected]>
Commit-Queue: Mingjing Zhang <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036261}
Create ClassicScript at ClassicPendingScript::NotifyFinished()
To make ClassicScript accessible from ScriptCacheConsumer
and thus avoid accessing duplicated information
via ScriptCacheConsumerClient.
A follow-up of
https://chromium-review.googlesource.com/c/chromium/src/+/3682122.
Bug: v8:12808, 1349934
Change-Id: I22c9c3e11998a3b88b61639d857d54120a5bfcdd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3808872
Reviewed-by: Shunya Shishido <[email protected]>
Reviewed-by: Kouhei Ueno <[email protected]>
Commit-Queue: Hiroshige Hayashizaki <[email protected]>
Reviewed-by: Minoru Chikamune <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036260}
sheriff: don't leak URL scheme registry in content unit tests
It makes the ASAN bots unhappy.
Fixed: 1353849
Change-Id: I5d2d1337a787b8d4ff0c3c6ff4f8d2019334d894
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3836415
Auto-Submit: Elly Fong-Jones <[email protected]>
Reviewed-by: John Abd-El-Malek <[email protected]>
Commit-Queue: Elly Fong-Jones <[email protected]>
Commit-Queue: John Abd-El-Malek <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036259}
Reset SODA when a new language pack finishes downloading
This CL resets SODA when a new language pack finishes downloading mid-
stream by observing the SODA installer in the browser process and
notifying the renderer when the new language pack is installed, which
in turn notifies the Speech Recognition service which resets SODA. This
allows the user to switch the Live Caption language in the middle of
a stream and have the new language start transcribing as soon as the
language pack finishes downloading without having to refresh the page.
Bug: 1239810
Change-Id: Ia23c32c12db00db921163548000d16b6956ff0f8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3827848
Commit-Queue: Evan Liu <[email protected]>
Reviewed-by: Akihiro Ota <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036258}
[fuchsia][input] Support scroll only contains scroll_*_physical_pixel
For touchpad, mouse scroll event does not include scroll_*
(delta by tick) field.
Bug: fuchsia:101286
Test: also manual tested to ensure scroll works
Change-Id: Icc468f83fa9b4cf0e30b2e44764a73aa6e4e154c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3831920
Reviewed-by: Sergey Ulanov <[email protected]>
Commit-Queue: Jianpeng Chao <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036257}
[Login Shelf] Fix focus traversal under OOBE
This CL fixes the issue that the login shelf button does not receive
the focus after pressing the tab key.
Bug: b/242026089
Change-Id: I1a38f2c005ec72abcc68d40be1d6f8eb8420b75b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3831811
Commit-Queue: Andrew Xu <[email protected]>
Reviewed-by: Xiyuan Xia <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036256}
Make the CanonOutput classes use size_t.
Also does a few other unsafe narrowing fixes in connected files.
Bug: 1292951
Change-Id: I9a7d3ed60f7902430b70e4297bf02f68f18fb3f5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832055
Commit-Queue: Peter Kasting <[email protected]>
Reviewed-by: Daniel Cheng <[email protected]>
Reviewed-by: Tom Sepez <[email protected]>
Commit-Queue: Tom Sepez <[email protected]>
Auto-Submit: Peter Kasting <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036255}
Fixes wrong condition for disabling cache.
Bug: dawn:549
Fixed: chromium:1353722
Change-Id: I9a1fa0302a6dfe88d0a90dd6071ee349fe4dea56
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832993
Reviewed-by: Sunny Sachanandani <[email protected]>
Commit-Queue: Loko Kung <[email protected]>
Auto-Submit: Loko Kung <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036254}
Use D3DImageBacking for more GMB formats
Some shared memory GMBs, eg. software video decode, are currently using
GLImageBacking rather than D3DImageBacking on Windows. If
D3DImageBacking supports the GMB format then use that instead.
Bug: 1293509
Change-Id: I139e90269951519fa76aa5119da121969e9912a3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832932
Commit-Queue: Kyle Charbonneau <[email protected]>
Reviewed-by: Sunny Sachanandani <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036253}
glanceables: Add welcome label component
Simple label component that renders "Welcome back, $0" text, where $0 is the user's given name returned from session controller.
Bug: 1353488
Test: added to ash_unittests ("GlanceablesWelcomeLabelTest.*")
Change-Id: I9eb31e003d39a7ffb2ffc9ba8aa016ce7169bc78
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3833509
Reviewed-by: James Cook <[email protected]>
Commit-Queue: Artsiom Mitrokhin <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036252}
DanglingPtr: fix dangling ptrs in xproto_internal
Use unique_ptr to handle owned memory.
Bug: 1291138
Change-Id: Ic7398f11466afc92e1551c50966885f91bc5780f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834482
Reviewed-by: Thomas Anderson <[email protected]>
Commit-Queue: Ali Hijazi <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036251}
Roll WebGPU CTS from 30e9e048a1ff to 168bc9b7f359 (2 revisions)
https://chromium.googlesource.com/external/github.com/gpuweb/cts.git/+log/30e9e048a1ff..168bc9b7f359
2022-08-17 [email protected] Refactor *SubnormalNumber functions to not depends on *SubnormalScalar functions (#1755)
2022-08-17 [email protected] Implementing dot f32 tests (#1748)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webgpu-cts-chromium-autoroll
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel
Bug: None
Tbr: [email protected]
Change-Id: I0e7e1053b918c4eb8074e6cc679c63f1153e33d3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834261
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036250}
Roll Fuchsia SDK from 9.20220816.1.1 to 9.20220817.1.1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast
Tbr: [email protected]
Disable-Retries: true
Change-Id: I76cdb6f9409823fd2d5dc01a469eb26cb1d87d3e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3836832
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036249}
Fix margin before the separator in DialogModel
This CL fixes the margin before the separator if the previous item
existing and not being a kMenuItem.
Bug: 1353193
Change-Id: Iefc49fa82cf485ef3eda99febfe5025b6a3dd759
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3828797
Reviewed-by: Peter Boström <[email protected]>
Commit-Queue: Mei Liang <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036248}
Roll Perfetto Trace Processor Win from 8ab7cdc76e49 to 8404c1cc9828
https://android.googlesource.com/platform/external/perfetto.git/+log/8ab7cdc76e49..8404c1cc9828
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: [email protected]
Change-Id: I2c73b5f3cf6778221041f5ee240a2fa976d4ae00
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3826191
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036247}
Fixed StatusView icon not updating when navigating back to NTP
This CL fixes an issue where the icon on StatusView is not visible when
navigating from a NTP feed page back to the NTP. This icon is the search
engine icon on the NTP.
Bug: 1345552
Change-Id: Ia71e00903dda1d068c943bced810ed5f6f645c09
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3836614
Commit-Queue: Salvador Guerrero Ramos <[email protected]>
Reviewed-by: Patrick Noland <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036246}
Reland "Hide tooltip when view becomes hidden"
This reverts commit e1791f868603ba85ac0a580381853b18920c9790.
It makes sure HomeButton::IsShowingAppList called in
HotseatShelfAppBrowserTest.EnableChromeVox returns false if
ash::AppListControllerImpl is null.
See https://luci-milo.appspot.com/ui/inv/task-chromium-swarm.appspot.com-5cc3807edb5ef611/test-results?q=HotseatShelfAppBrowserTest+
Original change's description:
> Revert "Hide tooltip when view becomes hidden"
>
> This reverts commit b8c159f60c033f4bf8e09a88c48efd972de11705.
>
> Reason for revert: Likely causing builder failure https://ci.chromium.org/ui/p/chromium/builders/ci/linux-chromeos-rel/58940/overview
>
> Original change's description:
> > Hide tooltip when view becomes hidden
> >
> > Bug: 926847
> > Change-Id: I49ba5aa0d39b7b6ed343dcf73d45979b02cb73b9
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3828370
> > Reviewed-by: Peter Kasting <[email protected]>
> > Commit-Queue: Fr <[email protected]>
> > Reviewed-by: Ahmed Fakhry <[email protected]>
> > Cr-Commit-Position: refs/heads/main@{#1035574}
>
> Bug: 926847
> Change-Id: I1b7c573bf823d83e772f786b756c9e7e5a91a12e
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Owners-Override: Emily Shack <[email protected]>
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3833525
> Auto-Submit: Emily Shack <[email protected]>
> Reviewed-by: Peter Kasting <[email protected]>
> Bot-Commit: Rubber Stamper <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1035641}
Bug: 926847
Change-Id: I6dded406591d7d0696114461aac16626500f4c5e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834249
Reviewed-by: Peter Kasting <[email protected]>
Commit-Queue: Fr <[email protected]>
Auto-Submit: Fr <[email protected]>
Reviewed-by: Ahmed Fakhry <[email protected]>
Commit-Queue: Ahmed Fakhry <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036245}
WebUI: Check in Polymer 3 cr_input/*
Checking in cr_input_style_css as a .css file and migrating the
generated wrapper to TypeScript by passing it to css_to_wrapper.
Bug: 1184053
Change-Id: I8e6e21abe3ddf3a0d7208d3ff842b184daa96ed4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832820
Reviewed-by: Luciano Pacheco <[email protected]>
Reviewed-by: John Lee <[email protected]>
Commit-Queue: Rebekah Potter <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036244}
float: Add MultitaskMenuView and TabletModeMultitaskMenu contents.
Add Maximize, Split, Partial and Float buttons to
TabletModeMultitaskMenuView.
Also refactor MultitaskMenuView as a base view for MultitaskMenu and
TabletModeMultitaskMenu.
Test: existing + manual
Bug: 1344294, 1351561
Fixed: 1351561
Change-Id: If46cfb5efa3da11b400e140eed484550e14f3250
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3821106
Reviewed-by: Ahmed Fakhry <[email protected]>
Commit-Queue: Sophie Wen <[email protected]>
Reviewed-by: Sammie Quon <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036243}
Add NotificationCenterTray skeleton code
This CL creates a new ash/system/notification_center directory
and adds skeleton code for the new notification center tray.
Bug: 1311738
Change-Id: Icff985b0dfb31e8ba917f9986711128e4ca7409a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3833482
Commit-Queue: Ahmed Mehfooz <[email protected]>
Reviewed-by: Alex Newcomer <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036242}
[Test Automation] Screenshot a secondary WebUI surface.
This CL (theoretically) makes taking screenshots of secondary WebUI using WebUIInteractionUtil::CompareScreenshot() reliable.
NOTE: if this CL still flakes, revert and tag me with a bug. We know the places it can flake now, but the intention is to do the bare minimum to fix the problem instead of "fixing" a bunch of test code pre-emptively and potentially changing the behavior of other tests.
This CL makes two specific changes that allow for this to work:
1. Adds WebUIInteractionUtil::SendEventOn...MinimumSize(), which can be used to ensure that a WebUI is rendered at an appropriate size and contains the expected contents (see crbug.com/1352886).
2. Modifies TestBrowserUi::VerifyPixelUi() to avoid a potential infinite loop/timeout due to crbug.com/1352884.
The Cl adds tests that prove both out:
- Adds testing for both the default and fully-specified version of SendEventOnMinimumSize().
- The new test is known to fail without the changes to VerifyPixelUi(), both in previous versions of this CL and older CLs that were reverted due to flakiness.
Finally, updates are made to the CompareScreenshot() method documentation to reflect a number of improvements to the test infrastructure and to explain best practices.
The changes to TestBrowserUi are not in a separate CL specifically because I needed this test case to serve as a regression test, but couldn't check in the test case separately because it was flaky 🤷♀️
Bug: 1352884, 1352886
Change-Id: Ib985b93fb5456642060f2a2e9848054475a66ff4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3664291
Reviewed-by: Caroline Rising <[email protected]>
Commit-Queue: Dana Fried <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036241}
Refactor browser/background to use PrefService::GetValueDict
This is part of a larger migration effort based on
go/trust-your-prefs.
Bug: 1341996
Test: Existing unit tests
Change-Id: I9817157f88297855132ff0895541fa643a6ed229
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3833534
Commit-Queue: Roland Bock <[email protected]>
Reviewed-by: Ted Choc <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036240}
No tab group for start surface.
Bug: 1350655
Change-Id: Icb4bde9f9a5f4605442d3a02e1a7a84aafe59063
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834591
Reviewed-by: Hao Dong <[email protected]>
Commit-Queue: Jian Li <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036239}
Roll Media App from h7OE9fCrkNVorXo4t... to OUGohHk5YvTdODZGY...
Release_Notes: http://go/media_app-x20/relnotes/Main/media_app_202208170800_RC00.html
https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/OUGohHk5YvTdODZGYUatmAIbkUeI9qX41jPUFsn8kFAC
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: [email protected]
Change-Id: I3dd07d3069cd50a9c68f5352e2e95ccb6a713425
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3836834
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1036238}
Refactor ManagedConfigurationAPI to use PrefService::GetValueDict
This is part of a larger migration effort based on
go/trust-your-prefs.
Bug: 1341996
Test: Existing unit tests
Change-Id: Iafc5bcbcfd6d16627db4ef0ae9599406ebf898c3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3827210
Reviewed-by: Roman Sorokin <[email protected]>
Commit-Queue: Roland Bock <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036237}
[FLEDGE] Add priority vector parser to TrustedSignals.
Add a new parser of the optional per-interest-group priority vector
that can be returned as part of priority signals. This CL doesn't do
anything with them, it just introduces a parser.
github PR: https://github.com/WICG/turtledove/pull/329
Bug: 1343389
Change-Id: I9f849432970ca35b322620a54bc8808e495bd71d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3835069
Reviewed-by: Maks Orlovich <[email protected]>
Commit-Queue: Matt Menke <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036236}
Finish gnrt tool
Translates dependency resolution data to build rules and outputs
BUILD.gn files accordingly.
A follow-up CL will update the build files checked in, finishing the
transition to gnrt from crates.py for build file generation.
Bug: 1291994
Change-Id: I29076f67e0cbe07710ac783ff318e3b70ee8c4d3
Cq-Include-Trybots: luci.chromium.try:linux-rust-x64-dbg,linux-rust-x64-rel,android-rust-arm-rel,android-rust-arm-dbg
Change-Id: I29076f67e0cbe07710ac783ff318e3b70ee8c4d3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3829810
Reviewed-by: Nasko Oskov <[email protected]>
Commit-Queue: Collin Baker <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036235}
[Read Anything] Use HtmlTag attribute.
Before this CL, we were special-casing each supported tag type with an
IsX() methods (for example, IsParagraph(), IsLink(), etc). This CL
generalizes this to support all html tags coming from the accessibility
tree.
This CL was inspired by an issue we had where we didn't correctly
handle the following case:
<h1>
<span id="1">My heading</span>
</h1>
The previous method didn't handle spans inside of h1 elements, so
"My heading" was not printed.
To address that issue, I considered a few options:
1. Add support for genericContainers, just like we did for paragraphs,
links, etc.
2. Treat all genericContainers as ignorable elements as we walked the
tree via GetNextUnignoredSibling. GenericContainers are sometimes
considered ignored, but if a genericContainer has an id, it is not
ignored because the id might be used as a labelled-by for a
control.
3. This CL
Option 3 (this CL) seemed to be the most generalizable for the future.
One problem with this CL is that we now include some undesirable
elements that are used purely for visuals, such as <mark>, <b>, and
<sup>. We will need to consider how to address this in a follow-up;
one idea is to replace their htmlTag with <span>.
Bug: 1266555
Change-Id: I29a7a6b99f7158d591ed4a57b75a3c8082511acb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3646654
Reviewed-by: Ramin Halavati <[email protected]>
Reviewed-by: Mark Schillaci <[email protected]>
Commit-Queue: Abigail Klein <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036234}
Remove reference to non-existent flag
Change-Id: I4293e69511505cbdac93e0beb59a8c2a7aff1075
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3831812
Commit-Queue: Aaron Krajeski <[email protected]>
Reviewed-by: Fernando Serboncini <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036233}
sheriff: disable PagesWithCacheControlNoStoreSetFromResponseHeader
This test is quite flaky on Linux, so disable it there.
Bug: 1353858
Change-Id: I4e44bd7e582abef66a21184aab920f441758fe5a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3835451
Commit-Queue: Peter Boström <[email protected]>
Auto-Submit: Elly Fong-Jones <[email protected]>
Reviewed-by: Peter Boström <[email protected]>
Commit-Queue: Elly Fong-Jones <[email protected]>
Owners-Override: Elly Fong-Jones <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036232}
Roll Chrome Mac Arm PGO Profile
Roll Chrome Mac Arm PGO profile from chrome-mac-arm-main-1660737332-adc7a3f7fbaab5ffcaec167dfa8bb93b302ddf7a.profdata to chrome-mac-arm-main-1660759200-46b5fdcae896d77ccc4504d58ac8a64bac713603.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-arm-chromium
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:mac-chrome
Tbr: [email protected]
Change-Id: I83271a07b06c6be23aac73dc881e9c42380b4938
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3836363
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036231}
Preloading: Integrate SearchNavigationPrefetch with Precog APIs
This CL integrates SearchNavigationPrefetch UKM logging with
Preloading APIs PreloadingAttempt and PreloadingPrediction using a
common methodology & terminology.
Bug: 1309934, 1346344
Change-Id: Id1626b2a98497551a4a97680ec4cdc98c94a7d3d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3829035
Reviewed-by: Ryan Sturm <[email protected]>
Commit-Queue: Sreeja Kamishetty <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036230}
sheriff: fix a11y fuzzer build
We can't use ABSL_FALLTHROUGH_INTENDED after an unconditional return.
The fact that this code is not compiled by the CQ is a little worrisome...
Bug: None
Change-Id: I13209bce4d60ddc970cee8416fa912e22f5c3b4f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3836617
Commit-Queue: Peter Boström <[email protected]>
Owners-Override: Elly Fong-Jones <[email protected]>
Auto-Submit: Elly Fong-Jones <[email protected]>
Reviewed-by: Peter Boström <[email protected]>
Commit-Queue: Elly Fong-Jones <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036229}
[CodeHealth] Replace DictionaryValue::GetString in /chrome/browser/media/webrtc.
This CL was uploaded by git cl split.
[email protected]
Bug: 1187036
Change-Id: I55da3d653620455e4d855b0f684d8b8e12f974b6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3828042
Reviewed-by: Sergey Ulanov <[email protected]>
Commit-Queue: Sergey Ulanov <[email protected]>
Auto-Submit: Brian Begnoche <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036228}
[New Deal] Enable consumer-auto-update-toggle-allowed feature flag
Set the feature flag enabled by default.
BUG=b:233127941
Change-Id: I34828656a09226c4611c12bb20aad46764bc2389
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832507
Reviewed-by: Xiyuan Xia <[email protected]>
Commit-Queue: Yuanpeng Ni <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036227}
Remove unnecessary absl::optional around mojo pointer.
Bug: 1349781
Change-Id: I6471a8822e0c1eacdf4423cd61f04592ae6ea9f5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3830752
Reviewed-by: Matt Reichhoff <[email protected]>
Commit-Queue: Chris Fredrickson <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036226}
Fix CCT Branding Toolbar animation
Bug 1: The transition of CCT toolbar when branding finishes is different than the spec. The branding text is supposed to be presented with the URL bar text style, not the title bar. This results in the defined animation in CustomTabToolbarAnimationDelegate working different, which always expecting the starting state is <title bar invisible + url bar visible>.
Fix: Switching to use URL bar to host the branding text resolve the animation direction.
Bug 2: The URL bar animation sometimes will be cut off when transitioning into its position. This is due to the animation's starting draw position exceeding the bounds of the parent LinearLayout.
Fix: Remove the parent LinearLayout fix the problem.
Recording see: crbug.com/1338307#c8
Bug: 1338307
Change-Id: I21c99496d131492c6f2841323ed9763ada5bfef7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3828894
Reviewed-by: Jinsuk Kim <[email protected]>
Reviewed-by: Theresa Sullivan <[email protected]>
Commit-Queue: Wenyu Fu <[email protected]>
Reviewed-by: Peter Conn <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036225}
DanglingPtr: fix dangling ptrs in direct_renderer
Bug: 1291138
Change-Id: If119f417ee7422ae179f547de8dbca4d776ca1d6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3819671
Reviewed-by: ccameron chromium <[email protected]>
Commit-Queue: Ali Hijazi <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036224}
DanglingPtr: fix dangling ptrs in display_damage_tracker.h
`Display::damage_tracker_` depends on `Display::aggregator_` so it must
be declared last and destroyed first.
Bug: 1291138
Change-Id: Ia2ef3677d0669cad10fdb353b75580752ca49f7d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3827406
Commit-Queue: Ali Hijazi <[email protected]>
Reviewed-by: Vladimir Levin <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036223}
Remove unnecessary DCHECK in ExternalCanvasResource dtor
DCHECK was failing flakily due to non-deterministic object destruction
order. Upon navigation, the objects of the previous page all get torn
down. In such situations, it is possible that a CanvasResource may
not be able to be destryed on its thread of origin if the thread has
already been torn down. Ex: A worker.
Bug: 1348616
Change-Id: I3de2739b8c847ad8876597a9192160e7101d9e5a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3835450
Reviewed-by: Juanmi Huertas <[email protected]>
Commit-Queue: Justin Novosad <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036222}
AppHome: Implement the basic |GetApps()| API.
|GetApps| is an backend API exposed to frontend of |chrome://apps|.It gets all apps basic information in chrome.
For background & design document, see following document:
https://docs.google.com/document/d/1I_Ot2Wuyyztt1YIE61rpkeXewaMnPzfMNF-6qCbdtVw/edit#heading=h.q3ma6p1wdg55
Bug: 1350406
Change-Id: I67daa318edcf6e8d0fa1151809e6681badf5b6ad
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3790426
Reviewed-by: Avi Drissman <[email protected]>
Reviewed-by: Alex Gough <[email protected]>
Commit-Queue: Avi Drissman <[email protected]>
Reviewed-by: Phillis Tang <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036221}
[TabStrip] Show selected tab on startup instead of scrolling to end
Show selected tab on startup instead of scrolling to end.
-Ensure the selected tab is immediately visible on the strip (without
needing to scroll).
-Prevent the strip from scrolling to the end on startup by marking tabs
created from startup restore as not selected.
Video: https://drive.google.com/file/d/1yJjL0cIrx3FKSG212e5p3mDey29qGCbn/view?usp=sharing
Bug: 1342653
Change-Id: Iba8924428d490457d57091bd6cb064ceb5639f7f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3778035
Reviewed-by: Sirisha Kavuluru <[email protected]>
Commit-Queue: Neil Coronado <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036220}
[fuchsia] Attempt best-effort to download images.
update_images.py should now attempt to download every image given,
regardless of the status of other images. This way, if one image is
missing, it does not block other images from downloading.
Failing to download images can cause tests depending on these images to
fail in a flaky fashion due to caching of stale images.
Bug: 1353763,1353811
Change-Id: Ie810b6ca458c58bf395e39f3f93348a2bb004317
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3835528
Reviewed-by: Bryant Chandler <[email protected]>
Reviewed-by: Fabrice de Gans <[email protected]>
Commit-Queue: Rohan Pavone <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036219}
Move frame detach check to right after RenderFrameObservers are called
Before this CL, blink::Document::CheckCompletedInternal():
1.) Notifies RenderFrameObservers of DidFinishLoad()
2.) Immediately uses GetFrame() to make a mojo IPC to the browser
3.) Checks if `!GetFrame()` to early-return
In reality, (3) should happen before (2), because (1) can theoretically
lead to frame detachment since arbitrary script could be executed. In the current implementation, if an RFO *did* detach the frame, we'd run (2) which expects GetFrame() to be non-null, and we would crash before our early-return in (3) could catch this.
So immediately after (1), we should be checking if `!GetFrame()` is true.
This CL implements that fix.
Change-Id: Ieaf13209489d5e2d8a3d24ba482a0cb897f84468
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3828631
Auto-Submit: Dominic Farolino <[email protected]>
Reviewed-by: Daniel Cheng <[email protected]>
Commit-Queue: Daniel Cheng <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036218}
Remove VirtualKeyboard RuntimeEnabledFeatures flag
This feature shipped in M94, so remove the flag and the
dependent code.
Bug: 856269
[email protected]
Change-Id: I62df729c3dde0b992b4c1e20f0b97eb482380335
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3827818
Reviewed-by: Anupam Snigdha <[email protected]>
Reviewed-by: Andrey Kosyakov <[email protected]>
Commit-Queue: Daniel Libby <[email protected]>
Reviewed-by: Stephen Chenney <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036217}
[lacros skew tests] Refresh skew tests for M106
This CL updates the ash version ['106.0.5246.0'] for Lacros version skew testing.
If this CL caused regressions, please revert and stop the autoroller
at https://luci-scheduler.appspot.com/jobs/chrome/lacros-version-skew-roller
Also please file a bug to OS>LaCrOS>Partner, and CC [email protected],
[email protected].
[email protected]
Bug: None
Change-Id: I1e913098f6c7b296005151663917de9fbc147861
Requires-Testing: True
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834808
Commit-Queue: Rubber Stamper <[email protected]>
Auto-Submit: chrome-weblayer-builder <chrome-weblayer-builder@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036216}
[anchor-position] Oilpan-ize |NGLogicalAnchorReference|
In order to prepare for supporting anchor-name conflicts.
This patch has no behavior changes.
Bug: 1309178
Change-Id: I472a36ca141e7ceeb4caa58a07385eb9957fefd6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3836612
Auto-Submit: Koji Ishii <[email protected]>
Reviewed-by: Xiaocheng Hu <[email protected]>
Commit-Queue: Xiaocheng Hu <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036215}
Refactor getSearchEngineLogo to return a Promise
This is a bit more natural with the way it's set up and lets us
optimize the common cases where a return value is available
immediately without having two versions of the method.
Bug: 1349486
Change-Id: I3c7c24a2dce78dc89f746a62d6e1fbef1c371fb0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3817468
Commit-Queue: Patrick Noland <[email protected]>
Reviewed-by: Tomasz Wiszkowski <[email protected]>
Reviewed-by: Brandon Wylie <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036214}
Use scoped_refptr instead of raw pointers for two paint property node pointers
This is a speculative fix for the bug.
Bug: 1352642
Change-Id: I65556ac4f279f9e2e18d1db1544cfdb9ab30cbe8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3827860
Reviewed-by: Philip Rogers <[email protected]>
Commit-Queue: Xianzhu Wang <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036213}
[AW] Bugfix for show interstitial page
Bugfix for show interstitial page. Webview network error happens occasionally when it should show an interstitial page.
Bug: 1266683
Change-Id: Ie2ba70418ad38839e4e8aff710c7bc9c210ccb29
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3707579
Commit-Queue: Daniel Rubery <[email protected]>
Reviewed-by: Daniel Rubery <[email protected]>
Auto-Submit: 张浩轩 <[email protected]>
Reviewed-by: Nate Fischer <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036212}
[Discount] Pass a no-discount merchant list from component updater
Bug: 1351534
Change-Id: Ibbb9f340fa205fa2c72a9f2cf7084dc1eaa68a86
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3820131
Reviewed-by: Wei-Yin Chen <[email protected]>
Commit-Queue: Yue Zhang <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036211}
[ntp] Fake promo in PromoService
This way we can test promo dismissal and restore with the fake promo.
Bug: 1003508
Change-Id: I309da3b61f2f97b72df47620f41e0c840848f6aa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834607
Auto-Submit: Tibor Goldschwendt <[email protected]>
Reviewed-by: Paul Adedeji <[email protected]>
Commit-Queue: Tibor Goldschwendt <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036210}
DanglingPtr: fix dangling ptr in v8_context_tracker_internal
Set `execution_context_data_` to nullptr in ~RemoteFrameData() to
avoid holding a dangling ptr.
Bug: 1291138
Change-Id: Ie782d6e9e2e6d022e0b0017c635286f20f4d2965
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3829550
Reviewed-by: Chris Hamilton <[email protected]>
Commit-Queue: Ali Hijazi <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036209}
Add webview flag for IncreasedCmdBufferParseSlice experiment.
Bug: chromium:1336981
Change-Id: I98bc27db31223f4ade5a3878a6515b143e1417f6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832713
Reviewed-by: Sunny Sachanandani <[email protected]>
Commit-Queue: Jonah Ryan-Davis <[email protected]>
Reviewed-by: Nate Fischer <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036208}
[Sync] Suppress NTP promo after the user chooses to not signin in FRE
This CL supresses NTP promo for 24h after the user chooses to not signin
in the FRE.
Bug: 1353777
Change-Id: I2398b7c9d8a3d89efb8ee44ab4fa8b7ce83aa535
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3836434
Commit-Queue: Mahmoud Rashad <[email protected]>
Reviewed-by: Boris Sazonov <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036207}
[ntp] Remove handling of HTML payload from promo
As of crrev.com/c/2366090 Chrome no longer uses the HTML payload; and
the associated code became obsolete.
Bug: 1112992
Change-Id: I02a7e9e1fd8e79862706ba6ec69d0aa5aeca3028
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834769
Auto-Submit: Tibor Goldschwendt <[email protected]>
Reviewed-by: Paul Adedeji <[email protected]>
Commit-Queue: Paul Adedeji <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036206}
Re-enable Fetch + HTTP 308 tests
Now the Apache bug blocking this was fixed/available on bots
long before.
Bug: 451938
Change-Id: I4eff19945fda2a87a63a4ce12c870e43eb25e3e2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3831843
Reviewed-by: Yoichi Osato <[email protected]>
Commit-Queue: Hiroshige Hayashizaki <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036205}
projector: Get Local video duration
Use SafeMediaMetadataParser to retrieve media metadata which contains
duration information, also serve the purpose of video file validation.
Bug: b/205334821
Change-Id: Ib46401df6fb06b6e4d7ef2854e5b7644bc9e3634
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3824541
Commit-Queue: Xiqi Ruan <[email protected]>
Reviewed-by: Toby Huang <[email protected]>
Reviewed-by: Li Lin <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036204}
[iOS] Correct IDS_IOS_CLEAR_BROWSING_DATA_FOOTER_SIGN_OUT_EVERY_WEBSITE
The word Chrome was used even on Chromium and was in lower case
Fixed: 1353766
Change-Id: I78f3d6732f01b2840d8ac303e5e42e74659f7150
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834599
Commit-Queue: Arthur Milchior <[email protected]>
Reviewed-by: Jérôme Lebel <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036203}
Roll Chrome Win32 PGO Profile
Roll Chrome Win32 PGO profile from chrome-win32-main-1660737332-9917a3d02b0f8798fefc802cdaeb0339a71e6073.profdata to chrome-win32-main-1660748343-6d911f54f87af4f82c894289657e08214d69979c.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win-chrome
Tbr: [email protected]
Change-Id: I5dad6bae261d86ec6bb8b6c6876a6b7590775506
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3836652
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036202}
[ios][feed] Remove bg timestamp & default false following feed bg refresh
Change-Id: If5a2f09c5bf7aed2e140bad0c712c8ae6e899dbb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3835267
Commit-Queue: edchin <[email protected]>
Reviewed-by: Sergio Collazos <[email protected]>
Commit-Queue: Sergio Collazos <[email protected]>
Auto-Submit: edchin <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036201}
[MPArch] Introduce GetGuestMainFrame on GuestViewBase.
The installation grants the direct access to the embedded guest's main
RFH, without accessing the inner WebContents at individual call sites.
Bug: 1261928
Change-Id: I3a33428a9ac81ff57811de4e6f5775e99145bb9d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3836452
Commit-Queue: William Liu <[email protected]>
Reviewed-by: Kevin McNee <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036200}
Roll libunwind from 030b4ebf3239 to 12726c93aa00 (1 revision)
https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/030b4ebf3239..12726c93aa00
2022-08-17 [email protected] [compiler-rt][libunwind][runtimes] Recategorize `llvm_check_linker_flag` langs
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/libunwind-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: [email protected],[email protected]
Change-Id: If4884ea96b2b52dd7379897c6a5bc7426f10232c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3835736
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036199}
Fix IWYU in ipc_fuzzer
Fixes missing ipc_platform_file.h include in fuzzer.cc, which is
included indirectly via content/common/all_messages.h, but only when
NaCl or PPAPI are enabled.
Bug: 1306610
Change-Id: I5beb4f053514f4a36f54c218d895798caee6c485
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834413
Commit-Queue: K. Moon <[email protected]>
Reviewed-by: Tom Sepez <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036198}
Reuse the location bar icon for PiP 2.0 window
This is required for us to reuse the permission setting UI from the normal browser.
This allows us to use LocationBarModel and the opener web contents to
display the window title URL too, so that we can remove
picture_in_picture_window_title in browser.h.
Bug: 1346734
Change-Id: Iaccd8b5ae523553e10b0c374410a05285b628e91
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3823701
Commit-Queue: Yiren Wang <[email protected]>
Reviewed-by: Scott Violet <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036197}
[CEX] Remove return type restriction on JS flows
This allows for string and byte return types.
Bug: b/238983486
Change-Id: Iae9f972500d5110562f2db9804c42669ba6187a9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834788
Auto-Submit: Florian Gauger <[email protected]>
Reviewed-by: Carlos IL <[email protected]>
Commit-Queue: Carlos IL <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036196}
Roll Help App from xyX-aFWvcF7WKFzTF... to FiCVNk17K_YUEWVml...
Release_Notes: http://go/help_app-x20/relnotes/Main/help_app_nightly_202208170800_RC00.html
https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/help_app/app/+/FiCVNk17K_YUEWVml6GtxHXnAuVr7KHhJ2oC-SY5k-QC
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/help-app-chromium-autoroll
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: [email protected]
Change-Id: I64f95512d1082d91116798524f08fa26620c99b7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3835735
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1036195}
Add mojo struct to hold public First-Party Sets data.
This struct will be extended in the future, to carry ccTLD data in
addition to the sets themselves.
Bug: 1349781
Change-Id: Id18021b797ead8e8995f9863a49ba7902bd4d5f4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3833499
Reviewed-by: Maks Orlovich <[email protected]>
Reviewed-by: Alex Gough <[email protected]>
Reviewed-by: Matt Reichhoff <[email protected]>
Commit-Queue: Chris Fredrickson <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036194}
Switch to secure state restoration serialization
New in macOS 12 is the API
-[NSApplicationDelegate applicationSupportsSecureRestorableState:]
which asks state restoration to use secure serialization when saving
restorable state. In the general case, it has to be opt-in because
app code might serialize its own data, and requiring the app to opt
in is a verification that anything that it might include in the
state also supports NSSecureCoding.
However, Chromium overrides the restorable state APIs to save its own
copy of the restorable state. Therefore, not only does this CL enable
that new NSApplicationDelegate API, but it also uses secure
serialization for its private copy. There will be a one-time failure
when the last non-secure archive is deserialized, but that will be low
impact as the only state that Chromium relies on this mechanism for
is window space restoration. Losing the window space information
during one restoration is unfortunate, but overall that is low-impact
and enables the closing of an attack vector [1].
(As an aside, Chromium did not participate in saving optional
restoration data, as it has its own restoration mechanism, so no work
was needed to adopt NSSecureCoding.)
As a bonus, all the non-secure serialization APIs are marked
deprecated in 10.14, so this also serves as a deprecation cleanup
ahead of the 10.14 removal coming next year.
[1] https://sector7.computest.nl/post/2022-08-process-injection-breaking-all-macos-security-layers-with-a-single-vulnerability/
Fixed: 1353039
Change-Id: Ie30e5109a6985b8da390450b72a8459b0a2501b6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832503
Commit-Queue: Avi Drissman <[email protected]>
Reviewed-by: Leonard Grey <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036193}
[CodeHealth] Removing a few base::Value conversions
This CL does some small clean up on base::Value conversions that are not
needed anymore, since JS runtime functions now take a base::ValueView.
Bug: 1187001
Change-Id: I25db8de4aabc3887d9707db11b62cb4c86aca947
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3829693
Reviewed-by: Ted Choc <[email protected]>
Reviewed-by: Giovanni Ortuno Urquidi <[email protected]>
Commit-Queue: Claudio DeSouza <[email protected]>
Reviewed-by: Mike Dougherty <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036192}
CRAS: Remove deprecated device runtime metrics
The metrics Cras.InputDevice*Runtime and Cras.OutputDevice*Runtime has
been replaced with Cras.DeviceRuntime*. Remove deprecated metrics in
this CL.
CRAS side change crrev.com/c/3575896
BUG=b:222388074
Change-Id: Ie140de7c2cff27c2c2c8aba2b8ddb70474994cd6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834222
Commit-Queue: Yu-Hsuan Hsu <[email protected]>
Reviewed-by: Mark Pearson <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036191}
Reland "[Cleanup] Delete old-gen and rename file to "structured_events"."
This is a reland of commit cafd7edfbf6fb4347ac9e1b62ec9d2feaab9736e
Original change's description:
> [Cleanup] Delete old-gen and rename file to "structured_events".
>
> Bug: 1249222
> Change-Id: I5a48cd57db05c13a137825a1e036a8fd4bee6e97
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3827385
> Reviewed-by: Tony Yeoman <[email protected]>
> Commit-Queue: Jong Ahn <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1035291}
Bug: 1249222
Change-Id: Ice70f72d3f6f32421fa9049e16cd5d4bc1fe388d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834383
Reviewed-by: Tony Yeoman <[email protected]>
Commit-Queue: Jong Ahn <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036190}
Refactor autofill to use PrefService::GetValueDict
This is part of a larger migration effort based on
go/trust-your-prefs.
Bug: 1341996
Test: Existing unit tests
Change-Id: I32c4d77545bc1ad66c2b197461ed0ff0710fe066
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3826304
Commit-Queue: Roland Bock <[email protected]>
Reviewed-by: Christoph Schwering <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036189}
Lacros: Fix icon assignment on new app tab
This CL fixes the way in which Lacros windows are assigned an icon when
an app opens a tab in a Lacros browser window. Previously, we allowed
for BrowserAppShelfItemController::OnBrowserAppAdded to change the icon
of a Lacros window when an app added a tab to the window. This CL fixes
that by having the function check if the type of the browser instance is
a kAppTab. If so, it skips assigning the app's icon to the browser
window.
Bug: 1344699
Change-Id: Iabb66b5c10ecdb1b522f156eb3e41411645b2dc8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832636
Reviewed-by: Alexander Bolodurin <[email protected]>
Commit-Queue: Ben Becker <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036188}
Fixed an NPE when downloading offline page
BUG=1353102
Change-Id: I48b29d46384ad8e21a0764d8e1669b77df6a4076
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832704
Reviewed-by: David Trainor <[email protected]>
Commit-Queue: Min Qin <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036187}
[site data] Get origins to display as rows in the dialog
Using CookiesTreeModel, get all origins that have access to site data or were blocked from accessing it. Using origins, build "From this site" and "From other sites" sections. The sections consist of a title, a subtitle and a list of SiteDataRowView. Each row represents one origin.
Bug: 1344787
Change-Id: If34923eb0ed7f687ffb21b4c5930cf5156549248
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834117
Reviewed-by: Theodore Olsauskas-Warren <[email protected]>
Commit-Queue: Olesia Marukhno <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036186}
sheriff: disable NoTrustedTypesViolation for chrome://sandbox
Bug: 1353819
Change-Id: Ic1f4f8a299aea654db478dc0bc2c11c6435c91af
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3836276
Auto-Submit: Elly Fong-Jones <[email protected]>
Owners-Override: Elly Fong-Jones <[email protected]>
Commit-Queue: Elly Fong-Jones <[email protected]>
Reviewed-by: Peter Boström <[email protected]>
Commit-Queue: Peter Boström <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036185}
win: use IsShortcutpinnedToTaskbar
Use IPinnedList3::IsPinned in
IsPinnedToTaskbarHelper::DirectoryContainsPinnedShortcutForProgram
and if that's not supported (pre WIN10_RS5), fall back to the expensive
and crashy unpin verb check.
Bug: 1094395
Change-Id: Icbbdf8ee14805e2fa14e4636a00fc56125de4671
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3828512
Reviewed-by: Ken Rockot <[email protected]>
Commit-Queue: David Bienvenu <[email protected]>
Reviewed-by: Greg Thompson <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036184}
[Cormorant] Setup Cormorant flag for Android testing
Bug: 1351159
Change-Id: I2a9d9661623215e6a33465d2aa39e0612310defd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3829090
Reviewed-by: Jeffrey Cohen <[email protected]>
Commit-Queue: Wissem Gamra <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036183}
Add documentation to WaylandEventSource::keyboard_modifiers_
Bug: 1352618
Change-Id: If25343ae611135b11b51fa7f931890b7dea57bca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3831892
Reviewed-by: Kramer Ge <[email protected]>
Commit-Queue: Erik Chen <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036182}
Adding a return
Just adding a missing return
Change-Id: I3b15dc6979565bdded8c9bdffcd6ad80a56812ee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832521
Auto-Submit: Alex Newcomer <[email protected]>
Reviewed-by: Andre Le <[email protected]>
Commit-Queue: Alex Newcomer <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036181}
Import wpt@66822d47ddfad11ff8309223fca177274ff0dae6
Using wpt-import in Chromium 39dc52d448aebd5013ac77960416ac13982a806b.
With Chromium commits locally applied on WPT:
951ec645d7 "Fallback to a main thread animation if background color animation affected by blur"
Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md
NOAUTOREVERT=true
[email protected]
No-Export: true
Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-input-fyi-rel,linux-blink-rel
Change-Id: I5b0a4ccd9a41f4e81aec5f2234f9d72cc5599253
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3835643
Auto-Submit: WPT Autoroller <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036180}
fido/mac: fix a bug in keychain item handling
CL:3781120 changed the data persisted into the kSecAttrApplicationTag
attribute for new credentials. Prior to that change, and up to
CredentialMetadata version 2, the field contained an encoding of (RP ID,
user ID); the CL makes that field store the encrypted metadata. Another
thing that CL changed was the data type of the stored value, from
CFStringRef to CFDataRef (because the official keychain docs say it
should be CFDataRef:
https://developer.apple.com/documentation/security/ksecattrapplicationtag?language=objc#:~:text=The%20corresponding%20value%20is%20of%20type%20CFDataRef%20and%20contains%20private%20tag%20data).
However, TouchIdCredentialStore::FindCredentialsImpl() expected all
query keychain items to contain CFDataRef, and returned absl::nullopt if
that wasn't true. This made credential lookups in the Touch ID
authenticator fail in the presence of older (version < 3) credentials
for the given RP.
To fix this, change TouchIdCredentialStore::FindCredentialsImpl() to not
bail entirely if kSecAttrApplicationTag doesn't contain the expected
type.
An existing test in CredentialStoreTest would have caught this issue, if
it hadn't been for a test bug where creating a legacy credential
mistakenly created a V3 credential. So this fix that bug as well.
Fixed: 1353101
Change-Id: I6cc04e84c1a011b5db1eed96734792fa9cd8aa4a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832144
Reviewed-by: Adam Langley <[email protected]>
Commit-Queue: Adam Langley <[email protected]>
Auto-Submit: Martin Kreichgauer <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036179}
Roll Skia from 86b5bf11ddfa to 4b720a135d0d (4 revisions)
https://skia.googlesource.com/skia.git/+log/86b5bf11ddfa..4b720a135d0d
2022-08-17 [email protected] Revert "Raster Pipeline: Use clang::musttail when possible"
2022-08-17 [email protected] [graphite] Add DrawBufferManager::getSsboWriter
2022-08-17 [email protected] Add ability to update SkMesh vertex and index buffers.
2022-08-17 [email protected] Reland "Replace StrikeRefs with SkStrikePromises"
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Cq-Do-Not-Cancel-Tryjobs: true
Bug: None
Tbr: [email protected]
Change-Id: Iae85000744979b41dcd22645321dc053c027f001
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3836356
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036178}
Add side panel resize metrics
Includes, per side panel type and overall, metrics for both the width of
the side panel after resize and the width as a percentage of browser
width. Also records actions for resize, per side panel type and overall.
"After resize" is measured either on unfocus, for keyboard resize
events, or on mouse up for drag to resize events.
Bug: 1351178
Change-Id: Ideca355cfe80677e7fcfb35e060db8a3ae5f8a9b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3831823
Reviewed-by: Weilun Shi <[email protected]>
Reviewed-by: Caroline Rising <[email protected]>
Commit-Queue: Emily Shack <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036177}
[Lacros] Observer for device setting updates
This change adds observers for device setting updates in Lacros. This
will enable components to listen for updates to device settings and act
on these updates right away. This will also enable our metrics reporting
pipeline to enable/disable metric collection and/or reporting like we do
in Ash today.
Bug: b:241486730
Change-Id: I6eb59186f1ca26730b7d67b87391f98f25025817
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3827487
Reviewed-by: Nicolas Dossou-Gbété <[email protected]>
Reviewed-by: Erik Chen <[email protected]>
Commit-Queue: Vignesh Shenvi <[email protected]>
Reviewed-by: Leonid Baraz <[email protected]>
Reviewed-by: Igor <[email protected]>
Reviewed-by: Ahmed Nasr <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036176}
Roll src-internal from b2beda591ad4 to f0e9eeb81399 (1 revision)
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b2beda591ad4..f0e9eeb81399
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: chromium:1324889
Tbr: [email protected]
Change-Id: Iff32a89fc3db2d3dff69f7a46a0e737640b989b8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3835774
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1036175}
Update favicon when size does not change.
Bug: 1352674
Change-Id: I4f241b4484252198705ae8425858ddf9c10e9f0b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3829500
Reviewed-by: Yaron Friedman <[email protected]>
Commit-Queue: Sky Malice <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036174}
[Omnibox] Add a parameter to control showing new UI for tablets
Add a new marameter enable_modernize_visual_update_on_tablet for the
flag OMNIBOX_MODERNIZE_VISUAL_UPDATE. So we can control that only
showing the new UI on the phone, or tablets as well.
Bug: 1348445
Change-Id: I618a719dbe9df27f1098bf314ca11e2293d8364c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3833535
Commit-Queue: Gang Wu <[email protected]>
Reviewed-by: Tomasz Wiszkowski <[email protected]>
Reviewed-by: Theresa Sullivan <[email protected]>
Reviewed-by: Sirisha Kavuluru <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036173}
Update SAA Permission Policy
With the update of the SAA spec and resolution of
https://github.com/privacycg/storage-access/issues/104 this change
updates the in-code permission policy from `storage-access-api` to
`storage-access`.
Bug: 1332577
Change-Id: Ic07185b8d9e9d456d20aaee418af8b495574940b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3830029
Reviewed-by: Nicolas Arciniega <[email protected]>
Reviewed-by: Mike West <[email protected]>
Commit-Queue: Brandon Maslen <[email protected]>
Reviewed-by: Chris Fredrickson <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036172}
sheriff: mark mouseenter-mouseleave-on-drag flaky under scroll unification
Bug: 1342623
Change-Id: I75d2d4d1fab9618ba6b1466feb4b8a659ca3975e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834778
Auto-Submit: Elly Fong-Jones <[email protected]>
Reviewed-by: Jeffrey Cohen <[email protected]>
Commit-Queue: Jeffrey Cohen <[email protected]>
Commit-Queue: Elly Fong-Jones <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036171}
Roll Perfetto Trace Processor Mac from 8ab7cdc76e49 to 3960394cdf24
https://android.googlesource.com/platform/external/perfetto.git/+log/8ab7cdc76e49..3960394cdf24
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: [email protected]
Change-Id: Ifa4c0d265d3385d526a15502e74d8d186d12fee2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834423
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036170}
[Cast2Class] Disable AccessCodeCastDialogBrowsertest
Disable AccessCodeCastDialogBrowsertest while investigating the cause
of failures.
Bug: b/242863470
Change-Id: I7555718c065c9612f70fff3a8749f2e22eebdf01
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3828157
Commit-Queue: Benjamin Zielinski <[email protected]>
Reviewed-by: George Benz <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036169}
[ozone/wayland] Unify WaylandEventSource::TouchFrame and PointerFrame
BUG=1351376
[email protected]
Change-Id: I3b31dff5394bfb7b0bad6455ad3afb713a338c34
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3829802
Reviewed-by: Nick Yamane <[email protected]>
Commit-Queue: Nick Yamane <[email protected]>
Auto-Submit: Antonio Gomes <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036168}
Deflake pointerevent_boundary_events_in_capturing.html
The test was expecting at least two pointermove events from a drag
gesture. When MT is slow, those pointermove events can be coalesced
into a single one. Rewrote the test to remove the assumption, now
either a pointermove or a pointerup completes the required checks.
Also switched the test to use promise_test and a simpler action/event
sequencing for better readablity.
Fixed: 1289232
Change-Id: I3a0dcb52a814fd21cce54e8a5ab6af3ed077be5b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3824442
Reviewed-by: Robert Flack <[email protected]>
Commit-Queue: Mustaq Ahmed <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036167}
Change PROXY_TABS debug string from "Tabs" to "Proxy tabs"
This only affects error logs and chrome://sync-internals.
Change this, otherwise it's super confusing to look at
chrome://sync-internals and see both "Sessions" and "Tabs".
Bug: None
Change-Id: If92d6f7821680221a0309f9b291b8c567a0cf21e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834385
Commit-Queue: Victor Vianna <[email protected]>
Commit-Queue: Marc Treib <[email protected]>
Reviewed-by: Marc Treib <[email protected]>
Auto-Submit: Victor Vianna <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036166}
Add a way to regenerate golden file for web app serialization.
This CL adds automatic rebaselining capabilities to WebAppTest unit tests that compare sample WebApps to golden JSON debug value expectations. Previously updating the expectation manually was unmanageable due to the size of the JSON expectation string.
In order to regenerate expectation, one can run:
```
autoninja -C out/Default unit_tests && out/Default/unit_tests --gtest_filter="WebAppTest.*" --rebaseline-web-app-expectations
```
The output looks like this:
```
[1073384:1073384:INFO:web_app_unittest.cc(281)] Generating expectations sample web app unit test in web_apps/sample_web_app.json
[1073384:1073384:INFO:web_app_unittest.cc(246)] No new content is generated for web_apps/sample_web_app.json
```
Bug: 1333966
Change-Id: Idb4fcb648568224b27827f27ff2b8aac2c734b09
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3826425
Reviewed-by: Alan Cutter <[email protected]>
Auto-Submit: Dmitrii Kuragin <[email protected]>
Commit-Queue: Dmitrii Kuragin <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036165}
IDB: Add estade@ as owner
Change-Id: If4b68ebafe0e4a918dba506b9942c8d626c9b0a5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3827355
Reviewed-by: Evan Stade <[email protected]>
Commit-Queue: Evan Stade <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036164}
Move to SSD and increase cores to 16 for android-pie-x86-rel.
android-pie-x86-rel has frequent infra failures because of timeout.
The "compile" time inflates over the time. Move to SSD with more cores would speed up the "compile" step.
The requested resource has been deployed in:
https://chrome-internal-review.googlesource.com/c/infradata/config/+/4929971
Bug: 1344689
Change-Id: Ia69a185256fe6ed2a2bcfbb315775f297fb029e8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834771
Commit-Queue: James Shen <[email protected]>
Reviewed-by: Ben Pastene <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036163}
[exo] Apply min/max constraints to the requested buffer size.
This is reland of crrev.com/c/3827939. PS2 has a memory fix.
Currently exo's xdg-shell impl doesn't apply the min/max size
constraints when the buffer size is updated. This spec isn't clearly
specified, but looks like some X11 apps depends on X11's WM manager
oo change its size. This CL updates the size so that it will satisfy
the condition.
Bug: 1330028, b/207430591
Test: Covered by unittests. Also tested using win.c in 133028.Fix
Change-Id: Iae9a6fa998e25222571845a83a3d061049e4ee17
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3833508
Reviewed-by: Chloe Pelling <[email protected]>
Auto-Submit: Mitsuru Oshima <[email protected]>
Commit-Queue: Mitsuru Oshima <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036162}
Update SAA Flag and Histogram Expirations
The about:flags and histograms for the SAA have been
updated to expire at a date in the future.
Bug: 1138391
Change-Id: I1da81120638f69095617a1e77ba84e211bdfa010
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3828308
Reviewed-by: Nicolas Arciniega <[email protected]>
Reviewed-by: Chris Fredrickson <[email protected]>
Reviewed-by: Mike West <[email protected]>
Reviewed-by: Ayu Ishii <[email protected]>
Commit-Queue: Brandon Maslen <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036161}
History Sync: Add more proto fields
This CL adds most of the remaining proto fields to HistorySpecifics -
namely, browser_type, window/tab_id, [parent_|root_]task_id,
page_language, and password_state.
This required moving the PasswordState enum from
session_specifics.proto to sync_enums.proto, and a few resulting
changes in sessions code.
The fields aren't populated or used yet; that's left for followup CLs.
Bug: 1347012
Change-Id: I534317e9fe6924e2720650bc28b0fbe16f7a8d38
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834790
Reviewed-by: Victor Vianna <[email protected]>
Commit-Queue: Marc Treib <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036160}
Roll Chromite from 2db7368ba02c to b6181b487cea (10 revisions)
https://chromium.googlesource.com/chromiumos/chromite.git/+log/2db7368ba02c..b6181b487cea
2022-08-17 [email protected] contrib: portage_explorer: Spider gets ebuild data
2022-08-17 [email protected] scripts: Improve output formatting in linting CLI
2022-08-17 [email protected] api: controller: Add more spider data to output
2022-08-16 [email protected] cli: cros_chrome_sdk: Set up Arm32 Nacl toolchain variables
2022-08-16 [email protected] Revert "binhosts: Dedup binpkg uploads."
2022-08-16 [email protected] binhosts: Dedup binpkg uploads.
2022-08-16 [email protected] cros-ide: Show the content of a json file from gerrit API using https API
2022-08-16 [email protected] cros-ide: run npm install
2022-08-16 [email protected] Automated Commit: Updated config generated by config-updater builder.
2022-08-16 [email protected] cros-ide: remove redundant newline from ConsoleOutputChannel output
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromite-chromium-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel
Tbr: [email protected],[email protected]
Change-Id: I5487a05e0972a100f8d39fde381f43c93b35ddac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834979
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Reviewed-by: Toby Huang <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036159}
[A11y Settings Revamp] Fix Switch Access back navigation to parent page
Fix Switch Access settings subpage back button to correctly navigate to
parent page.
Bug: 1292142
Change-Id: Id1931e834176ea827ed36a44d496c886dd7421c5
AX-Relnotes: Updates to Chrome OS Accessibility Settings to make accessibility options simpler / easier to use.
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832958
Auto-Submit: Josiah Krutz <[email protected]>
Reviewed-by: Jimmy Gong <[email protected]>
Reviewed-by: Katie Dektar <[email protected]>
Commit-Queue: Jimmy Gong <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036158}
Reland "Roll androidx and Adding android system jar to robolectric tests"
This reverts commit 5bdf30da8efcfd33a34e9644421128b02b5ea99b.
Reason for reland: FYI bot needs attention, but other bots seem fine.
Original change's description:
> Revert "Roll androidx and Adding android system jar to robolectric tests"
>
> This reverts commit 7a4401c7ea98c54a06080317e8a7066d221e43cb.
>
> Reason for revert: Fails CI due to missing classpath https://luci-milo.appspot.com/ui/p/chromium/builders/ci/Android%20FYI%20Release%20(Pixel%206)/2532/overview
>
> Original change's description:
> > Roll androidx and Adding android system jar to robolectric tests
> >
> > This is a reland of "Roll androidx from gAsD4l8Eo... to ZYh4te5k8..."
> > commit b94b8d853cfc36b65ab08b2bd2f3816019430b33
> >
> > We now add in the android system jar to all robolectric classpaths, so
> > that when we start using newer SDKs than robolectric supports,
> > robolectric will be able to resolve these new classes without failing.
> >
> > Bug: 1350963
> > Change-Id: I5cb4f4db80c8e0c5f6bedb244532ca9d9ab85325
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3817588
> > Reviewed-by: Andrew Grieve <[email protected]>
> > Commit-Queue: Peter Wen <[email protected]>
> > Commit-Queue: Andrew Grieve <[email protected]>
> > Auto-Submit: Sam Maier <[email protected]>
> > Reviewed-by: Peter Wen <[email protected]>
> > Cr-Commit-Position: refs/heads/main@{#1033130}
>
> Bug: 1350963
> Change-Id: I4dafe113f3e99ff1f60314ba3afdbbec98699a94
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3823044
> Bot-Commit: Rubber Stamper <[email protected]>
> Commit-Queue: Peter Wen <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1033491}
Bug: 1350963, 1352202
Change-Id: I12b242d5731266e51d55fbeabb3494bef0b11665
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832971
Bot-Commit: Rubber Stamper <[email protected]>
Commit-Queue: Andrew Grieve <[email protected]>
Reviewed-by: Peter Wen <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036157}
Add DIR_METADATA for lacros.
Bug: 1349169
Change-Id: I9f5eec3258b862dc5f8744235b2a5d6801da699a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3823149
Reviewed-by: Jenny Zhang <[email protected]>
Commit-Queue: Erik Chen <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036156}
[Start] Clean up field trial testing config for ChromeStart.
Bug: 1181923
Change-Id: I01f27b41cbb09f673920f7738ad8b43fa6a279fe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834291
Reviewed-by: Hao Dong <[email protected]>
Commit-Queue: Xi Han <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036155}
Roll SwiftShader from 5ac9bd16c803 to ab4bf6ad00d4 (1 revision)
https://swiftshader.googlesource.com/SwiftShader.git/+log/5ac9bd16c803..ab4bf6ad00d4
2022-08-17 [email protected] Ignore VK_INSTANCE_CREATE_ENUMERATE_PORTABILITY_BIT_KHR
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-chromium-autoroll
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86
Bug: None
Tbr: [email protected]
Change-Id: I00bd3712e74bd718917f63c33e86693c7cc04d4b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3836322
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036154}
Update RLZ brand codes map for M105+
[email protected]
Bug: 1353393
Change-Id: I62de2890b862362691c4c35f0d332276802ee9b6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3835089
Commit-Queue: Peter Kasting <[email protected]>
Auto-Submit: Stephen Lin <[email protected]>
Reviewed-by: Peter Kasting <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036153}
Remove [email protected] from chrome/browser/ash/login/enrollment/OWNERS.
This suggested change is automatically generated based on group memberships and affiliations.
If this change is unnecessary or in error, vote CR -1 and the bot will abandon it. Vote CR +1/2 to approve this change.
See the owner's recent activity for context: https://chromium-review.googlesource.com/q/[email protected]
To report an issue, file a bug in the Infra>Security component.
Change-Id: Icf5b5e9910230e6382c467a5dff13cd42a9d0d9e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834052
Reviewed-by: Maksim Ivanov <[email protected]>
Commit-Queue: Amr Aboelkher <[email protected]>
Auto-Submit: Owners Cleanup <swarming-tasks@owners-cleanup-prod.google.com.iam.gserviceaccount.com>
Reviewed-by: Amr Aboelkher <[email protected]>
Commit-Queue: Maksim Ivanov <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036152}
[CodeHealth] AssistantOptInFlowScreenHandler CallJS fixes
This CL fixes the way CallJS is being called with
AssistantOptInFlowScreenHandler, to reduce the number of member value
copies, as well as to make it less verbose.
Bug: 1187001
Change-Id: I76907f247a233f87796bba1dc79e63080099a3fc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3829534
Reviewed-by: Xiyuan Xia <[email protected]>
Commit-Queue: Claudio DeSouza <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036151}
[BrowserFragment] Update lifetime of WebLayer objects
- BrowserImpl is only created once per fragment.
- BrowserImpl gets destroyed after the ViewModel is cleared.
This ensures that the WebLayer internals are not re-created all the
time, and are available to resume the fragment state immediately while
it is still valid.
Change-Id: I620f9ca08fdfdef05538aafbf1a6e97d78fc9a88
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3819685
Commit-Queue: Rayan Kanso <[email protected]>
Reviewed-by: Clark DuVall <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036150}
Allow all committers to modify Experimental Settings
This CL is needed to allow all committers to modify Experimental.plist
or other experimental flag files.
Change-Id: I6984962ef6b8f1c77df8fd624cfd14ca36d1c4e5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3833395
Auto-Submit: edchin <[email protected]>
Reviewed-by: Sergio Collazos <[email protected]>
Commit-Queue: Rohit Rao <[email protected]>
Reviewed-by: Rohit Rao <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036149}
Pass composed favicon urls back to Java.
Previously the composed JNI path had a icon URL field that was never
set. This change switched that to an array of GURLs, and sets them.
Bug: 1351477
Change-Id: If3374d2e674cacf8ce6d711ab9955781746d936f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3827412
Commit-Queue: Sky Malice <[email protected]>
Reviewed-by: Mei Liang <[email protected]>
Reviewed-by: Peter Kotwicz <[email protected]>
Reviewed-by: Yaron Friedman <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036148}
Call AsyncActionTakenInMainFrameCallback for External Nav Message
I missed calling this callback when implementing the Message for
blocked external navigations. This will align behavior with what
happens when the Message isn't shown in terms of when non-committed
pages are closed and in terms of metrics.
Bug: 1333890
Change-Id: I244452e0dadd06b18db25aa1e219b6729758efbc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3831250
Reviewed-by: Yaron Friedman <[email protected]>
Commit-Queue: Michael Thiessen <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036147}
[Signin] Add Signin Intercept feature flags to chrome://flags
Bug: 1282157
Change-Id: I6a098cfb3d34a3ab4250ae263097123304cabf8e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834176
Commit-Queue: Gabriel Oliveira <[email protected]>
Reviewed-by: Alex Ilin <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036146}
[iOS] Change pipes to backticks in /ios/chrome/browser/download/background_service
Please review the CL to ensure that nothing is broken and the script
didn't miss some pipes.
This should allow us to have a better formatting in Xcode.
This CL was uploaded by git cl split.
[email protected]
Bug: 1311955
Change-Id: I5e569311bce8f52c7328a75cae106ce9a6014f55
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834582
Auto-Submit: Gauthier Ambard <[email protected]>
Reviewed-by: David Trainor <[email protected]>
Commit-Queue: Gauthier Ambard <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036145}
Roll Chrome Win64 PGO Profile
Roll Chrome Win64 PGO profile from chrome-win64-main-1660715759-32335aa14e4dc81c7277e1369dfd8ca35b9c8069.profdata to chrome-win64-main-1660737332-c1b32cf9ce20774d9bc94b435a8489360520618f.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win64-chrome
Tbr: [email protected]
Change-Id: I586a6cb4da88586d1cd027f55aecf33ed721601e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3835140
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036144}
Reland 'Update dialog height without footnote'
Reason for Reland: The test AccessCodeCastDialogBrowserTest.InvokeUi_default is flaky and should have failed in the dry run but actually passed.
Bug: b/238244922
Change-Id: I9fe27026b90dc2ad9f135eb195d02bf685341899
Screenshot: https://screenshot.googleplex.com/8EdCAVivHuUFnvJ.png
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834845
Commit-Queue: Luke Cao <[email protected]>
Reviewed-by: Benjamin Zielinski <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036143}
R8: Fix conflict in 3pp patches
Bug: 1353798
Change-Id: Ib21692578d5310715a759c340fac3cb3d6ab8e04
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3828158
Auto-Submit: Andrew Grieve <[email protected]>
Reviewed-by: Peter Wen <[email protected]>
Commit-Queue: Peter Wen <[email protected]>
Commit-Queue: Andrew Grieve <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036142}
GCC: avoid symbol clash in scoped feature list PassKey alias
Bug: 819294
Change-Id: I53bd4dbe059fed6d6dccdabeb3425aab2aa04b75
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3835426
Commit-Queue: José Dapena Paz <[email protected]>
Reviewed-by: Caitlin Fischer <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036141}
[APC Desktop] Only show separator if there are non-empty buttons.
The separator line should only be shown if there is at least one
button with text on it.
Current, incorrect separator line:
https://screenshot.googleplex.com/4VPkLm3qAkvoQVV
Bug: 1331202
Change-Id: Ifef1730574b1fa6cc13f54b1df61a62df5b91867
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3836393
Reviewed-by: Norge Vizcay <[email protected]>
Commit-Queue: Jan Keitel <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036140}
Add views::Builder support for ash::PillButton
We need a PillButton in the new notification center
and will be using views::Builder to create it.
Bug: 1311738
Change-Id: I4ef039b8085105c684854cd0378727bd9e27c291
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3829783
Reviewed-by: Xiyuan Xia <[email protected]>
Commit-Queue: Ahmed Mehfooz <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036139}
Registration for Device Management
This CL uses a common task for DM device registration and policy fetch.
Bug: 1345407
Change-Id: Ibe645f693ebdd97c8590993f5b95f7c793051119
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834175
Commit-Queue: S Ganesh <[email protected]>
Reviewed-by: Xiaoling Bao <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036138}
[Chromecast] Keep screen on if requested.
Some apps don't keep the screen on themselves when they should. This
change will allow apps to be configured to keep the screen on all the
time.
Bug: internal b/241153453
Test: junit tests, check dumpsys
Change-Id: I4fb71f3bd55ce972dbca76e89dd5d41237a9afe5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3835142
Reviewed-by: Simeon Anfinrud <[email protected]>
Commit-Queue: Thoren Paulson <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036137}
[Tracing] Hook up Perfetto client library startup tracing in Chrome
This CL enables startup tracing in Perfetto client library build.
It uses a recently introduced API to start tracing into a shared
memory buffer before a connection to the trace service is established.
Note that it still requires a thread pool to be available, so we start
startup tracing later than in non-client library build. Starting
tracing even earlier will require moving all Perfetto tasks to a
separate thread. This will be a subject of a subsequent change.
Change-Id: Ie5d951a8706e43567c53df611bd24271d2e7de21
Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3762466
Reviewed-by: Sami Kyöstilä <[email protected]>
Commit-Queue: Mikhail Khokhlov <[email protected]>
Reviewed-by: Andrey Kosyakov <[email protected]>
Reviewed-by: Eric Seckler <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036136}
Roll RTS model from eXuajLr_13p-4rXI2... to dem8jpLGDhB7uQjgE...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/rts-linux-amd64-chromium-autoroll
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: [email protected]
Change-Id: Ic0263b38507af9e1aa78cbc2fc8e9ed681c6c5bc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3836328
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036135}
Extract CertVerifierBuiltin and ChromeRootStore feature/policy browser tests
In https://crrev.com/c/3759632 the tests ProfileNetworkContextServiceCertVerifierBuiltinPermissionsPolicyTest and
ProfileNetworkContextServiceChromeRootStorePermissionsPolicyTest were changed to check the cert verifiers created during browser startup, so that test actually checks both the system and profile network contexts now.
Extract those to a new file, and remove the now redundant tests SystemNetworkContextServiceCertVerifierBuiltinPermissionsPolicyTest and
SystemNetworkContextServiceChromeRootStorePermissionsPolicyTest.
Bug: 1352171
Change-Id: Ibb04a7dc7a6f13fee3605f454be326e686f80fbf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834508
Reviewed-by: Hubert Chao <[email protected]>
Commit-Queue: Matt Mueller <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036134}
Create Promo class.
This change creates a base Promo class, enabling: 1. Simple
organization, access, and manipulation of promo-related data, like
impression limits. 2. Feature teams to extend and (optionally)
implement methods for customizing promo behavior.
This change is mostly class scaffolding, as the Promo class will grow in
subsequent CLs.
Change-Id: I17bbcb32547086fdfbe9f0318c4b24d389d5988d
Bug: 1353112
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3831890
Commit-Queue: Benjamin Williams <[email protected]>
Reviewed-by: Sebastien Seguin-Gagnon <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036133}
[skylab_tests] Update skylab tests cros img version
This CL will update cros image version for skylab tests. CROS_BOARD_LKGM
is updated according to chromeos/CHROMEOS_LKGM; CROS_BOARD_DEV,
CROS_BOARD_BETA and CROS_BOARD_STABLE are updated according to Omaha.
If this CL caused regressions, please revert and pause the autoroller at
https://luci-scheduler.appspot.com/jobs/chrome/lacros-skylab-tests-cros-img-roller
Also please file a bug to OS>LaCrOS>Partner, and CC [email protected],
[email protected].
[email protected]
Cq-Include-Trybots: luci.chrome.try:lacros-amd64-generic-chrome-skylab
Requires-Testing: True
Change-Id: I961405c3c220f9c328b9f51ce92a5410cd7ccefa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834806
Auto-Submit: skylab-test-cros-roller@chops-service-accounts.iam.gserviceaccount.com <skylab-test-cros-roller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036132}
Unify `AndroidPlatformConfiguration::GetChildProcessEnableFraction` with
`DefaultPlatformConfiguration::GetChildProcessEnableFraction`, thereby
enabling profiling for the network service on Android.
Bug: 1326430
Change-Id: I8e661e22a481c5854f7cd08d8d6edee1e4145bc7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3748657
Auto-Submit: Tushar Agarwal <[email protected]>
Reviewed-by: Mike Wittman <[email protected]>
Commit-Queue: Tushar Agarwal <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036131}
[iOS] Log metrics for Following feed sort type
Logs histogram with the current sort type whenever a user engages with
the Following feed. Uses prefService since NTPCoordinator is stopped by
the time this is needed.
Logs user action whenever a user selects a new sort type from the feed
header menu.
Change-Id: Ic777453debd6ad31d7b10053a65193b8b0df8773
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3826127
Reviewed-by: Dan H <[email protected]>
Reviewed-by: Robert Kaplow <[email protected]>
Commit-Queue: Adam Arcaro <[email protected]>
Reviewed-by: Sergio Collazos <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036130}
Remove unnecessary header inclusion.
Change-Id: I15cc836d7880899ae0131951ade0a0a3890c02d8
Bug: b/231934478
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3836333
Commit-Queue: Tushar Agarwal <[email protected]>
Auto-Submit: Tushar Agarwal <[email protected]>
Reviewed-by: Mike Wittman <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036129}
Align open in new tab button with results in LRP.
Without this fix: https://screenshot.googleplex.com/3DBYJNqvGLaE3Rx.png
With this fix: https://screenshot.googleplex.com/B9n5VrJQrF6FxrD.png
Bug: b/242861142
Change-Id: I1cd66efea98060eaff464c6c6473688b00c7af4b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3829316
Reviewed-by: Thomas Lukaszewicz <[email protected]>
Reviewed-by: Ali Stanfield <[email protected]>
Commit-Queue: Anudeep Palanki <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036128}
Roll RTS model from 7BoYCZFP7DHtgBj2x... to KV4QPYI4VnwiZw1JN...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/rts-mac-amd64-chromium-autoroll
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: [email protected]
Change-Id: I3745c4233d068644adf7785421f6a60994ba570f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3836327
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036127}
add chrome.loadTimes API use counters to UKM. These are deprecating features, for which we want to find the specific pages who still using them and do outreaches.
All feature usage are below 1%.
Use counts of page loads measured by UMA:
(data from last 24 hours on Aug.10 2022)
ChromeLoadTimesCommitLoadTime
0.0059%
ChromeLoadTimesConnectionInfo
0.0587%
ChromeLoadTimesFinishDocumentLoadTime
0.0059%
ChromeLoadTimesFinishLoadTime
0.0059%
ChromeLoadTimesFirstPaintAfterLoadTime
0.0757%
ChromeLoadTimesFirstPaintTime
0.4146%
ChromeLoadTimesNavigationType
0.1894%
ChromeLoadTimesNpnNegotiatedProtocol
0.0549%
ChromeLoadTimesRequestTime
0.0136%
ChromeLoadTimesStartLoadTime
0.0216%
ChromeLoadTimesUnknown
<0.0001%
ChromeLoadTimesWasAlternateProtocolAvailable
0.1544%
ChromeLoadTimesWasFetchedViaSpdy
0.2367%
ChromeLoadTimesWasNpnNegotiated
0.1548%
Bug: 621512
Change-Id: I0e993420f9bfd0d8324b3ce8dd08b7780ca820c6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3824142
Reviewed-by: Robert Kaplow <[email protected]>
Reviewed-by: Ian Clelland <[email protected]>
Commit-Queue: Aoyuan Zuo <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036126}
Roll RTS model from kvnnJX6BYmOihN9rx... to RbH8e_77lW7LpT7Nh...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/rts-windows-amd64-chromium-autoroll
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: [email protected]
Change-Id: I8937e926e0e1edf1ac4d7495408b77436662b26e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834980
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036125}
Change interest group k-anonymity stored data.
Change interest group k-anonymity storage so that table does not
separate keys by type and stores whether a key is k-anonymous
instead of expecting to store a noisy count. Also adds a function
to get the last server update time.
BUG=1234419
Change-Id: If026658321143237ec21341290ba18839e333ba2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3818142
Reviewed-by: Caleb Raitto <[email protected]>
Commit-Queue: Russ Hamilton <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036124}
color_panel_cocoa_unittest: add Mojo callback and fix tests
This CL adds a callback to the SetSelectedColor() and Show() methods
on the ColorPanel interface. This allows the tests to move away from
base::RunLoop().RunUntilIdle(), which was causing flakes.
Bug: 1296023
Change-Id: Id0876bb6a1527404008bcc23d94154c73476f276
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834784
Commit-Queue: Avi Drissman <[email protected]>
Reviewed-by: Alex Gough <[email protected]>
Auto-Submit: Tom Burgin <[email protected]>
Reviewed-by: Avi Drissman <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036123}
Roll Perfetto from 3960394cdf24 to 8404c1cc9828 (2 revisions)
https://android.googlesource.com/platform/external/perfetto.git/+log/3960394cdf24..8404c1cc9828
2022-08-17 [email protected] Merge "Remove duplicate function"
2022-08-17 [email protected] Merge "ui: Add initial search support for logs"
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel
Bug: None
Tbr: [email protected]
Change-Id: I068b728c3032d1b2433095faff87597584d925dc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3836355
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036122}
Roll Chrome Mac Arm PGO Profile
Roll Chrome Mac Arm PGO profile from chrome-mac-arm-main-1660715759-c9f51dd72bf9a894f0a18bf4b3d2169a2d6520b0.profdata to chrome-mac-arm-main-1660737332-adc7a3f7fbaab5ffcaec167dfa8bb93b302ddf7a.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-arm-chromium
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:mac-chrome
Tbr: [email protected]
Change-Id: I5d3722100cae29d4da68f66d85ec4656901a1aa3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3835729
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036121}
[DevTools] Add test for sending empty headers with curl
FE CL: https://crrev.com/c/3543151
Bug: 1309310
Change-Id: I9e51e36ea5b4c2ca3c2589e9543b79a36701e492
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3828228
Reviewed-by: Alex Rudenko <[email protected]>
Commit-Queue: Wolfgang Beyer <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036120}
[ios] Updates strings for the Lockscreen Launcher widget.
BUG=1347565
Change-Id: I4dd5f83cc51bdec13af79b3df33b9e86cde1d138
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3835071
Commit-Queue: Rohit Rao <[email protected]>
Reviewed-by: David Jean <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036119}
Roll Chrome Mac PGO Profile
Roll Chrome Mac PGO profile from chrome-mac-main-1660694323-0c813aed519ad7837d2488005b935b8bb4c28ab5.profdata to chrome-mac-main-1660737332-4cb1bea6efe2496fe83bb003b1253f145bacc0f3.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:mac-chrome
Tbr: [email protected]
Change-Id: I21c87144f43b901dbd114a1b7948a847f2e771d0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3835287
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036118}
Create Impression Limit class.
This change creates an Impression Limit class, enabling a standard
representation for impression limits.
This change is mostly class scaffolding, as the class will grow in
subsequent CLs.
Bug: 1353123
Change-Id: Ic4f8c822084df95ff9dba52dfd506082359a4a90
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3806554
Reviewed-by: Rohit Rao <[email protected]>
Commit-Queue: Benjamin Williams <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036117}
Update js_sandbox to match AndroidX javascriptengine
This change copies AndroidX versions of js_sandbox/javascriptengine
client code back over to Chromium. The Java package names from AndroidX
will be used going forward.
Copyright and licence preamble is adjusted.
The WebViewJavaScriptSandboxTest.java test runner is replaced with
BaseJUnit4ClassRunner.
WebView instrumentation tests have been updated to use the modified
class names and packages.
Bug: 1297672
Change-Id: Ic42471271f81015df71c2668ef65a93035a9aeeb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834449
Reviewed-by: Abhijith Nair <[email protected]>
Reviewed-by: Richard Coles <[email protected]>
Commit-Queue: Ashley Newson <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036116}
Add policy for context aware signals on login screen
Create device level policy DeviceContextAwareAccessSignalsAllowlist, which
allows specified URLs to be part of the attestation flow.
Bug: b/242036672
Change-Id: Ib0b0520c433cc333fa913b32d2c43cfffebef7d6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3822945
Reviewed-by: Alexander Hendrich <[email protected]>
Reviewed-by: Martin Rodriguez <[email protected]>
Commit-Queue: Leon Masopust <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036115}
Android: Implement D8 stale dep removal
Previously *.desugardeps files were only ever appended to, since we
could not reliably know during an incremental dex run whether a dep was
stale or new. This was done to avoid bugs like https://crbug.com/1305987
but could result in large *.desugardeps files, negating the benefit of
incremental dexing.
Using a new D8/R8 API, we are now able to remove all the nodes that D8
knows about before updating *.desugardeps files during an incremental
dex run, thus *.desugardeps files will now be kept up-to-date and stale
entries removed each time.
Bug: 1309097
Fixed: 1309097
Change-Id: I2533b47bd50a7d6f3bd103eaefcfd1aa99c93ed2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834173
Reviewed-by: Mohamed Heikal <[email protected]>
Auto-Submit: Peter Wen <[email protected]>
Commit-Queue: Mohamed Heikal <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036114}
Replace accidental absl::StrCat use with base::StrCat
Snuck in https://chromium-review.googlesource.com/c/chromium/src/+/3759632
Change-Id: Id8e8e882f746ee899b46cf09e651b3e558e19b08
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3831245
Reviewed-by: Hubert Chao <[email protected]>
Commit-Queue: Matt Mueller <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036113}
[iOS] Change pipes to backticks in /ios/chrome/browser/drag_and_drop
Please review the CL to ensure that nothing is broken and the script
didn't miss some pipes.
This should allow us to have a better formatting in Xcode.
This CL was uploaded by git cl split.
[email protected]
Bug: 1311955
Change-Id: Ia89c09ad2f8b300fd3942e29c41f63cacebf96c4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834312
Auto-Submit: Gauthier Ambard <[email protected]>
Commit-Queue: edchin <[email protected]>
Reviewed-by: Stepan Khapugin <[email protected]>
Reviewed-by: edchin <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036112}
Roll Chrome Win32 PGO Profile
Roll Chrome Win32 PGO profile from chrome-win32-main-1660715759-94da55ad39428f298ce5b2038af9272db9954ca9.profdata to chrome-win32-main-1660737332-9917a3d02b0f8798fefc802cdaeb0339a71e6073.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win-chrome
Tbr: [email protected]
Change-Id: Ib339d04a8c4302b9a2bde74e529d6a7471da0b4d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3835770
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036111}
[fuchsia] Set DomKey based on fuchsia.input3.KeyMeaning
Key events now have the DOM Code and Key populated from the Fuchsia
Key and KeyMeaning, respectively. If only the KeyMeaning is specified
then keydown/keyup events will be generated, with DOM Code "None" and
a zero legacy key_code, rather than "keypress" character events.
The legacy key_code continues to be populated based on the DOM Code,
assuming a US English layout - this will be addressed in a follow-up.
Bug: 1187257, fuchsia:106600
Change-Id: I10a70ca1737d03cc5706f1ca48e4e551f69c6350
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3826040
Reviewed-by: Greg Thompson <[email protected]>
Commit-Queue: Wez <[email protected]>
Auto-Submit: Wez <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036110}
Add rogerm to base/metrics/OWNERS.
Change-Id: Idd465f6dccfd129fca5a5727c7623daa19c68b80
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3835203
Auto-Submit: Caitlin Fischer <[email protected]>
Reviewed-by: Roger McFarlane <[email protected]>
Commit-Queue: Roger McFarlane <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036109}
[webgl] Move size check of webgl operations out of bindings code
WebGL uses uint32_t to store the size of incoming data. There should
not be a risk of integer overflows because the size of the incoming data
is supposed to be less than 2GB*. If the incoming data comes from
JavaScript and is an ArrayBuffer (or similar), then the size of the
ArrayBuffer is checked in the bindings to be less than 2GB.
The size check in the bindings causes problems for WebGL2, because the
size of the incoming data in WebGL2 is not defined by the size of the
ArrayBuffer but by the srcLength parameter. This means that incoming
data gets rejected for being too large when actually the srcLength
parameter is much less than 2GB.
With this CL the size check of the incoming data is moved from the
bindings to the WebGL code, which allows to check srcLength instead of
the size of the ArrayBuffer.
* The actual size limit is defined by the maximum size PartitionAlloc
can allocate, which is 2GB minus some constants.
[email protected]
Bug: chromium:1344047
Change-Id: I252cd9d526f178a55e6aa8babff8e6d4a4eb11f4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3825862
Reviewed-by: Kentaro Hara <[email protected]>
Commit-Queue: Andreas Haas <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036108}
Roll DevTools Frontend from d5f3befb47ea to 7b67f32b65dc (1 revision)
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/d5f3befb47ea..7b67f32b65dc
2022-08-17 [email protected] [e2e] Wait properly for the element to be DOM-connected when clicking
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: [email protected]
Change-Id: Iee7105f3b7448e138a38f1a1b196a1db12d5d41d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3836473
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036107}
[iOS] Create ChromeTailoredSecurityService on iOS
To have ChromeTailoredSecurityService on iOS, we need to create a
subclass that works with iOS infrastructure. This CL creates the files
and lays the foundation for additional changes in follow-up CLs.
Bug: 1353367
Change-Id: I21203eb1c2ff1c7d30661dbcdfcfb48fe653d465
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3831923
Commit-Queue: Joemer Ramos <[email protected]>
Reviewed-by: Varun Khaneja <[email protected]>
Reviewed-by: Ali Juma <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036106}
Refactor visual debugger to use canvas transforms
Transform the canvas context instead of manually computing where each
rect should be placed. For text, apply this transform only to the
position, so that the text maintains the correct orientation.
DrawFrame.updateCanvasOrientation() and .updateCanvasSize() don't
remember state and need to be called in a particular order, so combine
them.
Bug: 1345254
Change-Id: I0c7deed54a9d7b67c221381e0671ea5c6b21997d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3817907
Reviewed-by: Peter McNeeley <[email protected]>
Commit-Queue: River Gilhuly <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036105}
Roll src/third_party/cros_system_api/ 564038ed7..aa799daeb (2 commits)
https://chromium.googlesource.com/chromiumos/platform2/system_api.git/+log/564038ed7902..aa799daeb5b4
$ git log 564038ed7..aa799daeb --date=short --no-merges --format='%ad %ae %s'
2022-08-04 anastasiian cryptohome: Implement AuthSession::UpdateAuthFactor for USS
2022-08-09 sarthakkukreti spaced: Add stateful disk state signal
Created with:
roll-dep src/third_party/cros_system_api
Bug: None
Change-Id: I4df7aa4461420df54a8c7f499827dd3d39e09129
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3833550
Reviewed-by: Maksim Ivanov <[email protected]>
Commit-Queue: Anastasiia N <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036104}
Split up TabSearchAppTest browsertest.
TabSearchAppTest.All is flaky and times out. Split out the media tabs related tests into their own test suite.
Bug: 1311655
Change-Id: Ie3a10eab61568a49b6ab5ee68cc5f099562774d8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3828796
Reviewed-by: Thomas Lukaszewicz <[email protected]>
Commit-Queue: Elaine Chien <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036103}
Roll Perfetto Trace Processor Linux from 8ab7cdc76e49 to 3960394cdf24
https://android.googlesource.com/platform/external/perfetto.git/+log/8ab7cdc76e49..3960394cdf24
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: [email protected]
Change-Id: I344f86a16ba0efb8b436b8a5a6d42f6cf22f1050
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834754
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036102}
Roll eche_app from Qa1IWoOECUYzahsB4... to uWK-hoCeXK1wUicxH...
Release_Notes: http://go/eche-x20/relnotes/Main/eche_20220817_RC00.html
https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/eche_app/app/+/uWK-hoCeXK1wUicxHb7YlPKmGDebjbXvVHcCkFbCnFkC
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/eche-app-chromium
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: [email protected]
Change-Id: I53560985eca872e454fea6a3bce5b5bb2d420044
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3835731
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1036101}
Fix "session" field type in CookiesGetAll telemetry signal proto.
(string -> bool)
Bug: 1350204
Change-Id: I03e7256a7f4024d17c74f92d9fdd92916f1a1b01
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832790
Commit-Queue: Richard Chen <[email protected]>
Reviewed-by: Xinghui Lu <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036100}
Add metrics for main frame app launches
Adds metrics to record whether the main frame app launch is coming from
an app, and what kind of link they used to leave Chrome.
Bug: 1333890
Change-Id: I7708111ed8509c6fef5023b672992bc9789d65f8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832407
Reviewed-by: Yaron Friedman <[email protected]>
Commit-Queue: Michael Thiessen <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036099}
Change battery saver "temporarily enabled" to "disabled for session"
I had misread the requirements when implementing this flag, and it turns
out the planned interactions are the reverse of what I had in mind.
When BSM is enabled, a prompt will inform the user. This prompt will
contain a "turn off" button, which should disable BSM until one of the
following:
- The device is plugged in
- The browser is restarted
- The user manually configures the mode in settings
Bug: 1308741
Change-Id: I22372ba0f9a5af61a4b5a82f75ae3e0e936df59a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832648
Commit-Queue: Anthony Vallée-Dubois <[email protected]>
Reviewed-by: Chris Hamilton <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036098}
[Journeys] Include date headers when animating to the list view
We need to deliberately include the implicated views. Doing so via id
doesn't work (they don't have one), and using their class
(MaterialTextView) is too broad since it includes, e.g. the toggle.
The approach I've gone with here is to scan the recycler view for
visible view holders of the correct type.
Bug: 1352129
Change-Id: Ibba9fabed431eed7244aefc593cc117529947f69
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3831145
Reviewed-by: Gang Wu <[email protected]>
Commit-Queue: Patrick Noland <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036097}
[Journeys] Wire isIncognito when opening new tabs on tablet
We were mistakenly always passing false. Also, use the correct launch
type when creating a tab group on tablets.
Bug: 1352035, 1351664
Change-Id: I9593510ec21bd27a2f9f65ba316afc9c158c4bc9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3829809
Reviewed-by: Brandon Wylie <[email protected]>
Commit-Queue: Patrick Noland <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036096}
Move constraints from MediaStreamComponent to MediaStreamTrackImpl
Constraints are only used by MediaStreamTracks, and the JS API it
provides, so it makes more sense to store them on the MST instance in
modules/ rather than MSC in platform/.
Bug: 1351135, 1353279
Change-Id: I3ebc8f209e63da38cf2a5cc5834cb6b662fbbea7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3829698
Commit-Queue: Tony Herre <[email protected]>
Reviewed-by: Palak Agarwal <[email protected]>
Reviewed-by: Nico Weber <[email protected]>
Auto-Submit: Tony Herre <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036095}
[partition_alloc] Update alternate bucket distribution.
This CL updates the alternate bucket distribution to only go up to 2^16 instead of 2^19.
Everything in this CL is gated behind a feature flag, so it should not
affect chrome.
Change-Id: Ic206646fa4022abe07c997ca8a86918038914953
Bug: 1238858
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3826795
Commit-Queue: Thiabaud Engelbrecht <[email protected]>
Reviewed-by: Benoit Lize <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036094}
Roll src-internal from e436427b1b4c to b2beda591ad4 (2 revisions)
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e436427b1b4c..b2beda591ad4
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: chromium:1351353
Tbr: [email protected],[email protected]
Change-Id: I9783d1916a0d1363139d782cf4cf775ad2f5f7cd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3835137
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1036093}
[signin] Temporary disable IsAllowedForMachineLearningCapability
IsAllowedForMachineLearningCapability isn't enabled on server yet and
this causes test failures.
This CL excludes IsAllowedForMachineLearningCapability from
GetSupportedAccountCapabilityNames() so that it won't be fetched from
the server at all.
This is a temporary change until IsAllowedForMachineLearningCapability
is rolled out.
Bug: 1352081
Change-Id: I8337544d715d738f6f1f7d3ca297d2837c1997f7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834483
Auto-Submit: Alex Ilin <[email protected]>
Commit-Queue: Alex Ilin <[email protected]>
Reviewed-by: Nicolas Dossou-Gbété <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036092}
Automatic update from google3
Automatic update for 2022-08-17 UTC
Change-Id: Icfea3a5ae705aaf5e6e6da4f5220c32008356925
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3833399
Commit-Queue: PKI Metadata Updates Bot <[email protected]>
Bot-Commit: PKI Metadata Updates Bot <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036091}
Don't checkfail with negative visible cursor heights.
Bug: 1353370
Change-Id: I375b25a5c68f31560658c3504de133c77208c15c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832153
Commit-Queue: Peter Kasting <[email protected]>
Reviewed-by: Elaine Chien <[email protected]>
Auto-Submit: Peter Kasting <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036090}
Adding a missing header to FakeDesktopCapturer
I am going to fix up a TODO in webrtc
(https://webrtc-review.googlesource.com/c/src/+/271922) but I'd like
to ensure that all instances of screen_capture_frame_queue in Chromium
include the necessary headers. Luckily there is only one instance so
I'm fixing it in this CL.
Bug: webrtc:14378
Change-Id: Ib9c32754203f89d3f1f8aa0655ac1b27e049825e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3836317
Auto-Submit: Joe Downing <[email protected]>
Commit-Queue: Lambros Lambrou <[email protected]>
Reviewed-by: Lambros Lambrou <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036089}
Update fuchsia-binary-size failure message to show growth by type.
Change-Id: I1736b2431c2d2cc956e2ddd5ba7de0e2398d4d98
Bug: 1302137
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3835026
Reviewed-by: Wez <[email protected]>
Commit-Queue: Rohan Pavone <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036088}
Devirtualize CSSTokenizer to avoid performance penalty
In a previous CL (http://crrev.com/c/3808071) some CSSTokenizer
methods were made virtual to allow easy switching between the cached
tokenizer and the standard tokenizer. This had a small performance
penalty on some benchmarks, which was not ideal. This patch removes
the virtualization and instead adds a wrapper class which can switch
between the different tokenizers.
This fixes the regression in css-parser-yui from the previous patch:
https://pinpoint-dot-chromeperf.appspot.com/job/1198e7976a0000
Bug: 1289471
Change-Id: Ia24bfdbe8b3626abbf07b2fac4ccd74074e2cf0c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3828511
Reviewed-by: Rune Lillesveen <[email protected]>
Commit-Queue: Clark DuVall <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036087}
Roll Skia from 545157bb176d to 86b5bf11ddfa (4 revisions)
https://skia.googlesource.com/skia.git/+log/545157bb176d..86b5bf11ddfa
2022-08-17 [email protected] Re-enable VectorScalarMath on all GPUs.
2022-08-17 [email protected] Remove UnresolvedFunction node.
2022-08-17 [email protected] Raster Pipeline: Use clang::musttail when possible
2022-08-17 [email protected] Roll vulkan-deps from 206b75948397 to 16356830603c (2 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Cq-Do-Not-Cancel-Tryjobs: true
Bug: None
Tbr: [email protected]
Change-Id: I51f87fc15324d59ea5b7a5a393f6e8e067863de4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3835769
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036086}
Clean out unused #includes from html_media_element.cc.
clang-tidy complains that these are not (directly) used.
Change-Id: I63afd6efa1943742a60f8dcc3bba7aa81e694828
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3826258
Reviewed-by: Rune Lillesveen <[email protected]>
Commit-Queue: Steinar H Gunderson <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036085}
Support configuring duration for IconLabelBubbleView animation
The change within IconLabelBubbleView::GetWidthBetween is needed to support open_state_fraction_ values like 0.05. A DCHECK within gfx::Tween::CalculateValue throws without this change.
The duration configurability is needed so we can have a page action chip for the performance MVP features appear for 12 seconds before shrinking.
Change-Id: I50ab8365f73d886c771123c8125b332ac23ec22e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834603
Reviewed-by: Peter Kasting <[email protected]>
Commit-Queue: Alison Gale <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036084}
Refactor PushMessaging to use PrefService::GetValueDict
This is part of a larger migration effort based on
go/trust-your-prefs.
Bug: 1341996
Test: Existing unit tests
Change-Id: I5f785e07f1e97c7be5a0bb1276d2f50b6a4f44ec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832227
Reviewed-by: Peter Beverloo <[email protected]>
Commit-Queue: Roland Bock <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036083}
[iOS][Omnibox] Post-SwiftUI test cleanup.
Since SwiftUI Popup is not going to ship anytime soon:
* Reenable testSwitchToOpenTab
* Remove SwiftUI-specific triggers for tests
* Remove classes that were testing SwiftUI specifically.
Bug: 1346362
Change-Id: Iaa556fa63a18f53a0d7c3adf409ca517730ce8ab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3826024
Auto-Submit: Stepan Khapugin <[email protected]>
Commit-Queue: Stepan Khapugin <[email protected]>
Reviewed-by: Robbie Gibson <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036082}
Login screen: count login attempts by user
Bug: 1341437
Change-Id: I1aa3f3bc3c6a4aa2735187b43d8472100c541068
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3828079
Commit-Queue: Yunke Zhou <[email protected]>
Reviewed-by: Renato Silva <[email protected]>
Reviewed-by: Maksim Ivanov <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036081}
Refactor demographics to use PrefService::GetValueDict
This is part of a larger migration effort based on
go/trust-your-prefs.
Bug: 1341996
Test: Existing unit tests
Change-Id: I06308d0ba161538f2a36eec2f9060f9b46516226
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834110
Commit-Queue: Roland Bock <[email protected]>
Reviewed-by: Caitlin Fischer <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036080}
Clean-up: add missing braces around if blocks
Bug: 1313893
Change-Id: Idb55b94cf3e3fc690d29c626836826930a6b9698
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834253
Reviewed-by: Christoph Schwering <[email protected]>
Commit-Queue: Eva Herencsarova <[email protected]>
Reviewed-by: Mohamed Amir Yosef <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036079}
[editing] Handle null positions in MoveParagraphContentsToNewBlockIfNecessary
The logic to convert a Position into a VisiblePosition is broken and
thus it may unexpectetly return a null one in some cases.
This patch makes MoveParagraphContentsToNewBlockIfNecessary detect these
cases and then abort instead of failing some DCHECKs.
Bug: 1351899
TEST=CompositeEditCommandTest.MoveParagraphContentsToNewBlockWithNullVisiblePosition1
TEST=CompositeEditCommandTest.MoveParagraphContentsToNewBlockWithNullVisiblePosition2
Change-Id: Icf2ca057a432318bf8c68e94934f8d81135b841a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3829227
Commit-Queue: Oriol Brufau <[email protected]>
Reviewed-by: Yoshifumi Inoue <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036078}
Fix perf regression: remove iteration from AddElementIdentifierHashes()
To fix perf regression caused by handling :hover compounding conditions
for :has() fast rejection, remove for-loops and vector allocation
from CheckPseudoHasFastRejectFilter::AddElementIdentifierHashes()
- HasDescendantInvalidationWith1NonMatchingHasRule.html
https://pinpoint-dot-chromeperf.appspot.com/job/17757d936a0000
2,242.070 -> 2,450.221 (+9.3%)
- HasDescendantInvalidationWithMultipleNonMatchingHasRules.html
https://pinpoint-dot-chromeperf.appspot.com/job/10a200dd6a0000
2,167.904 -> 2,382.886 (+9.9%)
Bug: 1353176
Change-Id: I62131c4345146ec6133b469f789c2ee40d2991ad
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3833315
Commit-Queue: Byungwoo Lee <[email protected]>
Reviewed-by: Rune Lillesveen <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036077}
Allow base::expected and base::unexpected in Blink.
Change-Id: Ide26ea39123c09def9540503f79ba5ba9203a53e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834070
Reviewed-by: Daniel Cheng <[email protected]>
Commit-Queue: Caleb Raitto <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036076}
Add save only arm to CriticalPersistedTabData
This CL completes the save only arm for CriticalPersistedTabData to
quantify the effect of saving TabState and CriticalPersistedTabData
files simultaneously. It uses a BooleanCachedFieldTrialParameter for
the parameter acquisition as we cannot rely on native to have
initialized by the time Tab restoration begins. It also clearly
separates out save only and save + restore in TabPersistentStore
using the parameter to ensure that no CriticalPersistedTabData
restoration occurs in the save only arm. Save only also integrates
with the migrate stale Tabs to CriticalPersistedTabData which was
added to stop Tabs the user wasn't interacting with from getting
stuck on TabState as we migrated over. In addition, save only
integrates with CriticalPersistedTabData file deletion which
occurs when the experiment is turned off. Finally, it adds save only
and save + restore arms to chrome://flags for ease of canary
verification for merging. The save + restore arm is synonymous
with the current isCriticalPersistedTabDataEnabled arm so the current
experiment won't be disrupted.
Bug: 1347495
Change-Id: Iff76d6a4bcf70da673bb211e38acf0d6a98e5211
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3833261
Reviewed-by: Yaron Friedman <[email protected]>
Commit-Queue: David Maunder <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036075}
Fix ReduceUserAgentPlatformOsCpu experiment groups matching on study
Address check groups matching in study cl: cl/465567634.
Bug: 1339834
Change-Id: I2324aa1882cf92e6a2445237e01afdebc1b28b30
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832707
Commit-Queue: Victor Tan <[email protected]>
Reviewed-by: Mike Taylor <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036074}
[waterfall] update config after 6 bots are moved from waterfall to pinpoint
Bug: chromium:1352574
Change-Id: I73fd5fad48d6412e4d4970a7b56e2b66770ecc41
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834766
Auto-Submit: Wenbin Zhang <[email protected]>
Reviewed-by: John Chen <[email protected]>
Commit-Queue: John Chen <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036073}
[CodeHealth] Replace DictionaryValue::GetString in /chrome/browser/ash/app_mode.
This CL was uploaded by git cl split.
[email protected]
Bug: 1187036
Change-Id: I3c5880ad9279c18ec2241670caa861dcacab7434
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3826927
Commit-Queue: Edman Anjos <[email protected]>
Auto-Submit: Brian Begnoche <[email protected]>
Reviewed-by: Edman Anjos <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036072}
[FLEDGE] Add interest group name to trusted bidding signals requests.
This is needed to receive per-interest-group priority vectors, which
I'll add parsing for in a followup CL.
github PR: https://github.com/WICG/turtledove/pull/329
Bug: 1343389
Change-Id: I3a1e71e3d628200437de331d087ce5048f2f60be
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3830747
Reviewed-by: Maks Orlovich <[email protected]>
Commit-Queue: Matt Menke <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036071}
Remove redundant initializer
frozen_ is already initialized to false in the header.
Change-Id: I88ea33797002c43b252811afdfd54466ee54d8b2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3831627
Reviewed-by: David Tseng <[email protected]>
Commit-Queue: Chris Harrelson <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036070}
Updating XTBs based on .GRDs from branch main
Change-Id: I69e84639e7c9d6be6d5ed273533ec24bc94cbcfb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3830751
Commit-Queue: Rubber Stamper <[email protected]>
Auto-Submit: Ben Mason <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036069}
Clear destination rect if source is missing in CopySubTexture
Is some cases (e.g when video is playing directly to SurfaceView on
Android) we can't access source shared image in CopySubTexture.
Depending if the texture had previous content or not this can cause
problems later when we would try accessing uncleared destination.
This CL makes sure we always clear the destination rect with black color
to avoid issues and removes debug instrumentation that we used to
before.
Bug: 1307307
Change-Id: I57fbd355338890b5abcc20eda28b7d1107b66c80
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3827983
Reviewed-by: Sunny Sachanandani <[email protected]>
Commit-Queue: Vasiliy Telezhnikov <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036068}
Automatic update from google3
Automatic update for 2022-08-17 UTC
Change-Id: I76b727140336c0debdeb6de938096c80a942747a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3835053
Commit-Queue: PKI Metadata Updates Bot <[email protected]>
Bot-Commit: PKI Metadata Updates Bot <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036067}
Updating trunk VERSION from 5246.0 to 5247.0
* This is an automated release commit.
* Do not revert without consulting [email protected].
NOAUTOREVERT=true
Change-Id: I400514bb088a8102c55b9c6464d32c3b06d3669e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3836454
Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1036066}
Refactor Value usage in chrome\browser\media\router\providers\cast, CL1
Update CastSessionTracker::OnInternalMessage() to pass along
base::Value::Dicts instead of base::Values, and update all code it calls
into to (mostly) use Value::Dict and Value::List to create and access
dictionary and list fields, as all other APIs to do so are deprecated.
Followup CLs will make cast_channel::InternalMessage use Value::Dicts,
and update some of the other Value usage in this directory.
Bug: 1187001,1338341
Change-Id: Ieb264d52f86774aeeb7e2eb4f863191112d78963
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3812126
Reviewed-by: Mark Foltz <[email protected]>
Commit-Queue: Matt Menke <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036065}
[Shopping Service] Add on-demand API for product bookmarks
This patch exposes the optimization guide on-demand API to the
shopping service and operates exclusively on bookmarks that contain
product information.
Bug: 1352536
Change-Id: Ie3e038a45fe9d4d583d1e8ed47032d8b29d686d0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3828564
Commit-Queue: Matthew Jones <[email protected]>
Reviewed-by: Sophie Chang <[email protected]>
Reviewed-by: Yue Zhang <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036064}
[iOS] Re-enable testBrowsingWindowDataLinkScriptRedirect
A lot of tests were failing at that time, potentially due to some
Finch config. It seems fixed now.
Fixed: 1352105
Change-Id: I99607a8891c54cf1870a209a68b14350a86181ea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834112
Auto-Submit: Gauthier Ambard <[email protected]>
Commit-Queue: Ewann Pellé <[email protected]>
Reviewed-by: Ewann Pellé <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036063}
Remove usage of CreateAndConsumeTextureCHROMIUM
Remove some test usage of deprecated CreateAndConsumeTextureCHROMIUM()
and replace with CreateAndTexStorage2DSharedImageCHROMIUM().
Bug: 1273084
Change-Id: I3329b9254ca6829db1799acab41a8e013f69332a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3827581
Commit-Queue: Kyle Charbonneau <[email protected]>
Reviewed-by: Sunny Sachanandani <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036062}
[Tracing] Provide a process name in SDK build
Provides a meaningful name for a trace producer in SDK build. Note that
this only affects tracing through a system backend, because Chrome's
custom backend overrides this name.
Change-Id: I6fd6a20aed7f2c41c8f92bb18adb66130939d3c1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834456
Reviewed-by: Eric Seckler <[email protected]>
Commit-Queue: Mikhail Khokhlov <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036061}
[iOS][OpenIn] Fixes file deletion
This CL ensures that the activityView id about to be removed
before calling `openInActivityWillDisappearForFileAtURL:`
Bug: 1350940
Change-Id: Ic99f7ae8887c061ffe4d9b6e4747504046616360
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3820107
Reviewed-by: Sylvain Defresne <[email protected]>
Commit-Queue: Ewann Pellé <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036060}
Extend the Android.WebView.OriginsVisited histogram.
Apparently the current date was near enough to show an expiry warning
in the UMA dashboard.
Bug: 1352070
Change-Id: I7dbff81ac9a4a5b927acf5ed156e04babc9f8c47
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834180
Commit-Queue: Michael Thiessen <[email protected]>
Reviewed-by: Michael Thiessen <[email protected]>
Auto-Submit: Michael van Ouwerkerk <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036059}
NetworkPortalDetector: Elim NetworkPortalDetectorStrategy
When Chrome's CaptivePortalDetector was primary, the Strategy class was
intended to allow different strategies for portal detection backoff.
With Shill portal detection as primary, that logic is integrated into
Shill (and made consistent) so this class is no longer necessary.
This CL simplifies the timeouts used for Chrome detection when it is
triggered (e.g. when a proxy is configured).
Bug=b:207088236
Change-Id: Idd22388dbe5c0e389346b534f4e835e94bdc8684
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3828050
Reviewed-by: Danila Kuzmin <[email protected]>
Commit-Queue: Steven Bennetts <[email protected]>
Reviewed-by: Kyle Horimoto <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036058}
Roll DevTools Frontend from 5db934b91736 to d5f3befb47ea (5 revisions)
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/5db934b91736..d5f3befb47ea
2022-08-17 [email protected] [LMI] Implement UI specification for Highlight Chips
2022-08-17 [email protected] Disable a flaky raw-wasm e2e test (display correct location in Wasm...)
2022-08-17 [email protected] Disable Sources Panel grouping test
2022-08-17 [email protected] Store HeaderOverrides as an array instead of as an object
2022-08-17 [email protected] send empty headers with curl
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: chromium:1288023,chromium:1309310,chromium:1336568,chromium:1349268,chromium:1349290
Tbr: [email protected]
Change-Id: Ie59418c98340e6c3d83dba4cce2d66c08b28b463
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3836314
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036057}
Don't always check AllowSyncOffForChildAccounts if sync enabled in FRE
SyncConsentFirstRunFragment.shouldEnableImmediately() is called if
the user clicks "Yes, I'm in" in the "Turn on sync?" dialog of the
FirstRunExperience.
https://source.chromium.org/chromium/chromium/src/+/main:chrome/android/java/src/org/chromium/chrome/browser/firstrun/SyncConsentFirstRunFragment.java;l=86;drc=36c59c53be1d8852f5087008c45a95797bac9730
Because crrev.com/c/3776617 checks AllowSyncOffForChildAccounts first
in that predicate, a lot of non-child users will be enrolled into the
experiment, which is undesirable for metrics analysis.
To fix this, check EnableSyncImmediatelyInFre first - that one will
only be launched after AllowSyncOffForChildAccounts.
Note there are other callers of shouldEnableImmediately() but only for
assertions, which are stripped in most release builds anyways.
https://source.chromium.org/chromium/chromium/src/+/main:chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunSignInProcessor.java;l=71;drc=36c59c53be1d8852f5087008c45a95797bac9730
https://source.chromium.org/chromium/chromium/src/+/main:chrome/android/java/src/org/chromium/chrome/browser/firstrun/SyncConsentFirstRunFragment.java;l=104;drc=36c59c53be1d8852f5087008c45a95797bac9730
Fixed: 1353737
Change-Id: I0470365f47c9981ecdb7c24786c4d36dcdbb0c02
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834316
Auto-Submit: Victor Vianna <[email protected]>
Reviewed-by: Boris Sazonov <[email protected]>
Commit-Queue: Boris Sazonov <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036056}
[PageInfo] Add test for SiteCount
Add a test for
LocalSharedObjectsContainer::GetHostCountForDomain()
and LocalSharedObjectsContainer::GetHostCount().
Bug: 1346305
Change-Id: I38f0522f3cd3a7c283a8b0cc286a2a8b65687167
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3816816
Reviewed-by: Olesia Marukhno <[email protected]>
Reviewed-by: Christian Dullweber <[email protected]>
Commit-Queue: Zofia Salata <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036055}
Roll Perfetto from 2fbf8d8bf878 to 3960394cdf24 (2 revisions)
https://android.googlesource.com/platform/external/perfetto.git/+log/2fbf8d8bf878..3960394cdf24
2022-08-17 [email protected] Save and expose filter_debug_annotations in EventContext for Chromium
2022-08-17 [email protected] Merge "[ZipReader] Rename Header field to avoid conflict with zlib macros"
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel
Bug: None
Tbr: [email protected]
Change-Id: Iad928fb022c86442eebdb34b0403a05394a7e31f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3835764
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036054}
[iOS] Change pipes to backticks in /ios/chrome/browser/device_sharing
Please review the CL to ensure that nothing is broken and the script
didn't miss some pipes.
This should allow us to have a better formatting in Xcode.
This CL was uploaded by git cl split.
[email protected]
Bug: 1311955
Change-Id: Id2402eef49960c33209baec482db6db0701deb01
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3829280
Auto-Submit: Gauthier Ambard <[email protected]>
Reviewed-by: Mark Cogan <[email protected]>
Commit-Queue: Gauthier Ambard <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036053}
Fallback to a main thread animation if background color animation affected by blur
Bug: 1289412
Change-Id: I97dd798afe06d88d104a6a632199feed32c94678
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3781496
Reviewed-by: Robert Flack <[email protected]>
Commit-Queue: Kevin Ellis <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036052}
Disable crostini.RestartIcon.bullseye_stable on Chromium CQ
The test is flaky
Bug: 1353760
Change-Id: Id550327a42e6e74a7abc508f0512a3e8336c7225
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3827750
Auto-Submit: Roman Sorokin <[email protected]>
Reviewed-by: Michael Ershov <[email protected]>
Commit-Queue: Roman Sorokin <[email protected]>
Commit-Queue: Michael Ershov <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036051}
Roll Chrome Win64 PGO Profile
Roll Chrome Win64 PGO profile from chrome-win64-main-1660705020-f9f76813a388dd9cf2da15d6d80f03f32c6c2896.profdata to chrome-win64-main-1660715759-32335aa14e4dc81c7277e1369dfd8ca35b9c8069.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win64-chrome
Tbr: [email protected]
Change-Id: I30913c9eb4dc38218ab74e5d8c40fc6ad9a2bf83
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3835136
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036050}
Remove several undefined functions from DocumentAnimations
This functionality was split out into the class PostStyleUpdateScope
a long time ago, but apparently I forgot to remove some function
declarations.
Change-Id: I9ca74f5a99deceed1bf570d8c382634870fc5b3f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834485
Reviewed-by: Robert Flack <[email protected]>
Auto-Submit: Anders Hartvoll Ruud <[email protected]>
Commit-Queue: Robert Flack <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036049}
Roll Dawn from f83652f01935 to 5ef011f2c3fc (3 revisions)
https://dawn.googlesource.com/dawn.git/+log/f83652f01935..5ef011f2c3fc
2022-08-17 [email protected] Roll SwiftShader from c61fc9aec162 to 3fb7084b02d7 (2 revisions)
2022-08-17 [email protected] d3d12: Disallow creating external image after device destruction
2022-08-17 [email protected] Roll ANGLE from 0f5770deabf2 to 213a1ee6e6db (10 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dawn-chromium-autoroll
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel
Bug: chromium:1352802
Tbr: [email protected]
Change-Id: I76744ea896dfb68a3c4582ed54a405571f2b33c5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834661
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036048}
Rename Thread::GetTaskRunner to Thread::GetDeprecatedTaskRunner.
Renaming the name to deprecated will help us progressively fix the
callsites. The worker based callsites are not touched and will call
directly to the NonMainThread::GetTaskRunner.
This change was largely done mechanically via grep/sed.
BUG=624696
Change-Id: I38aae3fa914b46244503f90eee4d65ba5f0b1f0d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832931
Commit-Queue: Dave Tapuska <[email protected]>
Reviewed-by: Kentaro Hara <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036047}
[Android Test] Features annotations for outside chrome/
Migrate the core functionality of
org.chromium.chrome.test.util.browser.Features to base/ so that this
annotation style can be re-used by tests outside of chrome/.
There are now two "flavors" of features annotations.
- base/'s that only sets FeatureList and CommandLine.
- chrome/'s which also sets cached flags and FieldTrials.
Usages in chrome/ should continue working automatically. Usages outside
Chrome can use the new base/ variety.
Usages of ContentFeatures, BaseFeatures or UiBaseFeatures can now rely on the base/test/util/Features.java implementation.
Bug: 1352550
Change-Id: Id1fcb06a965f177d20644e7fbe8f4b671934a4f7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3828121
Commit-Queue: Calder Kitagawa <[email protected]>
Reviewed-by: Xi Han <[email protected]>
Reviewed-by: Michael Thiessen <[email protected]>
Reviewed-by: Yaron Friedman <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036046}
Refactor ChromeContentBrowserClient to use PrefService::GetValueDict
This is part of a larger migration effort based on
go/trust-your-prefs.
Bug: 1341996
Test: Existing unit tests
Change-Id: I39ba689ea9987a7ea3c5359922d0898c8bfeafdb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3829093
Commit-Queue: Roland Bock <[email protected]>
Reviewed-by: Jana Grill <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036045}
Disable lacros.ShelfLaunch.* tast tests
The tests are failed on lacros-amd64-generic-chrome builder and blocking
LKGM uprev 15050.0.0 (crrev.com/c/3833010).
List:
* lacros.ShelfLaunch.only
* lacros.ShelfLaunch.primary
Bug: 1352476
Change-Id: I4039502734c9fb1c74fce38c903ae45350705f16
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3826594
Commit-Queue: Rubber Stamper <[email protected]>
Auto-Submit: Yoshiki Iguchi <[email protected]>
Commit-Queue: Keigo Oka <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Reviewed-by: Keigo Oka <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036044}
Revert "[OOBE][SAML]: Update documentation for LoginAuthenticationBehavior"
This reverts commit 88e5442ae8d7825bfbab4675cd668e390ed21313.
Reason for revert: Flaky, see https://crbug.com/1102738
Original change's description:
> [OOBE][SAML]: Update documentation for LoginAuthenticationBehavior
>
> Add a message that since M99 if LoginAuthenticationBehavior is set to 1,
> user will be redirected to SAML IdP page directly without additional
> confirmation.
>
> Also make sure that GAIA buttons are still hidden when we are trying to
> redirect to an IdP page, but getting an error.
>
> Bug: b:228887266
> Change-Id: I239e9edb92b288bd6784e5c2d8af51c4c030793f
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3822907
> Reviewed-by: Renato Silva <[email protected]>
> Reviewed-by: Maksim Ivanov <[email protected]>
> Commit-Queue: Danila Kuzmin <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1035659}
Bug: b:228887266
Bug: 1102738
Change-Id: I88d861a235957b7996cc8c21572c1d8710a40a44
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3836394
Auto-Submit: Roman Sorokin <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036043}
Cache Texture in Ozone backing on Freedreno drivers
Freedreno drivers crash during glDeleteTextures or fail in
eglDupNativeFenceFDANDROID if we import same dma-buf twice into GL.
To mitigate with we cache single GL texture for each SharedImage.
Note, that this doesn't fix issues when there are multiple
SharedImages created from the same NativePixmapHandle and this is
incompatible with anything but having a single GL Context, which
is true for now.
Bug: 1343644
Change-Id: If5f24c2e228aa7cdbeeba9d2bcaa70d8f301a6b3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3827481
Reviewed-by: Peter McNeeley <[email protected]>
Reviewed-by: Saifuddin Hitawala <[email protected]>
Commit-Queue: Vasiliy Telezhnikov <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036042}
Roll src-internal from 2a1b82d6bf3d to e436427b1b4c (6 revisions)
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/2a1b82d6bf3d..e436427b1b4c
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: chromium:1346419
Tbr: [email protected]
Change-Id: Ia6e686ce0dc74ca1e32eb67d635033c6b04ccecc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3833249
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1036041}
Move {ash => chromeos/ash}/components/audio/
ChromeOS components and services are meant to live in chromeos/,
separate from Ash shell code. Fix a previous migration that used the
wrong directory.
This CL is part of the ChromeOS source code directory migration:
https://docs.google.com/document/d/1g-98HpzA8XcoGBWUv1gQNr4rbnD5yfvbtYZyPDDbkaE.
Bug: 1164001
Change-Id: Idfa0140faafb4d4135ebea2e6ff05f4975fd6a81
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3779526
Owners-Override: Hidehiko Abe <[email protected]>
Reviewed-by: Hidehiko Abe <[email protected]>
Commit-Queue: Henrique Ferreiro <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036040}
Delay expiry and change ownership of remote disabling histograms.
- Extensions.Extensions.ExtensionDisabledRemotely
- Extensions.Extensions.ExtensionReenabledRemotely
- Extensions.ExtensionAddDisableRemotelyReason2
Bug: 1348998
Change-Id: Ia2e334405ae22bf9f6b9fb7d21929b72a1e22cee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3828706
Reviewed-by: Kelvin Jiang <[email protected]>
Commit-Queue: Anunoy Ghosh <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036039}
[FastCheckout] Add network status UMA in CapabilitiesFetcher.
The CL adds the analogous metric for FastCheckout to
PasswordManager.CapabilitiesService.HttpResponseCode.
Bug: 1350456, 1334642
Change-Id: I42e0d1a7bbf29f4a044bb36c5149f6cdd6cfa973
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3830013
Reviewed-by: Christoph Schwering <[email protected]>
Reviewed-by: Norge Vizcay <[email protected]>
Reviewed-by: Vidhan Jain <[email protected]>
Commit-Queue: Jan Keitel <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036038}
[Flex][EULA]: Make sure EULA is accepted on managed devices
Bug: b:239935283
Change-Id: I8a58d48f7d29f7ee51e9364e060df0765ac3ece0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3829521
Commit-Queue: Danila Kuzmin <[email protected]>
Reviewed-by: Roman Sorokin <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036037}
Roll Chrome Linux PGO Profile
Roll Chrome Linux PGO profile from chrome-linux-main-1660715759-6fd7688957ac352f6a31883b1956029821b7e078.profdata to chrome-linux-main-1660737332-29095bd3d22be72b162a802963b21a87dc061e6a.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-linux-chromium
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:linux-chrome
Tbr: [email protected]
Change-Id: I56bb7452d4b3b64e4a9786b4e52b57dc4b1c4149
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3835768
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036036}
arc: Send VolumeProvider content URLs for Downloads and Android files
Currently, files inside Downloads and Android files are served by
ArcFileProvider on the Android side, while those inside My files,
removable media. etc. are served by VolumeProvider.
In order to achieve integrity and improve maintainability, let
VolumeProvider serve files inside Downloads and Android files, too.
Bug: b:176918971
Bug: b:182874843
Bug: b:190331084
Bug: b:242715166
Test: $ unit_tests --gtest_filter="FileManagerPathUtilConvertUrlTest.*"
Test: Open mp3 files under Downloads/ and "Play files" with VLC from the
Test: Chrome OS Files app.
Test: Open image files under Downloads/ and "Play files" with ArtFlow
Test: using SAF (Storage Access Framework).
Change-Id: I034fce8502ef0aa7ccba0f2e1b53f0a74e5c8acd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461551
Auto-Submit: Youkichi Hosoi <[email protected]>
Reviewed-by: Ryo Hashimoto <[email protected]>
Reviewed-by: François Degros <[email protected]>
Commit-Queue: Youkichi Hosoi <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036035}
[iOS] Adds Clear Browsing Symbols
Adds symbols to the Clear Browsing screen.
Bug: 131554
Change-Id: I698a22f17c892eeceefed271208cad90ac90f316
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834459
Commit-Queue: Gauthier Ambard <[email protected]>
Reviewed-by: Gauthier Ambard <[email protected]>
Commit-Queue: Ewann Pellé <[email protected]>
Auto-Submit: Ewann Pellé <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036034}
[Web Payment] Cross platform not-supported test with shipping
Before this patch,
PaymentRequestMetricsTest.testMetrics_NoSupportedPaymentMethod was a
flaky test that ran only on Android. The flakiness resulted from
PaymentRequestTestRule.openPageAndClickNodeAndWait() timeout.
This patch:
1) Converts the test into an Android browser test, which makes it run on
both desktop and Android platforms.
2) Changes the test from using
PaymentRequestTestRule.openPageAndClickNodeAndWait() with Java
callbacks to using content::NavigateTo() and content::EvalJs() with
JS promises.
After this patch, the flakiness no longer reproduces.
Bug: 1291889
Change-Id: I963e85069f9321df86868c98ec81fcc63cf785fa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832708
Reviewed-by: Stephen McGruer <[email protected]>
Commit-Queue: Rouslan Solomakhin <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036033}
Implement MST::BeingTransferred which notifies browser of the transfer
This function calls MSDH::KeepDeviceAliveForTransfer to keep the
MediaStreamDevice alive until it has been cloned successfully in the
transferred context. This function also stops the MST which is being
transferred in the original context.
Bug: 1288839
Change-Id: I29b0a7794409c7f98779c666a1415fd31f9df8c0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3812165
Reviewed-by: Jeremy Roman <[email protected]>
Commit-Queue: Palak Agarwal <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036032}
Privacy Guide: Add functionality to the MSBB page
Make the toggle in the MSBB page functional.
- Correct initialisation depending on the MSBB state.
- Change the MSBB state when the toggle is pressed.
Bug: 1238896
Change-Id: Iff59b6ea1d42dc0029bb55b42924bcc1b0c58fde
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3829531
Reviewed-by: Boris Sazonov <[email protected]>
Commit-Queue: Rubin Deliallisi <[email protected]>
Reviewed-by: Rainhard Findling <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036031}
[CodeHealth] Extensions file manager base::Value refactor
This CL contains base::Value modenrnisation for files under the path
chrome/browser/chromeos/extensions/file_manager/ and its adjacent code.
Bug: 1187001, 1352780
Change-Id: Ia40b94fddb7d1d5f1112afef48193bd83b3a2a30
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3829928
Reviewed-by: Jeremie Boulic <[email protected]>
Commit-Queue: Claudio DeSouza <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036030}
bindings: Remove the prototype chain from observable array handler object
Removes the prototype chain (__proto__) from observable array
handler objects so that only the trap functions installed by
Blink will be effective.
Bug: 1352549
Change-Id: Ied84c044708066c68c11a7e640846411284f545b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832190
Commit-Queue: Yuki Shiino <[email protected]>
Reviewed-by: Kentaro Hara <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036029}
[iOS] Change pipes to backticks in /ios/chrome/browser/dom_distiller
Please review the CL to ensure that nothing is broken and the script
didn't miss some pipes.
This should allow us to have a better formatting in Xcode.
This CL was uploaded by git cl split.
[email protected]
Bug: 1311955
Change-Id: I43aaca3dbb61631aff1293976bc0491aed26a106
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834246
Reviewed-by: Éric Noyau <[email protected]>
Commit-Queue: Gauthier Ambard <[email protected]>
Auto-Submit: Gauthier Ambard <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036028}
OOBE - Polymer3 - Check-in encryption migration
Check-in the modularised version of OOBE's Encryption Migration screen.
Bug: 1184731, b/242724200
Change-Id: I9af8639fe0da9656d141fae68f5ef22efea29788
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834445
Reviewed-by: Danila Kuzmin <[email protected]>
Commit-Queue: Renato Silva <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036027}
Standardize GPU parallelization
Standardizes the GPU parallelization-related code to be part of the
base GpuIntegrationTest instead of repeating code in child classes.
Also moves a couple of public methods in GpuIntegrationTest to be
private since the addition of the new public method pushed the number
over pylint's limit of 20 and there's no reason why they needed to be
public in the first place.
Bug: 1336393, 1340607
Change-Id: I8842da4a35059af5973bd294ba728d3bb6ba5da4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3826384
Auto-Submit: Brian Sheedy <[email protected]>
Commit-Queue: Yuly Novikov <[email protected]>
Reviewed-by: Yuly Novikov <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036026}
Pass new unwinders to TracingSamplerProfiler in the GPU
compositor thread.
We pass in CreateCoreUnwindersFactory here since it lives in the
chrome/ layer while TracingSamplerProfiler is outside of chrome/.
Also, move the initialization of TracingSamplerProfiler from
components/viz to chrome/gpu. This aligns better with how the
profiler is used in other child processes.
Change-Id: Iaa494b8f030390c92636693bf6c7297f7eec96a2
Bug: b/231934478
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3804589
Reviewed-by: Tommy Nyquist <[email protected]>
Commit-Queue: Eric Seckler <[email protected]>
Reviewed-by: Jonathan Ross <[email protected]>
Auto-Submit: Tushar Agarwal <[email protected]>
Commit-Queue: Tushar Agarwal <[email protected]>
Reviewed-by: Eric Seckler <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036025}
[ios] Fix crash when segmentation platform feature disabled.
`segmentation_otr_web_state_observer_` in ApplicationContextImpl can
only be initialized when `kSegmentationPlatformFeature` is enabled.
Although `kSegmentationPlatformFeature` is enabled by default currently,
but we'd better add non-nullptr check for
`segmentation_otr_web_state_observer_` in case this feature can appear
in the disabled feature list.
Bug: 1353619
Change-Id: I9e6d4b314ea24d5be68d68282dd40f9479729724
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3831629
Commit-Queue: Éric Noyau <[email protected]>
Reviewed-by: Éric Noyau <[email protected]>
Reviewed-by: Mark Cogan <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036024}
[iOS] Remove Dark mode workaround for resizable images
Using resizableImageWithCapInsets removes the Assets attribute related
to dark mode. We used a workaround by refetching the image each time the
trait collection was changing.
However, the correct solution is to set the insets in the image
metadata.
Fixed: 1351094
Change-Id: Ie892d6f004eb023033c54f6360256586f904fd33
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3817543
Commit-Queue: Gauthier Ambard <[email protected]>
Reviewed-by: Robbie Gibson <[email protected]>
Reviewed-by: Justin Cohen <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036023}
Update V8 to version 10.6.190.
Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/8444c40e..43711c5b
Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues
Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_chromeos_msan_rel_ng
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel
[email protected],[email protected],[email protected]
Change-Id: I7c0af68e3b5e65e513a019627fed709c9ec83afc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834550
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1036022}
Roll Projector App from 5aiSSTONnl1PqtAdZ... to OEv_F3H4roKFxcVxV...
Release_Notes: http://go/projector_app-x20/relnotes/Main/projector_app_nightly_202208170100_RC00.html
https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/projector_app/app/+/OEv_F3H4roKFxcVxV1LrSjOnVqoIszU3d8YiZSpLXG0C
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/projector-app-chromium-autoroll
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chrome.try:linux-chromeos-chrome
Bug: b/241488095
Tbr: [email protected]
Change-Id: I4d2612525f6fabeec55cc33fa8c99e580b384fa5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3835722
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1036021}
[grid] Fix synthesis vertical-lr baselines.
Previously we'd synthesize the baseline on the incorrect side (and there
was a test asserting incorrect behaviour), and we didn't account for
the text orientation.
Fixed: 1013578
Change-Id: I8b4466832e1ab9017289d516b06bf122ea636a13
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832966
Commit-Queue: Ian Kilpatrick <[email protected]>
Reviewed-by: Ethan Jimenez <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036020}
Remove kEnablePerfettoClientApiProducer feature flag
The flag makes things harder to support because we have 4 possible
configurations. This CL simplifies things by always using perfetto
producer in the SDK build and tracelog producer in the non-SDK build.
Bug: b/240132218
Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel
Change-Id: I14869f43b0714e4e1f6baa4088229645c2b6b480
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3830017
Reviewed-by: Eric Seckler <[email protected]>
Reviewed-by: Sami Kyöstilä <[email protected]>
Commit-Queue: Mikhail Khokhlov <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036019}
Allow controlling which experiments will go into which synthetic trial
Change-Id: I3694727eb42b661c074283d7ae58769657962219
Bug: b:242171397
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3826307
Commit-Queue: David Bengoa <[email protected]>
Reviewed-by: Florian Gauger <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036018}
NaCl on ARM64: Remove dependencies on //net
NaCl cannot depend on //net when building for ARM64, as in that build
some libraries are not present in the 32-bit version that NaCl needs.
Introduce is_minimal_toolchain build variable to distinguish our special
nacl_helper build.
Bug: 1339021
Change-Id: Ic1d37002e16c2a7a8e2479a39463454f805633c1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3819701
Reviewed-by: Mark Seaborn <[email protected]>
Reviewed-by: Derek Schuff <[email protected]>
Commit-Queue: Fabian Sommer <[email protected]>
Reviewed-by: Daniel Cheng <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036017}
[iOS][Omnibox] Clip omnibox to bounds.
Clips the omnibox to bounds to improve the animations.
Fixed: 1350067
Change-Id: If255a85b08ac6e71ef5583f88c703b3a9f878df0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3826130
Auto-Submit: Stepan Khapugin <[email protected]>
Commit-Queue: Stepan Khapugin <[email protected]>
Reviewed-by: Ewann Pellé <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036016}
Roll Chrome Win32 PGO Profile
Roll Chrome Win32 PGO profile from chrome-win32-main-1660705020-8cae24c037275a8529d60f3d361f009d45951634.profdata to chrome-win32-main-1660715759-94da55ad39428f298ce5b2038af9272db9954ca9.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win-chrome
Tbr: [email protected]
Change-Id: Iafdc2be2f44b4769af93050feafa14c0d0072623
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3835763
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036015}
[fileSystem API] Ensure RequestFileSystemDialogView invokes callback.
RequestFileSystemDialogView is used to display files access consent
dialog for chrome.fileSystem.requestFileSystem(). The constructor takes
a callback that gets invoked when the user responds to or closes the
dialog box.
Previously a problem arises when the containing App exits while the
consent dialog is shown. In this case, the callback is never invoked,
so the extension API never gets a response, and a DCHECK is triggered.
This CL fixes the issue by making RequestFileSystemDialogView's
destructor invoke the callback, if that's not yet done. Also, previously
ChromeFileSystemDelegateLacros::RequestFileSystem()'s main flow guards
against the possibility for the consent dialog call to not cause
callback to be called. We now relax this check.
RequestFileSystemDialogTest.InvokeUi_default (browser_tests) is also
updated to check that the callback is called. The test would fail
without this CL's fix.
Bug: 1352245, 1263204
Change-Id: I044dd10920204b53df44798e41d15fb435750eb4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3827708
Commit-Queue: Samuel Huang <[email protected]>
Reviewed-by: Josh Simmons <[email protected]>
Reviewed-by: Emilia Paz <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036014}
[Autofill Assistant] Add ParseSingleTagXml action to extract data from single tag Xml
- We have created a new action which will read data from the given input client memory key. It will validate that the stored data is single tag Xml.
- This action will then extract values from the single tag Xml for the given set of keys/attributes using java parser.
- Once, the required data has been extracted, it will then store it in the given output client memory key.
- Required error handling where data cannot be parsed or given data is signed has been take care by sending appropriate client action status back to the server.
- Added unit tests.
Bug: b/241884506
Change-Id: If21b1091bfc604a5c0a3c8c99e8889aa3d4eaa66
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3830128
Reviewed-by: Florian Gauger <[email protected]>
Commit-Queue: Vinit Solanki <[email protected]>
Reviewed-by: Shashank Jain <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036013}
Roll SwiftShader from 3fb7084b02d7 to 5ac9bd16c803 (1 revision)
https://swiftshader.googlesource.com/SwiftShader.git/+log/3fb7084b02d7..5ac9bd16c803
2022-08-17 [email protected] Regres: Update test lists @ a6c3e363
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-chromium-autoroll
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86
Bug: None
Tbr: [email protected]
Change-Id: Ib9a9a54fb44501a8850a403fffff4181b287cd96
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834528
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036012}
Use Sdk 33 constants in WebAPK notification delegation code.
Bug: 1298514
Change-Id: I9272064857007ec9d3bf816c9b68b6331dba37bc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3829704
Reviewed-by: Glenn Hartmann <[email protected]>
Commit-Queue: Michael van Ouwerkerk <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036011}
Roll Chrome Mac Arm PGO Profile
Roll Chrome Mac Arm PGO profile from chrome-mac-arm-main-1660694323-1852380f4185ea1ff9a2df04304a8be582950df2.profdata to chrome-mac-arm-main-1660715759-c9f51dd72bf9a894f0a18bf4b3d2169a2d6520b0.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-arm-chromium
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:mac-chrome
Tbr: [email protected]
Change-Id: Icbbd830aa4aaa17d87e67b94337ebb63f1b00ee8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3835631
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036010}
[beacon-api] Support `Blob` type in POST beacon's `setData()`
- Support setting & sending `Blob` and file-like object
- Specify data limit for `ArrayBuffer*` types and throws exception when exceeding, which is the same as what `navigator.sendBeacon()` [does][1].
- Throws `TypeError` when getting `ReadableStream` type.
- Throws `RangeError` when getting multi-parts data.
[1]: https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/modules/beacon/navigator_beacon.cc;l=115-117;drc=52f474916bdf33918223ad8254a333b5d517ee6c
Based on https://crrev.com/c/3826326
Bug: 1293679
Change-Id: I2c86efda3617910012d4a97e48642d1cd800e1a4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3823144
Reviewed-by: Yutaka Hirano <[email protected]>
Reviewed-by: Daniel Cheng <[email protected]>
Reviewed-by: Rakina Zata Amni <[email protected]>
Commit-Queue: Ming-Ying Chung <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036009}
[Autofill Assistant] Fixing QR Code model issues
Issue: When we call promptQrCode function two times in DSL script, the function was not working properly second time.
Cause and fix:
We noticed that we were using same model across the lifetime and hence when the action was triggered second time, it had some values set previously which was causing this issue.
As a fix for this, we are now creating a new model when action is started and in ClearQrCodeScanUi (which is called at the end of action), we will make it nullptr.
This will ensure:
1. New model is created for every action.
2. Model is deleted after action is completed.
Bug: b/241884506
Change-Id: I723d8d5bb41b80052478fe8c06fb762a7da8dbaf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3833633
Reviewed-by: Shashank Jain <[email protected]>
Reviewed-by: Florian Gauger <[email protected]>
Commit-Queue: Vinit Solanki <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036008}
[sheriff] Disable failing PasswordGenerationIntegrationTest test
Failing test:
PasswordGenerationIntegrationTest#testManualGenerationCancel
Bug: 1353701
Change-Id: Id9c576692e05d04ff6b1e16573b4426b9a9b5842
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834178
Reviewed-by: Alex Ilin <[email protected]>
Commit-Queue: Benoit Lize <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036007}
Skip raster invalidation for chunks that do not draw content
This patch generalizes an existing optimization, for a single
non-draws-content display item, to check if the chunk contains no
drawable content. Importantly, this new approach will skip raster
invalidation checks for empty chunks, which leads to a 10% improvement
on a virtual scroller testcase.
Bug: 1340881
Change-Id: I37a2c8f8b371142a0f656ae442f8db874dc09586
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832921
Reviewed-by: Delan Azabani <[email protected]>
Commit-Queue: Philip Rogers <[email protected]>
Reviewed-by: Xianzhu Wang <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036006}
bindings: Add argument type checks to ObservableArray<T>
Performs type checks for arguments of trap functions and throws
a TypeError if a type is wrong.
Bug: 1352549
Change-Id: I66df3a9eeae5e4f44bdf714666a2c6304ebec0f5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3835494
Auto-Submit: Yuki Shiino <[email protected]>
Reviewed-by: Kentaro Hara <[email protected]>
Commit-Queue: Kentaro Hara <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036005}
Adding base::Location to GpuProcessHost::CallOnIO parameters
the FROM_HERE macro is called within the CallOnIO function, which
doesn't give much information on who calls the function, this cl
moves the FROM_HERE macro call to the caller of
GpuProcessHost: :CallOnIO posts tasks on the main thread, right now
GpuProcessHost: :CallOnIO.
Bug: b/242556313
Change-Id: I779125763ad098cddbc49ea7e3bc684d26936fee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834113
Reviewed-by: Alexander Timin <[email protected]>
Commit-Queue: Omar Elmekkawy <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036004}
[BrowserFragment] Add a SurfaceHolder.Callback to manage SurfaceView events.
This registers a SurfaceHolder.Callback when the SurfaceView is attached to the Window and the SurfaceView ViewHierarchy is only attached when the surfaceCreated()-callback is called as the host token is not available before that.
Releasing the SurfaceControlViewHost happens when the Fragment is detached.
Change-Id: I6dd945518c53120dc19964dfb92ef50c5cc9b850
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3816281
Reviewed-by: Ken Buchanan <[email protected]>
Reviewed-by: Clark DuVall <[email protected]>
Commit-Queue: Susanne Westphal <[email protected]>
Reviewed-by: Rayan Kanso <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036003}
Roll abseil_revision 6d806da76f..547802119d
Change Log:
https://chromium.googlesource.com/external/github.com/abseil/abseil-cpp/+log/6d806da76f..547802119d
Full diff:
https://chromium.googlesource.com/external/github.com/abseil/abseil-cpp/+/6d806da76f..547802119d
Bug: None
Change-Id: If9850b203d6e03b85111a85e51153ec3853f7096
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834547
Reviewed-by: Mirko Bonadei <[email protected]>
Auto-Submit: Danil Chapovalov <[email protected]>
Commit-Queue: Mirko Bonadei <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036002}
Move attributeStyleMap to ElementCSSInlineStyle
Per spec, it should be on the ElementCSSInlineStyle mixin instead of on
the Element interface.
Should fix remaining part of 807008.
Bug: 807008
Change-Id: I60ae47130e4cb1d4f0a2477bca04ccba27cd8027
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3828238
Reviewed-by: Anders Hartvoll Ruud <[email protected]>
Reviewed-by: Philip Jägenstedt <[email protected]>
Commit-Queue: Rune Lillesveen <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036001}
[Fallbacks] Fill in textarea fields using the context menu
Prior to this CL, the textarea fields were not filled using the
autofill context menu due to couple of reasons:
1. The field renderer id is not set for the textarea fields so the
context menu would not fill them.
2. There were checks for WebInputElement in the renderer in
FillFieldWithValue that returns null for the textarea fields.
This CL fixes the above alongwith some cleanups.
Bug: 1344455, 1325811
Change-Id: I3c5c80738221a711db3b3deae045df50b174718a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3804639
Commit-Queue: Vidhan Jain <[email protected]>
Reviewed-by: Stefan Zager <[email protected]>
Reviewed-by: Christoph Schwering <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1036000}
Roll DevTools Frontend from 46b85ee0a9a7 to 5db934b91736 (2 revisions)
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/46b85ee0a9a7..5db934b91736
2022-08-17 [email protected] Improve message in CSS hints and handle editing better
2022-08-17 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: chromium:1178508
Tbr: [email protected]
Change-Id: If4793c45c5d94560790a1c328c95ac34d5adfdb8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834901
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035999}
Add account addition test support in FakeAccountManagerFacade
This cl moves the DummyAddAccountActivity from
AccountPickerBottomSheetTest to FakeAccountManagerFacade and renames
it to AddAccountActivityStub.
This will let testing add account flow in different entry points easier.
Bug: 1352486
Change-Id: I3bcfeb137c8ebab86e404f6af5882c7209d79819
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3830015
Reviewed-by: Boris Sazonov <[email protected]>
Commit-Queue: Tanmoy Mollik <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035998}
PageLoadMetrics: Prerender2 support for EarlyHintsPageLoadMetricsObserver
This CL makes EarlyHintsPageLoadMetricsObserver records metrics if the
page is prerendered and activated. UMAs PageLoad.Clients.EarlyHints.*
are affected and this CL renames PageLoad.Clients.EarlyHints.* to
PageLoad.Clients.EarlyHints2.*. The effects are the following:
- All PageLoad.Clients.EarlyHints2.*:
- Include samples from prerendered pages.
- PageLoad.Clients.EarlyHints2.Preload.PaintTiming.NavigationToFirstContentfulPaint
- The value is modified as activation start origined for prerendered
pages.
- PageLoad.Clients.EarlyHints2.Preload.PaintTiming.NavigationToLargestContentfulPaint2
- The value is modified as activation start origined for prerendered
pages.
For the complete list, see [1].
[1] https://docs.google.com/spreadsheets/d/1IhBvEq4Fa3mRob0LFaIpsH4g9E8WRVD8RjXnbxxmThI/edit?pli=1#gid=592018921
Bug: 1317494
Change-Id: I1c771002da6729774f9560e126751aedd8f3c2f5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832984
Reviewed-by: Kouhei Ueno <[email protected]>
Reviewed-by: Kenichi Ishibashi <[email protected]>
Reviewed-by: Takashi Toyoshima <[email protected]>
Commit-Queue: Ken Okada <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035997}
[iOS] Change pipes to backticks in /ios/chrome/browser/download
Please review the CL to ensure that nothing is broken and the script
didn't miss some pipes.
This should allow us to have a better formatting in Xcode.
This CL was uploaded by git cl split.
[email protected]
Bug: 1311955
Change-Id: I3bfe12633a3bad20d9a1fb2c6827483fc4fcdf5d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834169
Auto-Submit: Gauthier Ambard <[email protected]>
Reviewed-by: Ewann Pellé <[email protected]>
Commit-Queue: Ewann Pellé <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035996}
Roll WebRTC from 0cf140d720e1 to 723f19d230e7 (9 revisions)
https://webrtc.googlesource.com/src.git/+log/0cf140d720e1..723f19d230e7
2022-08-17 [email protected] Roll chromium_revision 61b1dc0d85..73d2f8e653 (1035720:1035926)
2022-08-16 [email protected] Roll chromium_revision 9079ff6a0a..61b1dc0d85 (1035583:1035720)
2022-08-16 [email protected] Roll chromium_revision 5ddcf683a5..9079ff6a0a (1035358:1035583)
2022-08-16 [email protected] Clean VideoReceiveStream2 includes
2022-08-16 [email protected] Move VideoStreamBufferController to packet sequence
2022-08-16 [email protected] Prepare rtc::Event to take on webrtc::TimeDelta dependency.
2022-08-16 [email protected] Adopt absl::string_view in modules/audio_processing/
2022-08-16 [email protected] Updated associated payload types without recreating receive streams.
2022-08-16 [email protected] Improve sanity checks
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in WebRTC: https://bugs.chromium.org/p/webrtc/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: [email protected]
Change-Id: Ie8733e0a76a1d2a4b7c09f4c358ba5e369d8ae99
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3835383
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035995}
Tie-break legacy keysets when cryptohome has many
Update the ChromeOS login code to select the lexicographically smallest
key label among all "legacy-" keys. In practice, this will almost always
mean the "legacy-0" key is chosen for doing the authentication.
The background is that apparently there are users in the wild who have
multiple "legacy-N" keysets configured in their cryptohome. In that
case, the Login code was proceeding with a random one, which was
unpredictable behavior and broke some users. The commit changes the
selection to be deterministic (not depending on the order of file
listing in cryptohome or map<> items serialization in protobuf), and
applies a speculative fix for the affected users: authenticating against
"legacy-0" if it's present.
Bug: 1350946
Change-Id: I00f09cdb8b2ada59efc9514bb0cd5dfb4cfe2323
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3829532
Reviewed-by: Roman Sorokin <[email protected]>
Reviewed-by: Martin Bidlingmaier <[email protected]>
Commit-Queue: Maksim Ivanov <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035994}
OOBE: Include GuestTos screen in OOBE Metrics
Include Guest ToS screen in the following UMA histograms:
- OOBE.StepShownStatus
- OOBE.StepCompletionTime
- OOBE.StepCompletionTimeByExitReason
Bug: b/242679991
Change-Id: Icfc60e9f968a2245726eac4ee9fca9de769feedf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3827218
Reviewed-by: Roman Sorokin <[email protected]>
Commit-Queue: Osama Fathy <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035993}
Revert "cros: add a cache for highlight border overlay"
This reverts commit b1f3e6bde4c2e7fea1359eb9ca0dba48bbab46e0.
Reason for revert: Suspect as a culprit for https://crbug.com/1353700
Original change's description:
> cros: add a cache for highlight border overlay
>
> HighlightBorderOverlay is using dynamically generate images with
> NinePatchLayers. However, the replaced image source is not removed which
> may cause performance issue.
>
> This cl adds a cache of the source images for different highlight border
> appearance. The highlight border overlay is mainly featured by its
> highlight color, border color and rounded corner radius. Each dark and
> light mode has only one set of highlight and border colors. The windows
> that are using HighlightBorderOverlay have three different rounded
> corner radius. Therefore, the cache size of source images is acceptable.
> However, when dynamic color is enabled or the HighlightBorderOverlay is
> applied to more window types, the cache size may be increased. We need
> to take care of it if the cache size is too large.
>
> Manually test that with the same pixel ref of the source image,
> UIResourceManager will not create a new resource.
>
> Bug: 1353075
> Change-Id: Ic9be06a75b2d8b80c2c8d5bf4734ee6a6d9ce37b
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3829092
> Commit-Queue: Xiaodan Zhu <[email protected]>
> Reviewed-by: Xiyuan Xia <[email protected]>
> Reviewed-by: Xiaodan Zhu <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1035771}
Bug: 1353075, 1353700
Change-Id: Ib6afae528b0bd3642c863c68ae09451f851da6cc
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3835665
Owners-Override: Roman Sorokin <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Commit-Queue: Roman Sorokin <[email protected]>
Reviewed-by: Roman Sorokin <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035992}
Update V8 to version 10.6.188.
Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/fe3bd282..8444c40e
Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues
Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_chromeos_msan_rel_ng
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel
[email protected],[email protected],[email protected]
Change-Id: I74ab87d45b16578e5bd7647edeb10d84ca3507bb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834510
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1035991}
[OOBE]: Check that LDHost exists before calling
Bug: 1353098
Change-Id: If79b99cd05ea7299209a448fe31bd9a16b8ccf19
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832672
Reviewed-by: Roman Sorokin <[email protected]>
Commit-Queue: Danila Kuzmin <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035990}
[Fallbacks] Hide Autofill popup if it overlaps with the context menu
Bug: 1325811
Change-Id: Ifef87469031fa202801d58335719f0973f24fe27
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3762492
Commit-Queue: Vidhan Jain <[email protected]>
Reviewed-by: Avi Drissman <[email protected]>
Reviewed-by: Christoph Schwering <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035989}
[CCTBrand] Disable branding for BrApp CCT
Bug: 1341138
Change-Id: I1f043636a11190fdeec5f529cd40a47c92529e0d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832964
Auto-Submit: Wenyu Fu <[email protected]>
Commit-Queue: Peter Conn <[email protected]>
Reviewed-by: Peter Conn <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035988}
[iOS] Change pipes to backticks in /ios/chrome/browser/credential_provider
Please review the CL to ensure that nothing is broken and the script
didn't miss some pipes.
This should allow us to have a better formatting in Xcode.
This CL was uploaded by git cl split.
[email protected]
Bug: 1311955
Change-Id: I23f683f8b21f594f7d621566958353c9418463c7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834311
Commit-Queue: David Jean <[email protected]>
Auto-Submit: Gauthier Ambard <[email protected]>
Reviewed-by: David Jean <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035987}
OOBE - Polymer3 - Rename core oobe files
Rename oobe_polymer3.js and oobe_polymer.html to oobe.html/.js.
Since no other version of OOBE exists, the explicit mentioning of
Polymer3 is no longer relevant. Also remove oobe.html from the
manual GRD file because no <includes> are needed for it.
Bug: 1184731
Change-Id: I526cc6f2dc07282b50e3abc71c608478081c505f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834164
Commit-Queue: Renato Silva <[email protected]>
Reviewed-by: Roman Sorokin <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035986}
[Public Session] Media access handler - Rip out dead code
Rip out all Public Session related code since PS is deprecated, and MGS
(Managed Guest Session) is the replacement ("PS v2").
First CL that removed DeviceLocalAccountManagedSessionEnabled policy:
crrev.com/c/3784794 -> as a consequence
|ArePublicSessionRestrictionsEnabled| will always return false.
Background: that policy is set to true since years ago, and the
restrictions enabled helper function was returning false, hence
this is all dead code being cleaned up.
Bug: b/233592812
Change-Id: I3386884a459f890632530350db18c8bdb19abd36
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3823065
Reviewed-by: John Rummell <[email protected]>
Commit-Queue: Ivan Šandrk <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035985}
[Telemetry] Add documentation for the current API
This CL adds documentation to /docs around the current architecture of
the Telemetry Extension. This document is targeting OEMs that want to
develop against the API.
Bug: b/241514978
Test: n/a
Change-Id: Ic7cd547cf9e8cff6983354ec2dcddc7d9ba61b73
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3811521
Reviewed-by: Oleh Lamzin <[email protected]>
Commit-Queue: Bastian Kersting <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035984}
Reland "[BrowserFragment] Programmatically create Tabs"
This is a reland of commit cbb1a41de09da72b667371b9a85513608be1fbe7
which contained a mistake from rebasing which is fixed in Patchset 3.
Original change's description:
> [BrowserFragment] Programmatically create Tabs
>
> - Sets FOREGROUND_TABS by default to active.
> - Add create Tab function to create tabs in the background
> - Update BrowserFragment-shell to demonstrate preloading of tab content.
>
> Change-Id: I892f58f7a72700a897a2951ac5101de5a7ef5909
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3811218
> Commit-Queue: Susanne Westphal <[email protected]>
> Reviewed-by: Rayan Kanso <[email protected]>
> Reviewed-by: Robert Sesek <[email protected]>
> Reviewed-by: Clark DuVall <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1035448}
Change-Id: Idb033168edd119bb38b55a07ff930b36a8b332ee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832664
Reviewed-by: Clark DuVall <[email protected]>
Commit-Queue: Susanne Westphal <[email protected]>
Reviewed-by: Ken Buchanan <[email protected]>
Reviewed-by: Rayan Kanso <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035983}
Roll Chrome Win64 PGO Profile
Roll Chrome Win64 PGO profile from chrome-win64-main-1660694323-a0df662925b72bd3e97141633addc5c57296028b.profdata to chrome-win64-main-1660705020-f9f76813a388dd9cf2da15d6d80f03f32c6c2896.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win64-chrome
Tbr: [email protected]
Change-Id: I6acf7e7989c5e76bec1315501b0c2758315a4a74
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834893
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035982}
Roll Chrome Win32 PGO Profile
Roll Chrome Win32 PGO profile from chrome-win32-main-1660694323-bf66eed84fef168c9923b22ad1faccf167b9ef65.profdata to chrome-win32-main-1660705020-8cae24c037275a8529d60f3d361f009d45951634.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win-chrome
Tbr: [email protected]
Change-Id: I8a4dfd5b6f8aef9a05a8820b0949573d896f21c1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3835128
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035981}
Lacros: Add an Account Manager API to report auth errors
Add an API - `AccountManagerFacade::ReportAuthError()` to report OAuth
errors. These errors will be fanned out to `AccountManagerFacade`
observers.
This CL adds the API stub. Following CLs will add the actual
implementation.
Design Doc: http://shortn/_hKoc0VqbIt
Bug: 1226055, 1312897
Change-Id: I35d7c8e6cfad6b1dfab5fb363c7430effc7f2c0a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832223
Commit-Queue: Kush Sinha <[email protected]>
Reviewed-by: Anastasiia N <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035980}
Roll Chrome Linux PGO Profile
Roll Chrome Linux PGO profile from chrome-linux-main-1660694323-3b8689f41924fd0b08a6a97ee0a53899a85546f3.profdata to chrome-linux-main-1660715759-6fd7688957ac352f6a31883b1956029821b7e078.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-linux-chromium
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:linux-chrome
Tbr: [email protected]
Change-Id: I3c8779dc2f0dbe7af7962f3d5c78ea318269aee9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3835132
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035979}
Add UserDirectoryIntegrityManager class
Create UserDirectoryIntegrityManager class for tracking the state of
incomplete users.
Bug: b/239420309
Change-Id: I99f33cd73a94cf9c0f89d57e30e0515ce82c3c2a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3780464
Reviewed-by: Xiyuan Xia <[email protected]>
Commit-Queue: Elie Maamari <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035978}
Fix ozone_unittests
Test: ran tests locally
Bug: none
Change-Id: Ic81ad638aa7dc061e950e0467c23d57962e428c6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3835662
Reviewed-by: Alexander Dunaev <[email protected]>
Commit-Queue: Maksim Sisov <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035977}
Fix abort during
LockStateController::StartUnlockAnimationAfterUIDestroyed
Handle the case where the unlock animation is aborted during
LockStateController::StartUnlockAnimationAfterUIDestroyed by pressing
the power button in tablet mode.
Bug: b/234146799
Change-Id: Idf63c43dea5f92171bd615b2ddabec4ec8767642
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3794115
Reviewed-by: Mitsuru Oshima <[email protected]>
Commit-Queue: Elie Maamari <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035976}
[FastCheckout] Connect CapabilitiesFetcher to cache and request processor.
This CL adds the implementation of FastCheckoutCapabilitiesFetcherImpl.
Follow-up work will introduce metrics to measure the performance of
the capabilities fetcher.
Bug: 1350456, 1334642
Change-Id: If9d9d5561ebc164fd4ef098733fe1d0ce8a6b3c3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3828234
Reviewed-by: Norge Vizcay <[email protected]>
Commit-Queue: Jan Keitel <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035975}
Enable WebAppProvider in Kiosk session
WebAppProvider was disabled in Kiosk due to conflict with Kiosk
accessibility menu (https://crbug.com/1180380). This CL disables the
creation of system web app handlers in Kiosk so that we can enable
WebAppProvider and use it to install web apps in Kiosk. Changes are
guarded by feature flag KioskEnableAppService.
Bug: b:240493670
Change-Id: I93822f399667fe5b18a78347fb5c908fba8293ae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3833515
Reviewed-by: Jiewei Qian <[email protected]>
Reviewed-by: Alan Cutter <[email protected]>
Commit-Queue: Yi Xie <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035974}
[Passwords] Disable flaky TwoBrowsersClosingShutdownHistograms on Mac
Bug: 1259913
Change-Id: I4c63a0afc4f104eb95187309e56e01adbcbd90a0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834162
Reviewed-by: Marc Treib <[email protected]>
Commit-Queue: Maxim Kolosovskiy <[email protected]>
Reviewed-by: Maxim Kolosovskiy <[email protected]>
Owners-Override: Maxim Kolosovskiy <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035973}
Roll Skia from d121e0a831fa to 545157bb176d (3 revisions)
https://skia.googlesource.com/skia.git/+log/d121e0a831fa..545157bb176d
2022-08-17 [email protected] Roll ANGLE from e79c9cd63053 to 213a1ee6e6db (4 revisions)
2022-08-17 [email protected] Roll SwiftShader from a6c3e363b7a9 to 3fb7084b02d7 (3 revisions)
2022-08-17 [email protected] Roll Dawn from c8b0cfe7e308 to 1130a602efc9 (4 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Cq-Do-Not-Cancel-Tryjobs: true
Bug: None
Tbr: [email protected]
Change-Id: I6fa0f7148491f42e3adb747c6f2d2f92f33210e1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3835327
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035972}
Remove PrefersContrast RuntimeEnabledFeature
This media feature shipped a while ago, so remove the feature and
related checks in the code.
[email protected]
Change-Id: I85187d7950ac923556f46bd9e1c3bd0c6e82ea66
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3835090
Commit-Queue: Rune Lillesveen <[email protected]>
Reviewed-by: Rune Lillesveen <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035971}
More strict request body handling in PendingBeacon
content::PendingBeaconService cannot handle request body with
multiple data elements (which is used when a FormData is given),
given a SimpleURLLoader restriction. Let's be strict and reject such
a request body in PendingBeaconHost::SetRequestData.
This allows us to store an optional<DataElement> rather than
vector<DataElement> in PendingBeaconHost, and that simplifies the
request body handling in PendingBeaconService::SendBeacons.
This change also adds DataElement::Clone() which is callable only
when the data element is copyable.
Bug: 1293679
Change-Id: I69bdddb146d16aefb928e11f477c92c51890ecea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3826326
Reviewed-by: Daniel Cheng <[email protected]>
Reviewed-by: Rakina Zata Amni <[email protected]>
Commit-Queue: Yutaka Hirano <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035970}
network task unittest: don't leak NetworkTasks
NetworkTasks unregisters as a NetworkObserver during it's destruction.
Hence, by leaking NetworkTasks, we're making the following race
condition possible: NCN firing a Network event on the network thread
while the test environment is being destructed on the main thread. In
this case, NCN will reference the network thread task runner after
it has been destructed, leading to a use after free.
As an additional cleanup, move the EXPECT calls used by the helper
functions to the main thread from the network one (otherwise tests
would silently on EXPECT failures).
Bug: 1338023
Change-Id: Iefbff94b8a3b92be5f897dd96b2c591b1441efc6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3805660
Reviewed-by: Ryan Hamilton <[email protected]>
Commit-Queue: Stefano Duo <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035969}
Refactor browser_window_state to use PrefService::GetValueDict
This is part of a larger migration effort based on
go/trust-your-prefs.
Bug: 1341996, 1187061
Test: Existing unit tests
Change-Id: I76eeb7ab84c689ec03e9ed2f41cc4bb88cc001f5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3827217
Reviewed-by: Elly Fong-Jones <[email protected]>
Commit-Queue: Roland Bock <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035968}
Check metrics and MSBB before reporting progress
Bug: b/242136158
Change-Id: Ie81747a8b4c307f35b4709bb69af6250d4abc4f5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3829277
Reviewed-by: Florian Gauger <[email protected]>
Commit-Queue: Julie Hockett <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035967}
Disable flaky CanRecropOriginalTrackAfterCloneIsGarbageCollected on Mac
Bug: 1353349
Change-Id: Ie1b9e888de319c77752d21050bfe3bc8855b49a9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834109
Reviewed-by: Maxim Kolosovskiy <[email protected]>
Owners-Override: Maxim Kolosovskiy <[email protected]>
Reviewed-by: Marc Treib <[email protected]>
Commit-Queue: Maxim Kolosovskiy <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035966}
Create form_data_importer_utils_unittest and test TimestampedSameOriginQueue.
This is an effort to simplify the gigantuous
form_data_importer_unittest.cc.
By testing TimestampedSameOriginQueue separately, the multi-step import
and form association tests can be simplified, as they can rely on the
tested properties of TimestampedSameOriginQueue.
Follow-up CLs will move/simplify these tests and move them to the
utils_unittest file.
The CL also moves the class out of the internal namespace, as it now has
an ok-ish interface and is tested.
Bug: 1313367
Change-Id: I72af82dea91ffb2acc599808d5161547fc1b7c1d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3828229
Commit-Queue: Florian Leimgruber <[email protected]>
Reviewed-by: Christoph Schwering <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035965}
Adds AXTreeSerializer for Screen AI
This patch creates a serializable tree and a tree source that will
attempt to serialize the set of accessibility nodes produced by the Screen AI
service, so that they could be:
A) validated for correctness.
B) Turned into a tree update by the serializer to be sent to the requesting process.
[email protected], [email protected]
AX-Relnotes: n/a.
Bug: 1248380
Change-Id: I233a9b11082e8788ceaf3ed711a5a293b09b63de
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3827297
Commit-Queue: Ramin Halavati <[email protected]>
Auto-Submit: Nektarios Paisios <[email protected]>
Reviewed-by: Nektarios Paisios <[email protected]>
Reviewed-by: Ramin Halavati <[email protected]>
Reviewed-by: David Tseng <[email protected]>
Reviewed-by: Joe Mason <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035964}
Roll DevTools Frontend from 040f5271c84a to 46b85ee0a9a7 (2 revisions)
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/040f5271c84a..46b85ee0a9a7
2022-08-17 [email protected] [component] Add a BreakpointListView component
2022-08-17 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS (trusted-origins)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: chromium:1324904,chromium:1346231
Tbr: [email protected]
Change-Id: I0fa8b2d416c17b70e889e41e944bc085e3469b09
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834708
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035963}
Removed register/unregister API for ondemand segment selection
The registration API for ondemand segment selection was deprecated in
favor of a pull model. This CL does some cleanup. More cleanup to follow
that removes the trigger context and associated tab helpers.
Bug: 1346619
Change-Id: I56aa39e5abd0089513f5f6c95dfc3ab6227d936f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3830067
Reviewed-by: Siddhartha S <[email protected]>
Commit-Queue: Shakti Sahu <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035962}
Add field trial params for ChromeOSARCVMReclaimThrottle
This is required in support of http://cl/467859805 which expands
the Finch study to Beta.
Contents fully auto-generated with:
$ blaze run googleclient/chrome/finch/analysis:fieldtrial_testing_config_entry -- --config_path=`pwd`/googledata/googleclient/chrome/finch/gcl_studies/chrome_os/ChromeOSARCVMReclaimThrottle.gcl --group_name='EnabledGroupMedium_20220808'
BUG=b:227251697
TEST=lint
Change-Id: I096b9f8eb1dadd3092285ed738280ec3e6344a46
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3833763
Reviewed-by: Yusuke Sato <[email protected]>
Commit-Queue: Alexandre Marciano Gimenez <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035961}
FrameSet NG: Implement NGFrameSetPainter::PaintObject()
This CL ports FrameSetPainter::Paint() to NGFrameSetPainter.
This CL has no behaivor changes due to a disabled runtime flag.
Bug: 1346221
Change-Id: Iff54a81dc24a3575b31e5af8654c1ce933b212e1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3835491
Commit-Queue: Kent Tamura <[email protected]>
Auto-Submit: Kent Tamura <[email protected]>
Commit-Queue: Koji Ishii <[email protected]>
Reviewed-by: Koji Ishii <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035960}
ServiceWorker: Don't run update check during browser shutdown
This CL checks if the browser is shutting down in
ServiceWorkerUpdateChecker::OnResourceIdAssignedForOneScriptCheck().
This avoids ServiceWorkerProcessManager::browser_context() access that
returns nullptr during browser shutdown.
Bug: 1351543
Change-Id: Iae3bb2a531a6e55dc0f6371f21ec09bad093093e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3835490
Commit-Queue: Hiroki Nakagawa <[email protected]>
Reviewed-by: Yoshisato Yanagisawa <[email protected]>
Reviewed-by: Kouhei Ueno <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035959}
Roll libc++ from 5df82514bc00 to 9de2fe040375 (8 revisions)
https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/5df82514bc00..9de2fe040375
2022-08-16 [email protected] [libc++] Improve updating data files.
2022-08-16 [email protected] [libc++][format] Improve format buffer.
2022-08-16 [email protected] [test][libcxx] Don't XFAIL passing test with HWASAN
2022-08-16 [email protected] [test][libcxx] Use own feature for HWAsan
2022-08-16 [email protected] [test][libcxx] Disable new.delete.array tests for HWAsan
2022-08-15 [email protected] Enable -Wctad-maybe-unsupported in LLVM build
2022-08-15 [email protected] [libc++] Implement `operator<=>` for `error_{code,condition}`
2022-08-15 [email protected] [libc++] Implement `operator<=>` for `error_category`
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/libcxx-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: [email protected],[email protected]
Change-Id: I05dda1b21db7843290f989f14e18e528088bc413
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3835504
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035958}
Fix recursive watches not being deleted
Replaces the use of lower_bound() with upper_bound() in
file_path_watcher_inotify.cc.
When `changed_dir` is being watched, the loop to remove the watches
contained in that directory immediately terminates because `changed_dir`
is not its own parent.
Using upper_bound() fixes this problem by ensuring that `changed_dir` is
not iterated.
Fixed: 1252325
Change-Id: I8ac4469f3bd6b8a3af480db3a08b145e58ae279d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3826018
Reviewed-by: Lei Zhang <[email protected]>
Commit-Queue: Steffen Seckler <[email protected]>
Auto-Submit: Steffen Seckler <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035957}
[FilesTrash] Show "Original file location" in quick view for Trash
Migrate the current implementation of Trash to show the original file
location in the Quick view instead of showing it inline as a breadcrumb.
Bug: b:238946031
Test: browser_tests --gtest_filter=*trash*
Change-Id: Ie710051fec36fa3cd4205dc078362cb16f560dbc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3833628
Reviewed-by: Luciano Pacheco <[email protected]>
Commit-Queue: Ben Reich <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035956}
FrameSet NG: Use NGFrameSetLayoutAlgorithm for LayoutNGFrameSet
This CL has no behavior changes due to a disabled runtime flag.
Bug: 1346221
Change-Id: I17eed6207e9547ea5d3e5e2e0601f18644398319
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3835489
Commit-Queue: Kent Tamura <[email protected]>
Auto-Submit: Kent Tamura <[email protected]>
Commit-Queue: Koji Ishii <[email protected]>
Reviewed-by: Koji Ishii <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035955}
ForeignObject NG: Enable the feature by default again
This CL switches the implementation of SVG <foreignObject> to one based
on LayoutNG.
The first try was reverted due to a regression, and the regression was
fixed by crrev.com/1035923.
Bug: 989916
Change-Id: Ia3dbfde41726c3350b8b273f90705b8ea8101ae1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832610
Auto-Submit: Kent Tamura <[email protected]>
Commit-Queue: Koji Ishii <[email protected]>
Reviewed-by: Koji Ishii <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035954}
Roll src-internal from 1c534010f828 to 2a1b82d6bf3d (1 revision)
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1c534010f828..2a1b82d6bf3d
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: [email protected]
Change-Id: I7ae3bccca5cc579f43576dd2e3ed7bc2537ad13e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3835001
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1035953}
Reland "Password Manager new UI: Add empty skeleton and feature flag"
This is reland of: https://chromium-review.googlesource.com/c/chromium/src/+/3815446
In this version password_manager_strings.grdp is renamed to
password_manager_strings_ui.grdp to fix the problem with translation
pipeline.
Bug: 1350947
Change-Id: I436284d1749a968d590a8ab56dd44255c165de8a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3829094
Reviewed-by: Vasilii Sukhanov <[email protected]>
Reviewed-by: Rebekah Potter <[email protected]>
Commit-Queue: Viktor Semeniuk <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035952}
Roll Website from 578e4cdc5efb to 00a10042ab33 (1 revision)
https://chromium.googlesource.com/website.git/+log/578e4cdc5efb..00a10042ab33
2022-08-17 [email protected] Unify mixed markdown syntax with HTML syntax.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/website-chromium
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Website: https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: chromium:1352890
Tbr: [email protected]
Change-Id: I7ff832d951920b8b52870e173777764cff497cdd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834894
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035951}
Implement preconnect in WebTestClient & enable preconnect test
Part of the implementation for preconnect is in the browser layer.
So far content-shell/WebTest did not support preconnect/dns-prefetch
at all, and those hints would silently fail.
This patch leverages the existing SimpleNetworkHintsHandler, currently
utilized by chromium clients other than chrome (e.g. Chromecast), and
adds preconnect support to that handler.
In addition, it binds that handler to WebTestContentRendererClient so
that the content shell variant used by WPT can take advantage of the
feature (and test it).
Bug: 1352009
Change-Id: I7c5f68cbafde92a52c05fc6bd0ac12497001355a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3829554
Reviewed-by: Avi Drissman <[email protected]>
Reviewed-by: Yutaka Hirano <[email protected]>
Commit-Queue: Noam Rosenthal <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035950}
Roll SwiftShader from c61fc9aec162 to 3fb7084b02d7 (2 revisions)
https://swiftshader.googlesource.com/SwiftShader.git/+log/c61fc9aec162..3fb7084b02d7
2022-08-16 [email protected] Update Marl to 2f129cf1b
2022-08-16 [email protected] update-marl: run Gerrit hook on generated CLs
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-chromium-autoroll
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86
Bug: None
Tbr: [email protected]
Change-Id: Ie06136bbb8efb79e9c79194a36f8cd7896a32e22
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834360
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035949}
[lacros skew tests] Refresh skew tests for M106
This CL updates the ash version ['106.0.5245.0'] for Lacros version skew testing.
If this CL caused regressions, please revert and stop the autoroller
at https://luci-scheduler.appspot.com/jobs/chrome/lacros-version-skew-roller
Also please file a bug to OS>LaCrOS>Partner, and CC [email protected],
[email protected].
[email protected]
Bug: None
Change-Id: I9b48960cc2d96d6bb30bce27d38a695c33649e1f
Requires-Testing: True
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834491
Bot-Commit: Rubber Stamper <[email protected]>
Auto-Submit: chrome-weblayer-builder <chrome-weblayer-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035948}
[String matching] Factor use_edit_distance out of fuzzy matching.
Part of an ongoing effort to streamline FuzzyTokenizedStringMatch.
use_edit_distance is always set to the same value (false) by all
callees of FTSM::Relevance().
Changes in this CL:
1) Factor use_edit_distance out of FTSM.
2) Retain use_edit_distance in SequenceMatcher class for now, because
handling of the two separate strategies (block matching and edit
distance) should occur in its own set of CLs. Swap the order of input
params to constructor, and default use_edit_distance to false.
We are moving in a general direction away from a highly tunable fuzzy
matching interface, towards a more unified approach.
Test: existing
Bug: 1336160
Change-Id: Ic76a97cb690cddf299198af0d242bef79432f7d7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3835422
Reviewed-by: Rachel Wong <[email protected]>
Commit-Queue: Amanda Deacon <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035947}
[Jellybean] Color Internals debug page
- Updates build rules to provide JSON output as a resource to
chrome://color-internals.
- Adds frontend JS logic for building the token table and does some
(very inadequate) styling.
Internal screencast showing the UI: http://go/scrcast/NjMxMzEyNTkyNzE5MDUyOHwwODI3MjA3ZS0yNQ
Followups:
1) Add JS color change logic so the updated tokens are rendered into
the table.
2) Consider using LitHTML to build the front end to give future webui
devs a more concrete example of a "modern" frontend. Not only is
this is a great candidate for building using lithtml declarative
templates, but being able to use TS vars for colors etc was nice,
since it catches spelling errors.
Bug: b:222408581
Change-Id: I536ff5fe5b7178ceb19a46d93bf20a9686e976a1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3823023
Reviewed-by: Dominic Schulz <[email protected]>
Reviewed-by: Zain Afzal <[email protected]>
Commit-Queue: Meredith Lane <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035946}
[anchor-position] Add tests for `position: fixed`
This patch adds tests for `position: fixed` when the anchor is
block fragmented.
This patch has no behavior changes.
Bug: 1309178
Change-Id: I21500ddd570dc9f5f55f02c2a1b023d87621dfa1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834954
Reviewed-by: Yoshifumi Inoue <[email protected]>
Auto-Submit: Koji Ishii <[email protected]>
Commit-Queue: Yoshifumi Inoue <[email protected]>
Commit-Queue: Koji Ishii <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035945}
Refactor TaskManager to use PrefService::GetValueDict
This is part of a larger migration effort based on
go/trust-your-prefs.
Bug: 1341996
Test: Existing unit tests
Change-Id: Ie5b392667724359a7ebc55d4ef58aa407f4c041c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832228
Reviewed-by: Peter Kasting <[email protected]>
Commit-Queue: Roland Bock <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035944}
Refactor security_interstitials to use PrefService::GetValueDict
This is part of a larger migration effort based on
go/trust-your-prefs.
Bug: 1341996
Test: Existing unit tests
Change-Id: Ie95dc0a3931957a3ca774cbc3d2ffbfc8288c117
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834302
Reviewed-by: Carlos IL <[email protected]>
Commit-Queue: Roland Bock <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035943}
Refactor ClipboardRestrictionService to use PrefService::GetValueDict
This is part of a larger migration effort based on
go/trust-your-prefs.
Bug: 1341996
Test: Existing unit tests
Change-Id: Iee16446da94bf9df0cbe8c3314c0ca79120f6922
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3833539
Commit-Queue: Roland Bock <[email protected]>
Reviewed-by: Fabio Tirelo <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035942}
Refactor omnibox to use PrefService::GetValueDict
This is part of a larger migration effort based on
go/trust-your-prefs.
Bug: 1341996
Test: Existing unit tests
Change-Id: Ia48a684e35ddfbac94c796883042f10fc2cf0b0a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832665
Reviewed-by: Mark Pearson <[email protected]>
Commit-Queue: Roland Bock <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035941}
migration: Use ui::ColorProvider to get dim color in WindowDimmer
Prior to this change, the owner' of WindowDimmer object pass color which
is retrieved from the AshColorProvider directly to set the color on the
dim window's layer.
In order to make the color change dynamically on theme changed, this CL implemented AshColorProviderSource which reflects theme information present in the nativeUI NativeTheme and can be used when we want to get a color and there's no related widget anywhere we can plumb
across from.
Also make WindowDimmer a ColorProviderSourceObserver, and use the color provider from the AshColorProviderSource to update the color on dim window's layer on color provider changed.
Fixed: 1351621
Change-Id: I02e4a4d8f301ce71c3282f7cbab6c81e9e493faf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3822222
Reviewed-by: Sean Kau <[email protected]>
Commit-Queue: Connie Xu <[email protected]>
Reviewed-by: Xiaoqian Dai <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035940}
Refactor ProxyConfig to use PrefService::GetValueDict
This is part of a larger migration effort based on
go/trust-your-prefs.
Bug: 1341996
Test: Existing unit tests
Change-Id: Ie47b88996141c27d69e5bf0a82d8b83d12561b3b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3827220
Commit-Queue: Roland Bock <[email protected]>
Reviewed-by: Ted Choc <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035939}
Refactor AccountInfoUtils to use PrefService::GetValueDict
This is part of a larger migration effort based on
go/trust-your-prefs.
Bug: 1341996
Test: Existing unit tests
Change-Id: If147c38eb38565aa0cc69fa8e07bc6a1005ad05b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3827211
Reviewed-by: Roger Tawa <[email protected]>
Commit-Queue: Roland Bock <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035938}
Refactor ExternalProtocolHandler to use PrefService::GetValueDict
This is part of a larger migration effort based on
go/trust-your-prefs.
Bug: 1341996
Test: Existing unit tests
Change-Id: Id935cf82babd87e3013f43943c8a305547547a56
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3830016
Reviewed-by: Dominick Ng <[email protected]>
Commit-Queue: Roland Bock <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035937}
[Autofill Assistant] Add Java Xml pull parser to parse single tag Xml
- Added logic to use Java Xml pull parser to extract attribute values from single tag Xml.
- Utilities have been added in "guided_browsing" component.
- Added unit tests.
Bug: b/241884506
Change-Id: I068ee13ed506c76671325a34162822df39ec518e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3831134
Reviewed-by: Shashank Jain <[email protected]>
Commit-Queue: Vinit Solanki <[email protected]>
Reviewed-by: Florian Gauger <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035936}
Give elevation colors a light mode variant.
Previously the illustration color palette provided elevation colors only
in dark mode, as in elevated surfaces only dark mode colors changed.
However by supplying a general elevation color set which falls back to
the regular colors in light mode we gain the ability to use the variable
without any additional logic surrounding light/dark mode. This makes the
API surface easier to use and as a side effect means illustrations automatically respect forced light/dark mode, such as is possible with
the TS api.
Bug: b/242786611
Change-Id: Iea0715497fd4ca96a0f48942267f450e48ff8961
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3833764
Reviewed-by: Meredith Lane <[email protected]>
Commit-Queue: Zain Afzal <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035935}
Escape path name before constructing GURL
Bug: 1238606
Change-Id: Ifb7f9d7ddd8dfd5172160a816a7bec1e15dc564c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832982
Commit-Queue: François Degros <[email protected]>
Reviewed-by: François Degros <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035934}
Update list Value usage in profile_manager.cc
Only Value::List should be used to access and update list and Values.
Other APIs are all deprecated.
Bug: 1187001, 1338341
Change-Id: I66c888699bd055265dda27378c84b2785bf92ed1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3819819
Reviewed-by: Ramin Halavati <[email protected]>
Commit-Queue: Matt Menke <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035933}
Prerender: Remove method parameter comparison
This CL removes the method parameter comparison part because the
difference of method parameter is detected as the HTTP request headers
difference earlier. This CL instead adds only DCHECK_EQ.
Bug: 1352891
Change-Id: I6a99e3ae3e6713da0b2be5440f985dbbf6b6cbf0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832980
Reviewed-by: Lingqi Chi <[email protected]>
Commit-Queue: Yoshiki Tanioka <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035932}
Roll src-internal from 12e5578d6729 to 1c534010f828 (1 revision)
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/12e5578d6729..1c534010f828
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: [email protected]
Change-Id: I7a3b2868d30bd4582ed7c2513f631210cccdd888
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3835503
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1035931}
Roll DevTools Frontend from ac83fd0b0031 to 040f5271c84a (1 revision)
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/ac83fd0b0031..040f5271c84a
2022-08-17 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS (trusted-versions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: [email protected]
Change-Id: I34102b216bfcbc31ccc6e87e634273e0c533e60f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3835127
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035930}
Refactor QuirksManager to use PrefService::GetValueDict
This is part of a larger migration effort based on
go/trust-your-prefs.
Bug: 1341996
Test: Existing unit tests
Change-Id: I7c89ace9f69a8458a09a02c8a57921accda55d9b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832233
Commit-Queue: Roland Bock <[email protected]>
Reviewed-by: Greg Levin <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035929}
Add the new option to LazyEmbeds to lazily load non-ad frames
This CL will introduce the new option to LazyEmbeds. The new feature
param called `strategy` indicates the way how to decide eligible frames
for LazyEmbeds. If the `strategy` value is "non_ads", the eligibility
detection is based on the Ad Tagging in Chrome. The `strategy` param is
defined with `AutomaticLazyFrameLoadingToEmbedLoadingStrategy` enum,
which has 1) kAllowList: default behavior 2) kNonAds: apply lazy-loading
to non ad related frames.
We don't add this param to `kAutomaticLazyFrametLoadingToEmbeds`, we add
it to `kAutomaticLazyFrameLoadingToEmbedUrls` for the UKM analysis
purpose. We want to measure the number of eligible frames on both
experiment enabled/disabled groups. We'd like to explore
this experiment as one of the effective iframe loading ideas.
Design doc is here.
https://docs.google.com/document/d/1xlERn2N3CaPWrDlnTRi_4Cdq_Cx8xGzTdWtWlZxpY7Y/edit#heading=h.x9lt2svj754v
To avoid apply LazyEmbeds to in-viewport frames, we have a plan to run
this feature with the existing opt-out mechanism [1].
[1] https://chromium-review.googlesource.com/c/chromium/src/+/3781826
Bug: 1247131
Change-Id: I7357b88dcfd34935c2a88daf7d625d12d1380152
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3827940
Reviewed-by: Hiroshige Hayashizaki <[email protected]>
Reviewed-by: Minoru Chikamune <[email protected]>
Commit-Queue: Shunya Shishido <[email protected]>
Reviewed-by: Alex Turner <[email protected]>
Reviewed-by: Kouhei Ueno <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035928}
Roll nearby-connections from 0849bc7598e5 to b57d03425f3f (2 revisions)
https://chromium.googlesource.com/external/github.com/google/nearby-connections.git/+log/0849bc7598e5..b57d03425f3f
2022-08-17 [email protected] Upgrade protobuf from version 2 to 3
> PiperOrigin-RevId: 468078014
>
2022-08-16 [email protected] Remove presence_identity struct.
> PiperOrigin-RevId: 468032143
>
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/nearby-connections-chromium
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:linux-nearby-chrome-fyi
Bug: None
Tbr: [email protected],[email protected],[email protected]
Change-Id: If005f04c7ec2747da16f8b859a8cb390cab02da7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834409
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1035927}
Refactor UserManager to use PrefService::GetValueDict
This is part of a larger migration effort based on
go/trust-your-prefs.
Bug: 1341996
Test: Existing unit tests
Change-Id: I6f707bfc9add0956a3e71ca17068cb78f4df91e8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834306
Commit-Queue: Roland Bock <[email protected]>
Reviewed-by: Achuith Bhandarkar <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035926}
Refactor LockScreenItemStorage to use PrefService::GetValueDict
This is part of a larger migration effort based on
go/trust-your-prefs.
Bug: 1341996
Test: Existing unit tests
Change-Id: I29432bbf71568b97cf6c3d4a2eb1238056d50978
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832386
Commit-Queue: Roland Bock <[email protected]>
Reviewed-by: Reilly Grant <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035925}
Refactor nearby_sharing to use PrefService::GetValueDict
This is part of a larger migration effort based on
go/trust-your-prefs.
Bug: 1341996
Test: Existing unit tests
Change-Id: Ic446eac63f3a361a0a487bc77c5fd1f08e1860df
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3829269
Commit-Queue: Roland Bock <[email protected]>
Reviewed-by: Michael Hansen <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035924}
ForeignObject NG: Do not reuse cached NGConstraintSpace after a size change
Bug: 1352482
Change-Id: Ib4b4a957558fe10812f4be52df2ccb8cb9ddf40a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3827280
Reviewed-by: Ian Kilpatrick <[email protected]>
Commit-Queue: Kent Tamura <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035923}
[mparch] Check prerendering state in DidBlockNavigation.
DidBlockNavigation is called when cross-origin iframes attempt to
navigate the top level browsing without a user gesture. However, a
cross-origin navigation itself is not allowed during prerendering so we
expect that DidBlockNavigation could not be reached. This CL adds a
DCHECK to DidBlockNavigation to ensure it is not in a prerendering
state.
Bug: 1350865
Change-Id: Iefd8c02a11b60c7cf74c2b8f7d6c22d33269d1c5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3814946
Reviewed-by: Kevin McNee <[email protected]>
Commit-Queue: Hyowon Kim <[email protected]>
Reviewed-by: Avi Drissman <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035922}
Fix flaky test: execution-order.sub.html
This CL tries to fix the flakiness of the execution-order.sub.html test.
Important change:
- async_preload and async_blocking_render are renamed to
async_preload_or_blocking_render because there is no ordering
guarantee between these two.
- Before this CL, the contentful paint (FirstPaint) seemed to trigger
random timings, and made the test flaky. This CL inserts a <h1> block
early so that FirstPaint happens at constant timing.
Bug: 1345745, 1340837
Change-Id: I3f48caee7cf97262dfc18c572c0c71a34714a8ed
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3833682
Reviewed-by: Kouhei Ueno <[email protected]>
Commit-Queue: Minoru Chikamune <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035921}
Add class level comment to WebAppProvider regarding on_registry_ready()
This CL adds to WebAppProvider's class level comment to point out that
it can't be used until the on_registry_ready() event has fired.
Bug: 1346038
Change-Id: I4b54877099983882019b4c49f1746f902e202c5d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3831802
Commit-Queue: Alan Cutter <[email protected]>
Reviewed-by: Li Lin <[email protected]>
Auto-Submit: Alan Cutter <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035920}
FrameSet NG: Set up initial geometry
The corresponding code of LayoutFrameSet::UpdateLayout() is:
if (!Parent()->IsFrameSet() && !GetDocument().Printing()) {
SetWidth(LayoutUnit(View()->ViewWidth()));
SetHeight(LayoutUnit(View()->ViewHeight()));
}
This CL has no behavior changes due to a disabled runtime flag.
Bug: 1346221
Change-Id: If7edc97995566f6f8e20ab0c1f67ed0c29646eb5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3828220
Commit-Queue: Kent Tamura <[email protected]>
Reviewed-by: Ian Kilpatrick <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035919}
Roll Chrome Win64 PGO Profile
Roll Chrome Win64 PGO profile from chrome-win64-main-1660683582-d37829843429963eeaa782e0c813619592a55f7f.profdata to chrome-win64-main-1660694323-a0df662925b72bd3e97141633addc5c57296028b.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win64-chrome
Tbr: [email protected]
Change-Id: I7a5839969110e4934539bdee092b5cf95ccea8c0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834704
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035918}
Retriage remaining failing <q> WPT tests
Retriaging the remaining failing <q> WPT tests as they are unrelated to
the bug described in 753671.
These tests are failing due to slightly shifted pixel differences between
rendered and expectations, not due to rendering wrong quote delimiters.
Change-Id: I4727614e97e89ada1cbf1ec605290c5b582a63ab
Bug: 1353560
Fixed: 753671
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834290
Commit-Queue: Koji Ishii <[email protected]>
Auto-Submit: Di Zhang <[email protected]>
Reviewed-by: Koji Ishii <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035917}
Gardener: Disable Tast tests on lacros-amd64-generic-chrome
Tests are flaky on lacros-amd64-generic-chrome builder and blocking
LKGM uprev (crrev.com/c/3832116).
List:
* lacros.ShelfLaunch
* platform.PerfettoChromeConsumer.lacros
* mlservice.WebHandwritingRecognition.lacros
Bug: 1352476,1352478,1352477
Change-Id: I8b5180d5edd7c9090145073f1283ec7119ba742a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832302
Reviewed-by: Sean Kau <[email protected]>
Commit-Queue: Yoshiki Iguchi <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035916}
dlp: Avoid indirection via BrowserServiceLacros to open learn-more
Change-Id: Idd92731baa86893d7319547b93d7b1c9f83af59e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3814949
Commit-Queue: Georg Neis <[email protected]>
Reviewed-by: Aya Elsayed <[email protected]>
Reviewed-by: Hidehiko Abe <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035915}
e14s flags audit: Bump diacritics flag to M111
__SIMPLE_REVIEW__
Bug: b/242234620
Change-Id: I1d2b87c256a683a934c7bfc925b73a582d802a9f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3833522
Commit-Queue: jhtin <[email protected]>
Reviewed-by: Darren Shen <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035914}
Add V8.ExternalPointerTableCompactionOutcome histogram
Bug: v8:10391
Change-Id: I44333c8a6f50f86c5eade10abc577dbd99274c30
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832667
Reviewed-by: Michael Lippautz <[email protected]>
Commit-Queue: Samuel Groß <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035913}
PrivacyIndicators: Add a status area tray item for privacy indicators
Implement the new privacy indicators view in the status area button,
with the new microphone and camera icons added. This CL also handles
tooltip text for the view, which will be updated according to
camera/micphone access.
Screenshot: https://screenshot.googleplex.com/43Jvy2nddttf5x2
Fixed: 1352836
Change-Id: Ib944a4e2e43948ad1d9cfab374d893d7d5cd127c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832497
Reviewed-by: Alex Newcomer <[email protected]>
Commit-Queue: Andre Le <[email protected]>
Reviewed-by: James Cook <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035912}
Make ContextualSearchContext inherit from SupportsWeakPtr.
ContextualSearchDeleate requires a WeakPtr<ContextualSearchContext>, so
it indeed winds up being simpler just having the base class enforce the
weak requirement rather than the child classes.
Change-Id: I86943f5a3d222ad6ca55542833c82c98d6a479b9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832321
Commit-Queue: Josh Simmons <[email protected]>
Reviewed-by: Gang Wu <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035911}
Rename external/wpt/web-bundle/subresource-loading/script-*.html tests
<link>-based APIs were removed, and "script-" prefix
doesn't make much sense anymore.
This patch remove "script-" prefix of WPT tests in web-bundle/subresource-loading.
Bug: 1347336
Change-Id: Iac4d719db0a637e7c59b78be5ed96e21aea8fafc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3812938
Reviewed-by: Hayato Ito <[email protected]>
Commit-Queue: DongJun Kim <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035910}
Roll eche_app from UWjW5UUyYh7eJT-i7... to Qa1IWoOECUYzahsB4...
Release_Notes: http://go/eche-x20/relnotes/Main/eche_20220811_RC00.html
https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/eche_app/app/+/Qa1IWoOECUYzahsB4j2P_hfFOSZ2Q978_xvr5rFv1QMC
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/eche-app-chromium
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: [email protected]
Change-Id: I96eba7ce1197dc11e12a50ba4d62f15b92b75902
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834891
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1035909}
[ios][feed] Use autoupdatingCurrentLocale
Change-Id: Ic20f97f3b863fb5549cb1747b2a5a17885cce2cd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832328
Reviewed-by: Sergio Collazos <[email protected]>
Commit-Queue: edchin <[email protected]>
Auto-Submit: edchin <[email protected]>
Commit-Queue: Sergio Collazos <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035908}
PA: Mirror base/types/strong_alias.h
Mirros base/types/strong_alias.h into partition_alloc_base/types/.
Bug: 1151236
Change-Id: Iaf9f3db8b7f71d9352191b2bcd28c3ecdf929e8f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832989
Reviewed-by: Takashi Sakamoto <[email protected]>
Commit-Queue: Yuki Shiino <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035907}
PageLoadMetrics: Prerender2 support for LayoutPageLoadMetricsObserver
This CL makes LayoutPageLoadMetricsObserver record metrics if the page
is prerendered and activated.
Bug: 1317494
Change-Id: Ie1ba7881e07979595d9570d4a2c3597da88d9293
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832596
Reviewed-by: Kouhei Ueno <[email protected]>
Reviewed-by: Takashi Toyoshima <[email protected]>
Commit-Queue: Ken Okada <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035906}
XS: Early out for AssistiveSuggester::HandleLongpressEnabledKeyEvent
__SIMPLE_REVIEW__
Change-Id: I09e054eae67cd4f336f3b56b03538a4379176029
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3828773
Reviewed-by: Darren Shen <[email protected]>
Commit-Queue: jhtin <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035905}
e14s flags audit: Update shend flags from M105->M111 and remove others.
Bug: b/242234620
Change-Id: I7334b0708a92a3c5e99c12ee84f26fdc3195f7ee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3828979
Reviewed-by: Darren Shen <[email protected]>
Auto-Submit: jhtin <[email protected]>
Commit-Queue: jhtin <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035904}
[games] Filter out games with no icons.
All games results should have icons.
This CL also fixes a bug where the wrong "Registered" circle R unicode
character was being used for title stripping. This inadvertently caused
a particular games (that contain R) to always be ranked below other
versions of the same game.
Bug: 1353175
Change-Id: Ic7587a6cbf634c61df6f01a07f24351afb7626f9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3833684
Reviewed-by: Amanda Deacon <[email protected]>
Commit-Queue: Rachel Wong <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035903}
Separate ScreenAI test_support to be used for browser_test.
Separate the test support code in ScreenAI component to be used for
ScreenAI browser_test.
Bug: 1278249
Change-Id: Ifa17640d6de43b3ed87a76ca1fad39467791eaad
AX-Relnotes: n/a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3829234
Reviewed-by: David Tseng <[email protected]>
Reviewed-by: Peter Kasting <[email protected]>
Commit-Queue: Ramin Halavati <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035902}
Update V8 to version 10.6.187.
Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/562b2178..fe3bd282
Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues
Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_chromeos_msan_rel_ng
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel
[email protected],[email protected],[email protected]
Change-Id: Ide61a8349583908677a5b23508a5ac80cdaf72e6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834749
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1035901}
Roll WebGPU CTS from dd01507ff53b to 30e9e048a1ff (1 revision)
https://chromium.googlesource.com/external/github.com/gpuweb/cts.git/+log/dd01507ff53b..30e9e048a1ff
2022-08-17 [email protected] Add indirect_dispatch_buffer,usage validation test (#1756)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webgpu-cts-chromium-autoroll
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel
Bug: None
Tbr: [email protected]
Change-Id: I21ad3afc631d479e551ae3b4dbc3d60022882e4c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3831249
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035900}
[flex] Add UMA for justify-content static-position change.
To see if we can stop justify-content affecting the static-position
of OOF-positioned items.
There should be no beahviour change.
Change-Id: I74f0fb2082b5da50d7aca9cf7122848ef08a5e2b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834773
Commit-Queue: Ian Kilpatrick <[email protected]>
Reviewed-by: David Grogan <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035899}
PageLoadMetrics: Prerender2 support for SideSearchPageLoadMetricsObserver
No behavioural change.
This CL makes it clear to use STOP_OBSERVING for
SideSearchPageLoadMetricsObserver.
Bug: 1317494
Change-Id: I81e5e43d2800bd6cb3d6421319183d8c466f4bdc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3831819
Commit-Queue: Ken Okada <[email protected]>
Reviewed-by: Yuheng Huang <[email protected]>
Reviewed-by: Takashi Toyoshima <[email protected]>
Reviewed-by: Kouhei Ueno <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035898}
Fix InsertChar in lacros
Just the fix-forward part of https://chromium-review.googlesource.com/c/chromium/src/+/3828763
To be submitted with this revert: https://chromium-review.googlesource.com/c/chromium/src/+/3828202
BUG=b:240618514
TEST=Ran locally on DUT.
Change-Id: I79eec002c1a77aa8fe8ea380fc09306ed011750a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3829496
Reviewed-by: Darren Shen <[email protected]>
Reviewed-by: Hidehiko Abe <[email protected]>
Commit-Queue: John Palmer <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035897}
Revert "Always use InsertText in MaybeProcessPendingInputMethodResult."
This reverts commit 529e49ff3b9ca748de15b4d6203087455d97ffe1.
Reason for revert: broke Citrix (b/240618514)
To be submitted with the Lacros fix: https://chromium-review.googlesource.com/c/chromium/src/+/3829496
BUG=b:240618514
Original change's description:
> Always use InsertText in MaybeProcessPendingInputMethodResult.
>
> Currently, depending on the context, InsertChar may be used
> in MaybeProcessPendingInputMethodResult.
> And in this case, key code gets unknown always.
>
> This caused two issues in wayland app (Lacros).
> - In chinese (traditional) + 'Punctuation width is full',
> the symbols were not be able to be input.
> - US-INTL dead key was broken.
>
> This is because, if InsertChar is used, the keysym was looked up
> by key code in the event inside exo (wayland compositor),
> but the key code is unknown so it always fails.
>
> This CL replaces the call by InsertText, so the character
> is always sent to wayland client as is.
>
> BUG=1287312, 1301032
> TEST=Ran on DUT locally with Lacros.
>
> Change-Id: Ia8995378bd203e8cf2d189f218389e73f3841f31
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3536987
> Reviewed-by: Darren Shen <[email protected]>
> Commit-Queue: Hidehiko Abe <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#984183}
Bug: 1287312, 1301032
Change-Id: Id97304c81c73d9e319b336817b1192c6f81fbadf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3828202
Reviewed-by: Hidehiko Abe <[email protected]>
Commit-Queue: John Palmer <[email protected]>
Reviewed-by: Darren Shen <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035896}
[FilesTrash] Wire parseTrashInfoFiles to TrashDirectoryReader
The existing implementation for TrashDirectoryReader reads the contents
of the .trashinfo files directly and attempts to parse them in
chrome://file-manager context. Move this logic to the TrashService to
ensure sandboxed parsing occurs.
This also updates all the tests to show the item name without the
breadcrumbs. A follow up CL will ensure the original file location moves
to the quick view instead.
Bug: b:238946031
Test: browser_tests --gtest_filter=*trash*
Change-Id: I3a3eb1be07fee954fcd5907ad3d30c6143abc343
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832975
Reviewed-by: Luciano Pacheco <[email protected]>
Commit-Queue: Ben Reich <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035895}
FrameSet NG: Add skeleton code of NGFrameSetPainter class
This CL has no behavior changes due to a disabled runtime flag.
Bug: 1346221
Change-Id: Ieb7edf8b412adc6976a3b63a306167620dab1c12
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834943
Auto-Submit: Kent Tamura <[email protected]>
Commit-Queue: Koji Ishii <[email protected]>
Reviewed-by: Koji Ishii <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035894}
Roll Chrome Win32 PGO Profile
Roll Chrome Win32 PGO profile from chrome-win32-main-1660683582-09c13c05d46c8f166f8f64ad8ab54a363ed045ae.profdata to chrome-win32-main-1660694323-bf66eed84fef168c9923b22ad1faccf167b9ef65.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win-chrome
Tbr: [email protected]
Change-Id: Ib7bafd45a4935885524c33f93d5315378c140e32
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834475
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035893}
Support wasm for ssh in Terminal with sockets.{tcpServer,udp}
Follow up to crrev.com/c/3818745.
Wasm SSH requires tcpServer for port forwarding, and udp.
Bug: 1350479
Change-Id: If328ef354c9dd190b4247cf7e97a8e20daca5500
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3828037
Reviewed-by: Xiyuan Xia <[email protected]>
Commit-Queue: Joel Hockey <[email protected]>
Reviewed-by: Mike Frysinger <[email protected]>
Auto-Submit: Joel Hockey <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035892}
[Files]: Fix source of hasAttribute crash.
onMouseOver_ is bound to null target. If the visibleTooltipTarget_ is
also null we call initShowingTooltip_ method with a null object. It is
not prepared for this. This CL simply skips calling initShowingTooltip_
if we do not have an actual target.
Bug: 1353182
Change-Id: I63f7426f1d0df2cafdc8b7d93dc14b0c622feadc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3833681
Reviewed-by: Luciano Pacheco <[email protected]>
Commit-Queue: Bo Majewski <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035891}
PageLoadMetrics: Prerender2 support for BackForwardCachePageLoadMetricsObserver
This CL makes BackForwardCachePageLoadMetricsObserver support
prerendered pages.
BackForwardCachePageLoadMetricsObserver is interested in events
after entering Back/Forward Cache. So, this class works well
as same as non prerendering case.
Bug: 1317494
Change-Id: If0ad1af84713f64977ff4b7a6dc4d1577adcf174
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3829030
Reviewed-by: Kouhei Ueno <[email protected]>
Commit-Queue: Ken Okada <[email protected]>
Reviewed-by: Takashi Toyoshima <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035890}
[ios][feed] Update Refresh experimental settings
- Add last foreground refresh timestamp
- Reorder to make enable notifications top of screen.
Screenshots:
https://screenshot.googleplex.com/A2cVBiEAkbu4TCN.png
https://screenshot.googleplex.com/6APy4jy2w63JqWY.png
Change-Id: I57247f247a95d2e082f1fd8c52a139fb3f5b60cb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3835103
Reviewed-by: Sergio Collazos <[email protected]>
Auto-Submit: edchin <[email protected]>
Commit-Queue: Sergio Collazos <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035889}
Import wpt@d0f7a13135f336290c1b3ebe13056c4fd5f38409
Using wpt-import in Chromium a1cc30e1c83321d36f0f54cd2b907033af497510.
Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md
Directory owners for changes in this CL:
[email protected]:
external/wpt/css/css-flexbox
NOAUTOREVERT=true
[email protected]
No-Export: true
Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-input-fyi-rel,linux-blink-rel
Change-Id: I77357e67bfa51d9d354da6ef7022580647af7502
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834804
Auto-Submit: WPT Autoroller <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035888}
Refactors gpu disk cache to be typed and handle based.
- Gpu disk cache no longer maintains client_id information, just opaque
handles instead. Users, i.e. the GpuHostImpl are tasked with keeping
client_id mapping instead.
- Adds mojom support for the types and handles.
- Adds a handle that maps 1:1 with physical path so that x-processes can
determine which cache a loaded entry is a part of without duplication.
- Fixes a potential race where entries might have been loaded without
a set callback to handle them.
- Updates mojo calls to reflect that the entries can be blobs now, not
just shaders.
Bug: dawn:549
Change-Id: Ib4a10e0fef0b112cc50e9eb1f8d1d2c815eff52f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3812182
Reviewed-by: Daniel Cheng <[email protected]>
Reviewed-by: Austin Eng <[email protected]>
Reviewed-by: Alex Moshchuk <[email protected]>
Commit-Queue: Loko Kung <[email protected]>
Reviewed-by: Sunny Sachanandani <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035887}
Prerender: Remove an already resolved TODO comment
This CL removes the unnecessary TODO regarding the deletion of
previews_state parameter because it has been already removed in the
following CL: I709460f82d45b9a17447fc14279adc8d2d4c53d0
Bug: 1232909
Change-Id: I148f17b0464df7bd9a279dfd74d0c3c6d4a80974
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3833594
Reviewed-by: Lingqi Chi <[email protected]>
Commit-Queue: Yoshiki Tanioka <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035886}
Shimless: fix shut down button on hardware error page
The shut down button was using an incorrect method, which
would get rejected by the platform. This CL adds a method
that requests a shut down from the power manager client.
Bug: 1198187
Test: browser_tests, ash_webui_unittests
Change-Id: I47f563a7ff4c25899f31cb0845e0237d139f31f4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3826411
Commit-Queue: Gavin Williams <[email protected]>
Auto-Submit: Anton Swifton <[email protected]>
Reviewed-by: Alex Gough <[email protected]>
Reviewed-by: Gavin Williams <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035885}
Roll src/third_party/cros_system_api/ 1771b7788..564038ed7 (1 commit)
https://chromium.googlesource.com/chromiumos/platform2/system_api.git/+log/1771b7788497..564038ed7902
$ git log 1771b7788..564038ed7 --date=short --no-merges --format='%ad %ae %s'
2022-08-12 nigeltao system_api: add fusebox DirEntryProto.mode_bits
Created with:
roll-dep src/third_party/cros_system_api
BUG=chromium:1244007
Change-Id: I89a22d001ce96b04bce948a11a7a79c0267fe52e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3835222
Auto-Submit: Nigel Tao <[email protected]>
Reviewed-by: François Degros <[email protected]>
Commit-Queue: François Degros <[email protected]>
Commit-Queue: Nigel Tao <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035884}
Roll Dawn from d9d6dfac9ab5 to f83652f01935 (1 revision)
https://dawn.googlesource.com/dawn.git/+log/d9d6dfac9ab5..f83652f01935
2022-08-16 [email protected] Remove suppressions from dawn:1471.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dawn-chromium-autoroll
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel
Bug: None
Tbr: [email protected]
Change-Id: Iae583c94080a6f853cf631e2d58d05184850b064
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834970
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035883}
Intents: Always allow Play Store to capture links by default
When the "DefaultLinkCapturingInBrowser" feature is enabled, Android
apps will default to opening clicked links in the browser rather than in
the app. The Play Store Android app provides core system functionality,
and so should be exempt from this behavior and allowed to capture links
by default.
Bug: 1269526
Change-Id: I9ed778fdd5825338fc75b4a963cb5a0793e18984
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3805122
Reviewed-by: Maggie Cai <[email protected]>
Commit-Queue: Tim Sergeant <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035882}
[String matching] Factor partial_match_penalty_rate out of input params.
Part of an ongoing effort to streamline FuzzyTokenizedStringMatch.
partial_match_penalty_rate is always set to the same value (0.9) by all
of its callees. Factor partial_match_penalty_rate out of the interface
of FTSM, and make it a constant within the class.
We are moving in a general direction away from a highly tunable fuzzy
matching interface, towards a more unified approach.
Test: existing
Bug: 1336160
Change-Id: I4dd05e8beb42021582b2183e65d0a873eb1c9a45
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834685
Commit-Queue: Amanda Deacon <[email protected]>
Reviewed-by: Rachel Wong <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035881}
Roll Chrome Mac Arm PGO Profile
Roll Chrome Mac Arm PGO profile from chrome-mac-arm-main-1660669594-8a0a8a5b58f64bf1e726898f026080ff1bbbfc9e.profdata to chrome-mac-arm-main-1660694323-1852380f4185ea1ff9a2df04304a8be582950df2.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-arm-chromium
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:mac-chrome
Tbr: [email protected]
Change-Id: I8fd25fbfe198166521087b8e23db584772c211fb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834887
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035880}
Update base::Value usage in task_module_service.cc
In particular, use base::Value::List and base::Value::Dict to access and
manipulate lists and dicts, rather than base::Value methods, which are
deprecated.
Bug: 1187001, 1338341
Change-Id: Ia579d6b3ef9765e5618ff18aad888f65d69dc015
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3831301
Reviewed-by: Kristi Park <[email protected]>
Commit-Queue: Matt Menke <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035879}
Roll src-internal from 546e7cc7522d to 12e5578d6729 (1 revision)
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/546e7cc7522d..12e5578d6729
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: [email protected]
Change-Id: Ie9537cac4987f426b2537f9bfbc8f6d41e74cdd6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834890
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1035878}
Roll Chrome Mac PGO Profile
Roll Chrome Mac PGO profile from chrome-mac-main-1660669594-ab66c8ad86c45aa98b2a82524a1be164c1c793cf.profdata to chrome-mac-main-1660694323-0c813aed519ad7837d2488005b935b8bb4c28ab5.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:mac-chrome
Tbr: [email protected]
Change-Id: If49b08a9852fe249088c316252f3b8297b093e8e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834989
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035877}
Switch some code in chrome/browser/policy/networking/ use Value::List
Switch a couple isolated consumers in chrome/browser/policy/networking/
to use base::Value::List to manipulate lists instead of deprecated APIs
(base::Value methods, base::ListValue).
This CL does not touch any of the header files in that directory,
which use ListValue extensively, to keep the CL simple.
Bug: 1338341
Change-Id: Ic66901ec776f879ac62dee0540bdace398d6e57f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3831057
Reviewed-by: Maksim Ivanov <[email protected]>
Commit-Queue: Matt Menke <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035876}
DPWA: denormalize install logic to InstallWebAppWithParam
Instead of sharing install logic in WebAppInstallCommand, denormalize
the install logic that's specific to background install to
InstallWebAppWithParams. Also rename InstallWebAppWithParams to
ExternallyManagedInstallCommand and takes ExternalInstallOptions as
argument. This way it explicitly restricts the usage to be for
externally managed installs.
Change-Id: I829aedaa7c9379cca2194a8dadcbf5a019a84cb3
Bug: 1298130
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3828503
Reviewed-by: Dibyajyoti Pal <[email protected]>
Reviewed-by: Daniel Murphy <[email protected]>
Commit-Queue: Phillis Tang <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035875}
Revert "[exo] Apply min/max constraints to the requested buffer size."
This reverts commit 9effea89a1edb74d98e82d5381347eda2cd717a5.
Reason for revert: breaks https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20(1)/45163/overview
Original change's description:
> [exo] Apply min/max constraints to the requested buffer size.
>
> Currently exo's xdg-shell impl doesn't apply the min/max size
> constraints when the buffer size is updated. This spec isn't clearly
> specified, but looks like some X11 apps depends on X11's WM manager
> oo change its size. This CL updates the size so that it will satisfy
> the condition.
>
> Bug: 1330028, b/207430591
> Test: Covered by unittests. Also tested using win.c in 133028.
>
> Change-Id: I87abe970c54d036d0382f7d6d5a6eacc2bb8d6b3
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3827939
> Reviewed-by: Chloe Pelling <[email protected]>
> Commit-Queue: Mitsuru Oshima <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1035766}
Bug: 1330028, b/207430591
Change-Id: I68d0225ec7d25b5fe89823e146201ba7b1218ae1
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832607
Bot-Commit: Rubber Stamper <[email protected]>
Auto-Submit: Melissa Zhang <[email protected]>
Commit-Queue: Melissa Zhang <[email protected]>
Owners-Override: Melissa Zhang <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035874}
Roll Chrome Win64 PGO Profile
Roll Chrome Win64 PGO profile from chrome-win64-main-1660650975-11c0305a3d05e803f31899ae4eaf2cadee7a5b99.profdata to chrome-win64-main-1660683582-d37829843429963eeaa782e0c813619592a55f7f.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win64-chrome
Tbr: [email protected]
Change-Id: I7cc9920a7935fd934b82836cde83f13e7d65f301
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834866
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035873}
Shimless: Move network connection behind feature flag
This change moves the network connection page behind the existing
`ShimlessRMAOsUpdate` feature flag. So when the flag is disabled, the
flow is Welcome Page -> Components page.
Connecting to a network is only useful in Shimless for updating the OS,
so it's logical to combine them behind the same feature flag.
Bug: 1198187
Test: ash_webui_unittests
Change-Id: I323f832dfad2f8e03d4fc2857f96f175bd1d33ca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3826115
Reviewed-by: Michael Checo <[email protected]>
Commit-Queue: Gavin Williams <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035872}
Move ProcessedStudy.Init tests to processed_study_unittest.cc
These tests are just in the wrong file for what they cover.
They are somewhat redundant with the existing tests in processed_study_unittest.cc, but also have some extra coverage, so just moving them in this CL.
Also re-orders processed_study_unittest.cc's AddExperiment arguments to match the convention used in all other test files.
Bug: b/241839751
Change-Id: I4f62186b8ddc3c0d4636f9d814615bede42dbab6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3828798
Reviewed-by: Ilya Sherman <[email protected]>
Auto-Submit: Steven Holte <[email protected]>
Commit-Queue: Steven Holte <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035871}
Make PrefStore::GetValues() return a base::Value::Dict.
And do the same for PrefValueMap::AsDictionaryValue(), which is renamed
to AsDict(). These methods were returning base::DictionaryValues, which
is deprecated.
Bug: 1187001
Change-Id: I191629bdb72ef62cf64a3cbea0f8a05a0758d230
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832474
Reviewed-by: Maksim Ivanov <[email protected]>
Commit-Queue: Matt Menke <[email protected]>
Reviewed-by: Dan S <[email protected]>
Reviewed-by: Dominic Battré <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035870}
longpress diacritics: Add blocklist based on app id
Bug: b/217560706
Change-Id: If3ef0523163e56a4d01ea6b1fea4dc05a990ead9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3826577
Commit-Queue: jhtin <[email protected]>
Reviewed-by: Keith Lee <[email protected]>
Reviewed-by: Bao-Duy Tran <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035869}
PageLoadMetrics: Prerender2 support for LoadingPredictorPageLoadMetricsObserver
This CL makes LoadingPredictorPageLoadMetricsObserver support
Prerender2. UMAs PageLoad.Clients.LoadingPredictor.* are affected
and this CL renames PageLoad.Clients.LoadingPredictor.* to
PageLoad.Clients.LoadingPredictor2.*. The effects are the following:
- All PageLoad.Clients.LoadingPredictor2.*
- Include samples from prerendered pages.
- PageLoad.Clients.LoadingPredictor2.Experimental.PaintTiming.NavigationToFirstMeaningfulPaint.Preconnectable
- The value is modified as activation start origined for prerendered pages.
- PageLoad.Clients.LoadingPredictor2.PaintTiming.NavigationToFirstContentfulPaint.Preconnectable
- The value is modified as activation start origined for prerendered pages.
For the complete list, see https://docs.google.com/spreadsheets/d/1IhBvEq4Fa3mRob0LFaIpsH4g9E8WRVD8RjXnbxxmThI/edit?pli=1#gid=592018921 .
Bug: 1317494
Change-Id: I5ce4bce43ddbfcf6f1d002bea09f078fe58c3d8b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3823371
Reviewed-by: Kouhei Ueno <[email protected]>
Reviewed-by: Takashi Toyoshima <[email protected]>
Commit-Queue: Ken Okada <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035868}
e14s flags audit: delete some jopalmer flags
Bug: b/242234620
Change-Id: Ic9e5dec3267c887eaed39388275dbbd7ed5781ca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832985
Auto-Submit: jhtin <[email protected]>
Commit-Queue: John Palmer <[email protected]>
Reviewed-by: John Palmer <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035867}
Fix ChromeTimeTicksBrowserTest.All which is always positive.
Any Mocha test should be "isAsync: true" because it calls the "testDone" method after all suites are passed (or failed). Otherwise the test is doomed to be always positive because it calls "testDone" before any test reports its result.
Also the unnecessary "browsePreload" getter was removed.
Change-Id: I7cb5b0d55521b8427ec47bb15ca8ea0f705da2ef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834585
Commit-Queue: Dmitry Iljinskiy <[email protected]>
Reviewed-by: Rebekah Potter <[email protected]>
Reviewed-by: Keren Zhu <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035866}
Disable FakeInputMethodContext on Lacros testing.
On Lacros testing, the backend wayland should work following the
real implementation, so we should use the real InputMethodContext, too.
Tweaking a few tests to annotate a flag to key events, so that their
key events look as same as real ones for Lacros IME.
Note that, in other platforms, the annotated flag is just ignored.
BUG=1348633
TEST=Ran tryjob.
Change-Id: Id367defacc72e4f24f6d30c8aa5f187eedf34914
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3831838
Reviewed-by: Devlin Cronin <[email protected]>
Reviewed-by: Darren Shen <[email protected]>
Reviewed-by: Erik Chen <[email protected]>
Reviewed-by: Mitsuru Oshima <[email protected]>
Commit-Queue: Hidehiko Abe <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035865}
Remove unnecessary if statement.
Change-Id: I318b076587724d971d9ce6db5269ce01ec132579
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3835062
Reviewed-by: Matt Reichhoff <[email protected]>
Commit-Queue: Chris Fredrickson <[email protected]>
Auto-Submit: Chris Fredrickson <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035864}
Updating trunk VERSION from 5245.0 to 5246.0
* This is an automated release commit.
* Do not revert without consulting [email protected].
NOAUTOREVERT=true
Change-Id: Ifbc06f997b4b2bf3aeeba6fc6147fed5bef1b691
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832432
Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1035863}
[ios] Ensure users are grouped into kTrendingQueriesModule each session
Users need to be assigned into experiment groups upon every new app
initialization, so CreateOneTimeRandomizedTrial needs to be called
every time. Since kTrendingQueriesModule needs to persist after
a new or existing user is added to the experiment, checks are removed
from preventing CreateOneTimeRandomizedTrial from being called.
Instead of a version pref check, in order to pave the way for
subsequent experiments, the current groups weight sums will be put
into a "Postperiod_N" group and then new "Control_M", "EnabledA_3",
etc groups will be appended after it, since order of AppendGroup() is
what will ensure that users in the old experiment don't get lumped
into the new.
A TrialExists() check is added to cover development/testing
overrides of the feature.
Bug: 1340123
Change-Id: I791c73797cedad6665933c2ec54cf8712df6c309
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3828884
Commit-Queue: Chris Lu <[email protected]>
Reviewed-by: Caitlin Fischer <[email protected]>
Reviewed-by: Rohit Rao <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035862}
[HSTS] Manual update of HSTS preload list for .gov
Adding this month's batch of newly registered .gov domains at the
request of the .gov TLD owner.
Change-Id: If3ac356fdb1f3a1edcb937f0b815670cd0f38bad
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834605
Reviewed-by: Chris Thompson <[email protected]>
Auto-Submit: Joe DeBlasio <[email protected]>
Commit-Queue: Chris Thompson <[email protected]>
Commit-Queue: Joe DeBlasio <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035861}
e14s flags audit: Audit curtismcmullan flags (some expiring M106)
- Removed obsolete flags.
- Added curtis to owners of:
3700 "name": "handwriting-legacy-recognition",
3705 "name": "handwriting-legacy-recognition-all-lang",
- Bumped all flags owned by curtis (including above) to M111.
- removed people who left the team from owners in curtis's flags.
Bug: b/242234620
Change-Id: Ie9ac15c2ac110026ce0e8b63de3309dcd92687eb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3833674
Commit-Queue: jhtin <[email protected]>
Auto-Submit: jhtin <[email protected]>
Reviewed-by: Curtis McMullan <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035860}
ime: Add flag for handwriting library DLC.
Add a flag which will enable downloading the handwriting library via
DLC, which will save rootfs space.
Bug: b/230556696
Change-Id: I02a9d5ed3329028771c9c1b31713aa95b7bfd9c5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3828035
Commit-Queue: Darren Shen <[email protected]>
Reviewed-by: Curtis McMullan <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035859}
[reland][memories][persist-clusters] Persist keywords.
Originally landed with crrev.com/c/3817582 .
Reverted with crrev.com/c/3827448 due to msan failures in tests.
Creates a 'cluster_keywords' table ┻━┻︵ \(°□°)/ ︵ ┻━┻. The
cluster-to-keyword relationship is 1-to-many. Will use a ROWID and omit
a primary key. Keywords can have multiple entities, but they're
serialized and stored in a single column, following the 'related
searchees' pattern. Creating yet another table would require 1) adding
keyword IDs, and 2) seems unnecessary at this time.
The table is populated when clusters are persisted. It's optionally
fetched when clusters are fetched. It's not always required, e.g. when
finding the most recent cluster threshold. It's deleted when deleting
clusters, either directly or indirectly when deleting the last visit in
a cluster.
Bug: 1184879, 1184875, 1171352
Change-Id: Ic06147e7c10b8d782fdee7af9cd4801c28bc7549
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3828883
Commit-Queue: manuk hovanesian <[email protected]>
Reviewed-by: Tommy Li <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035858}
e14s flags audit: Update tranbaoduy flags from M105/M106 --> M111
Updating these flags so that they won't expire in the next M106 branch since they are still in use.
Bug: b/242234620
Change-Id: I546c3dd4c56220eb2bb0182f3cc984c0c1d2a22b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3833615
Auto-Submit: jhtin <[email protected]>
Reviewed-by: Bao-Duy Tran <[email protected]>
Commit-Queue: Bao-Duy Tran <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035857}
Reland "[CacheStorage] 4/ Use BucketLocator instead of StorageKey"
This is a reland of commit 708ee55698cef08a3acc1895d33ef822129e1371
with a modification to add NOINLINE to the CacheStorageManager
constructor to address a crash related to ThinLTO in certain x86
Android builds.
Original change's description:
> [CacheStorage] 4/ Use BucketLocator instead of StorageKey
>
> This CL is the fourth in a set of CLs to integrate Cache Storage with
> the Buckets API. The buckets integration is nearly complete in a WIP
> CL [1], but we are splitting up the changes into smaller CLs for easier
> review.
>
> This CL implements a large portion of the Cache Storage key
> bucketization effort by replacing most StorageKey usage with
> BucketLocator usage.
>
> It also:
> - Adds bucket information to the Cache Storage index file,
> adds corresponding logic to migrate existing index files, and adds
> test coverage to ensure that migration happens successfully.
> - Updates the logic to extract Cache Storage instance sizes from
> disk such that it will correctly look for non-default and
> third-party context instances
> - Adds tests for deleting data via Storage Key and via Bucket
> - Updates tests so that they run using named buckets as well
> - Replaces calls to QuotaManagerProxy methods like
> NotifyStorageAccessed and NotifyStorageModified with the
> corresponding bucketized methods.
>
> This also adds a test for [2] that ensures GetAllStorageKeysUsage
> returns usage data for the correct owner.
>
> Design doc:
> https://docs.google.com/document/d/1VDm8M4vRyxCpvp_m3Ojs18W9g1WpqvSOsKf0A6hnAFM/edit?pli=1#heading=h.1kp8e5sw3qha
>
> Implementation design doc:
> https://docs.google.com/document/d/1B_tUfTJDeuqRyehvX6aM44YwvOkKWVNM5LNBu3_leqU/edit?usp=sharing
>
> [1] https://chromium-review.googlesource.com/c/chromium/src/+/3735215
> [2] https://chromium-review.googlesource.com/c/chromium/src/+/3777282
>
> Bug: 1218097, 1304786
> Change-Id: Icc1d727d32cb068eb853897295a9b1f210b1367e
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3768652
> Reviewed-by: Ben Kelly <[email protected]>
> Commit-Queue: Andrew Williams <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1028584}
Bug: 1218097, 1304786
Change-Id: Id07737f17e04c4ae85d064b5f7eca68e8d003874
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834742
Commit-Queue: Andrew Williams <[email protected]>
Reviewed-by: Ben Kelly <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035856}
[ChromeVox] Simplify iterative callbacks
This change is a pure refactor.
AX-Relnotes: n/a.
Bug: none
Change-Id: I26c7c7c0c793fdaa338438bc94b84bc74abf8029
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3829671
Commit-Queue: Anastasia Helfinstein <[email protected]>
Reviewed-by: Akihiro Ota <[email protected]>
Auto-Submit: Anastasia Helfinstein <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035855}
Use PassKeys for the UKM interfaces.
This is the follow up for CL:3744322, to use PassKeys for the UKM interfaces, and remove friend classes.
BUG=1340241
Change-Id: I119541adf067637026ffe48c7a53f1b1b4bb671c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3831748
Reviewed-by: Robert Kaplow <[email protected]>
Commit-Queue: Nancy Wang <[email protected]>
Reviewed-by: Dominick Ng <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035854}
Focus on Play files after clicking placeholder
This CL allows the Play files window to be focused once Play files is
mounted after clicking the placeholder icon.
Bug: b:215255080
Test: Manual check and integration test.
Change-Id: Id5bbc75021f82d6cb62ad93f2ae57c5cc758862e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3833516
Reviewed-by: Luciano Pacheco <[email protected]>
Commit-Queue: Risan <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035853}
Roll Chrome Linux PGO Profile
Roll Chrome Linux PGO profile from chrome-linux-main-1660669594-e1a98eac0424f7882f9f051b0b6d4d8ed43d1852.profdata to chrome-linux-main-1660694323-3b8689f41924fd0b08a6a97ee0a53899a85546f3.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-linux-chromium
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:linux-chrome
Tbr: [email protected]
Change-Id: I258c8cf7092095a0c77bfbf80a508c3467609c1b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834101
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035852}
cros_next: add system base and surface tokens
This cl adds system base and surface tokes that are required by
PillButton.
The newly added tokens are:
cros.sys.sys-base
cros.sys.sys-base-elevated
cros.sys.sys-on-base
cros.sys.sys-primary-container
cros.sys.sys-on-primary-container
The definitions of these tokens are in go/cros-tokens.
Bug: 1349580
Change-Id: Iee46b1a3270b07d7c46ffb0b713f640a674ff7e0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3833546
Reviewed-by: Zain Afzal <[email protected]>
Commit-Queue: Xiaodan Zhu <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035851}
Reland "[Lacros] Expose `LacrosMode` status in `LacrosInfo`"
This is a reland of commit 9d2f70d058c892d0e9024bbbf6909d72921fbbef. This reland changes only one line from the original CL, which was consistently crashing in bots such as `chromeos-eve-chrome`. The crash was caused by a mismatch between the idl definition and the `autotest_private_api.cc` calling code. The one liner diff can be found here. https://screenshot.googleplex.com/5srirJjPK62hJgc
Original change's description:
> [Lacros] Expose `LacrosMode` status in `LacrosInfo`
>
> This CL adds the `LacrosMode` in the `LacrosInfo` struct that is exposed
> by `autotest_private_api` to tast tests. So that tast tests can use
> `LacrosInfo` to figure out whether it's testing against Lacros Only or
> Lacros Primary, or any other listed mode. The four supported modes are
> `Disabled`, `SideBySide`, `Primary` and `Only`.
>
> Ultimately, this CL is one of a series of CLs that enable tast tests to
> test LacrosOnly scenarios.
>
> Bug: 1328994,1328851
> Change-Id: I29747b3e0c462e50bda560819fd1079cd5908f47
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3783852
> Reviewed-by: Ben Wells <[email protected]>
> Reviewed-by: Hidehiko Abe <[email protected]>
> Commit-Queue: Di Wu <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1032436}
Bug: 1328994,1328851
Change-Id: Id8e999f19203a24cd5d39c0afd0098117acceb5c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3818069
Reviewed-by: Ben Wells <[email protected]>
Reviewed-by: Hidehiko Abe <[email protected]>
Commit-Queue: Di Wu <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035850}
Use preparation-time Document/ExecutionContext in ClassicPendingScript
Previously, `GetElement()->GetDocument()` is used to access
Document/ExecutionContext, but this can be different from
the Document/ExecutionContext at the time of PrepareScript(),
e.g. where the corresponding
InlineCacheHandler/InlineScriptStreamer belongs.
This CL uses the preparation-time Document/ExecutionContext.
This doesn't affect script evaluation itself because
scripts moved between Documents are anyway not evaluated.
The other observable behavior changes are rare and not important
(Console logs, use counters and intervention-triggered fetches
now belong to different Documents when scripts are moved between
Documents), but this is still good for consistency.
Bug: 1323879, 1349934
Change-Id: I4a2cb1da0950502b266244a92bc91674ec91c56a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3812178
Reviewed-by: Shunya Shishido <[email protected]>
Commit-Queue: Hiroshige Hayashizaki <[email protected]>
Reviewed-by: Minoru Chikamune <[email protected]>
Reviewed-by: Kouhei Ueno <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035849}
[Settings] Add Target language select box
This CL adds a dropdown list of translate supported languages for the
user to select their target translate language. It adds functions to
LanguageHelper to populate the list of translate supported languages.
Tests for the translate target selection are added.
See bug for screenshot.
Bug: 1332337
Change-Id: I3f740cbb609af15e2c8173929cd5ec8b6f971398
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3811183
Reviewed-by: Trevor Perrier <[email protected]>
Reviewed-by: Scott Violet <[email protected]>
Commit-Queue: Andrea Gomez <[email protected]>
Reviewed-by: John Lee <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035848}
[TabletTabGroup] Fix reorder animation when dropping into group
Fix reorder animation when dropping into group.
-Calculate number of tabs to skip correctly.
Before: https://drive.google.com/file/d/1eM-gQfQ04kDrV8uxsTj9QqrDu_kfEdPy/view
After: https://drive.google.com/file/d/1DuNPj6Hz-fHHW_hh_CVVeWl2409M-0-L/view
Bug: 1353506
Change-Id: I1db504567f9d907a72269c4e00f14e3e5aaa3e86
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832962
Reviewed-by: Sirisha Kavuluru <[email protected]>
Commit-Queue: Neil Coronado <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035847}
[CodeHealth] Replace DictionaryValue::GetString in /chrome/browser/extensions.
This CL was uploaded by git cl split.
[email protected]
Bug: 1187036
Change-Id: I11b6bab3968bc9157db0ff083abefa111e604416
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3826074
Reviewed-by: Ben Wells <[email protected]>
Auto-Submit: Brian Begnoche <[email protected]>
Commit-Queue: Ben Wells <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035846}
Roll Fuchsia SDK from 9.20220812.1.1 to 9.20220816.1.1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast
Tbr: [email protected]
Disable-Retries: true
Change-Id: I2eeb83b8154a44b7daf2a94ccaee26aaf4d8ee67
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834966
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035845}
Prerender: Add metrics for navigation parameters mismatches
This CL adds some metrics for the parameters mismatches between initial
navigation and activation navigation in prerendering activation to
improve the dev experience by notifying developers why the prerendering
activation failed.
Bug: 1328365
Change-Id: I6d7898204f31c7c46a0012296e11170162069ec7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3828291
Commit-Queue: Yoshiki Tanioka <[email protected]>
Reviewed-by: Hiroki Nakagawa <[email protected]>
Reviewed-by: Ben Kelly <[email protected]>
Reviewed-by: Lingqi Chi <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035844}
assistive suggester filter: window properties retrieved via callback
This allows us to mock app ids and arc++ package names in tests. Added every arc++ package and app id (for extensions/system apps) that we currently use)
drive by: removed some obsolete functions IsUrlAllowedLegacy and its callers.
Change-Id: I2e1664275e3829e27515c23f36edea33735d6a88
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3828292
Reviewed-by: Darren Shen <[email protected]>
Reviewed-by: Curtis McMullan <[email protected]>
Commit-Queue: jhtin <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035843}
[reclient] Switch Comparison Builders to racing and disable nacl
Switch RBE exec strategy to use racing on Comparison Mac (reclient), Comparison Mac arm64 (reclient), and Comparison ios (reclient). Also disable nacl on Comparison Mac (reclient) and Mac deterministic (reclient shadow).
Bug: b/242206117
Change-Id: I9e190a541c35f1abe7239b163ca2ab0b3970ec2d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832318
Commit-Queue: Andus Yu <[email protected]>
Reviewed-by: Garrett Beaty <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035842}
Remove base::Value::Insert().
It's been deprecated in favor of base::Value::List::Insert, and all
callers have been converted.
Also remove a couple superfluous instance of "base::" in the
EnsureDict() / EnsureList() tests from an earlier CL.
Bug: 1187001, 1338341
Change-Id: I96184a9f92abda9202bebc5f6ab030db111e1d8a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3831376
Commit-Queue: Matt Menke <[email protected]>
Reviewed-by: Daniel Cheng <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035841}
Roll nearby-connections from e5c24b8b8ac4 to 0849bc7598e5 (1 revision)
https://chromium.googlesource.com/external/github.com/google/nearby-connections.git/+log/e5c24b8b8ac4..0849bc7598e5
2022-08-16 [email protected] Use absl::variant for PresenceScanFilter and legacy.
> PiperOrigin-RevId: 467982930
>
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/nearby-connections-chromium
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:linux-nearby-chrome-fyi
Bug: None
Tbr: [email protected],[email protected],[email protected]
Change-Id: I11f0dd062c70ce714467492e21b9d98857415311
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832786
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1035840}
HaTS config for the Photos Experience on Chromebooks.
To trigger, during SWA initialization, an observer is added for for a
Profile's AppServiceProxy's InstanceRegistry. This will possibly
trigger a happiness tracking survey (HaTS) when it observes the Photos
Android app being closed.
The survey includes four bools to assist filtering of responses:
whether the user had opened an {image,video} in Gallery via the
Gallery file handler, and whether the user had clicked the "More
tools in Photos" button in the app while viewing an {image,video}.
Collectors for these values are added in this CL.
Adds integration tests for the survey trigger and data collectors.
Bug: chromium:1347347, b:241060504
Change-Id: I5bdc6206d3bd0d02d7691d9c9e64ef89871afbb8
Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3825203
Commit-Queue: Trent Apted <[email protected]>
Reviewed-by: Ian Barkley-Yeung <[email protected]>
Reviewed-by: Caitlin Fischer <[email protected]>
Reviewed-by: Patti Lor <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035839}
Remove Account::AdFromObjGuid.
The API is used in known_user, but it was effectively no-op
(FindStringPath returns false always, because account is considered
invalid in KnownUser::FindPrefs), so removed.
Other uses are only for testing, so replaced by similar function
which initializes AccountId as "valid" state.
BUG=1325210
TEST=Ran tryjob.
Change-Id: I5499f9021ce1cffc1dbeec5df28fdf4b4b6d3127
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3812952
Reviewed-by: Xiyuan Xia <[email protected]>
Reviewed-by: Lei Zhang <[email protected]>
Commit-Queue: Hidehiko Abe <[email protected]>
Reviewed-by: Roman Sorokin <[email protected]>
Reviewed-by: Felipe Andrade <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035838}
Ensure WebDragSourceAura::window_ is cleared when destroyed
In its current multi-WebContents architecture, portal adoption destroys
the aura::Window of the navigated away from page. If this happens during
a drag and drop nested run loop, we may go on to access a destroyed
WebDragSourceAura::window_. We now observe its destruction and clear the
pointer.
Bug: 1346048
Change-Id: I4e603422f5a0b2676328fc70f4d3203b6ec83210
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3835023
Commit-Queue: Alex Moshchuk <[email protected]>
Reviewed-by: Alex Moshchuk <[email protected]>
Auto-Submit: Kevin McNee <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035837}
Do not convert DIAL sink to Cast if the IP address is already used
Before this CL we already do not attempt to convert a DIAL sink to Cast if there already exists a Cast sink with the same ID.
However there are cases where there is a Cast sink whose ID is different but the IP address is the same. This CL makes us not reopen a Cast channel in such cases.
Bug: b/218605324
Change-Id: I54eeefd460d6a070049b24329fc037cb7e02e2a7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3805152
Commit-Queue: Takumi Fujimoto <[email protected]>
Reviewed-by: Mark Foltz <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035836}
dpwa: Do not expose Window Controls Overlay values to a fenced frame
This Cl ensures Window Controls Overlay titlebar area values are not
sent to a fenced frame from the browser.
Bug: 1313778
Change-Id: Id2eadc299f5fbe2b223d7ada5ccfcd141877069e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3825936
Commit-Queue: Hassan Talat <[email protected]>
Reviewed-by: Alexander Timin <[email protected]>
Reviewed-by: Dave Tapuska <[email protected]>
Reviewed-by: Daniel Murphy <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035835}
Add feature flag to skip ignorable fetch handlers.
If the fetch handler is detected as ignorable and the flag is set,
and also we specify the case to be skipped, we do not make the service
worker to handle the fetch event and falls back to network.
i.e. we do not start the service worker to make it handle the fetch
event.
In this CL, we made the empty fetch handler to be skipped if the param
is set.
Bug: 1347319
Change-Id: I36e13594ff9ad267721705b86a5be061bff2b552
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3818351
Reviewed-by: Arthur Sonzogni <[email protected]>
Reviewed-by: Hiroki Nakagawa <[email protected]>
Reviewed-by: Ayu Ishii <[email protected]>
Commit-Queue: Yoshisato Yanagisawa <[email protected]>
Reviewed-by: Kouhei Ueno <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035834}
[A11y Settings Revamp] Add icons to A11y settings
Add icons to Chrome OS Accessibility settings to make features easier
to recognize.
Screenshot: https://screenshot.googleplex.com/zcjyTHExWPXnn9s
Bug: 1292142
Change-Id: Ie9984298ded6834f84164141e9026cfd35dfd4fa
AX-Relnotes: Updates to Chrome OS Accessibility Settings to make accessibility options simpler / easier to use.
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3827518
Reviewed-by: Katie Dektar <[email protected]>
Commit-Queue: Josiah Krutz <[email protected]>
Reviewed-by: Rebekah Potter <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035833}
[PhishGuard] Add affected histogram to histogram_suffixes.
Bug: 1328326
Change-Id: I9fea4cb78924fee5bdf2116e36d139bca1d5a398
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832792
Reviewed-by: Xinghui Lu <[email protected]>
Auto-Submit: Nwokedi Idika <[email protected]>
Commit-Queue: Xinghui Lu <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035832}
Updating owners and milestone for accessible-pdf-form
Change-Id: Id6363e03aebb9fd7ce39a52ee22fbd63ee4f7e09
Signed-off-by: Ankit Kumar <[email protected]>
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3827106
Commit-Queue: Lei Zhang <[email protected]>
Reviewed-by: Lei Zhang <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035831}
Import wpt@73d0d8516c021a2c4a673216c7a22afddf9d670b
Using wpt-import in Chromium 08ccbb946b25cd12587debaf7f3de3f74e690b25.
With Chromium commits locally applied on WPT:
57cf0662df "[CompositeClipPathAnimations] Add repaint tests from composited bg color animations"
8f386ba9b3 "Replace requestIdleCallback with double-rAF in wpt/accessibility tests"
Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md
NOAUTOREVERT=true
[email protected]
No-Export: true
Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-input-fyi-rel,linux-blink-rel
Change-Id: I7143c6efdc7f341921da35bcaa6ded5ef7fcf3ad
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3835066
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Auto-Submit: WPT Autoroller <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035830}
Revert "Keep app menu open after changing app launch type"
This reverts commit aebddaba65969e90d0f74a27852e09447b742bfd.
Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=1353254. Caused DCHECK errors for crostini apps.
Original change's description:
> Keep app menu open after changing app launch type
>
> And dynamically change icon and label of the `LAUNCH_NEW` menu item.
>
> BUG=844786
>
> Change-Id: I2300e723d333cda9e7b5c3e7a2c2f4a03c363361
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3788899
> Reviewed-by: Toni Barzic <[email protected]>
> Commit-Queue: Artsiom Mitrokhin <[email protected]>
> Reviewed-by: Nancy Wang <[email protected]>
> Reviewed-by: Alex Newcomer <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1034630}
Bug: 844786
Change-Id: I3b87e395eb63761faf5a72762f4d834db120e757
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3830745
Reviewed-by: Alex Newcomer <[email protected]>
Reviewed-by: Nancy Wang <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Reviewed-by: Toni Barzic <[email protected]>
Reviewed-by: Timothy Loh <[email protected]>
Commit-Queue: Artsiom Mitrokhin <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035829}
Roll PDFium from edf817eed90f to ee44620f2b58 (13 revisions)
https://pdfium.googlesource.com/pdfium.git/+log/edf817eed90f..ee44620f2b58
2022-08-16 [email protected] Tidy CFGAS_GEGraphics::StateRestore() usage
2022-08-16 [email protected] Add FPDFViewEmbedderTest.RepeatedInitDestroy.
2022-08-16 [email protected] Mark JpegDecoder instance variables as private.
2022-08-16 [email protected] Fix an assertion failure in OpenJPEG.
2022-08-16 [email protected] Funnel FXMEM_ calls into pdfium::internal routines
2022-08-16 [email protected] Avoid a copy in CJS_Document::mailForm().
2022-08-16 [email protected] Better encapsulate CPDFSDK_Annot
2022-08-16 [email protected] Better encapsulate CPDF_ColorSpace.
2022-08-16 [email protected] Store 2 unrelated GetSize() results in appropriate data types.
2022-08-16 [email protected] Use DataVector<T> in core/fxge/.
2022-08-16 [email protected] Use DataVector<T> in core/fpdfapi/parser/.
2022-08-16 [email protected] Use DataVector<T> in fxjs/ and xfa/.
2022-08-16 [email protected] Roll v8/ 4180a6ed4..709443dcb (374 commits)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pdfium-autoroll
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in PDFium: https://bugs.chromium.org/p/pdfium/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: chromium:1343737
Tbr: [email protected]
Change-Id: I6d4b83d78170c4136f0a695d0f0492ec20e7a3f2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3835123
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035828}
Roll vulkan-deps from 863822794aa7 to 31a5e38f3e48 (1 revision)
https://chromium.googlesource.com/vulkan-deps.git/+log/863822794aa7..31a5e38f3e48
Changed dependencies:
* spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/9abacb34a5..1728c1d40a
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-chromium-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86;luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:win-asan;luci.chromium.try:linux_chromium_cfi_rel_ng
Bug: None
Tbr: [email protected],[email protected],[email protected]
Change-Id: I506582616d7ae274ea68236c478c0050ca371d7f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834282
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035827}
[fuchsia] Allow PROTECTED_MEDIA_IDENTIFIER type conversion on Fuchsia
This enum is supported on Fuchsia. Just adding Fuchsia platform check to
fix the issue. Further investigation on whether to remove the whole
check will be in https://crbug.com/1353541.
Bug: 1352558, 1353541
Change-Id: I548c7ceaa6ebbee3530947b84214a2b75fdceeef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3828306
Reviewed-by: Dominick Ng <[email protected]>
Commit-Queue: Guocheng Wei <[email protected]>
Reviewed-by: Bryant Chandler <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035826}
[blinkpy] 4/N: `update-metadata` CLI
This change adds the CLI and option parsing for `update-metadata`,
which only fetches build data from Buildbucket for now.
This subcommand is temporarily hidden from `./blink_tool.py --help`.
Bug: 1299650
Test: ./blink_tool.py update-metadata --build="Linux Tests"
Change-Id: I8d792e1b03f623b92a530b6fb43b553835b365af
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3835047
Reviewed-by: Weizhong Xia <[email protected]>
Commit-Queue: Jonathan Lee <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035825}
Roll src/third_party/libyuv/ 1c5a8bb17..65e7c9d57 (1 commit)
https://chromium.googlesource.com/libyuv/libyuv.git/+log/1c5a8bb17ac4..65e7c9d5706a
$ git log 1c5a8bb17..65e7c9d57 --date=short --no-merges --format='%ad %ae %s'
2022-08-16 fbarchard MM21ToYUY2 and ABGRToJ420 conversion
Created with:
roll-dep src/third_party/libyuv
Bug: b/238137982
Change-Id: I06b9fee4cc65052fcfcdc07096a1caa3f7f06486
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3833680
Commit-Queue: Frank Barchard <[email protected]>
Reviewed-by: Wan-Teh Chang <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035824}
PermissionBubbleInteractiveUITest should enable kPermissionChip feature explicitly.
PermissionBubbleInteractiveUITest depends on that kPermissionChip
feature is enabled. But the test doesn't explicitly enable the feature.
The test uses field_trial_configs.json to enable it. This causes
unexpected test failure when using
--enable-features=TestFeature:TestParam/TestValue.
e.g. https://luci-milo.appspot.com/ui/inv/build-8805701623522221521/test-results?q=ExactID%3Aninja%3A%2F%2Fchrome%2Ftest%3Ainteractive_ui_tests%2FPermissionBubbleInteractiveUITest.SwitchTabs+VHash%3A5bdb240ff2746c1b
Change-Id: I3297a53f992cd74ffee33a8c6fb8b28dc39dd8cb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3831926
Reviewed-by: Illia Klimov <[email protected]>
Commit-Queue: Takashi Sakamoto <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035823}
Fix bug in AvoidEarlyExtensionScriptContextCreation feature
It was possible for non http/https frames to not get
SetAllowsCrossBrowsingInstanceFrameLookup() called on them, since the V8
context may not be initialized during commit. To fix this, instead of
waiting for DidCreateScriptContext(), we can use DidClearWindowObject()
which is called after the parser has been created during commit.
This still accomplishes the goal of the original patch by avoiding
creation of the script context too early, but still makes sure we call
SetAllowsCrossBrowsingInstanceFrameLookup() even in cases where the
script context would not have been created.
This was a little tricky because http/https frames would always get
their script context created when DetectJavascriptFrameworksOnLoad() was
called and tests run with the kDomAutomationController switch which
also creates the script context, which is how this bug slipped
through.
Bug: 1349787
Change-Id: Ia04203a37ed6fceb49bf25d7e31c09108348e8aa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3817164
Commit-Queue: Clark DuVall <[email protected]>
Reviewed-by: Devlin Cronin <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035822}
Roll Chrome Win32 PGO Profile
Roll Chrome Win32 PGO profile from chrome-win32-main-1660650975-ee2eda6f820d2789a82040d13a5e68a0c91b2dda.profdata to chrome-win32-main-1660683582-09c13c05d46c8f166f8f64ad8ab54a363ed045ae.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win-chrome
Tbr: [email protected]
Change-Id: Ie43396aaf64f1c87b02de22c8352138813ea69a1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834470
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035821}
Ensure center button position isn't negative
Don't use gfx::Range. Store these in ints to avoid erroneous type
conversions.
BUG=1347379
TEST=manual
Change-Id: I6fd0f2755e093c68d13883918f35c431290fcb92
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3828040
Auto-Submit: Kazuki Takise <[email protected]>
Commit-Queue: Kazuki Takise <[email protected]>
Reviewed-by: Xiyuan Xia <[email protected]>
Reviewed-by: Peter Kasting <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035820}
Revert "[TTS] Remove enhanced_network_tts/background.html"
This reverts commit 0ec30dea0510bc58c43d07628c1bc7b9b9b2586b.
Reason for revert: Component extension service worker seems to be unable to use import/export statements
Original change's description:
> [TTS] Remove enhanced_network_tts/background.html
>
> R=dtseng
>
> AX-Relnotes: n/a.
> Bug: 1288634
> Test: cq
> Change-Id: I8d9e562d579320f96a9c68c49ab654c48c2b39a9
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3827264
> Auto-Submit: Anastasia Helfinstein <[email protected]>
> Reviewed-by: David Tseng <[email protected]>
> Commit-Queue: Anastasia Helfinstein <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1034579}
Bug: 1288634
Change-Id: I22f511c4f8b2904a9ffca9a52bb0a6d352c85764
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832237
Bot-Commit: Rubber Stamper <[email protected]>
Reviewed-by: David Tseng <[email protected]>
Commit-Queue: Anastasia Helfinstein <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035819}
Extend histograms expiration date
Extend histograms expiration date for some Assistant and Quick answers
histograms. These histograms are still very helpful on monitoring the
feature quality.
Bug: 1345319, 1345337
Test: None
Change-Id: I8fbd8eee4f22d2c1544e8d357900c0030ea31692
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834606
Reviewed-by: Xiaohui Chen <[email protected]>
Commit-Queue: Yue Li <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035818}
win: add test failure if GetShortcutPath fails
the test failure less mysterious.
ShellUtil: :GetShortcutPath() can fail; if it does, this would make
Change-Id: Ibce4800916887a45c1295572ce6db949da09c64e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3827995
Reviewed-by: Evan Stade <[email protected]>
Commit-Queue: David Bienvenu <[email protected]>
Auto-Submit: David Bienvenu <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035817}
Move //chromeos/{=>ash/components}/dbus:test_support
This CL moves chromeos/dbus:test_support to chromeos/ash/components/dbus since it is used inside is_chromeos_ash only.
This CL is part of the Chrome OS source code directory migration:
https://docs.google.com/document/d/1g-98HpzA8XcoGBWUv1gQNr4rbnD5yfvbtYZyPDDbkaE.
Bug: 1164001
Change-Id: I80a86759b1223f0f0707ff46577725db250c52e8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3833595
Reviewed-by: Hidehiko Abe <[email protected]>
Owners-Override: Hidehiko Abe <[email protected]>
Commit-Queue: Yeunjoo Choi <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035816}
Migrate //chromeos/ash/components/cros_disks to namespace ash [6/N]
This CL migrates remaining classes to namespace ash and removes
temporary using declarations in cros_disks/.
This CL is part of the Chrome OS source code directory migration:
https://docs.google.com/document/d/1g-98HpzA8XcoGBWUv1gQNr4rbnD5yfvbtYZyPDDbkaE.
Change-Id: I212134b0f2a60ec5f1f417818c3567bf397cebad
Bug: 1164001
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3831848
Reviewed-by: Hidehiko Abe <[email protected]>
Owners-Override: Hidehiko Abe <[email protected]>
Commit-Queue: Yeunjoo Choi <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035815}
Roll Skia from 0450b8d5a2a4 to d121e0a831fa (10 revisions)
https://skia.googlesource.com/skia.git/+log/0450b8d5a2a4..d121e0a831fa
2022-08-16 [email protected] Revert "Replace StrikeRefs with SkStrikePromises"
2022-08-16 [email protected] RELEASE_NOTES: Move AVIF support to the current milestone
2022-08-16 [email protected] Fix SkSL dehydration on Windows machines
2022-08-16 [email protected] Update VectorScalarMath test avoid failure-prone division.
2022-08-16 [email protected] Replace StrikeRefs with SkStrikePromises
2022-08-16 [email protected] Roll ANGLE from ad6513fe3068 to e79c9cd63053 (4 revisions)
2022-08-16 [email protected] [bazel] Remove all macros from public.bzl
2022-08-16 [email protected] Roll vulkan-deps from 4f5fbed615fa to 206b75948397 (1 revision)
2022-08-16 [email protected] Roll Dawn from bade13a5d2e7 to c8b0cfe7e308 (2 revisions)
2022-08-16 [email protected] Roll ANGLE from 2089943b951d to ad6513fe3068 (3 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Cq-Do-Not-Cancel-Tryjobs: true
Bug: None
Tbr: [email protected]
Change-Id: I5d00140e78976687a7f7d50e0491dfe8b496d767
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834825
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035814}
[Flaky Reproducer] Fix infra error for flaky reproducer
free_space dimension is not exists in luci.chromium.try pool.
Bug: 1326336
Change-Id: Ic515c9646f017361b3fbaa2521361aa3d010474a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3835048
Reviewed-by: Ben Pastene <[email protected]>
Commit-Queue: Kuan Huang <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035813}
[ChromeVox] Add BridgeCallbackManager
In anticipation of several more callbacks being accessed across
contexts, this change adds a BridgeCallbackManager that encapsulates
the logic to save and call a callback on demand. Callers simply
create a new CallbackId, pass it around however is needed, and then
call BridgeCallbackManager.performCallback(callbackId).
This change is a pure refactor.
R=katie
AX-Relnotes: n/a.
Bug: none
Test: cq
Change-Id: Ie56e8925504fb2f64efc3eea6f6785a168da9edf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3812230
Auto-Submit: Anastasia Helfinstein <[email protected]>
Commit-Queue: Anastasia Helfinstein <[email protected]>
Reviewed-by: Katie Dektar <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035812}
Collect installer API result for offline install.
Bug: 1286574
Change-Id: Ie5aad9d8484915fd81c5dd4a469d6e3081dbc35b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3828027
Reviewed-by: Sorin Jianu <[email protected]>
Reviewed-by: S Ganesh <[email protected]>
Commit-Queue: Xiaoling Bao <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035811}
Reuse the PolicyService from the config instead of creating one
Bug: 1293203
Change-Id: Ia1089e2ee9272899a04f9ce45b271c7e49a9b2c4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834765
Commit-Queue: S Ganesh <[email protected]>
Reviewed-by: Sorin Jianu <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035810}
Roll src-internal from 6882dd54f1b6 to 546e7cc7522d (2 revisions)
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6882dd54f1b6..546e7cc7522d
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: [email protected]
Change-Id: I0f1e551870b15eb53472930bf7801d56de3346f9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3835122
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Reviewed-by: Emily Shack <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035809}
ChromeVox: improve performance on text areas
This is a workaround for text area performance problems in Blink.
For ChromeVox specifically, if we open the sample page included as a
test and linked to in the bug, ChromeVox completely locks up.
This is because of several things:
1. Cursor.deepEquivalent enumerates all leaves of the editable.
2. EditableLine computes the character offset from the selection both in
the forward and backward directions.
Fixes:
1. walk the leaves incrementally using AutomationTreeWalker. Exit early
when we've found the text offset we want.
2. special case large text areas so that we exclude offscreen lines. Note
that this may interfere with some computations in EditableLine and the
larger editing state machine. However, the basic functionality should
work.
After this change:
- ChromeVox no longer locks up
- reading content e.g. move by character, word, line, works ok though
isn't quite super snappy
- text changes e.g. typing, is still slow because each key press
triggers a re-computation of the inline text boxes. In the example,
this triggers recomputation of the 23k+ lines.
Finally, this change also serves to demonstrate what it is like to work
with the Blink data. The root cause and root fix should be in Blink, but
this change does make things better for ChromeVox in the meantime.
[email protected]
Bug: 1076525
Test: new test (this might still need to be disabled because it isn't as fast as typical browser tests should be).
Change-Id: I7b36af0b036a2b3232d1c66dc36af10b04a339f1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3827731
Reviewed-by: Katie Dektar <[email protected]>
Commit-Queue: David Tseng <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035808}
Roll Depot Tools from f9fede5f843d to 940cd8e20f54 (1 revision)
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/f9fede5f843d..940cd8e20f54
2022-08-16 [email protected] Use empty argument list in cmdhelp
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/depot-tools-chromium-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: [email protected],[email protected],[email protected],[email protected]
Change-Id: I057d7a640ba130643d672c77c0a6086209383c77
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834471
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035807}
personalization: rainbow icon color
Update the rainbow icon color on keyboard brightness slider to be
Google Grey 900
BUG=b/242777765
TEST=Manually
Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Change-Id: Iaa87366fbaff0ded305888dbf704bee7f318fbf0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3827814
Reviewed-by: James Cook <[email protected]>
Commit-Queue: James Cook <[email protected]>
Auto-Submit: Jason Thai <[email protected]>
Commit-Queue: Jason Thai <[email protected]>
Quick-Run: Jason Thai <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035806}
[PriceTracking] Add mojo interface for side panel price tracking
This CL
* Adds a mojo interface handler definition which is now only used for
information passing.
* Adds a dummy implementation of the mojo handler and registers the
handler in proper WebUIControllers.
* Adds a proxy in typescript to expose the handler to WebUI.
Bug: 1346624
Change-Id: Ib8ecfb26e01da9edd0968fdb187de13019753834
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3824464
Reviewed-by: Matthew Jones <[email protected]>
Reviewed-by: John Lee <[email protected]>
Reviewed-by: Alex Gough <[email protected]>
Commit-Queue: Yue Zhang <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035805}
Use the non mojom publisher interfaces for some AppService APIs.
Add a new kAppServiceWithoutMojom flag to implement the non mojom AppService APIs:
StopApp
ExecuteContextMenuCommand
OpenNativeSettings
Add the virtual interface for those APIs in the non mojom AppPublisher.
BUG=1253250
Change-Id: Id9996deec56e91fd203ca341d26a5ab6c6ce5fba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832181
Reviewed-by: Dominick Ng <[email protected]>
Commit-Queue: Nancy Wang <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035804}
Improve console messages of WebBundle parse errors
This makes two improvements:
1. Report a dedicated error message when attempted to parse the
(deprecated) b1 WebBundle format. Before this change, it was reported
with very confusing message: "Wrong CBOR array size of the top-level
structure".
2. Include resource URL that could not be parsed in the error message.
When relative URLs cannot be used, note it.
Bug: 1352933,1349815
Change-Id: I252493838375749751abf4bafb7686943244dccd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832976
Commit-Queue: Kunihiko Sakamoto <[email protected]>
Reviewed-by: Hayato Ito <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035803}
ChromeOS: Make "Search" and "Go to" context actions use Lacros
... if Lacros is the only browser (LacrosOnly mode).
This is partially a reland of a6f7dd509262c2a08ca71cefc4ce7678b9f7caf2,
which was a more radical change and was reverted in cf688a1b098062af5f8efee08de88b6f3d84af1c due to the fact that it didn't
propagate incognito mode from Ash.
The current CL is restricted to LacrosOnly mode, where we should never see an Ash incognito mode window. It also takes care to preserve the
behavior of the shift modifier to open the page in a new window.
As part of the CL, a WindowOpenDisposition is added to the parameters
of ash::NewWindowDelegate::OpenUrl.
Bug: chromium:1295604, chromium:1333289
Change-Id: I5c37df0c803f7efb610feab4ea9ba689922bcd5b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3802397
Reviewed-by: Hidehiko Abe <[email protected]>
Reviewed-by: Tao Wu <[email protected]>
Reviewed-by: Scott Violet <[email protected]>
Commit-Queue: Georg Neis <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035802}
Fix mac-backuprefptr-x64-fyi-rel failure
Adds missing builder_spec to mac-backuprefptr-x64-fyi-rel
Change-Id: I80969d21176071db4d08187440df09a9c9f11e6b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3831621
Commit-Queue: Keishi Hattori <[email protected]>
Reviewed-by: Garrett Beaty <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035801}
Switch //chrome to use ENABLE_PPAPI
Switches //chrome to use the ENABLE_PPAPI buildflag for PPAPI-specific
code, rather than the more general ENABLE_PLUGINS buildflag.
Bug: 1306610
Change-Id: Ie1c32c9c1397fb15a4930d6cb24ee0e06648d5d3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3828658
Commit-Queue: K. Moon <[email protected]>
Reviewed-by: Lei Zhang <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035800}
[chrome] Fix some cpplint errors in chrome part7
chrome/browser/devtools/chrome_devtools_manager_delegate.cc:50:
"base/command_line.h" already included at chrome/browser/devtools/chrome_devtools_manager_delegate.cc:11 [build/include] [4]
chrome/browser/dom_distiller/distillable_page_utils_browsertest.cc:33:
"testing/gmock/include/gmock/gmock.h" already included at chrome/browser/dom_distiller/distillable_page_utils_browsertest.cc:27 [build/include] [4]
chrome/browser/enterprise/browser_management/browser_management_status_provider.cc:20:
"chrome/browser/browser_process.h" already included at chrome/browser/enterprise/browser_management/browser_management_status_provider.cc:9 [build/include] [4]
chrome/browser/enterprise/connectors/reporting/extension_install_event_router_unittest.cc:11:
"chrome/browser/enterprise/connectors/reporting/extension_install_event_router.h" already included at chrome/browser/enterprise/connectors/reporting/extension_install_event_router_unittest.cc:4 [build/include] [4]
chrome/browser/enterprise/connectors/reporting/realtime_reporting_client.cc:43:
"chrome/browser/policy/chrome_browser_policy_connector.h" already included at chrome/browser/enterprise/connectors/reporting/realtime_reporting_client.cc:20 [build/include] [4]
Bug: None
Change-Id: Ia831bdb451d2fb48839fda7ddc2abee1508bc4e1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3826319
Reviewed-by: Andrey Kosyakov <[email protected]>
Auto-Submit: Qi Tiezheng <[email protected]>
Reviewed-by: Nicolas Ouellet-Payeur <[email protected]>
Reviewed-by: Wei-Yin Chen <[email protected]>
Commit-Queue: Andrey Kosyakov <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035799}
webauthn: ensure that reported transports are unique.
Since kAndroidAccessory is a different value from kHybrid, but they're
both converted into "hybrid", we need to ensure that they're
deduplicated. This is a generally good property to have anyway since
we're already sorting them.
Change-Id: I5835f09ccbacdf2f285902bc298612ec05933755
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3827857
Commit-Queue: Adam Langley <[email protected]>
Reviewed-by: Martin Kreichgauer <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035798}
[ios][feed] Make 8 hour default for foreground MaxCacheAge
Change-Id: If4a2106727bb6c03441d7dbcabd09b92586e4896
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832323
Commit-Queue: Sergio Collazos <[email protected]>
Auto-Submit: edchin <[email protected]>
Commit-Queue: edchin <[email protected]>
Reviewed-by: Sergio Collazos <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035797}
CSSColor: Use Color instead of RGBA32 in parsing
Change parsing functions to populate a Color instead of an RGBA32. We
will soon populate Color with non-RGBA32 values.
Delete a couple of unused functions in Color, while in the
neighborhood.
Bug: 1351544
Change-Id: I0e2e480f6a14f26fe062f4a0d3f1d1ee923bb133
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3826291
Reviewed-by: Juanmi Huertas <[email protected]>
Reviewed-by: Fernando Serboncini <[email protected]>
Commit-Queue: ccameron chromium <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035796}
Skip GpuCrash_InfoForHardwareGpu on Mac Debug Intel.
Already skipped on Mac Debug, on NVIDIA and AMD GPUs.
Move Mac Debug AMD suppression for this test from the temporary to
permanent skip expectations.
Bug: 1338955
Change-Id: I2365ce222167470733deaa4db7b0c41f231905c6
No-Try: True
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3835146
Commit-Queue: Kenneth Russell <[email protected]>
Reviewed-by: Brian Sheedy <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035795}
Use css variables for font family and size
Define font family and font size as css variables instead of javascript
variables. Use updateStyles to update them, following the Polymer
library example on custom properties.
Bug: 1266555
Change-Id: Ied5ed778aa3c071a6d70aa29759098f2e9712335
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3831884
Reviewed-by: Abigail Klein <[email protected]>
Commit-Queue: Shari Trewin <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035794}
[ViewsAX] Move function implementations to base class
For this CL, we move the implementations of GetTreeId,
GetParentTreeID,GetRootAsAxNode, and WillBeRemovedFromMap
from the overrides at BrowserAccessibilityManager,
AutomationAxTreeWrapper and ViewsAxTreeManager
to their parent AxTreeManager,
reducing code duplication between the three
since now they all share the same implementation.
Bug: 1049261
Change-Id: I9732e7807b389259bc2aa4c57fa6657ed7d10577
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3823373
Reviewed-by: Benjamin Beaudry <[email protected]>
Reviewed-by: Daniel Libby <[email protected]>
Commit-Queue: Javier Contreras <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035793}
Update list and dict Value usage in account_manager_handler.cc
Only Value::List and Value::Dict should be used to access and update
list and dict Values - other APIs are all deprecated.
Bug: 1187001, 1338341
Change-Id: Ib4c295562b033f9573fc97a324409e1f9537eb70
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3828428
Commit-Queue: Matt Menke <[email protected]>
Reviewed-by: Xiaohui Chen <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035792}
Fixes some of the rendering status lines issues in AnsibleDialog
* Modified the text conversion to be ascii -> utf16 instead of utf8 like a
clown.
* Forces the dialog to update with OnStateChanged.
* Updates AnsibleManagementService to send progress updates during Ansible
installation
I'll need to do a chromeos side change to pop all the empty lines at the
back of the progress because we're sending empty lines. There'll still be
a massive block of text that floods in at the end of the execution process,
but I suspect that'll remain the same since it's an Ansible output thing.
TEST: unittests
Bug: b:237345049
Change-Id: Ib5f8257b52f05a6952a4906774e39175ef7febc8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3829761
Reviewed-by: Nicholas Verne <[email protected]>
Commit-Queue: Nicholas Verne <[email protected]>
Auto-Submit: Justin Huang <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035791}
Reland WebUI: Migrate cr-dialog to class based syntax
Also updating to use the CrContainerShadowMixin, instead of the legacy
CrContainerShadowBehavior. Making cr_container_shadow_behavior files
ChromeOS Ash only, since with this change it is no longer used on other
platforms.
Updating to class based syntax also breaks some closure targets when
the type is not imported directly but is used in closure annotations
in a file. To address this, this CL also adds
import {CrDialogElement} from ...
in various ChromeOS files still typechecking with closure compiler.
Bug: 1206112
Change-Id: I46d83b706d3933eeef32625ea17ca35caaf39021
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3833505
Reviewed-by: John Lee <[email protected]>
Reviewed-by: Luciano Pacheco <[email protected]>
Commit-Queue: Rebekah Potter <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035790}
saved_desks: Remove callback from CreateNewDeskFromTemplate.
This function was taking a callback and thus giving people the idea
of it being async. However, the callback was always invoked directly
from the function.
To simplify things, the callback has been removed and the function
will now return the newly created desk.
Additionally, the function will now require that callers check
whether a new desk can be created (using `CanCreateDesks()`) first.
This makes the function consistent with `DesksController::NewDesk`.
Change-Id: I9508332f7494e1d0adb20ff9316e0988467f8697
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3826449
Reviewed-by: Richard Chui <[email protected]>
Commit-Queue: Daniel Andersson <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035789}
[Flaky Reproducer] Create flaky-reproducer builder
Create a flaky-reproducer builder that allow trybot users trigger
reproducing jobs via bb command.
The builder use builderless bot and the same swarming pool as the given flaky sample as tester.
The builder is meant to be manually triggered or automatically triggered with low priority during off-peak hours (automatically triggering TBD).
Bug: 1326336
Change-Id: I0c2db2462a7a7da543c1a0624842de877ae9a503
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3823232
Reviewed-by: Ben Pastene <[email protected]>
Commit-Queue: Kuan Huang <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035788}
FrameSet NG: Copy FrameSetLayoutData in the simplified layout algorithm
This CL has no behavior changes due to a disabled runtime flag.
Bug: 1346221
Change-Id: I0eb01889dbf3260b9d8af7b07e9936238170d00f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3828772
Commit-Queue: Kent Tamura <[email protected]>
Reviewed-by: Ian Kilpatrick <[email protected]>
Auto-Submit: Kent Tamura <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035787}
Move STYLE_EMPHASIZED and STYLE_EMPHASIZED_SECONDARY to views::style
Consolidates the ChromeTextStyle and AshTextStyle fields of the same
name into views::style::TextStyle
Bug: 1352342
Change-Id: I37eacd4ba634fb8713a6a69344e29aa2fd6fa750
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3820133
Reviewed-by: Peter Boström <[email protected]>
Reviewed-by: Ahmed Fakhry <[email protected]>
Commit-Queue: Austin Sullivan <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035786}
Add metrics to count the number of fetch handlers.
We intend to categorize the fetch handlers and tell it via
EmbeddedWorkerInstanceHost::OnStarted. However, multiple fetch handlers
can be set for a service worker, and we need further consideration
what to return.
To understand current status, we intend to gather metrics.
Bug: 1347319
Change-Id: I0a7d20ee6693001f7e4ead52ff7e371f047ea826
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3805195
Reviewed-by: Kouhei Ueno <[email protected]>
Commit-Queue: Yoshisato Yanagisawa <[email protected]>
Reviewed-by: Hiroki Nakagawa <[email protected]>
Reviewed-by: Ben Kelly <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035785}
[ZPS] Update ZeroSuggestProvider to enable ZPS prefetching on Web
Although Zero-Prefix Suggestions (ZPS) on Web is already active in the
current version of the codebase, the corresponding prefetching logic has
not yet been activated for Web. Unlike ZPS prefetching on NTP, the
prefetch logic used on Web will be given a non-empty page URL which will
need to be sent over to the remote zero-prefix suggestions service.
This CL updates the various checks in the ZeroSuggestProvider code to
now work properly when executing ZPS prefetch requests on Web (which are
given non-empty page URLs).
Bug: 1344004
Change-Id: I23d574366c99047808b691535fe177ee6c9d69d1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3829915
Commit-Queue: Khalid Peer <[email protected]>
Reviewed-by: Moe Ahmadi <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035784}
[stts/desktop] Hide "Your devices" link if there's no target device
This is the equivalent of crrev.com/c/3826260 for Desktop.
Bug: 1219433
Change-Id: I1bc8c822cd84b0c07ce92386debf6f3226b01033
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832669
Auto-Submit: Victor Vianna <[email protected]>
Commit-Queue: Victor Vianna <[email protected]>
Reviewed-by: Elly Fong-Jones <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035783}
Support auto-always-translate-language in the Translate Message UI.
This CL adds support for auto-always-translate-language to the Clank Messages implementation of the Translate UI, modelled after the infobar UI's support of auto-always-translate-language.
Design doc (googler only, sorry): https://docs.google.com/document/d/131bx-rtYQavH4sUXoj60oTvrFnxeB_u_pHsfDlFN3d8/edit?usp=sharing&resourcekey=0-DQEHbKEiiSq8P7IzLXH3bA
Bug: 1311774
Change-Id: I36e44b279259c136d356370ed2bc9914a511cb9f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3826790
Reviewed-by: Trevor Perrier <[email protected]>
Commit-Queue: Scott Little <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035782}
[remoting] Avoid overlaps when resizing an X11 Output.
This implements a simple algorithm for avoiding overlaps when
increasing the size of an Output/CRTC.
Any CRTCs to the right of the Output's original rectangle are shifted
right by the same amount. By applying the same shift to each of these
CRTCs, we avoid introducing new overlaps. The amount of shift is
determined to be the least possible that resolves overlaps with the
CRTC being resized.
Similarly, any CRTCs below the Output's original rectangle are shifted
down by the same amount, calculated similarly.
This method seems to work well, even though it's not an optimal
rectangle-packing solution!
Bug: 1326339
Change-Id: I99ff8bd5f4df685817df161ba0a01fc6071f0d3c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832413
Reviewed-by: Jamie Walch <[email protected]>
Commit-Queue: Lambros Lambrou <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035781}
Add new feature tracker feature for iOS Overflow Menu
This allows tracking behavior on the Overflow Menu for use in the
FeatureEngagementTracker, as well as adding a new feature to the tracker
for Overflow Menu IPH.
Bug: 1344522
Change-Id: I3db9e025602bb96f25be94cc3f12fb89e285246d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3828714
Reviewed-by: Tommy Nyquist <[email protected]>
Reviewed-by: Rohit Rao <[email protected]>
Commit-Queue: Robbie Gibson <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035780}
Final removal of IPC macros in //remoting
A little over a year ago we were asked to remove our IPC macro usages
as part of a broad clean-up effort and to modernize our IPC impl by
moving to Mojo. Fast-forward ~1 year and 20 CLs later and the end is
here (for IPC macros that is).
This CL replaces the last remaining IPC message in //remoting with a
shiny new Mojo interface. This message was used by the
WorkerProcessLauncher which would use it to ask a child process to
crash (exit) and produce a dump. I've updated the callsites to use
the new interface, tested the impl to make sure it will crash the
child process when requested, fixed the tests, and removed all
references to our old IPC macro file.
This should be it, no more crufty IPC in CRD!
<skeletor_smashing_mirror_as_they_exit.gif>
Bug: b:178114059
Change-Id: Ifbba870fbdb58c7731afd04559d3943e1d89eae0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3799549
Reviewed-by: Yuwei Huang <[email protected]>
Commit-Queue: Joe Downing <[email protected]>
Reviewed-by: Daniel Cheng <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035779}
Implement custom issuers for Trust Token.
Bug: 1342255
Change-Id: I0487a8dc0747de39fd77961b2e608855d61f0b01
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3823473
Reviewed-by: Kinuko Yasuda <[email protected]>
Commit-Queue: Steven Valdez <[email protected]>
Reviewed-by: Russ Hamilton <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035778}
[journeys] Added history clusters side panel searchbox
Added searchbox to history clusters side panel to assist in navigation.
Additionally added a string for no search results.
screenshot: http://screenshot/4paFrHBnRkxexQU
Bug: 1310280
Change-Id: I6aa66f24948462159d771c8b7d075243d7a1f0f5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3786941
Reviewed-by: Caroline Rising <[email protected]>
Reviewed-by: Rebekah Potter <[email protected]>
Commit-Queue: Marlon Facey <[email protected]>
Reviewed-by: Tommy Li <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035777}
[DownloadBubble] Update Field Trial for beta and stable experiment
Update field trials, and disable the download bubble feature for download notification tests on lacros. When the download bubble feature is active, chromeos notifications are disabled, so to test them, the feature needs to be disabled.
Bug: 1265640
Change-Id: I9c876c22483648df6b268cbe8bed6cab70a84ff4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3831931
Reviewed-by: Min Qin <[email protected]>
Commit-Queue: Rohit Bhatia <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035776}
[Read Anything] Update toolbar to observe theme changes and other UI fixes
This CL is part of the Read Anything feature.
With this CL we connect the existing toolbar with the existing theme
through the model observer, and update the background of the
toolbar to match the background of the content (per UI design). We
also update the button icon tints to match the foreground of the
theme (used for text color). We make some small UI adjustments as
per design (remove combobox border, add a color palette icon, remove
the dropdown arrow from color choices, etc).
There are only visual changes with this CL, nothing functional.
Screenshot: https://screenshot.googleplex.com/9ZRynXpivvkN7Ek.png
AX-Relnotes: N/A
Bug: 1266555
Change-Id: I721f6c0d9e81896cdf39216b168864fafc14b3d0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3829673
Reviewed-by: Abigail Klein <[email protected]>
Commit-Queue: Mark Schillaci <[email protected]>
Reviewed-by: Taylor Bergquist <[email protected]>
Reviewed-by: Evan Stade <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035775}
[omnibox][search_engines] Add EnteredKeywordModeByEngineType UMA histogram.
This CL creates a new BuiltinEngineType enum that specifies whether a
specific search engine is a prepopulated engine, a starter pack engine,
or a non-built-in (manually added or open search auto-added). It also
emits a new `EnteredKeywordModeByEngineType` histogram that enumerates
keyword mode entries by the BuiltinEngineType types.
Bug: 1287313
Change-Id: Ia65b82404d82d027e62531c29942bfa76939782f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3827806
Reviewed-by: manuk hovanesian <[email protected]>
Commit-Queue: Angela Yoeurng <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035774}
[CodeHealth] MediaInternalsAudioFocusHelper base::Value refactor
This CL updates the use of base::Value in
MediaInternalsAudioFocusHelper, removing any use of deprecated classes,
or methods.
Bug: 1187001
Change-Id: I6584e904d25e9b6a049c48422cef0c8202ac935f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3829153
Commit-Queue: Claudio DeSouza <[email protected]>
Reviewed-by: John Rummell <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035773}
Extend Shutdown.* metrics
This CL is extending the metrics since the investigation is still
active.
[email protected]
Bug: 1351036,1351037,1351038,1351039
Change-Id: I5614d560a8ddabf4d95c9825f3c383db68f0254a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832454
Reviewed-by: Mark Pearson <[email protected]>
Commit-Queue: Etienne Bergeron <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035772}
cros: add a cache for highlight border overlay
HighlightBorderOverlay is using dynamically generate images with
NinePatchLayers. However, the replaced image source is not removed which
may cause performance issue.
This cl adds a cache of the source images for different highlight border
appearance. The highlight border overlay is mainly featured by its
highlight color, border color and rounded corner radius. Each dark and
light mode has only one set of highlight and border colors. The windows
that are using HighlightBorderOverlay have three different rounded
corner radius. Therefore, the cache size of source images is acceptable.
However, when dynamic color is enabled or the HighlightBorderOverlay is
applied to more window types, the cache size may be increased. We need
to take care of it if the cache size is too large.
Manually test that with the same pixel ref of the source image,
UIResourceManager will not create a new resource.
Bug: 1353075
Change-Id: Ic9be06a75b2d8b80c2c8d5bf4734ee6a6d9ce37b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3829092
Commit-Queue: Xiaodan Zhu <[email protected]>
Reviewed-by: Xiyuan Xia <[email protected]>
Reviewed-by: Xiaodan Zhu <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035771}
[Test Automation] Add better logging when testing w/InteractionSequence
There are a number of tests which work almost all of the time but
occasionally seem to flake. This CL adds two nice-to-haves:
- Correct debug printing of InteractionSequence enums
- A method that can be used to print the state of a sequence when the
sequence times out during a test (otherwise, this data tends to not
end up in the log for the test)
Example usage:
base::test::ScopedRunLoopTimeout timeout(
FROM_HERE, kTestTimeout,
sequence->GetTimeoutMessageGeneratorForTesting());
sequence->RunSynchronouslyForTesting();
Change-Id: I4e70c4d6a1d54bcf4ea8b508c47d70804e0c1e40
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3826028
Reviewed-by: Peter Boström <[email protected]>
Commit-Queue: Dana Fried <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035770}
[blink] Use Ahem font to improve Blink unit tests' hermeticity.
Some Blink unit tests sourced fonts from the platform, which broke
test isolation. This CL switches the tests to use the test font "Ahem"
and updates the test expectations accordingly.
List of broken tests:
- WebFrameTest.DivScrollIntoEditablePreservePageScaleTest
- All/SelectionBoundsRecorderTest.SelectMultiline/LegacyLayout
- All/SelectionBoundsRecorderTest.SelectMultiline/LayoutNG
- WebFrameTest.DivScrollIntoEditableTest
Bug: 1352956
Change-Id: Ie695bdd236fd3c63152e94b0284d9a4fe91686ca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832293
Auto-Submit: Kevin Marshall <[email protected]>
Commit-Queue: Nate Chapin <[email protected]>
Reviewed-by: Nate Chapin <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035769}
Remove "Create shortcut" option from webstore in chrome://apps.
The Web Store is kind of a weird app where creating a short cut doesn't
really work well (at least on mac), so remove the option entirely rather
than trying to make it work.
Bug: 1347011
Change-Id: I700c3616ac19c40f52b6eaf7e219d9558d4beb52
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3835042
Commit-Queue: Marijn Kruisselbrink <[email protected]>
Reviewed-by: Daniel Murphy <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035768}
ambient: rm setting page components pt1
Remove ambient mode settings page.
BUG=b/242568053
TEST=Manually
Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Change-Id: I497d83fe808682eb31a559ae2973c9f3e91e92d9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3829263
Reviewed-by: Xiaohui Chen <[email protected]>
Commit-Queue: Jason Thai <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035767}
[exo] Apply min/max constraints to the requested buffer size.
Currently exo's xdg-shell impl doesn't apply the min/max size
constraints when the buffer size is updated. This spec isn't clearly
specified, but looks like some X11 apps depends on X11's WM manager
oo change its size. This CL updates the size so that it will satisfy
the condition.
Bug: 1330028, b/207430591
Test: Covered by unittests. Also tested using win.c in 133028.
Change-Id: I87abe970c54d036d0382f7d6d5a6eacc2bb8d6b3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3827939
Reviewed-by: Chloe Pelling <[email protected]>
Commit-Queue: Mitsuru Oshima <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035766}
[capture] Synchronous shutdown in VideoCaptureDeviceLinux
In commit 2c4a1317a2c26e7d2941d59fb7c40ede97c62e1e,
VideoCaptureDeviceLinux changed from having synchronous shutdown to
asynchronous shutdown. In some cases, this allows a new capture device
to be created before the shutdown is complete, resulting in failure.
Bug: 1352948
Change-Id: I3fe4802edcba3a6079130f6dd9841f6ae00e2ae6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832933
Auto-Submit: Dan Sanders <[email protected]>
Reviewed-by: Chrome Cunningham <[email protected]>
Commit-Queue: Chrome Cunningham <[email protected]>
Commit-Queue: Dan Sanders <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035765}
[remoting] Replace for_each() with C++11 range-based for-loops.
In X11CrtcResizer, I added some calls to base::ranges::for_each() but
I realize now that C++11 range-based for-loops are a better choice.
A 'continue' statement seems more intuitive than an early-return from a
lambda.
I think the other base::ranges algorithms are still useful, so I've
left those in place.
Change-Id: I17b516b4a4fe4d74b506b364011ccd92a1bdf35a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3835102
Commit-Queue: Jamie Walch <[email protected]>
Auto-Submit: Lambros Lambrou <[email protected]>
Reviewed-by: Jamie Walch <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035764}
HLS: Inform playlist parsing function of expected playlist version
This CL provides `hls::MediaPlaylist::Parse` and
`hls::MultivariantPlaylist::Parse` with the expected hls version of the
playlist being parsed. This is useful to know in advance since the rules
and semantics of various tags change depending on the version the
playlist declares, and the spec does not require the EXT-X-VERSION tag
in any specific part of the playlist. It does require that the version
does not change between playlist reloads, so the version can be
determined up front via `hls::Playlist::IdentifyPlaylist` and reused
across reloads.
Future CLs will plumb this version number down to the lower-level
parsing functions that require it. This CL adds basic tests to ensure
that the semantics of this parameter work as documented.
Bug: 1266991, 1284763
Change-Id: I747d5ca6c409159d4dda50a590f4e97bc2d5d166
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3823150
Commit-Queue: Will Cassella <[email protected]>
Reviewed-by: Matthew Wolenetz <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035763}
[grid] Small fixes & remove complex baseline logic.
Previously we had complicated "truth tables" to determine the correct
baseline. These were un-intuitive, and complex.
This patch introduces the concept of a writing-mode to read a baseline
for a particular grid-item.
This is what the spec(s) use, and should be easier to keep consistent
with the spec.
The two tests updated were using the wrong edge to synthesize their
respective baselines.
Change-Id: I576b79444e27e03583c709eb15e9e13d400e8b94
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3813642
Reviewed-by: Kurt Catti-Schmidt <[email protected]>
Commit-Queue: Ian Kilpatrick <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035762}
Revert "Add Tangible sync flow for signin row in main settings"
This reverts commit 4cee9379113bfc4c729d491143793be5192b49df.
Reason for revert: newly added tests fail on bots (see
https://crbug.com/1353505).
Original change's description:
> Add Tangible sync flow for signin row in main settings
>
> This cl adds the tangible sync flow launch capability to the signin
> preference in main settings page. This flow is guarded by a flag.
>
> Bug: 1332527
> Change-Id: I9222fa0512e1fcd55a012a9fa37853a9b66b0226
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3819763
> Reviewed-by: Boris Sazonov <[email protected]>
> Commit-Queue: Tanmoy Mollik <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1035435}
Bug: 1332527, 1353505
Change-Id: I6e82abcd635da0999b0c7752c77d0ef08986f193
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834451
Commit-Queue: Rubber Stamper <[email protected]>
Auto-Submit: Boris Sazonov <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035761}
Reland "Add LowPriorityAsyncScriptExecution feature"
This reverts commit e489d86e20e6d7d6fba343340686ef71593f35f0.
Reason for revert: After my CL was reverted, sample-on-last-keyframe.html was still failing (like below). So reland the reverted CL.
https://ci.chromium.org/ui/p/chromium/builders/ci/mac11-arm64-rel-tests/8763/blamelist
Original change's description:
> Revert "Add LowPriorityAsyncScriptExecution feature"
>
> This reverts commit f1b02444b28530edceca3d2edb9c5fdb6fb5410a.
>
> Reason for revert: I suspect that this CL caused a failure of virtual/threaded-no-composited-antialiasing/animations/sample-on-last-keyframe.html (time out)
>
> The first failed build: https://ci.chromium.org/ui/p/chromium/builders/ci/mac11-arm64-rel-tests/8756/overview
>
>
>
> Original change's description:
> > Add LowPriorityAsyncScriptExecution feature
> >
> > This CL adds LowPriorityAsyncScriptExecution feature. The basic idea of
> > LowPriorityAsyncScriptExecution is to run async script when the main
> > thread is doing nothing. But at the same time, we want to avoid waiting
> > too long to run async scripts. So this CL also adds a timeout mechanism.
> >
> > Design Doc:
> > https://docs.google.com/document/d/1RNSiQS3fG2olC52RRJ6Y7jY9LjWKn5Z2HZ3b9Qp0nmw/edit#bookmark=id.dr5ecxnx2kco
> >
> > Bug: 1348467
> > Change-Id: I06cad47e540da307046a105f6e737bced83cbf04
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3793626
> > Reviewed-by: Kouhei Ueno <[email protected]>
> > Commit-Queue: Minoru Chikamune <[email protected]>
> > Reviewed-by: Kentaro Hara <[email protected]>
> > Reviewed-by: Alexander Timin <[email protected]>
> > Reviewed-by: Scott Haseley <[email protected]>
> > Cr-Commit-Position: refs/heads/main@{#1035376}
>
> Bug: 1348467
> Change-Id: I10f02865dcd9901e2055d1efaa0109f6e8719856
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3830020
> Owners-Override: Maxim Kolosovskiy <[email protected]>
> Bot-Commit: Rubber Stamper <[email protected]>
> Reviewed-by: Maxim Kolosovskiy <[email protected]>
> Auto-Submit: Maxim Kolosovskiy <[email protected]>
> Commit-Queue: Rubber Stamper <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1035470}
Bug: 1348467
Change-Id: I781c195e2e48c72a1256d7c041416f2bbb939d3b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3833523
Reviewed-by: Maxim Kolosovskiy <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Reviewed-by: Kentaro Hara <[email protected]>
Reviewed-by: Alexander Timin <[email protected]>
Owners-Override: Maxim Kolosovskiy <[email protected]>
Commit-Queue: Minoru Chikamune <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035760}
[Settings] Disable remove language icon when unable to remove language
This CL will make the remove language icon disabled when the language is
unremovable. Since there must always be at least one language in the
never offer to translate language list, when there is one language, it
is unremovable.
See bug for screenshot.
Bug: 1352577
Change-Id: Iefaa8613a9a4bdf878c7cb008fa27dfb5fe47c93
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3830048
Reviewed-by: Rebekah Potter <[email protected]>
Reviewed-by: Trevor Perrier <[email protected]>
Commit-Queue: Andrea Gomez <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035759}
[SearchResumption] Fix naming.
Bug: 1332596
Change-Id: I7e1342a98c79845f6e2154147eb7b09d4855edff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832961
Reviewed-by: Hao Dong <[email protected]>
Commit-Queue: Xi Han <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035758}
Shimless: Update strings for UX
Select components: http://screen/6xAaSM7TQp8RmNL
Welcome page: http://screen/7uHqAHvfg2mmqp5
Get connected: http://screen/jdA838sWfQJg5ji
Repair complete: http://screen/6f2pn4tHaAGc8m6
Bug: 1198187
Change-Id: I793c021d958962bc287c901a4fd81013bc42797e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3828150
Commit-Queue: Gavin Williams <[email protected]>
Reviewed-by: Michael Checo <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035757}
[Signin][Android] Add support for new initialization flow
Implements a new initialization flow in SigninFirstRunMediator.
The new initialization flow doesn't wait for the native initialization
to show the list of account and continue/dismiss buttons.
This CL also adds 3 new experiment groups to
FREMobileIdentityConsistencySynthetic experiment:
InitializationFlowNew, InitializationFlowOld and
InitializationFlowControl. These groups will be enabled by subsequent
CLs.
Bug: 1343837
Change-Id: If9444e5d954903ea36c02daaab0ee8f9a87591a6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3827827
Reviewed-by: Tanmoy Mollik <[email protected]>
Commit-Queue: Boris Sazonov <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035756}
FrameSet: Fix an issue by a large relative value in rows/cols attribute
In LayOutAxis(), handling of large relative values were inconsistent:
- ClampTo<int> is applied in total_relative computation.
- ClampTo<int> is not applied in grid_layout[i] computation.
It could produce sizes greater than |available_len| and negative sizes.
Bug: 1353277
Change-Id: I3a992ffe05ac9f892182124c934f0df8af34fa50
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832987
Reviewed-by: Morten Stenshorne <[email protected]>
Commit-Queue: Kent Tamura <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035755}
[SearchResumption] Fix mismatch of Expand/Collapse chevron icon in multi Window
The bug was caused by keeping the default chevron icon if the current
Expand/Collapse state matches the state to set. In this CL, we update
the chevron icon when the module is first displayed.
Demo:
https://drive.google.com/file/d/1ipRf6HL9DTAgpYryPDJriRNfOPcR5Ddn/view?usp=sharing
Bug: 1353388
Change-Id: I2bcc548dad571faf5f4ca250942d3a40fb23ffc6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3833480
Commit-Queue: Xi Han <[email protected]>
Reviewed-by: Hao Dong <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035754}
[CPA] Added feature engagement rate limits to action chip
Bug: 1348606
Change-Id: I80f0a878849c52390fc2c4f15032d78192cc84f5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3794429
Reviewed-by: Matthew Jones <[email protected]>
Reviewed-by: Shakti Sahu <[email protected]>
Commit-Queue: Salvador Guerrero Ramos <[email protected]>
Reviewed-by: Tommy Nyquist <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035753}
win: drop out-of-bound Textfield::ExtendSelectionAndDelete operations
This change in effect reverts https://crrev.com/c/3713409 in Textfield.
Previously, out-of-bound calls to ExtendSelectionAndDelete are dropped.
This does not seem to cause any bad observable behaviors.
Bug: 1344096
Change-Id: I4c1eff513d075b0876dbc6a031ce10cf0fe24d74
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3833392
Commit-Queue: Keren Zhu <[email protected]>
Reviewed-by: Peter Kasting <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035752}
Fix invisible apps page caused by aborted show animation.
Bug: 1349833
Change-Id: I65153a130c660741bf8fefc03f121a4fb297f997
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3833501
Commit-Queue: Yulun Wu <[email protected]>
Reviewed-by: James Cook <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035751}
Roll Perfetto from d7a3c46d8622 to 2fbf8d8bf878 (4 revisions)
https://android.googlesource.com/platform/external/perfetto.git/+log/d7a3c46d8622..2fbf8d8bf878
2022-08-16 [email protected] Pivot table: fix drilldown when non-slice pivots are used
2022-08-16 [email protected] Merge "Do not show Slices aggregation panel with Pivot Table"
2022-08-16 [email protected] Merge "Pivot table: menu item to remove aggregation column"
2022-08-16 [email protected] Merge "Partial revert of "Partial revert of aosp/2166563""
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel
Bug: None
Tbr: [email protected]
Change-Id: I9792907080a2268f424c9b9cd555715c05c5c6db
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834375
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035750}
Do not set fallback text to a11y name of AssistantCardElementView
- ChromeVox can interact with elements inside webview. It should be
unnecessary to set fallback text. Also fallback text is empty for the
most cases.
Assistant. Confirm that you can access elements inside the
webview.
Bug: b:239259921
Test: Turn on ChromeVox and query "what's the weather" with Google
Change-Id: Ifce0e1c7d616aad9aea15a7b514e7ff280e2c298
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3824560
Reviewed-by: Jason Thai <[email protected]>
Commit-Queue: Yuki Awano <[email protected]>
Reviewed-by: Yue Li <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035749}
Revert "[libc++] Enable assertions on all builds and add a handler for release builds"
This reverts commit 84d5f89427e270d1830c359f9df082ff48709317.
Reason for revert: Breaks win64-builder-perf (crbug.com/1353463)
Original change's description:
> [libc++] Enable assertions on all builds and add a handler for release builds
>
> Enabling assertions improves security in libc++ by guarding against
> undefined behaviors (e.g. accessing an element out of bounds in
> std::vector).
>
> For release builds, this patch implements a libc++ assertion handler
> using libc++'s assertion mechanism introduced in
> https://reviews.llvm.org/D12147. The intent of this implementation is to
> closely match what absl does[0]. For non-debug builds, absl just
> aborts[1], so we call IMMEDIATR_CRASH(...) in the nondebug libc++
> assertion handler.
>
> For debug builds, we just use the default libc++ assertion handler. Absl
> calls assert(false && expr) in debug builds [2], which has the net
> effect of printing the failed assertion to stderr and aborting. The
> default libc++ assertion handler does this as well [3], so we'll just
> use that instead of implementing a Chromium-specific libc++ debug
> assertion handler.
>
> The assertion handler is implemented in //base as it depends on
> base/immediate_crash.h.
>
> [0]: https://crsrc.org/c/third_party/abseil-cpp/absl/base/macros.h;l=129-135;drc=eb8f0c03122e5cef55d62a1d59c7f36496c07d0a
> [1]: https://crsrc.org/c/third_party/abseil-cpp/absl/base/macros.h;l=106-116;drc=eb8f0c03122e5cef55d62a1d59c7f36496c07d0a
> [2]: https://crsrc.org/c/third_party/abseil-cpp/absl/base/macros.h;l=97-99;drc=eb8f0c03122e5cef55d62a1d59c7f36496c07d0a
> [3]: https://github.com/llvm/llvm-project/blob/d434e40f398e3144c69d57d2a142d35e2f760a8e/libcxx/src/verbose_abort.cpp#L32
>
> Binary-Size: Size increase due to added assertion checks in libc++
> Bug: 1335422
> Change-Id: I34f5a8995f64286d4b4f367d04a0df0302d88cf3
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3805403
> Commit-Queue: Alan Zhao <[email protected]>
> Reviewed-by: Andrew Grieve <[email protected]>
> Reviewed-by: Nico Weber <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1035591}
Bug: 1335422
Change-Id: Ib2d197dac5f4764541318bcdc9a7216853458eb6
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834069
Reviewed-by: Alan Zhao <[email protected]>
Commit-Queue: Alan Zhao <[email protected]>
Owners-Override: Daniel Cheng <[email protected]>
Reviewed-by: Daniel Cheng <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035748}
Skip flaky test AppListMainViewTest.DragReparentItemOntoPageSwitcher
This test is parameterized by ProductivityLauncher. It causes flaky
crashes in the GPU subsystem, but only when ProductivityLauncher is
off. I'm not sure why these crashes occur.
The ProductivityLauncher flag is on-by-default, and we'll be cleaning
up the code for the off case shortly. Just skip the test when
ProductivityLauncher is off.
Bug: 1351834
Test: ash_unittests
Change-Id: I66f9e207e2eab67e649b092bc9a0b6faee561f15
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832789
Quick-Run: James Cook <[email protected]>
Commit-Queue: James Cook <[email protected]>
Reviewed-by: Matthew Mourgos <[email protected]>
Auto-Submit: James Cook <[email protected]>
Commit-Queue: Matthew Mourgos <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035747}
Add a WebContentsObserver for document PiP in window manager
We need to reset pip_window_controller when the parent web contents are
being destroyed so that we will not call any function on
pip_window_controller after it is destructed, since the web contents
owns the controller rather than the window manager.
This aims to resolve the unit tests failure in
https://crrev.com/c/3823701.
Bug: 1346734
Change-Id: Ia8960e66f327987921180c329ecb03f27afd6002
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832145
Commit-Queue: Yiren Wang <[email protected]>
Reviewed-by: Fr <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035746}
multipaste: Move clipboard history histograms out of monolithic ash XML
This CL creates a new directory for clipboard history histograms,
populated with the clipboard history metrics previously in ash's
histograms file. This clipboard history metrics directory allows us to
modify histograms without top-level metrics reviewer intervention.
Bug: 1351528
Change-Id: Ic25644045de51fdcb456aadab6790f8051e11701
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3820266
Auto-Submit: Colin Kincaid <[email protected]>
Reviewed-by: David Black <[email protected]>
Commit-Queue: Colin Kincaid <[email protected]>
Reviewed-by: Alexei Svitkine <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035745}
Add yawano@ to chromeos assistant OWNERS file
Bug: none
Change-Id: Ief21e92c5a03dcf0fa0e89b4099e7f8231adc719
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3833758
Commit-Queue: Yuki Awano <[email protected]>
Reviewed-by: Xiaohui Chen <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035744}
Add NonMainThread public interface for scheduling.
Rename WorkerThread to NonMainThreadImpl. Move CreateThread into
the NonMainThread class.
The motivation behind this is to eventually restrict GetTaskRunner on
Thread via a passkey but leave it generally available for all on
NonMainThread. This will promote usage of the correct task runners on
the main thread.
BUG=624696
Change-Id: I378edf1b9af800a18a820c787aceaa04f449c103
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3828310
Reviewed-by: Kouhei Ueno <[email protected]>
Reviewed-by: Daniel Cheng <[email protected]>
Commit-Queue: Dave Tapuska <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035743}
Projector: Add OWNERS to chrome/browser/ui/ash/projector
This CL reorganizes some OWNERS files for Projector.
Bug: b:237089852
Change-Id: Id0c9825e2ae88b036921fbba099f156beb996549
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3828718
Reviewed-by: Trent Apted <[email protected]>
Reviewed-by: Li Lin <[email protected]>
Commit-Queue: Li Lin <[email protected]>
Auto-Submit: Toby Huang <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035742}
Roll Depot Tools from 268d645853ee to f9fede5f843d (1 revision)
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/268d645853ee..f9fede5f843d
2022-08-16 [email protected] [mac_toolchain] Roll mac_toolchain in depot_tools to latest version
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/depot-tools-chromium-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: chromium:1348212
Tbr: [email protected],[email protected],[email protected],[email protected]
Change-Id: I03e3f2661f31363b5053dedac9e3c1726fe4f93c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3833665
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035741}
DragDropController: avoid creating empty drag image widget.
This CL skips running cancel animation if there is no drag image, but preserves the long tap event processing.
In addition, this CL also makes some other changes to drag_drop_controller:
1) Consolidate |drop_weak_factory_| and |weak_factory_| and ensure that all async callbacks are invalidated when a new drag is started.
2) Ensure correct order of ending cancel animation and setting new drag image.
3) Some cleanup of unittests.
Bug: 1349821
Change-Id: I1563513193518d88738bf15f779630a2251cf1bd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3818344
Commit-Queue: Yuzhu Shen <[email protected]>
Reviewed-by: Mitsuru Oshima <[email protected]>
Reviewed-by: Scott Violet <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035740}
desktop-share-preview: add fieldtrial testing config
Get the likely launch config (the default, favicon only) running on the
bots :)
Bug: 1351156
Change-Id: If1d91d50247b65e27c20b2087a2706498ed5ae8a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834286
Commit-Queue: Jeffrey Cohen <[email protected]>
Commit-Queue: Elly Fong-Jones <[email protected]>
Reviewed-by: Jeffrey Cohen <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035739}
Reland "[src] Add inverse filter file generation for RTS/Quick Run"
This is a reland of commit 43071dbc5c8a71b1ab80fa1690fb87ed1ba786b3
The last patchset from the original CL combined the actions for
generating dummy filter files but the first arg was used twice in
add_rts_filters.py making it attempt to create the normal filter file
twice instead of the inverse filter file. Example failing build:
https://ci.chromium.org/ui/p/chromium/builders/try/linux-rel-compilator/317461/overview
The CL was then submitted instead of triggering a Quick Run first which missed the erroneous code. We are able to verify Quick Runs but
they require manual triggering before submitting.
Original change's description:
> [src] Add inverse filter file generation for RTS/Quick Run
>
> When RTS is enabled this will additionally generate the inverted
> filter file (a file that will only run the skipped tests), add it to
> the isolate and generates additional commands to run with these
> inverted filter files.
>
> See the design doc for more detailed information:
> http://docs/document/d/14XNntG5FNhf_lyTLtc1XlU2ZfiKmv8NzJK87D1m6zBE?resourcekey=0-GrHDLuC_iRkseeaEfGI-cQ
>
> led build using this CL:
> https://ci.chromium.org/raw/build/logs.chromium.org/chromium/led/sshrimp_google.com/15464dab518d5d7b92932010409bb216b5d47e7a695691fe016448e8247be9c6/+/build.proto?server=chromium-swarm.appspot.com
>
> Bug: 1344885
> Change-Id: Ic438bbb44495d2eb6d80e653f68a747d8f70e170
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3765373
> Reviewed-by: Takuto Ikuta <[email protected]>
> Reviewed-by: Ben Pastene <[email protected]>
> Commit-Queue: Struan Shrimpton <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1034546}
Bug: 1344885
Change-Id: I92f15385348d73f5783e3c8ead35380274942ce7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3827208
Reviewed-by: Takuto Ikuta <[email protected]>
Reviewed-by: Ben Pastene <[email protected]>
Commit-Queue: Struan Shrimpton <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035738}
Switch ash and lacros CI builders to highmem 8 cores machines
Experiment if e2-highmem-8 can help with the long compile
time issue.
Bug: 1345687
Change-Id: Ibdf05e60ba0c439eb8cd3ec94929bc3898c51cdb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834171
Reviewed-by: Gary Tong <[email protected]>
Commit-Queue: Sven Zheng <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035737}
[anchor-position] |NGPhysicalFragment::AnchorQuery| returns null if empty
This patch changes |NGPhysicalFragment::AnchorQuery| to return
`nullptr` if it's empty.
Before this patch, it returned an empty |NGPhysicalAnchorQuery|
if other |OutOfFlowData| exist, but returning an empty one is
useless for callers.
Bug: 1309178
Change-Id: I77ae5f5e6bcf662b1478669800e790ad8162379e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3833675
Auto-Submit: Koji Ishii <[email protected]>
Commit-Queue: Kent Tamura <[email protected]>
Reviewed-by: Kent Tamura <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035736}
Add comment explaining why ForcedColors flag should stay (for now).
Bug: 1231644
Change-Id: Ifc7eaee53c2d4b476ccc6fdd3e104832ba0dd491
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3828659
Reviewed-by: Daniel Libby <[email protected]>
Commit-Queue: Daniel Libby <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035735}
Remove an extra step added to the original tab group tutorial.
We accidentally added an extra step to the original tutorial. This step is removed and then both tutorials were tested to verify the correct steps.
Change-Id: I5e94bd5d38391a923eb3dd693e91d8c3cb152dc5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834844
Auto-Submit: David Pennington <[email protected]>
Commit-Queue: Dana Fried <[email protected]>
Reviewed-by: Dana Fried <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035734}
launcher: Show dragging mouse pointer when performing app drag
Fixed: 1251586
Test: Manually, added unit tests.
Change-Id: I71413b802890ab7640fec654bb66233663b88451
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3811458
Reviewed-by: Yulun Wu <[email protected]>
Reviewed-by: Toni Barzic <[email protected]>
Commit-Queue: Elliot Tuck <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035733}
Remove extra space in histogram token
When added in:
https://chromium-review.googlesource.com/c/chromium/src/+/3818264
There was an extra space in NotPerceptible.
See emission location:
https://source.chromium.org/chromium/chromium/src/+/6fd7b450c61ed1f602f20b29d094b8034364b028:content/public/android/java/src/org/chromium/content/browser/ChildProcessConnectionMetrics.java
Change-Id: I7dec195a904f2e6610fcdd61d1db6c83054326eb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832960
Commit-Queue: Calder Kitagawa <[email protected]>
Reviewed-by: Hao Dong <[email protected]>
Auto-Submit: Calder Kitagawa <[email protected]>
Commit-Queue: Hao Dong <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035732}
[Settings] Never translate languages will use getTranslatableLanuages_()
In translate_page.ts, onAddNeverTranslateLanguagesClick_() will use
getTranslatableLanguages() so the Add Never Translate Languages dialogue will show only translateSupported languages.
Bug: 1352666
Change-Id: Ia49d640c2e38f8c3b467bea141e729dd4ea86ff2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3828196
Reviewed-by: Rebekah Potter <[email protected]>
Reviewed-by: Trevor Perrier <[email protected]>
Commit-Queue: Andrea Gomez <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035731}
Replace requestIdleCallback with double-rAF in wpt/accessibility tests
Two accessibility/crashtests are flaky because requestIdleCallback
requires threaded compositor mode in Blink to work properly. This CL
fixes the flakes by replacing requestIdleCallback with a double-
requestAnimationFrame, which runs the class resetting code after the
main contents has been rendered. This pattern is used by other
accessibility crashtests, e.g. slot-assignment-lockup.html.
Alternatively we could run these tests in the virtutal/threaded test
suite, but changing the tests seems reasonable since there's a precedent
for double-rAF pattern and requestIdleCallback isn't supported yet in
WebKit.
Bug: 1353428
Change-Id: I51497f7f93bf43cbc4e25fb28179e579bd98dc29
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834842
Reviewed-by: Daniel Libby <[email protected]>
Commit-Queue: Scott Haseley <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035730}
[QuickStart] Generate EndpointInfo
Add a method to build the endpoint info bytes that will be sent in the
Nearby Connections advertisement.
See
https://docs.google.com/document/d/1vgDv8KTEIJ9NJisK3Lu9bSCvgvx1Wx-zW75H90IbwvE/edit?usp=sharing
TEST=Add unit test that parses the generated EndpointInfo.
Bug: b/234655072
Change-Id: Ief92521428cf61146c2013975c8cf095823c9c2e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3829019
Commit-Queue: Curt Clemens <[email protected]>
Reviewed-by: Michael Hansen <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035729}
[Autofill] Move files to use autocomplete_processing_util in form_field_data
In a future change, we would like to store the AutocompleteParsingResult (defined in autofill/core/browser/..) as a member in FormFieldData (autofill/core/common/).
This change moves dependent files to autofill/core/common to support this future change.
Bug: 1153539
Change-Id: I322654c865416a51fa0be84d821414abc01e5120
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3822707
Reviewed-by: Christoph Schwering <[email protected]>
Reviewed-by: Mohamed Amir Yosef <[email protected]>
Commit-Queue: Eva Herencsarova <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035728}
Allow Finching default high efficiency mode state
Bug: 1308741
Change-Id: I97d0ba20017e39b6e290a7c8a74a19f3002bd932
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3830748
Reviewed-by: Chris Hamilton <[email protected]>
Commit-Queue: Anthony Vallée-Dubois <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035727}
Create dot indicator in ash/style for app notification
Originally, the shelf app button uses the dot indicator in ui/views
while app list item view implements the dot indicator within its class.
As the dot indicator in ui/views has borders and doesn't have shadow,
this cl moves the indicator implemented in app list item view to
ash/style and apply that to shelf app button.
Bug: 1235852
Change-Id: I204f057c7f60b82e76eb74a585e2df4d82eee4a9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3812100
Reviewed-by: Toni Barzic <[email protected]>
Reviewed-by: Xiaodan Zhu <[email protected]>
Commit-Queue: Wen-Chien Wang <[email protected]>
Reviewed-by: Xiaoqian Dai <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035726}
Roll Dawn from dadb934e1978 to d9d6dfac9ab5 (4 revisions)
https://dawn.googlesource.com/dawn.git/+log/dadb934e1978..d9d6dfac9ab5
2022-08-16 [email protected] Enable the workaround about T2T copy on Intel Gen11 GPUs
2022-08-16 [email protected] Roll SwiftShader from a6c3e363b7a9 to c61fc9aec162 (1 revision)
2022-08-16 [email protected] tint: Fix implicit conversion of vector-scalar of abstract types in binary operations
2022-08-16 [email protected] Roll ANGLE from 2089943b951d to 0f5770deabf2 (1 revision)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dawn-chromium-autoroll
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel
Bug: chromium:1161355,chromium:1350147
Tbr: [email protected]
Change-Id: I667652ccfb55ccd2a4896f473bbb74bd1cf946d4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834005
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035725}
Roll Chrome Mac Arm PGO Profile
Roll Chrome Mac Arm PGO profile from chrome-mac-arm-main-1660650975-30813d08c6ccb5b6f1a6077df2f97a642093a30b.profdata to chrome-mac-arm-main-1660669594-8a0a8a5b58f64bf1e726898f026080ff1bbbfc9e.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-arm-chromium
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:mac-chrome
Tbr: [email protected]
Change-Id: Iedf3672aa618241f17aa164ae6363dc26d9d0f7c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3833671
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035724}
Add ArcEnableTTSCacheSetup experiment fieldtrial entry.
Bug: b:229014327
Change-Id: Ic9387cdea4ba8df4631f78133615827209f4b52e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3829488
Reviewed-by: Yury Khmel <[email protected]>
Commit-Queue: Hung Nguyen <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035723}
[ozone/wayland] Pair WaylandEventSource::TouchFrame and PointerFrame
... structs up.
Next CL, will merge them both into one.
BUG=1351376
[email protected]
Change-Id: I296102486d301f059ed3897b0ae52a9fce83a9dd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3829824
Reviewed-by: Nick Yamane <[email protected]>
Commit-Queue: Antonio Gomes <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035722}
[QuickStart] Truncate RandomSessionId to 10 bytes
The EndpointInfo expected by SmartSetup requires that the random session
id is 10 bytes long, but we're currently using base::UnguessableToken,
which is 16 bytes long.
TEST=Manually tested that FastPairAdvertiser still triggers the half
sheet. Existing unit tests provide full coverage.
Bug: b/234655072
Change-Id: Ie02cc847a1031de09f9217fadf89c6b30df91c04
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3827293
Commit-Queue: Curt Clemens <[email protected]>
Reviewed-by: Michael Hansen <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035721}
Add support for additional rounded corner behavior
This CL adds backend support for a `NotRounded` option
for TrayBackgroundView corners. This will be used for
the `DateTray` when the `NotificationCenterTray` is
visible.
Bug: 1311738
Change-Id: I301a7622f0afc79e86fc53badffabc7a0ca44ae1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3829311
Commit-Queue: Ahmed Mehfooz <[email protected]>
Reviewed-by: Jiaming Cheng <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035720}
Roll src-internal from 02a7f1d33d15 to 6882dd54f1b6 (8 revisions)
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/02a7f1d33d15..6882dd54f1b6
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: chromium:1352973
Tbr: [email protected],[email protected]
Change-Id: Id5f751755f2af17aa67c252f841e75e4d5e1a45c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3833591
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Reviewed-by: Emily Shack <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035719}
Expose Leak Check Service from ChromeWebView
Expose an API to allow bulk leak checks of CWVPassword from the CWVWebViewConfiguration.
Bug: 1352971
Change-Id: I89a593d8a95cf2af1b872479ae60bfe8f9915811
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3831883
Reviewed-by: John Wu <[email protected]>
Commit-Queue: Dan Riley <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035718}
[anchor-position] Add tests for inline containing block
This patch adds a test when the containing block is an inline
box. The test contains 24 assertions, combining following
conditions:
* The anchor and the inline containing block are
1) Single line.
2) Wrapped to two lines.
3) Wrapped to two lines by a forced break.
3) Wrapped to two columns.
* The querying element is
1) In the containing block.
2) In the same inline formatting context.
3) Outside of the inline formatting context.
* The two functions:
1) `anchor()`
2) `anchor-size()`
Bug: 1309178
Change-Id: If3f120ca48f63c61c7aa6d804b9e67d7f7bf0f72
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3831796
Commit-Queue: Koji Ishii <[email protected]>
Reviewed-by: Ian Kilpatrick <[email protected]>
Auto-Submit: Koji Ishii <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035717}
[infra] Fix reviver builder definitions.
* The value in the dimensions must be strings, so convert any non-string
values using str().
* Add the reviver service account to the BUILDBUCKET_TRIGGERER acl so
that the coordinator can trigger the runner.
Bug: 1346396
Change-Id: Ic9b17c60c81ebf848afbe668bbc38b33442c2300
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832312
Auto-Submit: Garrett Beaty <[email protected]>
Reviewed-by: Ben Pastene <[email protected]>
Commit-Queue: Ben Pastene <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035716}
Remove DialogFocusNewSpecBehavior flag
This flag was introduced a while ago as a killswitch in case the new
behavior broke any websites. Since it has been in stable since M93, it
should be removed.
Bug: 298078
Change-Id: I684de2afadff77342e33ae75dc8b9f5157d3e8f0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832317
Reviewed-by: Xianzhu Wang <[email protected]>
Commit-Queue: Joey Arhar <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035715}
Roll SwiftShader from 708ca9579181 to c61fc9aec162 (4 revisions)
https://swiftshader.googlesource.com/SwiftShader.git/+log/708ca9579181..c61fc9aec162
2022-08-16 [email protected] Implement VK_EXT_primitive_topology_list_restart
2022-08-12 [email protected] Regres: Roll dEQP to main revision eaf78cb
2022-08-11 [email protected] Ignore feature structs of partially promoted extensions
2022-08-11 [email protected] Don't expose VK_EXT_external_memory_host on macOS
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-chromium-autoroll
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86
Bug: None
Tbr: [email protected]
Change-Id: Ia1e08aee135a811c6cb8bd844084707060c57418
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3833997
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035714}
Roll Chrome Mac PGO Profile
Roll Chrome Mac PGO profile from chrome-mac-main-1660650975-78f2abc50319e2e21df10a82759f3c1451ffd523.profdata to chrome-mac-main-1660669594-ab66c8ad86c45aa98b2a82524a1be164c1c793cf.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:mac-chrome
Tbr: [email protected]
Change-Id: Ib5f9772c56c40e069fc8d4bd095e43d477c55eb0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834370
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035713}
Move AddDllToUnload to sandbox config
This shifts the collection of dlls to unload from child processes
to the config part of the sandbox policy.
Bug: 549319
Change-Id: Ia923ab597cf3c518da04f62b06b74509c547dff5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3806131
Reviewed-by: Tom Sepez <[email protected]>
Reviewed-by: Kenneth Russell <[email protected]>
Commit-Queue: Alex Gough <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035712}
Roll RTS model from cgreUs4CTQV8qLilU... to eXuajLr_13p-4rXI2...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/rts-linux-amd64-chromium-autoroll
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: [email protected]
Change-Id: Ie311c02d9329cd42a2db41b38d81a9e541718a8e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834348
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035711}
cros: Add a toolchain to build 32-bit nacl_helper
Define a cros_nacl_helper_arm32_toolchain which will be used
to build 32-bit nacl_helper in Arm64 builds.
The variables cros_nacl_helper_arm32* will be set by chromeos-chrome
ebuild or by the SimpleChrome script.
Bug: b:242104777, b:188495414
Test: cros chrome-sdk with --gn-extra-args="<var:value>"
Change-Id: I88c6a026b2abd978e13c53509d31da6c2b4be250
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3828483
Reviewed-by: Fabian Sommer <[email protected]>
Commit-Queue: Manoj Gupta <[email protected]>
Reviewed-by: Reid Kleckner <[email protected]>
Reviewed-by: Takuto Ikuta <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035710}
Fix divide by zero crash bug in NQE
Verify that duration passed to
IsHangingWindow() is positive to avoid divide by zero
crash in NQE (Network Quality Estimator).
Bug: 1351428
Change-Id: I17791b57a44ca67c888542449d76593d80278bc7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3829795
Commit-Queue: Tarun Bansal <[email protected]>
Reviewed-by: Ryan Sturm <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035709}
Remove is_ubsan_null gn flag
-fsanitize=null is already part of is_ubsan.
Seemingly no buildbot users of this flag.
Bug: 616870
Change-Id: If09baca5ec132a2a6dfeafe83ae5c30bccc0c23f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834184
Reviewed-by: Nico Weber <[email protected]>
Commit-Queue: Arthur Eubanks <[email protected]>
Reviewed-by: Mirko Bonadei <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035708}
[fuchsia] Enable fuchsia-binary-size trybot.
Remove experimental trybot condition, to make this bot mandatory.
The bot checks that the given change does not increase the binary size of Chrome-Fuchsia binaries of interest (WebEngine and CastRunner), with
the following failure conditions:
- +12kB increase in compressed size (with >0 uncompressed increase).
- +100kB in compressed size (regardless of uncompressed increase).
Documentation (shown during failure): https://chromium.googlesource.com/chromium/src/+/HEAD/docs/speed/binary_size/fuchsia_binary_size_trybot.md
Median runtime is currently at <10mins, with 90th percentile at
25mins, and 99th percentile jobs taking 34mins.
Bug: 1302137
Change-Id: Ide2c01d352cee0f6ec171da669d88f9d71a5a949
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834604
Reviewed-by: Erik Staab <[email protected]>
Commit-Queue: Rohan Pavone <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035707}
Correct owner for flakiness-data-packager builder
The original "google/[email protected]" group was not exported
to cria and it's an open to join group. This CL corrected this to
"mdb/chrome-flakiness".
The mdb group is exported to cria.
Bug: 1291685
Change-Id: I71f9f06fb382f5b520786d1a1ee2cd30a4064da1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3828556
Commit-Queue: Kuan Huang <[email protected]>
Reviewed-by: Ben Pastene <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035706}
Revert "[TangibleSync] Add variation strings for tangible sync view"
This reverts commit d1c4933fffc62ef2412c9b3f8e6e753235a2549b.
Reason for revert: Breaking builder.
https://ci.chromium.org/p/chromium/builders/ci/android-marshmallow-x86-rel
Original change's description:
> [TangibleSync] Add variation strings for tangible sync view
>
> This cl adds a title and a subtitle variation for tangible sync consent
> view. These different views are configured by finch field trial param.
> This cl thus modifies the existing flag setup to field trial with
> params.
> This cl also adds tests for these two different views. The
> @DisableFeature annotation has also been moved from the class level to
> the test level. Otherwise the test configuration for field trial tests
> were getting overridden by the class level annotation.
>
> Bug: 1332527
> Change-Id: I4efb511c159aec14320944f3497667cc5e8dfa25
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3825875
> Reviewed-by: Boris Sazonov <[email protected]>
> Commit-Queue: Tanmoy Mollik <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1035466}
Bug: 1332527
Change-Id: I42c7d7b5890f18d67f03445e3430b8dc73151406
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3835022
Owners-Override: Aishwarya Rajesh <[email protected]>
Commit-Queue: Aishwarya Rajesh <[email protected]>
Auto-Submit: Aishwarya Rajesh <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035705}
Re-enable AssistantOnboardingViewTest.DarkAndLightModeFlagOff
- Re-enable the test case with a fix.
Bug: b:242596633,chromium:1352671
Change-Id: I771dee3c203f65e41aaae6b8b53589cb74bcc90a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834247
Commit-Queue: Yuki Awano <[email protected]>
Auto-Submit: Yuki Awano <[email protected]>
Reviewed-by: Tao Wu <[email protected]>
Reviewed-by: Sean Kau <[email protected]>
Reviewed-by: Jeffrey Young <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035704}
compute pressure: skipping web tests on Windows due to flaky results
Compute pressure web tests do not use mock backend.
With the current Windows backend, web tests are flaky.
While the code is being reworked and looking for a root cause,
it was decided to temporarily skip the web tests on Windows.
Bug: 1351905
Change-Id: I0c4e63de12e48ed312e4c1fb5792eac98d2d906a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3826238
Reviewed-by: Dominic Farolino <[email protected]>
Reviewed-by: Raphael Kubo Da Costa <[email protected]>
Reviewed-by: Koji Ishii <[email protected]>
Commit-Queue: Arnaud Mandy <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035703}
Fix some argb order problems
Bug: 1308932
Change-Id: I9488318a399ee5e540096dce0126750097045e4e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3827802
Commit-Queue: Aaron Krajeski <[email protected]>
Reviewed-by: Robert Phillips <[email protected]>
Reviewed-by: Robert Kroeger <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035702}
[popup] Add a runtime feature, fieldtrial config, and OT config
Add a blink Feature for HTMLPopupAttribute, and add it to the
fieldtrial testing config. Also add an origin_trial_feature_name
to the runtime feature, and plumb Document to everywhere that
feature is checked.
This is in preparation for both an Origin Trial and a potential
Finch test to ensure Web Compat for the added attributes.
Bug: 1307772
Change-Id: If9eda7dd08eefc4faec633f5a514465fe87ed3f0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3824684
Reviewed-by: Joey Arhar <[email protected]>
Reviewed-by: Philip Jägenstedt <[email protected]>
Reviewed-by: Nate Fischer <[email protected]>
Reviewed-by: Rune Lillesveen <[email protected]>
Reviewed-by: Xianzhu Wang <[email protected]>
Commit-Queue: Mason Freed <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035701}
[remoting] Implement basic per-monitor resize for X11.
This resizes the specified monitor, keeping its original xy-offset.
The root window is resized to the bounding rectangle of all RANDR
Outputs after modification.
This is a basic implementation that does not attempt to adjust any
xy-offsets, so it may sometimes result in overlapping Outputs. This
will be addressed in a followup CL.
This implementation makes some simplifying assumptions that each
RANDR Monitor is "automatic" for a single Output, and each Output is
attached to 0 or 1 CRTCs. These are satisfied for Xvfb, and for Xorg
with the video-dummy driver (as long as the user doesn't create non-automatic Monitors).
Bug: 1326339
Change-Id: I03daa4ee6eab78e496b9267a1e21485c674ec9d8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832655
Reviewed-by: Jamie Walch <[email protected]>
Commit-Queue: Lambros Lambrou <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035700}
Ensure structs/methods are defined/declared before use.
This fixes compile errors in C++20, which in many cases is stricter
about this due to greater inlining/constexpr use in libraries. (Or
something like that; I'm not 100% sure what's causing the disparity.)
Bug: 1284275
Change-Id: Ia5dea754ae5fec59d20bc7b8ae68d5d23eba6855
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3827278
Reviewed-by: David Trainor <[email protected]>
Reviewed-by: Nico Weber <[email protected]>
Reviewed-by: Will Cassella <[email protected]>
Reviewed-by: Hirokazu Honda <[email protected]>
Reviewed-by: Mike West <[email protected]>
Commit-Queue: Peter Kasting <[email protected]>
Reviewed-by: Mark Foltz <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035699}
Reland "Reland "[Mohnstrudel] UAF regression test with InteractionSequence""
This reverts commit aa3cb45a2c8e693e83c896144936fbb68f7ed64d.
Reason for revert: Diagnosed and fixed linux-chromeos-chrome trybot-specific issue (due to specific build configuration). Inserted workaround for issue 1352701, which is separate from the regression under test.
Original change's description:
> Revert "Reland "[Mohnstrudel] UAF regression test with InteractionSequence""
>
> This reverts commit 778ebf866dfa3a98ce4e37ddb36277c05af70dc9.
>
> Reason for revert: CloseTabDuringDrag fails consistently
>
> Bug: 1352602
>
> Original change's description:
> > Reland "[Mohnstrudel] UAF regression test with InteractionSequence"
> >
> > This reverts commit c01d2b3f304169d0034aafbeddf24161d1d82224.
> >
> > Reason for revert: Fixed UAF and race condition in the test code that simulates a drag; see crbug.com/1352040
> >
> > This contains two fixes not in the original:
> > 1. endpoint of drag is bound by value instead of reference, and lambdas involved in the drag also use a weak pointer to prevent a UAF
> > 2. avoid a race condition when the webui tabstrip could start to close during the test as a response to the drag or the other window closing
> >
> > Otherwise the test is identical to before.
> >
> > Original change's description:
> > > Revert "[Mohnstrudel] UAF regression test with InteractionSequence"
> > >
> > > This reverts commit 9f32835e1e8ccebcc8775fa944b407cfe9b7169d.
> > >
> > > Reason for revert: https://crbug.com/1352040
> > > Crashes on linux-chromeos-* and Linux Chromium OS ASan LSan Tests
> > >
> > > Original change's description:
> > > > [Mohnstrudel] UAF regression test with InteractionSequence
> > > >
> > > > This is a proposed alternate version of the regression test found in
> > > > https://chromium-review.googlesource.com/c/chromium/src/+/3588859
> > > > which uses InteractionSequence and related techniques to lay out a test
> > > > plan.
> > > >
> > > > This test is useful for a couple of reasons:
> > > > - it employs complex inputs
> > > > - it touches both Views and WebUI code
> > > > - it addresses a drag-drop bug with the tabstrip, which is a very
> > > > common class of uncommon UAF bugs
> > > >
> > > > Three of the steps in this sequence and a LOT of boilerplate could be
> > > > condensed into one with a Drag() verb (which is planned but we
> > > > currently don't have yet).
> > > >
> > > > Change-Id: I850ab3edb04b264fe4129976eef78168a5251b53
> > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3614664
> > > > Reviewed-by: Chris Bookholt <[email protected]>
> > > > Commit-Queue: Dana Fried <[email protected]>
> > > > Cr-Commit-Position: refs/heads/main@{#1033801}
> > >
> > > Change-Id: I2caf0f44927643f1212cffccc097e28f37459432
> > > No-Presubmit: true
> > > No-Tree-Checks: true
> > > No-Try: true
> > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3827287
> > > Reviewed-by: Dan S <[email protected]>
> > > Auto-Submit: Aga Wronska <[email protected]>
> > > Reviewed-by: Aga Wronska <[email protected]>
> > > Reviewed-by: Dana Fried <[email protected]>
> > > Commit-Queue: Dana Fried <[email protected]>
> > > Cr-Commit-Position: refs/heads/main@{#1034121}
> >
> > Change-Id: Iabe96e660fcfa204ee2b70a05520698e24f66b58
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3828161
> > Reviewed-by: Dan S <[email protected]>
> > Commit-Queue: Dana Fried <[email protected]>
> > Cr-Commit-Position: refs/heads/main@{#1034517}
>
> Change-Id: Ibc7e938d88d1b1963386b6168828aed193433138
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3828015
> Owners-Override: Mohsen Izadi <[email protected]>
> Reviewed-by: Mohsen Izadi <[email protected]>
> Auto-Submit: Frank Liberato <[email protected]>
> Commit-Queue: Mohsen Izadi <[email protected]>
> Bot-Commit: Rubber Stamper <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1034670}
Bug: 1352602
Change-Id: I39b4347c8fcbb6298f8eec984dd4c4327a88b532
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3827720
Commit-Queue: Dana Fried <[email protected]>
Reviewed-by: Yuheng Huang <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035698}
QuoteContentData pseudo_style should use parent lang to create LayoutObject
Following the resolution of WHATWG HTML standard [1] and
existing CSS issue [2], it has been decided that the
auto (default) lang for <q> element should be based on the parent
language, and not the language of the element itself.
We change the function QuoteContentData::CreateLayoutObject so that
the ComputedStyle for the pseudo children of the <q> element will
use its parent locale.
[1] https://github.com/whatwg/html/issues/3636
[2] https://github.com/w3c/csswg-drafts/issues/5478
Change-Id: I5eb7c7dcdc4f2c73e99880598b230c02652ec953
Bug: 753671
Fixed: 1290851
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3795145
Reviewed-by: Koji Ishii <[email protected]>
Reviewed-by: Dominik Röttsches <[email protected]>
Commit-Queue: Di Zhang <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035697}
Fix gdb logging command
gdb commands 'set logging [on|off]' is depreciated. Use
set logging enabled [on|off]
See https://sourceware.org/gdb/onlinedocs/gdb/Logging-Output.html
Change-Id: I86128b3cf8c0bf6acef4bc2a74ab1bd097bbc25a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832642
Reviewed-by: Thomas Anderson <[email protected]>
Commit-Queue: Aykut Bulut <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035696}
[Feed Position] Extend NewTabPage.FeedPositionSegmentationResult.
Bug: 1353030
Change-Id: I18d5a9be97888ae6ac574be4eb6c4e74af4acfe9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832403
Reviewed-by: Mark Pearson <[email protected]>
Reviewed-by: Xi Han <[email protected]>
Commit-Queue: Hao Dong <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035695}
Refactor TopSitesImpl to use PrefService::GetValueDict
This is part of a larger migration effort based on
go/trust-your-prefs.
Bug: 1341996
Test: Existing unit tests
Change-Id: I431147b502613f40106c8c769199c6129ea287e6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3829232
Reviewed-by: Sophie Chang <[email protected]>
Commit-Queue: Roland Bock <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035694}
Roll Skia from a77024ee45e9 to 0450b8d5a2a4 (20 revisions)
https://skia.googlesource.com/skia.git/+log/a77024ee45e9..0450b8d5a2a4
2022-08-16 [email protected] Skip activate-emsdk for arm linux
2022-08-16 [email protected] Roll vulkan-deps from 816e6850b549 to 4f5fbed615fa (2 revisions)
2022-08-16 [email protected] Improve interpolation of radial gradients
2022-08-16 [email protected] Remove old (unused) LEGACY_RCP_RSQRT define from raster pipeline
2022-08-16 [email protected] fix assert when we're getting line metrics
2022-08-16 [email protected] Roll Dawn from c81cefe06ea4 to bade13a5d2e7 (2 revisions)
2022-08-16 [email protected] Roll vulkan-deps from 863822794aa7 to 816e6850b549 (2 revisions)
2022-08-16 [email protected] Fix SkImageFilters::ColorFilter when color filter is null
2022-08-16 [email protected] [graphite] Transform bounding box on the GPU
2022-08-16 [email protected] Create SkStrikePromises
2022-08-16 [email protected] In breakTextIntoLines, use the parent's line metrics if the line does not have valid metrics
2022-08-16 [email protected] Add missing SkStream include in SkResources
2022-08-16 [email protected] Enhance documentation for MakeSweep
2022-08-16 [email protected] Check for abandoned context in drawDrawable
2022-08-16 [email protected] [Graphite] Store Mtl queue on QueueManager instead of SharedContext.
2022-08-16 [email protected] Remove glyphs excluded logic
2022-08-16 [email protected] Remove skia_core_defines
2022-08-16 [email protected] Roll vulkan-deps from 00de9b28c7c8 to 863822794aa7 (2 revisions)
2022-08-16 [email protected] Pass in premul constant color for blend4f color filter on SkVM
2022-08-16 [email protected] Revert "Reland "Reland "Guarantee that raster pipeline always uses finite stack"""
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Cq-Do-Not-Cancel-Tryjobs: true
Bug: chromium:1350418
Tbr: [email protected]
Change-Id: I8c94d04911f3585f5f5e61e7b0c9655a6c83e40a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834002
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035693}
[@container] No !important in style() queries
!important should not be part of a valid style() query. Add tests for
custom property matching.
Bug: 1302630
Change-Id: I001d2d5784c2618cb57a30db61973f3647a27068
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832231
Reviewed-by: Anders Hartvoll Ruud <[email protected]>
Commit-Queue: Rune Lillesveen <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035692}
first-run: allow setting canary as default browser
This has been requested for a long time, but we couldn't previously
allow it because of lack of side-by-side install support. This change
both allows setting canary as default, and removes the code paths from
the first run dialog for hiding the first run prompt.
Fixed: 1350264
Change-Id: Icc0a3e61c2f48cb79dc99fcac091c9434a0af878
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3829489
Reviewed-by: Mark Mentovai <[email protected]>
Commit-Queue: Elly Fong-Jones <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035691}
Refactor SupervisedUserService to use PrefService::GetValueDict
This is part of a larger migration effort based on
go/trust-your-prefs.
Bug: 1341996
Test: Existing unit tests
Change-Id: If19bcaf356b213bd8dcd4806f3c4cba039476477
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3833536
Commit-Queue: Roland Bock <[email protected]>
Reviewed-by: Li Lin <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035690}
Revive Color Contrast Companion sources
This extension was previously internal only and lacked a home for
sources.
Placing publicly here after a line by line review and audit.
It is in hopes this extension will be picked up in any incremental work
as part of other extensions and be a marginal maintenance addition.
Sources are verbatim from original author with the exception of a few
copyright headers as part of Chromium. Future improvements to come
after.
Change-Id: Ic1e549d80984a19a552d238691db07378ddadb34
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3831797
Reviewed-by: Anastasia Helfinstein <[email protected]>
Commit-Queue: David Tseng <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035689}
Fix a typo in ozone function comment.
Change-Id: Ib576c357b955e1bf0294935d0889f16fc1b773f6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834288
Commit-Queue: Peter McNeeley <[email protected]>
Reviewed-by: Peter McNeeley <[email protected]>
Auto-Submit: Robert Kroeger <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035688}
[Frameworks roll] Roll to 467985825 piper revision
Change-Id: I212fde042b85879deb352610bd263b3f17c9145a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832406
Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1035687}
Fix early exit DCHECK failures
This CL is removing a DCHECK that is failing while adding an early
exit into PostEarlyInitialization phase.
There is currently no early exit and it is not currently failing.
We do have the intention of adding code that early exit in that
phase, which will trigger this error.
Added here:
https://chromium-review.googlesource.com/c/chromium/src/+/3650548
[23880:27688:0805/111651.158:FATAL:check_is_test.cc(16)] Check failed: g_this_is_a_test.
Backtrace:
base::debug::CollectStackTrace [0x00007FF98479CD02+18] (C:\src\chromium\src\base\debug\stack_trace_win.cc:329)
base::debug::StackTrace::StackTrace [0x00007FF9846689D2+18] (C:\src\chromium\src\base\debug\stack_trace.cc:218)
logging::LogMessage::~LogMessage [0x00007FF9846872CB+171] (C:\src\chromium\src\base\logging.cc:665)
logging::LogMessage::~LogMessage [0x00007FF9846889D0+16] (C:\src\chromium\src\base\logging.cc:658)
base::internal::check_is_test_impl [0x00007FF9846549CE+78] (C:\src\chromium\src\base\check_is_test.cc:17)
base::sequence_manager::internal::SequenceManagerImpl::~SequenceManagerImpl [0x00007FF984718393+1251] (C:\src\chromium\src\base\task\sequence_manager\sequence_manager_impl.cc:267)
base::sequence_manager::internal::SequenceManagerImpl::~SequenceManagerImpl [0x00007FF984722530+16] (C:\src\chromium\src\base\task\sequence_manager\sequence_manager_impl.cc:226)
content::BrowserIOThreadDelegate::~BrowserIOThreadDelegate [0x00007FF9745CECB0+16] (C:\src\chromium\src\content\browser\scheduler\browser_io_thread_delegate.cc:92)
content::BrowserTaskExecutor::IOThreadExecutor::~IOThreadExecutor [0x00007FF9745D05A0+52] (C:\src\chromium\src\content\browser\scheduler\browser_task_executor.cc:433)
content::BrowserTaskExecutor::IOThreadExecutor::~IOThreadExecutor [0x00007FF9745D0650+16] (C:\src\chromium\src\content\browser\scheduler\browser_task_executor.cc:433)
content::BrowserTaskExecutor::Shutdown [0x00007FF9745D00F0+240] (C:\src\chromium\src\content\browser\scheduler\browser_task_executor.cc:302)
content::ContentMainRunnerImpl::Shutdown [0x00007FF974D7D58F+271] (C:\src\chromium\src\content\app\content_main_runner_impl.cc:1224)
content::RunContentProcess [0x00007FF974D7B67A+2090] (C:\src\chromium\src\content\app\content_main.cc:455)
content::ContentMain [0x00007FF974D7B70A+90] (C:\src\chromium\src\content\app\content_main.cc:461)
ChromeMain [0x00007FF9760C1278+472] (C:\src\chromium\src\chrome\app\chrome_main.cc:182)
MainDllLoader::Launch [0x00007FF7AC9B26DA+888] (C:\src\chromium\src\chrome\app\main_dll_loader_win.cc:162)
wWinMain [0x00007FF7AC9B1BEC+3021] (C:\src\chromium\src\chrome\app\chrome_exe_main_win.cc:399)
__scrt_common_main_seh [0x00007FF7ACA61E86+262] (d:\a01\_work\12\s\src\vctools\crt\vcstartup\src\startup\exe_common.inl:288)
BaseThreadInitThunk [0x00007FF9FE6A7034+20]
RtlUserThreadStart [0x00007FF9FED82651+33]
[email protected]
Bug: 1340599
Change-Id: I9de8e7160c5197baaa0bd7e80854d35fb3cb9406
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3812404
Reviewed-by: Gabriel Charette <[email protected]>
Commit-Queue: Etienne Bergeron <[email protected]>
Reviewed-by: Alexander Timin <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035686}
Revert "WebUI: Migrate cr-dialog to class based syntax"
This reverts commit 70ddbf5707b4488980c9cd3d11dbe7642fb4f37a.
Reason for revert: Suspected culprit for tree closure, see https://ci.chromium.org/ui/p/chromium/builders/ci/linux-archive-rel/73485/overview
Original change's description:
> WebUI: Migrate cr-dialog to class based syntax
>
> Also updating to use the CrContainerShadowMixin, instead of the legacy
> CrContainerShadowBehavior. Making cr_container_shadow_behavior files
> ChromeOS Ash only, since with this change it is no longer used on other
> platforms.
>
> Updating to class based syntax also breaks some closure targets when
> the type is not imported directly but is used in closure annotations
> in a file. To address this, this CL also adds
> import {CrDialogElement} from ...
> in various ChromeOS files still typechecking with closure compiler.
>
> Bug: 1206112
> Change-Id: I4f0025dde75648932d26f4b6ae19ba10ef95d231
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3828781
> Reviewed-by: Luciano Pacheco <[email protected]>
> Reviewed-by: John Lee <[email protected]>
> Commit-Queue: Rebekah Potter <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1035674}
Bug: 1206112
Change-Id: I9999ca5e09206b5739f798a2125fde1212f58413
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832653
Owners-Override: Emily Shack <[email protected]>
Commit-Queue: Aishwarya Rajesh <[email protected]>
Auto-Submit: Emily Shack <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035685}
[CompositeClipPathAnimations] Fix a crash when a keyframe in an animation has clip-path: none
When composited clip path animations are enabled, clip path animations
that have a keyframe with clip-path: none crash.
This change adds a filter function to GetAnimationIfCompositable to
exclude animations with clip-path: none.
A clip path of none is difficult to paint with composited clip path as currently implemented, and there is no great need to composite this animation given there is no continuous interpolation to be done.
Bug: 1345977
Change-Id: I2bed8ab0ed6a41b7341f92a3bd48cc2e6457fcb4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3777767
Reviewed-by: Robert Flack <[email protected]>
Reviewed-by: Olga Gerchikov <[email protected]>
Commit-Queue: Claire Chambers <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035684}
OOBE: Updated meet flow for CFM devices
Update the meet flow so if no device requisition is set but the build
is a cfm variant the default value is set to 'remora' in Local State.
Introduced a new function in requisition manager to check if the
current device is a meet/cfm device.
Bug: b/214251446
Test: Built and flashed device board cfm variants with cfm images and ensured it defaulted to the OOBE flow since the devices are cfm variant.
Change-Id: I0fc03ce015ab9764ebe8e0b6e282bae9db5298a9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3827911
Commit-Queue: Joshua Pius <[email protected]>
Reviewed-by: Kyle Williams <[email protected]>
Reviewed-by: Roman Sorokin <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035683}
Roll WebGPU CTS from 8a9afc652513 to dd01507ff53b (1 revision)
https://chromium.googlesource.com/external/github.com/gpuweb/cts.git/+log/8a9afc652513..dd01507ff53b
2022-08-16 [email protected] Update compositingAlphaMode -> alphaMode (#1667)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webgpu-cts-chromium-autoroll
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel
Bug: None
Tbr: [email protected]
Change-Id: Ib83d0fccb909f2e4dc3ea16a83c2d8010009f6fd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834484
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035682}
personalization: fullscreen preview qol fixes
Remove overscroll-behavior: none that attempted to prevent
touchscreen swipe back to fire a popstate while fullscreen. It didn't
work properly anyway. Add a popstate handler to exit fullscreen preview
mode.
Add a wallpaper observer method OnWallpaperPreviewEnded to exit
fullscreen mode faster when wallpaper preview ends. Once preview ends,
send another OnWallpaperChanged event to sync the final state of
wallpaper with personalization app.
BUG=b:237307607
TEST=unit_tests --gtest_filter="*PersonalizationAppWallpaperProvider*"
TEST=browser_tests --gtest_filter="*WallpaperFullscreen*"
Change-Id: I1c2f1c14e352bab1b6708fd3718de7416bd8ec24
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3816823
Reviewed-by: Alex Gough <[email protected]>
Reviewed-by: Tao Wu <[email protected]>
Commit-Queue: Jeffrey Young <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035681}
Display download hash on chrome://safe-browsing
This field was missed when serializing the proto for display on
chrome://safe-browsing, but can be useful as a stable identifier
when testing download feature extraction.
Change-Id: I982ff6ad6713e14f7296327ad1bbbdef4dca9b5f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832781
Commit-Queue: Daniel Rubery <[email protected]>
Auto-Submit: Daniel Rubery <[email protected]>
Reviewed-by: Xinghui Lu <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035680}
Tidy up TabStrip vs TabContainer layout responsibilities.
Prior to this CL, layout control flow between TabStrip and its TabContainer was confusing, brittle, and tbh nonsensical, with both TabStrip and TabContainer setting their own bounds. Now TabStrip is responsible for sizing itself (which makes sense / is necessary, because TabStrip is the contents view for a ScrollView), and TabContainer just lays itself out normally within those bounds.
Bug: 1346017
Change-Id: If7a529cb091d2f5624df60e7ea6dfa956701efc5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3833678
Reviewed-by: Dana Fried <[email protected]>
Commit-Queue: Taylor Bergquist <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035679}
[Fast Pair] Extend Fast Pair flags to M109
Due to Fast Pair launch potentially being delayed we want to extend
the life of the associated flags for further data collection.
Change-Id: Ic46ae7eb8dc0fc651af1bf32815cba154ad5e77f
Fixed: b/242206131
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3828563
Reviewed-by: Jon Mann <[email protected]>
Commit-Queue: Alex Kingsborough <[email protected]>
Reviewed-by: Daniel Classon <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035678}
Refactor ExtensionRequest to use PrefService::GetValueDict
This is part of a larger migration effort based on
go/trust-your-prefs.
Bug: 1341996
Test: Existing unit tests
Change-Id: If2169795b8497e97dde7080ab47904851a822322
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3827212
Reviewed-by: Owen Min <[email protected]>
Commit-Queue: Roland Bock <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035677}
Roll RTS model from HWGL8sk_b9SwVwwSR... to 7BoYCZFP7DHtgBj2x...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/rts-mac-amd64-chromium-autoroll
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: [email protected]
Change-Id: I974f4ad4dd209231501f6fa9e9a57a67e3cb339c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834344
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035676}
Update list and dict Value usage in account_tracker_service.cc
Only Value::List and Value::Dict should be used to access and update
list and dict Values - other APIs are all deprecated.
Bug: 1187001, 1338341
Change-Id: I64162759fa6d7ed76c07af2b00c7a4b60033cdac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3828617
Reviewed-by: Alex Ilin <[email protected]>
Commit-Queue: Matt Menke <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035675}
WebUI: Migrate cr-dialog to class based syntax
Also updating to use the CrContainerShadowMixin, instead of the legacy
CrContainerShadowBehavior. Making cr_container_shadow_behavior files
ChromeOS Ash only, since with this change it is no longer used on other
platforms.
Updating to class based syntax also breaks some closure targets when
the type is not imported directly but is used in closure annotations
in a file. To address this, this CL also adds
import {CrDialogElement} from ...
in various ChromeOS files still typechecking with closure compiler.
Bug: 1206112
Change-Id: I4f0025dde75648932d26f4b6ae19ba10ef95d231
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3828781
Reviewed-by: Luciano Pacheco <[email protected]>
Reviewed-by: John Lee <[email protected]>
Commit-Queue: Rebekah Potter <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035674}
Video: Do not parse nalu headers of the same picture multiple times
When they are referring to the same picture, this is not necessary,
also add a comment about the HEVC Rext Profile support details.
Bug: 1300444
Change-Id: Ie3f9714d32b972d70da9f92207805406038e6ce5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3798837
Commit-Queue: Dan Sanders <[email protected]>
Reviewed-by: Dan Sanders <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035673}
[LTT] Abort LTT IPH when the profile is null.
Sometimes Profile.ProfileSupplier is unexpectedly returning null, so
add the null-check back so it doesn't cause crashes.
Bug: 1346710
Change-Id: I58fe4cc06b2b4ca07020d8943e30a73219ce705e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3828179
Reviewed-by: Tommy Nyquist <[email protected]>
Commit-Queue: Tommy Nyquist <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035672}
Roll Chrome Linux PGO Profile
Roll Chrome Linux PGO profile from chrome-linux-main-1660650975-0429cc669493803dc7829079efcbdbb7910f7af8.profdata to chrome-linux-main-1660669594-e1a98eac0424f7882f9f051b0b6d4d8ed43d1852.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-linux-chromium
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:linux-chrome
Tbr: [email protected]
Change-Id: Ib86eba2bd191d8f06c2b431a5716ecd853992f64
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3833589
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035671}
[power bookmarks] Ensure the bookmark model loads before price-tracking
Bug: 1352604
Change-Id: I8fbd7c2f5214cc3a435cc5d670c3d8e1f4943853
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3827492
Reviewed-by: Matthew Jones <[email protected]>
Commit-Queue: Brandon Wylie <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035670}
Remove CSSDynamicRangeMediaQueries flag
Feature has been enabled by default since M98.
Bug: 1224711
Change-Id: Idbb7e971c863c27f2b9f9e8cc54ce86eb4698d37
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3826163
Commit-Queue: Rune Lillesveen <[email protected]>
Auto-Submit: Rune Lillesveen <[email protected]>
Reviewed-by: Anders Hartvoll Ruud <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035669}
Integrating Private Aggregation with Shared Storage
Exposes a new privateAggregation.sendHistogramReport() call to Shared
Storage worklets and adds the mojo plumbing to forward these requests to
the private_aggregation/ component (if it's enabled) in the browser.
Bug: 1346108
Change-Id: Iea4db1c14fc1c0dda805a639bee917f4f9dfb2ae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3814272
Reviewed-by: Dominic Farolino <[email protected]>
Commit-Queue: Alex Turner <[email protected]>
Reviewed-by: Yao Xiao <[email protected]>
Reviewed-by: Nan Lin <[email protected]>
Reviewed-by: Alex Gough <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035668}
Lacros: integrate filter files to test runner
Integrate filter files to the test runner so developers
do not need to specify them.
Bug: 1322288
Change-Id: Ida1c234091d045cb238cc8f4910a36d7f385bb62
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832660
Commit-Queue: Sven Zheng <[email protected]>
Reviewed-by: Erik Chen <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035667}
[iOS] Cleanup AuthenticationFlow
Removes _shouldSignIn that is always sets to YES.
Removes _shouldCommitSync, and replaced with
_postSignInAction == POST_SIGNIN_ACTION_COMMIT_SYNC
To understand all the steps, I created:
https://graphviz.corp.google.com/#a881b36e57b502d447fe27493d93afc9
Change-Id: Ifa622c0e0582eb1fa14b914d71c027a30df007ff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3829278
Reviewed-by: Sebastien Seguin-Gagnon <[email protected]>
Auto-Submit: Jérôme Lebel <[email protected]>
Commit-Queue: Sebastien Seguin-Gagnon <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035666}
Stop lazy-loading SharedURLLoaderFactory in report sender
GetURLLoaderFactoryForBrowserProcess() is cheap: It creates a
scoped_refptr of a class that contains a single pointer member and does
no other initialization work in its constructor. Therefore, there's
little benefit to complicating our code to delay initialization of this
field.
Change-Id: I9bf68540ea10e5dc5af4ed615c45ce8616f49c50
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832393
Commit-Queue: Andrew Paseltiner <[email protected]>
Reviewed-by: Nan Lin <[email protected]>
Quick-Run: Andrew Paseltiner <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035665}
[CrOSEvents] Add events processor to modify events.
CrOSEvents will need to post-process events after they are recorded.
Bug: 1350322
Change-Id: I3ad749f6de99522ff47c6a545fe6bd6fcb7a089c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3812390
Reviewed-by: Hirthanan Subenderan <[email protected]>
Commit-Queue: Jong Ahn <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035664}
Roll WebRTC from f4f22872d0d9 to 0cf140d720e1 (3 revisions)
https://webrtc.googlesource.com/src.git/+log/f4f22872d0d9..0cf140d720e1
2022-08-16 [email protected] Rewrite AudioState null poller to use TaskQueueBase interface
2022-08-16 [email protected] Migrate away from rtc::MessageHandler in p2p unittests
2022-08-16 [email protected] rtc::Event: Remove call site dependency on kForever being int.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in WebRTC: https://bugs.chromium.org/p/webrtc/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: [email protected]
Change-Id: I50d8001b628cfa18f6a5f3a3640a4424c816b722
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3833583
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035663}
media/gpu/v4l2: Fix an issue with reference frames setup for AV1 decode
This CL fixes an issue with reference frames related setup
(|order_hints|) for AV1 decode. |reference_order_hint| param from
libgav1 can't be used to setup |order_hints| in V4L2 AV1 uAPI. The
algorithm has to be added to get frame number given a specific frame
type (L0, L1, L2, G, B, A1, A2) in the reference frame list. After this
fix, 10 frames were decoded correctly matching expected md5sum values.
Note that we still need to manually specify width & height for OUTPUT &
CAPTURE queue creation for testing due to b/242078563.
Bug: b:242337166
TEST: v4l2_stateless_decoder --video=00000527_20210205.ivf --frames=10 --md5 --v=4 using updated ec, kernel
Change-Id: I344095944b76b2222b9bcd483a7f8be63b10c932
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832315
Reviewed-by: Nathan Hebert <[email protected]>
Commit-Queue: Steve Cho <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035662}
[User Education] Allow custom IPH button to be default.
By default the custom action button is not the default button, but this
behavior can now be changed. If it is set to be default, the "got it"
button is then made non-default.
Bug: 1351582
Change-Id: Id25346e2d587ed304c6064f562941d345865c56b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3829811
Commit-Queue: Dana Fried <[email protected]>
Reviewed-by: Taylor Bergquist <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035661}
Remove cryptauth_device_manager_impl from chromeos safe list.
The cryptauth_device_manager_impl class already includes a partial
annotation which is sent along with the GetMyDevices call, so the
auditor shows no error on removing it. This change also fixes a small
spelling error in the annotation trigger description.
Bug: b/240321889
Change-Id: I0e6a81bdc1d83b1ba0a86b4081362819bf24e202
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3787690
Reviewed-by: Kyle Horimoto <[email protected]>
Reviewed-by: Nicolas Ouellet-Payeur <[email protected]>
Commit-Queue: Chris Mullins <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035660}
[OOBE][SAML]: Update documentation for LoginAuthenticationBehavior
Add a message that since M99 if LoginAuthenticationBehavior is set to 1,
user will be redirected to SAML IdP page directly without additional
confirmation.
Also make sure that GAIA buttons are still hidden when we are trying to
redirect to an IdP page, but getting an error.
Bug: b:228887266
Change-Id: I239e9edb92b288bd6784e5c2d8af51c4c030793f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3822907
Reviewed-by: Renato Silva <[email protected]>
Reviewed-by: Maksim Ivanov <[email protected]>
Commit-Queue: Danila Kuzmin <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035659}
Move v8::ScriptOrigin creation to ClassicScript
To make the `v8::ScriptOrigin` accessible from outside
`V8ScriptRunner`, i.e. from `ScriptCacheConsumer`.
This CL doesn't change the behavior.
Bug: 1349934
Change-Id: If0738abd0ac9d867b62aa61b5a47d6770c59f345
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3812101
Reviewed-by: Shunya Shishido <[email protected]>
Reviewed-by: Kouhei Ueno <[email protected]>
Commit-Queue: Hiroshige Hayashizaki <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035658}
[iOS] Fix titled promo fonts
Bug: 1331010
Change-Id: Iff10359ede09783c087ed361305ff9c51d3b573d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834188
Auto-Submit: Adam Arcaro <[email protected]>
Reviewed-by: Sergio Collazos <[email protected]>
Commit-Queue: Sergio Collazos <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035657}
Refactor PrivacySandbox to use PrefService::GetValueDict
This is part of a larger migration effort based on
go/trust-your-prefs.
Bug: 1341996
Test: Existing unit tests
Change-Id: I6ddf7cbbe869d5607dbb8fd94cf1548e16d1c173
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3829523
Reviewed-by: Olesia Marukhno <[email protected]>
Commit-Queue: Roland Bock <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035656}
Add more metrics for download duration
This CL adds several new metrics to try to narrow down why downloads
are taking a long time. Since the 99th percentile of
SBClientDownload.DownloadRequestDuration.* is consistently overflowing
10s, we add a medium time version, to record up to 3 minutes. This will
help to understand the long tail of file analysis time.
We also add SBClientDownload.FileFeatureExtractionDuration and
SBClientDownload.GetTabRedirectsDuration to measure the two major parts
of download request construction, and
SBClientDownload.MemoryMapFileDuration, which measure the one operation
I couldn't easily bound the time of on Linux.
Bug: 1331807
Change-Id: I5bcabae289badfa6394d2eb49714ec8579f859d3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3828507
Reviewed-by: Rohit Bhatia <[email protected]>
Commit-Queue: Daniel Rubery <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035655}
Revert "Reland investigation code for RawResourceClientStateChecker crash"
This reverts commit d7dff1c8ad831700b2ff14f2bbf24868cec35a92.
Reason for revert: we have obtained enough information with the investigation code.
Original change's description:
> Reland investigation code for RawResourceClientStateChecker crash
>
> This CL relands https://crrev.com/c/3538796 because the same crash
> happened again.
>
> Bug: 1346074
> Change-Id: Ica33dc507d81a718d6d70210a0a05466eb6f9c73
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3779441
> Commit-Queue: Minoru Chikamune <[email protected]>
> Reviewed-by: Kouhei Ueno <[email protected]>
> Reviewed-by: Yutaka Hirano <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1027635}
Bug: 1346074
Change-Id: If05aeb96b24854d494966929eccc432235303a67
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3828173
Reviewed-by: Kouhei Ueno <[email protected]>
Reviewed-by: Hiroshige Hayashizaki <[email protected]>
Commit-Queue: Hiroshige Hayashizaki <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035654}
Fix comment typo in chrome/browser/plugins/plugin_prefs.cc.
[email protected]
Change-Id: Id62332bdf333ec450a6de77f252155a9531bd837
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3827725
Reviewed-by: Nico Weber <[email protected]>
Commit-Queue: Brian Begnoche <[email protected]>
Auto-Submit: Brian Begnoche <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035653}
Move //printing to public_deps of crosapi to let USE_CUPS propagate to dependants correctly.
Change-Id: Ia650432f0d6a7e8e895db96db3cad82cf523ca29
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3780170
Auto-Submit: Andrew Rayskiy <[email protected]>
Commit-Queue: Erik Chen <[email protected]>
Reviewed-by: Erik Chen <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035652}
media/video: Update decode-test binary to receive a command line
argument |codec| which is used to select the codec for decoding.
BUG=b:239719493
TEST=tast run $volteer video.PlatformDecoding.vaapi_av1
TEST=tast run $volteer video.PlatformDecoding.vaapi_vp9_0_group1_buf
TEST=tast run $volteer video.PlatformDecoding.vaapi_vp8_inter
TEST=tast run $volteer video.PlatformDecoding.vaapi_h264_baseline
TEST=tast run $volteer video.PlatformDecoding.vaapi_hevc_main
All tests are passing except video.PlatformDecoding.vaapi_hevc_main,
which is failing for a reason unrelated to this commit. However, the
tests do verify that it is receiving the new command line argument,
which is the behavior changed in this commit.
Change-Id: I842e14099b7dc42e02b1f614c331418816d2b1d3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832457
Reviewed-by: Jao-ke Chin-Lee <[email protected]>
Reviewed-by: Andres Calderon Jaramillo <[email protected]>
Commit-Queue: Joey Allen <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035651}
[iOS] Change pipes to backticks in /ios/chrome/browser/crash_report/breadcrumbs
Please review the CL to ensure that nothing is broken and the script
didn't miss some pipes.
This should allow us to have a better formatting in Xcode.
This CL was uploaded by git cl split.
[email protected]
Bug: 1311955
Change-Id: If2f7a6db254b3a2f8dbfb466538c049cee681683
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834310
Reviewed-by: Jesse McKenna <[email protected]>
Commit-Queue: Jesse McKenna <[email protected]>
Auto-Submit: Gauthier Ambard <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035650}
Remove [email protected] from tools/metrics/histograms/metadata/enterprise/OWNERS.
This suggested change is automatically generated based on group memberships and affiliations.
If this change is unnecessary or in error, vote CR -1 and the bot will abandon it. Vote CR +1/2 to approve this change.
See the owner's recent activity for context: https://chromium-review.googlesource.com/q/[email protected]
To report an issue, file a bug in the Infra>Security component.
Change-Id: I7a92d6084b297c8e84fb75b986be9e847f1d0e5f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3833664
Reviewed-by: Amr Aboelkher <[email protected]>
Commit-Queue: Amr Aboelkher <[email protected]>
Auto-Submit: Owners Cleanup <swarming-tasks@owners-cleanup-prod.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1035649}
Remove infobar id LITE_MODE_HTTPS_IMAGE_COMPRESSION_INFOBAR_ANDROID
The infobar implementation of
LITE_MODE_HTTPS_IMAGE_COMPRESSION_INFOBAR_ANDROID has been removed.
Bug: None
Change-Id: I997b3d22b2e9957f649c8edcac0b783bc9cd4f18
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832458
Reviewed-by: Evan Stade <[email protected]>
Commit-Queue: Lijin Shen <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035648}
Unified side panel: schedule paint for combobox after selected index update.
Usually this is done by the combobox when Combobox::OnPerformAction is
called but since we delay combobox updates and also when updating the
combobox based on entries being registered/deregistered or changed on
tab change.
Bug: 1353375
Change-Id: I7f0b78c4ad99de389b5628375dd4e03b2315f552
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3828515
Reviewed-by: Emily Shack <[email protected]>
Commit-Queue: Caroline Rising <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035647}
shortcuts: Move __html_template__ placeholders to the end
- TypeScript errors are reported with a line offset compared to the src/ for Polymer files, due to html_to_js() being executed first (which pastes HTML content into the TS file). A simple way to address this, is to move _html_template_ placeholders to the bottom of each Polymer file
Bug: 242549183
Change-Id: I79cc3a1f61ab739197463f12be0269634d08a03f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3828212
Reviewed-by: Jimmy Gong <[email protected]>
Auto-Submit: Michael Checo <[email protected]>
Commit-Queue: Jimmy Gong <[email protected]>
Quick-Run: Michael Checo <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035646}
[anchor-position] Support conditions for the target anchor element
This patch supports conditions to determine the target anchor
element. From the spec[1]:
* if el has the same containing block as the querying element,
el is not positioned
* if el has a different containing block from the querying
element, the last containing block in el’s containing block
chain before reaching the querying element’s containing
block is not positioned
This patch contains a unit test for |NGAnchorQuery|. End-to-
end web tests that cover more cases will be in future patches.
[1] https://tabatkins.github.io/specs/css-anchor-position/#determining
Bug: 1309178
Change-Id: I7d87d7c60aa5a0577f405e2d9ce45e7d475d6d9a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832986
Commit-Queue: Koji Ishii <[email protected]>
Reviewed-by: Xiaocheng Hu <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035645}
Remove unused kAutoPositioned
Bug: None
Change-Id: I593246af72a5cb04edf9dc81253f0d2b4ec5d113
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832515
Commit-Queue: Mitsuru Oshima <[email protected]>
Reviewed-by: Ahmed Fakhry <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035644}
[fuchsia] Re-enable desktop capture tests
Desktop capture was enabled a while ago, so the tests now pass.
Bug: 1322341, 1271639
Change-Id: I56428b174aa088d0a826e500e970ce45ca753916
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3820624
Reviewed-by: Kevin Marshall <[email protected]>
Commit-Queue: Bryant Chandler <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035643}
Lock by app id and shared web contents during isolated web app installation.
Bug: 1333966
Change-Id: I548865b32b174edc95c4a34bbc4c0bee70244ae5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3826798
Auto-Submit: Dmitrii Kuragin <[email protected]>
Commit-Queue: Dmitrii Kuragin <[email protected]>
Reviewed-by: Daniel Murphy <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035642}
Revert "Hide tooltip when view becomes hidden"
This reverts commit b8c159f60c033f4bf8e09a88c48efd972de11705.
Reason for revert: Likely causing builder failure https://ci.chromium.org/ui/p/chromium/builders/ci/linux-chromeos-rel/58940/overview
Original change's description:
> Hide tooltip when view becomes hidden
>
> Bug: 926847
> Change-Id: I49ba5aa0d39b7b6ed343dcf73d45979b02cb73b9
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3828370
> Reviewed-by: Peter Kasting <[email protected]>
> Commit-Queue: Fr <[email protected]>
> Reviewed-by: Ahmed Fakhry <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1035574}
Bug: 926847
Change-Id: I1b7c573bf823d83e772f786b756c9e7e5a91a12e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Owners-Override: Emily Shack <[email protected]>
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3833525
Auto-Submit: Emily Shack <[email protected]>
Reviewed-by: Peter Kasting <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035641}
[Pixel Diff Ash] Stabilize the app list search box placeholder text
Before this CL, `SelectPlaceholderText()` in search_box_view.cc
chooses a placeholder text randomly.
With this CL, `SearchBoxView` provides a test API to use the fixed
placeholder text to avoid the flakiness in pixel tests.
Bug: 1353386
Change-Id: Id7683a3f279a4218443cfdbd5c76ca4e7546aabf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834185
Commit-Queue: Andrew Xu <[email protected]>
Reviewed-by: Xiyuan Xia <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035640}
SET,DL: Ensure content-visibility: auto is relevant when shared.
This patch updates the logic to make sure that content-visibility auto
elements are considered relevant to the user when either the descendant
of such a lock is a shared element, or the lock is a descendant of
a shared element itself.
[email protected]
Bug: 1351422
Change-Id: I51d87d5db83c09d00ff597608de3b35d6d01d894
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3827715
Reviewed-by: Khushal Sagar <[email protected]>
Commit-Queue: Vladimir Levin <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035639}
Remove deprecated base::Value APIs
[Code Health Rotation] Update AccessibilityTreeFormatter* to remove deprecated base::Value APIs.
Bug: 1351732
Change-Id: I3e657447c7141c5a63dda8110f0d80315cc441b8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3822806
Reviewed-by: Abigail Klein <[email protected]>
Commit-Queue: Iman Saboori <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035638}
Return early if RetargetForEvents is called with a null node on Android
Node should not be null. But this seems to be happening in the wild for
reasons not yet determined.
AX-Relnotes: Fixes crash on Android
Bug: 1350627
Change-Id: I225a90c56ad6bf8b9b65649ac7be7637d9ee52da
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3829519
Reviewed-by: Mark Schillaci <[email protected]>
Commit-Queue: Joanmarie Diggs <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035637}
[CompositeClipPathAnimations] Add repaint tests from composited bg color animations
Bug: 1223106
Change-Id: I13056f1eec8e0db47d047d878ae97027f0c91df0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3789841
Reviewed-by: Olga Gerchikov <[email protected]>
Reviewed-by: Robert Flack <[email protected]>
Commit-Queue: Claire Chambers <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035636}
[iOS] Change pipes to backticks in /ios/chrome/browser/discover_feed
Please review the CL to ensure that nothing is broken and the script
didn't miss some pipes.
This should allow us to have a better formatting in Xcode.
This CL was uploaded by git cl split.
[email protected]
Bug: 1311955
Change-Id: I2ee96f70303495869f8876fc686bd2253254694c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834544
Commit-Queue: Sergio Collazos <[email protected]>
Auto-Submit: Gauthier Ambard <[email protected]>
Reviewed-by: Sergio Collazos <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035635}
Create separate copies of PasswordForms instead of keeping raw pointers.
This CL avoids maintaining a set of raw pointers to PasswordForms and instead keeps separate copies. While this may be slightly less
performant, it reduces the risk of those pointers going stale during
future refactorings.
Bug: 1351969
Change-Id: Iabcde87cf022bcb61c2dfcd690e99cd108602571
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3826135
Reviewed-by: Vasilii Sukhanov <[email protected]>
Commit-Queue: Jan Keitel <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035634}
[fuchsia] Ignore binary-size growth if there is no uncompressed growth.
Check uncompressed growth and use this as a blocker for
whether the binary-size check fails. However, if growth exceeds 100KiB,
fail the tryjob regardless of uncompressed growth (this will be treated
as the threshold for 'unreasonable growth').
Additionally:
- replace `\n` usage in the summary string with `<br>`
- update `ChangePackageSize` helper method to have pytypes and to
optionally take the argument `uncompressed_increase`, allowing tests
to increase either the uncompressed or compressed size. Defaults to
given compressed size increase.
- Removes unused test helper method `ChangeBlobSize`
Change-Id: Ib7d02b6eb9ff8bbed970368fcfd7351878e3340f
Bug: 1302137
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3828644
Commit-Queue: Rohan Pavone <[email protected]>
Reviewed-by: Wez <[email protected]>
Reviewed-by: Fabrice de Gans <[email protected]>
Reviewed-by: Bryant Chandler <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035633}
Don't fire multiple kLoadComplete events
crrev.com/c/3750423 eliminated AXEventGenerator load start/complete
events in favor of the events we now reliably fire from Blink to
support bfcache and single-page app use cases. One of the things
removed in that change was the check that we didn't already fire
a load-complete.
RenderAccessibilityImpl::SendPendingAccessibilityEvents inserts
a load-complete event without checking that one is already present.
Perhaps it shouldn't. In the meantime, put the check back where it
was to fix the regression.
AX-Relnotes: Fix regression causing bubbles such as the "save password"
bubble from being spoken by VoiceOver.
Bug: 1352464
Change-Id: Iece59f336c29a37a25a35388fd2b3b5a67994532
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3826250
Commit-Queue: Joanmarie Diggs <[email protected]>
Reviewed-by: Daniel Libby <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035632}
[Clipboard API] Code format updates in clipboard files
This CL contains some nits and format updates in several clipboard
files. No new functionality is introduced.
Bug: 1268679
Change-Id: Idb986125d16871b90796333574740c84d369ad12
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3826504
Reviewed-by: Anupam Snigdha <[email protected]>
Reviewed-by: Austin Sullivan <[email protected]>
Commit-Queue: Ana Sollano Kim <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035631}
Align chip with the contents web view.
Bug: b:242723023
Change-Id: Ic718739550e53555f5b31464075165c45b715362
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834447
Reviewed-by: Ali Stanfield <[email protected]>
Commit-Queue: Juan Mojica <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035630}
Mark Maps_maps Failure on Fuchsia.
This test is failing ~4x/day which is causing FindIt to send reports
nearly daily. Since nobody has triaged this in ~8 months, suppress by
marking as Failure.
Bug: 1288217
No-Try: True
Change-Id: I13b0cdf6e61123cd7f2a38f6c38d5ee8baf8a509
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832539
Reviewed-by: Brian Sheedy <[email protected]>
Auto-Submit: Kenneth Russell <[email protected]>
Commit-Queue: Kenneth Russell <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035629}
[CodeHealth] Replace DictionaryValue::GetString in /chrome/browser/supervised_user.
This CL was uploaded by git cl split.
[email protected]
Bug: 1187036
Change-Id: Iec81042ba9c072067823adaf11502b04c3a5469d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3829162
Reviewed-by: Li Lin <[email protected]>
Auto-Submit: Brian Begnoche <[email protected]>
Commit-Queue: Li Lin <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035628}
Update list and dict Value usage in media_drm_origin_id_manager.cc.
Only Value::List and Value::Dict should be used to access and update
list and dict Values - other APIs are all deprecated.
Also, remove checks that DictionPrefUpdate returns a dictionary. This
is guaranteed by the API. It hits a NOTREACHED() if it hits a pref not
registered as a dictionary, and never returns null if the pref is
correctly registered as a dictionary. It may return null if the pref
isn't registered, in addition to hitting the NOTREACHED(), but seems
reasonable to crash in binaries that don't DCHECK when a NOTREACHED()
is hit.
Bug: 1187001, 1338341
Change-Id: Ie93e2c26ff0ba29228608458336b62cacf0060b7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3820426
Commit-Queue: Matt Menke <[email protected]>
Reviewed-by: John Rummell <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035627}
[chrome] Fix some cpplint errors in chrome part2
chrome/browser/app_controller_mac.h:27:
"chrome/browser/profiles/profile.h" already included at chrome/browser/app_controller_mac.h:10 [build/include] [4]
chrome/browser/accessibility/accessibility_labels_service_browsertest.cc:20:
"content/public/browser/browser_accessibility_state.h" already included at chrome/browser/accessibility/accessibility_labels_service_browsertest.cc:15 [build/include] [4]
chrome/browser/chrome_browser_interface_binders.cc:179:
"mojo/public/cpp/bindings/self_owned_receiver.h" already included at chrome/browser/chrome_browser_interface_binders.cc:86 [build/include] [4]
chrome/browser/chrome_content_browser_client_unittest.cc:93:
"base/test/scoped_feature_list.h" already included at chrome/browser/chrome_content_browser_client_unittest.cc:21 [build/include] [4]
Bug: None
Change-Id: Id4c46f32d1300b57fad569fb71d4586f32639fe5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3816164
Reviewed-by: Daniel Cheng <[email protected]>
Reviewed-by: Nico Weber <[email protected]>
Auto-Submit: Qi Tiezheng <[email protected]>
Commit-Queue: Nico Weber <[email protected]>
Reviewed-by: Katie Dektar <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035626}
Skip Pixel_WebGLContextRestored on ChromeOS AMD64 generic.
The test is taking 5 minutes to time out on this one configuration.
Skip it for the time being.
Bug: 1167246
Change-Id: I2b4fb0f11b6aad0ab4869e8852fffb86c5ca63b5
No-Try: True
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834683
Bot-Commit: Rubber Stamper <[email protected]>
Reviewed-by: Brian Sheedy <[email protected]>
Commit-Queue: Kenneth Russell <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035625}
Refactor browser/speech to use PrefService::GetValueDict
This is part of a larger migration effort based on
go/trust-your-prefs.
Bug: 1341996
Test: Existing unit tests
Change-Id: I28b3421f0828075a6f28ab57fb467249973576d4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3830019
Reviewed-by: Katie Dektar <[email protected]>
Commit-Queue: Roland Bock <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035624}
[iOS] Fix MobileMenuFollow/Unfollow
Change-Id: I62039f97198ff8344e9db60556e3e63848595e79
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834182
Reviewed-by: Sergio Collazos <[email protected]>
Auto-Submit: Adam Arcaro <[email protected]>
Commit-Queue: Sergio Collazos <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035623}
[iOS] Change pipes to backticks in /ios/chrome/browser/commerce
Please review the CL to ensure that nothing is broken and the script
didn't miss some pipes.
This should allow us to have a better formatting in Xcode.
This CL was uploaded by git cl split.
[email protected]
Bug: 1311955
Change-Id: I49e2718f0ce9bc48f9f361a439ef7ec2a5d8f98b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834309
Commit-Queue: Wei-Yin Chen <[email protected]>
Auto-Submit: Gauthier Ambard <[email protected]>
Reviewed-by: Wei-Yin Chen <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035622}
Updater: remove updater dir from 3pp install scripts, update minversion.
The new updater.zip doesn't have that dir.
Also update the minimum version so that we pull in the most recent
builds into CIPD, so that we can re-enable some tests.
Bug: 1349841
Change-Id: I060d61b91479fb67f1e893c88ea143d8628dfea9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3810532
Commit-Queue: Sorin Jianu <[email protected]>
Auto-Submit: Joshua Pawlicki <[email protected]>
Reviewed-by: Sorin Jianu <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035621}
fieldtrial_testing_config: Enable MojoAvoidRandomPipeId experiment
Enable "MojoAvoidRandomPipeId" base::Feature in
fieldtrial_testing_config.json to start experimenting in chromeperf. The
plan is to extend it to a field trial if the results of this change are
non-negative.
Bug: 1351813
Change-Id: Ie51ce504f6236f24d024f39fd9ee7fc311829a30
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832381
Reviewed-by: Benoit Lize <[email protected]>
Commit-Queue: Egor Pasko <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035620}
Revert "[Floss] Improve error message in ExportedCallbackManager"
This reverts commit 7d3e6ef9cfe3ed052413d3ed24cc4553fe601002.
Reason for revert: breaks since depends on https://crrev.com/c/3833334
Original change's description:
> [Floss] Improve error message in ExportedCallbackManager
>
> This adds more precise error message when failed to parse D-Bus
> parameters.
>
> Bug: b:233124021
>
> Change-Id: I6a4d0a35c744d159c769e511b3b530b0ff9b4ce7
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3828172
> Reviewed-by: Abhishek Pandit-Subedi <[email protected]>
> Commit-Queue: Sonny Sasaka <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1035592}
Bug: b:233124021
Change-Id: I7c05887dbb2eb86dfa7059580d817268591ac99b
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834584
Bot-Commit: Rubber Stamper <[email protected]>
Commit-Queue: Aishwarya Rajesh <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035619}
Update perf-timing info for removed blink_perf.paint tests.
The following tests were removed:
- perf_tests/paint/complex-iframe-filtered.html
- perf_tests/paint/move-text-with-mask.html
Update the timing files to take this into account.
Change-Id: Idcfea36929fe442aa36e572868f6ae395d180c69
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832957
Commit-Queue: Rohan Pavone <[email protected]>
Reviewed-by: John Chen <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035618}
[ntp] Add metrics to track promo dismissals.
Add metrics that track when promos are dismissed and when promos are resurfaced after dimissal.
Change-Id: Ia0719a5486091922b9653a1614f83ffffd8cdf8b
Bug: 1003508
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3825985
Reviewed-by: Tibor Goldschwendt <[email protected]>
Commit-Queue: Paul Adedeji <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035617}
Remove AndroidPushNotificationManager
AndroidPushNotificationManager is unused and is replaced with PushNotificationManager
Fixed: 1350174
Change-Id: I1a2d31ed69e27e2b472a5f43d2fb8b5e8ed4eb35
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3828132
Commit-Queue: Raj T <[email protected]>
Reviewed-by: Sophie Chang <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035616}
Disable BaseAllocatorDispatcherTest for Apple OSs
When running on any of Apple's OSs and PartitionAlloc not being the
default allocator, the test
BaseAllocatorDispatcherTest.VerifyNotificationUsingAllocatorShim
terminates unexpectedly. This happens because in this case
AllocatorShim invokes MallocImpl, which then terminates the process
due to malloc zones not being setup properly.
Hence, disabling the test for AppleOSs when building with
use_allocator = "none".
Bug: 1351658
Cq-Include-Trybots: luci.chromium.try:mac12-tests
Change-Id: I25fa1d1bd9917640e4b0f3abe22fa2e7f4baec65
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3822592
Commit-Queue: Richard Townsend <[email protected]>
Reviewed-by: Benoit Lize <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035615}
[Passwords Import] Remove error handling from CSVPassword
Removed error handling from CSVPassword, so now
CSVPasswordIterator only skips empty lines and error handling
can be done by CSVSequence users.
Bug: 1325290
Change-Id: Ia3dbc7621de7250c12a0ce4f3bc863e373233b9f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832232
Auto-Submit: Andrii Natiahlyi <[email protected]>
Commit-Queue: Andrii Natiahlyi <[email protected]>
Reviewed-by: Vasilii Sukhanov <[email protected]>
Commit-Queue: Vasilii Sukhanov <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035614}
Roll ANGLE from 0f5770deabf2 to 6ee6fac97f2a (4 revisions)
https://chromium.googlesource.com/angle/angle.git/+log/0f5770deabf2..6ee6fac97f2a
2022-08-16 [email protected] Roll SwiftShader from a6c3e363b7a9 to c61fc9aec162 (1 revision)
2022-08-16 [email protected] Refactor to reduce main loop complexity.
2022-08-16 [email protected] Unconditionally enable EGL_ANGLE_iosurface_client_buffer on macOS
2022-08-16 [email protected] Reland "Infra: Enable Skia Gold tests on Pixel 6"
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86
Bug: chromium:1352481
Tbr: [email protected]
Change-Id: Ie6bb106b8c9b2455338a595210da65e1b0b4aeee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834464
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035613}
Cache ThreadedPreloadScanner param for performance
This was causing regressions in some parser micro benchmarks.
Bug: 1349265
Change-Id: I538732a47cde5c3832a3c41767ba9c2bb50ca9a3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832974
Commit-Queue: Mason Freed <[email protected]>
Reviewed-by: Mason Freed <[email protected]>
Auto-Submit: Clark DuVall <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035612}
[Autofill] Move webauthn::InternalAuthenticator to CreditCardFIDOAuthenticator.
This CL moves webauthn::InternalAuthenticator from ContentAutofillDriver
to CreditCardFIDOAuthenticator. It used to be in ContentAutofillDriver
in order to access its RenderFrameHost. This CL eliminates the need to
obtain the RenderFrameHost at this point by passing an AutofillDriver to
AutofillClient::CreateCreditCardInternalAuthenticator() instead, where
we can (safely) cast the AutofillDriver to a ContentAutfillDriver and
then access its RenderFrameHost.
While this comes at the expense of this cast, it saves some preprocessor
directives and simplifies the architecture.
Bug: 1352283
Change-Id: I04a9129a107ab8161c257ac67e0a7d9bd3e15404
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3828364
Commit-Queue: Christoph Schwering <[email protected]>
Reviewed-by: Mohamed Amir Yosef <[email protected]>
Reviewed-by: Jared Saul <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035611}
glanceables: Add initial skeleton in ash
* Add a base::Feature "Glanceables".
* Create a GlanceablesController owned by ash::Shell when the feature
is enabled.
* Add a GlanceablesContainer aura::Window container when the feature
is enabled.
* After login, construct a fullscreen Widget and View for the
glanceables content.
See bug for link to design sketch.
Bug: 1353119
Test: added to ash_unittests
Change-Id: I04a68cd784b187a28d1521041a55695cc88766d4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3828510
Reviewed-by: Matthew Mourgos <[email protected]>
Commit-Queue: James Cook <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035610}
Move model provider factory to embedder to share with iOS
The model provider factory has code that is common for iOS and other
platforms. This object depends on optimization_guide and cannot be
inside the platform internals code. So, move it to embedder dir where
this code can be shared.
Ensure the default models are passed the same way in chrome and ios.
BUG=1346389
Change-Id: I3d12297f92b09635c2c7166fad9e05a9fcd5d5aa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3830821
Commit-Queue: Siddhartha S <[email protected]>
Reviewed-by: Min Qin <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035609}
Refactor DeskModel::GetAllEntries to a synchronous method
Bug: b/242350776
Change-Id: I227e920d1b194f513dadc231b2b650863cfe784f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3826450
Reviewed-by: Avynn Donaghe <[email protected]>
Reviewed-by: Daniel Andersson <[email protected]>
Commit-Queue: Yanzhu Du <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035608}
Implement CUD fallback experiment
Bug: b:241787710
Change-Id: Id266270637fedd5373f52badab157dba75630211
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3823064
Commit-Queue: Özgen Eren <[email protected]>
Reviewed-by: Luca Hunkeler <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035607}
[Anonymous Iframe] Stop browser initiated autofill.
This is a follow-up cl for unbinding password autofill for anonymous iframe.
We stop browser initiated password autofill here.
Bug: 1338404
Change-Id: I2455d9e0fdfa39f4c43287e5734707e440efd797
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3776719
Reviewed-by: Yifan Luo <[email protected]>
Auto-Submit: Yifan Luo <[email protected]>
Reviewed-by: Vasilii Sukhanov <[email protected]>
Commit-Queue: Yifan Luo <[email protected]>
Reviewed-by: Arthur Sonzogni <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035606}
FLEDGE: Make InterestGroupAuction::Bid not outlive the auction.
The dangling pointer detector doesn't like that the shared Mojo
interface pointer owns the Bid, which has raw_ptrs to objects the
InterestGroupAuction owns.
When an auction is cancelled, the objects being pointed at by Bids are
deleted, but since the Mojo pipe is shared, the Bid may live on as an
object owned by a bound callback owned by the shared Mojo remote. This
is safe, since the callback owns a weak pointer to the auction, which
is safely null checked by the callback infrastructure, but it can set
off the dangling pointer detection logic.
To solve this problem, introduce a per-ScoreAd() call ScoreAdClient
object which handles the callback. The Auction owns the
base::ReceiverSet that owns both the Mojo ScoreAdClient pipes and the
Bids that ScoreAd() is current scoring, so destroying Auction now also
destroys the Bid with pointers to some of its objects.
Another option would be to Clone() the SellerWorklet pipe, but it
looks like we're going to use the Client approach for the
analogous BidderWorklet::GenerateBid() method, so it can have an
extra phase with received data from the bidder, so adding a
new interface for the callback seems more consistent.
Also be sure to delete losing Bids when the ScoreAd() call completes,
before continuing the auction, since the auction may then synchronously
complete and be destroyed, which potentially leaves the Bid in a
stack variable owned by a function call further up the call stack.
Bug: 1352527
Change-Id: Iced2d8d817b3694f5677943d593f381458af0ac0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3829655
Reviewed-by: Daniel Cheng <[email protected]>
Reviewed-by: Maks Orlovich <[email protected]>
Commit-Queue: Matt Menke <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035605}
Update V8 to version 10.6.179.1 (cherry-pick).
Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/9b476953..562b2178
Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues
Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_chromeos_msan_rel_ng
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel
[email protected],[email protected],[email protected]
Change-Id: I4b8112d3727567c4ddd8ab49f5fc8900fb3e8dda
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834502
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1035604}
Simplify SpellChecker::MarkAndReplaceFor()
This patch simplifies the function by:
1. Removed everything related to the "ambiguous word boundary" handling
because HotModeSpellCheckRequester already takes care of it. This is
verified by the new test.
2. Removed the TextCheckingParagraph class completely because it's
just doing trivial work -- it's always constructed with the same
`checking_range` and `paragraph_range` parameters, then it always
have:
- CheckingStart() = 0
- CheckingEnd() = CheckingLength()
= TextIterator::RangeLength(checking_range)
So this patch removes the class and performs range checking with
`checking_range` directly.
This patch is also preparation for stopping MarkAndReplaceFor() from
removing and then readding the same markers.
Bug: 1000616
Change-Id: I8bfa6c23486df10a0d40a0bee0c6d59bb47278b3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3830306
Reviewed-by: Mike West <[email protected]>
Commit-Queue: Xiaocheng Hu <[email protected]>
Reviewed-by: Yoshifumi Inoue <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035603}
Using weak_ptr in WellKnownChangePasswordNavigationThrottle
Bug: 1352445
Change-Id: I93c912b82bd0d8b813f793db4a9e57f7be8cf76f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832390
Reviewed-by: Vasilii Sukhanov <[email protected]>
Commit-Queue: Vasilii Sukhanov <[email protected]>
Commit-Queue: Viktor Semeniuk <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035602}
Roll Help App from idmOLokpR8pqEKF3B... to xyX-aFWvcF7WKFzTF...
Release_Notes: http://go/help_app-x20/relnotes/Main/help_app_nightly_202208160800_RC00.html
https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/help_app/app/+/xyX-aFWvcF7WKFzTFRsyzI7sSc8QFNJZN_gy5TwPiUUC
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/help-app-chromium-autoroll
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: b/242477702
Tbr: [email protected]
Change-Id: I268c44313f1e9b01ed079891c7a91be1f123ac19
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832718
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1035601}
Enable Kerberos authentication on Lacros
Enable Kerberos authentication on Lacros browser, by setting the
necessary environment variables. These variables are used by the GSSAPI
library (third_party). They contain the paths to credential cache and
configuration files.
The Lacros process requires specific code to set these variables
because the DIR_HOME path wasn't yet overridden, as in ash-chrome.
Additionally, the browser process is usually not running when
KerberosFilesHandler sends the environment values to the network
service.
Bug: 1321568
Change-Id: I2194318e66f233ae8f10144ed2f3c0c946a7654f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3829527
Reviewed-by: Maks Orlovich <[email protected]>
Reviewed-by: Yaron Friedman <[email protected]>
Reviewed-by: Maksim Ivanov <[email protected]>
Commit-Queue: Felipe Andrade <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035600}
Split some structs out of permissions_policy.h.
This allows them to be fully defined before they're referenced, which
fixes some C++20 compile errors in mojo headers.
This also obviates the need for permissions_policy_forward.h.
Bug: 1284275
Change-Id: Ide0f25826a21b685209cab4d0aa69ed512820494
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3831236
Reviewed-by: Dave Tapuska <[email protected]>
Commit-Queue: Peter Kasting <[email protected]>
Reviewed-by: Ian Clelland <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035599}
Add validation for manifest id during isolated app installation.
For isolated web apps, the manifest id must always be "/" in order to guarantee isolation.
Bug: 1333966
Change-Id: Iff0632be458a981220eae28e768f29157ec7301a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3826799
Auto-Submit: Dmitrii Kuragin <[email protected]>
Reviewed-by: Robbie McElrath <[email protected]>
Reviewed-by: Daniel Murphy <[email protected]>
Commit-Queue: Dmitrii Kuragin <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035598}
[iOS] Add Incognito mode availability-related testing to Incognito interstitial
`PrivacyTableViewControllerTest` is updated:
- The pref service is not "customized" anymore, as it seems not to be a
necessity any longer. This is useful to enable setting managed prefs
such as `kIncognitoModeAvailability`.
- The test config is updated into a struct so as to make it possible to
configure the Incognito availability mode. Further config values are
added to the associated parameterized test suite.
`IncognitoInterstitialTestCase` is updated with two new tests to ensure
Incognito mode being forced or blocked prevents the Interstitial from
being shown. A new utility class `ScopedPolicyList` is added to allow
simple unwinding of custom policy values when its instance goes out of
scope.
Bug: 1318750
Change-Id: I0c4827031d5cd7af08d27451a33d205bf5aa1504
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3827436
Commit-Queue: Quentin Pubert <[email protected]>
Reviewed-by: Mark Cogan <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035597}
Roll Media App from lnTOZ6SVH7iYQ0TTT... to h7OE9fCrkNVorXo4t...
Release_Notes: http://go/media_app-x20/relnotes/Main/media_app_202208160800_RC00.html
https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/h7OE9fCrkNVorXo4tNlLAGOTvZor7e8nExX6Eoa-M2MC
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chrome.try:linux-chromeos-chrome
Bug: b/242475365
Tbr: [email protected]
Change-Id: I8d459ac6c1f0a0ba6a3b98aa691dbb6c248256ae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834266
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1035596}
Move remaining MainThread associated methods to MainThreadScheduler.
All the main thread bound methods are now inside the MainThreadScheduler
class.
BUG=1105403
Change-Id: I5e4990b09ba01ad57e2e32ab8d266c0669e153d2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3828887
Commit-Queue: Dave Tapuska <[email protected]>
Reviewed-by: Kent Tamura <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035595}
Make types on both sides of comparison operators match exactly.
This fixes errors in C++20 with operator==() reordering.
Bug: 1284275
Change-Id: Id756aa04131803c0d1a67c1bc9923f4ed26cab38
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3829084
Auto-Submit: Peter Kasting <[email protected]>
Reviewed-by: Eric Orth <[email protected]>
Commit-Queue: Peter Kasting <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035594}
[chrome] Fix some cpplint errors in chrome part9
chrome/browser/extensions/api/management/chrome_management_api_delegate.cc:75:
"chrome/browser/web_applications/web_app_utils.h" already included at chrome/browser/extensions/api/management/chrome_management_api_delegate.cc:45 [build/include] [4]
chrome/browser/extensions/api/management/management_api_unittest.cc:50:
"extensions/browser/api/management/management_api_constants.h" already included at chrome/browser/extensions/api/management/management_api_unittest.cc:23 [build/include] [4]
chrome/browser/extensions/api/management/management_api_unittest.cc:51:
"extensions/common/error_utils.h" already included at chrome/browser/extensions/api/management/management_api_unittest.cc:33 [build/include] [4]
chrome/browser/extensions/api/safe_browsing_private/safe_browsing_private_event_router.cc:61:
"chrome/browser/policy/chrome_browser_policy_connector.h" already included at chrome/browser/extensions/api/safe_browsing_private/safe_browsing_private_event_router.cc:26 [build/include] [4]
chrome/browser/feedback/show_feedback_page.cc:30:
"base/strings/escape.h" already included at chrome/browser/feedback/show_feedback_page.cc:9 [build/include] [4]
chrome/browser/feedback/system_logs/log_sources/chrome_internal_log_source.cc:44:
"base/strings/stringprintf.h" already included at chrome/browser/feedback/system_logs/log_sources/chrome_internal_log_source.cc:18 [build/include] [4]
chrome/browser/feedback/system_logs/log_sources/crash_ids_source.cc:21:
"content/public/browser/browser_thread.h" already included at chrome/browser/feedback/system_logs/log_sources/crash_ids_source.cc:15 [build/include] [4]
Bug: None
Change-Id: I7b17cc8fd25c142378f87dc3ede16dc1e04634f1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3826705
Reviewed-by: Daniel Rubery <[email protected]>
Commit-Queue: David Bertoni <[email protected]>
Reviewed-by: Xiangdong Kong <[email protected]>
Auto-Submit: Qi Tiezheng <[email protected]>
Reviewed-by: David Bertoni <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035593}
[Floss] Improve error message in ExportedCallbackManager
This adds more precise error message when failed to parse D-Bus
parameters.
Bug: b:233124021
Change-Id: I6a4d0a35c744d159c769e511b3b530b0ff9b4ce7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3828172
Reviewed-by: Abhishek Pandit-Subedi <[email protected]>
Commit-Queue: Sonny Sasaka <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035592}
[libc++] Enable assertions on all builds and add a handler for release builds
Enabling assertions improves security in libc++ by guarding against
undefined behaviors (e.g. accessing an element out of bounds in
std::vector).
For release builds, this patch implements a libc++ assertion handler
using libc++'s assertion mechanism introduced in
https://reviews.llvm.org/D12147. The intent of this implementation is to
closely match what absl does[0]. For non-debug builds, absl just
aborts[1], so we call IMMEDIATR_CRASH(...) in the nondebug libc++
assertion handler.
For debug builds, we just use the default libc++ assertion handler. Absl
calls assert(false && expr) in debug builds [2], which has the net
effect of printing the failed assertion to stderr and aborting. The
default libc++ assertion handler does this as well [3], so we'll just
use that instead of implementing a Chromium-specific libc++ debug
assertion handler.
The assertion handler is implemented in //base as it depends on
base/immediate_crash.h.
[0]: https://crsrc.org/c/third_party/abseil-cpp/absl/base/macros.h;l=129-135;drc=eb8f0c03122e5cef55d62a1d59c7f36496c07d0a
[1]: https://crsrc.org/c/third_party/abseil-cpp/absl/base/macros.h;l=106-116;drc=eb8f0c03122e5cef55d62a1d59c7f36496c07d0a
[2]: https://crsrc.org/c/third_party/abseil-cpp/absl/base/macros.h;l=97-99;drc=eb8f0c03122e5cef55d62a1d59c7f36496c07d0a
[3]: https://github.com/llvm/llvm-project/blob/d434e40f398e3144c69d57d2a142d35e2f760a8e/libcxx/src/verbose_abort.cpp#L32
Binary-Size: Size increase due to added assertion checks in libc++
Bug: 1335422
Change-Id: I34f5a8995f64286d4b4f367d04a0df0302d88cf3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3805403
Commit-Queue: Alan Zhao <[email protected]>
Reviewed-by: Andrew Grieve <[email protected]>
Reviewed-by: Nico Weber <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035591}
[Telemetry] Remove RenamedFrom tag in probe_service.mojom
Those tags were added to pass presubmit checks. Now they are not needed.
This is part of Making Telemetry Extensions work in LaCrOS:
go/dd-telemetry-extensions-lacros.
This CL is part of crrev.com/c/3613280 split which is very big to
submit.
Bug: b:219514064
Test: ash_webui_unittests --gtest_filter="*DiagnosticsService*"
Test: browser_tests --gtest_filter="*TelemetryExtension*"
Test: unit_tests --gtest_filter="*ProbeService*"
Change-Id: Ie29072bce037a7d7d9a17b76ee00dea71cf56efe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3747941
Reviewed-by: Ken Rockot <[email protected]>
Reviewed-by: Tom Sepez <[email protected]>
Commit-Queue: Oleh Lamzin <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035590}
Remove irrelevant source/trigger fields from attribution WPT
Change-Id: I896d09d48d702f308335a8f1d99cc79b0f9bc9d6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3829279
Quick-Run: Andrew Paseltiner <[email protected]>
Reviewed-by: Nan Lin <[email protected]>
Commit-Queue: Andrew Paseltiner <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035589}
[Read Anything] A few small code cleanups.
1. Include <string>.
2. Remove redundant Browser function argument as this is available via
a get method.
3. Remove unused imports of weak_ptr.
These cleanups arose while working on crrev.com/c/3820321 but I chose
to put them in a separate CL.
Bug: 1266555
Change-Id: I2d868df8afcc259083ec75d10b2b1e74799c9d76
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3831932
Reviewed-by: Mark Schillaci <[email protected]>
Commit-Queue: Abigail Klein <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035588}
Remove an unused variable.
In C++20, this caused a warning because the compiler was smarter about
realizing it was unused.
Bug: 1284275
Change-Id: Ic10f08d5688af434f78785e1ba527ec2db7e7ab1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3827138
Reviewed-by: Wei-Yin Chen <[email protected]>
Commit-Queue: Peter Kasting <[email protected]>
Auto-Submit: Peter Kasting <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035587}
Roll Manifest Merger from 0WkAedh1tJB8lzisW... to CvokX4c6dx7DwQ8VV...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/manifest-merger-chromium
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:android-internal-rel
Tbr: [email protected]
Change-Id: I349d4e767ee642e5e5d3216b778940b7ec9d216a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834263
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035586}
Roll RTS model from EdjH-IqvBY46yCmx-... to kvnnJX6BYmOihN9rx...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/rts-windows-amd64-chromium-autoroll
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: [email protected]
Change-Id: I6cad04351f01fad250533a4b88dfdb7d556d333c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832693
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035585}
Dynamically enable GSSAPI loading in Lacros
In Lacros browser, the GSSAPI should be loaded similarly as in Ash
browser. This CL extends all code related to GSSAPI dynamic loading
to CHROMEOS_LACROS builds as well. We still only check if the device
is AD managed on CHROMEOS_ASH builds, because we don't plan to support
Chromad in Lacros.
This API is only needed on Lacros for Kerberos authentication, so it's
only enabled when the Kerberos feature is enabled by policy.
Bug: 1321568
Change-Id: I517251425d4b6ab0ffc4328d64597793862584a1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3810331
Reviewed-by: Maks Orlovich <[email protected]>
Reviewed-by: Maksim Ivanov <[email protected]>
Commit-Queue: Felipe Andrade <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035584}
iOS Settings: Add Settings submenu option
This change adds a settingsButtonInToolbar property, analogous to the
existing addButtonInToolbar functionality. This is needed because
upcoming changes to the Password Manager screen will replace the "Add"
button with a "Settings" button.
Bug: 1335156
Change-Id: Ida9711dbae3fa34a7f0933dfa7fb765f5d7a0a51
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3823729
Reviewed-by: Sergio Collazos <[email protected]>
Commit-Queue: Tommy Martino <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035583}
[PMIntegrationTests] Fix and enable PasswordGenerationIntegrationTest
The tests were disabled long ago because it was failing on bots.
The mistake in testManualGenerationUsePassword and
testAutomaticGenerationUsePassword was that the tests were not waiting
for the success page to load before checking if the message about the
password being saved showed up.
TestManualGenerationUsePassword is still flaky so it's still disabled.
Bug: 1329840
Change-Id: I3843f8b45c7b195466000672095539012fee1c95
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3791345
Reviewed-by: Friedrich Horschig <[email protected]>
Commit-Queue: Ivana Žužić <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035582}
Roll src-internal from 4673f17429b7 to 02a7f1d33d15 (1 revision)
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4673f17429b7..02a7f1d33d15
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: [email protected],[email protected]
Change-Id: I4846f34ed80f14c6b580fddd1f0a2f4533cac893
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3833988
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1035581}
Roll DevTools Frontend from 8320c7d9e53e to ac83fd0b0031 (5 revisions)
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/8320c7d9e53e..ac83fd0b0031
2022-08-16 [email protected] [LMI] Show full name path when inspecting via context menu
2022-08-16 [email protected] Add menu item to toggle hiding ignore-listed sources
2022-08-16 [email protected] docs/workflows.md: miscellaneous documentation tweaks
2022-08-16 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS (trusted-origins)
2022-08-16 [email protected] Deflake click-handler by waiting for a DOM-connected element
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: chromium:1336568,chromium:1336604
Tbr: [email protected]
Change-Id: Ic7a60262145bb5c7933368b51f5530c8b41f65f0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832692
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035580}
Roll Skia from f86f24288669 to a77024ee45e9 (6 revisions)
https://skia.googlesource.com/skia.git/+log/f86f24288669..a77024ee45e9
2022-08-16 [email protected] [graphite] Make some SkShaderCodeDictionary functions const and non-metal
2022-08-16 [email protected] Fix queue transfer in VkHardwareBufferTest.
2022-08-16 [email protected] [ganesh] Buffer to buffer transfer ops block reordering
2022-08-16 [email protected] Implement OpenType 1.9.1 revised (Var)Sweep implementation
2022-08-16 [email protected] [canvaskit] Push 0.36.0
2022-08-16 [email protected] Introduce SkStrikePromise.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Cq-Do-Not-Cancel-Tryjobs: true
Bug: None
Tbr: [email protected]
Change-Id: I0d2a836ccee963bef53e1e0fbacca384d520ba69
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834342
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035579}
[blinkpy] Eliminate redundant `lint_test_expectations.py` checks
Currently, the linter is slow and noisy because of two sources of
redundant checks:
* Expectation files are parsed with the main desktop ports (Win, Mac,
Linux), but these ports do not actually do anything platform-specific.
The linter analyzes the original lines of the same set of expectation
files, so only using the current port will suffice.
* All expectations are parsed multiple times when checking for `Slow`
and `Timeout` tests. In this change, the linter parses and retains all
expectations up front. The linter delays logging until after all
checks have run and removes duplicate messages.
Bug: 1267101
Change-Id: Ia74b9ef7fc6beee7f9b4307b0b2ad6d40d604741
Test: Duplicate 'harness-tests/crash.html' line in 'TestExpectations'.
Test: `./lint_test_expectations.py` should only show one message.
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832494
Reviewed-by: Xianzhu Wang <[email protected]>
Reviewed-by: Weizhong Xia <[email protected]>
Commit-Queue: Jonathan Lee <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035578}
Extend DLP events to support files
Bug: 1352387
Change-Id: I0a7362a32ed7f460dc802f74bc5bd1f3a722ef7d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834108
Commit-Queue: Luca Accorsi <[email protected]>
Reviewed-by: Aya Elsayed <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035577}
Add bootstrap_env property following crrev/c/3827076
Bug: b/242040392
Change-Id: I13676d77d11f87b3002a4086f202887a8819b8c0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3831243
Reviewed-by: Garrett Beaty <[email protected]>
Commit-Queue: Ramy Medhat <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035576}
[CrOS Hotspot] Introduce hotspot mojom and HotspotStateHandler class
This CL introduces the new cros_hotspot_config.mojom which provides
mojo enum for hotspot tethering. A following CL will add interfaces that
allow configuration and setup of tethering hotspots.
This CL also introduce a HotspotStateHandler class which caches hotspot
related status, e.g: state and active client count, and implements
methods to get the current state, active client count. A followup CL
will add the implementation to get capabilities, configurations and
configure hotspot.
Bug: b/239477916
Change-Id: If777d633336305a8a42dac941127a7f0c0116cc3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3824937
Reviewed-by: Kyle Horimoto <[email protected]>
Commit-Queue: Jason Zhang <[email protected]>
Reviewed-by: Tom Sepez <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035575}
Hide tooltip when view becomes hidden
Bug: 926847
Change-Id: I49ba5aa0d39b7b6ed343dcf73d45979b02cb73b9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3828370
Reviewed-by: Peter Kasting <[email protected]>
Commit-Queue: Fr <[email protected]>
Reviewed-by: Ahmed Fakhry <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035574}
Fix unexpanded jinja template for VR module manifest
The manifest file is a template and must be preprocessed before use.
Use the pre-existing android_manifest_dep feature to do so.
Change-Id: Ic77ece5508f5ab261823021cfb80221a03c80414
Fixed: 1319977
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3828489
Reviewed-by: Andrew Grieve <[email protected]>
Commit-Queue: Klaus Weidner <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035573}
[ZPS] Improve Documentation for prefetching requirements and eligibility
Adds documentation to AutocompleteProvider::StartPrefetch() on the
requirements for providers that support prefetching requests.
Adds a new AutocompleteProvider::SupportsPrefetch() function which is
checked before StartPrefetch() is called. This new function can be used
for recording metrics at the AutocompleteController level and ensuring
StartPrefetch() is called for supported providers and contexts.
For instance, in the future, prefetching can cast a wider net by
calling AutocompleteController::StartPrefetch() on every page load
and specific providers can determine whether or not they support
prefetching for that context, depending on feasibility/cost/impact.
Bug: 1262373
Change-Id: I857e01a7409f60574f9d8c16402ab42355c75b52
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3828141
Reviewed-by: Justin Donnelly <[email protected]>
Commit-Queue: Moe Ahmadi <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035572}
[linux/wayland] Added support for xdg-activation.
This CL introduces the support for window activation by means of the
XDG activation Wayland protocol extension.
Bug: 1175327
Change-Id: Ib64ffda07862c5169caa2d4305965c293edce886
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2965925
Reviewed-by: Maksim Sisov <[email protected]>
Reviewed-by: Mitsuru Oshima <[email protected]>
Commit-Queue: Alexander Dunaev <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035571}
ATOMIC_FLAG_INIT is deprecated in C++20.
Bug: 1284275
Change-Id: I79dd06bc3326437cf45b3993a2c809340458cab4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3830251
Commit-Queue: Benoit Lize <[email protected]>
Auto-Submit: Peter Kasting <[email protected]>
Reviewed-by: Benoit Lize <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035570}
Dictation: Add commands test in Japanese
AX-Relnotes: N/A
Bug: 1353368
Change-Id: I9a6c7ff7db80a311c8d0129247db0915805edbbf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832640
Reviewed-by: Katie Dektar <[email protected]>
Commit-Queue: Akihiro Ota <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035569}
[omaha] Make min SDK version check dynamic.
Up until now, the minimum OS version check for Android has been
hard coded, which meant that a client side change was necessary for
being able to give users running an old version of their OS that support
was deprecated.
This CL keeps a default value that needs to be updated over time, but
also adds support for reading this from a server configuration when
necessary.
Bug: 1339501
Change-Id: I74e1344afbad4f107d8ddb06ad53701a40725886
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832512
Commit-Queue: Tommy Nyquist <[email protected]>
Reviewed-by: Joshua Pawlicki <[email protected]>
Reviewed-by: Elly Fong-Jones <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035568}
Update Value::List erase calls in hash_password_manager.cc.
In a previous CL, I updated the class to mostly use Value::List APIs
in place of deprecated equivalent methods on Value itself, but I missed
the erase calls.
Bug: 1338341
Change-Id: Ia7771541390a7e9344df245be28509fc15b702bf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3831304
Commit-Queue: Matt Menke <[email protected]>
Reviewed-by: Maxim Kolosovskiy <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035567}
Remove GPU cmd arg copies
It turns out that a number of GPU tests store their own copies of
parsed command line arguments even though the base class already has
a copy. This CL removes those redundant copies and instead uses the
copy provided by the base class.
Change-Id: I7b72ca790f1a0daae811ae2845ab6462b3689e2c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3826322
Auto-Submit: Brian Sheedy <[email protected]>
Reviewed-by: Yuly Novikov <[email protected]>
Commit-Queue: Brian Sheedy <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035566}
Request personalized feed for signed-in but non-syncing users
The "SyncAndroidPromosWithTitle" flag makes the sync promo _description_
text read "Sync to get the most relevant content from Google" rather
than "To get personalized content suggested by Google, turn on sync".
Signed-in users who have not enabled sync are able to get some amount
of personalization, but the sync promo text should reflect that if we
are to request a personalized feed for those users. Therefore we will
only request a personalized feed if those two flags are enabled, along
with a new feature flag that specifically controls the change in
consent level.
NtpFeedContentFetcher is only used for the desktop following feed
prototype new tab page module which is not enabled by default.
Bug: 1205923, b/188188861
Change-Id: Icb48280da4943edde526c1f0e1485eaffc63910a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3806149
Reviewed-by: Alex Ilin <[email protected]>
Commit-Queue: Ian Wells <[email protected]>
Reviewed-by: Victor Vianna <[email protected]>
Reviewed-by: Justin DeWitt <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035565}
Reset app list drag an drop proxy when resetting shelf
Fixes a UAF during display removal where app list tries to update
application drag and drop proxy (whose lifetime is bound to shelf
widget) after the removed display shelf is destroyed.
BUG=1350609
Change-Id: I7fd6a68da051a133bc67512df5e4d1d1653f726c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832395
Commit-Queue: Toni Barzic <[email protected]>
Reviewed-by: Xiyuan Xia <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035564}
[Lacros] Reset observation in VpnExtensionTrackerLacros when ExtensionRegistry shuts down.
Bug: 1352837
Change-Id: Id782673346207ca3f40a9201de4f8f3cb2208dbb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832380
Auto-Submit: Andrew Rayskiy <[email protected]>
Reviewed-by: Erik Chen <[email protected]>
Commit-Queue: Andrew Rayskiy <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035563}
FLEDGE: Corrected param comments ordering.
Correct the order of parameter comments to match with the signature.
Change-Id: Ibc4eed8d46463c30b4e3d417dc62e1c24e692021
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832641
Commit-Queue: Xiaochen Zhou <[email protected]>
Commit-Queue: Matt Menke <[email protected]>
Reviewed-by: Matt Menke <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035562}
[stts/android] Adjust background and alignment
Before/after screenshots per user state.
No target device state (kSendTabToSelfSigninPromo off):
https://screenshot.googleplex.com/BJ6tn5iNy65kDjq
https://screenshot.googleplex.com/4rghZiHSiW6Trf7
No target device state (kSendTabToSelfSigninPromo on):
https://screenshot.googleplex.com/rvD7MoNKRApABPk
https://screenshot.googleplex.com/9o8kF3WBtFFxDqq
Device picker:
https://screenshot.googleplex.com/9wZJg6c5ouEsMbG
https://screenshot.googleplex.com/ANsB54CxAkRPARH
Bug: 1219434
Change-Id: I698ea10837368cc27bc6d57bc9d3f72994fef992
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3826132
Reviewed-by: Sophey Dong <[email protected]>
Reviewed-by: Boris Sazonov <[email protected]>
Commit-Queue: Victor Vianna <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035561}
Roll WebRTC from 7cbd8dee7bf3 to f4f22872d0d9 (3 revisions)
https://webrtc.googlesource.com/src.git/+log/7cbd8dee7bf3..f4f22872d0d9
2022-08-16 [email protected] CallTest: migrate timeouts to TimeDelta.
2022-08-16 [email protected] Rename FrameBufferProxy to VideoStreamBufferController
2022-08-16 [email protected] Adopt absl::string_view in modules/audio_mixer/
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in WebRTC: https://bugs.chromium.org/p/webrtc/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: [email protected]
Change-Id: Ic8907ff700dd9e7f4dc2a194f19546ad83c7dd69
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834262
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035560}
Roll Perfetto from e3ae1b28af66 to d7a3c46d8622 (1 revision)
https://android.googlesource.com/platform/external/perfetto.git/+log/e3ae1b28af66..d7a3c46d8622
2022-08-16 [email protected] Merge "Keep namespace for mojo method name"
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel
Bug: None
Tbr: [email protected]
Change-Id: Id2047ff9b857faf119e8314ee1d09c24a65624f8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834091
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035559}
Shimless: Remove all strings translations
Set all Shimless RMA strings to translateable="false" so the app will
ignore the device language and only use English.
Bug: 1198187
Change-Id: I979a427775b512ee2df22a8574367ff4f40e2a5b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3828548
Reviewed-by: Xiangdong Kong <[email protected]>
Commit-Queue: Gavin Williams <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035558}
Delete unused class cc::MockMutatorHost
Change-Id: Ib2c6e369876e17de69714c19b4ff4a02c18a8059
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3827717
Auto-Submit: Stefan Zager <[email protected]>
Commit-Queue: Robert Flack <[email protected]>
Reviewed-by: Robert Flack <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035557}
Split UserPerformanceTuningManager initialization in 2 phases
This allows views:: code to register observers before the manager is
ready to be initialized.
Bug: 1348590
Change-Id: Ia43609c55fb0f23a8efafd500d3c329871fa8a6f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832501
Reviewed-by: Chris Hamilton <[email protected]>
Commit-Queue: Anthony Vallée-Dubois <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035556}
Feedback: Add bluetoothLogs flag to the report
When bluetoothLogs checkbox is checked:
- A sendBluetoothLogs flag is included in the report.
- The categoryTag of the report is marked as 'BluetoothReportWithLogs'.
browser_tests --gtest_filter=ChromeOsFeedbackDelegateTest.*;
Bug: b:185624798
Test: browser_tests --gtest_filter=OSFeedbackBrowserTest.*;
Change-Id: I37aa5145d64ed2febe48f16ea85df33f94a794c2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3823534
Reviewed-by: Tom Sepez <[email protected]>
Reviewed-by: Xiangdong Kong <[email protected]>
Reviewed-by: Jimmy Gong <[email protected]>
Commit-Queue: Yuhan Yang <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035555}
AboutThisSite: Ignore initial progress change
Ignore progress changes that might be intercepted by the
AboutThisPageSidePanelThrottle.
Bug: 1318000
Change-Id: Ic468aea9e5147a68d8af6fc5a0ec7a3ed36774e0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834307
Commit-Queue: Christian Dullweber <[email protected]>
Commit-Queue: Olesia Marukhno <[email protected]>
Auto-Submit: Christian Dullweber <[email protected]>
Reviewed-by: Olesia Marukhno <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035554}
[tracing] Make bg trace size reporting more precise
This change updates the logging of
Tracing.Background.FinalizingTraceSizeInKB to use
UMA_HISTOGRAM_CUSTOM_COUNTS (with the max of 50MB and 100 buckets)
since WebView traces are smaller than 1 MB
and their sizes are reported as 0 with UMA_HISTOGRAM_MEMORY_KB.
Bug: b/229996438
Change-Id: If6c8b455e449aab13f93f63042475a503f2a214c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3828143
Commit-Queue: Oksana Zhuravlova <[email protected]>
Reviewed-by: Eric Seckler <[email protected]>
Reviewed-by: Caitlin Fischer <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035553}
Update multipaste watch group to include current eng team
Change-Id: Id786942325b859a800c596292a35cd406b74d049
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3829310
Auto-Submit: Colin Kincaid <[email protected]>
Reviewed-by: David Black <[email protected]>
Commit-Queue: Colin Kincaid <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035552}
[iOS] Chrome on iOS missing server predictions for password generation
- Add missing code to use FormSignature.
- Add missing code to use FieldSignature.
- Fix unit tests.
- Remove changes from CL 3780597.
Bug: 1348744
Change-Id: Ia59398591586fa44231ed530903d4a71d6f95fcf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3800521
Commit-Queue: Veronique Nguyen <[email protected]>
Reviewed-by: Maxim Kolosovskiy <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035551}
Enable NoncedPartitionedCookies by default.
When enabled, then we allow partitioned cookies even if
kPartitionedCookies is disabled only if the cookie partition key
contains a nonce. So far, this is used to create temporary cookie jar
partitions for fenced and anonymous frames.
FencedFrame already enable it dynamically. See Finch config:
PrivacySandboxAdsAPIs.gcl
AnonymousIframe needs it for its origin trial:
https://groups.google.com/a/chromium.org/g/blink-dev/c/-7H19EHTenU
This patch adds some WPT test verifying AnonymousIframe origin trial
cookies are working.
Bug: 1318041
Change-Id: I5e1d80d823bd0397bcc3f77e319ae47273015497
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3829096
Commit-Queue: Shivani Sharma <[email protected]>
Reviewed-by: Maks Orlovich <[email protected]>
Auto-Submit: Arthur Sonzogni <[email protected]>
Reviewed-by: Shivani Sharma <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035550}
Remove the nodoc attribute on the document ID APIs.
With prerendering and back/forward cache shipping we need to
undocument these flags for extension developers.
A blog post and announcement will be sent highlighting the usages.
BUG=1227787
Change-Id: Ia5bd16ee2b8860d668267c94b6ebee30c151e2f0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3817584
Reviewed-by: Devlin Cronin <[email protected]>
Commit-Queue: Dave Tapuska <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035549}
Factor out site-validation logic for reuse.
Since we're going to be parsing SchemefulSites from multiple new
places (new subset fields, the ccTLD map), it's good to pull out the
validation for sharing.
Bug: 1349781
Change-Id: I7c139f3acfec3ebe787d0805f0862f0c1cea5e02
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832774
Reviewed-by: Kirubel Aklilu <[email protected]>
Commit-Queue: Kirubel Aklilu <[email protected]>
Auto-Submit: Chris Fredrickson <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035548}
Mac: Fix asynchronous TextInputHost::HasCompositionText
Currently, everything that goes through this path treats all RTL text as
if it was in the process of being composed in an IME. Looks like this
may have been a C+P error.
Bug: 1352091
Change-Id: Ife2b5c45552db3891621e97886fa42242fe064cb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832151
Auto-Submit: Leonard Grey <[email protected]>
Reviewed-by: Avi Drissman <[email protected]>
Commit-Queue: Avi Drissman <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035547}
[FRE] Fix signin fre UI when tablet is in landscape mode
This cl sets the width threshold to show signin fre in landscape mode
in tablets to 1000dp. Signin fre is launched as a dialog in tablets.
So tablets may not have enough space the show the signin fre in
landscape mode unless more space is available.
Bug: 1350917
Change-Id: I4c4b4aa65522b0daa05d8d981e77aabc0c9d3b9c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834107
Reviewed-by: Boris Sazonov <[email protected]>
Commit-Queue: Boris Sazonov <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035546}
Add CUD fallback experiment flags
Bug: b:241787710
Change-Id: Ie3203d3dffe917adbcf7af1d013f5978a0d76a59
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3816926
Reviewed-by: Luca Hunkeler <[email protected]>
Commit-Queue: Özgen Eren <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035545}
Roll src/third_party/libavif/src/ dd2d67c5f..d22d4de94 (35 commits)
https://chromium.googlesource.com/external/github.com/AOMediaCodec/libavif.git/+log/dd2d67c5f976..d22d4de94120
$ git log dd2d67c5f..d22d4de94 --date=short --no-merges --format='%ad %ae %s'
2022-08-11 vigneshv Refactor libyuv yuv->rgb conversion with function pointers
2022-08-10 vigneshv Use per-row conditional in avifImageIdentity8ToRGB8Color
2022-08-11 wtc Turn on caching of Build SVT-AV1 and Build libjpeg
2022-08-11 vigneshv Update libyuv.cmd to 9b17af9b
2022-08-10 wtc ext/svt.sh: Do not build the SVT-AV1 decoder
2022-08-10 wtc Ext: Update to SVT-AV1 v1.2.0
2022-08-09 vigneshv Support YUV422->RGB565 conversion with libyuv
2022-08-10 yguyon Run ext/libjpeg.cmd in GitHub CI
2022-08-04 vigneshv Add support RGB565 format
2022-08-09 wtc avifPNGWrite: Output RGB if input has no alpha
(...)
2022-08-02 wtc Fix MSVC warnings
2022-08-01 yguyon Make avifImageAllocatePlanes() return avifResult
2022-08-01 yguyon Bump AppVeyor Visual Studio version to 2022
2022-07-28 wtc Shorten AppVeyor build to fix build timeout
2022-07-28 wtc Add int32_t casts to fix MSVC warnings
2022-07-25 ccom svt: null metadata field on EbBufferHeaderType
2022-07-15 vrabaud Adding a basic test for lossless. (#984)
2022-07-12 yguyon Use I420ToRGB24Matrix() in reformat_libyuv.c
2022-07-11 wtc Initialize base class avifRWData with {nullptr, 0}
2022-07-11 yguyon Rename YUVToRGB test suite to RGBToYUV
Created with:
roll-dep src/third_party/libavif/src
Update two switch statements in avif_image_decoder.cc to handle the new
enum value 'AVIF_PIXEL_FORMAT_COUNT', otherwise there are -Wswitch
warnings.
[email protected],[email protected]
Change-Id: I303f40763bd6894be9be7f2c60807678fc4939f8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3828790
Commit-Queue: Wan-Teh Chang <[email protected]>
Reviewed-by: James Zern <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035544}
[CT][EngagementSignals] Add max scroll percentage reached signal
Bug: 1340074, 1351026
Change-Id: Ifdec7e7a44947cd0e4c6a7ce50d321fea1cc9f45
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3807899
Reviewed-by: Donn Denman <[email protected]>
Reviewed-by: Theresa Sullivan <[email protected]>
Commit-Queue: Donn Denman <[email protected]>
Reviewed-by: Jinsuk Kim <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035543}
Revert "Update to the new OWNERS file parser"
This reverts commit d0b6f640e8ac61e91c7dfc7abd82dd13151514df.
Reason for revert: Breaks bots?
https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20Builder/159106/overview
https://ci.chromium.org/ui/p/chromium/builders/try/android-marshmallow-x86-rel/581238/overview
Original change's description:
> Update to the new OWNERS file parser
>
> Move from the deprecated OWNERS file parser to the new OWNERS file
> API client.
>
> In addition, deduplicate owners, as there might be duplicates across
> the group of flag owners in the json file and those specified in the
> OWNERS file.
>
> Fixed: 1351519
> Change-Id: I7dc3a5a5dac8025071b87374ae3a552d332e4afe
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3827289
> Commit-Queue: Avi Drissman <[email protected]>
> Reviewed-by: Elly Fong-Jones <[email protected]>
> Reviewed-by: Nico Weber <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1035533}
Change-Id: If9daefc6970345a94d48b4a1956ce51191bf0db2
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834186
Bot-Commit: Rubber Stamper <[email protected]>
Auto-Submit: Avi Drissman <[email protected]>
Reviewed-by: Aishwarya Rajesh <[email protected]>
Owners-Override: Aishwarya Rajesh <[email protected]>
Commit-Queue: Aishwarya Rajesh <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035542}
Revert "CrOS VCD: Enable auto-framing by default"
This reverts commit 05b4c15c9caae339cc1a4fe044df1081ac7bd7b6.
Reason for revert: I suspect this CL causes failures
TrayAccessibilityLoginTestInstance/TrayAccessibilityLoginTest.ShowMenuWithShowOnLoginScreen/1
SystemTrayClientEnterpriseAccountTest.TrayEnterpriseManagedAccount
TrayAccessibilityLoginTestInstance/TrayAccessibilityLoginTest.ShowMenuWithShowOnLoginScreen/0
SystemTrayClientEnterpriseAccountTest.TrayEnterpriseUnmanagedAccount
...2 more failure(s) (6 total)...
https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests/29843/overview
Original change's description:
> CrOS VCD: Enable auto-framing by default
>
> Make chrome://flags#auto-framing-override flag defaults to enabled. Note
> that the feature is still guarded by per-device feature profile.
>
> Bug: b:210929757, b:221980963
> Test: Toggle chrome://flags#auto-framing-override and check behavior.
> Change-Id: I6b477be98dc75336cce2fd3841dc2d0d487dc7d9
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832988
> Auto-Submit: Ren-Pei Zeng <[email protected]>
> Reviewed-by: Shik Chen <[email protected]>
> Commit-Queue: Ren-Pei Zeng <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1035455}
Bug: b:210929757, b:221980963
Change-Id: I2aa286a9de951259247cd636ecb8aa72e2e08b64
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834442
Owners-Override: Maxim Kolosovskiy <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Reviewed-by: Maxim Kolosovskiy <[email protected]>
Commit-Queue: Osama Fathy <[email protected]>
Reviewed-by: Osama Fathy <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035541}
DanglingPtr: triage dangling ptr in SkiaRenderer
Investigating the code, we can be confident `this` won't outlive
`skia_output_surface_`, as the latter is stored as a unique_ptr in its
direct parent (as well as `this`). Moreover, the declaration order of
the two fields are correct in terms of dependency.
Bug: 1291138
Change-Id: I1f5e4a76049c766a0ce052926f0dab0cd707f397
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3833537
Reviewed-by: Arthur Sonzogni <[email protected]>
Reviewed-by: Peng Huang <[email protected]>
Commit-Queue: Paul Semel <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035540}
Fix crash in autofill manager if mixed forms pref is not set
Bug: 1346324
Change-Id: I8c4ca78681482f72ae6c9918fa92d0549f8d0358
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3831062
Reviewed-by: Christos Froussios <[email protected]>
Commit-Queue: Carlos IL <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035539}
[APC Desktop] Open password manager on click.
This CL adds support for opening Chrome's password manager in a new
tab when the user interacts with the respective link on the success
screen of a finished automated password change flow.
Bug: 1329179
Change-Id: I314ca7b97bbaf71da8389c0afa406cc45905adf4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3827408
Reviewed-by: Marc Treib <[email protected]>
Commit-Queue: Jan Keitel <[email protected]>
Reviewed-by: Vasilii Sukhanov <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035538}
Dictation: Add non-ascii support for tests
Previously, Dictation tests (or any other test that used fake speech
recognition) could not recognize non-ascii characters. This change
fixes that issue and adds a Dictation test to confirm new support.
Bug: N/A
Change-Id: I53765e238d9a2856226d6b45778d9dc4791c77ed
AX-Relnotes: N/A
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3828439
Reviewed-by: Katie Dektar <[email protected]>
Commit-Queue: Akihiro Ota <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035537}
saved_desks: Cleaning up saved desk GUID handling, part 1.
Every ash::DeskTemplate has a GUID which it internally holds in the form
of a base::GUID. However, there's a bunch of code where we use
std::string instead. This CL is part of a series to move to base::GUID
where possible.
There will be a very modest performance improvement, primarily when
eliminating pointless parsing when going from std::string to base::GUID.
For example: when creating a new saved desk, RestoreDataCollector would
call base::GUID::GenerateRandomV4() to construct a base::GUID. It then
immediately turned it into a std::string which was passed to
DeskTemplate's constructor. There, it would have to be turned into a
base::GUID again, which involved parsing the whole string and making
sure it's valid.
With this change, the GUID is built once and moved into the DeskTemplate
for a total of zero conversions and zero copies.
This specific CL tests the waters by changing DeskTemplate's constructor
from taking std::string to base::GUID.
Bug: 1352667
Change-Id: Iaece310bcf64019c2e5be4f1d6ebf5a7c2e5e81f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3827851
Reviewed-by: Yanzhu Du <[email protected]>
Reviewed-by: Marc Treib <[email protected]>
Commit-Queue: Daniel Andersson <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035536}
Encapsulate TimestampedSameOriginQueue.
Makes TimestampedSameOriginQueue a class.
Bug: 1313367
Change-Id: I8c3ed1300bd4e5e281b15be1c612875fffb616f6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3826042
Reviewed-by: Christoph Schwering <[email protected]>
Commit-Queue: Florian Leimgruber <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035535}
[Password Manager] Expand AddResult in SavedPasswordsPresenter to include conflicting store.
The specific conflicting store is needed by the caller: in this particular case it's the Importer flow.
Bug: 1325290
Change-Id: I68c7504461fc07b4a113b2705e949bb174d34da6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3827438
Auto-Submit: Elias Khsheibun <[email protected]>
Reviewed-by: Mohamed Amir Yosef <[email protected]>
Commit-Queue: Elias Khsheibun <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035534}
Update to the new OWNERS file parser
Move from the deprecated OWNERS file parser to the new OWNERS file
API client.
In addition, deduplicate owners, as there might be duplicates across
the group of flag owners in the json file and those specified in the
OWNERS file.
Fixed: 1351519
Change-Id: I7dc3a5a5dac8025071b87374ae3a552d332e4afe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3827289
Commit-Queue: Avi Drissman <[email protected]>
Reviewed-by: Elly Fong-Jones <[email protected]>
Reviewed-by: Nico Weber <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035533}
Add rajendrant@ to opt guide owners
Change-Id: Id2bc56b634c1656bbd9c7f59518ec7b6924a82ce
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3833494
Reviewed-by: Raj T <[email protected]>
Commit-Queue: Raj T <[email protected]>
Auto-Submit: Sophie Chang <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035532}
Re-enable HistoryBrowserTests.Verify* and .Consider*
These tests have been disabled since 2015 (and weren't actually executed
even before that, see linked bug), apparently due to essentially a typo
(missing /) in the test URLs.
This CL fixes the typo and re-enables the tests.
Bug: 511442
Change-Id: I3e6c71541abb14be2bba2a123c7471fc5dfece5f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3830022
Commit-Queue: Marc Treib <[email protected]>
Reviewed-by: Tommy Li <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035531}
blink: Enable css overflow for replaced elements field trial testing
[email protected]
Bug: 1321217
Change-Id: If43ffd51feb3dd952d2da2af395eaf2706bce596
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832301
Commit-Queue: Vladimir Levin <[email protected]>
Reviewed-by: Vladimir Levin <[email protected]>
Auto-Submit: Khushal Sagar <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035530}
Fix flaky BrowserAccessibilityStateImplTest test
GetRolePreventsAutoDisableAccessibility was failing on the first run
because the previous test left accessibility enabled. This commit
deflakes this test by disabling accessibility explicitly in TearDown().
Bug: 1352617
Change-Id: Iecac6865c71c398ee6be674d24967337044ee3b9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3831954
Reviewed-by: Abigail Klein <[email protected]>
Commit-Queue: Joanmarie Diggs <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035529}
Roll Chrome Win32 PGO Profile
Roll Chrome Win32 PGO profile from chrome-win32-main-1660629591-4c2e447a931c4be58f67e1d7c0640086f637eeee.profdata to chrome-win32-main-1660650975-ee2eda6f820d2789a82040d13a5e68a0c91b2dda.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win-chrome
Tbr: [email protected]
Change-Id: Ia2240a11ee2cbbc5f2eb1ac39bc539f5c3edbe5c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832850
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035528}
Revert "Update dialog height without footnote"
This reverts commit 50eec5c48a22ec54251fe2ec2c241e70f410377b.
Reason for revert: This CL caused a consistent failure of AccessCodeCastDialogBrowserTest.InvokeUi_default starting https://ci.chromium.org/ui/p/chromium/builders/ci/Win10%20Tests%20x64/70399/overview
[ RUN ] AccessCodeCastDialogBrowserTest.InvokeUi_default
[21280:13460:0815/175409.393:WARNING:field_trial_util.cc(104)] Field trial config study skipped: DesktopTabGroupsInProductHelp.EnabledIPH_20220401 (some of its features are already overridden)
[21280:13460:0815/175409.393:WARNING:field_trial_util.cc(104)] Field trial config study skipped: PreconnectToSearchDesktop.EnabledWithStartupDelayForegroundOnly (some of its features are already overridden)
[21280:13460:0815/175409.393:WARNING:field_trial_util.cc(104)] Field trial config study skipped: SharedHighlightingIphDesktop.Enabled (some of its features are already overridden)
[21280:13460:0815/175409.393:WARNING:field_trial_util.cc(104)] Field trial config study skipped: TabAudioMuting.Enabled (some of its features are already overridden)
[21280:13460:0815/175409.393:WARNING:field_trial_util.cc(104)] Field trial config study skipped: TabSearchInProductHelp.TabSearchIPH (some of its features are already overridden)
[21280:13460:0815/175409.393:WARNING:field_trial_util.cc(104)] Field trial config study skipped: WebUITabStrip.Enabled (some of its features are already overridden)
[21280:13460:0815/175409.907:ERROR:device_event_log_impl.cc(214)] [17:54:09.907] Bluetooth: bluetooth_adapter_winrt.cc:1074 Getting Default Adapter failed.
content\public\test\test_utils.cc(407): error: Failed
RunLoop::Run() timed out. Timeout set at ProxyRunTestOnMainThreadLoop@content\public\test\browser_test_base.cc:837.
Stack trace:
Backtrace:
base::internal::Invoker<base::internal::BindState<`lambda at ../../base/test/scoped_run_loop_timeout.cc:51:9',base::Location,base::RepeatingCallback<std::Cr::basic_string<char,std::Cr::char_traits<char>,std::Cr::allocator<char> > ()> >,void (const base::L [0x00007FF668D94F46+166] (o:\base\bind_internal.h:832)
base::`anonymous namespace'::OnRunLoopTimeout [0x00007FF668CF3ADC+60] (o:\base\run_loop.cc:48)
base::internal::Invoker<base::internal::BindState<void (*)(base::RunLoop *, const base::Location &, base::OnceCallback<void (const base::Location &)>),base::internal::UnretainedWrapper<base::RunLoop>,base::Location,base::RepeatingCallback<void (const base [0x00007FF668CF4E86+102] (o:\base\bind_internal.h:819)
base::internal::CancelableCallbackImpl<base::OnceCallback<void ()> >::ForwardOnce<> [0x00007FF665B8AFFD+61] (o:\base\cancelable_callback.h:127)
base::TaskAnnotator::RunTaskImpl [0x00007FF668D12567+327] (o:\base\task\common\task_annotator.cc:135)
base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWorkImpl [0x00007FF66A640425+965] (o:\base\task\sequence_manager\thread_controller_with_message_pump_impl.cc:424)
base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWork [0x00007FF66A63FEA5+165] (o:\base\task\sequence_manager\thread_controller_with_message_pump_impl.cc:303)
base::MessagePumpForUI::DoRunLoop [0x00007FF668D473B6+150] (o:\base\message_loop\message_pump_win.cc:215)
base::MessagePumpWin::Run [0x00007FF668D46D40+144] (o:\base\message_loop\message_pump_win.cc:79)
base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::Run [0x00007FF66A640E5A+394] (o:\base\task\sequence_manager\thread_controller_with_message_pump_impl.cc:580)
base::RunLoop::Run [0x00007FF668CF34DD+493] (o:\base\run_loop.cc:143)
content::WindowedNotificationObserver::Wait [0x00007FF66915D7A3+79] (o:\content\public\test\test_utils.cc:408)
content::WaitForLoadStopWithoutSuccessCheck [0x00007FF66910E5AE+211] (o:\content\public\test\browser_test_utils.cc:818)
content::WaitForLoadStop [0x00007FF66910E05D+138] (o:\content\public\test\browser_test_utils.cc:825)
media_router::AccessCodeCastDialogBrowserTest::ShowUi [0x00007FF6647ECA19+313] (o:\chrome\browser\ui\webui\access_code_cast\access_code_cast_dialog_browsertest.cc:44)
TestBrowserUi::ShowAndVerifyUi [0x00007FF668C5550B+263] (o:\chrome\browser\ui\test\test_browser_ui.cc:116)
TestBrowserDialog::ShowAndVerifyUi [0x00007FF664797525+13] (o:\chrome\browser\ui\test\test_browser_dialog.cc:77)
content::BrowserTestBase::ProxyRunTestOnMainThreadLoop [0x00007FF66910C1C4+740] (o:\content\public\test\browser_test_base.cc:912)
content::BrowserMainLoop::InterceptMainMessageLoopRun [0x00007FF666CDB5A2+92] (o:\content\browser\browser_main_loop.cc:1014)
content::BrowserMainLoop::RunMainMessageLoop [0x00007FF666CDB5EF+37] (o:\content\browser\browser_main_loop.cc:1026)
content::BrowserMainRunnerImpl::Run [0x00007FF666CDD421+17] (o:\content\browser\browser_main_runner_impl.cc:158)
content::BrowserMain [0x00007FF666CD8F23+203] (o:\content\browser\browser_main.cc:30)
content::RunBrowserProcessMain [0x00007FF6687C1DB7+239] (o:\content\app\content_main_runner_impl.cc:680)
content::ContentMainRunnerImpl::RunBrowser [0x00007FF6687C2EA8+374] (o:\content\app\content_main_runner_impl.cc:1207)
content::ContentMainRunnerImpl::Run [0x00007FF6687C2CF1+849] (o:\content\app\content_main_runner_impl.cc:1073)
content::RunContentProcess [0x00007FF6687C1820+1993] (o:\content\app\content_main.cc:433)
content::ContentMain [0x00007FF6687C1953+90] (o:\content\app\content_main.cc:461)
content::BrowserTestBase::SetUp [0x00007FF66910B805+1957] (o:\content\public\test\browser_test_base.cc:733)
InProcessBrowserTest::SetUp [0x00007FF668C8B8C5+421] (o:\chrome\test\base\in_process_browser_test.cc:477)
..\..\content\public\test\test_utils.cc(408): error: Value of: seen_
Actual: false
Expected: true
Stack trace:
Backtrace:
content::WindowedNotificationObserver::Wait [0x00007FF66915D854+256] (o:\content\public\test\test_utils.cc:408)
content::WaitForLoadStopWithoutSuccessCheck [0x00007FF66910E5AE+211] (o:\content\public\test\browser_test_utils.cc:818)
content::WaitForLoadStop [0x00007FF66910E05D+138] (o:\content\public\test\browser_test_utils.cc:825)
media_router::AccessCodeCastDialogBrowserTest::ShowUi [0x00007FF6647ECA19+313] (o:\chrome\browser\ui\webui\access_code_cast\access_code_cast_dialog_browsertest.cc:44)
TestBrowserUi::ShowAndVerifyUi [0x00007FF668C5550B+263] (o:\chrome\browser\ui\test\test_browser_ui.cc:116)
TestBrowserDialog::ShowAndVerifyUi [0x00007FF664797525+13] (o:\chrome\browser\ui\test\test_browser_dialog.cc:77)
content::BrowserTestBase::ProxyRunTestOnMainThreadLoop [0x00007FF66910C1C4+740] (o:\content\public\test\browser_test_base.cc:912)
content::BrowserMainLoop::InterceptMainMessageLoopRun [0x00007FF666CDB5A2+92] (o:\content\browser\browser_main_loop.cc:1014)
content::BrowserMainLoop::RunMainMessageLoop [0x00007FF666CDB5EF+37] (o:\content\browser\browser_main_loop.cc:1026)
content::BrowserMainRunnerImpl::Run [0x00007FF666CDD421+17] (o:\content\browser\browser_main_runner_impl.cc:158)
content::BrowserMain [0x00007FF666CD8F23+203] (o:\content\browser\browser_main.cc:30)
content::RunBrowserProcessMain [0x00007FF6687C1DB7+239] (o:\content\app\content_main_runner_impl.cc:680)
content::ContentMainRunnerImpl::RunBrowser [0x00007FF6687C2EA8+374] (o:\content\app\content_main_runner_impl.cc:1207)
content::ContentMainRunnerImpl::Run [0x00007FF6687C2CF1+849] (o:\content\app\content_main_runner_impl.cc:1073)
content::RunContentProcess [0x00007FF6687C1820+1993] (o:\content\app\content_main.cc:433)
content::ContentMain [0x00007FF6687C1953+90] (o:\content\app\content_main.cc:461)
content::BrowserTestBase::SetUp [0x00007FF66910B805+1957] (o:\content\public\test\browser_test_base.cc:733)
InProcessBrowserTest::SetUp [0x00007FF668C8B8C5+421] (o:\chrome\test\base\in_process_browser_test.cc:477)
[21280:13460:0815/175443.391:ERROR:browser_test_utils.cc(826)] WebContents was destroyed during waiting for load stop.
..\..\chrome\browser\ui\webui\access_code_cast\access_code_cast_dialog_browsertest.cc(44): error: Value of: content::WaitForLoadStop(dialog_contents)
Actual: false
Expected: true
Stack trace:
Backtrace:
media_router::AccessCodeCastDialogBrowserTest::ShowUi [0x00007FF6647ECA99+441] (o:\chrome\browser\ui\webui\access_code_cast\access_code_cast_dialog_browsertest.cc:44)
TestBrowserUi::ShowAndVerifyUi [0x00007FF668C5550B+263] (o:\chrome\browser\ui\test\test_browser_ui.cc:116)
TestBrowserDialog::ShowAndVerifyUi [0x00007FF664797525+13] (o:\chrome\browser\ui\test\test_browser_dialog.cc:77)
content::BrowserTestBase::ProxyRunTestOnMainThreadLoop [0x00007FF66910C1C4+740] (o:\content\public\test\browser_test_base.cc:912)
content::BrowserMainLoop::InterceptMainMessageLoopRun [0x00007FF666CDB5A2+92] (o:\content\browser\browser_main_loop.cc:1014)
content::BrowserMainLoop::RunMainMessageLoop [0x00007FF666CDB5EF+37] (o:\content\browser\browser_main_loop.cc:1026)
content::BrowserMainRunnerImpl::Run [0x00007FF666CDD421+17] (o:\content\browser\browser_main_runner_impl.cc:158)
content::BrowserMain [0x00007FF666CD8F23+203] (o:\content\browser\browser_main.cc:30)
content::RunBrowserProcessMain [0x00007FF6687C1DB7+239] (o:\content\app\content_main_runner_impl.cc:680)
content::ContentMainRunnerImpl::RunBrowser [0x00007FF6687C2EA8+374] (o:\content\app\content_main_runner_impl.cc:1207)
content::ContentMainRunnerImpl::Run [0x00007FF6687C2CF1+849] (o:\content\app\content_main_runner_impl.cc:1073)
content::RunContentProcess [0x00007FF6687C1820+1993] (o:\content\app\content_main.cc:433)
content::ContentMain [0x00007FF6687C1953+90] (o:\content\app\content_main.cc:461)
content::BrowserTestBase::SetUp [0x00007FF66910B805+1957] (o:\content\public\test\browser_test_base.cc:733)
InProcessBrowserTest::SetUp [0x00007FF668C8B8C5+421] (o:\chrome\test\base\in_process_browser_test.cc:477)
[21280:13460:0815/175443.393:INFO:test_browser_dialog.cc(106)] VerifyUi(): Expected 1 added widget; got 0
..\..\chrome\browser\ui\test\test_browser_ui.cc(117): error: Value of: VerifyUi()
Actual: false
Expected: true
Stack trace:
Backtrace:
TestBrowserUi::ShowAndVerifyUi [0x00007FF668C555D8+468] (o:\chrome\browser\ui\test\test_browser_ui.cc:117)
TestBrowserDialog::ShowAndVerifyUi [0x00007FF664797525+13] (o:\chrome\browser\ui\test\test_browser_dialog.cc:77)
content::BrowserTestBase::ProxyRunTestOnMainThreadLoop [0x00007FF66910C1C4+740] (o:\content\public\test\browser_test_base.cc:912)
content::BrowserMainLoop::InterceptMainMessageLoopRun [0x00007FF666CDB5A2+92] (o:\content\browser\browser_main_loop.cc:1014)
content::BrowserMainLoop::RunMainMessageLoop [0x00007FF666CDB5EF+37] (o:\content\browser\browser_main_loop.cc:1026)
content::BrowserMainRunnerImpl::Run [0x00007FF666CDD421+17] (o:\content\browser\browser_main_runner_impl.cc:158)
content::BrowserMain [0x00007FF666CD8F23+203] (o:\content\browser\browser_main.cc:30)
content::RunBrowserProcessMain [0x00007FF6687C1DB7+239] (o:\content\app\content_main_runner_impl.cc:680)
content::ContentMainRunnerImpl::RunBrowser [0x00007FF6687C2EA8+374] (o:\content\app\content_main_runner_impl.cc:1207)
content::ContentMainRunnerImpl::Run [0x00007FF6687C2CF1+849] (o:\content\app\content_main_runner_impl.cc:1073)
content::RunContentProcess [0x00007FF6687C1820+1993] (o:\content\app\content_main.cc:433)
content::ContentMain [0x00007FF6687C1953+90] (o:\content\app\content_main.cc:461)
content::BrowserTestBase::SetUp [0x00007FF66910B805+1957] (o:\content\public\test\browser_test_base.cc:733)
InProcessBrowserTest::SetUp [0x00007FF668C8B8C5+421] (o:\chrome\test\base\in_process_browser_test.cc:477)
[21280:13460:0815/175443.499:WARNING:pref_notifier_impl.cc(41)] Pref observer for media_router.cast_allow_all_ips found at shutdown.
[ FAILED ] AccessCodeCastDialogBrowserTest.InvokeUi_default, where TypeParam = and GetParam() = (34129 ms)
Original change's description:
> Update dialog height without footnote
>
> Bug: b/238244922
> Change-Id: I3d425887ed3535090b347e04cf39f9f0fec69358
> Screenshot: https://screenshot.googleplex.com/8EdCAVivHuUFnvJ.png
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3830741
> Commit-Queue: Luke Cao <[email protected]>
> Reviewed-by: Benjamin Zielinski <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1035280}
Bug: b/238244922
Change-Id: I1b82cb372c31c1935e5f83a79f36ef263a183a95
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3829100
Commit-Queue: Maxim Kolosovskiy <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Reviewed-by: Maxim Kolosovskiy <[email protected]>
Owners-Override: Maxim Kolosovskiy <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035527}
Roll Chrome Mac Arm PGO Profile
Roll Chrome Mac Arm PGO profile from chrome-mac-arm-main-1660629591-7059cbf5eed4d18173cea769494ab7763fc9f9b7.profdata to chrome-mac-arm-main-1660650975-30813d08c6ccb5b6f1a6077df2f97a642093a30b.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-arm-chromium
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:mac-chrome
Tbr: [email protected]
Change-Id: I7996de7f220efd3e0764c6a32d4cab72fac3176d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832852
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035526}
Roll Chromite from d391be8a4325 to 2db7368ba02c (153 revisions)
https://chromium.googlesource.com/chromiumos/chromite.git/+log/d391be8a4325..2db7368ba02c
2022-08-16 [email protected] cli: cros_chrome_sdk: Stop reading gs://chromeos-build-release-console
2022-08-15 [email protected] cros_test: Fix lint errors
2022-08-15 [email protected] api: convert docstring annotations
2022-08-15 [email protected] lib: Use context manager in firmware_lib
2022-08-15 [email protected] Automated Commit: Updated config generated by config-updater builder.
2022-08-15 [email protected] Automated Commit: Updated config generated by config-updater builder.
2022-08-15 [email protected] binhost: YAPF some binhost files
2022-08-15 [email protected] Automated Commit: Updated config generated by config-updater builder.
2022-08-13 [email protected] lib: (reland) Decouple signer logic from payload in Paygen*
2022-08-13 [email protected] service: Retrieve size for pkgs in partition db
2022-08-13 [email protected] licensing: disallow as-is usage
2022-08-13 [email protected] Automated Commit: Updated config generated by config-updater builder.
2022-08-12 [email protected] contrib: portage_explorer: Testing ebuild_metadata
2022-08-12 [email protected] scripts: Add more information to dump_syms failures
2022-08-12 [email protected] contrib: portage_explorer: Spider to get eclasses
2022-08-12 [email protected] Automated Commit: Updated config generated by config-updater builder.
2022-08-12 [email protected] cros-ide: Suggest user install Go for go linter.
2022-08-12 [email protected] cros_build_lib: run: drop Python 2 CalledProcessError glue
2022-08-12 [email protected] licensing: disallow CC-BY-NC usage
2022-08-12 [email protected] cros-ide: restrict the list of allowed 3rd party licenses.
2022-08-12 [email protected] cros-ide: fix license in package.json
2022-08-12 [email protected] cros-ide: do not lint generated files in chroot/build/
2022-08-12 [email protected] cros-ide: fix promise usage in gerrit.ts
2022-08-12 [email protected] lib: parser: Add comments to clarify pvr and vr
2022-08-11 [email protected] Automated Commit: Updated config generated by config-updater builder.
2022-08-11 [email protected] cros_build_lib: run: drop CommandResult compat
2022-08-11 [email protected] cli: cros_chrome_sdk.py: Rename name of nacl helper arm32 toolchain
2022-08-11 [email protected] contrib: adding tests for generate_cs_path.py
2022-08-11 [email protected] Automated Commit: Updated config generated by config-updater builder.
2022-08-11 [email protected] cli: cros_chrome_sdk: Fetch Arm32 toolchain in Arm64 builds
2022-08-10 [email protected] lib: convert a docstring annotation
2022-08-10 [email protected] config: Delete AUE factorybranch builders
2022-08-10 [email protected] cbuildbot: Remove pre-7828.B factory stage support
2022-08-10 [email protected] cros_build_lib: convert CommandResult to CompletedProcess
2022-08-10 [email protected] Revert "lib: Decouple signer logic from payload in Paygen*"
2022-08-10 [email protected] Automated Commit: Updated config generated by config-updater builder.
2022-08-10 [email protected] lint: upstart_exceptions: Drop trace_marker-test.conf
2022-08-10 [email protected] licensing: disallow AGPL usage
2022-08-10 [email protected] lib: Decouple signer logic from payload in Paygen*
2022-08-10 [email protected] licensing: Add modem-fw-dlc-villager to Google-TOS
2022-08-10 [email protected] lib: Run yapf on portage_util.py
2022-08-09 [email protected] lib: pyformat paygen files
2022-08-09 [email protected] contrib: convert docstring annotations
2022-08-09 [email protected] contrib: fix wrong internal CS links.
2022-08-09 [email protected] ide_tooling: Quick update to quickstart.md
2022-08-09 [email protected] cros-ide: Start developing Gerrit integration under a flag
2022-08-09 [email protected] cros-ide: Fix "go.toolsGopath is not defined in package.json".
2022-08-09 [email protected] cros-ide: Fix tast linting errors.
2022-08-09 [email protected] Revert "cros: test: add membership check for secagentd"
2022-08-08 [email protected] Revert "lib: install_mask: Move install mask from constants"
2022-08-08 [email protected] Revert "scripts: strip_package: Use install mask from python"
2022-08-08 [email protected] Automated Commit: Updated config generated by config-updater builder.
2022-08-08 [email protected] cros: test: add membership check for secagentd
2022-08-08 [email protected] cros_build_lib: internalize TerminateRunCommandError
2022-08-08 [email protected] Automated Commit: Updated config generated by config-updater builder.
2022-08-08 [email protected] contrib: deploy_to_termina: Rsync with sudo
2022-08-08 [email protected] cros-ide: Stop using hard-coded mapping for C++ code completion
2022-08-08 [email protected] cros-ide: make misuse of promises an error
2022-08-08 [email protected] cros-ide: fix promise-related lint warning in common_util.ts
2022-08-08 [email protected] cros-ide: Introduce a merged view of owned/leased devices
2022-08-08 [email protected] cros-ide: Fix README.md style
2022-08-08 [email protected] licensing: check for valid licenses at build time
2022-08-08 [email protected] cros-ide: fix promise-related lint warnings in gn.ts
2022-08-07 [email protected] Automated Commit: Updated config generated by config-updater builder.
2022-08-06 [email protected] licensing: Exempt nec-printing-license from package size check
2022-08-06 [email protected] scripts: strip_package: Use install mask from python
2022-08-06 [email protected] lib: install_mask: Move install mask from constants
2022-08-05 [email protected] api: Regenerate proto files
2022-08-05 [email protected] cros-ide: fix promise-related lint warnings in cpp_code_completion.ts.
2022-08-05 [email protected] cros-ide: Clean up and refactor code related to chroot support
2022-08-05 [email protected] cros-ide: Remove inside-chroot support from ChrootService
2022-08-05 [email protected] cros-ide: Boards and packages test now assumes outside-chroot env
2022-08-05 [email protected] cros-ide: Add helper to install fake handler for chroot commands
2022-08-05 [email protected] cros-ide: fix promise-related lint warnings in extension.ts
2022-08-05 [email protected] cros-ide: recommend Go extension only in code-server.
2022-08-05 [email protected] cros-ide: fix promise-related lint warnings in cros_lint.ts.
2022-08-05 [email protected] cros-ide: fix promise-related lint warning in check_updates.ts.
2022-08-05 [email protected] ide_tooling: Remove cros-sdk-proxy
2022-08-05 [email protected] cros-ide: Update license headers
2022-08-04 [email protected] cros-ide: Support cros lint for go packages.
2022-08-04 [email protected] format: repo_manifest: collapse multiple newlines
2022-08-04 [email protected] contrib: portage_explorer: Spider to get ebuilds
2022-08-04 [email protected] licensing: drop BSD->BSD-Google hack
2022-08-04 [email protected] Automated Commit: Updated config generated by config-updater builder.
2022-08-04 [email protected] Automated Commit: Updated config generated by config-updater builder.
2022-08-04 [email protected] lib: gob_util: Update argument checker in SetReview
2022-08-04 [email protected] Automated Commit: Updated config generated by config-updater builder.
2022-08-04 [email protected] Automated Commit: Updated config generated by config-updater builder.
2022-08-04 [email protected] Automated Commit: Updated config generated by config-updater builder.
2022-08-04 [email protected] cros-ide: Refactor packages.ts
2022-08-04 [email protected] lib: Provide standalone func for pkg size calc
2022-08-03 [email protected] contrib: portage_explorer: Spider for profile use
2022-08-03 [email protected] cros_build_lib: CommandResult: drop support for cmd=
2022-08-03 [email protected] Automated Commit: Updated config generated by config-updater builder.
2022-08-03 [email protected] cli: Use a default for chrome_src when it's None in simple chrome
2022-08-03 [email protected] cros_build_lib: CompletedProcess: drop Python 2 glue
2022-08-03 [email protected] cros_build_lib: CommandResult: mark cmd= as deprecated
2022-08-03 [email protected] cros-ide: fix linter problems on GN files
2022-08-03 [email protected] lib: scripts: Support force stable version ebuild uprev
2022-08-03 [email protected] service: sysroot: Pass through backtrack to update chroot
2022-08-03 [email protected] firmware: Add config for ghost
2022-08-02 [email protected] Reland "cros_build_lib: run: drop deprecated output=/error= APIs"
2022-08-02 [email protected] run_tests: log pytest invocation
2022-08-02 [email protected] cros_build_lib: run: convert a few more .output/.error usage
2022-08-02 [email protected] cros_build_lib: CommandResult: switch users from cmd= to args=
2022-08-02 [email protected] cros: image_test: Ignore check for camera libs
2022-08-02 [email protected] cros-ide: fix promise-related lint warnings in coverage.ts
2022-08-02 [email protected] api: controller/sysroot: Increase backtracking on bots.
2022-08-02 [email protected] service: fix linting using removed output field
2022-08-02 [email protected] service: Clippy/Tidy linters only in platform2
2022-08-02 [email protected] cros-ide: fix promise-related lint warnings in chroot detection.
2022-08-02 [email protected] Revert "cros_build_lib: run: drop deprecated output=/error= APIs"
2022-08-02 [email protected] lib: cros_sdk_lib: Add timers to SDK creation
2022-08-01 [email protected] sync_chrome: don't throw raw traceback on gclient sync failure
2022-08-01 [email protected] lib: remove libcxxabi references
2022-08-01 [email protected] contrib: portage_explorer: Spider profile_inherit
2022-08-01 [email protected] cros_build_lib: run: drop deprecated output=/error= APIs
2022-08-01 [email protected] contrib: portage_explorer: Parent profiles testing
2022-08-01 [email protected] cros-ide: Replace filename to link
2022-08-01 [email protected] cros-ide: Run compilation if necessary C++ files don't exist
2022-08-01 [email protected] cros-ide: Make Ebuild take use flag
2022-08-01 [email protected] cros-ide: Split files in compdb_service
2022-08-01 [email protected] cros-ide: Move compdb_service to a separate directory
2022-07-30 [email protected] Automated Commit: Updated config generated by config-updater builder.
2022-07-30 [email protected] Automated Commit: Updated config generated by config-updater builder.
2022-07-30 [email protected] Automated Commit: Updated config generated by config-updater builder.
2022-07-29 [email protected] lib: Reenable betty-pi-arc legacy release
2022-07-29 [email protected] api: controller: Add profile data to output proto
2022-07-29 [email protected] cli: Fix the parsing of build_config.ToT.json in simple chrome
2022-07-29 [email protected] setup_board & build_packages: Add --backtrack option.
2022-07-29 [email protected] partial_mock: drop support for deprecated run APIs
2022-07-29 [email protected] lib: Support package db lookups in more partitions
2022-07-29 [email protected] api: updated build api proto
2022-07-28 [email protected] service: Parse PackageIdentifier components
2022-07-28 [email protected] lib: Reenable reven-vmtest legacy release
2022-07-28 [email protected] api: controller/sysroot: YAPF
2022-07-28 [email protected] licensing: fix argparse usage info
2022-07-28 [email protected] scripts: add branch support to chrome_chromeos_lkgm
2022-07-28 [email protected] cros-ide: Enable golang linting using tast-lint.
2022-07-28 [email protected] cli: Remove use of site_config and config_dump.json from cros_chrome_sdk
2022-07-28 [email protected] contrib: portage_explorer: Add profile spider call
2022-07-28 [email protected] api: Updating portage_explorer proto
2022-07-28 [email protected] contrib: portage_explorer: Spider to get profiles
2022-07-28 [email protected] Automated Commit: Updated config generated by config-updater builder.
2022-07-28 [email protected] lint: Update resource limits anchor
2022-07-28 [email protected] contrib: portage_explorer: Spider unittest helpers
2022-07-28 [email protected] service: sysroot.py: BuildPackages metrics
2022-07-28 [email protected] api: controller/packages: proto field default value fallback
2022-07-28 [email protected] lib: gob_util_unittest.py: Create 201 response test.
2022-07-28 [email protected] cbuildbot: only apply LEGACY_RELEASE_ALLOWLIST to release
2022-07-28 [email protected] lib: Accept 200 and 201 for CreateChange
2022-07-27 [email protected] Automated Commit: Updated config generated by config-updater builder.
2022-07-27 [email protected] partial_mock: disallow output=/error= usage
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromite-chromium-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel
Tbr: [email protected],[email protected],[email protected]
Change-Id: I6271e8b8897f1e2e0583f79d64eb765dc0688faf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832447
Commit-Queue: Ben Pastene <[email protected]>
Reviewed-by: Ben Pastene <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035525}
Revert "Reland "MobileFriendlinessChecker add checking of ViweportMeta""
This reverts commit 093d9c31ab295c5e5a7372059197491458b25daa.
Reason for revert: Failed system tests for
- mac10.15-blink-rel
- mac11.0-blink-rel
- mac12.0.arm64-blink-rel
e.g.
https://ci.chromium.org/ui/p/chromium/builders/try/mac12.0.arm64-blink-rel/660/overview
Original change's description:
> Reland "MobileFriendlinessChecker add checking of ViweportMeta"
>
> This is a reland of commit e85b38d7956712e392827d562e9d90279a6cf3e2
>
> The original commit reverted because of timeout on test external/wpt/accessibility/crashtests/aria-owns-fallback-content.html with linux_chromium_dbg_ng test.
> But that phenomenon is no more reproducible by manual invocation and my local environment.
>
> Original change's description:
> > MobileFriendlinessChecker add checking of ViweportMeta
> >
> > Do not create MF checker if ViewportMeta is not enabled.
> >
> >
> > Bug: 1113750
> > Change-Id: I5cde07ac62b212df31865eef16931ba693384064
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3789270
> > Reviewed-by: Xianzhu Wang <[email protected]>
> > Commit-Queue: Hiroki Kumazaki <[email protected]>
> > Cr-Commit-Position: refs/heads/main@{#1030031}
>
> Bug: 1113750
> Change-Id: I8b17fd025db8c9b629338a12e626064353a2117f
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3801771
> Reviewed-by: Xianzhu Wang <[email protected]>
> Commit-Queue: Hiroki Kumazaki <[email protected]>
> Auto-Submit: Hiroki Kumazaki <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1035379}
Bug: 1113750
Change-Id: Iabddfddcd26ce8a52417e06e526892b8d3cfff23
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832981
Auto-Submit: Hiroki Kumazaki <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Reviewed-by: Xianzhu Wang <[email protected]>
Commit-Queue: Xianzhu Wang <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035524}
Creating Subclasses of Opt to hold different Opt records.
Currently, the Opt class holds an Opt record without a dedicated
subclass. This CL involves creating a subclass of Opt for each specific
Opt record, along with an UnknownOpt subclass to contain Opt records
without a specific subclass, as well as making Opt an abstract class.
Bug: 1347517
Change-Id: Iccdbac2fdc1b3c54e2f6ade2c6e4a6217722c3bd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3821163
Commit-Queue: Sukrit Ganesh <[email protected]>
Reviewed-by: Dan McArdle <[email protected]>
Reviewed-by: Eric Orth <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035523}
Roll Chrome Mac PGO Profile
Roll Chrome Mac PGO profile from chrome-mac-main-1660629591-1f325dcc2da375cc208a9ac8f1f693b2841ade8f.profdata to chrome-mac-main-1660650975-78f2abc50319e2e21df10a82759f3c1451ffd523.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:mac-chrome
Tbr: [email protected]
Change-Id: I2f9b439e0f5664e0f924f82ff175981d64822560
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832688
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035522}
[chrome] Fix enable_hidpi=false build on non-Windows platforms
Add missing guards in resources_integrity.cc.
Windows-specific code is not changed because there is no known use case.
Bug: 1352700
Change-Id: I46ad9f56b111ae6de7ffaa8292ead32c9a4b2d9f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832915
Auto-Submit: David Dorwin <[email protected]>
Reviewed-by: Avi Drissman <[email protected]>
Commit-Queue: Avi Drissman <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035521}
[chrome][pdf] Add ENABLE_PDF around PDF-specific test
This fixes a build error when enable_pdf=false.
Bug: 1352700
Change-Id: I347874a980f4a4fdf2a8f5b103fadc55b5c8b29a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832504
Commit-Queue: David Dorwin <[email protected]>
Reviewed-by: Lei Zhang <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035520}
WPT Triage
Addresses a navigation test on Mac that was already
reported for a different bot.
Also fixes a typo as a side effect.
Bug: 1299442
Change-Id: Ie7cfd787a6f678cb61a9b1f86c12ec2fc0e264bf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3828020
Reviewed-by: David Grogan <[email protected]>
Commit-Queue: David Grogan <[email protected]>
Auto-Submit: Stephen Chenney <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035519}
Change FilterData to use size_t.
Bug: 1292951
Change-Id: I587d6cb93a030ac5f395039c77bcc6dc2728b659
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3829695
Commit-Queue: Peter Kasting <[email protected]>
Reviewed-by: Matt Menke <[email protected]>
Commit-Queue: Matt Menke <[email protected]>
Auto-Submit: Peter Kasting <[email protected]>
Reviewed-by: Peter Boström <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035518}
nit: Remove deprecated comment from LacrosService
This comment should have been removed in crrev.com/c/3580292.
Change-Id: I4ad57940d8fd05ca2d3e0f584e5f58825985b561
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3829764
Reviewed-by: Hidehiko Abe <[email protected]>
Commit-Queue: Hidehiko Abe <[email protected]>
Auto-Submit: Eriko Kurimoto <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035517}
[PageInfo] Add data flow for number of sites
Add functions to LocalSharedObjectsContainer for
counting the number of allowed sites and
third-party blocked sites.
Bug: 1346305
Change-Id: Id70b1c49d1373caf806065355f2f62684480b4b5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3816642
Reviewed-by: Olesia Marukhno <[email protected]>
Commit-Queue: Zofia Salata <[email protected]>
Reviewed-by: Christian Dullweber <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035516}
Suppress VideoStreamFromWebGLCanvas tests on more bots.
The tests were timeout on Nexus 5 and Linux AMD RX 5500 XT bots.
Bug: 1353189
Change-Id: Ib4549bca6a981b1ed87f0f5084c9930afcc37af1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832305
Reviewed-by: Kenneth Russell <[email protected]>
Commit-Queue: Alexis Hétu <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035515}
Initial STG sync conversions.
Provides a way to convert from the sync representation of a saved tab
group into a c++ representation and back.
Change-Id: I13722ab3f24433ef28e2955c044710be8de4e382
Bug: 1343403
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3812121
Commit-Queue: Darryl James <[email protected]>
Reviewed-by: Marc Treib <[email protected]>
Reviewed-by: David Pennington <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035514}
Roll Chrome Win64 PGO Profile
Roll Chrome Win64 PGO profile from chrome-win64-main-1660640381-bb07ef06f78c53431d2f66258e20d7cc7462fb96.profdata to chrome-win64-main-1660650975-11c0305a3d05e803f31899ae4eaf2cadee7a5b99.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win64-chrome
Tbr: [email protected]
Change-Id: I6f6f360b9a58a6905f5faa7fbabd19951a455d9d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3833012
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035513}
Updating trunk VERSION from 5244.0 to 5245.0
* This is an automated release commit.
* Do not revert without consulting [email protected].
NOAUTOREVERT=true
Change-Id: I64daf881bd4a1207d97621cfc892c33c00af22f8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3833970
Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1035512}
[CodeHealth] Replace DictionaryValue::GetString in /chrome/browser/ui/startup.
This CL was uploaded by git cl split.
[email protected]
Bug: 1187036
Change-Id: Idfd808db3810f8e318bd394e9af85c0825d4c980
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3828603
Reviewed-by: Greg Thompson <[email protected]>
Auto-Submit: Brian Begnoche <[email protected]>
Commit-Queue: Brian Begnoche <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035511}
Roll src-internal from 57dca236c848 to 4673f17429b7 (6 revisions)
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/57dca236c848..4673f17429b7
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: chromium:1342977,chromium:1347390,chromium:1351735
Tbr: [email protected],[email protected]
Change-Id: I7fbb2e501dc3f3e2afb876934749925b8943c1b6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3833847
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1035510}
HighlightOverlayPainting: fix ‘text-decoration-skip-ink’
Underlines skip descenders when ‘text-decoration-skip-ink’ is ‘auto’,
but this relies on NGTextPainter having the correct range to compute
the text intercepts over. NGTextPainter is stateful, with a mutable
NGTextFragmentPaintInfo that affects things like the calculation of
text intercepts for skip ink.
This is generally not a problem, but for highlight painting we break
the text fragment into parts, often painting text for one range then
decorations for another. This means we might compute text intercepts
for the wrong range.
This patch fixes that bug by eliminating the NGTextFragmentPaintInfo
field, making functions that need one take it as an argument.
To make it easier to safely slice NGTextFragmentPaintInfo, we add
methods to do that while checking that the new range is a subrange of
the old range. That way, any guarantees the caller wants to make about
the StringView and/or ShapeResultView in the old instance remain true
for the new instance (for example, some callers don’t care if there’s
a valid ShapeResultView, and sometimes it’s nullptr).
To avoid messy template member functions, we duplicate a small method
(PaintDecorationUnderOrOverLine) for legacy, and move two others from
TextPainterBase into a new NGTextPainterBase, which contains LayoutNG-
specific code shared between NGTextPainter and NGTextCombinePainter.
Fixed: 1350469
Change-Id: Ic51ff58da4e2a80bae2527f7ea90b57b9e361000
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3820621
Reviewed-by: Philip Rogers <[email protected]>
Commit-Queue: Delan Azabani <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035509}
Revert "OOBE: Include ConsolidatedConsent screen in OOBE metrics"
This reverts commit ee54fadeb7edb490620931e72f13620901d39297.
Reason for revert: I suspect this CL causes failures
TrayAccessibilityLoginTestInstance/TrayAccessibilityLoginTest.ShowMenuWithShowOnLoginScreen/1
SystemTrayClientEnterpriseAccountTest.TrayEnterpriseManagedAccount
TrayAccessibilityLoginTestInstance/TrayAccessibilityLoginTest.ShowMenuWithShowOnLoginScreen/0
SystemTrayClientEnterpriseAccountTest.TrayEnterpriseUnmanagedAccount
...2 more failure(s) (6 total)...
https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests/29843/overview
Original change's description:
> OOBE: Include ConsolidatedConsent screen in OOBE metrics
>
> Include Consolidated Consent Screen in the following UMA histograms:
> - OOBE.StepShownStatus
> - OOBE.StepCompletionTime
> - OOBE.StepCompletionTimeByExitReason
>
> Bug: b/242679991
> Change-Id: Ia4bc7aa08be9561341c8df63e716614806273d3e
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832661
> Reviewed-by: Roman Sorokin <[email protected]>
> Commit-Queue: Osama Fathy <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1035452}
Bug: b/242679991
Change-Id: Ib1e1d767d23d6cfee23268dc3cc7cf6e03e40d3f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834243
Owners-Override: Maxim Kolosovskiy <[email protected]>
Commit-Queue: Osama Fathy <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Reviewed-by: Maxim Kolosovskiy <[email protected]>
Reviewed-by: Osama Fathy <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035508}
Refactor UKM StoreRecordingsInReport().
Creates a couple helper functions to reduce the length of the
calling function.
No logic changes.
We are getting some crash reports in this function, so this may
help narrow down where in the code it's happening, but is also a
good clean up on its own.
Bug: 1351337
Change-Id: I85773ebd284c3a5c4f0bff07d379a101916701ce
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832694
Commit-Queue: Alexei Svitkine <[email protected]>
Reviewed-by: Robert Kaplow <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035507}
[docs][fuchsia-binary-size] Add info on resolving growth issues.
Add:
- Comment to add near ifdef/build variables used to extract a feature
- updates fuchsia-dev email
- properly links Chromium binary-size docs.
Bug: 1353061, 1302137
Change-Id: Ia2561656f14edf63604cb987cc0c6a671c569851
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3825984
Commit-Queue: Rohan Pavone <[email protected]>
Reviewed-by: David Dorwin <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035506}
Roll Dawn from c81cefe06ea4 to dadb934e1978 (1 revision)
https://dawn.googlesource.com/dawn.git/+log/c81cefe06ea4..dadb934e1978
2022-08-16 [email protected] Roll vulkan-deps from fb0e26499a68 to 863822794aa7 (3 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dawn-chromium-autoroll
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel
Bug: None
Tbr: [email protected]
Change-Id: I56c6e79da48e5456f3ce83a6170c378ad54d2764
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3833440
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035505}
Revert "Make compound backing work with GLTextureImageBacking"
This reverts commit 8d6fa86174dda68bdfa7b42e19369e3a083284c2.
Reason for revert: Broken video on Windows. crbug.com/1353343
Original change's description:
> Make compound backing work with GLTextureImageBacking
>
> Make GLTextureImageBacking work with compound image backing and have it
> replace GLImageBacking for shared memory GMBs.
> GLTextureImageBackingFactory ignores scanout usage for shared memory
> GMBs to match existing behaviour in GLImageBackingFactory.
>
> This also removes the GLImageBackingFactory functionality to work with
> shared memory GMBs and having two instances of the factory.
> Unfortunately GLTextureImageBackingFactory needs two instances, one for
> regular GL textures and one for shared memory GMBs, to ensure we pick
> the right backing type on Windows. This should be a temporary state
> until usage flags to specify when D3D backing, eg. supporting
> CopyToGpuMemoryBuffer() and ProduceMemory() for overlay path, are needed
> get added.
>
> Bug: 1293509
> Change-Id: I6eb071c8b27f92a2cbcafbb6145f4c05ce04c000
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3774213
> Reviewed-by: Vasiliy Telezhnikov <[email protected]>
> Commit-Queue: Kyle Charbonneau <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1035129}
Bug: 1293509, 1353343
Change-Id: I9c07a7574b5ddd3c000742b30ea2bf1369956fe7
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3831244
Auto-Submit: Kyle Charbonneau <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Reviewed-by: Vasiliy Telezhnikov <[email protected]>
Commit-Queue: Vasiliy Telezhnikov <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035504}
[CodeHealth] Replace DictionaryValue::GetString in /chrome/browser/device_identity.
This CL was uploaded by git cl split.
[email protected]
Bug: 1187036
Change-Id: Ib1b8dc744885694580a13e176ff79ef18bfee6fa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3828233
Commit-Queue: Igor <[email protected]>
Reviewed-by: Igor <[email protected]>
Auto-Submit: Brian Begnoche <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035503}
OOBE - Remove stale Polymer2 code
Polymer2 is disabled and the files are no longer used.
The removal of .html/.js files from BUILD.gn is because
we already have the .m.js versions of these files there.
Bug: 1184731
Change-Id: Ifb567c87ac7ff44a79367419aa9ebc14de832ed6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3827440
Reviewed-by: Danila Kuzmin <[email protected]>
Commit-Queue: Renato Silva <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035502}
[fileSystem API] FileSystemApiConsentProviderTest: Extract TestDelegateState.
ConsentProvider is used by chrome.fileSystem APIs to query and request
user permissions re. file system access. We plan to refactor it to have
a lifetime matching a request, instead of being temporary. This in turn,
will require a ConsentProvider::DelegateInterface to be owned by a
ConsentProvider instance, and become opaque.
FileSystemApiConsentProviderTest uses TestingConsentProviderDelegate to:
* Assign fake results.
* Store function call counts for later retrieval.
Having ConsentProvider own the delegate gets in the way of the above.
This CL updates the test to prepare for the planned change. The
approach is to define (test only) TestDelegateState local to each
test, and inject its pointer into TestingConsentProviderDelegate.
This allows the latter to remain opaque, while still allowing the test
to write / read states it needs.
More changes will follow once we make ConsentProvider own the
delegate.
Bug: 1351493
Change-Id: I3939ecb0011947473b7c021c9664dc30f44fd26c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3827074
Reviewed-by: Josh Simmons <[email protected]>
Commit-Queue: Samuel Huang <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035501}
Updating XTBs based on .GRDs from branch main
Change-Id: Ib6faabdc4cb152d3d21f37a845ee15f04acd433c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834067
Auto-Submit: Ben Mason <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035500}
Automatic update from google3
Automatic update for 2022-08-16 UTC
Change-Id: Iff9cbe36e427333365fcdeefc33bb4cd33aa486c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3829524
Commit-Queue: PKI Metadata Updates Bot <[email protected]>
Bot-Commit: PKI Metadata Updates Bot <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035499}
[Code health] Avoid Value::GetAsDictionary (in /content/browser/media)
This method is deprecated, so port away from it, along with other nearby deprecated base::Value APIs that can be modernized at least somewhat locally.
This CL was uploaded by git cl split.
Bug: 1187011
Change-Id: Ib133af7d8d72280132437010e41a610abc708db2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3826009
Commit-Queue: Maks Orlovich <[email protected]>
Reviewed-by: Mark Foltz <[email protected]>
Auto-Submit: Maks Orlovich <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035498}
Truncate partially downloaded file before retrying
When retrying to download the file after an error during download, do
not just append to whatever was previously written. This would lead to
an invalid archive. Instead, reset file position and truncate its size.
Bug: 1352949
Change-Id: Ie774b8b1ba619c549f46f5da359d6dcafd595486
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3826252
Reviewed-by: Nico Weber <[email protected]>
Commit-Queue: Nico Weber <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035497}
[Autofill] Move CreditCard{CVC,Otp}Authenticator to AutofillClient.
This CL moves the CreditCard{CVC,Otp}Authenticator members from
CreditCardAccessManager, which has one instance per frame, to
[Chrome]AutofillClient, which has one instance per tab.
This eliminates a questionable WebContents::GetPrimaryMainFrame()
call in Autofill Assistant.
This also slightly simplifies testing (the test authenticators now
live in TestAutofillClient rather than the production class).
Bug: 1352283, 1352280, 1294378
Change-Id: I949219a53a9e40c8f012e9b28fa3aa321501ee40
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3826312
Reviewed-by: Gauthier Ambard <[email protected]>
Commit-Queue: Christoph Schwering <[email protected]>
Reviewed-by: Jared Saul <[email protected]>
Reviewed-by: Mohamed Amir Yosef <[email protected]>
Reviewed-by: Florian Gauger <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035496}
Migrate java version to 11 for generated gradle files
Chromium moved to java 11 support in crrev.com/c/3788903.
This CL updates the generated gradle files for Android studio to
indicate support for 1.11 features.
Change-Id: I5686f5334bf6604d9dbfae0df8a4a4af062f0ad4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3826136
Auto-Submit: Peter Pakkenberg <[email protected]>
Reviewed-by: Andrew Grieve <[email protected]>
Commit-Queue: Andrew Grieve <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035495}
Reset expectations for attribution WPT tests
There have been a number of recent changes to these tests that should
make them pass (more) consistently, and it would be useful to
redetermine which, if any, are still flaky.
Bug: 1322004, 1340981
Change-Id: I8eba83c25878cc878ff4703c334a3aa5b756f41b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3831313
Commit-Queue: Andrew Paseltiner <[email protected]>
Reviewed-by: Nan Lin <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035494}
Settings: Password View page waits for visibility for the first launch
Bug: 1345899
Change-Id: I0526fd4f9c1c5497563cd7c9b4391ebfcb5ea50d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3826126
Commit-Queue: Adem Derinel <[email protected]>
Reviewed-by: Viktor Semeniuk <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035493}
Settings: Password View page uses requestCredentialDetails
This CL introduces requestCredentialDetails API to password view page. The API is used to retrieve the full credential when:
- the user clicks to a password list item in chrome://settings/passwords
- opens the view page with URL chrome://settings/passwords/view?id=xy
MergePasswordsStoreCopiesMixin is not required in the page anymore.
Bug: 1345899
Change-Id: I253497da6399e34abacf631a787df73dc854a015
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3792013
Reviewed-by: Viktor Semeniuk <[email protected]>
Commit-Queue: Adem Derinel <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035492}
Automatic update from google3
Automatic update for 2022-08-16 UTC
Change-Id: I4d4b77fca4d64b3d77ffd40d988c6ce3d81a5d24
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832821
Bot-Commit: PKI Metadata Updates Bot <[email protected]>
Commit-Queue: PKI Metadata Updates Bot <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035491}
Roll Chrome Linux PGO Profile
Roll Chrome Linux PGO profile from chrome-linux-main-1660629591-c41d73b0894d26e63bf93c2dd833194e279b4c35.profdata to chrome-linux-main-1660650975-0429cc669493803dc7829079efcbdbb7910f7af8.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-linux-chromium
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:linux-chrome
Tbr: [email protected]
Change-Id: I9f5e26ffaa46779f27acabe4501cd605a8de7dc3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3833444
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035490}
Roll DevTools Frontend from 17217b35eafe to 8320c7d9e53e (3 revisions)
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/17217b35eafe..8320c7d9e53e
2022-08-16 [email protected] Add feedback links to experiments settings panel
2022-08-16 [email protected] Update protocol resources
2022-08-16 [email protected] Remove authored/deployed experiment banner
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: [email protected]
Change-Id: I52a2e7d597798e13bdb89f55d7927a937b52b3e4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3834008
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035489}
[reclient] Switch Comparison Mac Builders To Trusted Test
Run Comparison Mac (reclient), Comparison Mac arm64 (reclient), and
Comparison ios (reclient) against rbe trusted test instance instead of
trusted.
Bug: b/242206117
Change-Id: I7f756398169d31f4a24bc7e7adc23db2d145cc84
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3827490
Commit-Queue: Andus Yu <[email protected]>
Reviewed-by: Garrett Beaty <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035488}
[DownloadBubble] Add/revive metrics download file type metrics
This CL adds a metric to count the file types of opened download. Also
revives older metrics to count file types of initiated downloads.
Rename a few methods and comments to reflect their functionality.
Bug: 1352120
Change-Id: Ic1509b9cf157f8e48099cf8c84cf72ac3b09f842
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3826703
Reviewed-by: Xinghui Lu <[email protected]>
Commit-Queue: Rohit Bhatia <[email protected]>
Reviewed-by: Min Qin <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035487}
[Affiliation service] Using KeepPrefetchForFacets instead of N Prefetches
KeepPrefetchForFacets was implemented for OnLoginsRetained, but can be
used here as well.
Bug: 1352457
Change-Id: I2f61d8b90efd38aed3ba872a09c158f633963962
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3828903
Commit-Queue: Viktor Semeniuk <[email protected]>
Reviewed-by: Vasilii Sukhanov <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035486}
RasterInterface::ConvertYUVAMailboxesToRGB: Make color param optional
Allow specifying nullptr as a parameter to ConvertYUVAMailboxesToRGB,
and make that which disable color space conversion entirely. Add a
for this behavior.
This had previously been reverted due to a mid-air collision with
changes related to crrev.com/1034023.
Change-Id: I3b874f670ec8bdf5aee819f48530e33f0e8daab3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3826315
Reviewed-by: Zhenyao Mo <[email protected]>
Commit-Queue: ccameron chromium <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035485}
[iOS] Add read more button to unfold URL in Incognito Interstitial
A new button is added in the Incognito interstitial so as to let the
user unfold the URL that is to be opened, rather than display it in its
entirety by default. It is now limited to 3 lines, and then only when
the user taps the "more" button this limit is removed. In order to have
more control over how the URL is displayed, the `subtitleText` of the
`PromoStyleViewController` is left empty and the Incognito interstitial
view controller has its own `urlText` property which is displayed in a
custom label located in the `PromoStyleViewController`'s specific
content view. A gradient view is also added on the leading end of the
new button.
Also the `PromoStyleViewController` is fixed to ensure the banner image
size is re-computed when some related properties are set.
Change-Id: I757ef0094eb9ebba7ec604b051c6d905f5dadfa6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3825909
Commit-Queue: Quentin Pubert <[email protected]>
Reviewed-by: Mark Cogan <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035484}
Import wpt@bcdff15b0e933ac8e785aad2c7a5f6a4ca85fd1f
Using wpt-import in Chromium 386f980ee8406dc01b4c7b196d1203e4e25f3240.
Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md
NOAUTOREVERT=true
[email protected]
No-Export: true
Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-input-fyi-rel,linux-blink-rel
Change-Id: I7303eaf76463cb0e2dfa2904e973ea19e8d65240
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3831927
Bot-Commit: Rubber Stamper <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Auto-Submit: WPT Autoroller <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035483}
Synthetic field trial for ReportProgressAction
To monitor stability once we are ready to use it in flows.
Bug: b/209384145
Change-Id: Ic60f3777a25c86b14587a32a62cc2919f3bba0bc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3825940
Commit-Queue: Julie Hockett <[email protected]>
Reviewed-by: Florian Gauger <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035482}
Add security sheriff docdetail to convert Bug-Security to Bug when sending to Privacy
Change-Id: Ib367746d8a16e6aa19115dfe619cca7bf7d0146d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3831535
Reviewed-by: Adrian Taylor <[email protected]>
Commit-Queue: thefrog <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035481}
Roll Skia from de7a810734f3 to f86f24288669 (2 revisions)
https://skia.googlesource.com/skia.git/+log/de7a810734f3..f86f24288669
2022-08-16 [email protected] Roll Dawn from c935b497e6da to c81cefe06ea4 (2 revisions)
2022-08-16 [email protected] Roll ANGLE from 64c652d7fde0 to 2089943b951d (2 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Cq-Do-Not-Cancel-Tryjobs: true
Bug: None
Tbr: [email protected]
Test: Test: Test: angle_perftests --gtest_filter="*lumino_city*"
Change-Id: I50ff140726b907b9b9e2d7fd024f60e5595754a9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832211
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035480}
[chrome] Fix some cpplint errors in chrome part13
chrome/browser/printing/print_job_worker.cc:54:
"components/device_event_log/device_event_log.h" already included at chrome/browser/printing/print_job_worker.cc:25 [build/include] [4]
chrome/browser/printing/print_view_manager.cc:36:
"printing/printing_features.h" already included at chrome/browser/printing/print_view_manager.cc:28 [build/include] [4]
chrome/browser/printing/print_view_manager_base.cc:67:
"components/prefs/pref_service.h" already included at chrome/browser/printing/print_view_manager_base.cc:37 [build/include] [4]
chrome/browser/privacy_sandbox/privacy_sandbox_service_unittest.cc:16:
"chrome/browser/privacy_sandbox/privacy_sandbox_service.h" already included at chrome/browser/privacy_sandbox/privacy_sandbox_service_unittest.cc:5 [build/include] [4]
Bug: None
Change-Id: Ie97d864bb02740c12934ea600b26e99311dcf7e9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3826387
Auto-Submit: Qi Tiezheng <[email protected]>
Commit-Queue: Olesia Marukhno <[email protected]>
Reviewed-by: Olesia Marukhno <[email protected]>
Reviewed-by: Rebekah Potter <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035479}
Roll src-internal from a902f4610501 to 57dca236c848 (4 revisions)
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a902f4610501..57dca236c848
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: [email protected]
Change-Id: I7d7d22211290f7bda95bb7a3c0f2e2b4bece30fc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3833577
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1035478}
Remove unused refs to MediaConstraints
Bug: 1353279
Change-Id: I3ea9031b1d3015dd53485903124d5803d4fa6e83
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3829522
Auto-Submit: Tony Herre <[email protected]>
Reviewed-by: Palak Agarwal <[email protected]>
Commit-Queue: Tony Herre <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035477}
Increase line height of the sync consent footer text for tangible sync flow
This cl changes the footer font from medium to small and adjusts the
line height with UI guidance. The bottom margin is increased from 16dp
to 24dp.
Also adds line height to the title and the subtitle.
Bug: 1352500
Change-Id: I6e6ee4b62f8475ab7f9d0f82516dba883536d24e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3822704
Reviewed-by: Boris Sazonov <[email protected]>
Commit-Queue: Tanmoy Mollik <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035476}
HighlightInheritance: fix ‘currentColor’ for all other properties
Highlight pseudos have a special case for ‘color:currentColor’, where
it means the ‘color’ of the next active highlight layer below, rather
than being equivalent to ‘color:inherit’. This not only means that the
‘color’ of a highlight might be unknown until paint determines where
the highlights are active, but so can any other property with <color>
values, thanks to ‘currentColor’.
HighlightPaintingUtils contains the logic for this, but currently only
for ‘color’ and ‘background-color’, and even then the latter is bugged
since it always checks whether the *unvisited* value is currentColor.
The general approach of having only Color-returning methods plus bool
methods telling you whether to use them is also prone to bugs, since
we can just blindly use the Color without checking.
The ideal interface for highlights is for VisitedDependentColor and
the ColorIncludingFallback methods to return optional<Color>, but we
also don’t want to penalise non-highlight code with all of these extra
optional checks, nor do we want to maintain two copies of the code.
This patch adds an optional bool out parameter to
• ComputedStyle::VisitedDependentColor
• Longhand::ColorIncludingFallback
• StyleColor::Resolve
and the helper functions
• ComputedStyle::ResolvedColor
• ComputedStyle::GetCurrentColor
• ComputedStyle::GetInternalVisitedCurrentColor
• ComputedStyle::GetInternalForcedCurrentColor
• ComputedStyle::GetInternalForcedVisitedCurrentColor
• ComputedStyleUtils::BorderSideColor
• StyleColor::ResolveWithAlpha
that (if present) indicates whether the property that was ultimately
chosen was ‘currentColor’, while resolving the color as usual. We also
remove the old functions for handling ‘currentColor’ in highlights:
• ComputedStyle::IsBackgroundColorCurrentColor
• ComputedStyle::VisitedDependentColorIsCurrentColor
This in turn allows us to create HighlightPaintingUtils::ResolveColor,
which encapsulates the “property color or this layer currentColor or
previous layer currentColor or originating currentColor” dance.
While this patch won’t completely prevent misuse of the Color-based
interface, the new helper in HighlightPaintingUtils should at least
make the correct logic easy enough to discourage it.
Bug: 1295264
Change-Id: Ic0e5ee6787162b33172b9f7023e404c82be1b14d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3781986
Commit-Queue: Delan Azabani <[email protected]>
Reviewed-by: Anders Hartvoll Ruud <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035475}
DanglingPtr: fix dangling ptr in View
Remove all references to `child` before deleting it to avoid holding
a dangling ptr.
Bug: 1291138
Change-Id: Ib571e6d9039f13133b51ff2b9dc6b89e5cce7725
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3825955
Reviewed-by: Keren Zhu <[email protected]>
Commit-Queue: Ali Hijazi <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035474}
[iOS][Omnibox] Update paste control accessibility
Paste control uses a UIPasteControl that sets a default accessibility
label, set the accessibility hint instead.
Bug: 1349530
Change-Id: I509a421779e3b8afe44a7a0c709c939758a24144
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3829507
Commit-Queue: Christian Xu <[email protected]>
Auto-Submit: Christian Xu <[email protected]>
Commit-Queue: Stepan Khapugin <[email protected]>
Reviewed-by: Stepan Khapugin <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035473}
[cronet] Fixes and cleanup
1. Fix CronetTestRule's getMaximumAvailableApiLevel method
The method was comparing the cronet version lexicographically and
thus started failing from M100
a. Also fix failures from previously skipped tests.
2. Use @RequiresMinAndroidApi where needed instead of an if statement.
Bug: b:241240440
Change-Id: Iaf4582d51e8d72283ef1c126311e085241722862
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3805213
Reviewed-by: Stefano Duo <[email protected]>
Commit-Queue: Chidera Olibie <[email protected]>
Commit-Queue: Stefano Duo <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035472}
PageLoadMetrics: Prerender2 support for AMPPageLoadMetricsObserver
If a page starts as a prerendered page, AMPPageLoadMetricsObserver needs
to be silent til the page is activated, and records metrics only if the
page is activated.
This CL makes AMPPageLoadMetricsObserver work for prerendered pages.
UMAs *.AMP.* now include samples from prerendered pages, but metrics are
not affected by this change because metrics are user action triggered or
not related to load timing. So, this CL doesn't rename these histograms.
Bug: 1317494
Change-Id: I876c20ad1d872584a2a5092c0e2fc949273a0e27
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3810731
Reviewed-by: Annie Sullivan <[email protected]>
Reviewed-by: Kouhei Ueno <[email protected]>
Reviewed-by: Takashi Toyoshima <[email protected]>
Commit-Queue: Ken Okada <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035471}
Revert "Add LowPriorityAsyncScriptExecution feature"
This reverts commit f1b02444b28530edceca3d2edb9c5fdb6fb5410a.
Reason for revert: I suspect that this CL caused a failure of virtual/threaded-no-composited-antialiasing/animations/sample-on-last-keyframe.html (time out)
The first failed build: https://ci.chromium.org/ui/p/chromium/builders/ci/mac11-arm64-rel-tests/8756/overview
Original change's description:
> Add LowPriorityAsyncScriptExecution feature
>
> This CL adds LowPriorityAsyncScriptExecution feature. The basic idea of
> LowPriorityAsyncScriptExecution is to run async script when the main
> thread is doing nothing. But at the same time, we want to avoid waiting
> too long to run async scripts. So this CL also adds a timeout mechanism.
>
> Design Doc:
> https://docs.google.com/document/d/1RNSiQS3fG2olC52RRJ6Y7jY9LjWKn5Z2HZ3b9Qp0nmw/edit#bookmark=id.dr5ecxnx2kco
>
> Bug: 1348467
> Change-Id: I06cad47e540da307046a105f6e737bced83cbf04
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3793626
> Reviewed-by: Kouhei Ueno <[email protected]>
> Commit-Queue: Minoru Chikamune <[email protected]>
> Reviewed-by: Kentaro Hara <[email protected]>
> Reviewed-by: Alexander Timin <[email protected]>
> Reviewed-by: Scott Haseley <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1035376}
Bug: 1348467
Change-Id: I10f02865dcd9901e2055d1efaa0109f6e8719856
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3830020
Owners-Override: Maxim Kolosovskiy <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Reviewed-by: Maxim Kolosovskiy <[email protected]>
Auto-Submit: Maxim Kolosovskiy <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035470}
Fix OomScorePolicyLacros::GetUniqueSortedPids NULL dereference
Bug: 1352835
Change-Id: I22aef3e1288fcf36dbc4b2d7c55d8a1c80e1f89b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3833254
Commit-Queue: Vovo Yang <[email protected]>
Reviewed-by: Patrick Monette <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035469}
Roll Perfetto from 079afe8d24d8 to e3ae1b28af66 (1 revision)
https://android.googlesource.com/platform/external/perfetto.git/+log/079afe8d24d8..e3ae1b28af66
2022-08-16 [email protected] Project import generated by Copybara.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel
Bug: None
Tbr: [email protected]
Change-Id: I9bd80e84c0cc2814a6a5c6d8a2ee7b598a40a110
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832684
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035468}
Consistent border-spacing truncation.
With this change, we'll treat border-spacing pretty much like margins,
as far as block fragmentation is concerned. That is, we'll now truncate
them at fragmentainer boundaries. This also includes border-spacing
before repeated table headers, which affects quite a few tests in
fragmentation/ and printing/. Set border-spacing to 0 in some tests (and
compensate by adding padding to the table cells where it makes sense, so
that we don't affect the block-size of the contents too much (which
would require bigger test rewrites)).
Also add new tests that use non-zero border-spacing. They are marked as
tentative, since exact behavior here is undefined.
Bug: 1335870
Change-Id: I230d33cb165276dba044158cd97b892844bf8ac3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3829558
Commit-Queue: Morten Stenshorne <[email protected]>
Reviewed-by: Anders Hartvoll Ruud <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035467}
[TangibleSync] Add variation strings for tangible sync view
This cl adds a title and a subtitle variation for tangible sync consent
view. These different views are configured by finch field trial param.
This cl thus modifies the existing flag setup to field trial with
params.
This cl also adds tests for these two different views. The
@DisableFeature annotation has also been moved from the class level to
the test level. Otherwise the test configuration for field trial tests
were getting overridden by the class level annotation.
Bug: 1332527
Change-Id: I4efb511c159aec14320944f3497667cc5e8dfa25
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3825875
Reviewed-by: Boris Sazonov <[email protected]>
Commit-Queue: Tanmoy Mollik <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035466}
Add comments for DelayAsyncScriptExecution crbug link
This is a follow up CL of https://crrev.com/c/3816163 to add crbug link.
Bug: 1340837
Change-Id: I15b33990fbaa124438c56c1dddadf5c5002ea240
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3831144
Commit-Queue: Minoru Chikamune <[email protected]>
Reviewed-by: Kouhei Ueno <[email protected]>
Commit-Queue: Kouhei Ueno <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035465}
[DevTools] Temporarily disable test
FE CL: https://crrev.com/c/3543151
Re-enable test CL: https://crrev.com/c/3828228
Bug: 1309310
Change-Id: I2a302090d05ce3b576030ef8788263a97a00d08b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3829238
Reviewed-by: Alex Rudenko <[email protected]>
Commit-Queue: Wolfgang Beyer <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035464}
Revert "[BrowserFragment] Programmatically create Tabs"
This reverts commit cbb1a41de09da72b667371b9a85513608be1fbe7.
Reason for revert:
Findit (https://goo.gl/kROfz5) identified this CL at revision cbb1a41de09da72b667371b9a85513608be1fbe7 as
the culprit for failures in the continuous build including:
Sample Failed Build: https://ci.chromium.org/b/8805679527446973857
Sample Failed Step: compile
If it is a false positive, please report it at https://bugs.chromium.org/p/chromium/issues/entry?status=Available&comment=Datastore+key+for+the+culprit+entity%3A+chromium.googlesource.com%2Fchromium%2Fsrc%2Frefs%2Fheads%2Fmain%2Fcbb1a41de09da72b667371b9a85513608be1fbe7&labels=Test-Findit-Wrong&components=Tools%3ETest%3EFindIt&summary=Wrongly+blame+cbb1a41de09da72b667371b9a85513608be1fbe7
Original change's description:
> [BrowserFragment] Programmatically create Tabs
>
> - Sets FOREGROUND_TABS by default to active.
> - Add create Tab function to create tabs in the background
> - Update BrowserFragment-shell to demonstrate preloading of tab content.
>
> Change-Id: I892f58f7a72700a897a2951ac5101de5a7ef5909
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3811218
> Commit-Queue: Susanne Westphal <[email protected]>
> Reviewed-by: Rayan Kanso <[email protected]>
> Reviewed-by: Robert Sesek <[email protected]>
> Reviewed-by: Clark DuVall <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1035448}
Bug: 1353317
Change-Id: I6a6e0af666b18d189c90b81bfec3348829f9e93d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832065
Owners-Override: Maxim Kolosovskiy <[email protected]>
Owners-Override: Boris Sazonov <[email protected]>
Commit-Queue: Boris Sazonov <[email protected]>
Commit-Queue: Susanne Westphal <[email protected]>
Reviewed-by: Maxim Kolosovskiy <[email protected]>
Reviewed-by: Susanne Westphal <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035463}
Have MSC sync its own enabled state with its platform_track
Remove the odd DidSetMediaStreamTrackEnabled() MSTImpl method, instead
making the MediaStreamComponent do its own syncing of enabled state with
its platform track.
Bug: 1302689, 1288839
Change-Id: Ib8384739fbe13da0442d9dd38a84b3371c6dafcb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832216
Reviewed-by: Tove Petersson <[email protected]>
Commit-Queue: Tove Petersson <[email protected]>
Auto-Submit: Tony Herre <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035462}
Roll Chrome Win64 PGO Profile
Roll Chrome Win64 PGO profile from chrome-win64-main-1660629591-667bcb25d42812c6a6bf104fbca4383de3391c34.profdata to chrome-win64-main-1660640381-bb07ef06f78c53431d2f66258e20d7cc7462fb96.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win64-chrome
Tbr: [email protected]
Change-Id: I189450a90c51966ab429b82a23967b56563e9f09
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3833359
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035461}
Roll WebRTC from 8810a93ade13 to 7cbd8dee7bf3 (2 revisions)
https://webrtc.googlesource.com/src.git/+log/8810a93ade13..7cbd8dee7bf3
2022-08-16 [email protected] Prefer use of time controller main thread to run loop
2022-08-16 [email protected] Update WebRTC code version (2022-08-16T04:04:57).
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in WebRTC: https://bugs.chromium.org/p/webrtc/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: [email protected]
Change-Id: I32856808a7c1d08944e44624534b443d64d6b189
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3833835
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035460}
Update V8 to version 10.6.175.
Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/ea1e4173..9b476953
Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues
Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_chromeos_msan_rel_ng
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel
[email protected],[email protected],[email protected]
Change-Id: I3799d164db15c8fff33eba2cfcbe7fcc8de66c93
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3833496
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1035459}
Direct Sockets API: Reject |closed| with the same exception as readable/writable streams.
This CL changes the way |closed| promise is rejected: now it will mirror the rejection of reason of either [[readable]] or [[writable]] (whichever comes first). An example can be found here: https://wicg.github.io/direct-sockets/#dfn-handle-closing-the-tcp-writable-stream
Bug: 1345262
Change-Id: Ibcce469b35b08ce35de2f83afe7567c645f5a13d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3779544
Reviewed-by: Reilly Grant <[email protected]>
Commit-Queue: Andrew Rayskiy <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035458}
[fieldtrials] Add ForwardMemoryPressureEventsToGpuProcess to config
Enable ForwardMemoryPressureEventsToGpuProcess by default on bots, as
required to start a beta channel experiment.
Bug: 1329375
Change-Id: I21e7c151b39c592927686cdf3275a26e22eb6aab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3827213
Reviewed-by: Alex Ilin <[email protected]>
Commit-Queue: Benoit Lize <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035457}
[Autofill Assistant] Synthetic Trial for QrCodeScan
Register Synthetic field trials for Data Input via
QR Code Scanning in Autofill Assistant. Will be used
to measure stability.
Bug: b/241889107
Change-Id: I5b7f099a96f9fd69d6942a76c2cf43a51b19099a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3827926
Commit-Queue: Shashank Jain <[email protected]>
Reviewed-by: Florian Gauger <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035456}
CrOS VCD: Enable auto-framing by default
Make chrome://flags#auto-framing-override flag defaults to enabled. Note
that the feature is still guarded by per-device feature profile.
Bug: b:210929757, b:221980963
Test: Toggle chrome://flags#auto-framing-override and check behavior.
Change-Id: I6b477be98dc75336cce2fd3841dc2d0d487dc7d9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832988
Auto-Submit: Ren-Pei Zeng <[email protected]>
Reviewed-by: Shik Chen <[email protected]>
Commit-Queue: Ren-Pei Zeng <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035455}
[iOS] Change cancel button string in send-tab-to-self sign-in promo
The string should be "Cancel" instead of "Skip".
Bug: 1264471
Change-Id: I59a63a5b6f480ca3e0866f628090777bfba28e29
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3829703
Reviewed-by: Jérôme Lebel <[email protected]>
Commit-Queue: Jérôme Lebel <[email protected]>
Auto-Submit: Victor Vianna <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035454}
SAML username Autofill: remove url filtering
There was a last minute design change to allow admins to specify url
parameterm manually through a device policy (instead of only allowing
predefined values). This should allow them to use autofill feature with
any IdP, but that implies that we can't have any url filtering on the
client side as we no longer have a predefined list of supported IdPs. So
this CL removes limitations on IdP login page url. See
go/cros-saml-username-autofill-dd (internal link) for more details.
This cl also removes corresponding tests but instead adds tests with a
generic IdP url.
Bug: 1298675
Test: browser tests SamlUsernameAutofillUnitTest*
Change-Id: I0e9fa5369c9791e2a5a942538860fc5479df09dc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3829551
Commit-Queue: Andrey Davydov <[email protected]>
Reviewed-by: Roman Sorokin <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035453}
OOBE: Include ConsolidatedConsent screen in OOBE metrics
Include Consolidated Consent Screen in the following UMA histograms:
- OOBE.StepShownStatus
- OOBE.StepCompletionTime
- OOBE.StepCompletionTimeByExitReason
Bug: b/242679991
Change-Id: Ia4bc7aa08be9561341c8df63e716614806273d3e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832661
Reviewed-by: Roman Sorokin <[email protected]>
Commit-Queue: Osama Fathy <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035452}
History Sync: Add columns to VisitAnnotationsDatabase
This CL adds a number of additional annotation columns, in both the
context and the content annotations tables.
For now, the new columns are required only for Sync, but in the future
some of them will likely also be used locally.
Bug: 1347012
Change-Id: I5ecf33c9ebd67acf3436dac1e718730b0c3f7722
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3825961
Reviewed-by: Tommy Li <[email protected]>
Commit-Queue: Marc Treib <[email protected]>
Reviewed-by: Sophie Chang <[email protected]>
Reviewed-by: Scott Violet <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035451}
[iOS] CBD don’t disconnect user
Tested:
* enable enable-cbd-sign-out
* start Chrome disconnected
* go to www.google.com
* connect
* open settings
* open privacy and security
* open Clear Browsing Data
* click on Clear Browsing Data
* click on Clear Browsing Data
* check that you’re still signed-in
Bug: 1351660
Change-Id: Ibcb8dc2c39f76b2caf6b058aed4d52223fe41143
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3829152
Reviewed-by: Jérôme Lebel <[email protected]>
Commit-Queue: Arthur Milchior <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035450}
[chrome] Fix some cpplint errors in chrome part15
chrome/browser/renderer_context_menu/render_view_context_menu.cc:205:
"chrome/browser/apps/app_service/app_launch_params.h" already included at chrome/browser/renderer_context_menu/render_view_context_menu.cc:37 [build/include] [4]
chrome/browser/resource_coordinator/tab_activity_watcher_unittest.cc:14:
"chrome/browser/resource_coordinator/tab_activity_watcher.h" already included at chrome/browser/resource_coordinator/tab_activity_watcher_unittest.cc:5 [build/include] [4]
chrome/browser/resource_coordinator/tab_manager.cc:41:
"chrome/browser/resource_coordinator/tab_manager.h" already included at chrome/browser/resource_coordinator/tab_manager.cc:5 [build/include] [4]
chrome/browser/rlz/chrome_rlz_tracker_delegate.cc:46:
"base/command_line.h" already included at chrome/browser/rlz/chrome_rlz_tracker_delegate.cc:9 [build/include] [4]
chrome/browser/safe_browsing/download_protection/file_analyzer_browsertest.cc:20:
"chrome/browser/safe_browsing/download_protection/document_analysis_service.h" already included at chrome/browser/safe_browsing/download_protection/file_analyzer_browsertest.cc:12 [build/include] [4]
chrome/browser/safe_browsing/tailored_security/chrome_tailored_security_service.cc:27:
"chrome/browser/ui/browser_finder.h" already included at chrome/browser/safe_browsing/tailored_security/chrome_tailored_security_service.cc:12 [build/include] [4]
Bug: None
Change-Id: I5cafc9123996083648b3a676747e3f0c1d44c6e9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3827460
Auto-Submit: Qi Tiezheng <[email protected]>
Reviewed-by: Daniel Rubery <[email protected]>
Commit-Queue: Alex Ilin <[email protected]>
Reviewed-by: Alex Ilin <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035449}
[BrowserFragment] Programmatically create Tabs
- Sets FOREGROUND_TABS by default to active.
- Add create Tab function to create tabs in the background
- Update BrowserFragment-shell to demonstrate preloading of tab content.
Change-Id: I892f58f7a72700a897a2951ac5101de5a7ef5909
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3811218
Commit-Queue: Susanne Westphal <[email protected]>
Reviewed-by: Rayan Kanso <[email protected]>
Reviewed-by: Robert Sesek <[email protected]>
Reviewed-by: Clark DuVall <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035448}
DanglingPtr: fix dangling ptr in IOBuffer
We need to make sure some internal mechanisms are not releasing the
pointer on some operations.
Bug: 1291138
Change-Id: I2d47e12c5468905040eb01df2a793a8bde9e416c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3822946
Reviewed-by: Adam Rice <[email protected]>
Commit-Queue: Paul Semel <[email protected]>
Reviewed-by: Hiroki Nakagawa <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035447}
Mitigate iOS crash.
AutofillCountry does 2 things:
- Represent a country's address requirements (e.g. is a state used?).
- Derive a translated version of a country's name.
For the latter use case, a locale is passed to the constructor.
For unknown reasons the function used to derive the translated name
causes crashes on iOS (see bug). This seems to be a bug in
GetDisplayNameForLocale, which became much more apparent with crrev.com/c/3676973 (see 100x worse in the bug description).
Fortunately, in these cases only the former feature of the class is used
and translating the name is unnecessary. Thus, for the lack of a proper
fix, the locale parameter is replaced by an absl::optional and
translating the name is skipped if absl::nullopt is passed. The locale
already had a default parameter value for the same reason, so making it
optional makes this fact more explicit.
Bug: 1349345
Change-Id: I5aedc62d385858f401bb90a3f526fb113230c9fc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3810492
Reviewed-by: Christoph Schwering <[email protected]>
Commit-Queue: Florian Leimgruber <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035446}
[CodeHealth] Omaha UI base::Value modernisation
This CL removes the use of deprecated methods from base::Value in the
omaha webui code.
Bug: 1187001
Change-Id: If3d2c7132fe8a49e82658521459776230e8a1533
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3829694
Reviewed-by: Sorin Jianu <[email protected]>
Commit-Queue: Claudio DeSouza <[email protected]>
Reviewed-by: Mike Dougherty <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035445}
Migration of chrome/ BrowserContextKeyedServiceFactory to ProfileKeyedServiceFactory Part 7
Bug: 1284664
Change-Id: Ic36cd545bc794bc0365461ec5452cde87065bebb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3798174
Reviewed-by: Alex Ilin <[email protected]>
Commit-Queue: Ryan Sultanem <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035444}
Roll DevTools Frontend from d08e7f0540c0 to 17217b35eafe (1 revision)
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/d08e7f0540c0..17217b35eafe
2022-08-16 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS (untrusted)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: [email protected]
Change-Id: I1cfcd03ab8f01990e728324a4e62cdd31bafd6ef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3833245
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035443}
Call MSC::SetImplementation directly when component has been created
Bug: 1288839
Change-Id: Ibf865d06fcf959801e84c2de0b996e79e3b1c0f9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3828086
Reviewed-by: Tony Herre <[email protected]>
Commit-Queue: Tove Petersson <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035442}
[beacon-api] Add skeleton of `PendingBeaconDispatcher`
This CL does not change any PendingBeacon's behavior yet. It is to prepare for subsequent renderer-side timeout implementation.
- Replaced `PendingBeaconHostRemote` with `PendingBeaconDispatcher`
and exported the latter as an independent class.
- Removed `timeout` from the mojom message to browser process. All
timeout behavior will be implemented on the renderer-side, according
to [1].
- Browser-side will still be responsible for making network requests. And trigger sending all beacons on page destroyed.
Design Doc: https://docs.google.com/document/d/1QIFUu6Ne8x0W62RKJSoTtZjSd_bIM2yXZSELxdeuTFo/edit?pli=1#heading=h.nxtqzwddjsbk
[1]: https://github.com/WICG/unload-beacon/issues/10#issuecomment-1189804245
Bug: 1293679
Change-Id: I04534a95d8540dd4344cc2b916a028a96ed3fbf4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3809613
Reviewed-by: Daniel Cheng <[email protected]>
Reviewed-by: Rakina Zata Amni <[email protected]>
Commit-Queue: Ming-Ying Chung <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035441}
Script executor call to ReportProgress
To be called from an action
Bug: b:209384145
Change-Id: I25fc0934cb33ab742a84e877f466a1aa96eb6cb4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3784802
Reviewed-by: Florian Gauger <[email protected]>
Commit-Queue: Julie Hockett <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035440}
Fix AutofillEnableSupportForParsingWithSharedLabels.
Label inference assigns the same label to consecutive fields, unless
the fields are encapsulated in layers of divs. This effectively disables
the shared label feature, which is looking for consecutive fields with
empty labels.
This is fixed by also looking for consecutive fields which share the
same label as the first field in the group.
The alternative way of fixing it is tweaking label inference itself.
This was attempted in crrev.com/c/3634706, but is much more involved.
Bug: 1167702
Change-Id: I907f3d6fbf7ff273624a31bb5ac93219d6af0b17
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3816805
Commit-Queue: Florian Leimgruber <[email protected]>
Reviewed-by: Christoph Schwering <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035439}
[APC Desktop] Remove unnecessary space from success string.
Bug: 1329179
Change-Id: Ida23399ffaffd2e15967e6cdacf1c79de38ff174
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3830014
Reviewed-by: Norge Vizcay <[email protected]>
Commit-Queue: Jan Keitel <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035438}
Roll Chrome Win32 PGO Profile
Roll Chrome Win32 PGO profile from chrome-win32-main-1660618751-a18a938fe3e3094e9e24d71a5f6cf4ac61b350b2.profdata to chrome-win32-main-1660629591-4c2e447a931c4be58f67e1d7c0640086f637eeee.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win-chrome
Tbr: [email protected]
Change-Id: Ie1bd878ba343e2a4e9076b7f347236835a380a4b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3833006
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035437}
Import wpt@973e3df468214169971459c358afee05d02cb8a8
Using wpt-import in Chromium 754ede9fc072c33298a8edf5ed5239f49aa5e71f.
Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md
Directory owners for changes in this CL:
[email protected]:
external/wpt/css/css-sizing
NOAUTOREVERT=true
[email protected]
No-Export: true
Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-input-fyi-rel,linux-blink-rel
Change-Id: Id770f3712cedca5cf575f335ae0f0b1317281dbd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832513
Bot-Commit: Rubber Stamper <[email protected]>
Auto-Submit: WPT Autoroller <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035436}
Add Tangible sync flow for signin row in main settings
This cl adds the tangible sync flow launch capability to the signin
preference in main settings page. This flow is guarded by a flag.
Bug: 1332527
Change-Id: I9222fa0512e1fcd55a012a9fa37853a9b66b0226
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3819763
Reviewed-by: Boris Sazonov <[email protected]>
Commit-Queue: Tanmoy Mollik <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035435}
Roll Projector App from RKov5xJycWx1T0hd_... to 5aiSSTONnl1PqtAdZ...
Release_Notes: http://go/projector_app-x20/relnotes/Main/projector_app_nightly_202208160100_RC00.html
https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/projector_app/app/+/5aiSSTONnl1PqtAdZEgAZNfRqUSl2nAlWxjfH-DGOKwC
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/projector-app-chromium-autoroll
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chrome.try:linux-chromeos-chrome
Bug: b/242600025
Tbr: [email protected]
Change-Id: I36d8d5cd589ca2618a4973b95cfa8c64fa2d52da
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3833007
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1035434}
PageLoadMetrics: Prerender2 support for MultiTabLoadingPageLoadMetricsObserver
No behavioural change.
MultiTabLoadingPageLoadMetricsObserver will be deprecated near future.
This CL makes it clear that this class doesn't support prerendering
and using STOP_OBSERVING.
Bug: 1317494
Change-Id: Ic74646870be7e268f28f706aee29f915a12bb8d2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3819224
Reviewed-by: Takashi Toyoshima <[email protected]>
Reviewed-by: Kunihiko Sakamoto <[email protected]>
Commit-Queue: Ken Okada <[email protected]>
Reviewed-by: Kouhei Ueno <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035433}
[Signin][Android] Allow real AccountInfoService in AccountManagerTestRule
Before this CL, using AccountManagerTestRule implied always using
a fake instance of AccountInfoService. This caused issues for tests
trigger sign-in, as SigninManagerImpl uses AccountInfoService to wait
for the account to be seeded. FakeAccountInfoService doesn't actually
wait for seeding to happen, so the test would try proceed with the
sign-in before the seeding is finished.
This CL addresses this issue by allowing real AccountInfoService while
using AccountManagerTestRule. To do so, null should be passed to the
AccountManagerTestRule constructor.
This CL also changes FirstRunActivitySigninAndSyncTest so it now uses
real AccountInfoService instance.
Bug: 1343837, 1352119
Change-Id: Ib8ee4b5077b2311b26a1d5524d1882832355634d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3827862
Reviewed-by: Tanmoy Mollik <[email protected]>
Commit-Queue: Boris Sazonov <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035432}
PA: Make PA a static library by default
Make PartitionAlloc library a static library by default
except for the case of component builds.
Change-Id: I12272c593a81092f148fa0df1df2b049a434a28e
Bug: 1151236
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3812483
Reviewed-by: Takashi Sakamoto <[email protected]>
Commit-Queue: Yuki Shiino <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035431}
Roll Chrome Win64 PGO Profile
Roll Chrome Win64 PGO profile from chrome-win64-main-1660618751-5486368e92053699c0d9a4e6850d07713cc17733.profdata to chrome-win64-main-1660629591-667bcb25d42812c6a6bf104fbca4383de3391c34.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win64-chrome
Tbr: [email protected]
Change-Id: Id95e96c72ee22b43a15b40a6339784dd4e68cdb6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3833635
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035430}
Only create constraint space rare data when necessary.
A mistake in CL:3829224 caused us to always create a rare data object,
whether it was necessary or not, affecting performance (and memory
usage).
This affected perf_tests/css/ChangeStyleShallowTree.html and also many
perf_tests/layout/ tests.
Bug: 1353201, 1348774, 1348725, 1352931
Change-Id: I8acff4656c8b0a538e7daa64961e0a37b469dadc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832222
Reviewed-by: Rune Lillesveen <[email protected]>
Commit-Queue: Morten Stenshorne <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035429}
Clean up kAutofillFixFillableFieldType experiment
Fixed: 1080636
Change-Id: I178211889ccd1972d659b4ae354e8a9327d38c1b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3827418
Auto-Submit: Dominic Battré <[email protected]>
Commit-Queue: Florian Leimgruber <[email protected]>
Reviewed-by: Florian Leimgruber <[email protected]>
Reviewed-by: Richard Coles <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035428}
[PA] Rework `GetSubsequentPageMetadata()`
This CL reworks the return type of `GetSubsequentPageMetadata()` to
actually return a `SubsequentPageMetadata` struct.
Change-Id: Ia3b919cf8acd68a09d4f618d6edc1ec6f7b99ac2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3833256
Commit-Queue: Kalvin Lee <[email protected]>
Reviewed-by: Bartek Nowierski <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035427}
DanglingPtr: fix dangling ptr in QuotaManagerImpl
The deleter function will eventually delete the database before
~QuotaManagerImpl goes out of scope.
Bug: 1291138
Change-Id: I7eb567902d3e2d95ee1e058e08d7a40d1d2f7535
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3827835
Commit-Queue: Paul Semel <[email protected]>
Reviewed-by: Joshua Bell <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035426}
DanglingPtr: fix dangling ptr in ouput_device_mixer_impl
Use `ExtractAsDangling` to avoid holding a briefly danlging ptr.
Bug: 1291138
Change-Id: I7e74e331483ad528c7a573d2bafad8ebe9ec1062
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3826287
Commit-Queue: Ali Hijazi <[email protected]>
Reviewed-by: Olga Sharonova <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035425}
DevTools: add histograms for CSS hints
The reporting part is in this CL: https://crrev.com/c/3825896
Bug: 1178508
Change-Id: Ic578983fc3a4e81247523ea5da84afb2ab22e345
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3826316
Reviewed-by: Changhao Han <[email protected]>
Commit-Queue: Alex Rudenko <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035424}
Migration of chrome/ BrowserContextKeyedServiceFactory to ProfileKeyedServiceFactory Part 9
Bug: 1284664
Change-Id: I13a1cd7f587748f8d4138a4b8ce59b2cc24497a7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3798177
Reviewed-by: David Roger <[email protected]>
Commit-Queue: Ryan Sultanem <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035423}
DanglingPtr: fix dangling ptrs in window_tree_host
Use unique_ptr to hold owned input method instead of new/delete.
Bug: 1291138
Change-Id: Iccb116a256c3f3ffa95b0452514603888abd6ec5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3829302
Reviewed-by: Arthur Sonzogni <[email protected]>
Reviewed-by: Scott Violet <[email protected]>
Commit-Queue: Ali Hijazi <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035422}
Roll ANGLE from 2089943b951d to 0f5770deabf2 (1 revision)
https://chromium.googlesource.com/angle/angle.git/+log/2089943b951d..0f5770deabf2
2022-08-16 [email protected] Roll Chromium from 16d8164e92a5 to 754ede9fc072 (380 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86
Bug: None
Tbr: [email protected]
Change-Id: I86318f7e221c13e19981c6e4dedf5626195bdd73
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3833576
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035421}
Delay expiry of frequently used histograms.
Updates the expires_after attribute for 941 histograms that show
frequent access in the past 180 days. These are the 99% most
frequently used histograms over that time that do not already
have a date later than or within 60 days of 2022-11-14.
[email protected]
Change-Id: I4ab1ae1bf84d657f958630964f4d7470612f179a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3828135
Commit-Queue: Chrome Metrics Logs <[email protected]>
Bot-Commit: Chrome Metrics Logs <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035420}
Disable Settings button in IME Tray for Kiosk
Previous IME tray:
https://screenshot.googleplex.com/7mgW2BRw4VPv7YC
New IME tray in Kiosk session:
https://screenshot.googleplex.com/cDxA35HafiZprTD
IME tray in user session with settings button:
https://screenshot.googleplex.com/AfHbajdFnQq8M7t
Bug: b/242173879
Test: ash_unittests
--gtest_filter="ImeMenuTrayTest.*"
Change-Id: I2bb2a53efd39fc70fde5975621909f3def4c8c18
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3826305
Reviewed-by: Irina Fedorova <[email protected]>
Reviewed-by: Andre Le <[email protected]>
Commit-Queue: Irina Zelentsova <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035419}
DanglingPtr: fix dangling ptr in ContextProviderCommandBuffer
Since `impl_` is owned by one of gles2_impl_, raster_interface_, or webgpu_interface_, it must be declared last and cleared first.
Bug: 1291138
Change-Id: I5bddc19e1ed539c97c11590f82c48df4ca3df7f9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3816046
Reviewed-by: Zhenyao Mo <[email protected]>
Commit-Queue: Ali Hijazi <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035418}
Add ContactInfoSpecifics to EntitySpecifics and proto value conversions.
This CL corresponds to steps 4+5 of the sync integration checklist [1].
It additionally fixes a bug in proto_visitors.h, where VISIT_ENUM
instead of VISIT was called for two of the ContactInfoSpecifics' fields.
[1] https://www.chromium.org/developers/design-documents/sync/model-api/#sync-integration-checklist
Bug: 1348294
Change-Id: I339a74959d3fdf8ded494ccd73ea4ff47ddb5629
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3829508
Commit-Queue: Florian Leimgruber <[email protected]>
Reviewed-by: Marc Treib <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035417}
DanglingPtr: AXCallStatementInvokerAuraLinux
Remove DanglingUntriaged annotation on `indexer_` since it's not
dangling.
Bug: 1291138
Change-Id: Ie00ada415989e42d4779697b9d6ae21276ab7c51
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3819690
Commit-Queue: Ali Hijazi <[email protected]>
Reviewed-by: Martin Robinson <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035416}
AW: support flags in ServiceHelper.bindService
This fixes support for Context flags in ServiceHelper.bindService().
There was already a parameter for this, but the parameter was
accidentally ignored and Context.BIND_AUTO_CREATE was used instead.
This should have no effect in production. I manually verified that all
call sites pass Context.BIND_AUTO_CREATE anyway, so the behavior should
be the same.
Fixed: 1353168
Test: None
Change-Id: I539522b127c2b727b9dfacb4a44f48a80bb332a3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832776
Auto-Submit: Nate Fischer <[email protected]>
Reviewed-by: Hazem Ashmawy <[email protected]>
Commit-Queue: Hazem Ashmawy <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035415}
Roll src-internal from b21b98bdfcd7 to a902f4610501 (2 revisions)
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b21b98bdfcd7..a902f4610501
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: [email protected]
Change-Id: Ifc49de92f6c943bf51f960744248e59ff3bfa6d7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832737
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1035414}
[webgl] Add out parameters to ValidateUniformMatrixParameters
The implementation of WebGL functions like `uniformMatrixXXX` first
validates the incoming parameters in `ValidateUniformMatrixParameters`,
followed by the calculation of the data pointer and length to be passed
to the WebGL backend where the actual processing then happens.
With this CL, the calculation of the data pointer and length are moved
to `ValidateUniformMatrixParameters`. This means for the data pointer
that an offset gets added to an incoming base pointer. For the length
it means that either the incoming srcLength is used, or the size of the
incoming data array minus the offset.
This is just a refactoring, with the goal to create a single bottle
neck where the data pointer and length get calculated and can also be
checked.
The checks will be added in a later CL.
[email protected]
Bug: chromium:1344047
Change-Id: Ibcdc7d4f78d4f40b17087d43d871f11429a21440
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3822708
Reviewed-by: Kenneth Russell <[email protected]>
Commit-Queue: Andreas Haas <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035413}
[LoginScreen][SAML]: Fix activity observation condition
We should start observing user activity to reopen the login page only
when there are no user pods.
Bug: 1352074
Change-Id: I3ca15ef895cc3e9b31c05434a47b3e5381a1985d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3826309
Commit-Queue: Danila Kuzmin <[email protected]>
Reviewed-by: Renato Silva <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035412}
Ensure xcode is installed for WebRTC Chromium Mac Builder
Bug: webrtc:14364
Change-Id: I7199d52cde6478d2a6a4cb5d22d467fe4f571598
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3829516
Reviewed-by: Mirko Bonadei <[email protected]>
Commit-Queue: Jeremy Leconte <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035411}
Update V8 to version 10.6.174.
Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/dc38a218..ea1e4173
Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues
Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_chromeos_msan_rel_ng
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel
[email protected],[email protected],[email protected]
Change-Id: Ief1a016c8b3da241bbcd82919b445aa357e09d39
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3833495
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1035410}
Roll DevTools Frontend from 806f4a2e1cd6 to d08e7f0540c0 (2 revisions)
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/806f4a2e1cd6..d08e7f0540c0
2022-08-16 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS.
2022-08-16 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS (trusted-versions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: [email protected]
Change-Id: Id2c558eb655149e5cc4d156a11b067fcc62eab93
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3831410
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035409}
Roll Chrome Mac Arm PGO Profile
Roll Chrome Mac Arm PGO profile from chrome-mac-arm-main-1660607946-21fc3ac742bbf512e36ac315bd686a31e4bae5f8.profdata to chrome-mac-arm-main-1660629591-7059cbf5eed4d18173cea769494ab7763fc9f9b7.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-arm-chromium
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:mac-chrome
Tbr: [email protected]
Change-Id: I437dfee6e86c4f129266778794dfaaa7408315b3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832113
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035408}
Roll Chrome Mac PGO Profile
Roll Chrome Mac PGO profile from chrome-mac-main-1660607946-f1457d50bd4512f77090bbaad1f58f950b8f9471.profdata to chrome-mac-main-1660629591-1f325dcc2da375cc208a9ac8f1f693b2841ade8f.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:mac-chrome
Tbr: [email protected]
Change-Id: Ia67b1ffc3a4aeab24f49c416801d23b0b214731c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3833023
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035407}
[PA] partition_tag cleanups
This CL collects several fixes made in / around the `partition_tag`
module:
1. Call `PartitionTagIncrementValue()` with the slot start and size.
2. Extra DCHECK() in `PartitionTagSetValue()`.
3. `PartitionTagSetValue()` is changed to only operate on slot starts.
Bug: 1307514
Change-Id: I82153b09aef143c684fc13510957f67804f7b868
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3827932
Commit-Queue: Kalvin Lee <[email protected]>
Reviewed-by: Bartek Nowierski <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035406}
Delay expiry of histograms causing alerts.
Updates the expires_after attribute for 63 histograms that have
been used to generate alerts in the past 180 days and do not already have
a date later than or within 60 days of 2022-11-14.
[email protected]
Change-Id: I6b132d1b02edaf9a362e22d27370a3f31f59f41d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3828134
Commit-Queue: Chrome Metrics Logs <[email protected]>
Bot-Commit: Chrome Metrics Logs <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035405}
Roll WebRTC from 93fd55a030e8 to 8810a93ade13 (1 revision)
https://webrtc.googlesource.com/src.git/+log/93fd55a030e8..8810a93ade13
2022-08-16 [email protected] Roll chromium_revision dafd6f34c3..5ddcf683a5 (1035229:1035358)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in WebRTC: https://bugs.chromium.org/p/webrtc/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: [email protected]
Change-Id: I20dcc52c98eca1458e6d936c635592300f0f2045
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3833225
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035404}
Roll Chrome Linux PGO Profile
Roll Chrome Linux PGO profile from chrome-linux-main-1660607946-c55ac51ed3ad2d99676608338c73d1e6acc4162c.profdata to chrome-linux-main-1660629591-c41d73b0894d26e63bf93c2dd833194e279b4c35.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-linux-chromium
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:linux-chrome
Tbr: [email protected]
Change-Id: If6a668d8c688615cc4c55d99246d9a82d82c30d0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832848
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035403}
Privacy Guide: Update HaTS group names
Update the privacy guide HaTS group names, as discussed in cl/465067555.
Bug: 1215630
Change-Id: Ia985fafca8e587d4df9f8337376a2e62e3676571
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3822632
Commit-Queue: Rainhard Findling <[email protected]>
Reviewed-by: Side YILMAZ <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035402}
Do not forward memory pressure calls to image decode cache
LayerTreeHostImpl forwards memory pressure calls to image decode cache
by calling SetShouldAggressivelyFreeResources on it, which evicts
decoded images from cache.
At the same time, GpuImageDecodeCache listens to the same global
memory pressure events and does the same eviction.
Thus, remove calls to the ImageDecodeCache from the LayerTreeHostImpl
as they are not necessary.
Moreover, this simplifies sharing image decode cache instances between
cc instances (that will be done in a follow up cl).
Bug: 1279568
Change-Id: I3b167d9b8daf0a1194e243c86d3cb0db31006ecd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3817529
Reviewed-by: Khushal Sagar <[email protected]>
Commit-Queue: Maksim Sisov <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035401}
[Frameworks roll] Roll to 467850029 piper revision
Change-Id: Id1cde82c48c8c74107b03ebd6073720af76ae96e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832955
Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1035400}
Update list and dict Value usage in web_app_integration_test_driver.cc
Only Value::List and Value::Dict should be used to access and update
list and dict Values - other APIs are all deprecated.
Bug: 1187001, 1338341
Change-Id: I0c3ddf7b49b38f03cbec80aeb0bdfba8d3134da2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3831386
Reviewed-by: Alan Cutter <[email protected]>
Commit-Queue: Matt Menke <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035399}
[FastCheckout] Add a factory for FastCheckoutCapabilitiesFetcher.
Bug: 1350456, 1334642
Change-Id: I5cb6586c53f448033432ff4173b8ba65e16a9792
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3810488
Reviewed-by: Norge Vizcay <[email protected]>
Commit-Queue: Jan Keitel <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035398}
WebNN: implement MLOperator and build methods for clamp operator
This CL implements the internal slots of MLOperator. It also implements
the methods of MLGraphBuilder that build clamp operator.
Bug: 1273291
Change-Id: I22505bab95379f30efb305da91a1f8133502d806
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3818033
Reviewed-by: Jiewei Qian <[email protected]>
Commit-Queue: ningxin hu <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035397}
Roll Chrome Win32 PGO Profile
Roll Chrome Win32 PGO profile from chrome-win32-main-1660607946-9644f6ef70baeac7eebd3b368b81b4f239b82703.profdata to chrome-win32-main-1660618751-a18a938fe3e3094e9e24d71a5f6cf4ac61b350b2.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win-chrome
Tbr: [email protected]
Change-Id: Ibc2dbfc83ddf5cf578c30053c7435fab04618399
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3831408
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035396}
Refactor mojom API to receive list of struct rather action ids
This CL changes mojom API from sending list of ids and labels to sending
list of struct to prepare for the next change to receive label for
standard actions.
android side: ag/19201443
Bug: b/183573519
Test: AccessibilityNodeInfoWrapperTest.CustomActions
Change-Id: Ic9e5baa4d8c389b26f5378ed3f5850891cf21714
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3739902
Auto-Submit: Saho Kobayashi <[email protected]>
Reviewed-by: Hiroki Sato <[email protected]>
Reviewed-by: Dominick Ng <[email protected]>
Commit-Queue: Saho Kobayashi <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035395}
Settings WebUI: Fix empty extension info on chrome://settings/onStartup
crrev.com/c/3810934 attempted to modernize the base::Value usages across
WebUI but accidentally returned an empty object instead of `undefined`
when chrome://settings/onStartup checks if there is an extension
affecting Chrome startup.
This CL reverts those changes in the startup handler. See CL for
discussion [1].
[1] https://chromium-review.googlesource.com/c/chromium/src/+/3810934/3/chrome/browser/ui/webui/settings/on_startup_handler.cc#69
Fixed: 1352456
Change-Id: I782a099660f55a7baa59f889f2458a764888adb1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3833396
Reviewed-by: Rebekah Potter <[email protected]>
Commit-Queue: John Lee <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035394}
[lacros skew tests] Refresh skew tests for M106
This CL updates the ash version ['106.0.5243.0'] for Lacros version skew testing.
If this CL caused regressions, please revert and stop the autoroller
at https://luci-scheduler.appspot.com/jobs/chrome/lacros-version-skew-roller
Also please file a bug to OS>LaCrOS>Partner, and CC [email protected],
[email protected].
[email protected]
Bug: None
Change-Id: If7cf2cffdcbe14664a58409f21f8e44b6f28f385
Requires-Testing: True
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3831242
Auto-Submit: chrome-weblayer-builder <chrome-weblayer-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035393}
Roll nearby-connections from 123a2cfd1853 to e5c24b8b8ac4 (1 revision)
https://chromium.googlesource.com/external/github.com/google/nearby-connections.git/+log/123a2cfd1853..e5c24b8b8ac4
2022-08-15 [email protected] Add manager app ID into the APIs
> PiperOrigin-RevId: 467757514
>
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/nearby-connections-chromium
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:linux-nearby-chrome-fyi
Bug: None
Tbr: [email protected],[email protected],[email protected]
Change-Id: I27a9faf83b8592fa92563d199316e9f5cecc065e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832699
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1035392}
Roll Dawn from fa4a7291f2f6 to c81cefe06ea4 (1 revision)
https://dawn.googlesource.com/dawn.git/+log/fa4a7291f2f6..c81cefe06ea4
2022-08-16 [email protected] Roll ANGLE from 042fda3cacda to 2089943b951d (4 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dawn-chromium-autoroll
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel
Bug: None
Tbr: [email protected]
Change-Id: I77efe3ef579594aa26e05e39cc0c5d9d4513e8bb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3833456
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035391}
Pass flags for enabling Crostini IMEs and VK through to the container
Crostini IME/VK support is mainly enabled from within the container.
Pass these flags when launching vshd or apps so garcon can make use of
them.
Backend: https://crrev.com/c/3811044
Bug: b/231514911
Change-Id: I218e34dfefe175b123db54969ee1fbcfa19c5592
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3812701
Reviewed-by: Joel Hockey <[email protected]>
Commit-Queue: Timothy Loh <[email protected]>
Reviewed-by: Jason Lin <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035390}
[String matching] Rename prefix scoring constants.
The term "multiplier" is somewhat confusing.
Also change "word" to "token".
Test: existing
Bug: 1336160
Change-Id: I25d601c087205e60c5a26f1658cb641307800f12
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832979
Reviewed-by: Rachel Wong <[email protected]>
Commit-Queue: Amanda Deacon <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035389}
[ios][feed] Update experimental and feature flags for refresh
- Modifies the Experimental Settings for Refresh
- Modifies the about_flags variations for Refresh
Screenshots:
https://screenshot.googleplex.com/8aNCMGiwERBfDC5.png
https://screenshot.googleplex.com/AZTjEw6iEbzNpn3.png
Change-Id: I6c614708f5f7a779b19e0a1534d9ad586a268fc0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3827501
Commit-Queue: edchin <[email protected]>
Reviewed-by: Sergio Collazos <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035388}
Refactor CartService to use PrefService::GetValueDict
This is part of a larger migration effort based on
go/trust-your-prefs.
Bug: 1341996
Test: Existing unit tests
Change-Id: I877800988f2dd8d501785d2a97192a77504e5a38
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3827797
Commit-Queue: Roland Bock <[email protected]>
Reviewed-by: Paul Adedeji <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035387}
[cras] Add default device only if there are any available devices
Add default device only if there are any available audio devices. It can
prevent users from using fake devices on Chromebook without internal
mics or speakers.
For audio_manager_chromeos, also simply the logic of IsDefault function.
BUG=b:241739469
Change-Id: Ic36ab53b3892b96ca4bb9cbbc49a6b7ff0a4dffb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3829748
Reviewed-by: Olga Sharonova <[email protected]>
Commit-Queue: Yu-Hsuan Hsu <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035386}
[mparch] Use NR::frame_tree_node instead of RFHI::frame_tree_node_(4/4)
This CL replaces `frame_tree_node_` with
NavigationRequest::frame_tree_node() in
RenderFrameHostImpl::DidCommitNewDocument() to use the relevant
FrameTreeNode during navigation.
Bug: 1350575
Change-Id: Ib8c593bfc0eaa39659a82029f343677cb66fb71d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3829018
Reviewed-by: Alexander Timin <[email protected]>
Commit-Queue: Julie Jeongeun Kim <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035385}
[PA] Remove unused function
Nobody is calling `PartitionTagClearValue()`; remove the dead code.
Change-Id: I151f964f545e0a9062d5ad849fba19780520465c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3828025
Commit-Queue: Kalvin Lee <[email protected]>
Reviewed-by: Bartek Nowierski <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035384}
Unsuppress WebGL sad-canvas and context restoration pixel tests.
Pixel_WebGLContextRestored
Pixel_WebGLSadCanvas
These tests are passing on all configurations (except Android WebView,
which is expected). Android Chromium displays a strange blue background
behind the sad-canvas; will investigate this separately.
Bug: 1167246
Bug: 1086690
Change-Id: I6e910b216fd4059cb99b42bc0312dd29944f337b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3828891
Bot-Commit: Rubber Stamper <[email protected]>
Commit-Queue: Kenneth Russell <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035383}
[String matching] Mostly remove hybrid matching.
Also add a PrefixMatcher unit test file. The behavior of this class is
also already further covered in the FuzzyTokenizedStringMatch unit
tests.
See http://shortn/_iDJYSBeW0q for my definition of hybrid matching. In
short, it is one of the functions of the PrefixMatcher whereby a
combination of acronym matching and token prefix matching is carried out
in tandem.
Hybrid matching is only useful in a very narrow set of cases, and it
currently causes many inappropriately high match relevance scores. For
example, the following is currently graded a high match:
query: abcde
text: A BCDxyzxyz Exyzxyz
[capitals used to indicate matched portions of text]
This CL (mostly) removes hybrid matching from the PrefixMatcher. There
still exists a type of hybrid matching where entire tokens are matched.
e.g.:
query: abcde
text: A BCD Exyzxyz
This quirk is documented with a TODO in the added unit tests.
More cleanly separating out the functions of the PrefixMatcher is a
complex project. This current change is being made for short-term
mitigation of game search over-triggering.
score contribution to overall relevance scores (FTSM benchmarks)
Test: unit tests plus manual before/after comparison of the prefix
Bug: 1336160
Change-Id: I9436f642d4e5623bd39c95b7ec60dc47a322873d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3826616
Commit-Queue: Amanda Deacon <[email protected]>
Reviewed-by: Rachel Wong <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035382}
Roll Perfetto from 14874308ba40 to 079afe8d24d8 (325 revisions)
https://android.googlesource.com/platform/external/perfetto.git/+log/14874308ba40..079afe8d24d8
2022-08-15 [email protected] regenerate ftrace_descriptors am: 14874308ba
2022-08-12 [email protected] syscall_table: Build on windows am: 9b95139ed2
2022-08-12 [email protected] Add a list of identified potential causes for slow startup to startup_metric. am: 8537afe24e
2022-08-11 [email protected] Add trace-uri-resolver to perfetto-trace-processor-python am: 6373547903
2022-08-10 [email protected] Merge "Refactor the syscall table into a shared location" am: 54e7c1ce9c
2022-08-10 [email protected] Merge "Include sanitizer header for container annotations" am: 268fce601b
2022-08-10 [email protected] Update ui-stable version am: 2d152304da
2022-08-10 [email protected] Merge "Project import generated by Copybara." am: 7271d500e2
2022-08-10 [email protected] Merge "Adding chrome_inputs_per_frame.sql to track input count per frame" am: 0f47be4001
2022-08-09 [email protected] Merge "Add V4L2 Ftrace events" am: 1ca2df707e
2022-08-08 [email protected] [ui] Add panel for scroll jank tasks am: 14ae2bfe87
2022-08-08 [email protected] Merge "[ui] Add Chrome Scroll Jank plugin" am: fd4adc11dd
2022-08-08 [email protected] Merge "Update traceconv docs to properly call out how profile command works." am: 42165ac0c1
2022-08-08 [email protected] Merge "track_event_internal: Remove unused global variable" am: 2aa95acd9a
2022-08-08 [email protected] Merge "ui: Update channels" am: ecfe490673
2022-08-05 [email protected] Merge "Project import generated by Copybara." am: f44970fbda
2022-08-05 [email protected] Merge "Add memory fragmentation tracing" am: a6fa1c35d9
2022-08-05 [email protected] Merge "Fix `_COPY` version of legacy trace macros" am: c7072e645e
2022-08-04 [email protected] Merge "traced_probes: Support async events in the .json format" am: cb46e0562e
2022-08-04 [email protected] Merge "ui: Remove tslint suppressions" am: 850472f559
2022-08-04 [email protected] Merge "Fix android_jank_cuj missing CUJs in the output" am: 95939e60c0
2022-08-04 [email protected] Merge "ui: Catch and ignore cache errors" am: d2a590f4af
2022-08-04 [email protected] Merge "ui: Refactor cache manager to isolate API calls" am: 70ace4cf13
2022-08-04 [email protected] Merge "Revert "Add aggregation function EXPERIMENTAL_PPROF"" am: aafc89ce0a
2022-08-04 [email protected] Merge "[protozero] Fix cross-file-referenced enums." am: 28de3d8549
2022-08-03 [email protected] Merge "Partial revert of aosp/2166563" am: 470bc189f5
2022-08-03 [email protected] Merge "perfetto_cmd: --ignore-guardrails effects service" am: 44362a6663
2022-08-03 [email protected] Merge "Pivot table: header cell component with drag'n'drop support" am: a9b60d13f0
2022-08-03 [email protected] Merge "[ui] Update focus logic to change zooms levels more conservatively" am: a7c19fc9d3
2022-08-03 [email protected] Merge "Add a line about startup tracing in CHANGELOG" am: c0732e7ac4
2022-08-03 [email protected] Merge "Disable MainTracingNeverStarted once again" am: 64054d8a6e
2022-08-03 [email protected] Fix lmk metric in cases of buffer wraparound am: f21d8bd1d7
2022-08-03 [email protected] Merge "docs: Add linux.system_info to datasource references" am: 91540cbf6e
2022-08-02 [email protected] Merge "tp: Destroy TraceProcessorContext (except storage and two trackers)" am: a5a48bdc22
2022-08-02 [email protected] Merge "Add startup type to metric output" am: 19fc0ca111
2022-08-02 [email protected] Merge "Factor SizeProfileComputer out of protoprofile tool" am: a2e8a03841
2022-08-02 [email protected] Merge "Store expected ts in android_jank_cuj tables" am: ce19ce7576
2022-08-02 [email protected] tools: python amalgamation for tools/tracebox etc am: 11d94e1fed
2022-08-02 [email protected] Merge "Roll prebuilts for v28.0" am: 99b80d81d6
2022-08-02 [email protected] Merge "Startup tracing: Enable a test" am: 3edf152dd4
2022-08-02 [email protected] Fix v28.0 CHANGELOG am: 2ed5d3d8e6
2022-08-02 [email protected] Add CHANGELOG for v28.0 am: 0a357422d3
2022-08-02 [email protected] Merge "gn: Format everything" am: 6f2fd146e3
2022-08-02 [email protected] Merge "ui: Improve visible slice filtering" am: aa6525c786
2022-08-02 [email protected] Merge "base: Support base::StringView in base::Hash::Combine" am: c4da6db67c
2022-08-02 [email protected] Merge "tools/add_tp_diff_test: Enforce presubmit" am: 44110aceec
2022-08-01 [email protected] [protozero] Refactor nested enum values am: 762b30bd90
2022-08-01 [email protected] Merge "Fix android_jank_cuj producing duplicate SF frames" am: f8af68b972
2022-08-01 [email protected] Merge "Fix android_jank_cuj CUJ - counter matching" am: 0b22f0bb08
2022-07-29 [email protected] Merge "[ui] Add --cross-origin-isolation flag to ui/run-dev-server" am: 01993ba7f5
2022-07-29 [email protected] Merge "tp: Pass objects, not unique pointers, inside TraceSorter" am: 2ec0cd48c0
2022-07-29 [email protected] Merge "Add aggregation function EXPERIMENTAL_PPROF" am: 566ee6c9e7
2022-07-29 [email protected] Merge "Fix handling of async slices for track." am: 5f039513f2
2022-07-29 [email protected] Merge "Add new fields with fixed64 type for flow ids in TrackEvent" am: 139aa51f0d
2022-07-29 [email protected] tools/difF_test_tp handle CTRL-C and kill everything immediately am: 521d620b42
2022-07-29 [email protected] Merge "Use chrome.process_type arg for identifying Chrome processes" am: c9535c6684
2022-07-29 [email protected] Merge "TraceProcessor: Add initial bugreport parser" am: 0dc0de1f09
2022-07-28 [email protected] Merge "ui: Don't aggregate perf samples on single selection" am: 8ab7cdc76e
2022-07-28 [email protected] Use base::SprintfTrunc() in streaming_line_reader_unittest.cc. am: 7954ca73f6
2022-07-28 [email protected] Merge "base: Disable Sockaddr_AbstractUnix test on Mac OS" am: ea8c38758d
2022-07-28 [email protected] traced_probes: Fix test path am: 3cb10921b8
2022-07-28 [email protected] startup trace: Fix abort and restart am: f848e2608c
2022-07-28 [email protected] Test multiple DS in startup tracing am: e9c3cece1b
2022-07-28 [email protected] Add a new test for Startup Trace am: e4cdcdf8c6
2022-07-28 [email protected] Merge "Link crbug component from Perfetto docs" am: 98ea8945a9
2022-07-27 [email protected] Merge "Revise special type category in java_heap_histogram metric" am: a9efcec17a
2022-07-27 [email protected] Merge changes I2e5d1c76,I84982c81,Idbadf707 am: f921169dca
2022-07-27 [email protected] Merge "Expose Trace protos in a java_library_host" am: 468424f34c
2022-07-27 [email protected] heapprofd: Read whole shmem buffer when stopping data source. am: fe9023f1dc
2022-07-27 [email protected] Merge "ui: Push tracebox to device" am: 07b87a79a8
2022-07-27 [email protected] Merge "tp: improve python error message when tp fails to start" am: c9244a8ff3
2022-07-27 [email protected] Merge "base: Fix off-by-one in abstract unix socket names" am: 8c0e5cddcd
2022-07-27 [email protected] Merge "Fix TP diff tests on mac" am: 07713c7803
2022-07-27 [email protected] Merge "Emit mojo interface tag based on symbol" am: 24cd5e92b8
2022-07-27 [email protected] Merge "Add instruction for tracing Chrome on desktop" am: fc7632cd9d
2022-07-27 [email protected] Merge "Tests: deflake protozero_benchmark.cc" am: 3177787e47
2022-07-27 [email protected] Fix chromium build, take 5 am: e65601d47b
2022-07-26 [email protected] base: Fix chromium autoroll take 4 am: f166fc4872
2022-07-26 [email protected] TP: Fix ZipReader tests when zlib is disabled. Fix chromium. am: ad35c20d94
2022-07-26 [email protected] Merge "[ui] Fix kthread track ordering" am: 519a7b3f5c
2022-07-26 [email protected] Merge "TP: Fix windows build and small time bug in ZipReader" am: b4c6bc48b3
2022-07-26 [email protected] Merge "[ui] Record metatrace from the UI" am: ab65cfbcd2
2022-07-26 [email protected] Merge "ui: Add default mode for counters" am: 1d8f20f053
2022-07-26 [email protected] Merge "tp: fix ninja gzip by flushing data in gzip parser" am: f5d2a9d1f2
2022-07-26 [email protected] Merge "Disable a flaky test temporarily" am: cce216814d
2022-07-26 [email protected] Merge "TraceProcessor: use UTC in ZipReader" am: d7786fc968
2022-07-26 [email protected] Merge "Include SF in android_jank_cuj metric" am: 79f30e9ac8
2022-07-26 [email protected] Merge "UnixSocketRaw: fix recent regression where we weren't setting CLOEXEC" am: 7d7687ea9f
2022-07-26 [email protected] Merge "ui: Add rate mode for counters" am: 97d44b4faa
2022-07-26 [email protected] Merge "TraceProcessor: add ZipReader" am: 30f1f06bcf
2022-07-26 [email protected] Merge "TraceProcessor: Add StreamingLineReader" am: f692f560ab
2022-07-26 [email protected] Merge "tp: add documentation for batch trace processor" am: edae25d0fa
2022-07-26 [email protected] Merge "Add more documentation to query_frame_slice.sql" am: bc18be5bc3
2022-07-26 [email protected] Merge "TP: Set Access-Control-Allow-Private-Network: true" am: bc178838b0
2022-07-26 [email protected] Merge "tp: fix ingestion of ninja logs" am: 880ad9da29
2022-07-25 [email protected] Merge "kallsyms: initialize synchronously and add option to avoid teardown" am: e19e4f253f
2022-07-25 [email protected] Merge "Disable a flaky test temporarily" am: f36cd8e533
2022-07-25 [email protected] Merge "Add new arg for Chrome processes" am: e4d93e430c
2022-07-25 [email protected] Merge "Pivot table: get rid of edit view" am: 624891936a
2022-07-25 [email protected] Merge "Fix process labels query" am: a3a3b568a2
2022-07-25 [email protected] Merge "protozero::EnumToString." am: 049a4290ea
2022-07-25 [email protected] tp: fix bounds table for traces with data added in eof am: e8137e2b16
2022-07-24 [email protected] Merge "Add ANDROID_JANK_CORRELATE_FRAME_SLICE" am: e420efc80e
2022-07-23 [email protected] Merge "tp: Change from multithreading to multiprocessing in diff tests" am: c9aa8a4ab3
2022-07-22 [email protected] Merge "Add support for blocking method in StartupTracing" am: 86c920c317
2022-07-22 [email protected] Merge changes I652777da,I30e3e707 am: 209791f79d
2022-07-21 [email protected] Merge "Revert "Add new fields with fixed64 type for flow ids in TrackEvent."" am: 361efbf9aa
2022-07-21 [email protected] Merge "Show symbolization error for /data/local/tmp binaries" am: 8feaff378d
2022-07-21 [email protected] Merge "traced: don't set sys.trace.traced_started in standalone builds" am: 39b96e46bc
2022-07-21 [email protected] Merge "tracebox: Optionally bundle traced_perf" am: 4a560a9007
2022-07-21 [email protected] Merge "Project import generated by Copybara." am: 8417903389
2022-07-21 [email protected] Merge "Fix format specifier for TracingBackendId (aka size_t)" am: 4ff8baf8c8
2022-07-21 [email protected] Merge "add chrome_tasks_delaying_input_processing.sql" am: 66bed4ed59
2022-07-20 [email protected] Merge "Adding scroll_jank_caused_by_scheduling.sql" am: 437f9d9de0
2022-07-20 [email protected] Merge "[metrics] adding chrome_stack_samples_for_task.sql" am: 624d558fb1
2022-07-20 [email protected] Merge "Add example_startup_trace.cc" am: 0bc0ae0cee
2022-07-20 [email protected] Merge "tp: Destroy in context CHANGELOG" am: 76abb4316e
2022-07-20 [email protected] Merge "Add new fields with fixed64 type for flow ids in TrackEvent." am: c8ba9179ad
2022-07-20 [email protected] Merge "Support AndroidSystemProperty in trace processor." am: c223598255
2022-07-20 [email protected] Merge "Fixing sybmolize_database attempting to convert non hex build ids." am: 50f9a87461
2022-07-20 [email protected] Merge "Pivot table: add aggregations via dropdown menu" am: 3101cf59da
2022-07-19 [email protected] Merge "trace_processor: change track name for ufs clkgating to align io.ufs format" am: ac8e40ad9e
2022-07-19 [email protected] Merge "ui: Add Chrome recording UI V2" am: 5dd5bf76c9
2022-07-19 [email protected] Merge "base::Daemonize(): wait for child setsid()" am: 5c68a10eb7
2022-07-19 [email protected] Merge "Add pivots via dropdown" am: f8903a06d5
2022-07-19 [email protected] Merge "tracebox: fix "traced_proces" typo in error message." am: 0641c2d485
2022-07-19 [email protected] ui: Add chrome recording V2 target, target factory and am: a4222f2a87
2022-07-18 [email protected] Merge "Typo buils -> build" am: 761031a428
2022-07-18 [email protected] Merge "trace_processor: Understand <!DOCTYPE HTML> as systrace" am: ec8de057b3
2022-07-18 [email protected] Merge "tp: Construct Trackers with storage, not context" am: a16f43c697
2022-07-18 [email protected] Merge "Make the extension work with 127.0.0.1" am: 4e004c2d16
2022-07-16 [email protected] Merge "sdk: Support startup tracing" am: 84c611be65
2022-07-16 [email protected] Merge "Distinguish profile types and show different UI labels for each" am: 9882c50ee9
2022-07-15 [email protected] Merge "ui: fix slice aggregation with many slices" am: 9277dbf0aa
2022-07-15 [email protected] Merge "ui: Change interfaces to allow Chrome recording V2" am: 16075d13d0
2022-07-15 [email protected] Merge "tp: Fix bug: diff_tests not showing diff in failing test" am: 4a7522f01b
2022-07-15 [email protected] Merge changes I5d09b94d,I5c341ab4 am: b781e1fdec
2022-07-15 [email protected] Merge "[ui] Reorder columns in the "Debug SQL performance" view." am: 0c6720dbdd
2022-07-15 [email protected] Merge "ui: add io.ufs.command.tags group tab" am: efbcdf72c0
2022-07-14 [email protected] perfetto: Add changelog for v27.1 am: bed4b810cd
2022-07-14 [email protected] Merge "Fix a minor typo" am: da6e55d8b2
2022-07-14 [email protected] [automerger skipped] Merge "Add missing test dependencies for CtsPerfettoTestCases" am: 5771b65247 -s ours
2022-07-14 [email protected] [automerger skipped] Add missing test dependencies for CtsPerfettoTestCases am: 4bb9c5402a -s ours
2022-07-14 [email protected] Merge "Don't emit consecutive empty trace packets" am: 39bdfbd0bb
2022-07-14 [email protected] Merge "UI: Add Android game intervention table" am: ed613a2e0f
2022-07-13 [email protected] Merge "Add high_latency_contribution_stage to ChromeFrameReporter" am: 29a81e33e6
2022-07-13 [email protected] Merge "trace_processor: show I2C transactions for the outermost adapter IDs" am: 90d4b83dcd
2022-07-13 [email protected] Merge "[ui] Refactor track sorting logic" am: 800729ab02
2022-07-13 [email protected] Merge "ui: Customise modal used for resetting the device interface." am: 53040b175c
2022-07-13 [email protected] Merge "ui: Add logic for forcing the connection to the device when adb server is running" am: 975d653113
2022-07-13 [email protected] Merge "tp_python: try to avoid downloading TP many times" am: 199bdbc0b3
2022-07-13 [email protected] Merge "[ui] Fix height of the panel details column" am: 00a6e13924
2022-07-13 [email protected] Merge "Enable traced_perf android standalone build" am: f6cffe1120
2022-07-13 [email protected] Merge "Change the preset of the pivot table to include dur and use sorting" am: f9b0adce21
2022-07-13 [email protected] Merge "ui/tp: fix flamegraphs and tracks for stackless perf samples" am: eefeab864b
2022-07-13 [email protected] Merge "DO NOT MERGE - Merge TP1A.220624.013" into stage-aosp-master
2022-07-12 [email protected] Merge "buildtools: remove include of bionic from libunwindstack" am: 7a33ae4f5f
2022-07-12 [email protected] Merge "Make the images in CI diff report clickable" am: 29c42fc6f5
2022-07-12 [email protected] Change android_frame_timeline_metric to extract more frame metrics am: 4a17c4c0e2
2022-07-12 [email protected] Merge "Reland: "traced_probes: Add statsd atoms datasource"" am: b55187de9e
2022-07-12 [email protected] Merge "protos: Fix shell_config.proto" am: 8fe494f32e
2022-07-12 [email protected] Merge "perfetto: bump prebuilts to v27.1" am: cd6868ceeb
2022-07-12 [email protected] docs: Fix a typo am: 8bf2c5fd2c
2022-07-12 [email protected] Merge "tracing: Add API to shut down Perfetto" am: 3613efe4a9
2022-07-11 [email protected] trace_processor: Update game intervention table and parser am: 16cf103dc6
2022-07-11 [email protected] traced_probes: Update intervention list data source am: e23e97d40e
2022-07-11 [email protected] Merge "Extend the interactive area for pinning tracks" am: da38394c89
2022-07-11 [email protected] Merge "tp: fix up precision in diff test printing" am: 0ab5718881
2022-07-11 [email protected] Implement a script to download changed screenshots from CI am: dbfcb7c647
2022-07-11 [email protected] Merge "Make pivot table slices selection consistent with slice aggregation" am: 20b95850d8
2022-07-11 [email protected] Merge "Fix missing rows in pivot table" am: d1dcea545d
2022-07-11 [email protected] Merge "Pivot table: make menu icons indicate sorting direction" am: ed0ec64f6b
2022-07-08 [email protected] Merge "tp: Parallelize diff tests" am: 742e9183b4
2022-07-08 [email protected] Merge "tp: split off ColumnStorageOverlay from RowMap" am: b4b37d45c5
2022-07-08 [email protected] Remove obsolete intructions for llvm-symbolizer am: 03942595e3
2022-07-08 [email protected] Merge "Revert "traced_probes: Add statsd atoms datasource"" am: 9bad4b45b0
2022-07-08 [email protected] Merge "tp: Extract Flush logic from NotifyEndOfFile" am: f610ed74ff
2022-07-07 [email protected] Merge changes I377c7e62,Ib1ad99a3 am: f56e4abd18
2022-07-07 [email protected] Merge "Translate slice args before removing slice from stack" am: cfd9fa01b5
2022-07-07 [email protected] Merge "Parse and export background_tracing_metadata" am: a9181a27b5
2022-07-07 [email protected] Merge "[metrics] Add input_arrived_to_processing_intervals.sql." am: acc008eff9
2022-07-07 [email protected] Merge changes Idcc16653,I6c774825 am: 3c4bdd0f33
2022-07-07 [email protected] Merge "trace_processor_shell process does not exit" am: e535a96ea0
2022-07-07 [email protected] Merge "trace_processor: shows the UI of ufs command tags" am: ba68fc5df8
2022-07-07 [email protected] Merge "traced_probes: Add statsd atoms datasource" am: 1e47025056
2022-07-07 [email protected] Merge "ui: Create PluginContext and pass it to plugins" am: 92289f45c5
2022-07-07 [email protected] Replace deprecated atoms.proto file path am: 4440655d1a
2022-07-06 [email protected] Merge "protozero: Support custom ring buffer formats" am: 84a3c77dcd
2022-07-06 [email protected] Merge "android_system_property data source." am: d1ec856c99
2022-07-06 [email protected] Merge "ui: Combine all tracks into single files" am: 0cc049c788
2022-07-06 [email protected] Merge "fix zombie process" am: d78aeb6913
2022-07-06 [email protected] Merge "ui: optimize perf sample sorting sub-query" am: c23f5c7c8a
2022-07-06 [email protected] Merge "[ui] Display unnamed processes last" am: b49f453ce7
2022-07-06 [email protected] Merge "Fix report.txt parsing on diff viewer" am: 407c3d3107
2022-07-06 [email protected] Start phasing out checkbox UI for Pivot Table configuration am: bf2ee62fe2
2022-07-05 [email protected] Format all Python scripts am: b1989b0ff0
2022-07-05 [email protected] Merge "doc: tighten security on dev server" am: 28934fcd20
2022-07-05 [email protected] Merge "PERFETTO_FATAL if there are duplicate datasources" am: 78eca1d74f
2022-07-05 [email protected] Merge "Teach tools/update-statsd-descriptor to update atom_ids.proto" am: 7d9cddacc9
2022-07-05 [email protected] Remove unused Pivot Table v1 CSS classes am: d94e4dc359
2022-07-05 [email protected] Merge "startup: pick the max slice if multiple processes match" am: b6fc104b80
2022-07-05 [email protected] Merge "presubmit: Fix typo --override -> --overwrite" am: 0fe22d8dff
2022-07-05 [email protected] Merge "Popup with rudimentary completion of argument pivot name" am: bfd67329f5
2022-07-05 [email protected] Merge "Copy ui-test-artifacts unconditionally" am: b3236194dd
2022-07-04 [email protected] Merge "message_arena: Use forward_list instead of list" am: 1cc939592a
2022-07-04 [email protected] Merge "Fix command to run in PRESUBMIT.py" am: 80dd4d929a
2022-07-04 [email protected] Merge "Add *.pftrace in .gitignore" am: 6e69093d8e
2022-07-04 [email protected] Merge "Revert "perfetto: Allow to profile system server on user"" am: 2a5d492d84
2022-07-04 [email protected] startup: exclude any thread which ended during launch am: 8f3125e91d
2022-07-04 [email protected] Merge "[ui] Fix process sorting by perf samples" am: 129e19f71c
2022-07-04 [email protected] Merge "perfetto: bump prebuilts to v27.0" am: 9687be9f75
2022-07-04 [email protected] Merge "ui: Reduce circular imports" am: 6fa11b726b
2022-07-04 [email protected] Merge "[ui] optimize sched subquery in process sorting" am: c519690a33
2022-07-04 [email protected] Merge "Reland "[ui] Sort processes by slice count as a fallback"" am: 54009f2b3d
2022-07-04 [email protected] Merge "CI: pin libraries for python 2.7" am: dd682e48aa
2022-07-04 [email protected] Diff report for screenshot tests am: bb4e6b261f
2022-07-01 [email protected] Merge "tp: move ColumnStorage creation to initializer instead of body" am: d86457ab53
2022-07-01 [email protected] Merge "tp: use process metadata table when figuring out launch processes" am: 63cdebc57f
2022-07-01 [email protected] Merge "perfetto: add changelog for v27" am: 96c8a8bd8c
2022-07-01 [email protected] Ignore incomplete suspend/resume slices. am: 69bd8a4ece
2022-07-01 [email protected] Fix android_sysui_cuj_surfaceflinger metric am: 3a4f21146f
2022-07-01 [email protected] Merge "Remove dead file" am: 89368fd8c2
2022-07-01 [email protected] Merge "ui: Separate recording Settings sections into components" am: a339bfa73c
2022-07-01 [email protected] Merge "Remove android_jank.sql and related files" am: 659ec76603
2022-07-01 [email protected] Merge "ui: Change interface to support datasources for targets" am: 15247138d1
2022-07-01 [email protected] Merge "startup: fix failure when top process has a null name" am: 778139313b
2022-07-01 [email protected] Merge "Use CUJ instrumentation markers to detect canceled CUJs" am: f413bdf835
2022-06-30 [email protected] Merge "Revert "[ui] Sort processes by slice count as a fallback"" am: 7bcfdf24e8
2022-06-30 [email protected] Merge "tools: require prebuilt command to match exactly with passed arch" am: 48f72af9a2
2022-06-30 [email protected] Merge "tp: be more strict when deciding launch types" am: 4d22aa7847
2022-06-30 [email protected] Merge "Fix warnings in windows build" am: a6d76d5c31
2022-06-30 [email protected] Merge "gn: Minimize rebuilding when commit hash changes" am: bb9d99f280
2022-06-30 [email protected] Merge "tp: migrate counter dur generator to use modern iterators" am: 2c4a70d951
2022-06-30 [email protected] Merge "tp: improve vtable benchmark" am: c70c6ac44d
2022-06-30 [email protected] Merge "docs: add info about versioned traceconv downloads" am: e47c012750
2022-06-30 [email protected] Merge "[ui] Optimise the query to select flow chrome custom names." am: bfb457d406
2022-06-30 [email protected] Merge "[ui] Do not use half-width table in the slice details panel" am: 9bbd6d9c49
2022-06-30 [email protected] Merge "[ui] Fix stack sampling panel auto-closing when clicking on a slice." am: 32aab6ae7c
2022-06-30 [email protected] Merge "tools: allow specifying a different origin for open_trace_in_ui" am: cea074c657
2022-06-30 [email protected] Merge "Project import generated by Copybara." am: 36f9846409
2022-06-30 [email protected] Merge "[Client API] Add WillClearIncrementalState callback" am: 7c0dc4ade9
2022-06-29 [email protected] Merge "Merge tm-dev-plus-aosp-without-vendor@8763363" into stage-aosp-master
2022-06-29 [email protected] Merge "tp: cleanup functions even if they error" am: 6d78abbecc
2022-06-29 [email protected] Merge "update-statsd-descriptor: Include all protos in the descriptor" am: 0721392a57
2022-06-29 [email protected] Merge "Remove extraneous "1" from AndroidManifest.xml" am: a0523785eb
2022-06-29 [email protected] Merge "[ui] Sort processes by slice count as a fallback" am: 29c4330a4a
2022-06-29 [email protected] Merge "protozero: Add Const{Chars,Bytes} setters for strings/bytes" am: 357c16299c
2022-06-28 [email protected] Merge "[ui] Sort processes by number of perf samples" am: d8081faeb0
2022-06-28 [email protected] Merge "Fix concurrency of GetDataSourceLocked() and GetInterceptorLocked()" am: 6d4ebba30b
2022-06-28 [email protected] Merge "Build example_custom_data_source.cc with gn" am: beb2e06ad3
2022-06-28 [email protected] Perfetto: Add proto parser for game intervention am: 4ba9ce2bc3
2022-06-28 [email protected] Merge "[ui] Support "select all" shortcut" am: cf76c40bdd
2022-06-28 [email protected] Merge "trace_processor: Add tools/update-statsd-descriptor to import atoms.descriptor" am: da725bce72
2022-06-28 [email protected] Merge "bazel: add rules for protos for Go" am: c594998498
2022-06-28 [email protected] Merge "trace_processor: Rename tests to not break the presubmit" am: 6a3a7e9cef
2022-06-28 [email protected] Merge "traced_probes: Increase trace length watchdog timeout" am: 8c074f877b
2022-06-28 [email protected] [ui] Rebaseline failing difftests. am: 8a5eea67e3
2022-06-27 [email protected] Merge "tp: fix create view function scoped statement" am: 4d2a825326
2022-06-27 [email protected] Merge "tp: fix crash by not freeing events" am: 048f619e85
2022-06-27 [email protected] Merge "[ui] Add "visualise arg values" option to the arg context menu" am: 2a59c7427c
2022-06-27 [email protected] Merge "ui: Add websocket recording" am: 1599610a78
2022-06-27 [email protected] Merge "Fix layout of track header" am: 01aa86f1ef
2022-06-27 [email protected] Merge "[test] Mark test/data as owned-by-everyone." am: 010e6c1867
2022-06-27 [email protected] ui: Release canary am: 89c02bcf66
2022-06-24 [email protected] Suggest increasing buffer size in case of incomplete heap dump am: 588d85dc56
2022-06-24 [email protected] Merge "tp: don't stack overflow on bad track event parent <-> child relations" am: 8209fb9b9a
2022-06-24 [email protected] Merge "Improve test-data-sync error message" am: 9ed5f4f37c
2022-06-24 [email protected] Merge "tp: return the top 5 processes by mcycles in the startup metric" am: 4ce89ccad0
2022-06-24 [email protected] Merge changes I7120df21,I8eeaa3c8 am: 95ba9b12f6
2022-06-24 [email protected] python: update documentation for public util methods am: 8b8042059e
2022-06-23 [email protected] Merge "python: add resolver util methods for generating clauses for queries" am: 2d2d50afec
2022-06-23 [email protected] Merge "Add statsd write-side protos" am: 9a4022db03
2022-06-23 [email protected] Merge "Add chrome_unsymbolized_args metric" am: d3300e34ed
2022-06-23 [email protected] tp: count broadcasts sent and processed concurrent to startup am: b27180c55d
2022-06-23 [email protected] Merge "tp: flag when dex2oat/installd are running during app start" am: 07b7e63e25
2022-06-23 [email protected] Merge "ui: Add initial plugin architecture" am: e203cbf28e
2022-06-23 [email protected] Merge "Translate native symbol in mojo event info" am: 7f8b5c5e49
2022-06-23 [email protected] Show process labels in collapsed state am: 7d71321db7
2022-06-23 [email protected] tp: remove all increase in memory use caused by switching to vectors am: 8cafb589b7
2022-06-23 [email protected] Merge "tp: switch columns from deque to vector" am: eba209175d
2022-06-22 [email protected] Merge "perfetto: Only match partial rss_stat_throttled trigger" am: 0eba417b2c
2022-06-22 [email protected] Merge "tp: Fix proto_to_args_parser.h comment" am: 225c531571
2022-06-22 [email protected] Merge "Add support for custom attributes in a macro" am: 6d2f19ea52
2022-06-22 [email protected] Merge "Cache hsluvToHex invocations" am: d232f00304
2022-06-22 [email protected] Add null check in DynamicString wrapper am: 77d58bef36
2022-06-22 [email protected] Merge "trace_processor: support sched_cpu_util_cfs event" am: 90b69aca3f
2022-06-21 [email protected] Perfetto: Add game mode intervention data source am: 2b0a2135f0
2022-06-21 [email protected] Merge "tp: add metrics for lock contention on main thread during app startup" am: 790912114b
2022-06-21 [email protected] Merge changes from topic "rss-trigger" am: 0b8505ac1d
2022-06-21 [email protected] tp: rewrite startup metric to be much easier to understand and extend am: fb9252f949
2022-06-21 [email protected] Merge "Create `embeddedMode` and `hideSidebar` globals" am: 3d3f58658f
2022-06-21 [email protected] Merge "python: add support for operators in trace URIs" am: ae42e46f23
2022-06-21 [email protected] Merge "[tp] Normalise path separator arguments" am: 46069f6353
2022-06-21 [email protected] Merge "ui: add f2fs_iostat_latency group tab" am: 5c85522e6e
2022-06-21 [email protected] ui: Fix grouping of iostat tracks am: a15b969a82
2022-06-21 [email protected] Merge "ui: Update error messages for api version fetching" am: 8f3eeefc37
2022-06-21 [email protected] Merge "ui: Add shellAndGetOutput method to the adb connection" am: 33a5412d45
2022-06-21 [email protected] Merge "ui: Add util class for building an arrayBuffer" am: cf9f60bcc2
2022-06-21 [email protected] Merge "ui: Update interfaces to support API fetching from the device" am: a89fe83597
2022-06-20 [email protected] Follow up for aosp/2129480 am: b983faf1bf
2022-06-20 [email protected] Merge "[ui] Show flow events in the "Current selection" panel" am: 52ef6a5351
2022-06-20 [email protected] Merge "tools/check_proto_comments: Ignore protos/third_party" am: f933e6d834
2022-06-20 [email protected] Merge "tp: Rename {Message,Field}Descriptor to FtraceX" am: 5332b415ce
2022-06-20 [email protected] ui: Fix CI am: f4e82a1152
2022-06-20 [email protected] Make TrackEventInternedDataIndex::GetOrCreateIndexForField protected am: 3ce201c8de
2022-06-17 [email protected] Merge "tp: switch from using RowMap to BitVector inside NullableVector" am: faa478c787
2022-06-17 [email protected] Merge "tp: separate storage for non-null columns from nullable columns" am: 0a3aae7c43
2022-06-17 [email protected] Merge "Allow multiple messages in post message handler" am: 372573604a
2022-06-17 [email protected] Merge "Extract some styles to CSS constants to make them easier to override." am: 26341db4d3
2022-06-17 [email protected] tp: decouple nullable vector from column storage am: 0fc854399d
2022-06-17 [email protected] Merge "metrics: add simpleperf event metrics" am: b9f4805cad
2022-06-16 [email protected] Merge "Add FrameType field to ChromeFrameReporter." am: 678b18cbe3
2022-06-15 [email protected] Merge "[fuchsia] Reland: Add alternate socket acceptance path." am: 66845965ee
2022-06-15 [email protected] Merge "[ipchost] Allow callers to provide Hosts to ServiceIPCHost." am: 9fcbb7415a
2022-06-15 [email protected] Update CHROMIUM_OWNERS am: f35bba229d
2022-06-15 [email protected] Merge "Fix scrolling to slice when navigating search results" am: 6007fadd7c
2022-06-15 [email protected] Merge "Add OWNERS file for protos/third_party/chromium" am: ce6bb400f0
2022-06-15 [email protected] Merge "base: Define PERFETTO_COMPONENT_EXPORT conditionally" am: 397f8c5e50
2022-06-15 [email protected] Merge "Update screenshots" am: bc61345664
2022-06-15 [email protected] Merge "Project import generated by Copybara." am: 58475d0a90
2022-06-15 [email protected] Merge "Disable enable_perfetto_x64_cpu_opt on x64 MacOS" am: eb16ef487f
2022-06-15 [email protected] Merge "Update "Next id" in {data_source_config,trace_packet}.proto" am: d9a966e241
2022-06-15 [email protected] Merge "Document query input capabilities in "Shortcuts" popup" am: 74fabc35bb
2022-06-15 [email protected] Merge "tp: fix off-by-one error in UpdateSetBits" am: ddc88694c4
2022-06-15 [email protected] Merge "tp: fix invalid track_event end event causing crashes" am: 29c99a813c
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel
Bug: None
Tbr: [email protected]
Change-Id: I300250ae9926eae412a4b1a1a67d8c5950bb2dfc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3833219
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035381}
[CodeHealth] Further clean up `BackForwardCacheMetricsTestMatcher`
- Make impl provides `histogram_tester_`.
- Update the signature of `ukm_recorder()`.
- Move `AddSampleToBuckets()` to local.
- Add more documentation about how this class actually works.
Bug: 1352894
Change-Id: I1835a33c06318493e498ff5e2be91f00eee21e84
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832154
Reviewed-by: Rakina Zata Amni <[email protected]>
Commit-Queue: Ming-Ying Chung <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035380}
Reland "MobileFriendlinessChecker add checking of ViweportMeta"
This is a reland of commit e85b38d7956712e392827d562e9d90279a6cf3e2
The original commit reverted because of timeout on test external/wpt/accessibility/crashtests/aria-owns-fallback-content.html with linux_chromium_dbg_ng test.
But that phenomenon is no more reproducible by manual invocation and my local environment.
Original change's description:
> MobileFriendlinessChecker add checking of ViweportMeta
>
> Do not create MF checker if ViewportMeta is not enabled.
>
>
> Bug: 1113750
> Change-Id: I5cde07ac62b212df31865eef16931ba693384064
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3789270
> Reviewed-by: Xianzhu Wang <[email protected]>
> Commit-Queue: Hiroki Kumazaki <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1030031}
Bug: 1113750
Change-Id: I8b17fd025db8c9b629338a12e626064353a2117f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3801771
Reviewed-by: Xianzhu Wang <[email protected]>
Commit-Queue: Hiroki Kumazaki <[email protected]>
Auto-Submit: Hiroki Kumazaki <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035379}
[Topics] Resolve invalid feature configurations
A render crash will trigger if the kPrivacySandboxAdsAPIsOverride is
(manually) enabled and kBrowsingTopics is disabled. It’s speculated
that some existing crashes are due to this cause.
Bug: 1347039
Change-Id: Ia552cd23b828a5f835526fbce84ab8d2feb5b265
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3831888
Reviewed-by: Daniel Cheng <[email protected]>
Commit-Queue: Yao Xiao <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035378}
Roll Chrome Win64 PGO Profile
Roll Chrome Win64 PGO profile from chrome-win64-main-1660607946-dd44455994bd6ed145d7eb27db7171b2d89adea3.profdata to chrome-win64-main-1660618751-5486368e92053699c0d9a4e6850d07713cc17733.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win64-chrome
Tbr: [email protected]
Change-Id: I7154f9d02a61b2a3060df46fe64d7e15fefff0d2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832999
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035377}
Add LowPriorityAsyncScriptExecution feature
This CL adds LowPriorityAsyncScriptExecution feature. The basic idea of
LowPriorityAsyncScriptExecution is to run async script when the main
thread is doing nothing. But at the same time, we want to avoid waiting
too long to run async scripts. So this CL also adds a timeout mechanism.
Design Doc:
https://docs.google.com/document/d/1RNSiQS3fG2olC52RRJ6Y7jY9LjWKn5Z2HZ3b9Qp0nmw/edit#bookmark=id.dr5ecxnx2kco
Bug: 1348467
Change-Id: I06cad47e540da307046a105f6e737bced83cbf04
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3793626
Reviewed-by: Kouhei Ueno <[email protected]>
Commit-Queue: Minoru Chikamune <[email protected]>
Reviewed-by: Kentaro Hara <[email protected]>
Reviewed-by: Alexander Timin <[email protected]>
Reviewed-by: Scott Haseley <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035376}
Roll src/third_party/cros_system_api/ 3befa16e0..1771b7788 (4 commits)
https://chromium.googlesource.com/chromiumos/platform2/system_api.git/+log/3befa16e0af0..1771b7788497
$ git log 3befa16e0..1771b7788 --date=short --no-merges --format='%ad %ae %s'
2022-08-02 whalechang system_api: Public NumberOfVolumeSteps for dbus api
2022-08-11 danielng vm_tools: extend vm info to support storage balloons
2022-08-01 timloh vm_tools: Add flag for setting Crostini IMEs env vars
2022-08-11 chenghaoyang Revert "system_api: Add mojo SensorHalClient Service name"
Created with:
roll-dep src/third_party/cros_system_api
Bug: b/231514911
Change-Id: I77e4e578ace0831df60559d3953c4b51ab1789fc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3831851
Reviewed-by: Daniel Ng <[email protected]>
Commit-Queue: Daniel Ng <[email protected]>
Auto-Submit: Timothy Loh <[email protected]>
Commit-Queue: Timothy Loh <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035375}
Roll src-internal from 68a199d434a2 to b21b98bdfcd7 (1 revision)
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/68a199d434a2..b21b98bdfcd7
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: [email protected]
Change-Id: I6060da12cda60407c9b3a30cd8a365fc9225a09e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3831189
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Reviewed-by: Jeevan Shikaram <[email protected]>
Owners-Override: Jeevan Shikaram <[email protected]>
Commit-Queue: Jeevan Shikaram <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035374}
Roll DevTools Frontend from be22ffa7215a to 806f4a2e1cd6 (1 revision)
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/be22ffa7215a..806f4a2e1cd6
2022-08-16 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS (trusted-origins)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: [email protected]
Change-Id: I094c155ca667b2692b661764ea1491bc544d59ee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3833222
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035373}
Always send change notifications on IOTask completion
HandleFileWatchNotification only sends out notifications if the file
path is being watched. However, the directory tree needs notifications
for folders outside of those being watched.
Also add a test to ensure the directory tree gets updated.
Bug: b/242133438
Change-Id: If923338f156db36ab514b5475fd171b0aab0c098
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3826858
Reviewed-by: Luciano Pacheco <[email protected]>
Commit-Queue: Austin Tankiang <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035372}
[launcher] Permanently use RemovedResultsRanker for Omnibox results.
This removes the call to OmniboxResult::InvokeAction for the
productivity launcher. It is a no-op in terms of actual behaviour,
since OmniboxResult::InvokeAction only operates for Remove actions.
Some extra context at
https://bugs.chromium.org/p/chromium/issues/detail?id=1272361#c4.
Bug: 1272361
Change-Id: I9e2e3eb844e18be290f6e35102bc50816b9abdbc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3747533
Reviewed-by: Amanda Deacon <[email protected]>
Commit-Queue: Rachel Wong <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035371}
Mark `text-transform-capitalize-018.html` as flaky on Linux
From crbug.com/906369#c34
external/wpt/css/css-text/text-transform/text-transform-capitalize-018.html -- This test flakiness had caused multiple Linux CI builder Linux tests(dbg)(1) red:
https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20Tests%20(dbg)(1)/107109/overview
https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20Tests%20(dbg)(1)/107087/overview
Image failure:
https://test-results.appspot.com/data/layout_results/Linux_Tests__dbg__1_/107109/blink_wpt_tests/layout-test-results/results.html
https://test-results.appspot.com/data/layout_results/Linux_Tests__dbg__1_/107087/not_site_per_process_blink_wpt_tests/layout-test-results/results.html
Dashboard:
https://data.corp.google.com/sites/chrome_generic_flakiness_dashboard_datasite/top_flakes/?f=test_id:eq:(null)&f=realm:in:(null)&f=shorten_test_name:in:external%2Fwpt%2Fcss%2Fcss-text%2Ftext-transform%2Ftext-transform-capitalize-018.html&f=variant_test_suite:in:blink_wpt_tests&can=2
and average 12%+ flaky rate in builds and 14% flaky rate in runs mostly on Linux and mac builders.
Bug: 906369
Change-Id: I91d1c435746c28f4aac640735f818de489583b2e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3831849
Reviewed-by: Kent Tamura <[email protected]>
Auto-Submit: Koji Ishii <[email protected]>
Commit-Queue: Koji Ishii <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035370}
Update expiration date of a few Net and Navigation throttle histograms
Bug: 1349006,1349007,1349047,1349048,1349052,1349053
Change-Id: I5cc04bab688676886c04c047fa72fd9dac44f18b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3828580
Commit-Queue: Takashi Toyoshima <[email protected]>
Commit-Queue: Clark DuVall <[email protected]>
Reviewed-by: Takashi Toyoshima <[email protected]>
Auto-Submit: Clark DuVall <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035369}
emoji-picker: disable tabs category scrolling
Out of view categories should only be viewable by clicking on the
chevrons. Using a scroll wheel no longer has any action.
Fixed: b:220202868
Change-Id: I6cfb4e81425019d5a115bc7231294f29e1478254
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3829758
Reviewed-by: John Palmer <[email protected]>
Reviewed-by: Mehrab N <[email protected]>
Commit-Queue: Zac Partridge <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035368}
Webhid: Fix UAF issue when BrowserContext is destroyed
There is a smaller window between BrowserContext and HidService
destruction timing in service worker condition, which creates an UAF
issue as the stored BrowserContext pointer can still be accessed by the
HidService. This is fixed by using weak pointer of
ServiceWorkerContextCore to access BrowserContext when it is valid.
This change also refactor HidService and its related unit tests to have
its constructors be used explicitly for RenderFrameHost or
ServiceWorkerContextCore.
Bug: 1347015
Change-Id: Id0c35da5a24ad4c742a0e58d17775b8db5180bf9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3809913
Reviewed-by: Marijn Kruisselbrink <[email protected]>
Commit-Queue: Jack Hsieh <[email protected]>
Reviewed-by: Matt Reynolds <[email protected]>
Reviewed-by: Ken Buchanan <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035367}
Revert "Add TRACE_EVENT Encode() function of MojoVEA and its clients"
This reverts commit 4609f724a3677c3ead89de51a5c50501fdc1053e.
Reason for revert: Causing compile failures in linux-perfetto-rel builder.
Example failure: https://ci.chromium.org/ui/p/chromium/builders/try/linux-perfetto-rel/8378
Original change's description:
> Add TRACE_EVENT Encode() function of MojoVEA and its clients
>
> This CL adds TRACE_EVENT to MojoVEA::Encode() and its caller functions
> so as to measure the pre-processing time like scaling and buffer
> allocation for Encode().
>
> Bug: b:241362231
> Test: chrome://tracing in Google Meet call
> Change-Id: Ic3cfa624230b20466bd7b96f96907283ee1959e7
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3812821
> Reviewed-by: Joe Downing <[email protected]>
> Reviewed-by: Ryan Keane <[email protected]>
> Commit-Queue: Hirokazu Honda <[email protected]>
> Reviewed-by: Eugene Zemtsov <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1035034}
Bug: b:241362231
Change-Id: If2e47912d0f36909b30092419ebb6b6a28212dc7
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3833514
Reviewed-by: Minoru Chikamune <[email protected]>
Reviewed-by: Jeevan Shikaram <[email protected]>
Commit-Queue: Jeevan Shikaram <[email protected]>
Owners-Override: Jeevan Shikaram <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035366}
Update V8 to version 10.6.172.
Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/5039a98e..dc38a218
Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues
Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_chromeos_msan_rel_ng
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel
[email protected],[email protected],[email protected]
Change-Id: I6763fe1ee37f66b72e9764e625fda73eac595357
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832511
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1035365}
Roll libc++ from 6cc58d640cfe to 5df82514bc00 (4 revisions)
https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/6cc58d640cfe..5df82514bc00
2022-08-15 [email protected] [test][libc++][hwasan] Handle hwaddress_sanitizer
2022-08-15 [email protected] [libc++][test] Fix conversion signed/unsigned in test/support/MoveOnly.h
2022-08-14 [email protected] [libc++][spaceship] Implement std::variant::operator<=>
2022-08-14 [email protected] Revert "[clang] adds unary type transformations as compiler built-ins"
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/libcxx-chromium
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: [email protected],[email protected]
Change-Id: I79e958d2c0efbce8cd46e881ebefe0fe5e3889df
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832677
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035364}
Roll WebRTC from ab6233708cfe to 93fd55a030e8 (2 revisions)
https://webrtc.googlesource.com/src.git/+log/ab6233708cfe..93fd55a030e8
2022-08-15 [email protected] Roll chromium_revision 9c813849ab..dafd6f34c3 (1035116:1035229)
2022-08-15 [email protected] Combine setters for protection payload types (red and ulpfec)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in WebRTC: https://bugs.chromium.org/p/webrtc/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: [email protected]
Change-Id: I485693ab1b57f7390f5c6f2de5dd21397769e323
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832840
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035363}
[anchor-position] Support block-fragmented containing block
r1028600 crrev.com/c/3787752 and r1028608 crrev.com/c/1309178
supported inline-/block-fragmented anchors by uniting
fragments as specified. However, that was not enough to
support when the containing block of the querying element is
block-fragmented.
In that case, OOFs are added to their fragmentainers, and the
coordinate system is stitched. This patch supports such case
by constructing a stitched |NGLogicalAnchorQuery| and a
specialized |NGAnchorEvaluatorImpl|.
Bug: 1309178
Change-Id: Id6693df1dab213f29da7c04dc1684ef9e79ea2a8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3823145
Commit-Queue: Koji Ishii <[email protected]>
Reviewed-by: Morten Stenshorne <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035362}
FrameSet NG: Add skeleton code of NGFrameSetLayoutAlgorithm class
This CL has no behavior changes. The class is not used yet.
Bug: 1346221
Change-Id: Iafe6788efac1485167749f8a9f53f46ae394a844
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3828296
Reviewed-by: Koji Ishii <[email protected]>
Auto-Submit: Kent Tamura <[email protected]>
Commit-Queue: Koji Ishii <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035361}
[anchor-position] Fix when the containing block has borders
In CSS, "the containing block is formed by the padding
edge"[1], while our geometry is based on the border box.
This patch fixes |NGAnchorEvaluatorImpl| to return the padding
box instead of the border box.
[1] https://www.w3.org/TR/CSS21/visudet.html#containing-block-details
Bug: 1309178
Change-Id: I046feaf0977863549cf51bfe97263323ffc04217
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3817423
Auto-Submit: Koji Ishii <[email protected]>
Reviewed-by: Kent Tamura <[email protected]>
Commit-Queue: Kent Tamura <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035360}
Migrate //chromeos/ash/services/assistant to namespace ash [4/N]
This CL migrates public/proto to namespace ash from chromeos.
This CL is part of the Chrome OS source code directory migration:
https://docs.google.com/document/d/1g-98HpzA8XcoGBWUv1gQNr4rbnD5yfvbtYZyPDDbkaE.
Change-Id: Ib960e94715b1d6fe57a41974f92c1baf0acbfeb2
Bug: 1164001
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3806390
Owners-Override: Hidehiko Abe <[email protected]>
Commit-Queue: Yeunjoo Choi <[email protected]>
Reviewed-by: Tao Wu <[email protected]>
Reviewed-by: Hidehiko Abe <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035359}
Roll Chrome Mac Arm PGO Profile
Roll Chrome Mac Arm PGO profile from chrome-mac-arm-main-1660586298-2836e78d4fbda95205a30dedbe1f118d9ae71008.profdata to chrome-mac-arm-main-1660607946-21fc3ac742bbf512e36ac315bd686a31e4bae5f8.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-arm-chromium
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:mac-chrome
Tbr: [email protected]
Change-Id: I64ec050814fd068d588bd08cff6bbfed646d785b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832452
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035358}
[files] Pass SessionManager in as a dependency to ZS drive provider.
In line with the dependency injection structure of the
ZeroStateDriveProvider, pass the SessionManager in during construction
rather than retrieving it from the global state.
Bug: 1348449
Change-Id: I2f07826f229faed01f3ebce4b05d0443d44a604e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3828779
Reviewed-by: Amanda Deacon <[email protected]>
Commit-Queue: Rachel Wong <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035357}
Roll Fuchsia Internal Images from 9.20220815.2.1 to 9.20220815.3.1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/fuchsia-internal-images-chromium
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:fuchsia-fyi-astro
Tbr: [email protected]
Disable-Retries: true
Change-Id: I2c222c3a7cc46d9dff1db14a5201c4a639884073
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832997
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1035356}
WebUI: Check-in Polymer3 version of cr_toggle/
Bug: 1184053
Change-Id: I5bdd048a328d152b1568fe1ac17f75b65512ef47
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3811440
Reviewed-by: Luciano Pacheco <[email protected]>
Reviewed-by: John Lee <[email protected]>
Commit-Queue: Rebekah Potter <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035355}
Change pop-up light dismiss trigger from mousedown to mouseup
Per the resolution [1], it is better for users to trigger light-
dismiss on mouseup rather than mousedown, because it makes it less
likely that an accidental mouse-down will cause a pop-up to hide,
possibly losing state.
[1] https://github.com/openui/open-ui/issues/529#issuecomment-1205605282
Bug: 1307772
Change-Id: Ib6b3ab633cecc4e051bbfc7857c4177c14e2419e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3830822
Reviewed-by: Joey Arhar <[email protected]>
Auto-Submit: Mason Freed <[email protected]>
Commit-Queue: Joey Arhar <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035354}
Record website usage time UKM Part II.
go/cros-app-metrics-website
Implement the UKM report for website url, and apply noise for the
running time in each 5 minutes.
BUG=1334173
Change-Id: Ia670557ded4271b2133ba743aae70030f5352793
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3744322
Reviewed-by: Dominick Ng <[email protected]>
Reviewed-by: Robert Kaplow <[email protected]>
Reviewed-by: Yue Ru Sun <[email protected]>
Commit-Queue: Nancy Wang <[email protected]>
Reviewed-by: Nancy Wang <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035353}
fusebox: speak POSIX errno's across D-Bus
Having the D-Bus protocol use standard POSIX errno codes (e.g. ENOENT)
instead of e.g. base::File::Error::FILE_ERROR_NOT_FOUND codes means that
the D-Bus client (which is not part of the Chrome binary) does not need
to depend on Chrome's //base/file (or keep in cross-repo sync with any
changes to the base::File::Error enum).
This continues the work started in crrev.com/c/3615961
BUG=chromium:1249370
Change-Id: I3bffcd270d66f83b0b5e331fe11bd4ef09e70b0d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3828339
Reviewed-by: Ben Reich <[email protected]>
Auto-Submit: Nigel Tao <[email protected]>
Reviewed-by: Ryo Hashimoto <[email protected]>
Commit-Queue: Ryo Hashimoto <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035352}
Roll Chrome Win32 PGO Profile
Roll Chrome Win32 PGO profile from chrome-win32-main-1660596999-38042d5219e1af86f427bbe0b6e1921399cc7d51.profdata to chrome-win32-main-1660607946-9644f6ef70baeac7eebd3b368b81b4f239b82703.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win-chrome
Tbr: [email protected]
Change-Id: Ie9f80c2156baf6be00dd12cc3139577b15ee4c1e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3831405
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035351}
[mparch] Use NR::frame_tree_node instead of RFHI::frame_tree_node_(2/4)
This CL replaces `frame_tree_node_` with
NavigationRequest::frame_tree_node() in
RenderFrameHostImpl::CanSubframeCommitOriginAndUrl() to use the
relevant FrameTreeNode during navigation.
Bug: 1350575
Change-Id: I209645a9c79bf233fb8d524f2a0c567f84d790d7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3831835
Reviewed-by: Alexander Timin <[email protected]>
Commit-Queue: Julie Jeongeun Kim <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035350}
Roll vulkan-deps from fb0e26499a68 to 863822794aa7 (3 revisions)
https://chromium.googlesource.com/vulkan-deps.git/+log/fb0e26499a68..863822794aa7
Changed dependencies:
* spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/3a8a961cff..9abacb34a5
* vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/50fe2fc2d0..e51d0d1c18
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-chromium-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86;luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:win-asan;luci.chromium.try:linux_chromium_cfi_rel_ng
Bug: None
Tbr: [email protected],[email protected],[email protected]
Change-Id: Ia142eec4a217e59e0893fbd934098211c28998ad
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3827859
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035349}
[mparch] Use NR::frame_tree_node instead of RFHI::frame_tree_node_(1/4)
This CL replaces `frame_tree_node_` with
NavigationRequest::frame_tree_node() in
RenderFrameHostImpl::CommitNavigation() to use the relevant
FrameTreeNode during navigation.
Bug: 1350575
Change-Id: Id576487c83fcba26720a3c701d847254f2a21bee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3829013
Reviewed-by: Alexander Timin <[email protected]>
Commit-Queue: Julie Jeongeun Kim <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035348}
[CodeHealth] TranslateInternalsHandler base::Value refactor
This CL updates the use of base::Value, avoiding the use of any
deprecated base::Value methods into TranslateInternalsHandler.
Bug: 1187001
Change-Id: I7744d26a0b4ca2c2362ec89465102af5398598b2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3827262
Commit-Queue: Claudio DeSouza <[email protected]>
Reviewed-by: Giovanni Ortuno Urquidi <[email protected]>
Reviewed-by: Mike Dougherty <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035347}
Roll Chrome Mac PGO Profile
Roll Chrome Mac PGO profile from chrome-mac-main-1660586298-c6a583817d54635ca6eb80e0f97694b6d27004c2.profdata to chrome-mac-main-1660607946-f1457d50bd4512f77090bbaad1f58f950b8f9471.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:mac-chrome
Tbr: [email protected]
Change-Id: Ie1f0f9d9a660b0d27553f507f87e1d282a9c0fd3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3831185
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035346}
Fix typo and extra word in base/memory/raw_ptr.md.
Change-Id: I1589ac4cd18ca4dc7e3a3d4100a1b2651272e416
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3831747
Reviewed-by: Keishi Hattori <[email protected]>
Commit-Queue: Keishi Hattori <[email protected]>
Auto-Submit: Emil Mikulic <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035345}
Migrate //chromeos/ash/components/dbus/shill to namespace ash
This CL is part of the Chrome OS source code directory migration:
https://docs.google.com/document/d/1g-98HpzA8XcoGBWUv1gQNr4rbnD5yfvbtYZyPDDbkaE.
Bug: 1164001
Change-Id: Ibf668d53f9b6e337e236314dcead0bbece58a3a0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3825677
Commit-Queue: Yeunjoo Choi <[email protected]>
Reviewed-by: Hidehiko Abe <[email protected]>
Owners-Override: Hidehiko Abe <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035344}
ChromeOS: Start stack sampler after sandboxing on renderer
Similar to
https://chromium-review.googlesource.com/c/chromium/src/+/3764862, on
ChromeOS, SandboxLinux::InitializeSandbox will AssertSingleThreaded.
Since the stack sampler starts a new thread, it must be created after
the sandbox is initialized.
BUG=b:214117401,chromium:1324337
Change-Id: I451e1297980f7bb0b77b238480eca0a7fcd40e44
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3767428
Reviewed-by: John Abd-El-Malek <[email protected]>
Commit-Queue: Ian Barkley-Yeung <[email protected]>
Reviewed-by: Mike Wittman <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035343}
Change ARCVM GuestOS volume to be Android volume
This CL change the ARCVM GuestOS volume to be an Android volume so that
all the customizations (that are described in
go/arc:play-files-sshfs-ui) that are specific to Android volume works.
Bug: b:215255080
Test: Manual check
Change-Id: If1691adf68f04bde9bf3308551e7e84f89e43741
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3824939
Reviewed-by: David Munro <[email protected]>
Commit-Queue: Risan <[email protected]>
Reviewed-by: Luciano Pacheco <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035342}
Eliminate unnecessary function wrapping in ComServerApp.
Bug: 1293203
Change-Id: If925d32105b6aebbda950af5ff6f8a49a6cb7964
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832536
Reviewed-by: Joshua Pawlicki <[email protected]>
Reviewed-by: S Ganesh <[email protected]>
Commit-Queue: Sorin Jianu <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035341}
Migrate //chromeos/ash/components/dbus/cros_disks to namespace ash [5/N]
This CL migrates remaining enums from chromeos to namespace ash and
changes to enum class.
This CL is part of the Chrome OS source code directory migration:
https://docs.google.com/document/d/1g-98HpzA8XcoGBWUv1gQNr4rbnD5yfvbtYZyPDDbkaE.
Change-Id: I193d8126b6e2175404c9cacdd9edb8414075d50a
Bug: 1164001
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3815106
Owners-Override: Hidehiko Abe <[email protected]>
Commit-Queue: Yeunjoo Choi <[email protected]>
Reviewed-by: Bo Majewski <[email protected]>
Reviewed-by: Hidehiko Abe <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035340}
[style_var_gen] Add proto fields to cros token json5 files
Includes the proto field definitions into the token json5 files and
adds goldens.
Bug: b/240376038
Change-Id: I2c5bb93df193a585f3da63715a4d1c7a42601dbe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3827450
Reviewed-by: Zain Afzal <[email protected]>
Commit-Queue: Meredith Lane <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035339}
ash: Check >1 displays in SetDisplayLayoutMode
This CL adds a check to CrosDisplayConfig::SetDisplayLayoutMode() that
ensures there is more than one display before setting a new display layout mode.
test webpage: https://alder-versed-polyanthus.glitch.me/
to access API calls.
Bug: b:241900074, b:240297404
Test: Setup a semi-kiosk mode with a Chrome Extension API
Change-Id: I369dc40ecea4a0279b638e1a3d89bbe8bcfd06b2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3829649
Reviewed-by: Mitsuru Oshima <[email protected]>
Reviewed-by: Ahmed Fakhry <[email protected]>
Reviewed-by: Robert Sesek <[email protected]>
Commit-Queue: Gil Dekel <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035338}
Roll src-internal from 115058df3cd4 to 68a199d434a2 (1 revision)
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/115058df3cd4..68a199d434a2
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: [email protected]
Change-Id: I6ac2af29764a3c0ced747377890e5f438bc9ecaa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3831293
Reviewed-by: Jeevan Shikaram <[email protected]>
Owners-Override: Jeevan Shikaram <[email protected]>
Commit-Queue: Jeevan Shikaram <[email protected]>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1035337}
Updating trunk VERSION from 5243.0 to 5244.0
* This is an automated release commit.
* Do not revert without consulting [email protected].
NOAUTOREVERT=true
Change-Id: I7d48f875714637267f5d660b5948036675c97b9b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832464
Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1035336}
Roll PDFium from e172d7c167c6 to edf817eed90f (10 revisions)
https://pdfium.googlesource.com/pdfium.git/+log/e172d7c167c6..edf817eed90f
2022-08-15 [email protected] Mark CFWL_ThemeBackground as stack-allocated.
2022-08-15 [email protected] Encapsulate CFXJS_PerObjectData public instance variables.
2022-08-15 [email protected] Rename FXMEM_InitializePartitionAlloc() to FX_InitializeMemoryAllocators()
2022-08-15 [email protected] Make CPDF_PageObject::m_Rect a private member.
2022-08-15 [email protected] Fully encapsulate Partition Alloc in fx_memory.cpp
2022-08-15 [email protected] Introduce CFGAS_GEGraphics::StateRestorer
2022-08-15 [email protected] Avoid a copy in CPDFSDK_InteractiveForm::SubmitForm().
2022-08-15 [email protected] Remove use of skia_core_defines
2022-08-15 [email protected] Encapsulate CFWL_ThemeBackground::m_pPath
2022-08-15 [email protected] Remove in-out parameter from FDFToURLEncodedData().
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pdfium-autoroll
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in PDFium: https://bugs.chromium.org/p/pdfium/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: [email protected]
Change-Id: I96e7eb18bb16ea728f0d819fc541ce2ef8b9c49c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3831291
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035335}
[launcher] Update the policy for zero state app recommendations.
Zero state app recommendations are no longer supported in the launcher
and were removed in M100 at crrev.com/c/3307860. This CL updates the
enterprise policy to reflect the removal.
Bug: b/229354168
Change-Id: I814ab0019f322d20528fe2a2c1bfb1aed2408257
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3826615
Commit-Queue: Rachel Wong <[email protected]>
Reviewed-by: Julian Pastarmov <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035334}
Roll Chrome Win64 PGO Profile
Roll Chrome Win64 PGO profile from chrome-win64-main-1660596999-4f87e7e4108e3777b08968025e771c83a2d74b54.profdata to chrome-win64-main-1660607946-dd44455994bd6ed145d7eb27db7171b2d89adea3.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win64-chrome
Tbr: [email protected]
Change-Id: I5252997104ad9b28c09b418fe34ed1311af32dde
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3833214
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035333}
Add sequence checker to ReportingClient::Uploader
Bug: b:236097755
Change-Id: I5e189d490b826163f316bfed99a033af640df9c5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832377
Reviewed-by: Leonid Baraz <[email protected]>
Auto-Submit: Hong Xu <[email protected]>
Commit-Queue: Hong Xu <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035332}
[mparch] Replace FTN::IsInFencedFrameTree with IsNestedWithinFencedFrame
In order to remove RFHI::frame_tree_node_ (crbug.com/1179502), this CL
replaces frame_tree_node_->IsInFencedFrameTree with
RFHI::IsNestedWithinFencedFrame.
Bug: 1350600
Change-Id: I7f36a7f1202a45a64a58d3b7cc7f8bce789e8d2b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3823540
Reviewed-by: Alexander Timin <[email protected]>
Commit-Queue: Hyowon Kim <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035331}
float: Implement for lacros p1.
Adds set/unset float event and pipes it through wayland into exo.
Right now kWindowStateTypeKey in Lacros does not change to float state,
so this works like a toggle, calling set float all the time, which
temporarily toggles float on ash side.
Once https://chromium-review.googlesource.com/c/chromium/src/+/3810538
has landed, we can use configure to update the kWindowStateTypeKey in
Lacros using configure event.
Test: tbd
Bug: 1347534
Change-Id: I202a4124c2796aa5fb9d03a6f9538ede0ed2f97c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3792887
Reviewed-by: Mitsuru Oshima <[email protected]>
Commit-Queue: Sammie Quon <[email protected]>
Reviewed-by: Scott Violet <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035330}
Revert "[Floss] Refactor WriteDBusParamIntoVariant"
This reverts commit 8e1badaca38627376b4f1274c8b758c0d318f764.
Reason for revert:
Findit (https://goo.gl/kROfz5) identified this CL at revision 8e1badaca38627376b4f1274c8b758c0d318f764 as
the culprit for failures in the continuous build including:
Sample Failed Build: https://ci.chromium.org/b/8805713332501153025
Sample Failed Step: compile
If it is a false positive, please report it at https://bugs.chromium.org/p/chromium/issues/entry?status=Available&comment=Datastore+key+for+the+culprit+entity%3A+chromium.googlesource.com%2Fchromium%2Fsrc%2Frefs%2Fheads%2Fmain%2F8e1badaca38627376b4f1274c8b758c0d318f764&labels=Test-Findit-Wrong&components=Tools%3ETest%3EFindIt&summary=Wrongly+blame+8e1badaca38627376b4f1274c8b758c0d318f764
Original change's description:
> [Floss] Refactor WriteDBusParamIntoVariant
>
> This refactors WriteDBusParamIntoVariant to minimize the multiple
> similar definitions by creating a general definition that will call the
> specific WriteDBusParam inside a variant, so that implementations need
> to focus only on WriteDBusParam for each new type.
>
> This adds DBusTypeInfo which will be useful for ExportedCallbackManager
> to provide a more meaningful error message when automatically parsing
> D-Bus parameters.
>
> Bug: b:233124021
>
> Change-Id: Ic6771958e2c1aa2f2a2167bcc2f9885ca8adca29
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3828504
> Reviewed-by: Abhishek Pandit-Subedi <[email protected]>
> Commit-Queue: Sonny Sasaka <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1035324}
Change-Id: Iab0189196975722fbef7791b75a29aa5cac7f39c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: b:233124021
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3833334
Owners-Override: Jeevan Shikaram <[email protected]>
Reviewed-by: Jeevan Shikaram <[email protected]>
Commit-Queue: Jeevan Shikaram <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035329}
Suppress stderr during unit test case
No change to logic. One of the test cases in version_test.py
intentionally triggers an argparse error and catches the exception. This
test case originally did not suppress the stderr message though, so this
updates the test to suppress that by mocking sys.stderr.
I verified this change does not interfere with assertion failures.
Assertion failures are still printed as expected, even if the assertion
violation occurs while stderr is mocked.
Fixed: 1344991
Test: vpython3 build/util/version_test.py
Change-Id: I62f9409634177b2a3bc07daf9f49ae66b1b43956
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3830075
Reviewed-by: Takuto Ikuta <[email protected]>
Commit-Queue: Takuto Ikuta <[email protected]>
Auto-Submit: Nate Fischer <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035328}
Roll Chrome Linux PGO Profile
Roll Chrome Linux PGO profile from chrome-linux-main-1660586298-d8ee82923629a44e5ca8bcf8bc5fd33e4ba3bb83.profdata to chrome-linux-main-1660607946-c55ac51ed3ad2d99676608338c73d1e6acc4162c.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-linux-chromium
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:linux-chrome
Tbr: [email protected]
Change-Id: I4b0e44de9eb901a47ed6fd297c8e9043a05a0c43
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832681
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035327}
Fix info bar background color in web app windows
This CL makes info bars in web app windows use the same color scheme
as the CCT bar (CustomTabBarView). This uses the OS dark mode colors
rather than using the app's theme/background color.
Screenshots:
Before: https://bugs.chromium.org/p/chromium/issues/attachment?aid=565655&signed_aid=igpBAXOBi3xPWaP58V0ZlA==&inline=1
After (light mode): https://bugs.chromium.org/p/chromium/issues/attachment?aid=565654&signed_aid=tQ1l_k6hFgnAdILPXWlwyA==&inline=1
After (dark mode): https://bugs.chromium.org/p/chromium/issues/attachment?aid=565653&signed_aid=6bbimCNfRS_2bmmqom94Xw==&inline=1
Bug: 1351610
Change-Id: I9be3ac0cca0693b2afae1e22fe1f7ee76a4a903c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3829026
Reviewed-by: Tim Sergeant <[email protected]>
Commit-Queue: Alan Cutter <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035326}
Rename kRpNotPotentiallyTrustworthy->kIdpNotPotentiallyTrustworthy
This CL:
- Renames enum value kRpNotPotentiallyTrustworthy to the more
accurate kIdpNotPotentiallyTrustworthy
- Refactors federated_auth_request_impl_unittest.cc and merges
kIdpTestOrigin, kProviderUrl and kProviderUrlFull constants
BUG=None
Change-Id: I7e310f55433c976c2d250dd62fe12dd46ac4a743
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832299
Commit-Queue: Peter Kotwicz <[email protected]>
Reviewed-by: Yi Gu <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035325}
[Floss] Refactor WriteDBusParamIntoVariant
This refactors WriteDBusParamIntoVariant to minimize the multiple
similar definitions by creating a general definition that will call the
specific WriteDBusParam inside a variant, so that implementations need
to focus only on WriteDBusParam for each new type.
This adds DBusTypeInfo which will be useful for ExportedCallbackManager
to provide a more meaningful error message when automatically parsing
D-Bus parameters.
Bug: b:233124021
Change-Id: Ic6771958e2c1aa2f2a2167bcc2f9885ca8adca29
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3828504
Reviewed-by: Abhishek Pandit-Subedi <[email protected]>
Commit-Queue: Sonny Sasaka <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035324}
[ios][feed] Dispatch expiration handler to main
The expiration handler seems to be called on a non-main thread.
Bug: 1343695, 1352470
Change-Id: I820837b79665953af6fdf3b8f47f04fb57e5afbe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832463
Commit-Queue: Sergio Collazos <[email protected]>
Commit-Queue: edchin <[email protected]>
Auto-Submit: edchin <[email protected]>
Reviewed-by: Sergio Collazos <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035323}
Revert "[ios] Fix tests for kTrendingQueriesModule"
This reverts commit 8eea7a0bd9b8839ad75284147e153d3ed68a5a93.
Reason for revert: Suspected CL for failing tests on ios-simulator-noncq.
Example build: https://ci.chromium.org/ui/p/chromium/builders/ci/ios-simulator-noncq/27943/overview
Original change's description:
> [ios] Fix tests for kTrendingQueriesModule
>
> Forces a particular experiment arm that doesn't hide Shortcuts. Also,
> a test is added to validate the Trending Queries module.
>
> Bug: 1350826, 1352158
> Change-Id: Ie44481ae884018361e3916d793fe0b444068c269
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3817208
> Commit-Queue: Chris Lu <[email protected]>
> Reviewed-by: Rohit Rao <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1035246}
Bug: 1350826, 1352158
Change-Id: Ib93f50a1ebd6c21749f737dabc23780e6c67cd8b
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3828215
Commit-Queue: Jeevan Shikaram <[email protected]>
Owners-Override: Jeevan Shikaram <[email protected]>
Auto-Submit: Jeevan Shikaram <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035322}
Revert "Switch ash and lacros CI builders to cores 8 machines"
This reverts commit 225a93fee467deedc284120154bf37fc17a5c05d.
Reason for revert: This immediately caused issues.
https://ci.chromium.org/ui/p/chromium/builders/ci/linux-lacros-builder-rel/34551/overview
https://ci.chromium.org/ui/p/chromium/builders/ci/linux-lacros-dbg/11279/overview
https://ci.chromium.org/ui/p/chromium/builders/ci/linux-chromeos-rel/58909/overview
Original change's description:
> Switch ash and lacros CI builders to cores 8 machines
>
> Experiment whether a lower performance machine is enough.
>
> Bug: 1345687
> Change-Id: I1bbfd6299f315cf228c525c87f07838d81102ab6
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3829091
> Auto-Submit: Sven Zheng <[email protected]>
> Reviewed-by: Gary Tong <[email protected]>
> Commit-Queue: Sven Zheng <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1035231}
Bug: 1345687
Change-Id: Ide181bf03fb764d0495b3831128db568b6abf069
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3827809
Auto-Submit: Sven Zheng <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035321}
Extends Grid and Group M5 flags
Change-Id: I6cadf8418145ce139bce22342a5da61dfa60ddf1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3830226
Auto-Submit: Mei Liang <[email protected]>
Reviewed-by: Yue Zhang <[email protected]>
Commit-Queue: Yue Zhang <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035320}
Import wpt@6c73ed5ac9660688ccbfe86d28e835a9c886bfca
Using wpt-import in Chromium 8eea7a0bd9b8839ad75284147e153d3ed68a5a93.
Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md
Directory owners for changes in this CL:
[email protected], [email protected]:
external/wpt/FileAPI
[email protected], [email protected], [email protected]:
external/wpt/fetch
NOAUTOREVERT=true
[email protected]
No-Export: true
Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-input-fyi-rel,linux-blink-rel
Change-Id: I9a474920dbd9020116001b4a6b2f7ce726e4af2b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832143
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Auto-Submit: WPT Autoroller <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035319}
Re-organize find_in_page_native_api
This CL contains no functional changes, but only re-orders the contents
of find_in_page_native_api to group variables and functions by type in
preparation for converting the file to TypeScript.
Bug: 1348327
Change-Id: I4d69b0a061e6ffa0219d154c2c29c3da45c597fa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3826434
Reviewed-by: Chris Lu <[email protected]>
Commit-Queue: Mike Dougherty <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035318}
Quota: Enable flag to deprecate persistent quota
Enable flag by default to deprecate persistent quota.
Extend expiration for persistent-quota flag.
Updates tests to either check if the feature is enabled,
or removes tests that become irrelevant with the deprecation.
I2R: https://groups.google.com/a/chromium.org/g/blink-dev/c/ziTjKMdOqz8/m/rwpc02S-BgAJ
Bug: 1233525
Change-Id: I4ea6a3addcfc2dc0c128d18c9613fd3f5610f6f3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3769282
Reviewed-by: Kent Tamura <[email protected]>
Reviewed-by: Marijn Kruisselbrink <[email protected]>
Reviewed-by: Michael Thiessen <[email protected]>
Reviewed-by: Kentaro Hara <[email protected]>
Commit-Queue: Ayu Ishii <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035317}
[chrome][printing] Fix build when enable_basic_printing=false
The fix is consistent with TestingBrowserProcess and the
print preview-related code in the same class.
Bug: 1352700
Change-Id: I4f359158e1849ca40fc179504238594fdfb72b96
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832146
Reviewed-by: Lei Zhang <[email protected]>
Commit-Queue: David Dorwin <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035316}
Revert "[sheriff] Disable test on ChromeOS"
This reverts commit 0b7a3a1c1e1b2eda918d4c54d414b848e3c73bb2.
Reason for revert:
The broken test has been fixed by CL:3826320.
Original change's description:
> [sheriff] Disable test on ChromeOS
>
> This CL disables the following test on ChromeOS:
> FullRestoreAppLaunchHandlerBrowserTest.NoBrowserOnLaunch
>
> Bug: 1351532
> Change-Id: I8177054d363910e16a76cf0b85758f26ae1ce5b3
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3822583
> Commit-Queue: Marc Treib <[email protected]>
> Auto-Submit: Rushan Suleymanov <[email protected]>
> Commit-Queue: Rushan Suleymanov <[email protected]>
> Owners-Override: Rushan Suleymanov <[email protected]>
> Reviewed-by: Marc Treib <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1033440}
Bug: 1351532, 1351396
Change-Id: I62a52489060f44e54283095b49c8d9ebe146fb00
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3827936
Commit-Queue: Nancy Wang <[email protected]>
Reviewed-by: Xiyuan Xia <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035315}
webview: Add a flag to the webview UI for overflow on replaced elements
This experiment will be enabled on webview so requires a flag to toggle
in the UI
[email protected]
Bug: 1321217
Change-Id: Idcb94ff6cef6fe25a6d430960bf04892a8d47da9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832815
Reviewed-by: Bo Liu <[email protected]>
Auto-Submit: Khushal Sagar <[email protected]>
Commit-Queue: Khushal Sagar <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035314}
move TabActivationTypes to tab_enums
Change-Id: I2a5a364c4e27811f5314b25030d96b1073ec9e78
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3810983
Reviewed-by: Taylor Bergquist <[email protected]>
Reviewed-by: Thomas Lukaszewicz <[email protected]>
Commit-Queue: David Pennington <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035313}
[Files app] Use MountPoint instead of MountPointInfo
Use the shorter name of this struct.
Use brace initialization when constructing MountPoint values.
Less code for the same thing.
BUG=chromium:1313346
TEST=autoninja -C out/Default unit_tests browser_tests components_unittests ash_components_unittests
Change-Id: I169c9e99ef052e393412f84324133ec8a86aca86
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3827455
Reviewed-by: Nic Hollingum <[email protected]>
Commit-Queue: François Degros <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035312}
[a11y-during-render] Move AXImageAnnotator logic out of BlinkAXTreeSource
It's now directly in RenderAccessibilityImpl. This achieves the
following goals:
* Decouple from BlinkAXTreeSource (therefore unblocking a11y onion
soup for that class)
* Avoid conflict with devtools inspector code that ended up calling
this code but wasn't actually compatible with using it.
Note that this new code is going to be slightly slower than the old
code, because it iterates over the AXTreeUpdate node list rather
than annotating in the moment.
AX-Relnotes: n/a.
Bug: 1068668, 1342801
Change-Id: I1ad9c3e90da5c497467863197b7a00ab2e0fd241
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3812410
Commit-Queue: Chris Harrelson <[email protected]>
Reviewed-by: David Tseng <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035311}
Roll WebRTC from 1c5f317e178a to ab6233708cfe (1 revision)
https://webrtc.googlesource.com/src.git/+log/1c5f317e178a..ab6233708cfe
2022-08-15 [email protected] Roll chromium_revision 9ae72ef099..9c813849ab (1034994:1035116)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in WebRTC: https://bugs.chromium.org/p/webrtc/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: [email protected]
Change-Id: Ib31192d8501c831960367227db16e1fea736f4d8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3831593
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035310}
Remove uses of `_isTitleHidden`
There's API to accomplish this, so use it.
Bug: 876613
Change-Id: I5e232b615a5fb9703b04c9c2c667802bde20be1a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832456
Reviewed-by: Ben Wells <[email protected]>
Commit-Queue: Ben Wells <[email protected]>
Auto-Submit: Avi Drissman <[email protected]>
Reviewed-by: Leonard Grey <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035309}
ChromeOS: Start stack sampler after sandboxing on gpu-process
On ChromeOS, the gpu-process will AssertSingleThreaded() during
sandboxing. Therefore, we can't start the stack sampler (which creates a
thread) until after sandboxing.
BUG=b:214117401,chromium:1324337
Change-Id: Icfee509869f2bda9d2fe124a3146e8d98ef84708
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3764862
Reviewed-by: Hirokazu Honda <[email protected]>
Reviewed-by: Kenneth Russell <[email protected]>
Commit-Queue: Ian Barkley-Yeung <[email protected]>
Reviewed-by: John Abd-El-Malek <[email protected]>
Reviewed-by: Mike Wittman <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035308}
webauthn: drop kWebAuthCableDisco
This feature controls whether the caBLE authenticator will accept
discoverable credential requests. The code checked the request before
sending it to Play Services and showed an error if it was a discoverable
credential request, because Play Services can't satisfy those.
But soon it will, so this change drops the flag and always sends a
request to Play Services. If Play Services rejects the request then we
recognise the error code (and, sadly, error string in one case) and
_then_ show the error if discoverable credentials aren't supported.
Bug: b/241938657
Change-Id: I5b8a3935c1ff0de30d0ac151afc85e437f9cdca1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3824992
Reviewed-by: Martin Kreichgauer <[email protected]>
Auto-Submit: Adam Langley <[email protected]>
Commit-Queue: Adam Langley <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035307}
[Files app] Use MountPoint instead of MountPointInfo
Use the shorter name of this struct.
Use brace initialization when constructing MountPoint values.
Less code for the same thing.
BUG=chromium:1313346
TEST=CQ
Change-Id: I87d4cd1879e6bcddc301f6fbf024881b0745a093
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3827608
Commit-Queue: François Degros <[email protected]>
Reviewed-by: Lei Zhang <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035306}
PageLoadMetrics: Prerender2 support for FencedFramesPageLoadMetricsObserver
No behavioural change.
This CL makes it clear to use STOP_OBSERVING for
FencedFramesPageLoadMetricsObserver.
Bug: 1317494
Change-Id: Iae2f5ad7024fd32aa41384830107a4223da799c3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3828211
Commit-Queue: Ken Okada <[email protected]>
Reviewed-by: Kouhei Ueno <[email protected]>
Reviewed-by: Takashi Toyoshima <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035305}
RTCVideoEncoder: Don't copy buffer to EncodedBuffer
RTCVideoEncoder passes the bitstream buffer to webrtc::EncodedImage
with webrtc::EncodedBuffer. EncodedBuffer allocates a buffer and
copies into the buffer every BitstreamBufferReady().
This CL reduces the buffer allocation and memory copy by giving
EncodedImage EncodedDataWrapper. EncodedDataWrapper doesn't own the
buffer and calls UseOutputBitstreamBufferId on destruction.
Bug: b:241349739
Test: Google Meet call
Change-Id: Id849eece6973005f4cdabc8facf04df0e1a1ba24
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3811035
Reviewed-by: Eugene Zemtsov <[email protected]>
Commit-Queue: Hirokazu Honda <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035304}
[chrome][printing] Use correct BUILDFLAG for Policy Handlers
This fixes a build error when enable_pdf=false and
enable_basic_printing=true.
Bug: 1352700
Change-Id: I4ac112350355f897bb5070f8c386ed76929bd042
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3829264
Reviewed-by: Lei Zhang <[email protected]>
Commit-Queue: David Dorwin <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035303}
Revert "[Cleanup] Delete old-gen and rename file to "structured_events"."
This reverts commit cafd7edfbf6fb4347ac9e1b62ec9d2feaab9736e.
Reason for revert:
Findit (https://goo.gl/kROfz5) identified this CL at revision cafd7edfbf6fb4347ac9e1b62ec9d2feaab9736e as
the culprit for failures in the continuous build including:
Sample Failed Build: https://ci.chromium.org/b/8805718468534313137
Sample Failed Step: compile
If it is a false positive, please report it at https://bugs.chromium.org/p/chromium/issues/entry?status=Available&comment=Datastore+key+for+the+culprit+entity%3A+chromium.googlesource.com%2Fchromium%2Fsrc%2Frefs%2Fheads%2Fmain%2Fcafd7edfbf6fb4347ac9e1b62ec9d2feaab9736e&labels=Test-Findit-Wrong&components=Tools%3ETest%3EFindIt&summary=Wrongly+blame+cafd7edfbf6fb4347ac9e1b62ec9d2feaab9736e
Original change's description:
> [Cleanup] Delete old-gen and rename file to "structured_events".
>
> Bug: 1249222
> Change-Id: I5a48cd57db05c13a137825a1e036a8fd4bee6e97
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3827385
> Reviewed-by: Tony Yeoman <[email protected]>
> Commit-Queue: Jong Ahn <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1035291}
Change-Id: I59d97c8784a1eafccf09ac264245fe8bd972c932
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1249222
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832177
Commit-Queue: Jeevan Shikaram <[email protected]>
Reviewed-by: Jeevan Shikaram <[email protected]>
Owners-Override: Jeevan Shikaram <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035302}
Roll Dawn from cdb53972831c to fa4a7291f2f6 (4 revisions)
https://dawn.googlesource.com/dawn.git/+log/cdb53972831c..fa4a7291f2f6
2022-08-15 [email protected] tint: add [[nodiscard]] on utils::Result class
2022-08-15 [email protected] Split some structs out of DawnTest.h into their own file.
2022-08-15 [email protected] Roll vulkan-deps from 3ebe695e969a to fb0e26499a68 (4 revisions)
2022-08-15 [email protected] tint: natvis: add utils::Slice, utils::Vector, and utils::VectorRef
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dawn-chromium-autoroll
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel
Bug: chromium:1284275
Tbr: [email protected]
Change-Id: I33427513dae75a5aa3418432d9fa140c34b20a4b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832835
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035301}
Update V8 to version 10.6.171.
Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/709443dc..5039a98e
Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues
Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_chromeos_msan_rel_ng
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel
[email protected],[email protected],[email protected]
Change-Id: I76beaf666ad20db6a9c66e6160ca6f5bf9c1d8b8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3831060
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1035300}
[CodeHealth] Replace DictionaryValue::GetString in /chrome/browser/ui/webui/settings.
This CL was uploaded by git cl split.
[email protected]
Bug: 1187036
Change-Id: If5b49d29a3011c395f82a8d119309f9401d8839d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3827727
Reviewed-by: Kyle Horimoto <[email protected]>
Commit-Queue: Kyle Horimoto <[email protected]>
Auto-Submit: Brian Begnoche <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035299}
webauthn: update message on caBLE QR screen.
With the launch of iOS 16, it's not just computers that will be
displaying FIDO QR codes.
Change-Id: I07cbd6f92e7d83ae2125e73c682194b1d003d814
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832303
Commit-Queue: Adam Langley <[email protected]>
Commit-Queue: Martin Kreichgauer <[email protected]>
Reviewed-by: Martin Kreichgauer <[email protected]>
Auto-Submit: Adam Langley <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035298}
Report DM policy validation errors
We now call `DMClient::ReportPolicyValidationErrors` when
`DMClient::FetchPolicy` reports an error.
Bug: 1345407
Change-Id: I976dffa909a4f4f0ac5726798b86cce41ec0e504
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832703
Reviewed-by: Sorin Jianu <[email protected]>
Commit-Queue: S Ganesh <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035297}
Roll ANGLE from b9fd47b8d2bd to 2089943b951d (1 revision)
https://chromium.googlesource.com/angle/angle.git/+log/b9fd47b8d2bd..2089943b951d
2022-08-15 [email protected] Tests: Add Lumino City trace
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86
Bug: None
Tbr: [email protected]
Test: Test: angle_perftests --gtest_filter="*lumino_city*"
Change-Id: I835c6dcb8325b093e52c0c52c321164abf1128a1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832680
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035296}
capture-mode: Extend the expiry date of capture mode histograms
Change-Id: I6188775d1c07f0f0a863409bb047b814840585bd
Fixed: 1352990, 1352989, 1352988, 1352987, 1352986, 1352985, 1352984
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3828171
Commit-Queue: Michele Fan <[email protected]>
Reviewed-by: Tony Yeoman <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035295}
Roll Catapult from 42f4f9ca7d14 to b3421074fa70 (1 revision)
https://chromium.googlesource.com/catapult.git/+log/42f4f9ca7d14..b3421074fa70
2022-08-15 [email protected] [pinpoint] upload 1000 rows at maximum when exporting row data to big query
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/catapult-autoroll
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: chromium:1352869
Tbr: [email protected]
Change-Id: Id0d8fab3693358b117be11e7907db97ba41f270e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832736
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035294}
[SharingHub] Add Profile fallback and null-check back.
Sometimes Profile.ProfileSupplier is unexpectedly returning null, so
add the null-check back so it doesn't cause crashes.
Bug: 1346710
Change-Id: I8d847cc5bf600c6255bc4f66535cd63d4365bba7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3831799
Commit-Queue: Sophey Dong <[email protected]>
Reviewed-by: Tommy Nyquist <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035293}
Improve WebGPU message code
Makes the following improvements to the WebGPU CTS message code:
* Adjusts message timeouts based on the current test state so we only
use the (long) test timeout when actually running the test.
* Moves and modifies the JavaScript duration logic so that we only
report it if the JavaScript code actually timed out.
Bug: 1340602
Change-Id: I86a260c2e3d23c4b30ba9da7fbb9375644346364
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3829229
Commit-Queue: Brian Sheedy <[email protected]>
Reviewed-by: Austin Eng <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035292}
[Cleanup] Delete old-gen and rename file to "structured_events".
Bug: 1249222
Change-Id: I5a48cd57db05c13a137825a1e036a8fd4bee6e97
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3827385
Reviewed-by: Tony Yeoman <[email protected]>
Commit-Queue: Jong Ahn <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035291}
Roll Depot Tools from 647cfe6bf10e to 268d645853ee (41 revisions)
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/647cfe6bf10e..268d645853ee
2022-08-12 [email protected] [depot_tools] roll bb
2022-08-12 [email protected] Print which PRESUBMIT.py scripts run on Python 2
2022-08-12 [email protected] Revert "Update autoninja.bat to work with other shells."
2022-08-11 [email protected] [depot_tools] roll dirmd
2022-08-10 [email protected] Add BatchListBestOwners and ListBestOwners to GerritClient
2022-08-10 [email protected] [cipd] Update CIPD client v2.6.7 => v2.6.8.
2022-08-10 [email protected] Update autoninja.bat to work with other shells.
2022-08-10 [email protected] Don't do double-serial Pylint checks
2022-08-10 [email protected] Add a fetch config for GN.
2022-08-10 [email protected] Make "All rights reserved" Optional in the License
2022-08-09 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2022-08-08 [email protected] Revert "Remove old DepotToolsOwners implementation"
2022-08-08 [email protected] Remove old DepotToolsOwners implementation
2022-08-08 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2022-08-06 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2022-08-05 [email protected] Improve presubmit no-network handling
2022-08-05 [email protected] [led] roll led
2022-08-05 [email protected] [depot_tools] roll led
2022-08-05 [email protected] Add debug logs during Clone process.
2022-08-05 [email protected] Revert "Update led to the current version."
2022-08-05 [email protected] Revert "[depot_tools] roll led"
2022-08-05 [email protected] vpython(3) no longer needs to bootstrap python.
2022-08-04 [email protected] [depot_tools] roll led
2022-08-04 [email protected] Allow 'noparent' in DEPS
2022-08-03 [email protected] Update led to the current version.
2022-08-03 [email protected] Add jojwang to OWNERS
2022-08-03 [email protected] Use the bundled interpreter instead of passing -vpython-interpreter.
2022-08-02 [email protected] Report more issues as errors with presubmit --all
2022-08-02 [email protected] Update lucicfg version 1.32.0 to 1.32.1
2022-08-01 [email protected] New vpython to depot_tools.
2022-08-01 [email protected] [no-sync] bot_update: Remove previous no-sync exp changes and implement new one.
2022-08-01 [email protected] [no-sync] Save previous values to files.
2022-07-29 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2022-07-28 [email protected] depot_tools: Roll rdb
2022-07-28 [email protected] Clarify documentation from `gclient recurse`
2022-07-28 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2022-07-28 [email protected] [lucicfg] Update v1.31.5 => v1.32.0.
2022-07-27 [email protected] [no-sync] Set _should_sync and add flag to control if the experiment should be enabled.
2022-07-27 [email protected] Treat UnitTests failures as presubmit --all errors
2022-07-25 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2022-07-25 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/depot-tools-chromium-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: chromium:1151236,chromium:1171945,chromium:1309977,chromium:1318617,chromium:1339472,chromium:1347252,chromium:1347622,chromium:1348065,chromium:1348269,chromium:1349169,chromium:1349905,chromium:1350060,chromium:1350210,chromium:1350227,chromium:1351212,chromium:1351519,chromium:1351817,chromium:1352347
Tbr: [email protected],[email protected],[email protected],[email protected]
Change-Id: Iddc79a4ee4eb14970e5ccbf6310d5f3a1a3bb3cf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832874
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035290}
Fuzz AXPlatformNodeTextRangeProviderWin
This change also updates the tree fuzzer util to generate tree updates.
AX-Relnotes: n/a
Bug: 1334820
Change-Id: Ib4f00e3da2369a37118b611efedc91eae888a665
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3794435
Reviewed-by: Daniel Libby <[email protected]>
Commit-Queue: Jacques Newman <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035289}
[HSTS] Preload .hotmail
Per Microsoft's request.
Change-Id: Ia650c8f1d4bc24c625801c0af15d995198fbe3b6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3828034
Auto-Submit: Joe DeBlasio <[email protected]>
Reviewed-by: Chris Thompson <[email protected]>
Commit-Queue: Chris Thompson <[email protected]>
Commit-Queue: Joe DeBlasio <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035288}
Speculatively serialize test
Serializes deqp/functional/gles3/shaderindexing/uniform.html, as doing
so seems to improve stability of subsequent WebGL conformance tests.
Bug: 1345755, 1345782
Change-Id: I6729f6cfaa0bce1fd0285be25c99e49ddc4c9ca8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832914
Commit-Queue: Kenneth Russell <[email protected]>
Auto-Submit: Brian Sheedy <[email protected]>
Commit-Queue: Brian Sheedy <[email protected]>
Reviewed-by: Kenneth Russell <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035287}
Roll ChromeOS Bigcore AFDO profile from 106-5195.24-1660556265-benchmark-106.0.5240.0-r1 to 106-5195.24-1660556265-benchmark-106.0.5241.0-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-bigcore-chromium
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: [email protected]
Change-Id: Id2a37b177a4d0f06a69a3cd4a435c55bfc8c84a3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3831292
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035286}
Devirtualize InputType validation
This CL is based on WebKit patches:
https://github.com/WebKit/WebKit/commit/2cc0d11933aafd9c8c6bcb2262f0641dba35c569
and https://trac.webkit.org/changeset/293546/webkit, which are
optimization about devirtualize functions and claim progression 0.5% ~
0.75% on Speedometer2
Bug: 1350031
Change-Id: I124fc5072103690aea88ce64f82350a90b7caf6e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3793245
Reviewed-by: Mason Freed <[email protected]>
Reviewed-by: Xiaocheng Hu <[email protected]>
Commit-Queue: Mason Freed <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035285}
Updater: Suppress metainstaller error dialog when run with arguments.
The dialog is most useful when a user is double-clicking to launch a
broken metainstaller. It is undesirable to show it when a program is
launching the metainstaller in the background, e.g. with --update.
Fixed: 1344584
Change-Id: I1f073ee9f56784b8fa9bc3e178bc7cad708714f1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832496
Auto-Submit: Joshua Pawlicki <[email protected]>
Commit-Queue: Sorin Jianu <[email protected]>
Reviewed-by: Sorin Jianu <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035284}
Roll Chrome Win32 PGO Profile
Roll Chrome Win32 PGO profile from chrome-win32-main-1660586298-c914d01b1b949f2a28c615a53b3d3a0ba7009a6f.profdata to chrome-win32-main-1660596999-38042d5219e1af86f427bbe0b6e1921399cc7d51.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win-chrome
Tbr: [email protected]
Change-Id: I652b6e6f004a58195c16efdf3024abb9d93e2ce8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832572
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035283}
One/TwoCopyCanvasCapture: Add trace integration tests for WebGL.
Trace tests were already added for WebGPU canvas.
This CL adds WebGL version of the trace tests.
Bug: 1351117
Change-Id: I2e409633c7b4d0e1f13f8dec17e7b83206beff88
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3818341
Commit-Queue: Quyen Le <[email protected]>
Reviewed-by: Sunny Sachanandani <[email protected]>
Reviewed-by: Kenneth Russell <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035282}
[Extensions] Add new Webstore domain to extension URLs and clients
This CL adds in the new Webstore domain to extension URLs, along with
adding the associated GURL caching for all of the extension clients.
This will be used by future CLs for implementing special logic which
is based around this domain.
Bug: 1338235
Change-Id: I205975f76f51e3471d9fcb1c4349f2d283f2f20c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3793043
Reviewed-by: Devlin Cronin <[email protected]>
Commit-Queue: Tim <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035281}
Update dialog height without footnote
Bug: b/238244922
Change-Id: I3d425887ed3535090b347e04cf39f9f0fec69358
Screenshot: https://screenshot.googleplex.com/8EdCAVivHuUFnvJ.png
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3830741
Commit-Queue: Luke Cao <[email protected]>
Reviewed-by: Benjamin Zielinski <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035280}
[Files app] Remove unused code
Remove unused functions MountConditionToString and DeviceTypeToString.
BUG=chromium:1313346
TEST=autoninja -C out/Default unit_tests browser_tests components_unittests ash_components_unittests chrome
Change-Id: If0c75c6d72c53d2c783abdf4a83e72b6a82d3158
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3831620
Commit-Queue: François Degros <[email protected]>
Reviewed-by: Marcello Salomao <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035279}
[Files app] Add output operator for DeviceType
It is used in unit tests.
BUG=chromium:1313346
TEST=autoninja -C out/Default unit_tests browser_tests components_unittests ash_components_unittests chrome
Change-Id: I9ea427a15d947b7c7ae45a3e6a66bec59836fe39
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3831738
Reviewed-by: Marcello Salomao <[email protected]>
Commit-Queue: François Degros <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035278}
FSA: Add prompt when saving files with a dangerous extension
See http://screen/87uovCEWf85BU4g.png (Googler-only) for a screenshot
of this prompt on Mac.
The prompt default is to NOT save the file, requiring the user to
explicitly opt in to save a file with a dangerous extension.
Bug: 1320877, 1352338
Change-Id: I958a17dc485668c2e5825832ac43454cc3bc934e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3829770
Commit-Queue: Austin Sullivan <[email protected]>
Reviewed-by: Avi Drissman <[email protected]>
Reviewed-by: Peter Boström <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035277}
FileSystem: Delete persistent data if persistent quota is deprecated
This change updates DeleteDefaultBucket to check if
blink::features::IsPersistentQuotaIsTemporaryQuota is enabled.
If so, will delete bucket data for kFileSystemTypePersistent
as if persistent quota type is deprecated.
This will resolve test failures from https://crrev.com/c/3769282.
Bug: 1233525
Change-Id: I27ff4e9783b89626be78a239a01f333b0fe7e668
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3828571
Reviewed-by: Marijn Kruisselbrink <[email protected]>
Commit-Queue: Ayu Ishii <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035276}
webview: Add a flag to expose the DocumentTransition API.
This feature is actively being experimented by webview based apps.
[email protected]
Change-Id: I2942c754afd7b157aa5ec84f942c5cc43d050dce
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3828559
Reviewed-by: Bo Liu <[email protected]>
Commit-Queue: Khushal Sagar <[email protected]>
Auto-Submit: Khushal Sagar <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035275}
[Files app] Refactor DiskMap -> Disks
Changed the type of DiskMountManager::Disks from map<string,
unique_ptr<Disk>> to set<unique_ptr<Disk>> indexed by device path.
Previously, the device path was stored twice in memory: once as a key of
the map's entry, and once inside the Disk object itself. Now, this data
duplication has been removed. Moreover, the code using the Disks
collection looks simpler and more natural.
BUG=chromium:1313346
TEST=autoninja -C out/Default unit_tests browser_tests components_unittests ash_components_unittests chrome
Change-Id: I315e0987fc26bc9b27eede69072465cb038ecb76
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3830136
Reviewed-by: Avi Drissman <[email protected]>
Reviewed-by: Marcello Salomao <[email protected]>
Commit-Queue: François Degros <[email protected]>
Reviewed-by: Tommy Li <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035274}
Roll Chrome Win64 PGO Profile
Roll Chrome Win64 PGO profile from chrome-win64-main-1660586298-d90bc9394f8c202fb20a0cf42c5530141aab9f10.profdata to chrome-win64-main-1660596999-4f87e7e4108e3777b08968025e771c83a2d74b54.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win64-chrome
Tbr: [email protected]
Change-Id: Ib7efd10a5f444a656c4ab7d4368c53136d9c9d30
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3831428
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035273}
Extensions: WAR: Allow file:// access
Web Accessible Resources are now available to file:// schemes. This is
a scheme that has an opaque origin, so an explicit check has now been
included specifically for file://. This CL specifically addresses the
associated bug, and immediately gives developers something requested.
Bug: 1181450
Change-Id: Ie4af70a9d62b65535d79ec5bafb291a90d63a971
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3808511
Reviewed-by: Tim <[email protected]>
Reviewed-by: Devlin Cronin <[email protected]>
Commit-Queue: Solomon Kinard <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035272}
[CT][EngagementSignals] Add root scroll offset to onScrollUpdateGestureConsumed
Bug: 1340074
Change-Id: I300e6d5646d507c83b74133b5fe9aa8b0b75a229
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3807994
Reviewed-by: Donn Denman <[email protected]>
Reviewed-by: Jinsuk Kim <[email protected]>
Commit-Queue: Donn Denman <[email protected]>
Reviewed-by: Richard Coles <[email protected]>
Reviewed-by: Theresa Sullivan <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035271}
[Pixel Diff Ash] A pixel test for the app list under clamshell
This CL adds a pixel test to verify the app list under the clamshell
mode. To implement the pixel test, this CL adds an API in the app list
test helper to add app list items with solid-colored icons.
Bug: 1351444
Change-Id: I2be0601fc5fd6a239bd96e5e2e72b8f7d7fe2b53
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3829212
Commit-Queue: Andrew Xu <[email protected]>
Reviewed-by: Xiyuan Xia <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035270}
FSA: Add DCHECK that permission prompt callback is called
Asserts that the behavior matches the comment
Bug: 1352338
Change-Id: I5a229faaa89140c16f8d53ccc994f487ce21b653
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832656
Commit-Queue: Austin Sullivan <[email protected]>
Reviewed-by: Peter Boström <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035269}
Roll ChromeOS Atom AFDO profile from 106-5195.19-1659952549-benchmark-106.0.5240.0-r1 to 106-5226.0-1660558034-benchmark-106.0.5241.0-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-atom-chromium
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: [email protected]
Change-Id: Id82bd49f58efcfcd543065240eb430a25cc76884
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832759
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035268}
Initial CL to add telemetry signal protos for Cookies.getAll() and Cookies.Get() APIs.
Also auto-formatted proto file.
Bug: 1350204
Change-Id: Ifb5c63d76a33043642a0da045709548fbe881a44
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3812114
Auto-Submit: Richard Chen <[email protected]>
Reviewed-by: Xinghui Lu <[email protected]>
Commit-Queue: Xinghui Lu <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035267}
arc/gio: Reduce the calculation for each RewriteEvent
CalculateTouchPosition and CalculateWindowContentBounds are repeated for
each RewriteEvent(), which is unnecessary. The window content bounds
are only changed when window bounds changed. The touch position is
changed when display is rotated and window bounds changed. During
RewriteEvent, display rotation and window bounds are not changed, so we
can save the window content bounds and touch down position in advance
and no need to calculate for each RewriteEvent.
Bug: b:241841669
Test: unittest
Test: manual test by rotating display and changing window bounds.
Change-Id: I4991d70a1927e370957faaa688b9dc764855d7ee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3817597
Auto-Submit: Cici Ruan <[email protected]>
Reviewed-by: David Jacobo <[email protected]>
Commit-Queue: Cici Ruan <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035266}
breadcrumbs: remove unused GetEventCount()
This change removes the unused function GetEventCount().
Bug: 1163762
Change-Id: I4c7527bd60e6fb8ee60258e04d70a3daf216cbd6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3584397
Commit-Queue: Jesse McKenna <[email protected]>
Reviewed-by: Mike Dougherty <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035265}
[TabStrip] Fix crash when starting reorder on closing tab
Fix crash when starting reorder on closing tab.
-Prevent reorder mode from starting if selected tab is dying.
Bug: 1353049
Change-Id: Icb88bdea161c6d09edd54754963e1b0ebdae2698
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3828213
Reviewed-by: Sirisha Kavuluru <[email protected]>
Commit-Queue: Neil Coronado <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035264}
Implement aggregation service internals handler for the web UI
This CL adds the backing mojo interface and handler for the WebUI, which
is used in a followup CL (crrev.com/c/3789670).
There is two way communication between the handler and the WebUI over
mojo, and this also proxies callbacks to the observer functions.
Bug: 1348029
Change-Id: Ibac65ad3195bdab394acc3d579bf13b6a7dd9528
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3797345
Commit-Queue: Nan Lin <[email protected]>
Reviewed-by: Robert Sesek <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035263}
Roll src-internal from d7544fbedf88 to 115058df3cd4 (3 revisions)
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d7544fbedf88..115058df3cd4
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: [email protected]
Change-Id: Ie5044bf9a2b8465099ac5a099a05168f2cc99bfa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832758
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1035262}
Make TabStrip layout more consistent between scrolling on and off.
Using a FlexLayout in both cases allows us to drop the minimum and preferred size overloads and still get the behavior we want. Scrolling still needs a layout override to expand beyond the parent view's available space.
Bug: 1346017
Change-Id: Idef751f304963277f4fbe27361038932cb1ffbeb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3821126
Reviewed-by: David Pennington <[email protected]>
Commit-Queue: Taylor Bergquist <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035261}
Fix GPU flake finder properties
Fixes several issues with the GPU flake finder's properties
that were caught when actually using them with the recipe.
Bug: 1340617
Change-Id: Id9d3d1204e55e53ae8619f746f4e1e98831ddc82
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3829913
Auto-Submit: Brian Sheedy <[email protected]>
Reviewed-by: Garrett Beaty <[email protected]>
Commit-Queue: Brian Sheedy <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035260}
Move -dcheck from ChannelInfo to chrome:// pages
This removes the expectation that ChannelInfo should return "-dcheck" as
part of the channel name in DCHECK_IS_CONFIGURABLE build, which makes
Mac builds pass.
The string is instead added to chrome:// pages matching existing Lacros
behavior. This is done in a platform-agnostic way and shouldn't require
updates as DCHECK builds roll out on additional platforms.
A shared VersionUI::GetAnnotatedVersionStringForUi() is added which
replaces all existing uses of IDS_SETTINGS_ABOUT_PAGE_BROWSER_VERSION.
A side effect of above synchronizes chrome://settings/help's string on
Lacros to be dev-lacros (as an example) instead of Lacros, matching
chrome://version which had been updated since.
ChannelInfoWin is updated to remove "-dcheck" as part of the channel
name.
Bug: 1346080
Change-Id: I9fe1012c0ffa4c8aaec4ab69b82ed259bc695b14
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3781313
Commit-Queue: Peter Boström <[email protected]>
Reviewed-by: Greg Thompson <[email protected]>
Reviewed-by: Lei Zhang <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035259}
Report correct error for a missing bucket/value in sendHistogramReport()
Currently, the FLEDGE integration issues the wrong error as Get()
returns undefined for a missing key in an object.
Bug: 1346108
Change-Id: I6be9f36a9277268b93dba26aa5c5e89cf600c16a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3823233
Commit-Queue: Alex Turner <[email protected]>
Reviewed-by: Russ Hamilton <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035258}
webauthn: explicitly send caBLE transports.
This change puts transports in the caBLE getInfo. By giving explicit
transports, clients (inc Chrome) can have enough confidence to report
them to servers. For now, include both old and new names for hybrid
CTAP.
Change-Id: I623e2ae1e938198b88418e8d1da0c2a0f8bfca68
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3828560
Auto-Submit: Adam Langley <[email protected]>
Reviewed-by: Martin Kreichgauer <[email protected]>
Commit-Queue: Martin Kreichgauer <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035257}
[power bookmarks] Rely on BottomSheetContent for destruction
The way it's currently setup is to observe the contents and compare
it against ourselves. This causes a crash when there are multiple
duplicate sheets contending for space.
Bug: 1346336
Change-Id: I6605071f49c51888f598d3b547eb6454ca3ef382
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3830066
Reviewed-by: Matthew Jones <[email protected]>
Commit-Queue: Brandon Wylie <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035256}
mojo-ipcz: Driver transports
Implements the mojo-ipcz driver transport on top of a lightly tweaked
variation of each platform's existing Channel implementation in Mojo.
Bug: 1299283
Change-Id: I7e6277477cda4d23a18d950f65624ce33b8d7ce2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3810676
Reviewed-by: Robert Sesek <[email protected]>
Commit-Queue: Ken Rockot <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035255}
Introduce InitByteStream()
Currently, we can only create a new byte stream, but we cannot
initialize a byte stream with an existing stream, which is needed for
example in WebTransport's IncomingStream::InitWithExistingReadableStream().
This CL refactors some of the code to allow this functionality.
Bug: 1284571
Change-Id: Iff4f991c8b81889f8c6f72fd2906daa832289e71
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3829325
Reviewed-by: Adam Rice <[email protected]>
Commit-Queue: Nidhi Jaju <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035254}
[Sheriff] Disable SubresourcePartitionedCookiesOriginTrialBrowserTest.InvalidToken on Mac.
Bug: 1353084
Change-Id: Id2e20572d131bae6f41a45ee7b3e6127f91b5eb2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3826796
Reviewed-by: Kevin McNee <[email protected]>
Auto-Submit: David Bertoni <[email protected]>
Commit-Queue: David Bertoni <[email protected]>
Owners-Override: David Bertoni <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035253}
Add alt strings for region search chip experiment.
Bug: b:242594424
Change-Id: I8dbcae2a28fdbcdfdec3590710658c5b27603c03
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3827207
Reviewed-by: Ali Stanfield <[email protected]>
Commit-Queue: Juan Mojica <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035252}
Update OptimizeNetworkBuffers2 field trial testing config.
Bug: 1318925
Change-Id: Iae950aafea6a2ed1d2b5b6d536556d1e56e8fd2e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3829230
Commit-Queue: Clark DuVall <[email protected]>
Auto-Submit: John Abd-El-Malek <[email protected]>
Reviewed-by: Clark DuVall <[email protected]>
Commit-Queue: John Abd-El-Malek <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035251}
[Jank] [a11y] Introduce new a11y performance histogram.
This can be used to evaluate optimizations of BrowserAccessibilityManager.
Bug: 1352616
Change-Id: I779ff8ed4c07e25fd24e77011cd33f466c6b7cb8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3828149
Commit-Queue: Yaron Friedman <[email protected]>
Reviewed-by: Aaron Leventhal <[email protected]>
Reviewed-by: Evan Liu <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035250}
Renable Flaky Win11 test
This CL reenables video-controls-with-cast-rendering.html on Win11.
Flakiness should be resolved through rebaselining.
Fixed: 1343270
Change-Id: I429ab54a5c15ea7601c927d602bad7fcac68bbe1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3823190
Reviewed-by: Frank Liberato <[email protected]>
Commit-Queue: Thomas Guilbert <[email protected]>
Auto-Submit: Thomas Guilbert <[email protected]>
Commit-Queue: Frank Liberato <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035249}
Fix a few crashes related to popup=manual
In a few cases, it was assumed that popup=manual pop-ups would be
present in the popup_positions map, causing a crash in hashset.at().
This is now fixed.
Bug: 1307772
Change-Id: I1f0a5200bc2074d7058ea74c57e6e56c1e8aaf7f
Fixed: 1349587
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3827318
Auto-Submit: Mason Freed <[email protected]>
Commit-Queue: Mason Freed <[email protected]>
Reviewed-by: Joey Arhar <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035248}
Set the LayoutNGTableFragmentation feature to "stable".
Also shuffled some feature dependency around, to match how it's done
for LayoutNGFlexFragmentation and LayoutNGGridFragmentation, so that
it's still possible to disable LayoutNG.
This prevents
DumpAccessibilityTreeWithoutLayoutNGBlockFragmentationTest.AccessibilityCSSMarkerCrash
from failing.
Bug: 1078927
Change-Id: I0398fd1c5d9b7a375bfc428529aae897b5bb2abe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832215
Reviewed-by: Ian Kilpatrick <[email protected]>
Commit-Queue: Morten Stenshorne <[email protected]>
Reviewed-by: Alison Maher <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035247}
[ios] Fix tests for kTrendingQueriesModule
Forces a particular experiment arm that doesn't hide Shortcuts. Also,
a test is added to validate the Trending Queries module.
Bug: 1350826, 1352158
Change-Id: Ie44481ae884018361e3916d793fe0b444068c269
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3817208
Commit-Queue: Chris Lu <[email protected]>
Reviewed-by: Rohit Rao <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035246}
[lacros] Fix stale lacros component loads when attempting updates
This CL addresses a bug in CrOSComponentInstaller that causes it to
load stale versions of the lacros component - even when new versions
have been downloaded and installed.
The issue is that once a component load succeeds it populates the
installer's load_cache_. When subsequent loads are requested the
component entry is found in the load cache and loading early returns,
reporting a successful load for the cached (now stale) version.
This CL addresses the issue specifically for the lacros component to
avoid potentially regressing performance for other CrOS components, where loading older component versions may not be an issue.
Follow up CLs will address this problem more generally so that all
CrOS component loads will load the latest version if available and
installed.
Bug: 1352867, 1322678
Change-Id: I29baab12cbf2a112fe11c39ca98eeb84b653cb12
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832637
Reviewed-by: Joshua Pawlicki <[email protected]>
Commit-Queue: Thomas Lukaszewicz <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035245}
[Chromecast] Refactor Observable.not().
The old implementation would leak subscriptions without closing
them.
The new implementation is written in terms of a new operator,
fold(), which is versatile and useful in many scenarios where
monadic flatMap()-based operators cannot help. Namely, fold()
can track state over time, differentiate between the order of
activations, and aggregate activations and deactivations into
a single authoritative value.
The fold() implementation depends on a new Observable called
Cell, which has exactly one activation at all times. Cell
provides the means to set() its data, but not reset() it like
Controller, and it must be constructed with a value to start,
so it is non-nullable. It also provides a mutate() method,
which allows changing the value based on the current value,
and supports the same deduplication functionality as Controller.
Bug: b/241322428
Test: cast_base_junit_tests, cast_shell_junit_tests
Change-Id: I314702cb1c6ce600cc0e63829d862d2841995ee6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3809671
Reviewed-by: Yuchen Liu <[email protected]>
Commit-Queue: Yuchen Liu <[email protected]>
Auto-Submit: Simeon Anfinrud <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035244}
Roll Chrome Mac PGO Profile
Roll Chrome Mac PGO profile from chrome-mac-main-1660542448-93e96f805595961cca72c8f0f4c8d5dc51ea623d.profdata to chrome-mac-main-1660586298-c6a583817d54635ca6eb80e0f97694b6d27004c2.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:mac-chrome
Tbr: [email protected]
Change-Id: Icfbf7228ee6f56919a2d0737659ce6e833a5d156
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832092
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035243}
Improve debugging output when app id is not correct.
In case when some code fails, it would help developers to understand what values they have. Future improvement might be to return a status error from the function, so the error would be explicit.
Bug: 1333966
Change-Id: I8c444fea6d5e0ef845ef429cb20a99acff484def
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3829515
Commit-Queue: Dmitrii Kuragin <[email protected]>
Auto-Submit: Dmitrii Kuragin <[email protected]>
Reviewed-by: Daniel Murphy <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035242}
Roll Skia from e96d4aa2ad3b to de7a810734f3 (3 revisions)
https://skia.googlesource.com/skia.git/+log/e96d4aa2ad3b..de7a810734f3
2022-08-15 [email protected] Roll Dawn from cdb53972831c to c935b497e6da (3 revisions)
2022-08-15 [email protected] Roll ANGLE from 4c941149774f to 64c652d7fde0 (3 revisions)
2022-08-15 [email protected] Update emsdk repo (speculative fix for Linux arm64)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Cq-Do-Not-Cancel-Tryjobs: true
Bug: None
Tbr: [email protected]
Change-Id: Ia176720807283274be2782f9ba137de226c0d315
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832093
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035241}
[OnDemand AT] Factor histogram logging logic into separate class
To improve code readability and maintainability, factor out UMA
histogram logging from WebContentsAccessibilityImpl into a separate
component, the AccessibilityHistogramLogger.
This will help when adding logging to track impact of new features like
OnDemand AT.
Change-Id: I3288bd04365fc892b6143595d3b51a62e1439ee7
Bug: 1227192
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3824049
Reviewed-by: Mark Schillaci <[email protected]>
Reviewed-by: Bo Liu <[email protected]>
Commit-Queue: Amanda Lin Dietz <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035240}
Add PretokenizeCSS to ProductionSupportedFlagList.java
Bug: 1289471
Change-Id: I8ade01d44557ec42f74add2d35510a78f21d37f6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3826797
Commit-Queue: Clark DuVall <[email protected]>
Reviewed-by: Nate Fischer <[email protected]>
Commit-Queue: Nate Fischer <[email protected]>
Auto-Submit: Clark DuVall <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035239}
[Android Bulk Tab Edit] Selection Action
Add a button that toggles between select all and deselect all.
Add an ActionDelegate for controlling the behavior of the editor.
Reference screenshots:
https://drive.google.com/drive/folders/10EAy4J494QORWBgND0eArFdDDej-wjaZ?usp=sharing
Bug: 1343374
Change-Id: I15f98f41923804876f57423b83cda2a982a92c4c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3807906
Commit-Queue: Calder Kitagawa <[email protected]>
Reviewed-by: Sky Malice <[email protected]>
Reviewed-by: Mei Liang <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035238}
[ViewsAX] Removed unnecessary member variable
Removed event_generator_ as member variable for AutomationAXTManager since now it inherits the base class event_generator_ variable
Bug: 1049261
Change-Id: Iad110b2a782058b11603d687d113d0730372c4c4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3830820
Reviewed-by: Benjamin Beaudry <[email protected]>
Commit-Queue: Benjamin Beaudry <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035237}
[Journeys] Fix displayed favicon size
To mirror history, we should call getIconDrawableWithoutFilter using the
larger value of default_favicon_size instead of the smaller
default_favicon_min_size.
Bug: 1352969
Change-Id: I0c1b01825a3eff254be18451cd7072ea865a8891
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3828170
Commit-Queue: Patrick Noland <[email protected]>
Reviewed-by: Brandon Wylie <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035236}
Fenced frames: First refactor for urn:uuid properties flow
This CL creates a struct to represent fenced frame inner properties, and
carries them in the browser from the urn mapping into the FrameTreeNode.
There will be a second refactor CL to eliminate the now-redundant
equivalents of these properties outside of the struct.
See https://github.com/WICG/fenced-frame/issues/48
The second refactor is here: https://chromium-review.googlesource.com/c/chromium/src/+/3806500
Bug: 1347953
Change-Id: Ie26ba7f2c67f25c2304bd46259bd8646791d34fa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3781046
Reviewed-by: Shivani Sharma <[email protected]>
Reviewed-by: Dominic Farolino <[email protected]>
Reviewed-by: Alex Moshchuk <[email protected]>
Commit-Queue: Garrett Tanzer <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035235}
[mac] Re-enable two orderWindow-related widget unittests
These tests seem fixed after r1011169, so re-enable them.
Bug: 1114243
Change-Id: I7fb958e041b6d8404292f10cd212e5263b43d04b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3830739
Reviewed-by: Avi Drissman <[email protected]>
Commit-Queue: Keren Zhu <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035234}
Roll src-internal from 4f6a554e1d38 to d7544fbedf88 (1 revision)
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4f6a554e1d38..d7544fbedf88
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: [email protected],[email protected]
Change-Id: I62ebf18f17207b830e4fa24538b1f80c8d3a7523
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832130
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1035233}
[CodeHealth] Removing extra copies in content handlers
This CL removes the extra copies that used to be required when
submitting arguments to the JS runtime for a few files under the path
content/browser.
Bug: 1187001
Change-Id: Ia6405e788de1e08aa02beabe318a96cc972780ad
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3825897
Reviewed-by: Ben Kelly <[email protected]>
Reviewed-by: Guido Urdaneta <[email protected]>
Commit-Queue: Claudio DeSouza <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035232}
Switch ash and lacros CI builders to cores 8 machines
Experiment whether a lower performance machine is enough.
Bug: 1345687
Change-Id: I1bbfd6299f315cf228c525c87f07838d81102ab6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3829091
Auto-Submit: Sven Zheng <[email protected]>
Reviewed-by: Gary Tong <[email protected]>
Commit-Queue: Sven Zheng <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035231}
Roll vulkan-deps from 3ebe695e969a to fb0e26499a68 (4 revisions)
https://chromium.googlesource.com/vulkan-deps.git/+log/3ebe695e969a..fb0e26499a68
Changed dependencies:
* vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/a0ab2f162e..16d5d8f254
* vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/49314e0667..50fe2fc2d0
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-chromium-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86;luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:win-asan;luci.chromium.try:linux_chromium_cfi_rel_ng
Bug: None
Tbr: [email protected],[email protected],[email protected]
Change-Id: I3411a59910a56d0a2aee8da70f79d0c13c0f08e2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3829910
Commit-Queue: chromium-autoroll <[email protected]>
Bot-Commit: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035230}
Switch to assertRegex in version_test
No change to logic. This switches version_test.py to use assertRegex()
because assertRegexpMatches() is deprecated. This python test does not
support python2, so we can simply switch to the new API.
Bug: 1344991
Test: vpython3 build/util/version_test.py
Change-Id: Ic2afe27689eb85f112cb159afdb4cff2f10e0172
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3829513
Reviewed-by: Thomas Anderson <[email protected]>
Auto-Submit: Nate Fischer <[email protected]>
Commit-Queue: Thomas Anderson <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035229}
Initialize profile_ in CustomizeChromeUI initializer list
profile_ was not initialized in the initializer list for the
CustomizeChromeUI.
Change-Id: I51ce355ebd45954a3735832b75b2cb0d0181a070
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3829750
Reviewed-by: Thomas Lukaszewicz <[email protected]>
Commit-Queue: Nihar Majmudar <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035228}
Expose a method to query about the experiment parameter
Bug: none
Change-Id: I7d9403646c30c1ab51e05a041558deb93c2bd179
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3827787
Commit-Queue: Jian Li <[email protected]>
Reviewed-by: Dan H <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035227}
Revert "[src] Add inverse filter file generation for RTS/Quick Run"
This reverts commit 43071dbc5c8a71b1ab80fa1690fb87ed1ba786b3.
Reason for revert: Compile has started failing for Quick Runs
Original change's description:
> [src] Add inverse filter file generation for RTS/Quick Run
>
> When RTS is enabled this will additionally generate the inverted
> filter file (a file that will only run the skipped tests), add it to
> the isolate and generates additional commands to run with these
> inverted filter files.
>
> See the design doc for more detailed information:
> http://docs/document/d/14XNntG5FNhf_lyTLtc1XlU2ZfiKmv8NzJK87D1m6zBE?resourcekey=0-GrHDLuC_iRkseeaEfGI-cQ
>
> led build using this CL:
> https://ci.chromium.org/raw/build/logs.chromium.org/chromium/led/sshrimp_google.com/15464dab518d5d7b92932010409bb216b5d47e7a695691fe016448e8247be9c6/+/build.proto?server=chromium-swarm.appspot.com
>
> Bug: 1344885
> Change-Id: Ic438bbb44495d2eb6d80e653f68a747d8f70e170
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3765373
> Reviewed-by: Takuto Ikuta <[email protected]>
> Reviewed-by: Ben Pastene <[email protected]>
> Commit-Queue: Struan Shrimpton <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1034546}
Bug: 1344885
Change-Id: I5695f77d92d83a1acd29c6a86d204ad7c670488c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3828900
Auto-Submit: Struan Shrimpton <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Owners-Override: Ben Pastene <[email protected]>
Commit-Queue: Ben Pastene <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035226}
[ios] Create separate BUILD file for //ios/c/b/resources
- Reduces monolithic //ios/c/b/BUILD.gn
- Makes it easier for folks to add/modify Experimental Settings
- Reduces overhead for //ios/c/b/OWNERS
Change-Id: I1fff8f8701900ad0eea3b1b7c189ca6acf4924c7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3826404
Reviewed-by: Rohit Rao <[email protected]>
Commit-Queue: edchin <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035225}
mojo-ipcz: Implement Mojo trap emulation
This introduces a new MojoTrap object within the mojo-ipcz driver. These
objects are created by the MojoCreateTrap(), which returns a new
MojoTrap as an ipcz box to be passed into other Mojo trap functions.
MojoTrap effectively emulates current Mojo Core's trap behavior using a
separate ipcz trap per trigger.
Bug: 1299283
Change-Id: Id7a7522b7b161bae580eb787c8be0995d727ac09
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3810986
Reviewed-by: Alex Gough <[email protected]>
Commit-Queue: Ken Rockot <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035224}
Roll AFDO from 106.0.5240.0_rc-r1-merged to 106.0.5241.0_rc-r1-merged
This CL may cause a small binary size increase, roughly proportional
to how long it's been since our last AFDO profile roll. For larger
increases (around or exceeding 100KB), please file a bug against
[email protected]. Additional context: https://crbug.com/805539
Please note that, despite rolling to chrome/android, this profile is
used for both Linux and Android.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/afdo-chromium-autoroll
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: [email protected]
Change-Id: I7dcf0f2d68864df6a8fde21148883a382c7f183c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3831950
Bot-Commit: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035223}
Add version to prevent build warning
Context: https://chromium-review.googlesource.com/c/chromium/src/+/3823415/comments/3e7e753e_0988aedb
Change-Id: I3c2877d4095acecd9532bf0ad445f53aebe452ec
Fixed: 1352895
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3828787
Reviewed-by: Mitsuru Oshima <[email protected]>
Commit-Queue: Fred Shih <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035222}
Earlier ScopedHandleVerifier hook registration
https://crrev.com/8d2df4ae recently re-enabled these hooks in some
test environments, including anything using the base unit test
launcher. The hooks are installed during test launch.
Several test suites however spin up a persistent IO thread before
launching their tests. This leads to races during hook installation
and ultimately to subtle flake.
This CL makes hook installation happen earlier, during TestSuite
construction.
Fixed: 1352874
Change-Id: I0812a1d738adf9c6e924c1914f98a683488e885c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3830818
Reviewed-by: Daniel Cheng <[email protected]>
Commit-Queue: Ken Rockot <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035221}
[ios] Disable failing tests on small devices
Bug: 1353093
Change-Id: I3928c7f2c6c377bffcc6d323dab29f2e916b8040
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3829757
Reviewed-by: Tommy Martino <[email protected]>
Auto-Submit: Chris Lu <[email protected]>
Commit-Queue: Tommy Martino <[email protected]>
Owners-Override: Chris Lu <[email protected]>
Commit-Queue: Chris Lu <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1035220}
![ios/chrome/widget_kit_extension/resources/lockscreen_chrome_logo.imageset/[email protected]](/https/chromium.googlesource.com/chromium/src/+/774415e24315b54c5536a9bbe34b19b3ebcce14a/ios/chrome/widget_kit_extension/resources/lockscreen_chrome_logo.imageset/lockscreen_chrome_logo%402x.png){kind=link}
![ios/chrome/widget_kit_extension/resources/lockscreen_chrome_logo.imageset/[email protected]](/https/chromium.googlesource.com/chromium/src/+/774415e24315b54c5536a9bbe34b19b3ebcce14a/ios/chrome/widget_kit_extension/resources/lockscreen_chrome_logo.imageset/lockscreen_chrome_logo%403x.png){kind=link}
![ios/chrome/widget_kit_extension/resources/lockscreen_game_logo.imageset/[email protected]](/https/chromium.googlesource.com/chromium/src/+/774415e24315b54c5536a9bbe34b19b3ebcce14a/ios/chrome/widget_kit_extension/resources/lockscreen_game_logo.imageset/lockscreen_game_logo%402x.png){kind=link}
![ios/chrome/widget_kit_extension/resources/lockscreen_game_logo.imageset/[email protected]](/https/chromium.googlesource.com/chromium/src/+/774415e24315b54c5536a9bbe34b19b3ebcce14a/ios/chrome/widget_kit_extension/resources/lockscreen_game_logo.imageset/lockscreen_game_logo%403x.png){kind=link}
![ios/chrome/widget_kit_extension/resources/lockscreen_incognito_logo.imageset/[email protected]](/https/chromium.googlesource.com/chromium/src/+/774415e24315b54c5536a9bbe34b19b3ebcce14a/ios/chrome/widget_kit_extension/resources/lockscreen_incognito_logo.imageset/lockscreen_incognito_logo%402x.png){kind=link}
![ios/chrome/widget_kit_extension/resources/lockscreen_incognito_logo.imageset/[email protected]](/https/chromium.googlesource.com/chromium/src/+/774415e24315b54c5536a9bbe34b19b3ebcce14a/ios/chrome/widget_kit_extension/resources/lockscreen_incognito_logo.imageset/lockscreen_incognito_logo%403x.png){kind=link}
![ios/chrome/widget_kit_extension/resources/lockscreen_voicesearch_logo.imageset/[email protected]](/https/chromium.googlesource.com/chromium/src/+/774415e24315b54c5536a9bbe34b19b3ebcce14a/ios/chrome/widget_kit_extension/resources/lockscreen_voicesearch_logo.imageset/lockscreen_voicesearch_logo%402x.png){kind=link}
![ios/chrome/widget_kit_extension/resources/lockscreen_voicesearch_logo.imageset/[email protected]](/https/chromium.googlesource.com/chromium/src/+/774415e24315b54c5536a9bbe34b19b3ebcce14a/ios/chrome/widget_kit_extension/resources/lockscreen_voicesearch_logo.imageset/lockscreen_voicesearch_logo%403x.png){kind=link}
