Publish DEPS for 101.0.4951.17
Incrementing VERSION to 101.0.4951.17
Change-Id: I667859947de4fb1c7ca83fe7dc23e72040489f3c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3559230
Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/4951@{#254}
Cr-Branched-From: 27de6227ca357da0d57ae2c7b18da170c4651438-refs/heads/main@{#982481}
[ios] Reload Content Suggestions when Removing Return to Recent Tab Tile
When SingleCellContentSuggestions feature is enabled, there is only
one item holding all the content, so the Return to Recent Tab
section cannot be removed. Instead, just reload the content.
(cherry picked from commit c4e71f31a695a2909a0c016be1cd1a85876913a4)
Fixed: 1309852, 1307945
Change-Id: I183fcefcf03630a5758fb2e6e9616c4c4bdacdeb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3553200
Auto-Submit: Chris Lu <[email protected]>
Reviewed-by: Adam Arcaro <[email protected]>
Commit-Queue: Chris Lu <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#986524}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3558378
Reviewed-by: Harry Souders <[email protected]>
Reviewed-by: Chris Lu <[email protected]>
Commit-Queue: Harry Souders <[email protected]>
Owners-Override: Harry Souders <[email protected]>
Cr-Commit-Position: refs/branch-heads/4951@{#253}
Cr-Branched-From: 27de6227ca357da0d57ae2c7b18da170c4651438-refs/heads/main@{#982481}
[Android notifications] Fixed capitalization on dialog strings
This changes the capitalization of "incognito" to "Incognito" on the
notification permission rationale UI.
(cherry picked from commit d645e0c2528a80ce395a759c9f57ad0a5d42bc7c)
Skip-Translation-Screenshots-Check: True
Bug: 1311033
Change-Id: Iea3e08759f4e1ba340f21d6774843aedc3484ee4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3556627
Reviewed-by: Shakti Sahu <[email protected]>
Commit-Queue: Salvador Guerrero Ramos <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#986237}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3558062
Auto-Submit: Salvador Guerrero Ramos <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/4951@{#252}
Cr-Branched-From: 27de6227ca357da0d57ae2c7b18da170c4651438-refs/heads/main@{#982481}
[lacros skew tests] Refresh skew tests for M102
This CL updates the ash version ['102.0.4970.3'] for Lacros version skew testing.
If this CL caused regressions, please revert and stop the autoroller
at https://luci-scheduler.appspot.com/jobs/chrome/lacros-version-skew-roller
Also please file a bug to OS>LaCrOS>Partner, and CC [email protected],
[email protected], [email protected].
[email protected]
Bug: None
Change-Id: I992baee8e896cb097d8ac7fbebafad26e37b971e
Requires-Testing: True
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3558817
Auto-Submit: chrome-weblayer-builder <chrome-weblayer-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/4951@{#251}
Cr-Branched-From: 27de6227ca357da0d57ae2c7b18da170c4651438-refs/heads/main@{#982481}
[skylab_tests] Update skylab tests cros img version
This CL will update cros image version for skylab tests. CROS_BOARD_LKGM
is updated according to chromeos/CHROMEOS_LKGM; CROS_BOARD_DEV,
CROS_BOARD_BETA and CROS_BOARD_STABLE are updated according to Omaha.
If this CL caused regressions, please revert and pause the autoroller at
https://luci-scheduler.appspot.com/jobs/chrome/lacros-skylab-tests-cros-img-roller
Also please file a bug to OS>LaCrOS>Partner, and CC [email protected],
[email protected], [email protected].
[email protected]
Requires-Testing: True
Change-Id: I125e050326b2fa11bd7f625cadfc7d643ac4e396
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3558795
Auto-Submit: skylab-test-cros-roller@chops-service-accounts.iam.gserviceaccount.com <skylab-test-cros-roller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/4951@{#250}
Cr-Branched-From: 27de6227ca357da0d57ae2c7b18da170c4651438-refs/heads/main@{#982481}
Incrementing VERSION to 101.0.4951.16
Change-Id: I6d2b2d6ee0a9a7e1f3ae3dd98d61b781242ed45f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3557401
Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/4951@{#249}
Cr-Branched-From: 27de6227ca357da0d57ae2c7b18da170c4651438-refs/heads/main@{#982481}
[Merge to M101] [Topics] Add data clearing methods for UX integration
This CL adds the following to `BrowsingTopicsService`:
1) a method for UX to call that clears a topic
2) a method for UX to call to clear a site's Topics data
3) a method for UX to call to clear all Topics data
4) only return the true top topics to UX (as opposed to the 5% random
topic, or the randomly padded top topics), for
GetTopicsForSiteForDisplay() and GetTopTopicsForDisplay().
(cherry picked from commit bf39e34d0a9eb371aff9764a9e13b92dcb9e69c5)
Binary-Size: Size increase is unavoidable due to new feature.
Bug: 1310360
Change-Id: I1f51ea238c059f5459486adb5d0f2d8c96904b91
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3553619
Reviewed-by: Theodore Olsauskas-Warren <[email protected]>
Reviewed-by: Josh Karlin <[email protected]>
Reviewed-by: Avi Drissman <[email protected]>
Commit-Queue: Yao Xiao <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#986163}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3557533
Bot-Commit: Rubber Stamper <[email protected]>
Auto-Submit: Yao Xiao <[email protected]>
Commit-Queue: Avi Drissman <[email protected]>
Cr-Commit-Position: refs/branch-heads/4951@{#248}
Cr-Branched-From: 27de6227ca357da0d57ae2c7b18da170c4651438-refs/heads/main@{#982481}
[realbox] Fixes design update bugs and cleans up CSS rules
Irons out the remaining edge cases with realbox design update:
- Dropdown was increasing the overall realbox height in dark themes.
- Dropdown was causing the search loupe and microphone icons to move.
- Faint line with NTP background color was seen inside input.
And simplifies the CSS rules.
Fixed: 1310297
(cherry picked from commit 6355ec5ea19cda1a38a312feb1598decbb7fa68d)
Change-Id: I08cd39dad9f01e157604c53511584a80801aa532
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3551262
Reviewed-by: Justin Donnelly <[email protected]>
Commit-Queue: Mohamad Ahmadi <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#986026}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3558475
Auto-Submit: Mohamad Ahmadi <[email protected]>
Commit-Queue: Justin Donnelly <[email protected]>
Cr-Commit-Position: refs/branch-heads/4951@{#247}
Cr-Branched-From: 27de6227ca357da0d57ae2c7b18da170c4651438-refs/heads/main@{#982481}
M101: Change ownership of BlobBytesProvider.
Rather than immediately passing ownership to a cross-thread
SelfOwnedReceiver while retaining a raw pointer, instead maintain
ownership in a unique_ptr as long as it is needed, only transferring
ownership to a SelfOwnedReceiver when BlobData is done with the
BlobBytesProvider.
Also clean-up/tighten down sequence checks for BlobBytesProvider a bit.
(cherry picked from commit 7222e9825fc02acc962e005c59885ee2f26df185)
Bug: 1285234
Change-Id: I7273e886a0bab2ae489b680d786991c9e4ff1dbb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3553304
Reviewed-by: Austin Sullivan <[email protected]>
Commit-Queue: Marijn Kruisselbrink <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#986111}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3557907
Auto-Submit: Marijn Kruisselbrink <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/4951@{#246}
Cr-Branched-From: 27de6227ca357da0d57ae2c7b18da170c4651438-refs/heads/main@{#982481}
[M101][DragDrop] Add Android.DragDrop.Image.OpenFileTime.FirstAttempt
Merge to M101.
Record the duration between receiving Android Drag End event and the
first ContentProvider#openFile attempted by the drop target app.
Record 0 if the duration is negative for both
Android.DragDrop.Image.OpenFileTime.FirstAttempt and LastAttempt.
(cherry picked from commit 6fc7b0f352d45cd11b892bec8e74b1441a1f0ed0)
Bug: 1299143
Change-Id: I36e1a8f881650b59b0876a6018ad182a1386f279
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3538167
Reviewed-by: Wenyu Fu <[email protected]>
Reviewed-by: Theresa Sullivan <[email protected]>
Reviewed-by: Tomasz Wiszkowski <[email protected]>
Commit-Queue: Shu Yang <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#984500}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3557975
Auto-Submit: Shu Yang <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Commit-Queue: Tomasz Wiszkowski <[email protected]>
Cr-Commit-Position: refs/branch-heads/4951@{#245}
Cr-Branched-From: 27de6227ca357da0d57ae2c7b18da170c4651438-refs/heads/main@{#982481}
[iOS][media-permissions] Change permissions camera icon image
This CL does the following,
1) Change the camera fill icon to a smaller size
2) Change the permission icons to a non-filled version in overflow
3) Change the overflow icon if #use-new-popup is enabled
(cherry picked from commit 60ba62cdc90f096c1b3399ce5c011cff7b6dc208)
Bug: 1307717
Change-Id: I50720738877c627f8a76a881dc89de9d130cea88
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3553314
Auto-Submit: Ginny Huang <[email protected]>
Reviewed-by: Chris Lu <[email protected]>
Commit-Queue: Chris Lu <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#986106}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3558750
Commit-Queue: Ginny Huang <[email protected]>
Cr-Commit-Position: refs/branch-heads/4951@{#244}
Cr-Branched-From: 27de6227ca357da0d57ae2c7b18da170c4651438-refs/heads/main@{#982481}
M101: sql: Handle sqlite3_backup_init() failures.
https://crrev.com/c/3520185 removed error checks in the code calling
sqlite3_backup_init(), based on a DCHECK that suggested the function
should not error out given our usage.
Crash data from the field proved this assumption was incorrect. This
CL adds a test demonstrating one failure case, and adds error handling
back in the code calling sqlite3_backup_init().
(cherry picked from commit cdef384420333e3c22cf3c9e1743b000e414cd73)
Bug: 1308325
Change-Id: I6c54a521faeb7812d01f7c9645646aba4ccb693f
Tested: New test hit the deleted DCHECK (before it was deleted).
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3554638
Auto-Submit: Victor Costan <[email protected]>
Reviewed-by: Austin Sullivan <[email protected]>
Commit-Queue: Austin Sullivan <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#986071}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3558320
Cr-Commit-Position: refs/branch-heads/4951@{#243}
Cr-Branched-From: 27de6227ca357da0d57ae2c7b18da170c4651438-refs/heads/main@{#982481}
[M101] Suppress the failing out-of-bounds-array-buffers.html WebGL test
The WebGL Conformance test at
conformance/rendering/out-of-bounds-array-buffers.html
is failing on Windows Intel card, with latest patch of ANGLE build.
Suppress this test so that ANGLE cl can pass the CQ test.
(cherry picked from commit 1de6709a50a9524cc6007187fce5c917f9bbf373)
Bug: 1307924
Bug: 1311208
Change-Id: Id8fe091b0bf3f019b05b1166009d5d52fa5930f8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3537749
Reviewed-by: Geoff Lang <[email protected]>
Reviewed-by: Kenneth Russell <[email protected]>
Commit-Queue: Yuxin Hu <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#983562}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3558611
Commit-Queue: Kenneth Russell <[email protected]>
Reviewed-by: Yuly Novikov <[email protected]>
Cr-Commit-Position: refs/branch-heads/4951@{#242}
Cr-Branched-From: 27de6227ca357da0d57ae2c7b18da170c4651438-refs/heads/main@{#982481}
FrameSinkBundle: Lazily observe BeginFrameSource
BeginFrameSources may have some overhead while generating frame events,
e.g. requiring VSync on Windows. If nobody is listening to these events,
they may waste significant resources. By contract, BFS implementations
agree to free such resources when no observers are present.
Meanwhile, FrameSinkBundles group their sinks by BeginFrameSource and
eagerly observe said source even while no frame sinks are present. That
means any use of FrameSinkBundles can trivially lead to unnecessary BFS
overhead.
This changes the FrameSinkBundle implementation so that each SinkGroup
only lazily observes its BFS as long as at least one FrameSink exists in
the group.
(cherry picked from commit 88c004adb325dee2be844e0411c68984faede31d)
Fixed: 1307440
Change-Id: I73e699598cc8e95da7bd6760d38208976e8ba37e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3544647
Reviewed-by: Kyle Charbonneau <[email protected]>
Commit-Queue: Ken Rockot <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#985579}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3557900
Auto-Submit: Ken Rockot <[email protected]>
Commit-Queue: Kyle Charbonneau <[email protected]>
Cr-Commit-Position: refs/branch-heads/4951@{#241}
Cr-Branched-From: 27de6227ca357da0d57ae2c7b18da170c4651438-refs/heads/main@{#982481}
Merge to release branch: Un-expire persistent-quota flag.
(cherry picked from commit e758190307bfe6c16cc0c24cc23da66ab8fa7872)
Bug: 1233525, 1309076
Change-Id: Ia66854d9db36d1c722096341241d94b5b48496af
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3535206
Auto-Submit: Chris Fredrickson <[email protected]>
Reviewed-by: Marijn Kruisselbrink <[email protected]>
Commit-Queue: Marijn Kruisselbrink <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#983690}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3542665
Commit-Queue: Chris Fredrickson <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/4951@{#240}
Cr-Branched-From: 27de6227ca357da0d57ae2c7b18da170c4651438-refs/heads/main@{#982481}
[Merge to M101] wm: Another speculative fix for the crash during window dragging
This is another specutlative fix for the crash that happens during
dragging. It's possible that when dragging a maximized window, restoring
the maximized window may cause the window being destroyed. Early return
in this case.
(cherry picked from commit 2eb6c28fab6cb64ca1b099fd57ed4d93139f95db)
Bug: 1200599
Change-Id: Ib8c49ee418e6fd1d3549de6e7b8ec71f6a35e412
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3543511
Reviewed-by: Xiyuan Xia <[email protected]>
Commit-Queue: Xiaoqian Dai <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#984102}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3557902
Cr-Commit-Position: refs/branch-heads/4951@{#239}
Cr-Branched-From: 27de6227ca357da0d57ae2c7b18da170c4651438-refs/heads/main@{#982481}
Configure the NetworkService after creation on android webview
It seems the default schemes for Android webview were not applied in
time, because ConfigureHttpAuthPrefs was not called right after
SetUpHttpAuth in AwContentBrowserClient::OnNetworkServiceCreated.
(cherry picked from commit 593521f76f75e93013452d49825141f11d51a317)
Bug: 1305229
Change-Id: Icd9e28f9f31e2dcc49b1d221a11ba2b1f473daba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3540581
Reviewed-by: Rohit Rao <[email protected]>
Reviewed-by: Alex Ilin <[email protected]>
Reviewed-by: Nate Fischer <[email protected]>
Reviewed-by: Matt Menke <[email protected]>
Commit-Queue: Yann Dago <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#985412}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3553191
Auto-Submit: Yann Dago <[email protected]>
Commit-Queue: Nate Fischer <[email protected]>
Cr-Commit-Position: refs/branch-heads/4951@{#238}
Cr-Branched-From: 27de6227ca357da0d57ae2c7b18da170c4651438-refs/heads/main@{#982481}
[M101][exo] Crash when the Surface is destroyed on dnd end
It is common when the drop surface is a UI submenu that
the underlying Surface is destroyed upon drop.
This happens for instance in Lacros when the user drags a
item over a bookmark bar folder, and drops it on the submenu.
In this scenario, Exo should not try to send any pointer enter
event, since the Surface has been destroyed.
BUG=1285504,1307143
R=[email protected]
(cherry picked from commit 216ba150e0002f8fce059bcb9eb96c004c6f5b59)
Change-Id: Ie5d6af026c692a17f27d0c5e15b9717ee04dcf5a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3529650
Reviewed-by: Mitsuru Oshima <[email protected]>
Commit-Queue: Antonio Gomes <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#983292}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3556698
Auto-Submit: Antonio Gomes <[email protected]>
Commit-Queue: Mitsuru Oshima <[email protected]>
Cr-Commit-Position: refs/branch-heads/4951@{#237}
Cr-Branched-From: 27de6227ca357da0d57ae2c7b18da170c4651438-refs/heads/main@{#982481}
[M101] viz: Clear overlay locks on SwapBuffersSkipped
Rapidly rotating the display orientation on CrOS can leave the
device in a bad state. This is because updating the orientation sets
the current rotation in Viz and animates between the old and new
rotations via CopyOutputRequests.
While Viz waits for for the ui::Compositor to produce a frame at the
new orientation, Display::DrawAndSwap will usually skip both drawing
content and swapping buffers. However, if the frame has a
CopyOutputRequest (which can sometimes happen when rapidly rotating
the screen), we will be forced to draw the frame for the copy but
will still not swap.
This is problematic because drawing invokes SkiaRenderer::
CommitOverlays which adds an entry to pending_overlay_locks_ [1]
to ensure that overlay resources are not freed too early.
Unfortunately, these locks are only removed at the end of the next
SwapBuffers [2]. Thus, when Viz draws but does not swap,
pending_overlay_locks_ grows by an extra entry which causes problems.
For example, ARC++ apps will hang as they wait for their presentation
buffers to be freed, even though they are perpetually stuck in
pending_overlay_locks_.
This CL fixes this issue by clearing the last drawn frame's overlay
locks if Viz does not end up swapping buffers.
[1] https://source.chromium.org/chromium/chromium/src/+/main:components/viz/service/display/skia_renderer.cc;l=2359;drc=1e63878d3c35dbabad85e49ff0f53f09cc2280fe
[2] https://source.chromium.org/chromium/chromium/src/+/main:components/viz/service/display/skia_renderer.cc;l=854;drc=5af781c328bdc091651764b5d9ea0f6d77828fed
(cherry picked from commit a41fd03e6dbc453630837b5b08a6eab1abf34f0e)
Bug: b:223980619
Change-Id: I07e08a5a9ceabc3ef56db8881a74cf7166a199bb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3555806
Reviewed-by: Kyle Charbonneau <[email protected]>
Commit-Queue: Brian Ho <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#986200}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3558549
Cr-Commit-Position: refs/branch-heads/4951@{#236}
Cr-Branched-From: 27de6227ca357da0d57ae2c7b18da170c4651438-refs/heads/main@{#982481}
[realbox] Add transparent google g to build file
The svg for the transparent google g was added to the realbox icons but
it was never added to the build file.
(cherry picked from commit 6ca9e1a542364b87bad13684f496bd3a57698634)
Bug: 1308945
Change-Id: I5f77142bc7a40bd2f0f38206c7e2c39ae5a223f8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3551259
Reviewed-by: Mohamad Ahmadi <[email protected]>
Commit-Queue: Mohamad Ahmadi <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#985130}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3551463
Auto-Submit: Marlon Facey <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Commit-Queue: Marlon Facey <[email protected]>
Cr-Commit-Position: refs/branch-heads/4951@{#235}
Cr-Branched-From: 27de6227ca357da0d57ae2c7b18da170c4651438-refs/heads/main@{#982481}
Fix themed NTP background flashing under multi profiles
(cherry picked from commit f8b9bb5b47db9836247d3146bd14c9f5ff8cca83)
Bug: 1309818
Change-Id: Ibdfc64d22fe5102ea668aec0ca5e321d8d3a1977
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3550763
Reviewed-by: Rebekah Potter <[email protected]>
Commit-Queue: Keren Zhu <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#985321}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3555889
Reviewed-by: Peter Kasting <[email protected]>
Commit-Queue: Peter Kasting <[email protected]>
Cr-Commit-Position: refs/branch-heads/4951@{#234}
Cr-Branched-From: 27de6227ca357da0d57ae2c7b18da170c4651438-refs/heads/main@{#982481}
[M101 merge] fwupd: Allow missing description for an update
Merge notes: No changes made from original CL.
Previously required all fwupd updates to have a description,
since descriptions are no longer used it can be removed as a
requirement.
(cherry picked from commit aa17040583490f2ff0e91f0321a1796136968f8b)
Bug: b/226299604
Change-Id: I11bbda93efd75d4c8bdcd91cf6c9226753244b2d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3551256
Reviewed-by: Zentaro Kavanagh <[email protected]>
Commit-Queue: Jimmy Gong <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#985501}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3556154
Commit-Queue: Zentaro Kavanagh <[email protected]>
Cr-Commit-Position: refs/branch-heads/4951@{#233}
Cr-Branched-From: 27de6227ca357da0d57ae2c7b18da170c4651438-refs/heads/main@{#982481}
Fixed the crash on ShelfBackgroundLayerDelegate
This cl fixed the issue that layer->bounds() is used in layer delelgate
that gives the wrong bounds for the delegate to draw. Also, the layer
delegate is not getting the corner radius from layer itself, which I
believe that is invalid during animation.
(cherry picked from commit e6b6a4f76a392133ed87f25411c844e77bcf39fa)
Bug: 1307810, 1307834, 1307836
Change-Id: Ia1886f456235a1a7889f0131e44f1596529e7015
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3537417
Reviewed-by: Toni Barzic <[email protected]>
Commit-Queue: Wen-Chien Wang <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#982968}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3556122
Reviewed-by: Andrew Xu <[email protected]>
Commit-Queue: Toni Barzic <[email protected]>
Cr-Commit-Position: refs/branch-heads/4951@{#232}
Cr-Branched-From: 27de6227ca357da0d57ae2c7b18da170c4651438-refs/heads/main@{#982481}
Cronet: destroy network-bound contexts when no longer useful
This stops us from leaking URLRequests when we destroy a network-bound
URLRequestContext (after the network they're bound to disconnects).
When a network disconnects destroy the associated URLRequestContexts (if
it exists) only if it has no pending URLRequests. If there are, do
nothing, and let the URLRequests themselves destroy it lazily when they
fail/complete.
This is implemented by always calling back into
CronetContext::MaybeDestroyURLRequestContext while destroying a
CronetURLRequest request.
(cherry picked from commit 0d3e86dd2bd59f5650cf85db5957bb95cfa4beb5)
Bug: 1284972, 1309865
Change-Id: I8b979e4a3b57939a3078f458ee587783f47eb5a8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3516376
Reviewed-by: Richard Coles <[email protected]>
Commit-Queue: Stefano Duo <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#984795}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3550589
Auto-Submit: Stefano Duo <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/4951@{#231}
Cr-Branched-From: 27de6227ca357da0d57ae2c7b18da170c4651438-refs/heads/main@{#982481}
[M101] Fix test flakiness by adding flag.
Merge to release branch.
WidgetInputHandlerManager has logic to ignore user input before content
has been rendered. We don't care about whether content is visible during
testing, so disable that feature with a command line flag -- it made
some tests flaky.
(cherry picked from commit fb0f84c29ebc6dab88ea5b43d52699c0ddab9813)
Bug: 987626, 1307275, 1307293, 1308894
Change-Id: I6e57076b7952906703b5933ea2daddf442d99c59
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3549616
Reviewed-by: Matt Reichhoff <[email protected]>
Commit-Queue: Ryan Tarpine <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#984854}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3557353
Cr-Commit-Position: refs/branch-heads/4951@{#230}
Cr-Branched-From: 27de6227ca357da0d57ae2c7b18da170c4651438-refs/heads/main@{#982481}
Updating XTBs based on .GRDs from branch 4951
Change-Id: Iba5900e9bcd09d03dbd3ea1754f15b7b8773f1f2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3557351
Auto-Submit: Ben Mason <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/4951@{#229}
Cr-Branched-From: 27de6227ca357da0d57ae2c7b18da170c4651438-refs/heads/main@{#982481}
Roll ChromeOS Bigcore AFDO profile from 101-4937.0-1647859331-benchmark-101.0.4951.13-r1 to 101-4937.0-1648462840-benchmark-101.0.4951.15-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-bigcore-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium Beta Branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: [email protected]
Change-Id: I514d60e01c4dddea54f6f9f1063781a9036d5127
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3556995
Commit-Queue: Chrome Release Autoroll <[email protected]>
Bot-Commit: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4951@{#228}
Cr-Branched-From: 27de6227ca357da0d57ae2c7b18da170c4651438-refs/heads/main@{#982481}
Roll ChromeOS Atom AFDO profile from 101-4937.0-1647867996-benchmark-101.0.4951.13-r1 to 101-4951.6-1648463443-benchmark-101.0.4951.15-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-atom-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium Beta Branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: [email protected]
Change-Id: Ia7b91bc724154233a04ffb28d7f2fff688dc72d4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3556714
Commit-Queue: Chrome Release Autoroll <[email protected]>
Bot-Commit: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4951@{#227}
Cr-Branched-From: 27de6227ca357da0d57ae2c7b18da170c4651438-refs/heads/main@{#982481}
Roll AFDO from 101.0.4951.13_rc-r1-merged to 101.0.4951.15_rc-r1-merged
This CL may cause a small binary size increase, roughly proportional
to how long it's been since our last AFDO profile roll. For larger
increases (around or exceeding 100KB), please file a bug against
[email protected]. Additional context: https://crbug.com/805539
Please note that, despite rolling to chrome/android, this profile is
used for both Linux and Android.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/afdo-chromium-beta-autoroll
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium Beta Branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: [email protected]
Change-Id: I0af0381b83fb94ab30b8da6a6245ee780d2ae7e7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3556298
Commit-Queue: Chrome Release Autoroll <[email protected]>
Bot-Commit: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4951@{#226}
Cr-Branched-From: 27de6227ca357da0d57ae2c7b18da170c4651438-refs/heads/main@{#982481}
Allow semantic-only selectors
Before, a selector without CSS but only semantic information was
considered "empty". This made the BatchElementChecker disregard it
and never attempt to resolve it. As a result, a WaitForDom with a
semantic selector never worked.
(cherry picked from commit 4875fded0843fbfba46983e1b66cff121aae50f5)
Bug: 1310691
Bug: b:226910816
Change-Id: I635d7078731d32e8b0acb8d38034e7bf2032d5a1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3550221
Commit-Queue: Sandro Maggi <[email protected]>
Auto-Submit: Sandro Maggi <[email protected]>
Reviewed-by: Mathias Carlen <[email protected]>
Commit-Queue: Mathias Carlen <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#985319}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3552571
Cr-Commit-Position: refs/branch-heads/4951@{#225}
Cr-Branched-From: 27de6227ca357da0d57ae2c7b18da170c4651438-refs/heads/main@{#982481}
[Merge 101] Privacy Sandbox: Accept feature override as confirmation
CL adjusts the PrivacySandboxSettings delegate implementation to accept
the recently added override feature as confirmation.
(cherry picked from commit 1d89f43754b9de931bb3234613acee948c94300d)
Bug: 1310173
Change-Id: I757bf5472c31ae73bcfd47506ac88cee9e141eb9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3552636
Auto-Submit: Theodore Olsauskas-Warren <[email protected]>
Reviewed-by: Sean Harrison <[email protected]>
Commit-Queue: Sean Harrison <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#985232}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3552635
Bot-Commit: Rubber Stamper <[email protected]>
Commit-Queue: Theodore Olsauskas-Warren <[email protected]>
Cr-Commit-Position: refs/branch-heads/4951@{#224}
Cr-Branched-From: 27de6227ca357da0d57ae2c7b18da170c4651438-refs/heads/main@{#982481}
Use continue_on_shutdown for opt. guide task runners
(cherry picked from commit f139e8e6ad38b2b719c2c6e796603eda7a647866)
Bug: 1310377
Change-Id: Ibfc1b07c0e47dbedead6da537ecfdbbab82c9946
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3543659
Reviewed-by: Sophie Chang <[email protected]>
Commit-Queue: Tarun Bansal <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#985517}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3556157
Cr-Commit-Position: refs/branch-heads/4951@{#223}
Cr-Branched-From: 27de6227ca357da0d57ae2c7b18da170c4651438-refs/heads/main@{#982481}
[journeys] Further cull entities if they do not meet the threshold
The previous approach only removed entities from batch entity metadata
task but if there is a valid entity above threshold somewhere else in
the clustering pass that is the same as the one that was "removed", this
didn't actually do anything
(cherry picked from commit dc5dbb6a1558f623257ff79b1cd3b48808ce22ce)
Bug: 1309665
Change-Id: I70742d88e8e85be0c6ae88d57b4456a12b8600eb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3553460
Reviewed-by: Tommy Li <[email protected]>
Commit-Queue: Sophie Chang <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#985418}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3556738
Auto-Submit: Sophie Chang <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/4951@{#222}
Cr-Branched-From: 27de6227ca357da0d57ae2c7b18da170c4651438-refs/heads/main@{#982481}
[Merge 101] Privacy Sandbox Settings: Set V2 manually controlled pref
CL adjusts behavior on the Privacy Sandbox settings page to set the
correct version of the manually controlled preference.
(cherry picked from commit 5f2d8a3ffc659e7a49b2abb51fd07c13fcbec2b8)
Bug: 1310161
Change-Id: I5d025613cc035596c80aee31daf8155697819092
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3551840
Reviewed-by: Tommy Li <[email protected]>
Reviewed-by: Olesia Marukhno <[email protected]>
Commit-Queue: Theodore Olsauskas-Warren <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#985330}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3551931
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/4951@{#221}
Cr-Branched-From: 27de6227ca357da0d57ae2c7b18da170c4651438-refs/heads/main@{#982481}
[Merge to M101][Topics] Implement BrowsingTopicsServiceImpl
- Implement the BrowsingTopicsServiceImpl responsible for scheduling the
topics calculation, observing and handling history/cookies deletion,
and calculating the topics for the JS API and for the UX.
- Integrate with the renderer side API.
- Update the
BrowsingTopicsSiteDataManager/Storage::OnBrowsingTopicsApiUsed API() to
let it get the timestamp from the main thread and pass it to the
backend thread. This way, it's consistent with the query operation,
so that there's no races (i.e. a Query(/*end_time=*/Now()) is
guaranteed to return previously stored entries).
- Update model_version type from "int" to "int64_t": the model version
is expected to exceed the limit of int (i.e. it's using the timestamp).
(cherry picked from commit cc37939dc5f9987a6d649d5357627f85ad9f1e03)
Binary-Size: Size increase is unavoidable due to new feature.
Bug: 1310012
Change-Id: I45bc0ff3e7b8e9df28c940d14a95f076d9a69944
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3526273
Reviewed-by: Josh Karlin <[email protected]>
Reviewed-by: Daniel Cheng <[email protected]>
Reviewed-by: Avi Drissman <[email protected]>
Commit-Queue: Yao Xiao <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#985500}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3552463
Reviewed-by: Yao Xiao <[email protected]>
Cr-Commit-Position: refs/branch-heads/4951@{#220}
Cr-Branched-From: 27de6227ca357da0d57ae2c7b18da170c4651438-refs/heads/main@{#982481}
[realbox] Adding polish to Pedals
Add transparent G, Change font size, add more padding to action row
to make it match the omnibox more closely.
Note: Can't test the transparent google_g icon since gsuite features
do not work on Omnibox
Before: http://screenshot/7H8bY5eznUkW3pK
After: http://screenshot/C2EoajP8WaoofVo
(cherry picked from commit bb4002a015a079b1e1c961e79bd7959a916f9ec2)
Fixed: 1308945, 1307543, 1307537
Change-Id: Ib9fb5672132d298bfe6937d794bb06afb7e02e17
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3537393
Reviewed-by: Mohamad Ahmadi <[email protected]>
Commit-Queue: Marlon Facey <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#984470}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3551440
Auto-Submit: Marlon Facey <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Commit-Queue: Mohamad Ahmadi <[email protected]>
Cr-Commit-Position: refs/branch-heads/4951@{#219}
Cr-Branched-From: 27de6227ca357da0d57ae2c7b18da170c4651438-refs/heads/main@{#982481}
[journeys] Do not include entities or categories in processing if relevance is too low
(cherry picked from commit dd74aa8d6c725351728d23bb35b67d2277e0e8ea)
Bug: 1309665
Change-Id: I3bb8df3e2d2ccf29efc8d1e36aabad48e9de722e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3546466
Reviewed-by: Tommy Li <[email protected]>
Commit-Queue: Sophie Chang <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#984685}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3556730
Auto-Submit: Sophie Chang <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/4951@{#218}
Cr-Branched-From: 27de6227ca357da0d57ae2c7b18da170c4651438-refs/heads/main@{#982481}
Incrementing VERSION to 101.0.4951.15
Change-Id: Ieb94c02a4bf032124fcfef149d8a3abeb56e3828
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3552095
Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/4951@{#217}
Cr-Branched-From: 27de6227ca357da0d57ae2c7b18da170c4651438-refs/heads/main@{#982481}
[M101] Remove xenial_or_bionic for try android builders
This is making a few milestone android builders run on xenial bots.
This CL needs to be cherry-picked.
(cherry picked from commit cd90c7194fd70b8557be070d8a35c3bd995e7ed5)
Bug: 1202741
Change-Id: Ic162730da9f8a48ac1ddee84ca265a5412846035
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3553578
Reviewed-by: Garrett Beaty <[email protected]>
Commit-Queue: Stephanie Kim <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#986131}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3556421
Auto-Submit: Stephanie Kim <[email protected]>
Commit-Queue: Garrett Beaty <[email protected]>
Cr-Commit-Position: refs/branch-heads/4951@{#216}
Cr-Branched-From: 27de6227ca357da0d57ae2c7b18da170c4651438-refs/heads/main@{#982481}
Delete old model paths at beginning of next session rather than right after update
This removes a race from when an execution is happening and the model
file gets updated/deleted from underneath it causing SIGBUS
(cherry picked from commit 0c7fa09551646c727ceaf6815fccb2f390b5c4b6)
Bug: 1307862
Change-Id: I434558cfe36019b791206e5a79527c4d254fde49
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3536938
Reviewed-by: Robert Ogden <[email protected]>
Commit-Queue: Sophie Chang <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#983429}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3556149
Auto-Submit: Sophie Chang <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/4951@{#215}
Cr-Branched-From: 27de6227ca357da0d57ae2c7b18da170c4651438-refs/heads/main@{#982481}
[lacros] Update lacros QA qualified version
This CL will update lacros version in //chrome/LACROS_QA_QUALIFIED_VERSION. This
file will be used in Upreving the RootFS-Lacros in the CROS image.
If this CL caused regressions, please revert and pause the autoroller at
https://luci-scheduler.appspot.com/jobs/chrome/lacros-qa-qualified-tracking-roller
Also please file a bug to OS>LaCrOS>Partner, and CC [email protected],
[email protected], [email protected].
[email protected]
Change-Id: Ia0b2162c628ce41e67e7b82154a3e652b3e70795
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3552468
Auto-Submit: lacros-tracking-roller@chops-service-accounts.iam.gserviceaccount.com <lacros-tracking-roller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/4951@{#214}
Cr-Branched-From: 27de6227ca357da0d57ae2c7b18da170c4651438-refs/heads/main@{#982481}
[CHU] Expose version info of CommerceHeuristicsData
(cherry picked from commit 8107048d1ecc416ecd5bfde1292ad18fee7f9c33)
Bug: 1300332
Change-Id: I7e0e4b71bcd95d65c8d00425778fae0b4a45c6d7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3540710
Reviewed-by: Wei-Yin Chen <[email protected]>
Reviewed-by: Joshua Pawlicki <[email protected]>
Commit-Queue: Yue Zhang <[email protected]>
Auto-Submit: Yue Zhang <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#984369}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3554877
Cr-Commit-Position: refs/branch-heads/4951@{#213}
Cr-Branched-From: 27de6227ca357da0d57ae2c7b18da170c4651438-refs/heads/main@{#982481}
[lacros skew tests] Refresh skew tests for M102
This CL updates the ash version ['102.0.4970.0'] for Lacros version skew testing.
If this CL caused regressions, please revert and stop the autoroller
at https://luci-scheduler.appspot.com/jobs/chrome/lacros-version-skew-roller
Also please file a bug to OS>LaCrOS>Partner, and CC [email protected],
[email protected], [email protected].
[email protected]
Bug: None
Change-Id: I003f281302bb9846164bf2416915ee62123b27a5
Requires-Testing: True
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3555258
Auto-Submit: chrome-weblayer-builder <chrome-weblayer-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/4951@{#212}
Cr-Branched-From: 27de6227ca357da0d57ae2c7b18da170c4651438-refs/heads/main@{#982481}
[CHU] Feed renderer heuristics from component to ChromeCart [2]
(cherry picked from commit f1f49d9c0ea464ee2656a7f08205b720d4601013)
Bug: 1300332
Change-Id: I7eee52d99146a7c0ea275c5852c9a9fa65ec1a25
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3533547
Reviewed-by: Wei-Yin Chen <[email protected]>
Commit-Queue: Yue Zhang <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#984103}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3550605
Cr-Commit-Position: refs/branch-heads/4951@{#211}
Cr-Branched-From: 27de6227ca357da0d57ae2c7b18da170c4651438-refs/heads/main@{#982481}
[CHU] Feed renderer heuristics from component to ChromeCart [1]
(cherry picked from commit 6410ba821edbf3c839bb38bfe31096472c7f3eeb)
Bug: 1300332
Change-Id: Ieb25c8db0aeb7043c07c5eadcd25655f944b41ca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3530760
Reviewed-by: Wei-Yin Chen <[email protected]>
Commit-Queue: Yue Zhang <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#982487}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3550638
Commit-Queue: Wei-Yin Chen <[email protected]>
Cr-Commit-Position: refs/branch-heads/4951@{#210}
Cr-Branched-From: 27de6227ca357da0d57ae2c7b18da170c4651438-refs/heads/main@{#982481}
[Merge to M101] Put User-Agent Client Hint override behavior behind feature
New behavior was introduced in crrev.com/c/3484996 that may be causing
some compat issues, so adding a feature flag for a softer roll out
later
(cherry picked from commit 48268d651d914506dd08603f7b94b640ccdb4748)
Bug: 1240171
Change-Id: Ib70cb381014c16a78cd0e99a3a098422ee5d0b19
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3550762
Commit-Queue: Aaron Tagliaboschi <[email protected]>
Reviewed-by: Ali Beyad <[email protected]>
Reviewed-by: Bo Liu <[email protected]>
Reviewed-by: James Maclean <[email protected]>
Reviewed-by: Steve Kobes <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#985385}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3555252
Commit-Queue: Victor Tan <[email protected]>
Cr-Commit-Position: refs/branch-heads/4951@{#209}
Cr-Branched-From: 27de6227ca357da0d57ae2c7b18da170c4651438-refs/heads/main@{#982481}
Incrementing VERSION to 101.0.4951.14
Change-Id: Ie732da6703b5c245a64aaec227c74c1f1328d7e2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3553185
Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/4951@{#208}
Cr-Branched-From: 27de6227ca357da0d57ae2c7b18da170c4651438-refs/heads/main@{#982481}
[M101] Dismiss keyboard once user scroll the tab grid search results
Deleted the code that added the insets for the keyboard, it was not
working correctly because the insets were not forced to update after the
keyboardOverlay height was calculated, but with the keyboard dismissed
on scroll no need for the insets update.
Also fixed a problem where the suggested actions cell height was fixed
to the maximum the first time the search was performed (first letter).
this issue have been there but not obvious due to the keyboard covering
the space. But with the keyboard dismissed it looked ugly. Fixed that by
preloading the suggested table cells before the suggested actions grid
cell size is determined.
(cherry picked from commit 80100e6d074e2d6256d680126c98d43ed4bf3fac)
Bug: 1308891
Change-Id: I8348ba1961da1ef3164b24dbe681425ce82ea4d6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3541071
Reviewed-by: Mike Dougherty <[email protected]>
Commit-Queue: Mohammad Refaat <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#983916}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3553936
Auto-Submit: Mohammad Refaat <[email protected]>
Commit-Queue: Mike Dougherty <[email protected]>
Cr-Commit-Position: refs/branch-heads/4951@{#207}
Cr-Branched-From: 27de6227ca357da0d57ae2c7b18da170c4651438-refs/heads/main@{#982481}
[TTS][RSearches] Protect for an NPE on chip click
Adds an NPE check when an RS chip is clicked to make sure
we have the associated Related Searches to load.
BUG=1307267
(cherry picked from commit ee4e061d629e692378a6e3214b5c04caf7f0a4ec)
Change-Id: I560c312abc9c2f54f99653137dfb3d19fc9434e8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3533359
Auto-Submit: Donn Denman <[email protected]>
Reviewed-by: Gang Wu <[email protected]>
Commit-Queue: Gang Wu <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#982811}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3556148
Commit-Queue: Donn Denman <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/4951@{#206}
Cr-Branched-From: 27de6227ca357da0d57ae2c7b18da170c4651438-refs/heads/main@{#982481}
[M101] Fix Search History Suggested Action missing result count
Only a single search through the user's history can occur at once.
However, both the regular tab grid and the remote tabs suggested action
cells for searching history were issuing these search requests
simultaneously. The remote tabs page was usually issued last, preventing
the regular tab grid suggested action cell from updating.
In order to fix this, only update the current displayed page with the
entered search terms and pass the search term to the other page only if
the user is about to navigate to it.
Additionally, add an animation to fade in the updated count label text.
(cherry picked from commit fa2f0e3097605cc1cf9a5f9c9dedac1ed4b23588)
Fixed: 1309155
Change-Id: If3893e4d79a67b7bc2f0c6c1ec9011aa6e4527cf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3543318
Reviewed-by: Mohammad Refaat <[email protected]>
Commit-Queue: Mike Dougherty <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#984520}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3555202
Auto-Submit: Mike Dougherty <[email protected]>
Commit-Queue: Mohammad Refaat <[email protected]>
Cr-Commit-Position: refs/branch-heads/4951@{#205}
Cr-Branched-From: 27de6227ca357da0d57ae2c7b18da170c4651438-refs/heads/main@{#982481}
Add enterprise policy for setTimeoutWithoutClamp flag
(cherry picked from commit 28eb25e23962949fe1a94fb7af83eeb6e0489d3b)
Bug: 402694
Change-Id: Id20f4255883fb9f57263c50ab8609e50cb94fc25
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3503058
Reviewed-by: Daniel Cheng <[email protected]>
Reviewed-by: Owen Min <[email protected]>
Reviewed-by: Tommy Nyquist <[email protected]>
Reviewed-by: Scott Haseley <[email protected]>
Commit-Queue: Wanming Lin <[email protected]>
Auto-Submit: Wanming Lin <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#983632}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3540652
Bot-Commit: Rubber Stamper <[email protected]>
Owners-Override: Prudhvikumar Bommana <[email protected]>
Commit-Queue: Scott Haseley <[email protected]>
Cr-Commit-Position: refs/branch-heads/4951@{#204}
Cr-Branched-From: 27de6227ca357da0d57ae2c7b18da170c4651438-refs/heads/main@{#982481}
Make sure all users in the Control group get to see the widget.
The widget enabled state is retained by the package manager.
All users who were in the control group will not receive the
widget until that state is corrected, otherwise the offering
will persist.
The change partially reverts the mechanism that was used to
conditionally disable Widget for users in Control group, and
uses it to unconditionally enable it for everyone.
The restored code taken from http://shortn/_NL8d3BYmTI.
(cherry picked from commit 3b730ff12b77905796647ab3b3cd8bbd267c51d5)
Bug: 1309116
Change-Id: I86705fcfcefff18921f5a203ce80caddd07d44c4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3549540
Auto-Submit: Tomasz Wiszkowski <[email protected]>
Reviewed-by: Filip Gorski <[email protected]>
Commit-Queue: Filip Gorski <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#984976}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3555198
Commit-Queue: Tomasz Wiszkowski <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/4951@{#203}
Cr-Branched-From: 27de6227ca357da0d57ae2c7b18da170c4651438-refs/heads/main@{#982481}
Use updateable pins list to enforce key pinning
As part of this CL, GetStaticDomainState was separated into
GetStaticPKPState and GetStaticSTSState (similar to how the dynamic
counterparts were separated). For the most part this is an
implementation detail, but this (as a side effect) fixes a bug where
static Expect-CT was causing SSL errors to be treated as fatal, when it
shouldn't have. This only affects two domains
(preloaded-expect-ct.badssl.com and ritter.vg) which are in the static
list for Expect-CT, but not for HSTS or key pinning.
(cherry picked from commit c6b73a7e1338d1290ea984f69f8456888c2f10f6)
Bug: 1286121
Change-Id: I555f665cbe0df5b00e5d8d37cf331a03335a4078
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3413459
Reviewed-by: David Benjamin <[email protected]>
Commit-Queue: Carlos IL <[email protected]>
Auto-Submit: Carlos IL <[email protected]>
Reviewed-by: Clark DuVall <[email protected]>
Commit-Queue: Clark DuVall <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#984547}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3556118
Bot-Commit: Rubber Stamper <[email protected]>
Commit-Queue: Prudhvikumar Bommana <[email protected]>
Owners-Override: Prudhvikumar Bommana <[email protected]>
Cr-Commit-Position: refs/branch-heads/4951@{#202}
Cr-Branched-From: 27de6227ca357da0d57ae2c7b18da170c4651438-refs/heads/main@{#982481}
Roll AFDO from 101.0.4948.0_rc-r2-merged to 101.0.4951.13_rc-r1-merged
This CL may cause a small binary size increase, roughly proportional
to how long it's been since our last AFDO profile roll. For larger
increases (around or exceeding 100KB), please file a bug against
[email protected]. Additional context: https://crbug.com/805539
Please note that, despite rolling to chrome/android, this profile is
used for both Linux and Android.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/afdo-chromium-beta-autoroll
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium Beta Branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: [email protected]
Change-Id: I1f3236957c769b54ce80be5bd3887db54eb67c5b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3556112
Commit-Queue: Chrome Release Autoroll <[email protected]>
Bot-Commit: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4951@{#201}
Cr-Branched-From: 27de6227ca357da0d57ae2c7b18da170c4651438-refs/heads/main@{#982481}
[M101]Stop receiving input on the bottomtoolbar when it is not visible
This fix problems with thumbstrip and searchmode where there should be
no bottomtoolbar. however the toolbar is still on the layout and
intercepting input.
(cherry picked from commit 533671dc2c8b5913e0aac571b1dc428ecc3906c6)
Bug: 1308742
Change-Id: I505a201f9dda04efef4b53167e644ec59b78350b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3540963
Reviewed-by: Mike Dougherty <[email protected]>
Commit-Queue: Mohammad Refaat <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#983536}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3554361
Auto-Submit: Mohammad Refaat <[email protected]>
Commit-Queue: Mike Dougherty <[email protected]>
Cr-Commit-Position: refs/branch-heads/4951@{#200}
Cr-Branched-From: 27de6227ca357da0d57ae2c7b18da170c4651438-refs/heads/main@{#982481}
[M101 Merge[[side search] Add a chrome://flags entry for improved clobbering
(cherry picked from commit 54ddbd2a9e5b40e2e431a8708b3b95b4d0b4bd69)
Bug: 1310299
Change-Id: I75d8dd4fe9c69941b44352bff793651e2147ee24
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3553303
Reviewed-by: Roman Arora <[email protected]>
Commit-Queue: Thomas Lukaszewicz <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#985506}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3555396
Cr-Commit-Position: refs/branch-heads/4951@{#199}
Cr-Branched-From: 27de6227ca357da0d57ae2c7b18da170c4651438-refs/heads/main@{#982481}
Fix feature list in ads apis about:flag
The string supplied here is not testable, so this was missed in the
initial review of
https://chromium-review.googlesource.com/c/chromium/src/+/3527133
(cherry picked from commit e76d5f724e7f72e2f17de572309bc8cef8ad7ea8)
Bug: 1310289
Change-Id: I2ae65aff0d85a4054af1b226c175da8dcdbf1716
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3551885
Reviewed-by: Nan Lin <[email protected]>
Commit-Queue: John Delaney <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#985551}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3556008
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/4951@{#198}
Cr-Branched-From: 27de6227ca357da0d57ae2c7b18da170c4651438-refs/heads/main@{#982481}
dpwa: hide options on chrome://apps when not applicable
Hide instead of disable the options item in chrome://apps right click
menu when the optionsUrl is undefined, this is only defined for
extension-based chrome apps.
(cherry picked from commit 1bac1ef4f61b8b7078ffcec4aef28ff16a613514)
Bug: 1307442
Change-Id: Ia69086fc5b2ca3a99f1e8e5d36a6e82d3b3a4f33
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3549506
Reviewed-by: Evan Stade <[email protected]>
Commit-Queue: Phillis Tang <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#985492}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3555431
Auto-Submit: Phillis Tang <[email protected]>
Commit-Queue: Evan Stade <[email protected]>
Cr-Commit-Position: refs/branch-heads/4951@{#197}
Cr-Branched-From: 27de6227ca357da0d57ae2c7b18da170c4651438-refs/heads/main@{#982481}
[Dr-Dc][Merge-101] Add FrameInfoHelperHolder.
1. Add FrameInfoHelperHolder to mimic the weakPtr behavior of
FrameInfoHelperImpl::OnGpu. FrameInfoHelperHolder is
RefCountedThreadSafe, and has a pointer to FrameInfoHelperImpl::OnGpu.
FrameInfoHelperImpl::OnGpu owns the FrameInfoHelperHolder and sets the
pointer to FrameInfoHelperImpl::OnGpu in its destructor.
2. Allow GetFrameInfoImpl() to be run from any thread.
(cherry picked from commit 6f31ac834acc00fff8bb62b7caaab769241d5293)
Bug: 1306650
Change-Id: I77a6ddde6a93c7b1e795b1768090ebcc9867b664
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3527494
Reviewed-by: Vasiliy Telezhnikov <[email protected]>
Commit-Queue: vikas soni <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#984066}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3553937
Auto-Submit: vikas soni <[email protected]>
Commit-Queue: Vasiliy Telezhnikov <[email protected]>
Cr-Commit-Position: refs/branch-heads/4951@{#196}
Cr-Branched-From: 27de6227ca357da0d57ae2c7b18da170c4651438-refs/heads/main@{#982481}
Roll ChromeOS Bigcore AFDO profile from 101-4928.0-1647252364-benchmark-101.0.4948.0-r2 to 101-4937.0-1647859331-benchmark-101.0.4951.13-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-bigcore-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium Beta Branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: [email protected]
Change-Id: I71984cb277609f84291d756ba8f42ff7a58c8ce9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3555660
Commit-Queue: Chrome Release Autoroll <[email protected]>
Bot-Commit: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4951@{#195}
Cr-Branched-From: 27de6227ca357da0d57ae2c7b18da170c4651438-refs/heads/main@{#982481}
Roll ChromeOS Atom AFDO profile from 101-4928.0-1647252934-benchmark-101.0.4948.0-r2 to 101-4937.0-1647867996-benchmark-101.0.4951.13-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-atom-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium Beta Branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: [email protected]
Change-Id: I3244fb5973e97ad156264008816b6cde3f4fa5c6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3555661
Commit-Queue: Chrome Release Autoroll <[email protected]>
Bot-Commit: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4951@{#194}
Cr-Branched-From: 27de6227ca357da0d57ae2c7b18da170c4651438-refs/heads/main@{#982481}
[M101] Disable download shelf when download bubble is enabled.
Since the MVP launch doesn't support deep scanning, keep the new
download bubble disabled for enhanced protection, advanced protection
and WebProtect users. The new UI would be enabled once deep scanning is
supported.
Whether to show the download shelf can change at runtime (e.g. switching
from standard protection to enhanced protection). In this scenario, it's
still possible that both UIs are shown together.
(cherry picked from commit 8ca8b88c81aec62643baf105cc87c894dc29da08)
Bug: 1307021
Change-Id: I04e1d3734d1233c08a2ba02cd3271f44251763d5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3529377
Reviewed-by: Min Qin <[email protected]>
Reviewed-by: Rohit Bhatia <[email protected]>
Reviewed-by: Allen Bauer <[email protected]>
Reviewed-by: Peter Kasting <[email protected]>
Commit-Queue: Xinghui Lu <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#982514}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3551257
Cr-Commit-Position: refs/branch-heads/4951@{#193}
Cr-Branched-From: 27de6227ca357da0d57ae2c7b18da170c4651438-refs/heads/main@{#982481}
[M101 merge] history: don't handle db error during destruction
Handling of db errors is delayed using a posttask. ~HistoryBackend
closes all the dbs. If closing the db results in an error, then
a PostTask() is scheduled with a HistoryBackend that is part way
through deletion. When the PostTask() runs, we get a uaf.
This patch resets the error callback in ~HistoryBackend to ensure
this doesn't happen. This means a db error is effectively ignored
during shutdown. Presumably if the error is fatal, it'll be handled
when the HistoryBackend is created again.
BUG=1306507
TEST=none
(cherry picked from commit 72315bbaa74a0ffe110b33adfebb5252f283b8ce)
Change-Id: Ic158589a43e7bc2fd1f602fb2798ab500dc8d6d7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3538001
Reviewed-by: Victor Costan <[email protected]>
Commit-Queue: Victor Costan <[email protected]>
Commit-Queue: Scott Violet <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#983478}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3554357
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/4951@{#192}
Cr-Branched-From: 27de6227ca357da0d57ae2c7b18da170c4651438-refs/heads/main@{#982481}
[M101 Merge][side search] Implements clobbering+ logic for RHS side panels
This CL introduces an improved clobbering experience for RHS browser
side panels.
The current clobbering experience is whenever a RHS side panel is
shown all other open side panels for that window are immediately
closed. This naive clobbering logic results in UX issues where a user
may not expect their global panel to be dismissed when they open a
tab specific side search instance.
The improved logic covered by this CL implements the following
policy:
1. Only one RHS panel is present in a window at a time.
2. If a contextual panel (side search) is opened it will open over
the top of any open global panels.
3. If the user switches away from the tab with the contextual panel
the previously open global panel will be restored (if it was
open preciously).
(cherry picked from commit b119af9e464f2cc654382085d23d08348ac6d1ea)
Bug: 1309679
Change-Id: Ide39a8e562b3d2879b0f31712c11cd6979ab1c62
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3547558
Reviewed-by: Dana Fried <[email protected]>
Commit-Queue: Thomas Lukaszewicz <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#985128}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3554873
Cr-Commit-Position: refs/branch-heads/4951@{#191}
Cr-Branched-From: 27de6227ca357da0d57ae2c7b18da170c4651438-refs/heads/main@{#982481}
Replace receiver-data map with mutable context in AttributionDataHostManagerImpl
Instead of managing the lifetime of receiver data in a separate map, we
merge the ReceiverData struct into FrozenContext, avoiding the need for
disconnect handlers or a non-default destructor for the data host
manager itself. We record metrics when each FrozenContext is destroyed,
which implicitly occurs when the corresponding receiver is disconnected.
We also remove the duplicate emplace call in SourceDataAvailable, and
immediately return from that method and TriggerDataAvailable if the
relevant origins are not potentially trustworthy.
(cherry picked from commit 3a066c2d2359e701402ecd39c1f6d71dd2d0a689)
Bug: 1308756
Change-Id: I78a145ddb71420d5a9a4f398533f5931cb676df4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3540481
Reviewed-by: Nan Lin <[email protected]>
Commit-Queue: Andrew Paseltiner <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#983398}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3551959
Auto-Submit: Andrew Paseltiner <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/4951@{#190}
Cr-Branched-From: 27de6227ca357da0d57ae2c7b18da170c4651438-refs/heads/main@{#982481}
[Preconnect] Cherrypick two metrics addition CLs
This CL cherrypicks two trunk CLs to 101 (the second was dependent on
the first). Both CLs cherrypicked cleanly.
First CL (cherrypick contained in PS1):
---------------------------------------
[Preconnect] Add metric for queueing time of preconnect callbacks
This metric will allow us to determine how much of the latency of
host resolution/proxy lookup is due to the completion callbacks being
queued (which can be impacted by prioritization when scheduling these
tasks).
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3528675
Second CL (cherrypick contained in diff between PS1 and PS5):
----------------------------------------
[Preconnect] Add metrics related to PreresolveJob queueing
This CL adds metrics to help us gain insight into PreconnectManager's
queueing of requested preresolve jobs:
- The amount of time that a PreresolveJob spends queued
- The length of the queue at the time that PreconnectManager processes
it
These metrics will help us gain insight into whether and how to
experiment with changing PreconnectManager's logic for when to stop
processing jobs from the queue in a given iteration.
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3528742
Bug: 1257582
Change-Id: Ideb0c559ff698d4c3d52d841c36a3b2db7451ead
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3555967
Commit-Queue: Colin Blundell <[email protected]>
Auto-Submit: Colin Blundell <[email protected]>
Reviewed-by: Prudhvikumar Bommana <[email protected]>
Commit-Queue: Prudhvikumar Bommana <[email protected]>
Owners-Override: Prudhvikumar Bommana <[email protected]>
Reviewed-by: Tarun Bansal <[email protected]>
Cr-Commit-Position: refs/branch-heads/4951@{#189}
Cr-Branched-From: 27de6227ca357da0d57ae2c7b18da170c4651438-refs/heads/main@{#982481}
M101: Remove ash-chrome special handling in BrowserView::CanAcrivate
> The special handing calls ActivateAppModalDialog synchrounously
> which causes infinite recursion. On other platform, the problem is
> fixed by posting a task to call ActivateAppModalDialog and ChromeOS
> should follow.
>
> The ChromeOS special handing fixes a crash when creating js
> modal dialog under an active lock screen (http://crbug/226141).
> This crash no longer happens, with or without the synchronous call.
>
> Bug: 1287282
> Change-Id: I6b4ac46e93e5c85336a37ae461a6e554847e5cc3
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3553683
> Reviewed-by: Scott Violet <[email protected]>
> Commit-Queue: Xiyuan Xia <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#985667}
(cherry picked from commit cb9b1232b7d732156b35fe28bfc79b467f4fa3a6)
Change-Id: I346420e9b6c8b5f62ccf0336285efb9301d42901
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3554874
Auto-Submit: Xiyuan Xia <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Reviewed-by: Scott Violet <[email protected]>
Commit-Queue: Scott Violet <[email protected]>
Cr-Commit-Position: refs/branch-heads/4951@{#188}
Cr-Branched-From: 27de6227ca357da0d57ae2c7b18da170c4651438-refs/heads/main@{#982481}
M101: lacros: Fix UAF in select file dialog code
The base class of SelectFileDialogLacros has a `listener_` raw pointer.
That pointer must be reset to null in ListenerDestroyed().
I forgot to reset it in the initial stub version of this code, and the
defect has persisted since then:
https://chromium-review.googlesource.com/c/chromium/src/+/2240409
(cherry picked from commit 3ce7fed99d16e9ec5514e794a57a9a371f623d75)
Bug: 1306768
Test: manual, see repro steps in bug
Change-Id: I65bc7f6e56812587154fd170699037b35698ee25
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3547132
Reviewed-by: Erik Chen <[email protected]>
Commit-Queue: James Cook <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#984588}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3553030
Auto-Submit: James Cook <[email protected]>
Owners-Override: Prudhvikumar Bommana <[email protected]>
Reviewed-by: Prudhvikumar Bommana <[email protected]>
Commit-Queue: Prudhvikumar Bommana <[email protected]>
Commit-Queue: Erik Chen <[email protected]>
Cr-Commit-Position: refs/branch-heads/4951@{#187}
Cr-Branched-From: 27de6227ca357da0d57ae2c7b18da170c4651438-refs/heads/main@{#982481}
[merge to 101] desks: Do not exit overview when removing active desk.
The bug is a DCHECK with desk templates, but the issue is that if there
are no windows snapped, removing the active desk would exit overview,
which isn't consistent with removing any other desk.
(cherry picked from commit c5b333ca66fc76d02b4cdf024ad77d556cdcd316)
Test: manual, ash_unittests TabletModeDesksTest.RemovingActiveDeskDoesNotExitOverview
Bug: 1309175
Change-Id: Ifcdb3e438304441e7722d0037c5f9a54e5a92d9e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3545900
Reviewed-by: Ahmed Fakhry <[email protected]>
Commit-Queue: Sammie Quon <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#985119}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3553682
Cr-Commit-Position: refs/branch-heads/4951@{#186}
Cr-Branched-From: 27de6227ca357da0d57ae2c7b18da170c4651438-refs/heads/main@{#982481}
[FedCM] Reject the requests if the API is disabled in about:flags
The origin trial framework allows the feature to be enabled at runtime
on a per-page basis regardless the configuration in about:flags.
This patch adds extra checks in the browser process to make sure that
we only proceed if the feature is not disabled explicitly.
This patch also fixes a crash when the flag is set to "disabled" on a
page with an origin trial token: if a token is found on a page, then
the runtime feature is enabled. i.e. the renderer will ask for a remote
|FederatedAuthRequest| which is actually not created due to the feature
being disabled in browser.
(cherry picked from commit d328cc272eba32e0a1016b00d906862789bd44d1)
Bug: 1310121
Change-Id: I54b501339820f65efd87f35a41e9ae8056199f33
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3552356
Reviewed-by: Ken Buchanan <[email protected]>
Commit-Queue: Yi Gu <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#985415}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3555152
Auto-Submit: Yi Gu <[email protected]>
Commit-Queue: Ken Buchanan <[email protected]>
Cr-Commit-Position: refs/branch-heads/4951@{#185}
Cr-Branched-From: 27de6227ca357da0d57ae2c7b18da170c4651438-refs/heads/main@{#982481}
Fix embedding origin for GetPermissionStatusForCurrentDocument.
This CL fetches correct embedding and requesting origins for
GetPermissionStatusForCurrentDocument().
(cherry picked from commit 1b3a330323184a5dd7b4478f2c9015722cdd6757)
Bug: 1309661
Change-Id: I1e39944bd4ff5e230da081935db60f7261aef67b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3548957
Reviewed-by: Balazs Engedy <[email protected]>
Commit-Queue: Illia Klimov <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#984897}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3555672
Cr-Commit-Position: refs/branch-heads/4951@{#184}
Cr-Branched-From: 27de6227ca357da0d57ae2c7b18da170c4651438-refs/heads/main@{#982481}
[merge-101] Add new experiment configuration for Attribution Reporting
This CL introduces a new RTE trial feature which enabled Attribution
Reporting, Fledge, and Topics.
With this change multiple RTE features will use the same OT trial name,
however we want to ensure they can still be individually enabled/
disabled via feature specific base::Features. We add new logic to
further restrict what features can be registered from a given trial
name for this reason.
In order for the pre-existing Fledge and Topics RTEF to work
correctly with the origin trial infrastructure, we remove their
base::Features mappings, and introduce a new base::Feature
PrivacySandboxAdStackOverride which allows force enabling via flags.
A separate override about:flag is enabled which overrides the RTE
features and ensures that privacy sandbox settings are skipped to
allow for local testing with the new experiment configuration
(which would otherwise not be possible).
Note: With this new experiment config, Attribution Reporting will
no longer be using a user subset exclusion origin trial, so
corresponding tests are removed.
(cherry picked from commit 1d6e4b5c91adb7417f80626a9c87cd15c312d28b)
Bug: 1309791
Change-Id: I00dfde8c6154accfbc88d96dfffdcba702edca83
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3527133
Reviewed-by: Josh Karlin <[email protected]>
Reviewed-by: Jeremy Roman <[email protected]>
Reviewed-by: Russ Hamilton <[email protected]>
Reviewed-by: Michael Thiessen <[email protected]>
Reviewed-by: Paul Jensen <[email protected]>
Reviewed-by: Theodore Olsauskas-Warren <[email protected]>
Reviewed-by: Andrew Paseltiner <[email protected]>
Reviewed-by: Yao Xiao <[email protected]>
Reviewed-by: Ian Clelland <[email protected]>
Reviewed-by: Dominic Farolino <[email protected]>
Reviewed-by: Avi Drissman <[email protected]>
Commit-Queue: John Delaney <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#985142}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3554848
Owners-Override: Prudhvikumar Bommana <[email protected]>
Cr-Commit-Position: refs/branch-heads/4951@{#183}
Cr-Branched-From: 27de6227ca357da0d57ae2c7b18da170c4651438-refs/heads/main@{#982481}
Fix crash with JAWS screen reader
This CL prevents dereferencing a
WeakPtr<autofill::AutofillPopupControllerImpl> which may have been
invalidated already when JAWS tries to determine the role of a view.
(cherry picked from commit ce3a842550ce1f0ea2c37d95cee5ff996e6054e8)
Fixed: 1308182
Change-Id: I694076f70bf7de702ac11194fae04f349c545952
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3553114
Commit-Queue: Dominic Battré <[email protected]>
Auto-Submit: Dominic Battré <[email protected]>
Reviewed-by: Mohamed Amir Yosef <[email protected]>
Commit-Queue: Mohamed Amir Yosef <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#985706}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3551612
Cr-Commit-Position: refs/branch-heads/4951@{#182}
Cr-Branched-From: 27de6227ca357da0d57ae2c7b18da170c4651438-refs/heads/main@{#982481}
[Merge 101] Privacy Sandbox: Adjust confirmation dialog logic
CL introduces the option for no notice or consent to be shown to the
user, but to still receive the Privacy Sandbox release 3 updated
settings.
The default value of the Privacy Sandbox V2 preference is set based on
a combination of finch parameters and local state, such that users
which will eventually require consent have the user facing control off,
while users who will eventually require notice have the user facing
control on.
Privacy Sandbox APIs cannot run if the user has not confirmed them,
either through the notice / consent, or by manually controlling them on
the updated settings page.
If a user manually controls the Privacy Sandbox toggle, any future
notice or consent will be suppressed.
(cherry picked from commit 610624d521b9afd0e27be6ed16f1460bd71668c4)
Bug: 1309805
Change-Id: Ib17882d6fdc1bd6cb76e28308d4814cecf0bb86c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3546056
Reviewed-by: Christian Dullweber <[email protected]>
Reviewed-by: Matt Menke <[email protected]>
Reviewed-by: Yao Xiao <[email protected]>
Commit-Queue: Theodore Olsauskas-Warren <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#985217}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3552066
Reviewed-by: Sean Harrison <[email protected]>
Cr-Commit-Position: refs/branch-heads/4951@{#181}
Cr-Branched-From: 27de6227ca357da0d57ae2c7b18da170c4651438-refs/heads/main@{#982481}
Rebaseline texImage-imageBitmap-from-blob-resize
The test has been failing on Mac10.14 since
https://chromium-review.googlesource.com/c/chromium/src/+/3507539.
(cherry picked from commit 572f3f5a91a4c75bc2f76c2a8d9762de2428e930)
Bug: 1307882
Change-Id: I496141f3f7e6f6330ab255cb3922c3e2e4d81455
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3543385
Reviewed-by: Robert Phillips <[email protected]>
Commit-Queue: Florin Malita <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#983964}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3553313
Cr-Commit-Position: refs/branch-heads/4951@{#180}
Cr-Branched-From: 27de6227ca357da0d57ae2c7b18da170c4651438-refs/heads/main@{#982481}
Revise same-process throttling to match OOPIF throttling.
This CL relaxes the throttling conditions used when enabling feature
ThrottleDisplayNoneAndVisibilityHiddenCrossOriginIframesEnabled to match
the throttling used for out-of-process iframes (OOPIFs). The current
throttling, introduced in
https://chromium-review.googlesource.com/c/chromium/src/+/2809446,
attempts to always throttle zero-area iframes, which is a worthwhile
goal but isn't strictly necessary to align same-process and cross-procss
iframe throttling behaviour, and throttling zero-area frames breaks
some sites.
The throttling of zero-area iframes can be attempted in a later CL,
after appropriate outreach has occurred, but for now it is important
to get same-process and cross-process to exhibit the same behaviour.
(cherry picked from commit 86b04de5c1ea45f975270fe019d71bd2baee8bf9)
Bug: 958475
Change-Id: Idda7d9d1428a32002f9655a055baa5dad42e5d8b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3546438
Reviewed-by: David Bokan <[email protected]>
Commit-Queue: James Maclean <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#985300}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3553930
Commit-Queue: Prudhvikumar Bommana <[email protected]>
Cr-Commit-Position: refs/branch-heads/4951@{#179}
Cr-Branched-From: 27de6227ca357da0d57ae2c7b18da170c4651438-refs/heads/main@{#982481}
Give newly appended anchor time to render before clicking it in attribution browser test
Sleeping before clicking on it eliminates all flakes locally.
We also use a more robust mechanism for identifying the link's position
on the screen.
(cherry picked from commit b166cfc5ac5c217f992d49ff76d648d0e4c06731)
Bug: 1309403
Change-Id: I1937d91de04cf9337c77f4b2ed32f2e5abbb3b2a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3550466
Reviewed-by: Nan Lin <[email protected]>
Commit-Queue: Andrew Paseltiner <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#985268}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3552383
Auto-Submit: Andrew Paseltiner <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/4951@{#178}
Cr-Branched-From: 27de6227ca357da0d57ae2c7b18da170c4651438-refs/heads/main@{#982481}
mac: Download both intel and arm64 httpd in DEPS and pick right one at runtime
(cherry picked from commit 5a0046ead00a6516872538737cc060e8eee162a6)
Bug: 1190885
Change-Id: I8f1f50a512514274c6362dfda38829b738cb257a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3546600
Reviewed-by: David Benjamin <[email protected]>
Commit-Queue: Nico Weber <[email protected]>
Reviewed-by: Weizhong Xia <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#984517}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3553392
Auto-Submit: Nico Weber <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/4951@{#177}
Cr-Branched-From: 27de6227ca357da0d57ae2c7b18da170c4651438-refs/heads/main@{#982481}
Updating XTBs based on .GRDs from branch 4951
Change-Id: Ib613c564606aed1e76bc1610f3b8ca55707c0358
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3555251
Auto-Submit: Ben Mason <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/4951@{#176}
Cr-Branched-From: 27de6227ca357da0d57ae2c7b18da170c4651438-refs/heads/main@{#982481}
Remove test-only path for overriding bound receiver in AttributionHost
Instead, we override the user data containing the AttributionHost in the
tests themselves with the MockAttributionHost subclass, and allow the
attribution manager provider to be overridden by a test peer.
This prevents there from being multiple live AttributionHosts in the
tests, which was a potential source of confusion for debugging, as
evidenced by the "expected" histogram count of 2 in
AttributionHostTest.ImpressionNavigationWithDeadInitiator_Ignored rather
than 1.
The AttributionHost instance created in the test fixture in
attribution_host_unittest.cc was unnecessary even without the other
changes in this CL, as it already associates itself with the proper
WebContents, so there's no need to override the receiver.
(cherry picked from commit c926c24c4aa9f474525b60f7d65c4ded0f969c48)
Bug: 1310023
Change-Id: I2ef0e5286c077b22b60b4c1457d562dc592bb154
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3550616
Reviewed-by: Nan Lin <[email protected]>
Commit-Queue: Andrew Paseltiner <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#985281}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3555349
Auto-Submit: Andrew Paseltiner <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/4951@{#175}
Cr-Branched-From: 27de6227ca357da0d57ae2c7b18da170c4651438-refs/heads/main@{#982481}
[privacy sandbox settings] Restore focus after closing dialog
After closing any dialog from privacy sandbox settings page, focus the
element that triggered opening the dialog. For "Interested removed"
dialog return focus to "Ad personalization" row because it triggers
"Ad personalization" dialog from which "Interested removed" is opened.
(cherry picked from commit a7a25257703a763802a7cdcfbeb8e0aaa3156f10)
Bug: 1309915
Change-Id: I7017bea1bffa26f82581f2c7a76ac41815ce8ea4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3548881
Reviewed-by: Theodore Olsauskas-Warren <[email protected]>
Commit-Queue: Olesia Marukhno <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#984878}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3554066
Auto-Submit: Olesia Marukhno <[email protected]>
Commit-Queue: Theodore Olsauskas-Warren <[email protected]>
Cr-Commit-Position: refs/branch-heads/4951@{#174}
Cr-Branched-From: 27de6227ca357da0d57ae2c7b18da170c4651438-refs/heads/main@{#982481}
[Merge 101][iOS] Fix FRE
The association was done in a DCHECK. As the DCHECK is removed in
Official build, the association was no longer done.
Move the association out of the DCHECK to make sure that it is
happening on Official builds.
(cherry picked from commit a55b26f6fb39fa5dbe3f87ce928631b9156b94f6)
Bug: 1307714
Change-Id: Ie0a6a23bd5f720662d5e271a0889ccfcf46401c4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3545210
Reviewed-by: Olivier Robin <[email protected]>
Reviewed-by: Vincent Boisselle <[email protected]>
Commit-Queue: Gauthier Ambard <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#984453}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3547096
Auto-Submit: Vincent Boisselle <[email protected]>
Reviewed-by: Gauthier Ambard <[email protected]>
Commit-Queue: Vincent Boisselle <[email protected]>
Cr-Commit-Position: refs/branch-heads/4951@{#173}
Cr-Branched-From: 27de6227ca357da0d57ae2c7b18da170c4651438-refs/heads/main@{#982481}
[Android] Restore tracking Android.TabNavigationInterceptResult metric
This metric tracks the outcomes of checks for whether a navigation
should result in an external intent. It expired in M81 and was
subsequently removed. However, it would still be useful, e.g., for
tracking intent launching behavior across different arms of experiments.
This CL restores the tracking of the metric, essentially reverting
https://chromium-review.googlesource.com/c/chromium/src/+/2158828 and
then accounting for the cosmetic changes in the codebase that have
occurred since that CL. We additionally split the metric into variants
for internal and external protocols.
(cherry picked from commit 90477df54e7b99bb377e3fbcab75f2437fdf5deb)
Change-Id: Ie99e890876aa7d41048fe63b5ed0c9ee7c353357
Bug: 1307848
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3548237
Reviewed-by: Michael Thiessen <[email protected]>
Commit-Queue: Colin Blundell <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#985355}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3553008
Auto-Submit: Colin Blundell <[email protected]>
Commit-Queue: Michael Thiessen <[email protected]>
Cr-Commit-Position: refs/branch-heads/4951@{#172}
Cr-Branched-From: 27de6227ca357da0d57ae2c7b18da170c4651438-refs/heads/main@{#982481}
[Merge to M101] [Topics] Implement BrowsingTopicsCalculator
- Implement BrowsingTopicsCalculator. It’s responsible for doing a
one-off browsing topics calculation. The calculation will occur every 7
days. See the class comment for details.
- Rename “top_host” to “main_frame_host” to be more clear. This is fine
with database schema as well, as currently there’s no way to initialize
the database tables (even with feature flags).
- Let PageContentAnnotationsService::BatchAnnotatePageTopics accept the
hosts instead of GURL.
- Move GetModelInfoForType() to the PageContentAnnotator interface, so
that the model version can be mocked in tests as well.
Explainer: https://github.com/jkarlin/topics
Design doc:
https://docs.google.com/document/d/12UEo6PgeySUgEpkaAoawPjhjR0GSz-XhSOXSmrMxV6U
PoC CL:
https://chromium-review.googlesource.com/c/chromium/src/+/3416117
(cherry picked from commit c95d315240703c193578fc6a1c4441da8bae5951)
Bug: 1294456
Change-Id: I13aba4d32a0e3377295f926a5ddb2168417d8c4c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3511510
Reviewed-by: Josh Karlin <[email protected]>
Reviewed-by: Robert Ogden <[email protected]>
Reviewed-by: Avi Drissman <[email protected]>
Reviewed-by: Daniel Cheng <[email protected]>
Reviewed-by: Mark Pearson <[email protected]>
Reviewed-by: Sophie Chang <[email protected]>
Reviewed-by: Christian Dullweber <[email protected]>
Reviewed-by: Gabriel Charette <[email protected]>
Commit-Queue: Yao Xiao <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#982586}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3553239
Bot-Commit: Rubber Stamper <[email protected]>
Auto-Submit: Yao Xiao <[email protected]>
Reviewed-by: Balazs Engedy <[email protected]>
Commit-Queue: Balazs Engedy <[email protected]>
Cr-Commit-Position: refs/branch-heads/4951@{#171}
Cr-Branched-From: 27de6227ca357da0d57ae2c7b18da170c4651438-refs/heads/main@{#982481}
MediaDevices: Prevent iterator invalidation during Promise resolution
(cherry picked from commit 8699f6f278147fca3809e6fed8246ea48fca4ec1)
Bug: 1307302
Change-Id: I8ca37614b9cbe2ff90b5743a1879911e8b2b40f3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3532561
Reviewed-by: Elad Alon <[email protected]>
Commit-Queue: Adrian Taylor <[email protected]>
Commit-Queue: Elad Alon <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#985079}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3550288
Auto-Submit: Elad Alon <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/4951@{#170}
Cr-Branched-From: 27de6227ca357da0d57ae2c7b18da170c4651438-refs/heads/main@{#982481}
Merge M101: Enable the WebRTC extension of the MediaCapabilities API
The WebRTC extension of the MediaCapabilities API was just approved
for launch:
- Chrome status
https://chromestatus.com/feature/6242376685191168
- Intent to Ship
https://groups.google.com/a/chromium.org/g/blink-dev/c/loWlekYWswQ/m/VMOq0eBFDgAJ
This CL enables the API.
(cherry picked from commit 12cd7e8fd6351ef966832d307bee7937e651602a)
Bug: chromium:1187565
Change-Id: I39df0f341fb36cc2f141b7254f463a4a0d42e49b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3528423
Auto-Submit: Johannes Kron <[email protected]>
Reviewed-by: Yoav Weiss <[email protected]>
Commit-Queue: Johannes Kron <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#982774}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3550582
Commit-Queue: Yoav Weiss <[email protected]>
Cr-Commit-Position: refs/branch-heads/4951@{#169}
Cr-Branched-From: 27de6227ca357da0d57ae2c7b18da170c4651438-refs/heads/main@{#982481}
[Merge 101] Privacy Sandbox Settings: Fix android subheading style
(cherry picked from commit 2ad053f103f827c026a9fdb1e060139c0ffa82c5)
Bug: 1310233
Change-Id: Iad1e3792897e132084c9feb5c3ac4321ab1b385c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3550962
Reviewed-by: Theodore Olsauskas-Warren <[email protected]>
Commit-Queue: Christian Dullweber <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#985451}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3554227
Auto-Submit: Theodore Olsauskas-Warren <[email protected]>
Reviewed-by: Olesia Marukhno <[email protected]>
Commit-Queue: Olesia Marukhno <[email protected]>
Cr-Commit-Position: refs/branch-heads/4951@{#168}
Cr-Branched-From: 27de6227ca357da0d57ae2c7b18da170c4651438-refs/heads/main@{#982481}
Privacy Sandbox Settings: Show trials_on string when a topic is blocked
(cherry picked from commit a5cc3f38ad05244529e614e6379a366dacaf1d0f)
Bug: 1309942
Change-Id: I52f9427ca8b2e4b3fd3be72f9453a11385445a0c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3548920
Auto-Submit: Christian Dullweber <[email protected]>
Reviewed-by: Ehimare Okoyomon <[email protected]>
Reviewed-by: Theodore Olsauskas-Warren <[email protected]>
Commit-Queue: Theodore Olsauskas-Warren <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#985191}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3552067
Auto-Submit: Theodore Olsauskas-Warren <[email protected]>
Reviewed-by: Olesia Marukhno <[email protected]>
Commit-Queue: Olesia Marukhno <[email protected]>
Cr-Commit-Position: refs/branch-heads/4951@{#167}
Cr-Branched-From: 27de6227ca357da0d57ae2c7b18da170c4651438-refs/heads/main@{#982481}
[Merge 101] Privacy Sandbox Settings: Prevent nav until prefs loaded
When navigating to the Ad Personalization subpage directly prefs are
checked before they are loaded to determine the value of strings on the
page.
This CL moves the check for whether a subpage navigation should occur
until after the prefs are reported as initialized.
(cherry picked from commit 59d422e72bb60304454755ad5c116f148a089c5f)
Bug: 1309873
Change-Id: Id406da34450b852c9a0d20ad13b6074e98dd70f8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3545741
Auto-Submit: Theodore Olsauskas-Warren <[email protected]>
Reviewed-by: Ehimare Okoyomon <[email protected]>
Commit-Queue: Ehimare Okoyomon <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#984879}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3552023
Commit-Queue: Theodore Olsauskas-Warren <[email protected]>
Reviewed-by: Olesia Marukhno <[email protected]>
Commit-Queue: Olesia Marukhno <[email protected]>
Cr-Commit-Position: refs/branch-heads/4951@{#166}
Cr-Branched-From: 27de6227ca357da0d57ae2c7b18da170c4651438-refs/heads/main@{#982481}
[Messages] Guard against popup blocked message being shown before init
//chrome-level initialization of the messages infrastructure happens in
RootUiCoordinator#onFinishNativeInitialization(). The execution of this
method is not ordered with respect to the initial navigation, and if
that initial navigation occurs quickly enough, it can result in messages
being shown before the initialization has occurred. One such case is for
a blocked popup. When the blocked popup message is asked to show itself
in this case, a crash results as it calls into
MessageDispatcherBridge::MapToJavaDrawableId() before the
//chrome-level call to MessageDispatcherBridge::Initialize() has set
the ResourceMapper callback.
This CL fixes the crash by having ChromePopupNavigationDelegate check
for this case and short-circuit out of showing the message as
necessary.
Other potential ways to fix this issue that I considered:
- Make PopupNavigationMessageDelegate resilient to being asked to show
itself in this case. This is doable, but seems odd (from the
component's POV, why would an embedder ask the message to show itself if
messages aren't supported in the embedder?)
- Make MessageDispatcherBridge resilient to this case. AFAICT this is
not possible, as there is no safe sentinel value to return from
MapToJavaDrawableId().
- Fix the startup ordering issue. This would be ideal, but is out of the
scope of this fix and seems tricky given
https://chromium-review.googlesource.com/c/chromium/src/+/2476616.
Finally, I noted that there are two other production callers of
MessageDispatcherBridge::MapToJavaDrawableId:
- AdsBlockedMessageDelegate is already only shown in the case where
MessageDispatcherBridge::IsMessagesEnabledForEmbedder() is true.
- In a separate CL, ArCoreInstallHelper could have a similar change to
the one in this CL made if that is deemed necessary (I don't know
exactly what flows cause the message there to be shown).
(cherry picked from commit 2ace5cafe2e29d6118338114b431bb62ab74cc0f)
Bug: 1308214
Change-Id: I3aad67a38962cebf1d14305b63e93423b102c3da
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3541981
Reviewed-by: Theresa Sullivan <[email protected]>
Commit-Queue: Colin Blundell <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#984352}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3552645
Cr-Commit-Position: refs/branch-heads/4951@{#165}
Cr-Branched-From: 27de6227ca357da0d57ae2c7b18da170c4651438-refs/heads/main@{#982481}
[lacros skew tests] Refresh skew tests for M102
This CL updates the ash version ['102.0.4968.0'] for Lacros version skew testing.
If this CL caused regressions, please revert and stop the autoroller
at https://luci-scheduler.appspot.com/jobs/chrome/lacros-version-skew-roller
Also please file a bug to OS>LaCrOS>Partner, and CC [email protected],
[email protected], [email protected].
[email protected]
Bug: None
Change-Id: I7f1a882de8169fdb4337464e3e8be1ed39f6ce14
Requires-Testing: True
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3550535
Auto-Submit: chrome-weblayer-builder <chrome-weblayer-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/4951@{#164}
Cr-Branched-From: 27de6227ca357da0d57ae2c7b18da170c4651438-refs/heads/main@{#982481}
Incrementing VERSION to 101.0.4951.13
Change-Id: Ifffa286b9273d237b0eb37e8c149df8e826c9dc7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3555088
Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/4951@{#163}
Cr-Branched-From: 27de6227ca357da0d57ae2c7b18da170c4651438-refs/heads/main@{#982481}
Extend expiration date of force-control-face-ae flag
(cherry picked from commit 5cc3b427c9ff3832e94d9d465628489bc11ab446)
Bug: b/226533540
Test: trybot
Change-Id: Id8b7fedd90c35c5e76b5400185ba2346dbf36a0a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3534767
Reviewed-by: Ricky Liang <[email protected]>
Commit-Queue: Hsu Wei-Cheng <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#982622}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3552017
Cr-Commit-Position: refs/branch-heads/4951@{#162}
Cr-Branched-From: 27de6227ca357da0d57ae2c7b18da170c4651438-refs/heads/main@{#982481}
[attribution_reporting] Notify observer for reports with
`kTransientFailure` status but reached retry limit
Reports that failed but reached retry limit won't be retried and will be
deleted from the storage. Displaying them in the internal UI will make
debugging easier.
(cherry picked from commit 65734ce3c2dbe47ec9df3a53a37221f1c467bcab)
Bug: 1310226
Change-Id: I7213399aec3ff3c6bd792bad1c147dc9078157f5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3552258
Reviewed-by: Andrew Paseltiner <[email protected]>
Commit-Queue: Nan Lin <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#985295}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3552595
Auto-Submit: Nan Lin <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/4951@{#161}
Cr-Branched-From: 27de6227ca357da0d57ae2c7b18da170c4651438-refs/heads/main@{#982481}
[lacros skew tests] Refresh skew tests for M102
This CL updates the ash version ['102.0.4966.0'] for Lacros version skew testing.
If this CL caused regressions, please revert and stop the autoroller
at https://luci-scheduler.appspot.com/jobs/chrome/lacros-version-skew-roller
Also please file a bug to OS>LaCrOS>Partner, and CC [email protected],
[email protected], [email protected].
[email protected]
Bug: None
Change-Id: I8900742c427d67681d0aed3610a7ba746f715d41
Requires-Testing: True
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3550528
Auto-Submit: chrome-weblayer-builder <chrome-weblayer-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/4951@{#160}
Cr-Branched-From: 27de6227ca357da0d57ae2c7b18da170c4651438-refs/heads/main@{#982481}
Privacy Sandbox Settings: Ad personalization tooltips + back button a11y
Make tooltips and back button screen readable. Add button role for tooltips and an aria label for both so that the screen reader can convey the contents of the tooltip popup and the back button.
(cherry picked from commit 6af00b7189eb33c1a2ad8fa2017ebe6c35302185)
Bug: 1309946
Change-Id: I4aca503cddd4cb02679f5e9333fa84835940a429
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3549378
Auto-Submit: Ehimare Okoyomon <[email protected]>
Reviewed-by: Theodore Olsauskas-Warren <[email protected]>
Commit-Queue: Theodore Olsauskas-Warren <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#985190}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3552503
Commit-Queue: Ehimare Okoyomon <[email protected]>
Cr-Commit-Position: refs/branch-heads/4951@{#159}
Cr-Branched-From: 27de6227ca357da0d57ae2c7b18da170c4651438-refs/heads/main@{#982481}
Incrementing VERSION to 101.0.4951.12
Change-Id: I2656c8151d6a621a8cae233ea0217e22c908e5f1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3554746
Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/4951@{#158}
Cr-Branched-From: 27de6227ca357da0d57ae2c7b18da170c4651438-refs/heads/main@{#982481}
Reland "mac: Make dump_syms (and symupload) buildable for target"
This is a reland of commit dc9d7321306a08ca36638abeeaa9f5bb7be2e98c
In the reland, update build files that call dump_syms to call the
host version of the binary (see diff from patch set 1).
Tweak build/redirect_stdout.py to use the same './' prefixing
that build/gn_run_binary.py (used by compiled_action.gni) does.
Original change's description:
> mac: Make dump_syms (and symupload) buildable for target
>
> content_shell_crash_test wants to run dump_syms at test time, and
> when running tests on arm64 but cross building arm64 on an intel
> host, we'd previously always build an intel dump_syms, which then
> couldn't run on the testers.
>
> Bug: 1309474
> Change-Id: I8e91cb572a4b73e11b263f9d1e74a361c755c8d5
> Cq-Include-Trybots: luci.chromium.try:mac11-arm64-rel
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3547176
> Auto-Submit: Nico Weber <[email protected]>
> Reviewed-by: Mark Mentovai <[email protected]>
> Commit-Queue: Nico Weber <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#984513}
(cherry picked from commit f63161904212bdc4f0ec274f06ffef9fb723d7e1)
Bug: 1309474
Change-Id: I741f5283d37ba0c80cfec539815a4304eb5729f8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3547018
Reviewed-by: Mark Mentovai <[email protected]>
Auto-Submit: Nico Weber <[email protected]>
Commit-Queue: Nico Weber <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#984846}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3552591
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/4951@{#157}
Cr-Branched-From: 27de6227ca357da0d57ae2c7b18da170c4651438-refs/heads/main@{#982481}
mac: Make minidump_stackwalk buildable for target arch
(cherry picked from commit cc95c82b3a614ac4d121133d7df0d113cc2308ba)
Bug: 1309489
Change-Id: I1b544eef79bbd6fc9fda9eee6d64ebb261b64efb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3546460
Auto-Submit: Nico Weber <[email protected]>
Reviewed-by: Mark Mentovai <[email protected]>
Commit-Queue: Nico Weber <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#984515}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3553391
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/4951@{#156}
Cr-Branched-From: 27de6227ca357da0d57ae2c7b18da170c4651438-refs/heads/main@{#982481}
Updating XTBs based on .GRDs from branch 4951
Change-Id: Id574878ba7567402473f92dde3a86a59f0a48a75
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3553389
Auto-Submit: Ben Mason <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/4951@{#155}
Cr-Branched-From: 27de6227ca357da0d57ae2c7b18da170c4651438-refs/heads/main@{#982481}
Accelerators: Add support for new KEY_ALL_APPLICATIONS
- On Chrome OS will just open the launcher
- New ID's
- USB: 0x0c - 0x02A2
- KEY_ALL_APPLICATIONS: 0xCC
- KEY_ALL_APPLICATIONS is an alias of KEY_DASHBOARD
BUG=b/191272840
TEST=unittests
(cherry picked from commit 07b908ce09b5190577792b17146879160b0e2ab2)
Change-Id: I5f8e173e727a1cf383ac705350d7c277feb2a4cc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3428492
Reviewed-by: Sean O'Brien <[email protected]>
Reviewed-by: Sam McNally <[email protected]>
Auto-Submit: Zentaro Kavanagh <[email protected]>
Reviewed-by: Scott Violet <[email protected]>
Commit-Queue: Zentaro Kavanagh <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#983333}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3553437
Commit-Queue: Sam McNally <[email protected]>
Cr-Commit-Position: refs/branch-heads/4951@{#154}
Cr-Branched-From: 27de6227ca357da0d57ae2c7b18da170c4651438-refs/heads/main@{#982481}
[lacros skew tests] Refresh skew tests for M102
This CL updates the ash version ['102.0.4964.0'] for Lacros version skew testing.
If this CL caused regressions, please revert and stop the autoroller
at https://luci-scheduler.appspot.com/jobs/chrome/lacros-version-skew-roller
Also please file a bug to OS>LaCrOS>Partner, and CC [email protected],
[email protected], [email protected].
[email protected]
Bug: None
Change-Id: I3d92d22ab4bc808053f24dc7d02258046c87ee4c
Requires-Testing: True
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3553145
Auto-Submit: chrome-weblayer-builder <chrome-weblayer-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/4951@{#153}
Cr-Branched-From: 27de6227ca357da0d57ae2c7b18da170c4651438-refs/heads/main@{#982481}
Incrementing VERSION to 101.0.4951.11
Change-Id: I224be52433b167d241d3d1e9f4629e7b46e41376
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3552585
Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/4951@{#152}
Cr-Branched-From: 27de6227ca357da0d57ae2c7b18da170c4651438-refs/heads/main@{#982481}
[Extensions] Revert change to webRequest events custom bindings.
This CL reverts a change in crrev.com/7f01af56213bde29bbc84dd747bdc7c9c973817f
that broke the webRequest API in extensions.
(cherry picked from commit d03093ee7239d058da62bdfd5526454575b226be)
Bug: 1309302
Change-Id: I45982aa24c9fc8006ee7e3db2a70c5e3ccaefcfe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3553231
Reviewed-by: Tim <[email protected]>
Commit-Queue: David Bertoni <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#985498}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3551632
Cr-Commit-Position: refs/branch-heads/4951@{#151}
Cr-Branched-From: 27de6227ca357da0d57ae2c7b18da170c4651438-refs/heads/main@{#982481}
Merge M101: Let power efficient imply that smooth is true
Update the logic for the WebRTC implementation of MediaCapabilities
API so that powerEfficient=true implies that smooth=true.
This update is based on tests that show that the encode and decode
time measurements are not reliable for the case of hardware encoder/
decoders. Implying that smooth=true from powerEfficient=true is
a reasonable assumption.
The new behavior can be overridden through field trials parameters.
(cherry picked from commit dfcf84e07376e7991803e0fc8c448360bfcc647d)
Bug: chromium:1306967
Change-Id: I6072192340be7a335447eda650e58e8617ab167c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3529212
Reviewed-by: Will Cassella <[email protected]>
Commit-Queue: Johannes Kron <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#984216}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3552646
Auto-Submit: Johannes Kron <[email protected]>
Commit-Queue: Will Cassella <[email protected]>
Cr-Commit-Position: refs/branch-heads/4951@{#150}
Cr-Branched-From: 27de6227ca357da0d57ae2c7b18da170c4651438-refs/heads/main@{#982481}
[TTS][RSearches] Fix handling Definition Cards
Definition cards are handled in a special way because they have a
multipart display. In order to accommodate this we use the "Resolving"
layout because it can show two parts. However that was not done in
a clean way, which causes trouble for Related Searches, and is
error prone.
The animation that's done during the transition of an expanded panel
that shows an RS back the the default query when collapsing the panel
has been changed. The code was doing the transition when the panel
is fully collapsed, but the animation is better when it's done part
of the way through the transition. Changing "Collapsed" methods to
"Collapsing" for this.
Low coverage will be handled in a follow-on patch.
BUG=1244107,1244110
(cherry picked from commit 351d363e43e8d3f1fc39b311177d3bf434e69c1c)
Change-Id: I4cf027a4a81cc259e088e55f30c5ec4052fb5a8d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3533029
Reviewed-by: Gang Wu <[email protected]>
Commit-Queue: Donn Denman <[email protected]>
Auto-Submit: Donn Denman <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#984486}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3553645
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/4951@{#149}
Cr-Branched-From: 27de6227ca357da0d57ae2c7b18da170c4651438-refs/heads/main@{#982481}
[ios] Assign the correct ContentSuggestionsViewController for sharing
(cherry picked from commit 8a62a7a5d74c238a9793943a910528423fc88aeb)
Bug: 1309184
Change-Id: Iab585d698f4f528e0452b58f9b675df3efdc983a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3549681
Commit-Queue: Chris Lu <[email protected]>
Auto-Submit: Chris Lu <[email protected]>
Reviewed-by: Adam Arcaro <[email protected]>
Commit-Queue: Adam Arcaro <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#984928}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3553441
Cr-Commit-Position: refs/branch-heads/4951@{#148}
Cr-Branched-From: 27de6227ca357da0d57ae2c7b18da170c4651438-refs/heads/main@{#982481}
[attribution_reporting] Notify observer on aggregatable report stored
and dropped due to assembly failure
This caused the new report to be absent in the internals UI until a
manual refresh, and caused the report dropped due to assembly failure
to be absent.
(cherry picked from commit 6eb925582a36cdba74ad60f01a19897866a92cca)
Bug: 1309917
Change-Id: I6ebb910e5d7d49a7bb04e7562c7bda0c6eb457a1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3549996
Reviewed-by: Andrew Paseltiner <[email protected]>
Commit-Queue: Nan Lin <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#984947}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3553307
Auto-Submit: Nan Lin <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/4951@{#147}
Cr-Branched-From: 27de6227ca357da0d57ae2c7b18da170c4651438-refs/heads/main@{#982481}
[ios] Separate omnibox and feed offset logic
This change separates the minimum offset calculation and logic for
when the stick the omnibox to the top of the NTP and when the user has
scrolled into the feed (and therefore when to stick its header to the
top as well). This is important since the final state of the ongoing
NTP UIViewController migration will have the omnibox stick much earlier
than before, where the omnibox would stick just as the user was
scrolling into the feed.
(cherry picked from commit 39715a7108a8c0c47ca580f119e9e91235c7c08b)
Bug: 1308871
Change-Id: I5a652729b472c51022e8096271d44793f92a375b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3546710
Reviewed-by: Adam Arcaro <[email protected]>
Commit-Queue: Chris Lu <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#984913}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3552550
Auto-Submit: Chris Lu <[email protected]>
Commit-Queue: Adam Arcaro <[email protected]>
Cr-Commit-Position: refs/branch-heads/4951@{#146}
Cr-Branched-From: 27de6227ca357da0d57ae2c7b18da170c4651438-refs/heads/main@{#982481}
[Android notifications] Removed notification permission check from FGS
Notification permission request checks aren't required any more before
launching a FGS. This CL removes this check.
(cherry picked from commit b54a489b2621a0e6c15babee21663736ed97f08d)
Bug: 1293976
Change-Id: Id399b0a9416947c20404566fe78bbb175a922363
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3533519
Reviewed-by: Salvador Guerrero Ramos <[email protected]>
Auto-Submit: Shakti Sahu <[email protected]>
Reviewed-by: David Trainor <[email protected]>
Commit-Queue: Shakti Sahu <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#982566}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3546127
Cr-Commit-Position: refs/branch-heads/4951@{#145}
Cr-Branched-From: 27de6227ca357da0d57ae2c7b18da170c4651438-refs/heads/main@{#982481}
[Merge to M101] Make base::Time::FromDeltaSinceWindowsEpoch() constexpr.
Also make base::Time::ToDeltaSinceWindowsEpoch() for symmetry.
(cherry picked from commit ab117655a36582683917eaa9f00d3a75bf76c34c)
Change-Id: I40ff76bc27fbcea2207763573ac62c6d215a70c9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3544609
Reviewed-by: Peter Kasting <[email protected]>
Commit-Queue: Peter Kasting <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#984310}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3550772
Reviewed-by: Daniel Cheng <[email protected]>
Auto-Submit: Yao Xiao <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/4951@{#144}
Cr-Branched-From: 27de6227ca357da0d57ae2c7b18da170c4651438-refs/heads/main@{#982481}
Add a blocklist of hosts that should not appear in any cluster
The blocklist itself is behind a flag so this will basically be a no-op until that is configured
(cherry picked from commit 8c80d835c4bb220f893bbd6fd371f4f246accebe)
Bug: 1308850
Change-Id: I0d91557b2e6af0d5b12826508d9a3fe27fefc23f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3541022
Reviewed-by: Tarun Bansal <[email protected]>
Reviewed-by: Tommy Li <[email protected]>
Commit-Queue: Sophie Chang <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#983516}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3551295
Auto-Submit: Sophie Chang <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/4951@{#143}
Cr-Branched-From: 27de6227ca357da0d57ae2c7b18da170c4651438-refs/heads/main@{#982481}
[Extensions] Revert change to IdGenerator for webview events.
This CL reverts a change in crrev.com/7f01af56213bde29bbc84dd747bdc7c9c973817f
that broke the webRequest API in WebView.
(cherry picked from commit f3f022673309ce21ed4dc88743b8a2f742c24def)
Bug: 1309302
Change-Id: I06e62c2608109bad776ec2fc40aaa32ff7045efc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3543710
Reviewed-by: Devlin Cronin <[email protected]>
Commit-Queue: David Bertoni <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#984164}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3552541
Reviewed-by: Tim <[email protected]>
Cr-Commit-Position: refs/branch-heads/4951@{#142}
Cr-Branched-From: 27de6227ca357da0d57ae2c7b18da170c4651438-refs/heads/main@{#982481}
Generate a new token for PartitionedCookiesEnabledClientHintsTest
The token used by the test has now expired. This generates a fresh
token to make the tests pass for the time being.
(cherry picked from commit 3375004566fcc85b09c8ccc55bdace7ed8866407)
Bug: 1310113
Change-Id: I65b41031ba0cf7e6970b4c49de2ccd37404da7d7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3551261
Auto-Submit: Fabrice de Gans <[email protected]>
Reviewed-by: Trent Apted <[email protected]>
Commit-Queue: Trent Apted <[email protected]>
Owners-Override: Trent Apted <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#985186}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3551294
Reviewed-by: Fabrice de Gans <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Owners-Override: Srinivas Sista <[email protected]>
Commit-Queue: Fabrice de Gans <[email protected]>
Cr-Commit-Position: refs/branch-heads/4951@{#141}
Cr-Branched-From: 27de6227ca357da0d57ae2c7b18da170c4651438-refs/heads/main@{#982481}
Update Crashpad to 25e67e285c01b2b0c7d654dc2238176f0f1a56c3
4c85c466b00c ios: Fix test failure on M1 ARM64 machines
460dbdceaeb4 ios: Unblock all signals corresponding to Mach exceptions
on crash
243dffb04573 ios: Stop prune and upload thread when app is inactive and
may suspend
25e67e285c01 ios: Track last NSException in ObjcException preprocessor
(cherry picked from commit 12803e0fb37255f05c74b8f51a4441bdb18864be)
Change-Id: If360f268af8180c3706c35ede6c4ddde9638843d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3546087
Auto-Submit: Justin Cohen <[email protected]>
Reviewed-by: Robert Sesek <[email protected]>
Commit-Queue: Robert Sesek <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#984839}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3553199
Reviewed-by: Harry Souders <[email protected]>
Commit-Queue: Harry Souders <[email protected]>
Owners-Override: Harry Souders <[email protected]>
Cr-Commit-Position: refs/branch-heads/4951@{#140}
Cr-Branched-From: 27de6227ca357da0d57ae2c7b18da170c4651438-refs/heads/main@{#982481}
[CrOS Cellular] Extend attach apn flag expiration dates.
(cherry picked from commit 2c23299b1c60a92b10ac8d958c349f2a15f4b813)
Bug: b/226179791
Change-Id: I7d8e5f97151bd2cf4203e341349efd9f3b349a75
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3543377
Reviewed-by: Azeem Arshad <[email protected]>
Commit-Queue: Regan Hsu <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#984503}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3549457
Reviewed-by: Kyle Horimoto <[email protected]>
Cr-Commit-Position: refs/branch-heads/4951@{#139}
Cr-Branched-From: 27de6227ca357da0d57ae2c7b18da170c4651438-refs/heads/main@{#982481}
Extends lifetime of raw-audio-capture flag until M104
Change-Id: Ib82b26ce04a51fe159a0d24091efafd7e1d1437c
(cherry picked from commit ce42ef43342795c61bbc4fe1729b9635356afcd5)
Bug: 1133643,1277474
Change-Id: Ib82b26ce04a51fe159a0d24091efafd7e1d1437c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3545252
Reviewed-by: Ale Bzk <[email protected]>
Commit-Queue: Henrik Andreasson <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#984427}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3552556
Commit-Queue: Ale Bzk <[email protected]>
Cr-Commit-Position: refs/branch-heads/4951@{#138}
Cr-Branched-From: 27de6227ca357da0d57ae2c7b18da170c4651438-refs/heads/main@{#982481}
Update sanitizer-api flag milestone.
(cherry picked from commit c81879956db9b2cd626351076329f8d35f0267cc)
Bug: 1271557
Change-Id: Ia94c88f9ec207c544185711e7b8d181eaf690227
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3539920
Reviewed-by: Yifan Luo <[email protected]>
Commit-Queue: Daniel Vogelheim <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#983771}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3553004
Auto-Submit: Daniel Vogelheim <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/4951@{#137}
Cr-Branched-From: 27de6227ca357da0d57ae2c7b18da170c4651438-refs/heads/main@{#982481}
Fix CCT treating intents as background due to timing issue
Sometimes CCT starts processing an intent before native initialization
has finished, which means the tab may still be hidden. This causes CCT
to treat these intents as background intents. In other cases, CCT may handle the intent before the application state
has been updated to "running". To solve this, we can allow background
navigations if incomingIntentRedirect is true.
(cherry picked from commit ed79acdf0030406a26d08b9bc273a3d5362f15f7)
(cherry picked from commit aa215941575ca059ade5df056af0c5c11dffec46)
Bug: 1307848
Change-Id: I4cb1ede3ad50bf112262178610fa3a3537776829
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3547199
Reviewed-by: Michael Thiessen <[email protected]>
Commit-Queue: Clark DuVall <[email protected]>
Cr-Original-Original-Commit-Position: refs/heads/main@{#984952}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3551496
Reviewed-by: Clark DuVall <[email protected]>
Reviewed-by: Krishna Govind <[email protected]>
Commit-Queue: Krishna Govind <[email protected]>
Owners-Override: Krishna Govind <[email protected]>
Auto-Submit: Krishna Govind <[email protected]>
Cr-Original-Commit-Position: refs/branch-heads/4962@{#5}
Cr-Original-Branched-From: 0234f19605f0b7cefa3b6ed6f82c912fa0023595-refs/heads/main@{#984778}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3551576
Reviewed-by: Yaron Friedman <[email protected]>
Reviewed-by: John Abd-El-Malek <[email protected]>
Cr-Commit-Position: refs/branch-heads/4951@{#136}
Cr-Branched-From: 27de6227ca357da0d57ae2c7b18da170c4651438-refs/heads/main@{#982481}
Make status column second-from-left in attribution internals UI
For better visibility.
(cherry picked from commit c5519f164f3cf5e18165ff1fa9006a6b5b40bfdd)
Bug: 1309851, 1309834
Change-Id: I29f6f78e95df2236c5a7d4652910ef6a09195c9b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3548976
Commit-Queue: Andrew Paseltiner <[email protected]>
Auto-Submit: Andrew Paseltiner <[email protected]>
Reviewed-by: Nan Lin <[email protected]>
Commit-Queue: Nan Lin <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#984810}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3550548
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/4951@{#135}
Cr-Branched-From: 27de6227ca357da0d57ae2c7b18da170c4651438-refs/heads/main@{#982481}
Updating XTBs based on .GRDs from branch 4951
Change-Id: Iac3d374ee41f60fb43a5036bb5c230ca2033279f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3550843
Auto-Submit: Ben Mason <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/4951@{#134}
Cr-Branched-From: 27de6227ca357da0d57ae2c7b18da170c4651438-refs/heads/main@{#982481}
[iOS] Add CHECK in AuthenticationService::SignInInternal()
Add a CHECK for the status returned by
PrimaryAccountMutator::SetPrimaryAccount().
This would help to understand why SignInInternal() can fail.
(cherry picked from commit e8c23ec61b1330482070f4f1bfc3d97a0ad815a8)
Fixed: 1309186
Change-Id: Ia08d4702249042b3d61b1b0c0e0badd4408a46ae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3545086
Reviewed-by: David Roger <[email protected]>
Commit-Queue: Jérôme Lebel <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#984326}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3548880
Cr-Commit-Position: refs/branch-heads/4951@{#133}
Cr-Branched-From: 27de6227ca357da0d57ae2c7b18da170c4651438-refs/heads/main@{#982481}
Privacy Sandbox Settings: Use button for learn more link
Switch link to a button to add the learn more link to the tab order, and to avoid issues with href and onclick working together.
(cherry picked from commit ed77ad80377775b7555ab6dffb79f72221aab2c4)
Bug: 1309473
Change-Id: Ie9c1b402577dcc662dac3e08ebb17c92e4da890b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3545446
Reviewed-by: Theodore Olsauskas-Warren <[email protected]>
Commit-Queue: Ehimare Okoyomon <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#984361}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3550958
Auto-Submit: Ehimare Okoyomon <[email protected]>
Commit-Queue: Theodore Olsauskas-Warren <[email protected]>
Cr-Commit-Position: refs/branch-heads/4951@{#132}
Cr-Branched-From: 27de6227ca357da0d57ae2c7b18da170c4651438-refs/heads/main@{#982481}
[privacy sandbox settings] Announce the title when opening page info subpage
When opening a subpage in the page info, focus must be set. The focus is
set on the back button. Additionally, to inform the user that the UI was
changed, the title of the subpage is announced.
(cherry picked from commit ffd841b20d9c581eb44a128f4393c5fa1ed0e354)
Bug: 1309512, 1268383
Change-Id: Ifd96fb9024888b7baeabf990665a2fd24f1783c6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3545661
Reviewed-by: Christian Dullweber <[email protected]>
Commit-Queue: Olesia Marukhno <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#984397}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3552498
Auto-Submit: Olesia Marukhno <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/4951@{#131}
Cr-Branched-From: 27de6227ca357da0d57ae2c7b18da170c4651438-refs/heads/main@{#982481}
Revert "Web apps: Fix browser side race condition in LaunchQueue"
This reverts commit e9e2b0c2aed89a3889b23d1ce6d3d91f4c1d46c8.
Reason for revert: b/224436725, crbug.com/1307800
Original change's description:
> Web apps: Fix browser side race condition in LaunchQueue
>
> If a web app is launched rapidly in quick succession the LaunchParams
> can clobber each other due to there only being one WebLaunchParamsHelper
> per WebContents.
>
> This CL replaces WebLaunchParamsHelper with a WebAppLaunchQueue living
> on WebAppTabHelper which persists for the entire WebContents lifetime
> and can buffer all LaunchParams that get enqueued during a navigation.
>
> Bug: 1273703
> Change-Id: Idb7ebbb086ee2a8636ac94f354e7850f1309461e
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3347215
> Reviewed-by: Evan Stade <[email protected]>
> Auto-Submit: Alan Cutter <[email protected]>
> Reviewed-by: Wei Lee <[email protected]>
> Commit-Queue: Wei Lee <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#979078}
(cherry picked from commit 1221d4d2fb47aeb23fbf2c00f2bceaabb26dc199)
Bug: 1273703, 1307800
Change-Id: I9de383cd1c4e4b3e91abf67160fb3b567633caa8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3535605
Reviewed-by: Alan Cutter <[email protected]>
Commit-Queue: Wei Lee <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#983229}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3552018
Commit-Queue: Alan Cutter <[email protected]>
Auto-Submit: Alan Cutter <[email protected]>
Reviewed-by: Wei Lee <[email protected]>
Cr-Commit-Position: refs/branch-heads/4951@{#130}
Cr-Branched-From: 27de6227ca357da0d57ae2c7b18da170c4651438-refs/heads/main@{#982481}
[lacros skew tests] Refresh skew tests for M102
This CL updates the ash version ['102.0.4962.0'] for Lacros version skew testing.
If this CL caused regressions, please revert and stop the autoroller
at https://luci-scheduler.appspot.com/jobs/chrome/lacros-version-skew-roller
Also please file a bug to OS>LaCrOS>Partner, and CC [email protected],
[email protected], [email protected].
[email protected]
Bug: None
Change-Id: If52269e76b1c6a935778bb71fcb041e45f46cdc9
Requires-Testing: True
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3550884
Auto-Submit: chrome-weblayer-builder <chrome-weblayer-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/4951@{#129}
Cr-Branched-From: 27de6227ca357da0d57ae2c7b18da170c4651438-refs/heads/main@{#982481}
Quota: RazeAndReopen to create db if one doesn't exist
`db_` may not exist if database fails on open. This change
updates RazeAndReopen to try opening the database one
last time before disabling the database.
(cherry picked from commit d02d5bc22b05977527795e18542dd007c0767600)
Bug: 1308328
Change-Id: I3e319c648953d7528498b89e3511b2a23b10add5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3543330
Reviewed-by: Marijn Kruisselbrink <[email protected]>
Commit-Queue: Ayu Ishii <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#984187}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3550116
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/4951@{#128}
Cr-Branched-From: 27de6227ca357da0d57ae2c7b18da170c4651438-refs/heads/main@{#982481}
[skylab_tests] Update skylab tests cros img version
This CL will update cros image version for skylab tests. CROS_BOARD_LKGM
is updated according to chromeos/CHROMEOS_LKGM; CROS_BOARD_DEV,
CROS_BOARD_BETA and CROS_BOARD_STABLE are updated according to Omaha.
If this CL caused regressions, please revert and pause the autoroller at
https://luci-scheduler.appspot.com/jobs/chrome/lacros-skylab-tests-cros-img-roller
Also please file a bug to OS>LaCrOS>Partner, and CC [email protected],
[email protected], [email protected].
[email protected]
Requires-Testing: True
Change-Id: I2a44e9eb7da6d506bf8d2b78968c306505aa1dcf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3550467
Auto-Submit: skylab-test-cros-roller@chops-service-accounts.iam.gserviceaccount.com <skylab-test-cros-roller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/4951@{#127}
Cr-Branched-From: 27de6227ca357da0d57ae2c7b18da170c4651438-refs/heads/main@{#982481}
Incrementing VERSION to 101.0.4951.10
Change-Id: If7259f198d31f35ba79b1cca5af13bc80261c5fa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3550917
Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/4951@{#126}
Cr-Branched-From: 27de6227ca357da0d57ae2c7b18da170c4651438-refs/heads/main@{#982481}
[attribution_reporting] Add metrics for create aggregatable report status
Add metrics to measure the status of aggregatable report creation in
storage layer. Also updated new enum labels for
"ConversionStorageCreateReportStatus".
(cherry picked from commit 854af5bd98039bd83441adce87b2aceee27be88c)
Bug: 1308832
Change-Id: I7429caa24ef2d02655d69ecda93435a6766dab36
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3533159
Reviewed-by: John Delaney <[email protected]>
Reviewed-by: Andrew Paseltiner <[email protected]>
Commit-Queue: Nan Lin <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#984509}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3550817
Auto-Submit: Nan Lin <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Commit-Queue: John Delaney <[email protected]>
Cr-Commit-Position: refs/branch-heads/4951@{#125}
Cr-Branched-From: 27de6227ca357da0d57ae2c7b18da170c4651438-refs/heads/main@{#982481}
Extend Web MIDI flag
This CL extends the Web MIDI flag expiry to M103. (Branch date 5/12/2022)
(cherry picked from commit 74c0dce03d9e3745c5186a79526238e927b3053e)
Bug: 1251044
Change-Id: Id0d1abc76403925a221bfa658eee0df7baea8727
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3544005
Reviewed-by: Reilly Grant <[email protected]>
Commit-Queue: Hongchan Choi <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#984342}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3549461
Cr-Commit-Position: refs/branch-heads/4951@{#124}
Cr-Branched-From: 27de6227ca357da0d57ae2c7b18da170c4651438-refs/heads/main@{#982481}
Desk templates: move launch ID generation to DesksTemplatesClient.
This is where it really belongs. This fixes a DCHECK when a template
is launched from the extension (which does not go through the regular
DesksTemplatesPresenter path).
(cherry picked from commit fe32960c0bbb117ff959bbfe50fa4a74f093d56d)
Bug: 1309231
Change-Id: I070243a8cc9e435e47026a88134f1efe9b000628
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3543573
Reviewed-by: Sammie Quon <[email protected]>
Commit-Queue: Daniel Andersson <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#984123}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3550081
Cr-Commit-Position: refs/branch-heads/4951@{#123}
Cr-Branched-From: 27de6227ca357da0d57ae2c7b18da170c4651438-refs/heads/main@{#982481}
[iOS][media-permissions] Modify permissions description in page info
Use the correct string in site info panel's permission description
footer.
(cherry picked from commit 29d4beefb1581990783bbf9a886f16dc199d94df)
Bug: 1308446
Change-Id: Id39af9e7a97a19f3c9c256ca34cdd246df98accf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3546237
Auto-Submit: Ginny Huang <[email protected]>
Reviewed-by: Gauthier Ambard <[email protected]>
Commit-Queue: Ginny Huang <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#984384}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3549499
Bot-Commit: Rubber Stamper <[email protected]>
Commit-Queue: Gauthier Ambard <[email protected]>
Cr-Commit-Position: refs/branch-heads/4951@{#122}
Cr-Branched-From: 27de6227ca357da0d57ae2c7b18da170c4651438-refs/heads/main@{#982481}
[iOS] Improve CHECK_EQ() in AuthenticationService::SignInInternal()
This patch adds the following line, in SignInInternal():
CHECK(identity_manager_->HasPrimaryAccount(kSignin))
This helps to have more information if the following CHECK_EQ() fails:
CHECK_EQ(account_id, identity_manager_->GetPrimaryAccountId(
signin::ConsentLevel::kSignin));
On beta and stable, the CHECK doesn't send any message.
(cherry picked from commit f5bc137def5412b0e88253bdaa7a8a70eb99bd5e)
Bug: 1309186
Change-Id: Ifc925e3ee3effaacb2114c08996a492202405323
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3542272
Reviewed-by: Justin Cohen <[email protected]>
Commit-Queue: Jérôme Lebel <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#984266}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3549039
Cr-Commit-Position: refs/branch-heads/4951@{#121}
Cr-Branched-From: 27de6227ca357da0d57ae2c7b18da170c4651438-refs/heads/main@{#982481}
[M101] Re-path libclearkeycdm.so in test-ash-chrome.yaml
This is a test only change.
Similar to crrev.com/c/3448036, this step has been failing
since the path changed in crrev.com/c/2033936.
(cherry picked from commit 5f369e55a663bb5e5b465fcf1bc0695bd2f5c822)
Bug: 1308979
Change-Id: Ia7bc09e6a2fcde60f51ed7c8a2dba6b5f880f37d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3546759
Auto-Submit: Sven Zheng <[email protected]>
Reviewed-by: Ben Pastene <[email protected]>
Commit-Queue: Ben Pastene <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#984523}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3547397
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/4951@{#120}
Cr-Branched-From: 27de6227ca357da0d57ae2c7b18da170c4651438-refs/heads/main@{#982481}
Privacy Sandbox Settings: Fixed height for personalization dialogs
Use fixed height for ad personalization dialogs so that the tooltips do not look weird and so that we have a set view size to avoid jumping when removing/adding list items.
(cherry picked from commit ee3b602a39a6e2ec2cea0b06731322a25bbce5c7)
Bug: 1309411
Change-Id: I14849de59021c079abbdabad9ce2731b22893a89
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3541988
Reviewed-by: Theodore Olsauskas-Warren <[email protected]>
Commit-Queue: Ehimare Okoyomon <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#984258}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3548879
Cr-Commit-Position: refs/branch-heads/4951@{#119}
Cr-Branched-From: 27de6227ca357da0d57ae2c7b18da170c4651438-refs/heads/main@{#982481}
[M101] Split histograms into 4 quadrants.
Merge to release branch
For DIPS (Detect Incidental Party State) we expect that behavior could
be significantly different depending on whether the user is in an
incognito window and/or is blocking third-party cookies (3PC). So split
each of our histograms into the four possible combinations of those two
attributes.
(Also, enable the DIPS Service in incognito windows -- it was previously
disabled.)
To get the 3PC setting, we use CookieSettings; and to get that, we use
CookieSettingsFactory, which is provided by //chrome/browser. This
required us to inline the `dips` source_set into //chrome/browser to
avoid a circular dependency :-/
(cherry picked from commit 5861d17d717d10f2abd24269b88e9dd7e433bb78)
Bug: 1304755
Change-Id: Ifde31da5586ce7ca3713e53f2a0c79330d74c43e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3533167
Reviewed-by: Christian Dullweber <[email protected]>
Reviewed-by: Avi Drissman <[email protected]>
Commit-Queue: Ryan Tarpine <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#983360}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3549519
Auto-Submit: Ryan Tarpine <[email protected]>
Commit-Queue: Avi Drissman <[email protected]>
Cr-Commit-Position: refs/branch-heads/4951@{#118}
Cr-Branched-From: 27de6227ca357da0d57ae2c7b18da170c4651438-refs/heads/main@{#982481}
[M101 Merge][side search] Add nullptr checks for potentially dangling raw ptrs
This CL adds checks for the tab helper WebContentsUserData helper
pointers. This avoids edge cases where these may not have been
added to a given tab's contents, resulting in browser crashes.
(cherry picked from commit 20686ddffde3fab4afbbcd1a2257e99e067dbc19)
Bug: 1307908
Change-Id: I20a296cf5e66fe94973233ad3e4ca78cc8b09154
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3541701
Reviewed-by: Yuheng Huang <[email protected]>
Commit-Queue: Thomas Lukaszewicz <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#984173}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3547608
Cr-Commit-Position: refs/branch-heads/4951@{#117}
Cr-Branched-From: 27de6227ca357da0d57ae2c7b18da170c4651438-refs/heads/main@{#982481}
Extend expiration milestone for the enable-generic-sensor-extra-classes flag.
The features are still under development and there has been no agreement
that the code should be removed at the moment.
(cherry picked from commit 4e152ce36bd5ddcb63cf664b3d9d91cd08f0eb15)
Fixed: 1309407
Change-Id: I99ee49ff0cb3f7d5abaa4bf695fd785b7848cd3c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3535943
Auto-Submit: Raphael Kubo Da Costa <[email protected]>
Reviewed-by: Reilly Grant <[email protected]>
Commit-Queue: Raphael Kubo Da Costa <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#984243}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3548959
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/4951@{#116}
Cr-Branched-From: 27de6227ca357da0d57ae2c7b18da170c4651438-refs/heads/main@{#982481}
[Messages] Init MessageDispatcherBridge::messages_enabled_for_embedder_
I discovered this while working on unittests related to
crbug.com/1308214. The fact that this boolean member variable isn't
initialized means that it takes an undefined value, which is problematic
(a) for embedders that don't call MessageDispatcherBridge::Initialize()
[such as WebLayer], and (b) for Chrome being able to reliably
distinguish between when MessageDispatcherBridge::Initialize() has not
yet been called from when it has been called.
We also add a test that fails without the fix (the boolean gets a
default value of true at least in my local build configuration).
(cherry picked from commit 5e6cb0c635c1fcee5f8cce6e04169a78a88f6ecb)
Bug: 1309043, 1308214
Change-Id: I5714f1c066427bc3b85f7d62cc0ff8011530a7f6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3542022
Reviewed-by: Theresa Sullivan <[email protected]>
Commit-Queue: Colin Blundell <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#984236}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3548918
Cr-Commit-Position: refs/branch-heads/4951@{#115}
Cr-Branched-From: 27de6227ca357da0d57ae2c7b18da170c4651438-refs/heads/main@{#982481}
[M101 merge] Null check side_search_side_panel_ in BrowserView
In incognito mode, side_search_side_panel_ is nullptr. This CL fixes the
NPE when click on the side panel button in incognito mode.
(cherry picked from commit 461a08ff906438f2d98d5cf4247a78454a75a26a)
Bug: 1308183
Change-Id: Ib43f1a01611e364b36ac22e980e9c8db234c22ad
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3540990
Reviewed-by: Peter Kasting <[email protected]>
Commit-Queue: Peter Kasting <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#984357}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3546184
Reviewed-by: Thomas Lukaszewicz <[email protected]>
Commit-Queue: Yuheng Huang <[email protected]>
Cr-Commit-Position: refs/branch-heads/4951@{#114}
Cr-Branched-From: 27de6227ca357da0d57ae2c7b18da170c4651438-refs/heads/main@{#982481}
[M101 Merge][side search] Eliminates conditional updates for the DSE favicon
This CL eliminates the TemplateURL id and favicon checks when
propagating updates in the DefaultSearchIconSource, instead notifying
clients whenever any state in the TemplateURLService changes.
Attempting to conditionally notify clients could result in missed
updates as the specifics of what has changed is not communicated
by the TemplateURLServiceObserver and should not be assumed.
(cherry picked from commit 60f49eb68c7540ad5c4f0d079beae3ddbfd0fa36)
Bug: 1308982
Change-Id: Ib98f878b8761abd5015e423bd87452330346451b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3541047
Reviewed-by: Yuheng Huang <[email protected]>
Commit-Queue: Thomas Lukaszewicz <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#984069}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3547605
Cr-Commit-Position: refs/branch-heads/4951@{#113}
Cr-Branched-From: 27de6227ca357da0d57ae2c7b18da170c4651438-refs/heads/main@{#982481}
Add a Boolean metric to differentiate between BlueZ v.s. Floss
BUG=b:201111413
TEST=build
(cherry picked from commit 6886095ebd12ad2ff8bba0ad7eff57d2166d7415)
Change-Id: Ie9c42a40d6640a1d8799fc56b807119aaba4c75a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3534221
Reviewed-by: Kyle Horimoto <[email protected]>
Reviewed-by: Robert Kaplow <[email protected]>
Auto-Submit: Michael Sun <[email protected]>
Commit-Queue: Michael Sun <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#984128}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3546299
Cr-Commit-Position: refs/branch-heads/4951@{#112}
Cr-Branched-From: 27de6227ca357da0d57ae2c7b18da170c4651438-refs/heads/main@{#982481}
Use attributionsrc API surface for populating context menu impressions
We also re-enable the relevant test, since it is the only place this
behavior is covered.
(cherry picked from commit 81673d4bcda6c21441563d6962c26f1c6c160432)
Bug: 1308781, 1219907
Change-Id: Ibaa470a20ac9d788375a0bc15db724ed26c3cb18
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3540922
Reviewed-by: Nate Chapin <[email protected]>
Reviewed-by: John Delaney <[email protected]>
Commit-Queue: Andrew Paseltiner <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#984051}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3546717
Auto-Submit: Andrew Paseltiner <[email protected]>
Commit-Queue: Nate Chapin <[email protected]>
Cr-Commit-Position: refs/branch-heads/4951@{#111}
Cr-Branched-From: 27de6227ca357da0d57ae2c7b18da170c4651438-refs/heads/main@{#982481}
[m101] android: Null check in WakeUpGpu
Add back the null check that was accidentally removed in r973834
(cherry picked from commit 895654d606847ba40f2b3956c7bad7841e665ec6)
Bug: 1308776
Change-Id: I9b47faf76aad5a89b7efe2c0bebd744be621ff2f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3543706
Commit-Queue: Bo Liu <[email protected]>
Auto-Submit: Bo Liu <[email protected]>
Reviewed-by: Vasiliy Telezhnikov <[email protected]>
Commit-Queue: Vasiliy Telezhnikov <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#983938}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3549137
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/4951@{#110}
Cr-Branched-From: 27de6227ca357da0d57ae2c7b18da170c4651438-refs/heads/main@{#982481}
Updating XTBs based on .GRDs from branch 4951
Change-Id: I2de24e9660e5003860c0b8ef1e93ae38fb77b7fb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3549136
Auto-Submit: Ben Mason <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/4951@{#109}
Cr-Branched-From: 27de6227ca357da0d57ae2c7b18da170c4651438-refs/heads/main@{#982481}
[Merge-M101][Passwords] If FormData cannot be retrieved for TTF, don't crash
(cherry picked from commit a0c3f666e2cc0a5e249a52592dba49e6cf25b317)
Bug: 1308791, 1283004
Change-Id: I041158ab9d2b48ff82c250489cd6ad31e7417171
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3542549
Auto-Submit: Maxim Kolosovskiy <[email protected]>
Reviewed-by: Friedrich Horschig <[email protected]>
Commit-Queue: Friedrich Horschig <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#984263}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3548696
Commit-Queue: Maxim Kolosovskiy <[email protected]>
Cr-Commit-Position: refs/branch-heads/4951@{#108}
Cr-Branched-From: 27de6227ca357da0d57ae2c7b18da170c4651438-refs/heads/main@{#982481}
Don't paint overlay scrollbars when printing or painting preview
To prevent them from being all visible and covering contents.
(cherry picked from commit b39a2d30d79c7fe2191202e55858301ccf87b5d6)
Bug: 1297969
Change-Id: I8ba32ee58fc07f5aee7b7bd43084e03e382533f2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3534771
Auto-Submit: Xianzhu Wang <[email protected]>
Reviewed-by: Philip Rogers <[email protected]>
Commit-Queue: Xianzhu Wang <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#984121}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3548138
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/4951@{#107}
Cr-Branched-From: 27de6227ca357da0d57ae2c7b18da170c4651438-refs/heads/main@{#982481}
Properly remove / re-add moved children from / to the flow thread.
CL:3479936 added code to notify the flow thread about descendant
removal "in time", but we forgot to notify the flow thread about the
descendants (that we're going to keep) being "re-added".
Request a full remove/insert, which will automatically call
FlowThreadDescendantWillBeRemoved() and
FlowThreadDescendantWasInserted() (in LayoutMultiColumnFlowThread) at
the right times.
(cherry picked from commit 927e2919b43ca155923bf1cc5d3a35d074737d03)
Bug: 1308253, 1305865, 1308232
Change-Id: I39e0404bdc53136fa646d4664681facf0a6e35e6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3541961
Reviewed-by: Ian Kilpatrick <[email protected]>
Commit-Queue: Morten Stenshorne <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#984108}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3548176
Auto-Submit: Morten Stenshorne <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/4951@{#106}
Cr-Branched-From: 27de6227ca357da0d57ae2c7b18da170c4651438-refs/heads/main@{#982481}
[attribution_reporting] Show aggregatable source in internals UI
Screenshot can be found at crbug.com/1308824#c1.
(cherry picked from commit 1a20bb347fa076c0362793b6ca79d7b10d5592fe)
Bug: 1308824
Change-Id: I6374c91f5475b029b04af6b7d52fc1b2ad9c59ef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3537314
Reviewed-by: Alex Gough <[email protected]>
Reviewed-by: Andrew Paseltiner <[email protected]>
Reviewed-by: John Delaney <[email protected]>
Commit-Queue: Nan Lin <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#984038}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3546504
Auto-Submit: Nan Lin <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/4951@{#105}
Cr-Branched-From: 27de6227ca357da0d57ae2c7b18da170c4651438-refs/heads/main@{#982481}
Clear results on Start for zero-state providers in classic launcher
Attempt 2 at this, which will not regress zero-state results in tablet
mode. Intending to merge to M101.
(cherry picked from commit f4f57afc991bb0d0da9e014baeb1609620426044)
Bug: 1298854
Change-Id: I167d77163046dcdb130b2fd7d2249e7ac377cdc6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3544750
Commit-Queue: Rachel Wong <[email protected]>
Reviewed-by: Rachel Wong <[email protected]>
Commit-Queue: Tony Yeoman <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#984200}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3545490
Auto-Submit: Tony Yeoman <[email protected]>
Cr-Commit-Position: refs/branch-heads/4951@{#104}
Cr-Branched-From: 27de6227ca357da0d57ae2c7b18da170c4651438-refs/heads/main@{#982481}
[skylab_tests] Update skylab tests cros img version
This CL will update cros image version for skylab tests. CROS_BOARD_LKGM
is updated according to chromeos/CHROMEOS_LKGM; CROS_BOARD_DEV,
CROS_BOARD_BETA and CROS_BOARD_STABLE are updated according to Omaha.
If this CL caused regressions, please revert and pause the autoroller at
https://luci-scheduler.appspot.com/jobs/chrome/lacros-skylab-tests-cros-img-roller
Also please file a bug to OS>LaCrOS>Partner, and CC [email protected],
[email protected], [email protected].
[email protected]
Requires-Testing: True
Change-Id: I0d193e11bcc2d1f77caf49fc4b4ebac5c9d32451
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3545137
Auto-Submit: skylab-test-cros-roller@chops-service-accounts.iam.gserviceaccount.com <skylab-test-cros-roller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/4951@{#103}
Cr-Branched-From: 27de6227ca357da0d57ae2c7b18da170c4651438-refs/heads/main@{#982481}
[lacros skew tests] Refresh skew tests for M102
This CL updates the ash version ['102.0.4960.0'] for Lacros version skew testing.
If this CL caused regressions, please revert and stop the autoroller
at https://luci-scheduler.appspot.com/jobs/chrome/lacros-version-skew-roller
Also please file a bug to OS>LaCrOS>Partner, and CC [email protected],
[email protected], [email protected].
[email protected]
Bug: None
Change-Id: I0f648eda37f25178d0b322597695e668943bf478
Requires-Testing: True
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3547696
Auto-Submit: chrome-weblayer-builder <chrome-weblayer-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/4951@{#102}
Cr-Branched-From: 27de6227ca357da0d57ae2c7b18da170c4651438-refs/heads/main@{#982481}
Incrementing VERSION to 101.0.4951.9
Change-Id: Ic3dec2fd8e7fcb05b4e330ad79831b39b68687d6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3545757
Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/4951@{#101}
Cr-Branched-From: 27de6227ca357da0d57ae2c7b18da170c4651438-refs/heads/main@{#982481}
[M101][LR] Fix crash when app resumes form background
There's a known issue with DialogFragment where if the app is sent to
the background and some OS settings are changed, such as enabling or
disabling battery saver, or enabling or disabling dark theme, then when
the app is brought to the foreground again, the DialogFragment gets
recreated. This means that any custom initialization is not performed
on the DialogFragment subclass. In this specific case, the Dialog owner
needs to call init() on it. Without it, the scene coordinator is null
when the app resumes from background, which causes a crash.
This state cannot be recovered from, so the best course of action is to
simply dismiss the dialog. This isn't so bad from the user's perspective
because they had left the app already. Resuming the app will simply
bring them back to the website they were browsing.
(cherry picked from commit a6069dc3ce347a832a5fd3c3aa81d5ea89190285)
Bug: 1303469
Change-Id: If51d79893775acbbc230d15c20eaa8196e66bd62
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3542794
Reviewed-by: Sophey Dong <[email protected]>
Commit-Queue: Guillaume Jenkins <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#983923}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3547037
Auto-Submit: Guillaume Jenkins <[email protected]>
Commit-Queue: Sophey Dong <[email protected]>
Cr-Commit-Position: refs/branch-heads/4951@{#100}
Cr-Branched-From: 27de6227ca357da0d57ae2c7b18da170c4651438-refs/heads/main@{#982481}
Replace individual window.open attribution parameters with attributionsrc infra
https://github.com/WICG/conversion-measurement-api/blob/main/EVENT.md#registering-attribution-sources
(cherry picked from commit 9328e26f45b6175fe56028bad46d2dcba47d1ab3)
Bug: 1308460, 1308438, 1301960
Change-Id: Ib00b0361ca4ada774f0c57d519f4d4898ce56cf1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3537908
Reviewed-by: John Delaney <[email protected]>
Reviewed-by: Nate Chapin <[email protected]>
Commit-Queue: Andrew Paseltiner <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#983993}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3547237
Auto-Submit: Andrew Paseltiner <[email protected]>
Commit-Queue: Nate Chapin <[email protected]>
Cr-Commit-Position: refs/branch-heads/4951@{#99}
Cr-Branched-From: 27de6227ca357da0d57ae2c7b18da170c4651438-refs/heads/main@{#982481}
M101 merge: [App Shim] Respect Profile lifetime
Now that Profiles can be destroyed at any time, we need to tweak
AppShimManager to respect that. We're seeing crash reports from trying
to access a deleted Profile* in AppState::profiles.
We don't know the exact cause of the crashes, so this patch includes
speculative fixes, and a (hopefully actionable) DumpWithoutCrashing().
- OnAppDeactivated(): After performing cleanup, ensure that *all*
AppState::profiles entries are in a consistent state.
- OnBrowserRemoved(): Rather than cleaning up a single AppState, iterate
through all of them and clean them all up. This fixes cases where
GetAppIdFromApplicationName() doesn't work (if it happens).
- Add OnProfileWillBeDestroyed(), and perform some additional cleanup
there. This fixes cases where there are 0 Browsers for a Profile,
and OnBrowserRemoved() never runs (if it happens).
(cherry picked from commit 0ed1e9e52f51e7650017eade5286e72f737916d8)
Fixed: 1302722, 1307335
Bug: 1302344
Change-Id: I1d6a1bb88c640f6deb5db660f5f0621899123f06
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3537309
Reviewed-by: ccameron chromium <[email protected]>
Commit-Queue: Nicolas Ouellet-Payeur <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#983485}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3546080
Auto-Submit: Nicolas Ouellet-Payeur <[email protected]>
Commit-Queue: ccameron chromium <[email protected]>
Cr-Commit-Position: refs/branch-heads/4951@{#98}
Cr-Branched-From: 27de6227ca357da0d57ae2c7b18da170c4651438-refs/heads/main@{#982481}
[LaCrOS]Temporary workaround to disable RED_8 overlay candidates
creations through SharedImageInterface
LaCrOS on ARM devices can't create RED_8 gmb's via Gbm device, this
capability is not communicated to clients. Causing certain shared image
creations to fail when delegated compositing is on. Disable this.
(cherry picked from commit 3171a47d5f899ffe8bf11b6f2c65f542f49ec956)
Change-Id: Ia03c9a00450f45d68f1194bb5614cc1cae3506c1
Bug: 1301891
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3537451
Reviewed-by: Robert Kroeger <[email protected]>
Commit-Queue: Kramer Ge <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#982914}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3546838
Reviewed-by: Peter McNeeley <[email protected]>
Auto-Submit: Kramer Ge <[email protected]>
Cr-Commit-Position: refs/branch-heads/4951@{#97}
Cr-Branched-From: 27de6227ca357da0d57ae2c7b18da170c4651438-refs/heads/main@{#982481}
[M101 merge] Clobber side search side panels if other side panel is open.
The CL clobber all side search side panels if either lens and read later
side panel is open per UX's request. This logic is guarded under
ClobberAllSideSearchSidePanels flag and is enabled by default.
(cherry picked from commit 7705d2a51a056038f5b1259a22dfa174d15ddbbc)
Bug: 1307556
Change-Id: I4276e76dcaa6fe1c631a0c370a1345784e244a8d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3537227
Reviewed-by: Thomas Lukaszewicz <[email protected]>
Reviewed-by: Peter Kasting <[email protected]>
Commit-Queue: Yuheng Huang <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#983490}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3546283
Cr-Commit-Position: refs/branch-heads/4951@{#96}
Cr-Branched-From: 27de6227ca357da0d57ae2c7b18da170c4651438-refs/heads/main@{#982481}
[VCN][M2] Update metrics for infobar close and cancel
Log VIRTUAL_CARD_ENROLLMENT_BUBBLE_CANCELLED for both infobar close and cancel. On Clank, closing infobar is equivalent to cancelling.
(cherry picked from commit 4e6219392492111d7968c5016f1393061fe2277f)
Bug: 1308861
Change-Id: I0853adf1eea8fd0913c58667bf007f1e813eb206
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3536418
Reviewed-by: Siyu An <[email protected]>
Commit-Queue: Vishwas Uppoor <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#982910}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3546497
Auto-Submit: Vishwas Uppoor <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/4951@{#95}
Cr-Branched-From: 27de6227ca357da0d57ae2c7b18da170c4651438-refs/heads/main@{#982481}
Notification: Only synthesize mouse move event when widget is open.
The bug below is caused by clicking the crostini upgrade notification
(constructed in CrostiniUpgradeAvailableNotification). When we click
the button on this notification in message center, the notification
get updated and at the same time close the widget to open a WebUI
dialog. This caused a crash when calling SynthesizeMouseMoveEvent()
since the widget is closed.
(cherry picked from commit 12ffe9e3e5939c1f114e5c28f748ac943c1df8c2)
Bug: 1305042
Change-Id: If80b5011ec8408e1e8727060b6f246bdbaf00d5f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3540482
Reviewed-by: Yoshiki Iguchi <[email protected]>
Commit-Queue: Andre Le <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#983612}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3546478
Reviewed-by: Ahmed Mehfooz <[email protected]>
Cr-Commit-Position: refs/branch-heads/4951@{#94}
Cr-Branched-From: 27de6227ca357da0d57ae2c7b18da170c4651438-refs/heads/main@{#982481}
[omnibox][a11y] Update voiceover string for entering Keyword Mode
(cherry picked from commit ae5e76d3d5e5b2b0036cb59055b7cc9da262a20c)
Bug: 1212247
Change-Id: I91731cf5e7979add98f409a264cfb3339c96305d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3539687
Reviewed-by: Justin Donnelly <[email protected]>
Commit-Queue: Angela Yoeurng <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#983558}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3546187
Auto-Submit: Angela Yoeurng <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/4951@{#93}
Cr-Branched-From: 27de6227ca357da0d57ae2c7b18da170c4651438-refs/heads/main@{#982481}
Revert "Roll androidx from k4t_4yTm0... to vxGk90QHP..."
This reverts commit 7f3360b017068b80c2fd598fac7b438b2f039747.
Rolling back androidx version to before app menu close events were
broken. This fixes an issue where the NTP stops being intractable
with touch after a context menu is shown.
Bug: 1305963
Change-Id: I8c2e3bf936ddf9724cd11a0fb17727ed37707c72
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3546837
Commit-Queue: Sky Malice <[email protected]>
Auto-Submit: Sky Malice <[email protected]>
Reviewed-by: Sinan Sahin <[email protected]>
Commit-Queue: Sinan Sahin <[email protected]>
Cr-Commit-Position: refs/branch-heads/4951@{#92}
Cr-Branched-From: 27de6227ca357da0d57ae2c7b18da170c4651438-refs/heads/main@{#982481}
[RSearches] Scroll to the tapped chip if it is partially off screen
RecyclerView#scrollToPosition will scroll to the view if the view is off
or partially off the screen.
Video:
https://drive.google.com/file/d/10_uXKHGXYjwAoBWK8PdnJwZ2gR-zMabp/view?usp=sharing
(cherry picked from commit a1386c4931a36843471ee8007eefc0e53fe1e024)
Bug: 1252569
Change-Id: I903fb31067d0e4810dedbae52a519ee78ab336dd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3543665
Reviewed-by: Donn Denman <[email protected]>
Commit-Queue: Gang Wu <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#984015}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3546524
Cr-Commit-Position: refs/branch-heads/4951@{#91}
Cr-Branched-From: 27de6227ca357da0d57ae2c7b18da170c4651438-refs/heads/main@{#982481}
[merge to M101] Extend notifications revamp flag in Chrome UI
This feature was delayed to M104, with dogfood beginning in M101
we need users the ability to turn off this feature when needed.
Bug: 1307889
(cherry picked from commit 9582804a2a70de1d44bf99db232da15fd368f4d6)
Change-Id: I8f0f44d7a1c8ec8f1ade3ab4778da08dabbdd0a7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3537647
Reviewed-by: Alex Newcomer <[email protected]>
Commit-Queue: Alex Newcomer <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#982906}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3546130
Commit-Queue: Ahmed Mehfooz <[email protected]>
Cr-Commit-Position: refs/branch-heads/4951@{#90}
Cr-Branched-From: 27de6227ca357da0d57ae2c7b18da170c4651438-refs/heads/main@{#982481}
[M101] Enable `rasterize_pdf` option for low quality printing.
Currently the unseasoned PDF plugin fails to load Print Preview for low
quality printing due to rasterizing PDF option is disabled from the
`print_param` input of blink::WebPlugin::PrintBegin(). The correct
`rasterize_pdf` option value should also depend on the printing quality
for the PDFs.
This CL enables `rasterize_pdf` when doing low quality printing so that
Print Preview can load successfully.
(cherry picked from commit fc45b35aa4c786f9b5cd78f8e93c062702022c86)
Bug: 1307219
Change-Id: I1fe3dc21807c5f7bfa52fcdc40163459073147cc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3534390
Reviewed-by: Lei Zhang <[email protected]>
Commit-Queue: Nigi <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#983709}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3546182
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/4951@{#89}
Cr-Branched-From: 27de6227ca357da0d57ae2c7b18da170c4651438-refs/heads/main@{#982481}
[Merge to M101]bento_bar: Extend expiration of the flags
(cherry picked from commit 2f54187f2ccab5853343ee0aed4982899048cd97)
Bug: 1309121
Change-Id: Iae7416296a3d004cb3a2e67b34375792355561f8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3540966
Reviewed-by: Xiaoqian Dai <[email protected]>
Commit-Queue: Min Chen <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#983864}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3546298
Auto-Submit: Min Chen <[email protected]>
Cr-Commit-Position: refs/branch-heads/4951@{#88}
Cr-Branched-From: 27de6227ca357da0d57ae2c7b18da170c4651438-refs/heads/main@{#982481}
[M101] Add MediaFoundationH264CbpEncoding flag.
This flag is used to enable/disable the hardware H.264 encoder for
constrained baseline profile on Windows.
(cherry picked from commit 10d042200ff57d0d4578e77bd232bd22f49dcc80)
Bug: 1295815
Change-Id: I3cacd3977901df78e7fd558e19a98fcf1567651f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3534690
Reviewed-by: Dale Curtis <[email protected]>
Commit-Queue: Chunbo Hua <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#983096}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3538815
Commit-Queue: Dale Curtis <[email protected]>
Cr-Commit-Position: refs/branch-heads/4951@{#87}
Cr-Branched-From: 27de6227ca357da0d57ae2c7b18da170c4651438-refs/heads/main@{#982481}
Privacy Sandbox Settings: Fix consent and notice width on tablets
Merge approved in crbug.com/1308362
Screenshot: https://screenshot.googleplex.com/5vS2upnUMw4VkJP.png
(cherry picked from commit f19f637b62d6906b52c13f97f920950f76a53775)
Bug: 1308362, 1286276
Change-Id: Ic184e06a043789f6689eca51bdc18f5f436a312e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3540320
Auto-Submit: Andrey Zaytsev <[email protected]>
Reviewed-by: Christian Dullweber <[email protected]>
Commit-Queue: Andrey Zaytsev <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#983324}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3545152
Commit-Queue: Christian Dullweber <[email protected]>
Cr-Commit-Position: refs/branch-heads/4951@{#86}
Cr-Branched-From: 27de6227ca357da0d57ae2c7b18da170c4651438-refs/heads/main@{#982481}
MERGE: Add interest group priority and limit interest groups per auction
Change interest_group_owner index to include next_update_after and
group name.
(cherry picked from commit 5a102f146faa0c21eb9cf255ceb46b35a158ab3f)
Bug: 1305596
Change-Id: I67ecfdcfe67d2e89608903d52c2495366e962f1a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3517534
Reviewed-by: Caleb Raitto <[email protected]>
Reviewed-by: Mike West <[email protected]>
Reviewed-by: Victor Costan <[email protected]>
Commit-Queue: Victor Costan <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#982757}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3542072
Auto-Submit: Russ Hamilton <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Commit-Queue: Russ Hamilton <[email protected]>
Cr-Commit-Position: refs/branch-heads/4951@{#85}
Cr-Branched-From: 27de6227ca357da0d57ae2c7b18da170c4651438-refs/heads/main@{#982481}
OOBE: Update the integration between ConsolidatedConsent and PerUserMetrics
- Enterprise enrolled devices will have the metrics opt-in managed
by the admin.
- Skip the consolidated consent screen when metrics is managed and
ARC Negotiation is not required.
- Construct and start ArcOptInPreferenceHandler object in
OnOwnershipStatusCheckDone callback since the handler depends on
the ownership status.
- Set the default value of metrics opt-in to true.
- Add an observer in UserManager to listen to changes from CrosSettings
and update the owner ID.
(cherry picked from commit c10ddcd25bf46409ed42fb1d958d2eaea2a9ac04)
Bug: 1201616
Change-Id: I795357ab320559b2682e9fa3842e2a6a3b4a26e2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3529075
Reviewed-by: Jong Ahn <[email protected]>
Reviewed-by: Roman Sorokin <[email protected]>
Reviewed-by: Yury Khmel <[email protected]>
Commit-Queue: Osama Fathy <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#982507}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3542329
Cr-Commit-Position: refs/branch-heads/4951@{#84}
Cr-Branched-From: 27de6227ca357da0d57ae2c7b18da170c4651438-refs/heads/main@{#982481}
[attribution_reporting] Limit the number of concurrent attributionsrc
requests
The number of concurrent attributionsrc requests should be limited to
30 per frame.
(cherry picked from commit c6ba12544c81d5ccb7c40e1abc2f52de8a010575)
Bug: 1306506
Change-Id: Ie62c751d7a9031016ea736721b67ca3ca772de0b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3525495
Reviewed-by: Nico Weber <[email protected]>
Reviewed-by: John Delaney <[email protected]>
Reviewed-by: Andrew Paseltiner <[email protected]>
Commit-Queue: Nan Lin <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#983495}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3544066
Auto-Submit: Nan Lin <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Commit-Queue: Nico Weber <[email protected]>
Cr-Commit-Position: refs/branch-heads/4951@{#83}
Cr-Branched-From: 27de6227ca357da0d57ae2c7b18da170c4651438-refs/heads/main@{#982481}
Multi-network Cronet: implementation plumbing
This CL introduces only the implementation part of the multi-network
Cronet API and pre-bumps the implementation API level. All this does is
pass down a Network parameter from Cronet's Java implementation classes.
Currently this Network parameter cannot be set through Cronet's Java
API classes, this will be added later on (through the interface part of
the multi-network Cronet API).
Now that this is in place, we can also remove the optional
CronetContext::NetworkTasks's contructor parameter
listen_to_network_changes and always register for NCN notifications.
(cherry picked from commit 03391acb02363cbb15b781a0c13fd553214bf8b9)
Bug: 1284972
Change-Id: I52dca2733732409c3fc4d19aa4187336281850aa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3529068
Reviewed-by: Richard Coles <[email protected]>
Commit-Queue: Stefano Duo <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#983402}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3545247
Auto-Submit: Stefano Duo <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Commit-Queue: Richard Coles <[email protected]>
Cr-Commit-Position: refs/branch-heads/4951@{#82}
Cr-Branched-From: 27de6227ca357da0d57ae2c7b18da170c4651438-refs/heads/main@{#982481}
Accept physical pixels for main thread hit test.
(cherry picked from commit 911088694d7d1e4af0c14c6ac0fcf95dadea4565)
Bug: 1304965
Change-Id: I003830e1a24cf597e02c679b5983c66e9190536d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3537317
Reviewed-by: David Bokan <[email protected]>
Commit-Queue: Steve Kobes <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#983779}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3546098
Auto-Submit: Steve Kobes <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Commit-Queue: David Bokan <[email protected]>
Cr-Commit-Position: refs/branch-heads/4951@{#81}
Cr-Branched-From: 27de6227ca357da0d57ae2c7b18da170c4651438-refs/heads/main@{#982481}
Updating XTBs based on .GRDs from branch 4951
Change-Id: Iee16c79b66e502d6c84477b88e55a2dbf69e81a5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3546076
Auto-Submit: Ben Mason <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/4951@{#80}
Cr-Branched-From: 27de6227ca357da0d57ae2c7b18da170c4651438-refs/heads/main@{#982481}
Extend `permission-predictions` flag to 110
(cherry picked from commit 1a1023c3f5bcf34431f262992ae6358e30724fb8)
Bug: 1307679
Change-Id: I9950c2456e32826fe4f88f39da95c9200bfed7bd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3535945
Auto-Submit: Andy Paicu <[email protected]>
Reviewed-by: Kamila Hasanbega <[email protected]>
Commit-Queue: Andy Paicu <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#982681}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3545150
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/4951@{#79}
Cr-Branched-From: 27de6227ca357da0d57ae2c7b18da170c4651438-refs/heads/main@{#982481}
[M101] wayland: no longer reset kTouchPress serial on touch-up
Under Wayland, 'set_selection' requests require a serial number
corresponding to a recent input event (eg: mouse press, key press, touch
tap, etc). OTOH, kTouchPress serial is reset upon wl_touch.up, which
leads to no-op when trying to write to clipboard when, handling a
touch-tap (ie: touch down followed by a touch up), for example. Another
example is when clipboard writes are triggered asynchronously, eg: touch
down coming from a renderer process.
This CL fixes it by no longer resetting kTouchPress upon touch-up
Wayland event, which should not cause issues as, nowadays, compositors
usually only check whether a received serial is "not too old". It also
should not lead to bad side effects at ozone/wayland code as long as
SerialTracker is not used to determine whether there are active touch
points, for example.
Additionally, clipboard unit tests are fixed and improved to correctly
exercise these edge cases.
R=[email protected]
(cherry picked from commit 097317ebd89b8559778ccb63b176a383d9e9ec6b)
Bug: 1282220
Test: Covered by WaylandClipboardTest in ozone_unittests
Change-Id: Ib6305accf1fd542b80711730c654b0a1e51b6ded
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3527605
Reviewed-by: Maksim Sisov <[email protected]>
Commit-Queue: Nick Yamane <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#983748}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3545329
Auto-Submit: Nick Yamane <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/4951@{#78}
Cr-Branched-From: 27de6227ca357da0d57ae2c7b18da170c4651438-refs/heads/main@{#982481}
[AA CEX] Add JS_FORCED_ROUNDTRIP status
This status will be used by js flows when they want to force an
additional roundtrip. Can be used to cancel a speculative execution.
(cherry picked from commit 693d3604eb2b60421e7d01d04925653a0f1de28f)
Bug: 1308337
Change-Id: I9b586a2b77702e411ea6bf583f827b90ca24f73b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3536654
Auto-Submit: Florian Gauger <[email protected]>
Reviewed-by: Clemens Arbesser <[email protected]>
Commit-Queue: Florian Gauger <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#983246}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3545147
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/4951@{#77}
Cr-Branched-From: 27de6227ca357da0d57ae2c7b18da170c4651438-refs/heads/main@{#982481}
Privacy Sandbox Settings: Fix typo in removed interests view
(cherry picked from commit 8f36831f735466ed99c9e4b759309f45125f06ea)
Bug: 1308404
Change-Id: I988e8edde28fe40076d652ea8cf39ffb4d415112
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3540321
Commit-Queue: Christian Dullweber <[email protected]>
Auto-Submit: Christian Dullweber <[email protected]>
Reviewed-by: Andrey Zaytsev <[email protected]>
Commit-Queue: Andrey Zaytsev <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#983332}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3541946
Reviewed-by: Olesia Marukhno <[email protected]>
Commit-Queue: Olesia Marukhno <[email protected]>
Cr-Commit-Position: refs/branch-heads/4951@{#76}
Cr-Branched-From: 27de6227ca357da0d57ae2c7b18da170c4651438-refs/heads/main@{#982481}
Fix `ShelfLayoutManager` crash on browser shutdown.
Fixes a crash in which the `aura::client::DragDropClient` could be
`nullptr` during browser shutdown. Crash conditions require that the
user have auto-hidden shelf enabled.
Crash introduced by change in lifecycle:
https://chromium-review.googlesource.com/c/chromium/src/+/3488450
(cherry picked from commit 61a894db33f01f985237c9d80c1c6df9e26bcf1e)
Bug: 1303849
Change-Id: I606a8d21b92d6772ea07203703dd90c3fd28f988
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3534547
Reviewed-by: Toni Barzic <[email protected]>
Commit-Queue: David Black <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#982785}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3544531
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/4951@{#75}
Cr-Branched-From: 27de6227ca357da0d57ae2c7b18da170c4651438-refs/heads/main@{#982481}
[Merge M101] Fix crash when WindowAndroid has no ModalDialogManager
This can happen when a page is opened in a ThinWebView. I discussed this
with shaktisahu@ on the bug, we can request permissions directly if a
ModalDialogManager isn't present.
(cherry picked from commit 3dca949ca16bf72a4c2cbffea7b1c4136bcfd2aa)
Bug: 1308293
Change-Id: I04bfe52e5f362ac62460eea8d03f95014c30d44e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3537811
Reviewed-by: Shakti Sahu <[email protected]>
Commit-Queue: Shakti Sahu <[email protected]>
Commit-Queue: Clark DuVall <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#983663}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3541670
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/4951@{#74}
Cr-Branched-From: 27de6227ca357da0d57ae2c7b18da170c4651438-refs/heads/main@{#982481}
[M101] Extend expiration for several site isolation flags.
Many of these flags are still relevant, and we plan to keep working on
origin isolation, site isolation on Android, etc.
(cherry picked from commit 1ea7efa20cf80fd0030443d3ef6ec6e791cc6ddf)
Bug: 1308897
Change-Id: Ief5d8476bf5bbd8f6b93825eb8d4eac015cfd587
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3541381
Auto-Submit: Alex Moshchuk <[email protected]>
Reviewed-by: Łukasz Anforowicz <[email protected]>
Commit-Queue: Łukasz Anforowicz <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#983575}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3544029
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/4951@{#73}
Cr-Branched-From: 27de6227ca357da0d57ae2c7b18da170c4651438-refs/heads/main@{#982481}
[lacros skew tests] Refresh skew tests for M99
This CL updates the ash version ['99.0.4844.86'] for Lacros version skew testing.
If this CL caused regressions, please revert and stop the autoroller
at https://luci-scheduler.appspot.com/jobs/chrome/lacros-version-skew-roller
Also please file a bug to OS>LaCrOS>Partner, and CC [email protected],
[email protected], [email protected].
[email protected]
Bug: None
Change-Id: Ie81cea32e78be8fccc150101064a46e29a196543
Requires-Testing: True
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3544015
Auto-Submit: chrome-weblayer-builder <chrome-weblayer-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/4951@{#72}
Cr-Branched-From: 27de6227ca357da0d57ae2c7b18da170c4651438-refs/heads/main@{#982481}
Fix registered sources/triggers per data host metrics
crrev.com/c/3522702 added the metrics for registered sources/triggers
per data host but missed the case that a data host is registered but
never registers a source or trigger.
Since whether it's source or trigger is not known at data host
registration time, to be consistent, we only log the metrics if there's
at least one source or trigger registered.
The number of data hosts that don't register any source or trigger can
be inferred combined with "Conversions.AttributionSrcRequestStatus".
(cherry picked from commit bae1fce14dc7c6c87a745fd2415834f020dde80a)
Bug: 1285319
Change-Id: I5213dbbc016c99563a212960123a90d05bf82846
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3538202
Reviewed-by: Andrew Paseltiner <[email protected]>
Commit-Queue: Nan Lin <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#983299}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3544105
Auto-Submit: Nan Lin <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/4951@{#71}
Cr-Branched-From: 27de6227ca357da0d57ae2c7b18da170c4651438-refs/heads/main@{#982481}
[skylab_tests] Update skylab tests cros img version
This CL will update cros image version for skylab tests. CROS_BOARD_LKGM
is updated according to chromeos/CHROMEOS_LKGM; CROS_BOARD_DEV,
CROS_BOARD_BETA and CROS_BOARD_STABLE are updated according to Omaha.
If this CL caused regressions, please revert and pause the autoroller at
https://luci-scheduler.appspot.com/jobs/chrome/lacros-skylab-tests-cros-img-roller
Also please file a bug to OS>LaCrOS>Partner, and CC [email protected],
[email protected], [email protected].
[email protected]
Requires-Testing: True
Change-Id: Idb1f14042502c970cfc1e3e24ef1f88a803f22e7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3542432
Auto-Submit: skylab-test-cros-roller@chops-service-accounts.iam.gserviceaccount.com <skylab-test-cros-roller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/branch-heads/4951@{#70}
Cr-Branched-From: 27de6227ca357da0d57ae2c7b18da170c4651438-refs/heads/main@{#982481}
