Page MenuHomePhabricator
Differential D69959

Bug 1627892 - Make StreamList derive from SafeRefCounted. r=#dom-workers-and-storage
ClosedPublic
Actions

Authored by • sg on Apr 7 2020, 9:27 AM.

Details

Reviewers
• perry
Group Reviewers
Restricted Project
Commits
rMOZILLACENTRALc1672bc9a695: Bug 1627892 - Make StreamList derive from SafeRefCounted. r=dom-workers-and…
Bugzilla Bug ID
1627892

Diff Detail

Repository
rMOZILLACENTRAL mozilla-central
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

• sg created this revision.Apr 7 2020, 9:27 AM
Herald added a project: secure-revision. · View Herald TranscriptApr 7 2020, 9:27 AM
Harbormaster completed remote builds in B180959: Diff 256379.Apr 7 2020, 9:27 AM
phab-bot requested review of this revision.Apr 7 2020, 9:28 AM
phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".
phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".
phab-bot removed a project: secure-revision.
• sg added a child revision: D69960: Bug 1627892 - Make CacheWorkerRef derive from SafeRefCounted. r=#dom-workers-and-storage.Apr 7 2020, 9:28 AM
• sg updated this revision to Diff 256441.Apr 7 2020, 11:13 AM
• sg edited the summary of this revision. (Show Details)
Harbormaster completed remote builds in B181003: Diff 256441.Apr 7 2020, 11:13 AM
• sg updated this revision to Diff 256573.Apr 7 2020, 1:25 PM
Harbormaster completed remote builds in B181090: Diff 256573.Apr 7 2020, 1:25 PM
reviewbot added a subscriber: reviewbot.Apr 7 2020, 2:00 PM

The analysis task source-test-coverity-coverity failed, but we could not detect any issue.
Please check this task manually.

If you see a problem in this automated review, please report it here.

• sg updated this revision to Diff 256605.Apr 7 2020, 2:01 PM
Harbormaster completed remote builds in B181113: Diff 256605.Apr 7 2020, 2:01 PM
• sg updated this revision to Diff 258339.Apr 9 2020, 3:02 PM
Harbormaster completed remote builds in B182332: Diff 258339.Apr 9 2020, 3:02 PM
• perry added a reviewer: • perry.Apr 22 2020, 5:04 AM
• perry accepted this revision.Apr 22 2020, 5:06 AM
This revision is now accepted and ready to land.Apr 22 2020, 5:06 AM
ttung added a subscriber: ttung.Apr 22 2020, 7:37 AM
ttung added inline comments.
dom/cache/AutoUtils.cpp
488

I think changing the parameter type to a plain reference is doable and it's what we should do based on our guideline. The reason why it is asserted is probably because the code below starts to access the aStreamList.

dom/cache/Manager.cpp
1762–1763

The answer is we don't need to create it for CacheDeleteAction can you file a follow-up bug for that?

1808–1809

Same as above.

• sg marked 3 inline comments as done.May 11 2020, 10:39 AM
• sg added inline comments.
dom/cache/AutoUtils.cpp
488

Ok, I changed that now in this patch. Looks much better now :)

dom/cache/Manager.cpp
1762–1763

I changed that in this patch now.

• sg updated this revision to Diff 275826.May 11 2020, 10:45 AM
• sg marked 2 inline comments as done.
Harbormaster completed remote builds in B194793: Diff 275826.May 11 2020, 10:45 AM
• sg updated this revision to Diff 275855.May 11 2020, 12:11 PM
Harbormaster completed remote builds in B194816: Diff 275855.May 11 2020, 12:11 PM
Closed by commit rMOZILLACENTRALc1672bc9a695: Bug 1627892 - Make StreamList derive from SafeRefCounted. r=dom-workers-and… (authored by • sg). · Explain WhyMay 11 2020, 12:19 PM
This revision was automatically updated to reflect the committed changes.
• sg added a commit: rMOZILLACENTRALc1672bc9a695: Bug 1627892 - Make StreamList derive from SafeRefCounted. r=dom-workers-and….

Revision Contents
Changeset List

Diff 275867

View Options

dom/cache/AutoUtils.h

Loading...
View Options

dom/cache/AutoUtils.cpp

Loading...
View Options

dom/cache/CacheOpParent.h

Loading...
View Options

dom/cache/CacheOpParent.cpp

Loading...
View Options

dom/cache/CacheStreamControlParent.h

Loading...
View Options

dom/cache/CacheStreamControlParent.cpp

Loading...
View Options

dom/cache/Manager.h

Loading...
View Options

dom/cache/Manager.cpp

Loading...
View Options

dom/cache/StreamList.h

Loading...
View Options

dom/cache/StreamList.cpp

Loading...
Privacy · Cookies · Legal