Page MenuHomePhabricator

Bug 1627892 - Make Context derive from SafeRefCounted. r=#dom-workers-and-storage
ClosedPublic

Authored by sg on Apr 7 2020, 9:26 AM.

Diff Detail

Repository
rMOZILLACENTRAL mozilla-central
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".
phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".
phab-bot removed a project: secure-revision.

The analysis task source-test-coverity-coverity failed, but we could not detect any issue.
Please check this task manually.

If you see a problem in this automated review, please report it here.

sg edited the summary of this revision. (Show Details)

The analysis task source-test-coverity-coverity failed, but we could not detect any issue.
Please check this task manually.

If you see a problem in this automated review, please report it here.

This revision is now accepted and ready to land.Apr 22 2020, 5:04 AM

Code analysis found 1 defect in the diff 275824:

  • 1 defect found by clang-format

You can run this analysis locally with:

  • ./mach clang-format -s -p dom/cache/Manager.cpp (C/C++)

For your convenience, here is a patch that fixes all the clang-format defects (use it in your repository with hg import or git apply -p0).

If you see a problem in this automated review, please report it here.

You can view these defects on the code-review frontend and on Treeherder.