Page MenuHomePhabricator
Differential D69945

Bug 1627892 - Replace custom AutoLock by BaseAutoLock. r=#dom-workers-and-storage
ClosedPublic
Actions

Authored by • sg on Apr 7 2020, 8:58 AM.

Details

Reviewers
ttung
Group Reviewers
Restricted Project
Commits
rMOZILLACENTRALbd4efe76e01e: Bug 1627892 - Replace custom AutoLock by BaseAutoLock. r=ttung
Bugzilla Bug ID
1627892

Diff Detail

Repository
rMOZILLACENTRAL mozilla-central
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

• sg created this revision.Apr 7 2020, 8:58 AM
Herald added a project: secure-revision. · View Herald TranscriptApr 7 2020, 8:58 AM
Harbormaster completed remote builds in B180939: Diff 256355.Apr 7 2020, 8:58 AM
phab-bot requested review of this revision.Apr 7 2020, 8:58 AM
phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".
phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".
phab-bot removed a project: secure-revision.
• sg added a parent revision: D61233: Bug 1623278 - Create SafeRefCounted base class that is initialized with a refcount of 1 and can only be instantiated via MakeSafeRefPtr. r=#dom-workers-and-storage.Apr 7 2020, 9:21 AM
• sg updated this revision to Diff 256374.Apr 7 2020, 9:25 AM
Harbormaster completed remote builds in B180954: Diff 256374.Apr 7 2020, 9:25 AM
• sg added a child revision: D69956: Bug 1627892 - Make Manager derive from SafeRefCounted. r=#dom-workers-and-storage.Apr 7 2020, 9:26 AM
• sg added a parent revision: D69978: Bug 1627918 - Make dom/cache build outside unified build environment. r=#dom-workers-and-storage.Apr 7 2020, 1:21 PM
• sg updated this revision to Diff 256565.Apr 7 2020, 1:22 PM
Harbormaster completed remote builds in B181082: Diff 256565.Apr 7 2020, 1:22 PM
reviewbot added a subscriber: reviewbot.Apr 7 2020, 1:49 PM

The analysis task source-test-coverity-coverity failed, but we could not detect any issue.
Please check this task manually.

If you see a problem in this automated review, please report it here.

• sg updated this revision to Diff 256601.Apr 7 2020, 1:58 PM
Harbormaster completed remote builds in B181109: Diff 256601.Apr 7 2020, 1:58 PM
• sg updated this revision to Diff 258335.Apr 9 2020, 2:59 PM
Harbormaster completed remote builds in B182328: Diff 258335.Apr 9 2020, 2:59 PM
ttung accepted this revision as: ttung.Apr 15 2020, 7:33 AM
ttung added subscribers: asuth, ttung.

Thanks for replacing CacheChild::AutoLock to BaseAutoLock so that we can reuse the similar code! I think @asuth should give it another look.

This revision is now accepted and ready to land.Apr 15 2020, 7:33 AM
• sg removed a parent revision: D69978: Bug 1627918 - Make dom/cache build outside unified build environment. r=#dom-workers-and-storage.Apr 17 2020, 10:34 AM
• sg removed a parent revision: D61233: Bug 1623278 - Create SafeRefCounted base class that is initialized with a refcount of 1 and can only be instantiated via MakeSafeRefPtr. r=#dom-workers-and-storage.May 7 2020, 3:10 PM
• sg updated this revision to Diff 275822.May 11 2020, 10:41 AM
Harbormaster completed remote builds in B194789: Diff 275822.May 11 2020, 10:41 AM
• sg updated this revision to Diff 275851.May 11 2020, 12:08 PM
Harbormaster completed remote builds in B194812: Diff 275851.May 11 2020, 12:08 PM
Closed by commit rMOZILLACENTRALbd4efe76e01e: Bug 1627892 - Replace custom AutoLock by BaseAutoLock. r=ttung (authored by • sg). · Explain WhyMay 11 2020, 12:19 PM
This revision was automatically updated to reflect the committed changes.
• sg added a commit: rMOZILLACENTRALbd4efe76e01e: Bug 1627892 - Replace custom AutoLock by BaseAutoLock. r=ttung.

Revision Contents
Changeset List

PathSize
dom/
cache/
16 lines
13 lines

Diff 275863

View Options

dom/cache/Cache.cpp

Loading...
View Options

dom/cache/CacheChild.h

Loading...
Privacy · Cookies · Legal