Attachment 202647 Details for Bug 38756 – Patch

[patch] Patch

bug-38756-20130522224737.patch (text/plain), 2.35 KB, created by Brent Fulgham on 2013-05-22 22:48:49 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Brent Fulgham

Created: 2013-05-22 22:48:49 PDT

Size: 2.35 KB

patch

obsolete

>Index: Tools/ChangeLog
>===================================================================
>--- Tools/ChangeLog	(revision 150569)
>+++ Tools/ChangeLog	(working copy)
>@@ -1,3 +1,19 @@
>+2013-05-22  Brent Fulgham  <bfulgham@webkit.org>
>+
>+        [Windows] Update new-run-webkit-tests for Windows port.
>+        https://bugs.webkit.org/show_bug.cgi?id=38756
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * Scripts/new-run-webkit-httpd:
>+        (run): Switch from 'chromium' to 'win'
>+        * Scripts/webkitpy/port/win.py:
>+        (WinPort): Add support methods for lighttpd server.
>+        (WinPort._uses_apache):
>+        (WinPort._path_to_lighttpd):
>+        (WinPort._path_to_lighttpd_modules):
>+        (WinPort._path_to_lighttpd_php):
>+
> 2013-05-22  Ryosuke Niwa  <rniwa@webkit.org>
> 
>         REGRESSION(r150491): WebKit2.DOMWindowExtensionNoCache fails
>Index: Tools/Scripts/new-run-webkit-httpd
>===================================================================
>--- Tools/Scripts/new-run-webkit-httpd	(revision 150562)
>+++ Tools/Scripts/new-run-webkit-httpd	(working copy)
>@@ -61,7 +61,7 @@ def run(options):
>             raise 'Specifying port requires also a root.'
>         host = Host()
>         # FIXME: Make this work with other ports as well.
>-        port_obj = host.port_factory.get(port_name='chromium', options=options)
>+        port_obj = host.port_factory.get(port_name='win', options=options)
>         httpd = http_server.Lighttpd(port_obj,
>                                      tempfile.gettempdir(),
>                                      port=options.port,
>Index: Tools/Scripts/webkitpy/port/win.py
>===================================================================
>--- Tools/Scripts/webkitpy/port/win.py	(revision 150562)
>+++ Tools/Scripts/webkitpy/port/win.py	(working copy)
>@@ -98,3 +98,21 @@ class WinPort(ApplePort):
>         if not match_object:
>             return None
>         return match_object.group('features_string').split(' ')
>+
>+    #
>+    # PROTECTED ROUTINES
>+    #
>+    # The routines below should only be called by routines in this class
>+    # or any of its subclasses.
>+    #
>+    def _uses_apache(self):
>+        return False
>+
>+    def _path_to_lighttpd(self):
>+        return "/usr/sbin/lighttpd"
>+
>+    def _path_to_lighttpd_modules(self):
>+        return "/usr/lib/lighttpd"
>+
>+    def _path_to_lighttpd_php(self):
>+        return "/usr/bin/php-cgi"

Actions: View | Formatted Diff | Diff

Attachments on bug 38756: 55389 | 82890 | 87818 | 202647 | 202746