Attachment 185656 Details for Bug 108416 – Patch

[patch] Patch

bug-108416-20130130185212.patch (text/plain), 4.33 KB, created by Dirk Pranke on 2013-01-30 18:55:27 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Dirk Pranke

Created: 2013-01-30 18:55:27 PST

Size: 4.33 KB

patch

obsolete

>Subversion Revision: 141337
>diff --git a/Tools/ChangeLog b/Tools/ChangeLog
>index 7acec1c118cba9459ff008d0730d1835ea8d125e..9f70a1fcee66a7d22fc29747be03933767fd9b49 100644
>--- a/Tools/ChangeLog
>+++ b/Tools/ChangeLog
>@@ -1,3 +1,17 @@
>+2013-01-30  Dirk Pranke  <dpranke@chromium.org>
>+
>+        consider adding a platform/mac-wk1 directory
>+        https://bugs.webkit.org/show_bug.cgi?id=108416
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Work in progress patch. Tests still fail. Do not land!
>+
>+        * Scripts/webkitpy/layout_tests/port/base.py:
>+        (Port._wk1_port_name):
>+        * Scripts/webkitpy/layout_tests/port/mac.py:
>+        (MacPort.default_baseline_search_path):
>+
> 2013-01-30  Sheriff Bot  <webkit.review.bot@gmail.com>
> 
>         Unreviewed, rolling out r141205.
>diff --git a/Tools/Scripts/webkitpy/layout_tests/port/base.py b/Tools/Scripts/webkitpy/layout_tests/port/base.py
>index 045c6023bf107ae0be1dcffad62aef94e444b2f6..e22c5997b699218370bbf77bdc95fe40235b96f2 100644
>--- a/Tools/Scripts/webkitpy/layout_tests/port/base.py
>+++ b/Tools/Scripts/webkitpy/layout_tests/port/base.py
>@@ -1547,6 +1547,9 @@ class Port(object):
>         # except for Qt because WebKit2 is only supported by Qt 5.0 (therefore: qt-5.0-wk2).
>         return "%s-wk2" % self.port_name
> 
>+    def _wk1_port_name(self):
>+        return "%s-wk1" % self.port_name
>+
> 
> class VirtualTestSuite(object):
>     def __init__(self, name, base, args, tests=None):
>diff --git a/Tools/Scripts/webkitpy/layout_tests/port/mac.py b/Tools/Scripts/webkitpy/layout_tests/port/mac.py
>index 30b3255dbd68c7609d54fa3b8ff163c08c7ca668..9466d35a9eeb1e840321d81c57966858f1b15dcf 100644
>--- a/Tools/Scripts/webkitpy/layout_tests/port/mac.py
>+++ b/Tools/Scripts/webkitpy/layout_tests/port/mac.py
>@@ -80,6 +80,8 @@ class MacPort(ApplePort):
>             fallback_names = self.VERSION_FALLBACK_ORDER[self.VERSION_FALLBACK_ORDER.index(name):-1] + [self.port_name]
>         if self.get_option('webkit_test_runner'):
>             fallback_names = [self._wk2_port_name(), 'wk2'] + fallback_names
>+        else:
>+            fallback_names = [self._wk1_port_name()] + fallback_names
>         return map(self._webkit_baseline_path, fallback_names)
> 
>     def expectations_files(self):
>diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
>index 67346a22887eea3ca1f0b1f5064c7558c14f4d07..3bb464d508beddcf47196b0feaf19099f891a4bf 100644
>--- a/LayoutTests/ChangeLog
>+++ b/LayoutTests/ChangeLog
>@@ -1,3 +1,12 @@
>+2013-01-30  Dirk Pranke  <dpranke@chromium.org>
>+
>+        consider adding a platform/mac-wk1 directory
>+        https://bugs.webkit.org/show_bug.cgi?id=108416
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * platform/mac-wk1/TestExpectations: Added.
>+
> 2013-01-30  Tony Chang  <tony@chromium.org>
> 
>         [Chromium] Enable textarea resize corner for tests
>diff --git a/LayoutTests/platform/mac-wk1/TestExpectations b/LayoutTests/platform/mac-wk1/TestExpectations
>new file mode 100644
>index 0000000000000000000000000000000000000000..e40670e12512c41106be691f41f81a2ac723f512
>--- /dev/null
>+++ b/LayoutTests/platform/mac-wk1/TestExpectations
>@@ -0,0 +1,40 @@
>+# This file should contain entries for expectations that are specific
>+# to the Apple Mac port running the WebKit1 variant
>+
>+###### This file has four sections. When adding new tests, make sure to
>+###### add to the right section:
>+
>+### (1) Classified failures with bug reports
>+### (2) Classified failures without bug reports (yet)
>+### (3) Unclassified failures
>+### (4) Features that are not supported in WebKit1 and likely never will be
>+
>+
>+########################################
>+### START OF (1) Classified failures with bug reports
>+
>+
>+### END OF (1) Classified failures with bug reports
>+########################################
>+
>+
>+########################################
>+### START OF (2) Classified failures without bug reports (yet)
>+
>+### END OF (2) Classified failures without bug reports (yet)
>+########################################
>+
>+
>+########################################
>+### START OF (3) Unclassified failures
>+
>+
>+### END OF (3) Unclassified failures
>+########################################
>+
>+
>+########################################
>+### START OF (4) Features that are not supported in WebKit1 and likely never will be
>+
>+### END OF (4) Features that are not supported in WebKit1 and likely never will be
>+########################################

Actions: View | Formatted Diff | Diff

Attachments on bug 108416: 185656