Attachment 12204 Details for Bug 12089 – Proposed fix

[patch] Proposed fix

12089patch.txt (text/plain), 1.24 KB, created by Brady Eidson on 2007-01-03 17:35:57 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Brady Eidson

Created: 2007-01-03 17:35:57 PST

Size: 1.24 KB

patch

obsolete

>Index: ChangeLog
>===================================================================
>--- ChangeLog	(revision 18566)
>+++ ChangeLog	(working copy)
>@@ -1,3 +1,12 @@
>+2007-01-03  Brady Eidson  <beidson@apple.com>
>+
>+        Reviewed by Mark Rowe
>+
>+        Fixes http://bugs.webkit.org/show_bug.cgi?id=12089
>+
>+        * loader/FrameLoader.cpp:
>+        (WebCore::FrameLoader::updateHistoryForCommit): Null check the documentLoader
>+
> 2007-01-03  David Hyatt  <hyatt@apple.com>
> 
>         Relax the display type restriction a little bit for generated content inside
>Index: loader/FrameLoader.cpp
>===================================================================
>--- loader/FrameLoader.cpp	(revision 18566)
>+++ loader/FrameLoader.cpp	(working copy)
>@@ -3071,7 +3071,7 @@
> #endif
>     FrameLoadType type = loadType();
>     if (isBackForwardLoadType(type) ||
>-        (type == FrameLoadTypeReload && !documentLoader()->unreachableURL().isEmpty())) {
>+        (type == FrameLoadTypeReload && documentLoader() && !documentLoader()->unreachableURL().isEmpty())) {
>         // Once committed, we want to use current item for saving DocState, and
>         // the provisional item for restoring state.
>         // Note previousItem must be set before we close the URL, which will

Flags:

mrowe: review+

Actions: View | Formatted Diff | Diff

Attachments on bug 12089: 12204