Debian Bug report logs - #970247
lintian: debian-changelog-has-wrong-day-of-week false negative regression

version graph

Package: lintian; Maintainer for lintian is Debian Lintian Maintainers <[email protected]>; Source for lintian is src:lintian (PTS, buildd, popcon).

Reported by: Axel Beckert <[email protected]>

Date: Sun, 13 Sep 2020 17:45:02 UTC

Severity: normal

Found in version lintian/2.94.0

Reply or subscribe to this bug.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to [email protected], [email protected], [email protected], Debian Lintian Maintainers <[email protected]>:
Bug#970247; Package lintian. (Sun, 13 Sep 2020 17:45:03 GMT) (full text, mbox, link).


Acknowledgement sent to Axel Beckert <[email protected]>:
New Bug report received and forwarded. Copy sent to [email protected], [email protected], Debian Lintian Maintainers <[email protected]>. (Sun, 13 Sep 2020 17:45:04 GMT) (full text, mbox, link).


Message #5 received at [email protected] (full text, mbox, reply):

From: Axel Beckert <[email protected]>
To: Debian Bug Tracking System <[email protected]>
Subject: lintian: debian-changelog-has-wrong-day-of-week false negative regression
Date: Sun, 13 Sep 2020 19:42:57 +0200
Package: lintian
Version: 2.94.0
Severity: normal

Hi,

https://salsa.debian.org/lynx-team/lynx/-/merge_requests/1 by
@janitor-bot made me aware of two dates in lynx's debian/changelog (as
of the just uploaded 2.9.0dev.6-1) having a wrong week day. According to
"ccal" these weekdays are indeed wrong. (See below.)

But neither the current Lintian in unstable (2.94.0) nor the lintian
version in Buster (2.15.0) emits that tag. What I see on Debian
Unstable:

$ lintian /var/cache/pbuilder/result/lynx_2.9.0dev.6-1_amd64.changes
I: lynx source: patch-not-forwarded-upstream debian/patches/21_do_not_strip_-g.diff
I: lynx source: patch-not-forwarded-upstream debian/patches/30_build_path_in_binary.diff
I: lynx source: upstream-metadata-missing-repository
$ egrep -v '^#|^$' ~/.lintianrc
display-experimental = yes
display-level = >=pedantic
color = always
suppress-tags=debian-news-entry-uses-asterisk
$

But some lintian version in between (around 2020-05-09) must have
emitted it twice, otherwise lintian-brush/Lintian-Janitor wouldn't have
found it and fixed it in the above mentioned merge request.

Manually checking the date lines mentioned in the merge request confirms
that the weekdays are indeed wrong:

 -- Atsuhito KOHDA <[email protected]>  Sun, 19 Dec 2009 20:04:44 +0900

$ ccal 12 2009

     December 2009     
 Mo Tu We Th Fr Sa Su   
     1  2  3  4  5  6   
  7  8  9 10 11 12 13   
 14 15 16 17 18 19 20   
 21 22 23 24 25 26 27   
 28 29 30 31            

(2009-12-19 was a Sunday)

 -- Atsuhito KOHDA <[email protected]>  Thu,  10 May 2004 13:22:29 +0900

$ ccal 5 2004

       May 2004        
 Mo Tu We Th Fr Sa Su   
                 1  2   
  3  4  5  6  7  8  9   
 10 11 12 13 14 15 16   
 17 18 19 20 21 22 23   
 24 25 26 27 28 29 30   
 31                     

(2004-05-10 was a Monday.)

-- System Information:
Debian Release: bullseye/sid
  APT prefers unstable
  APT policy: (990, 'unstable'), (980, 'unstable-debug'), (600, 'testing'), (111, 'buildd-unstable'), (111, 'buildd-experimental'), (110, 'experimental'), (105, 'experimental-debug')
Architecture: amd64 (x86_64)

Kernel: Linux 5.7.0-2-amd64 (SMP w/2 CPU threads)
Locale: LANG=C.UTF-8, LC_CTYPE=C.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages lintian depends on:
ii  binutils                        2.35-3
ii  bzip2                           1.0.8-4
ii  diffstat                        1.63-1
ii  dpkg                            1.20.5
ii  dpkg-dev                        1.20.5
ii  file                            1:5.38-5
ii  gettext                         0.19.8.1-10
ii  gpg                             2.2.20-1
ii  intltool-debian                 0.35.0+20060710.5
ii  libapt-pkg-perl                 0.1.36+b3
ii  libarchive-zip-perl             1.68-1
ii  libcapture-tiny-perl            0.48-1
ii  libclass-xsaccessor-perl        1.19-3+b5
ii  libclone-perl                   0.45-1
ii  libconfig-tiny-perl             2.24-1
ii  libcpanel-json-xs-perl          4.23-1
ii  libdata-dpath-perl              0.58-1
ii  libdata-validate-domain-perl    0.10-1
ii  libdevel-size-perl              0.83-1+b1
ii  libdigest-sha-perl              6.02-1+b2
ii  libdpkg-perl                    1.20.5
ii  libemail-address-xs-perl        1.04-1+b2
ii  libfile-basedir-perl            0.08-1
ii  libfile-find-rule-perl          0.34-1
ii  libfont-ttf-perl                1.06-1
ii  libhtml-html5-entities-perl     0.004-1
ii  libipc-run3-perl                0.048-2
ii  libjson-maybexs-perl            1.004002-1
ii  liblist-compare-perl            0.55-1
ii  liblist-moreutils-perl          0.416-1+b5
ii  liblist-utilsby-perl            0.11-1
ii  libmoo-perl                     2.004000-1
ii  libmoox-aliases-perl            0.001006-1
ii  libnamespace-clean-perl         0.27-1
ii  libpath-tiny-perl               0.114-1
ii  libperlio-gzip-perl             0.19-1+b6
ii  libproc-processtable-perl       0.59-2
ii  libsereal-decoder-perl          4.018+ds-1
ii  libsereal-encoder-perl          4.018+ds-1
ii  libtext-glob-perl               0.11-1
ii  libtext-levenshteinxs-perl      0.03-4+b7
ii  libtext-markdown-discount-perl  0.12-1
ii  libtext-xslate-perl             3.5.8-1
ii  libtime-duration-perl           1.21-1
ii  libtime-moment-perl             0.44-1+b2
ii  libtimedate-perl                2.3300-1
ii  libtry-tiny-perl                0.30-1
ii  libtype-tiny-perl               1.010006-1
ii  libunicode-utf8-perl            0.62-1+b1
ii  liburi-perl                     1.76-2
ii  libxml-libxml-perl              2.0134+dfsg-2
ii  libyaml-libyaml-perl            0.82+repack-1
ii  lzip                            1.21-8
ii  lzop                            1.04-1
ii  man-db                          2.9.3-2
ii  patchutils                      0.4.2-1
ii  perl [libdigest-sha-perl]       5.30.3-4
ii  t1utils                         1.41-4
ii  unzip                           6.0-25
ii  xz-utils                        5.2.4-1+b1

lintian recommends no packages.

Versions of packages lintian suggests:
ii  binutils-multiarch     2.35-3
ii  libtext-template-perl  1.59-1

-- no debconf information



Information forwarded to [email protected], Debian Lintian Maintainers <[email protected]>:
Bug#970247; Package lintian. (Wed, 16 Sep 2020 21:54:02 GMT) (full text, mbox, link).


Acknowledgement sent to Jelmer Vernooij <[email protected]>:
Extra info received and forwarded to list. Copy sent to Debian Lintian Maintainers <[email protected]>. (Wed, 16 Sep 2020 21:54:02 GMT) (full text, mbox, link).


Message #10 received at [email protected] (full text, mbox, reply):

From: Jelmer Vernooij <[email protected]>
To: [email protected]
Subject: Re: Bug#970247: lintian: debian-changelog-has-wrong-day-of-week false negative regression
Date: Wed, 16 Sep 2020 21:51:11 +0000
On Sun, Sep 13, 2020 at 07:42:57PM +0200, Axel Beckert wrote:
> https://salsa.debian.org/lynx-team/lynx/-/merge_requests/1 by
> @janitor-bot made me aware of two dates in lynx's debian/changelog (as
> of the just uploaded 2.9.0dev.6-1) having a wrong week day. According to
> "ccal" these weekdays are indeed wrong. (See below.)
> 
> But neither the current Lintian in unstable (2.94.0) nor the lintian
> version in Buster (2.15.0) emits that tag. What I see on Debian
> Unstable:
> 
> $ lintian /var/cache/pbuilder/result/lynx_2.9.0dev.6-1_amd64.changes
> I: lynx source: patch-not-forwarded-upstream debian/patches/21_do_not_strip_-g.diff
> I: lynx source: patch-not-forwarded-upstream debian/patches/30_build_path_in_binary.diff
> I: lynx source: upstream-metadata-missing-repository
> $ egrep -v '^#|^$' ~/.lintianrc
> display-experimental = yes
> display-level = >=pedantic
> color = always
> suppress-tags=debian-news-entry-uses-asterisk
> $
> 
> But some lintian version in between (around 2020-05-09) must have
> emitted it twice, otherwise lintian-brush/Lintian-Janitor wouldn't have
> found it and fixed it in the above mentioned merge request.

FWIW lintian-brush will find issues on its own once it runs, so in
this case it may have been an issue that it has always existed in
lintian.

Scheduling in the janitor happens based on the issues that
lintian identifies, but lintian-brush subsequently edits the files
on its own accord.

I'm working to introduce more cross-checking (verifying that
when lintian-brush claimed it fixed an issue, it was actually
an issue that lintian reported), which would allow us to bugs
like this as well as in the other direction (when lintian-brush
claims to fix things that aren't actually a problem).

Cheers,

Jelmer



Send a report that this bug log contains spam.


Debian bug tracking system administrator <[email protected]>. Last modified: Sun Sep 22 09:16:49 2024; Machine Name: buxtehude

Debian Bug tracking system

Debbugs is free software and licensed under the terms of the GNU Public License version 2. The current version can be obtained from https://bugs.debian.org/debbugs-source/.

Copyright © 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson, 2005-2017 Don Armstrong, and many other contributors.