Debian Bug report logs - #1022246
device-tree-compiler: FTBFS on hppa - assembler issues

Reply or subscribe to this bug.

Display info messages

Message #5 received at [email protected] (full text, mbox, reply):

From: John David Anglin <[email protected]>

To: Debian Bug Tracking System <[email protected]>

Subject: device-tree-compiler: FTBFS on hppa - assembler issues

Date: Sat, 22 Oct 2022 17:08:03 +0000

[Message part 1 (text/plain, inline)]

Source: device-tree-compiler
Version: 1.6.1-4
Severity: normal
Tags: ftbfs patch

Dear Maintainer,

Build fails here:
 AS tests/trees.o
tests/trees.S: Assembler messages:
tests/trees.S:256: Error: junk at end of line, first unrecognized character is `''
tests/trees.S:257: Error: junk at end of line, first unrecognized character is `''
tests/trees.S:258: Error: junk at end of line, first unrecognized character is `''
tests/trees.S:219: Error: invalid operands (*UND* and .data sections) for `-'

The GNU assembler on hppa differs in a number of ways with the assembler
on other architectures:

1) The end-of-line character is `!'. `;' introduces a comment.
2) The `.string' directive doesn't add a null termination character.
3) It is strict about the format for characters and junk at end of line.

With the attached patch, the device-tree-compiler package builds successfully
on hppa:
https://buildd.debian.org/status/fetch.php?pkg=device-tree-compiler&arch=hppa&ver=1.6.1-4&stamp=1666457482&raw=0

Please push upstream and add to debian/patches if okay.

Thanks,
Dave Anglin

-- System Information:
Debian Release: bookworm/sid
  APT prefers buildd-unstable
  APT policy: (500, 'buildd-unstable'), (500, 'unstable')
Architecture: hppa (parisc64)

Kernel: Linux 5.19.16+ (SMP w/4 CPU threads)
Locale: LANG=C, LC_CTYPE=C.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)

[device-tree-compiler-hppa-fix.patch (text/plain, attachment)]

Message #10 received at [email protected] (full text, mbox, reply):

From: Uwe Kleine-König <[email protected]>

To: John David Anglin <[email protected]>, [email protected]

Subject: Re: Bug#1022246: device-tree-compiler: FTBFS on hppa - assembler issues

Date: Fri, 28 Apr 2023 21:33:46 +0200

[Message part 1 (text/plain, inline)]

Control: tag -1 + fixed-upstream

Hello,

On Sat, Oct 22, 2022 at 05:08:03PM +0000, John David Anglin wrote:
> Source: device-tree-compiler
> Version: 1.6.1-4
> Severity: normal
> Tags: ftbfs patch
> 
> Dear Maintainer,
> 
> Build fails here:
>  AS tests/trees.o
> tests/trees.S: Assembler messages:
> tests/trees.S:256: Error: junk at end of line, first unrecognized character is `''
> tests/trees.S:257: Error: junk at end of line, first unrecognized character is `''
> tests/trees.S:258: Error: junk at end of line, first unrecognized character is `''
> tests/trees.S:219: Error: invalid operands (*UND* and .data sections) for `-'
> 

I tried to compile upstream's main branch on hppa and couldn't reproduce
it. I guess it was fixed by

	https://git.kernel.org/pub/scm/utils/dtc/dtc.git/commit/?id=d24cc189dca6148eedf9dc9e2d45144b3851dae0

which is included in v1.7.0.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

[signature.asc (application/pgp-signature, inline)]

Send a report that this bug log contains spam.