| commit | abb27061859ce358313da7aed348ea9094c461ac | [log] [tgz] |
|---|---|---|
| author | David Benjamin <[email protected]> | Fri Nov 15 16:13:13 2024 -0500 |
| committer | Boringssl LUCI CQ <[email protected]> | Mon Nov 18 16:56:01 2024 +0000 |
| tree | aef51d12b7076d242e73021a38a15c78994ba68b | |
| parent | 83fc0d94d7040544480d42db01554f2421cfc081 [diff] |
runner: Remove outdated FragmentClientVersion logic A long time ago, OpenSSL negotiated versions by sniffing at the first few bytes of the ClientHello. It couldn't handle ClientHellos that were so fragmented that the version field was unreadable. When it encountered a ClientHello it couldn't handle, it silently assumed TLS 1.0, which led to CVE-2014-3511. The original fix for that made this case an error instead. But this meant that MaxHandshakeRecordLength had to take care never to trigger this error case in other tests, otherwise it wouldn't exercise what we were trying to exercise. So we addeed some funny logic in https://boringssl-review.googlesource.com/1452. Fast forward many years and BoringSSL no longer negotiates versions this way. We read the whole ClientHello and then act on it. Now fragmenting the first few bytes of the ClientHello behaves the same as any other, and we no longer need to special case it in tests. Change-Id: Id098f1e2066626661113ca4796250feb6cea421b Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/73247 Auto-Submit: David Benjamin <[email protected]> Reviewed-by: Bob Beck <[email protected]> Commit-Queue: David Benjamin <[email protected]>
BoringSSL is a fork of OpenSSL that is designed to meet Google's needs.
Although BoringSSL is an open source project, it is not intended for general use, as OpenSSL is. We don't recommend that third parties depend upon it. Doing so is likely to be frustrating because there are no guarantees of API or ABI stability.
Programs ship their own copies of BoringSSL when they use it and we update everything as needed when deciding to make API changes. This allows us to mostly avoid compromises in the name of compatibility. It works for us, but it may not work for you.
BoringSSL arose because Google used OpenSSL for many years in various ways and, over time, built up a large number of patches that were maintained while tracking upstream OpenSSL. As Google's product portfolio became more complex, more copies of OpenSSL sprung up and the effort involved in maintaining all these patches in multiple places was growing steadily.
Currently BoringSSL is the SSL library in Chrome/Chromium, Android (but it's not part of the NDK) and a number of other apps/programs.
Project links:
To file a security issue, use the Chromium process and mention in the report this is for BoringSSL. You can ignore the parts of the process that are specific to Chromium/Chrome.
There are other files in this directory which might be helpful: