| commit | 03ca65809451c07c860b48b28bde043ec5197b26 | [log] [tgz] |
|---|---|---|
| author | David Benjamin <[email protected]> | Mon Nov 11 16:29:18 2024 -0500 |
| committer | Boringssl LUCI CQ <[email protected]> | Tue Nov 12 22:49:35 2024 +0000 |
| tree | 3d54d7de3144f47e29d82e3f6d80426049ea9c42 | |
| parent | fe552c2c7e6341b0408f76afa9875f4850c90c3c [diff] |
Reject NewSessionTicket messages with empty tickets in TLS 1.3 In TLS 1.2, the ticket field could be empty to indicate the server changed its mind on sending a ticket, having previously committed to sending a NewSessionTicket message a round-trip ago. In TLS 1.3, the server does not commit to sending NewSessionTicket. It can always just not send it. So the ticket field is required to be non-empty. It's important we enforce this on the client because otherwise we produce a mixed up SSL_SESSION object that looks like an ID session (thanks to the placeholder ID field that was added for a still unfixed Envoy bug, see b/200292207). That, in turn, confuses some code in assembling the next ClientHello. The subsequent CL will tighten that up. Update-Note: BoringSSL TLS 1.3 clients will now correctly reject zero-length tickets, rather than letting servers get us into a slightly funny state. Change-Id: I1651e7887f9611ebc44ac54af89c85bf86a9feff Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/73007 Commit-Queue: David Benjamin <[email protected]> Auto-Submit: David Benjamin <[email protected]> Reviewed-by: Adam Langley <[email protected]>
BoringSSL is a fork of OpenSSL that is designed to meet Google's needs.
Although BoringSSL is an open source project, it is not intended for general use, as OpenSSL is. We don't recommend that third parties depend upon it. Doing so is likely to be frustrating because there are no guarantees of API or ABI stability.
Programs ship their own copies of BoringSSL when they use it and we update everything as needed when deciding to make API changes. This allows us to mostly avoid compromises in the name of compatibility. It works for us, but it may not work for you.
BoringSSL arose because Google used OpenSSL for many years in various ways and, over time, built up a large number of patches that were maintained while tracking upstream OpenSSL. As Google's product portfolio became more complex, more copies of OpenSSL sprung up and the effort involved in maintaining all these patches in multiple places was growing steadily.
Currently BoringSSL is the SSL library in Chrome/Chromium, Android (but it's not part of the NDK) and a number of other apps/programs.
Project links:
To file a security issue, use the Chromium process and mention in the report this is for BoringSSL. You can ignore the parts of the process that are specific to Chromium/Chrome.
There are other files in this directory which might be helpful: