NetBSD Problem Report #34742

From [email protected]  Sat Oct  7 13:37:47 2006
Return-Path: <[email protected]>
Received: from mail.netbsd.org (mail.netbsd.org [204.152.190.11])
	by narn.NetBSD.org (Postfix) with ESMTP id 20B8B63B968
	for <[email protected]>; Sat,  7 Oct 2006 13:37:47 +0000 (UTC)
Message-Id: <[email protected]>
Date: Sat,  7 Oct 2006 14:36:42 +0200 (CEST)
From: [email protected]
Reply-To: [email protected]
To: [email protected]
Subject: [mail/postgrey] - missing command in postgrey.sh (1.24)
X-Send-Pr-Version: 3.95

>Number:         34742
>Category:       pkg
>Synopsis:       postgrey rc_file lacks reload command
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    kim
>State:          closed
>Class:          change-request
>Submitter-Id:   net
>Arrival-Date:   Sat Oct 07 13:40:00 +0000 2006
>Closed-Date:    Tue Mar 15 00:08:00 +0000 2011
>Last-Modified:  Tue Mar 15 00:08:00 +0000 2011
>Originator:     Xavier Humbert
>Release:        NetBSD 3.1_RC1
>Organization:
>Environment:
System: NetBSD arnor.groumpf.org 3.1_RC1 NetBSD 3.1_RC1 (XAVIER) #4: Tue Aug 29 00:42:39 CEST 2006 [email protected]:/usr/netbsd-build/obj.i386/sys/arch/i386/compile/XAVIER i386
Architecture: i386
Machine: i386
>Description:
	There is no reload command in /etc/rc.d/postgrey, while the software understands HUP signal for that purpose
	Excerpt from http://isg.ee.ethz.ch/tools/postgrey/pub/Changes 
| * 2004-07-05: version 1.13
|   [...]
|   - reload whitelists on HUP

>How-To-Repeat:
	Nothing, this is a missing feature	
>Fix:
	Just addd 
		extra_commands="reload"
	to the rc_script, rc.subr does the job.

Thanks !

Xav

>Release-Note:

>Audit-Trail:
From: Jukka Salmi <[email protected]>
To: [email protected]
Cc: 
Subject: Re: pkg/34742: [mail/postgrey] - missing command in postgrey.sh (1.24)
Date: Sat, 7 Oct 2006 16:00:55 +0200

 [email protected] wrote:
 > >Fix:
 > 	Just addd 
 > 		extra_commands="reload"
 > 	to the rc_script, rc.subr does the job.

 Thanks for reporting this. I have this change in my local repository
 for some time now. Works as expected, of course.

 While at it, please also add

 	stop_postcmd='rm -f $pidfile'

 to the postgrey rc.d script. Otherwise postgrey complains when being
 restarted (note the last line in the following output):

 	$ /etc/rc.d/postgrey restart
 	Stopping postgrey.
 	Waiting for PIDS: 6249.
 	Starting postgrey.
 	Pid_file "/var/run/postgrey.pid" already exists.  Overwriting!

 Thanks and sorry for abusing this PR... ;-)


 Regards, Jukka

 -- 
 If fifty million people say a foolish thing,
 it is still a foolish thing.

 	Anatole France

Responsible-Changed-From-To: pkg-manager->kim
Responsible-Changed-By: [email protected]
Responsible-Changed-When: Sun, 08 Oct 2006 22:07:30 +0000
Responsible-Changed-Why:
Over to maintainer.


State-Changed-From-To: open->feedback
State-Changed-By: [email protected]
State-Changed-When: Wed, 16 Feb 2011 19:38:31 +0000
State-Changed-Why:
Fixes committed.


From: "Sergey Svishchev" <[email protected]>
To: [email protected]
Cc: 
Subject: PR/34742 CVS commit: pkgsrc/mail/postgrey
Date: Wed, 16 Feb 2011 19:37:50 +0000

 Module Name:	pkgsrc
 Committed By:	shattered
 Date:		Wed Feb 16 19:37:50 UTC 2011

 Modified Files:
 	pkgsrc/mail/postgrey: Makefile
 	pkgsrc/mail/postgrey/files: postgrey.sh

 Log Message:
 PR/34742 -- support "reload" command, remove pidfile after stopping


 To generate a diff of this commit:
 cvs rdiff -u -r1.27 -r1.28 pkgsrc/mail/postgrey/Makefile
 cvs rdiff -u -r1.1.1.1 -r1.2 pkgsrc/mail/postgrey/files/postgrey.sh

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: feedback->closed
State-Changed-By: [email protected]
State-Changed-When: Tue, 15 Mar 2011 00:08:00 +0000
State-Changed-Why:
No feedback received, assuming OK


>Unformatted:

Home	PR Database Search