Issue 6670115: Improve property access with keys that can always be converted into a symbol string.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6670115: Improve property access with keys that can always be converted into a symbol string. (Closed)

Created:
9 years, 8 months ago by fschneider

Modified:
9 years, 6 months ago

Reviewers:
Mads Ager (chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Improve property access with keys that can always be converted into a symbol string. Committed: http://code.google.com/p/v8/source/detail?r=7454

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 1

Created: 9 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -0 lines)			Patch
	M	src/heap.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
	M	src/ic.cc	View	1	1 chunk	+9 lines, -0 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (chromium)

9 years, 8 months ago (2011-03-31 09:41:49 UTC) #2

LGTM

http://codereview.chromium.org/6670115/diff/1003/src/ic.cc
File src/ic.cc (right):

http://codereview.chromium.org/6670115/diff/1003/src/ic.cc#newcode1146
src/ic.cc:1146: // Check for values that can be converted into a symbol.
Could you file a bug report stating that this is put in because Kraken 1.1 is
not released in the web runner. Kraken 1.0 accesses undefined and NaN in arrays
a lot and this speeds it up. We have put it in so people do not make wrong
conclusions based on broken benchmarks. Once the web runner is updated to Kraken
1.1 which does correct array accesses we should get rid of this again.

Expand Messages | Collapse Messages